)]}'
{"specs/liberty/approved/linux_net_refactor.rst":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"6880cc1476947182d15713a5e08b8ed1eb171bbc","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"It would be good to improve code maintainability, readability and portability"},{"line_number":43,"context_line":"by refactoring the linux_net.py module."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Use Cases"},{"line_number":46,"context_line":"----------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af86dd1_70d82254","line":44,"updated":"2015-06-12 16:41:15.000000000","message":"A lot of the current usage of linux_net is from virt/libvirt/vif.py, and the discussion at https://review.openstack.org/#/c/162468/ is talking about deprecating and eventually removing all of the built-in plug/unplug code here.\n\nI imagine that that will make parts of linux_net unused, and hence allow them to be simply deleted.  Hence you might want to postpone any linux_net refactoring work until that has happened - unless you have some other really strong reason for doing it now.","commit_id":"d42f8722a4975a8152db100e26e877c7e4bc7adf"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"6880cc1476947182d15713a5e08b8ed1eb171bbc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"The only type of audience that would benefit from this change is developers"},{"line_number":49,"context_line":"who work with linux_net.py and ones who are looking into extending Nova"},{"line_number":50,"context_line":"with new mechanisms for interface management, firewalling and related."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Project Priority"},{"line_number":53,"context_line":"-----------------"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af86dd1_30b06af4","line":51,"updated":"2015-06-12 16:41:15.000000000","message":"Are people really doing that?  I\u0027d expect new networking-related development to be happening in Neutron, and Nova\u0027s networking capability to remain mostly unchanged from now on.","commit_id":"d42f8722a4975a8152db100e26e877c7e4bc7adf"},{"author":{"_account_id":6509,"name":"Roman Bogorodskiy","email":"rbogorodskiy@mirantis.com","username":"novel"},"change_message_id":"64e6a4ce87a0f4db960ea0f81400f01b9791df19","unresolved":false,"context_lines":[{"line_number":48,"context_line":"The only type of audience that would benefit from this change is developers"},{"line_number":49,"context_line":"who work with linux_net.py and ones who are looking into extending Nova"},{"line_number":50,"context_line":"with new mechanisms for interface management, firewalling and related."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Project Priority"},{"line_number":53,"context_line":"-----------------"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af86dd1_fc798930","line":51,"in_reply_to":"1af86dd1_30b06af4","updated":"2015-06-12 18:05:09.000000000","message":"The final goal would be to make Nova run on FreeBSD. At this point linux_net is the most inflexible bit preventing doing this in a clean way. There\u0027s a post on the mailing list I linked in the reference section of this spec:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-June/066342.html","commit_id":"d42f8722a4975a8152db100e26e877c7e4bc7adf"},{"author":{"_account_id":6509,"name":"Roman Bogorodskiy","email":"rbogorodskiy@mirantis.com","username":"novel"},"change_message_id":"54ec9a5d0423a48a0c0e608c9fbee4a2bdb631ef","unresolved":false,"context_lines":[{"line_number":48,"context_line":"The only type of audience that would benefit from this change is developers"},{"line_number":49,"context_line":"who work with linux_net.py and ones who are looking into extending Nova"},{"line_number":50,"context_line":"with new mechanisms for interface management, firewalling and related."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Project Priority"},{"line_number":53,"context_line":"-----------------"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af86dd1_dcfc8d40","line":51,"in_reply_to":"1af86dd1_5cfe5d6c","updated":"2015-06-12 18:12:39.000000000","message":"That scares people away :-) J\nI\u0027ll update the spec a bit later to explicitly state that.","commit_id":"d42f8722a4975a8152db100e26e877c7e4bc7adf"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"39db5d92f54f9c9789ffc5897eb9386847131371","unresolved":false,"context_lines":[{"line_number":48,"context_line":"The only type of audience that would benefit from this change is developers"},{"line_number":49,"context_line":"who work with linux_net.py and ones who are looking into extending Nova"},{"line_number":50,"context_line":"with new mechanisms for interface management, firewalling and related."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Project Priority"},{"line_number":53,"context_line":"-----------------"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af86dd1_5cfe5d6c","line":51,"in_reply_to":"1af86dd1_fc798930","updated":"2015-06-12 18:08:38.000000000","message":"Ah, that makes sense.  Why not say that upfront in the Problem description above?","commit_id":"d42f8722a4975a8152db100e26e877c7e4bc7adf"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"0d041b5c93c0759939f6ba41416b16bbac922d99","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Proposed change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The proposed appoach would be:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Currently the usage of linux_net in libvirt.vif looks this way:"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_36b11490","line":64,"updated":"2015-06-22 20:57:54.000000000","message":"approach","commit_id":"228c9d63e5788724aa07a112c95e35e67a086fe4"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"92f869d2092e05ec3cb7a06667ede2640517185c","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        nova.netowrk.netdev.linux"},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        class LinuxNetDevDriver(NetDevDriver):"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_0fd986f3","line":125,"updated":"2015-06-15 12:27:29.000000000","message":"Nit: typo here","commit_id":"228c9d63e5788724aa07a112c95e35e67a086fe4"}]}