)]}'
{"specs/liberty/approved/allow-list-all-instances-for-non-admin.rst":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b4659fb27315cffe80c2494d74d45962c72190e8","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The request and response headers, body and possible codes are unchanged from"},{"line_number":65,"context_line":"current behaviour. if the policy.json is setup right, non-admins should be"},{"line_number":66,"context_line":"able to list all servers."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Security impact"},{"line_number":69,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_22198ad7","line":66,"updated":"2015-06-17 14:22:38.000000000","message":"when this query parameter isn\u0027t allow for some user, we should explicitly return error status code.","commit_id":"acf746339cc19c28a239c298e1dd8e2c9a3c3978"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fcccb93fadf3d5f42aaedecd2f2704d4f1f5c0c8","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The request and response headers, body and possible codes are unchanged from"},{"line_number":65,"context_line":"current behaviour. if the policy.json is setup right, non-admins should be"},{"line_number":66,"context_line":"able to list all servers."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Security impact"},{"line_number":69,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_98cec62b","line":66,"in_reply_to":"fa32b979_22198ad7","updated":"2015-06-17 15:49:56.000000000","message":"is this same to what we have now? we should already returned error for user who is not authorized?","commit_id":"acf746339cc19c28a239c298e1dd8e2c9a3c3978"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"960012b41a458dd54d006e7fbef1c49216bfd094","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The request and response headers, body and possible codes are unchanged from"},{"line_number":65,"context_line":"current behaviour. if the policy.json is setup right, non-admins should be"},{"line_number":66,"context_line":"able to list all servers."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Security impact"},{"line_number":69,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_da38bea2","line":66,"in_reply_to":"fa32b979_98cec62b","updated":"2015-06-17 17:35:38.000000000","message":"right now we silently ignore it, and that wrong, given we are updating it, we should return an error if its not allowed.\n\nWe should be clear that there are no changes to previous API versions right?","commit_id":"acf746339cc19c28a239c298e1dd8e2c9a3c3978"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fcccb93fadf3d5f42aaedecd2f2704d4f1f5c0c8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"---------------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"python-novaclient will have to be updated so that it can request the new"},{"line_number":82,"context_line":"microversion when the ``list --all-tenants`` option is used."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Performance Impact"},{"line_number":85,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_78018237","line":82,"updated":"2015-06-17 15:49:56.000000000","message":"should novaclient always use last version (e.g. 2.4) or earliest version (2.1)?\n\nif last version, no need to change?","commit_id":"acf746339cc19c28a239c298e1dd8e2c9a3c3978"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"960012b41a458dd54d006e7fbef1c49216bfd094","unresolved":false,"context_lines":[{"line_number":79,"context_line":"---------------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"python-novaclient will have to be updated so that it can request the new"},{"line_number":82,"context_line":"microversion when the ``list --all-tenants`` option is used."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Performance Impact"},{"line_number":85,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_7a4ad227","line":82,"in_reply_to":"fa32b979_78018237","updated":"2015-06-17 17:35:38.000000000","message":"There is another spec about that, not sure about the link I am afraid.","commit_id":"acf746339cc19c28a239c298e1dd8e2c9a3c3978"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fcccb93fadf3d5f42aaedecd2f2704d4f1f5c0c8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"----------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* Add a new microversion and change"},{"line_number":113,"context_line":"  ```nova/api/openstack/compute/servers.py``` to elevate the context when the"},{"line_number":114,"context_line":"  policy check succeeds."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_78af422a","line":113,"updated":"2015-06-17 15:49:56.000000000","message":"I think it\u0027s\nnova/api/openstack/compute/plugins/v3/servers.py?","commit_id":"acf746339cc19c28a239c298e1dd8e2c9a3c3978"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"af24d618d65ea8f5f923e1fe67694ff1dd3f0e4e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Security impact"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Notifications impact"},{"line_number":85,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa32b979_2512e609","line":82,"updated":"2015-06-17 18:52:56.000000000","message":"There is a security impact, because default policy today allows these calls, and we change what it does in code. So we need probably\n\nUpgradeImpact\n\nand \n\nSecurityImpact \n\nOn this change which includes a default policy change to be admin only.","commit_id":"153c16c0769da6bf0c4f1384d4dd1b4074b14a36"}]}