)]}'
{"specs/liberty/approved/multi-attach-volume.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"84ce7d9eb42f6c70973fa2df65fdba1b2197538d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"snapshot_id\": null,"},{"line_number":100,"context_line":"            \"attachments\": [],"},{"line_number":101,"context_line":"            \"created_at\": \"2012-02-14T20:53:07Z\","},{"line_number":102,"context_line":"            \"multiattach\": \"False\""},{"line_number":103,"context_line":"        },"},{"line_number":104,"context_line":"        {"},{"line_number":105,"context_line":"            \"id\": \"76b8950a-8594-4e5b-8dce-0dfa9c696358\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_4daaa586","line":102,"updated":"2015-06-18 01:29:12.000000000","message":"The following jsonschema defines this type \"boolean\", so here should be\n\n \"multiattach\": false\n\nas json format.","commit_id":"42f661e4579ac44d7e1da0058fbcf609a128ddce"},{"author":{"_account_id":13909,"name":"Chris Gacsal","email":"chris.gacsal@gmail.com","username":"chrisg"},"change_message_id":"9ef5fc38dcd86d5b5a43a3a408375fab5f1419b0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"snapshot_id\": null,"},{"line_number":100,"context_line":"            \"attachments\": [],"},{"line_number":101,"context_line":"            \"created_at\": \"2012-02-14T20:53:07Z\","},{"line_number":102,"context_line":"            \"multiattach\": \"False\""},{"line_number":103,"context_line":"        },"},{"line_number":104,"context_line":"        {"},{"line_number":105,"context_line":"            \"id\": \"76b8950a-8594-4e5b-8dce-0dfa9c696358\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_c585215a","line":102,"in_reply_to":"fa32b979_4daaa586","updated":"2015-06-18 09:10:38.000000000","message":"Done","commit_id":"42f661e4579ac44d7e1da0058fbcf609a128ddce"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"84ce7d9eb42f6c70973fa2df65fdba1b2197538d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            \"snapshot_id\": null,"},{"line_number":113,"context_line":"            \"attachments\": [],"},{"line_number":114,"context_line":"            \"created_at\": \"2012-03-15T19:10:03Z\","},{"line_number":115,"context_line":"            \"multiattach\": \"True\""},{"line_number":116,"context_line":"        }"},{"line_number":117,"context_line":"    ]"},{"line_number":118,"context_line":"  }"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_6dad299a","line":115,"updated":"2015-06-18 01:29:12.000000000","message":"ditto\n\n \"multiattach\": true","commit_id":"42f661e4579ac44d7e1da0058fbcf609a128ddce"},{"author":{"_account_id":13909,"name":"Chris Gacsal","email":"chris.gacsal@gmail.com","username":"chrisg"},"change_message_id":"9ef5fc38dcd86d5b5a43a3a408375fab5f1419b0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            \"snapshot_id\": null,"},{"line_number":113,"context_line":"            \"attachments\": [],"},{"line_number":114,"context_line":"            \"created_at\": \"2012-03-15T19:10:03Z\","},{"line_number":115,"context_line":"            \"multiattach\": \"True\""},{"line_number":116,"context_line":"        }"},{"line_number":117,"context_line":"    ]"},{"line_number":118,"context_line":"  }"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_a57edd67","line":115,"in_reply_to":"fa32b979_6dad299a","updated":"2015-06-18 09:10:38.000000000","message":"Done","commit_id":"42f661e4579ac44d7e1da0058fbcf609a128ddce"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"84ce7d9eb42f6c70973fa2df65fdba1b2197538d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    ]"},{"line_number":118,"context_line":"  }"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Add multiattach flag to request and response for"},{"line_number":121,"context_line":"POST /v2.1/{tenant_id}/os-volumes/{volume_id}. Response has the multiattach"},{"line_number":122,"context_line":"flag in the same form as the reponse example above."},{"line_number":123,"context_line":"Updated JSON schema for the request::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_ed1a99c5","line":120,"updated":"2015-06-18 01:29:12.000000000","message":"I could not understand the usage/purpose of this new flag.\n\nThe response of current \"list/show volume\" API contains attachments parameter like\n\n    \"volumes\": [\n        {\n            \"attachments\": [\n                {\n                    \"device\": \"/\",\n                    \"id\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\",\n                    \"serverId\": \"3912f2b4-c5ba-4aec-9165-872876fe202e\",\n                    \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\"\n                }\n            ],\n\nSo if the volume is shared between multiple instances, I guess it is enough to multiple instances just appear on the parameter.\nIs that wrong?","commit_id":"42f661e4579ac44d7e1da0058fbcf609a128ddce"},{"author":{"_account_id":13909,"name":"Chris Gacsal","email":"chris.gacsal@gmail.com","username":"chrisg"},"change_message_id":"9ef5fc38dcd86d5b5a43a3a408375fab5f1419b0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    ]"},{"line_number":118,"context_line":"  }"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Add multiattach flag to request and response for"},{"line_number":121,"context_line":"POST /v2.1/{tenant_id}/os-volumes/{volume_id}. Response has the multiattach"},{"line_number":122,"context_line":"flag in the same form as the reponse example above."},{"line_number":123,"context_line":"Updated JSON schema for the request::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_45583188","line":120,"in_reply_to":"fa32b979_ed1a99c5","updated":"2015-06-18 09:10:38.000000000","message":"If the volume is attached to multiple vms than you are right.\n\nBut it is not true if there is an volume that was created with multiattach flag, but only being attached to one vm.\nIn this case there is no way to determine that the volume can be attached to multiple vms or not without the multiattach flag.","commit_id":"42f661e4579ac44d7e1da0058fbcf609a128ddce"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4c9218205b0702295387b8a4c8fb1d36d14552cc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Add multiattach flag to response for GET /v2.1/{tenant_id}/os-volumes as well"},{"line_number":84,"context_line":"as for GET /v2.1/{tenant_id}/os-volumes/detail and GET os-volumes/{volume_id}."},{"line_number":85,"context_line":"Example response::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  {"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_9664fce5","line":84,"updated":"2015-06-19 09:36:52.000000000","message":"Sorry if I miss something.\nBut this description doesn\u0027t contain what meaning of new flag \"multiattach\".\n\nWhen I saw this spec at the first time, True of this flag means \"this volume is already attached between multiple instances\".\nbut that was wrong.\n\nSo I think it is nice to rename this flag to represent the meaning more clearly. How about \"multiple_attachable\" or something. I\u0027m not good at English, hope better one.\n\nAnyway, it is necessary to describe the meaning of true/false at least for avoiding misunderstanding like me.","commit_id":"3442ab1188357f82495f03351b19c45c411f0579"},{"author":{"_account_id":13909,"name":"Chris Gacsal","email":"chris.gacsal@gmail.com","username":"chrisg"},"change_message_id":"688936a8a08419d2d547ee0dbe12b08b3029b822","unresolved":false,"context_lines":[{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Add multiattach flag to response for GET /v2.1/{tenant_id}/os-volumes as well"},{"line_number":84,"context_line":"as for GET /v2.1/{tenant_id}/os-volumes/detail and GET os-volumes/{volume_id}."},{"line_number":85,"context_line":"Example response::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  {"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_5c8c557f","line":84,"in_reply_to":"fa32b979_9664fce5","updated":"2015-06-19 10:22:38.000000000","message":"Hi,\nThanks for the comment.\nI\u0027ve added a short description for the purpose of the \"multiattach\" flag.\nI don\u0027t think that we can rename the flag as the cinder use the same naming for this capability and it would be a bit confusing to have different naming for the same thing.","commit_id":"3442ab1188357f82495f03351b19c45c411f0579"}],"specs/mitaka/approved/multi-attach-volume.rst":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"75e911be29d338fa3695f306cbb39be5e855affd","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Add multiattach flag to request and response for"},{"line_number":127,"context_line":"POST /v2.1/{tenant_id}/os-volumes/{volume_id}. Response has the multiattach"},{"line_number":128,"context_line":"flag in the same form as the reponse example above."},{"line_number":129,"context_line":"Updated JSON schema for the request::"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  {"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_76551bf8","line":128,"updated":"2015-08-29 13:51:07.000000000","message":"s/reponse/response/","commit_id":"afde1674d714b734338eba3caefa4b62b0c1f24c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7bcf4ce54e2b5c25a80d6cb66f1042eb14995851","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Add multiattach flag to request and response for"},{"line_number":127,"context_line":"POST /v2.1/{tenant_id}/os-volumes/{volume_id}. Response has the multiattach"},{"line_number":128,"context_line":"flag in the same form as the reponse example above."},{"line_number":129,"context_line":"Updated JSON schema for the request::"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  {"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_616a6e1c","line":128,"in_reply_to":"da20952f_76551bf8","updated":"2015-09-28 10:22:29.000000000","message":"Done in https://review.openstack.org/#/c/212508/","commit_id":"afde1674d714b734338eba3caefa4b62b0c1f24c"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"474f521d978a97188db9cb0386aee575cbb095a7","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"In the libvirt driver, the disk is given a shared SELinux label,"},{"line_number":162,"context_line":"and so that disk has no longer strong sVirt SELinux isolation."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Notifications impact"},{"line_number":165,"context_line":"--------------------"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_3961d405","line":163,"updated":"2015-08-29 16:39:55.000000000","message":"I recommend adding something like the following here: \u0027The OpenStack volume encryption capability may be affected by this feature.  A path to maintain the availability of volume encryption should considered during implementation.\u0027","commit_id":"afde1674d714b734338eba3caefa4b62b0c1f24c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7bcf4ce54e2b5c25a80d6cb66f1042eb14995851","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"In the libvirt driver, the disk is given a shared SELinux label,"},{"line_number":162,"context_line":"and so that disk has no longer strong sVirt SELinux isolation."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Notifications impact"},{"line_number":165,"context_line":"--------------------"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_c161fa3a","line":163,"in_reply_to":"da20952f_3961d405","updated":"2015-09-28 10:22:29.000000000","message":"Done in https://review.openstack.org/#/c/212508/","commit_id":"afde1674d714b734338eba3caefa4b62b0c1f24c"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"5b9dea488b65e57e9d290727881c89b7fc03c583","unresolved":false,"context_lines":[{"line_number":201,"context_line":"-----------"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Primary assignee:"},{"line_number":204,"context_line":"  Krisztian Gacsal"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_5f81dff9","line":204,"range":{"start_line":204,"start_character":2,"end_line":204,"end_character":18},"updated":"2015-09-17 14:51:29.000000000","message":"I don\u0027t think you should change this retrospectively. It\u0027d be better to add yourself as a co-author, see the template.","commit_id":"afde1674d714b734338eba3caefa4b62b0c1f24c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7bcf4ce54e2b5c25a80d6cb66f1042eb14995851","unresolved":false,"context_lines":[{"line_number":201,"context_line":"-----------"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Primary assignee:"},{"line_number":204,"context_line":"  Krisztian Gacsal"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_a15e4674","line":204,"range":{"start_line":204,"start_character":2,"end_line":204,"end_character":18},"in_reply_to":"ba15a1d1_5f81dff9","updated":"2015-09-28 10:22:29.000000000","message":"Done in https://review.openstack.org/#/c/212508/","commit_id":"afde1674d714b734338eba3caefa4b62b0c1f24c"}]}