)]}'
{"specs/liberty/approved/optional-on-shared-storage-flag-in-rebuild-instance.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fca207735504d7cd7f235068748eefb578ae1236","unresolved":false,"context_lines":[{"line_number":47,"context_line":"the target host and as a consequence make the on_shared_store parameter of"},{"line_number":48,"context_line":"the rebuild_instance function of the compute manager optional."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"If the on_share_storage parameter is not proveded then the ompute manager"},{"line_number":51,"context_line":"should call the virt driver instance_on_disk function to check that the"},{"line_number":52,"context_line":"instance is available on disk of the target host of the rebuild."},{"line_number":53,"context_line":"If the instance is available on the disk then it will be used during the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_595aa4f3","line":50,"range":{"start_line":50,"start_character":59,"end_line":50,"end_character":65},"updated":"2015-06-23 14:52:43.000000000","message":"Should be \"compute\" manager","commit_id":"e625b8e68b2839c43ca65f55159bf3217d8854db"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fca207735504d7cd7f235068748eefb578ae1236","unresolved":false,"context_lines":[{"line_number":52,"context_line":"instance is available on disk of the target host of the rebuild."},{"line_number":53,"context_line":"If the instance is available on the disk then it will be used during the"},{"line_number":54,"context_line":"rebuild. This is the same behavior as the case when the caller provides"},{"line_number":55,"context_line":"the on_shared_storage with vaule True to the rebuild_instance."},{"line_number":56,"context_line":"If the instance is not available on the disk then it will be recreated from"},{"line_number":57,"context_line":"the original image. This is the same behavior as the case when the caller"},{"line_number":58,"context_line":"provides on_shared_storage with value False to the rebuild_instance."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_390c80eb","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":32},"updated":"2015-06-23 14:52:43.000000000","message":"Should be \"value\"","commit_id":"e625b8e68b2839c43ca65f55159bf3217d8854db"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fca207735504d7cd7f235068748eefb578ae1236","unresolved":false,"context_lines":[{"line_number":58,"context_line":"provides on_shared_storage with value False to the rebuild_instance."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Note that there will be a follow up spec for M release where the related"},{"line_number":61,"context_line":"onSharedStorage flag will be removed from the REST API"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Alternatives"},{"line_number":64,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_59df043a","line":61,"updated":"2015-06-23 14:52:43.000000000","message":"Just to be clear, I don\u0027t think I suggested that it needs to be *removed*. I wonder if there is some amount of safety involved in the operator being *able* to say \"I think this is on shared storage -- if it\u0027s not, please don\u0027t do anything\". At least, since we already have the flag...","commit_id":"e625b8e68b2839c43ca65f55159bf3217d8854db"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"832cabbdc783a3bf1c1dae06685c0ec2ea473b49","unresolved":false,"context_lines":[{"line_number":58,"context_line":"provides on_shared_storage with value False to the rebuild_instance."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Note that there will be a follow up spec for M release where the related"},{"line_number":61,"context_line":"onSharedStorage flag will be removed from the REST API"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Alternatives"},{"line_number":64,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_5c66eb51","line":61,"in_reply_to":"fa32b979_59df043a","updated":"2015-06-24 10:24:50.000000000","message":"John, made the suggestion to drop the flag in a new microversion. I have no hard opinion about making optional or dropping the flag in a new microversion. Let\u0027s discuss this in the other spec proposed for M as this spec will be abandoned.","commit_id":"e625b8e68b2839c43ca65f55159bf3217d8854db"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fca207735504d7cd7f235068748eefb578ae1236","unresolved":false,"context_lines":[{"line_number":113,"context_line":"----------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* Change the compute manager to handle the case when on_shared_storage is None"},{"line_number":116,"context_line":"  in rebuild_instance"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_19941c41","line":116,"updated":"2015-06-23 14:52:43.000000000","message":"So, after reading this spec, I wonder if we should just make this change and drop the spec. It\u0027s just a couple of lines of code as setup before we make the actual change in M.\n\nWhat do other folks think of just doing this and dropping this spec? We could tag the commit against the blueprint that we\u0027re going to actually target in M for clarity..","commit_id":"e625b8e68b2839c43ca65f55159bf3217d8854db"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"832cabbdc783a3bf1c1dae06685c0ec2ea473b49","unresolved":false,"context_lines":[{"line_number":113,"context_line":"----------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* Change the compute manager to handle the case when on_shared_storage is None"},{"line_number":116,"context_line":"  in rebuild_instance"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_7ce2cfa1","line":116,"in_reply_to":"fa32b979_19941c41","updated":"2015-06-24 10:24:50.000000000","message":"I will do this way.","commit_id":"e625b8e68b2839c43ca65f55159bf3217d8854db"}]}