)]}'
{"specs/liberty/approved/use-glance-v2-api.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"52b33da72972d36cc79b0f0c20c931daac8a1432","unresolved":false,"context_lines":[{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Full support for Glance v2 by the Nova Image API is dependent on:"},{"line_number":218,"context_line":"\u003cTODO add link to spec or blueprint for the changes_since API work\u003e"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Testing"},{"line_number":221,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_1a2ce6aa","line":218,"updated":"2015-06-24 10:08:11.000000000","message":"At a minimum we need this link here.","commit_id":"d4d53c236cd153a104e444eb39b64ae16071c478"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1beff45cb72b18a846cd4142c1159d06bc9b1c96","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Glance v2 has moved to CURRENT status and v1 to SUPPORTED in Kilo. Currently"},{"line_number":24,"context_line":"Nova requires access to the Glance v1 API. Glance would like to deprecate"},{"line_number":25,"context_line":"that API, so to help that effort Nova should stop using Glance v1 API."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_3ad96a57","line":23,"updated":"2015-07-03 09:32:08.000000000","message":"Images V2 API moved to CURRENT at September 2012:\ncommit 9ef42887d6083f1a74fee202e7749a297d6b6aa1\nAuthor: Brian Waldon \u003cbcwaldon@gmail.com\u003e\nDate:   Tue Sep 11 16:07:01 2012 -0700\n\n    Update v2.0 API version to CURRENT","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1beff45cb72b18a846cd4142c1159d06bc9b1c96","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* Creating and deleting snapshots in common code."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Before we can stop Nova requiring Glance v1 and fully deprecate the"},{"line_number":44,"context_line":"requirement for Glance v1, we need to remove all the above uses of Glance v1."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Note the current version of Glance v2 does not provide an efficient way to"},{"line_number":47,"context_line":"implement the changes_since parameter that is supported by the current Nova"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_5ac78e63","line":44,"updated":"2015-07-03 09:32:08.000000000","message":"\"we need to remove the hard dependencies of the above...\" We gotta keep both API versions working in parallel still over the deprecation period.","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6b1b3f6dfdc30d17a0e64d9f82f58eaf13fcb35b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* Creating and deleting snapshots in common code."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Before we can stop Nova requiring Glance v1 and fully deprecate the"},{"line_number":44,"context_line":"requirement for Glance v1, we need to remove all the above uses of Glance v1."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Note the current version of Glance v2 does not provide an efficient way to"},{"line_number":47,"context_line":"implement the changes_since parameter that is supported by the current Nova"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_2bf037c8","line":44,"in_reply_to":"ba3cc151_5ac78e63","updated":"2015-07-03 12:45:25.000000000","message":"That is also stated here.","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1beff45cb72b18a846cd4142c1159d06bc9b1c96","unresolved":false,"context_lines":[{"line_number":88,"context_line":"The main bulk of the work is ensuring the Nova Image API contract is"},{"line_number":89,"context_line":"maintained while talking to either Glance v1 API or Glance v2 API."},{"line_number":90,"context_line":"There will be a new configuration value that tells Nova if the configured"},{"line_number":91,"context_line":"Glance URL is for v1 or v2, and it will default to v2."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The second part is looking at another other areas in Nova\u0027s Glance related"},{"line_number":94,"context_line":"modules that doesn\u0027t work with the Glance v2 API."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_3a0aca8a","line":91,"updated":"2015-07-03 09:32:08.000000000","message":"Can we default to v2 \"auto\" if found by version negotiation so that there is no need to bring in new config value just to keep the deployments working that has specifically v2 API turned off.","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6b1b3f6dfdc30d17a0e64d9f82f58eaf13fcb35b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"The main bulk of the work is ensuring the Nova Image API contract is"},{"line_number":89,"context_line":"maintained while talking to either Glance v1 API or Glance v2 API."},{"line_number":90,"context_line":"There will be a new configuration value that tells Nova if the configured"},{"line_number":91,"context_line":"Glance URL is for v1 or v2, and it will default to v2."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The second part is looking at another other areas in Nova\u0027s Glance related"},{"line_number":94,"context_line":"modules that doesn\u0027t work with the Glance v2 API."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_6bd15f22","line":91,"in_reply_to":"ba3cc151_3a0aca8a","updated":"2015-07-03 12:45:25.000000000","message":"So people should already have v2 available, this is more about having they use that.","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1beff45cb72b18a846cd4142c1159d06bc9b1c96","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The virt drivers that don\u0027t support Glance v2 should fail to start when they"},{"line_number":101,"context_line":"are configured with Glance v2, and Log an error so the users can work out"},{"line_number":102,"context_line":"what is happening."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_9a70b60c","line":102,"updated":"2015-07-03 09:32:08.000000000","message":"Seriously ok to default to v2 (as stated above) and break current functionality by doing so?","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6b1b3f6dfdc30d17a0e64d9f82f58eaf13fcb35b","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The virt drivers that don\u0027t support Glance v2 should fail to start when they"},{"line_number":101,"context_line":"are configured with Glance v2, and Log an error so the users can work out"},{"line_number":102,"context_line":"what is happening."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_4bc25b54","line":102,"in_reply_to":"ba3cc151_9a70b60c","updated":"2015-07-03 12:45:25.000000000","message":"The idea is to default to v2 once it works in the gate. we could be more explicit here.","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1beff45cb72b18a846cd4142c1159d06bc9b1c96","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Ideally there would be a common library for both Cinder and Nova to use to"},{"line_number":108,"context_line":"upload and download images, with a stable API, that is maintained by Glance,"},{"line_number":109,"context_line":"similar to Cinder\u0027s brick library. But this is not currently the case, and"},{"line_number":110,"context_line":"we have waited too long for this support to delay this work any further."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_3a664a51","line":107,"updated":"2015-07-03 09:32:08.000000000","message":"Yes, it\u0027s called python-glanceclient, which is developed for this exact purpose.","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6b1b3f6dfdc30d17a0e64d9f82f58eaf13fcb35b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Ideally there would be a common library for both Cinder and Nova to use to"},{"line_number":108,"context_line":"upload and download images, with a stable API, that is maintained by Glance,"},{"line_number":109,"context_line":"similar to Cinder\u0027s brick library. But this is not currently the case, and"},{"line_number":110,"context_line":"we have waited too long for this support to delay this work any further."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_cb83cb01","line":107,"in_reply_to":"ba3cc151_3a664a51","updated":"2015-07-03 12:45:25.000000000","message":"We are strongly moving away from that due to dependency issues. Frankly we don\u0027t really have a proper plan there yet.","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1beff45cb72b18a846cd4142c1159d06bc9b1c96","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"There will be no impact on the REST API contract."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The Nova Image API will now default to proxying requests from Glance v2."},{"line_number":136,"context_line":"However the existing API contract will be maintained."},{"line_number":137,"context_line":"We will ensure the Nova Image API requests (based on current requests to"},{"line_number":138,"context_line":"Glance v1) get translated into requests suitable for Glance v2,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_bad9faf4","line":135,"updated":"2015-07-03 09:32:08.000000000","message":"I didn\u0027t realize Glance is doing requests from the v2 api towards Nova.","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6b1b3f6dfdc30d17a0e64d9f82f58eaf13fcb35b","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"There will be no impact on the REST API contract."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The Nova Image API will now default to proxying requests from Glance v2."},{"line_number":136,"context_line":"However the existing API contract will be maintained."},{"line_number":137,"context_line":"We will ensure the Nova Image API requests (based on current requests to"},{"line_number":138,"context_line":"Glance v1) get translated into requests suitable for Glance v2,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_0b953331","line":135,"in_reply_to":"ba3cc151_bad9faf4","updated":"2015-07-03 12:45:25.000000000","message":"thats a typo.\n\ns/from/to/","commit_id":"59599e99803f4c0555d08157bcf7bc608ea57e44"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"296446aa4e97fd7e73bd4b1aeb9e803880baf103","unresolved":false,"context_lines":[{"line_number":89,"context_line":"done after the support for talking to Glance v1 is dropped in a future release."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The main bulk of the work is ensuring the Nova Image API contract is"},{"line_number":92,"context_line":"maintained while talking to either Glance v1 API or Glance v2 API."},{"line_number":93,"context_line":"There will be a new configuration value that tells Nova if the configured"},{"line_number":94,"context_line":"Glance URL is for v1 or v2, and it will default to v2."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_92e4efac","line":92,"updated":"2015-07-06 08:38:21.000000000","message":"This won\u0027t be guaranteed unless the inconsistencies between Glance v1 and v2 are worked out. For instance, changes-since. There\u0027s already a spec for this case and there\u0027ll hopefully be an implementation. However, there are also some other issues that I had pointed out in my previous patch.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2f3d023fd09728e7f861daee3687c48df652b4c5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"done after the support for talking to Glance v1 is dropped in a future release."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The main bulk of the work is ensuring the Nova Image API contract is"},{"line_number":92,"context_line":"maintained while talking to either Glance v1 API or Glance v2 API."},{"line_number":93,"context_line":"There will be a new configuration value that tells Nova if the configured"},{"line_number":94,"context_line":"Glance URL is for v1 or v2, and it will default to v2."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_df8cbb81","line":92,"in_reply_to":"ba3cc151_92e4efac","updated":"2015-07-06 10:31:52.000000000","message":"This spec depends on changes-since.\n\nThis is my key requirement, that Nova image API stays the same.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"689b7d84f1b403f157f9abbb2bea93f60725e64d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"done after the support for talking to Glance v1 is dropped in a future release."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The main bulk of the work is ensuring the Nova Image API contract is"},{"line_number":92,"context_line":"maintained while talking to either Glance v1 API or Glance v2 API."},{"line_number":93,"context_line":"There will be a new configuration value that tells Nova if the configured"},{"line_number":94,"context_line":"Glance URL is for v1 or v2, and it will default to v2."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_dfe8d7e4","line":92,"in_reply_to":"ba3cc151_df8cbb81","updated":"2015-07-08 02:54:04.000000000","message":"I think we don\u0027t have to depend on the spec of change-since if you guys are comfortable with my solution, see line 609-626 https://review.openstack.org/#/c/144875/34/nova/image/api.py","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"454de7388ed576bf4f60bafeb8b8087b99fe926d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"The main bulk of the work is ensuring the Nova Image API contract is"},{"line_number":92,"context_line":"maintained while talking to either Glance v1 API or Glance v2 API."},{"line_number":93,"context_line":"There will be a new configuration value that tells Nova if the configured"},{"line_number":94,"context_line":"Glance URL is for v1 or v2, and it will default to v2."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The second part is looking at another other areas in Nova\u0027s Glance related"},{"line_number":97,"context_line":"modules that doesn\u0027t work with the Glance v2 API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_22a4d148","line":94,"updated":"2015-07-03 16:06:45.000000000","message":"Why do we need a configuration option? Glance\u0027s version information is fully discoverable already.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"296446aa4e97fd7e73bd4b1aeb9e803880baf103","unresolved":false,"context_lines":[{"line_number":91,"context_line":"The main bulk of the work is ensuring the Nova Image API contract is"},{"line_number":92,"context_line":"maintained while talking to either Glance v1 API or Glance v2 API."},{"line_number":93,"context_line":"There will be a new configuration value that tells Nova if the configured"},{"line_number":94,"context_line":"Glance URL is for v1 or v2, and it will default to v2."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The second part is looking at another other areas in Nova\u0027s Glance related"},{"line_number":97,"context_line":"modules that doesn\u0027t work with the Glance v2 API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_92fb8f47","line":94,"in_reply_to":"ba3cc151_22a4d148","updated":"2015-07-06 08:38:21.000000000","message":"Agreed, this was one of the things the existing refactor kept in mind. In fact, we changed glanceclient to be smart enough to discover the version from the URL.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"689b7d84f1b403f157f9abbb2bea93f60725e64d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"The main bulk of the work is ensuring the Nova Image API contract is"},{"line_number":92,"context_line":"maintained while talking to either Glance v1 API or Glance v2 API."},{"line_number":93,"context_line":"There will be a new configuration value that tells Nova if the configured"},{"line_number":94,"context_line":"Glance URL is for v1 or v2, and it will default to v2."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The second part is looking at another other areas in Nova\u0027s Glance related"},{"line_number":97,"context_line":"modules that doesn\u0027t work with the Glance v2 API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_ffccbb8a","line":94,"in_reply_to":"ba3cc151_92fb8f47","updated":"2015-07-08 02:54:04.000000000","message":"+1","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"296446aa4e97fd7e73bd4b1aeb9e803880baf103","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The virt drivers that don\u0027t support Glance v2 should fail to start when they"},{"line_number":104,"context_line":"are configured with Glance v2, and Log an error so the users can work out"},{"line_number":105,"context_line":"what is happening."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Note, we will only update the default to Glance v2 if the gate is passing,"},{"line_number":108,"context_line":"and all the third party CI systems are passing. We will not deprecate the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_72c04be1","line":105,"updated":"2015-07-06 08:38:21.000000000","message":"I\u0027m not a Nova folk but it would be a real bummer to have some drivers working with v1 and others with v2. This means we won\u0027t be able to fully deprecate v1 anyways. At least not until all virt drivers add support for v2.\n\nIs there a plan/strategy to enforce the above?","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2f3d023fd09728e7f861daee3687c48df652b4c5","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The virt drivers that don\u0027t support Glance v2 should fail to start when they"},{"line_number":104,"context_line":"are configured with Glance v2, and Log an error so the users can work out"},{"line_number":105,"context_line":"what is happening."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Note, we will only update the default to Glance v2 if the gate is passing,"},{"line_number":108,"context_line":"and all the third party CI systems are passing. We will not deprecate the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_5f0d0b36","line":105,"in_reply_to":"ba3cc151_72c04be1","updated":"2015-07-06 10:31:52.000000000","message":"Yeah, this was a poor attempt at saying it might not all get done in one go.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"296446aa4e97fd7e73bd4b1aeb9e803880baf103","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Note, we will only update the default to Glance v2 if the gate is passing,"},{"line_number":108,"context_line":"and all the third party CI systems are passing. We will not deprecate the"},{"line_number":109,"context_line":"Glance v1 support in liberty if we are unable to change the default to"},{"line_number":110,"context_line":"Glance v2. Given the late merging of this spec, it is likely that these"},{"line_number":111,"context_line":"changes will be delayed until the M release, but should everything get done"},{"line_number":112,"context_line":"sooner than expected, we do not want to exclude the possibility of all this"},{"line_number":113,"context_line":"work being completed during liberty."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_1243ff6d","line":110,"updated":"2015-07-06 08:38:21.000000000","message":"Until all drivers are moved to v2, I don\u0027t think we should change the default. Even v2\u0027s responses are different from v1\u0027s for some calls, which means some extra normalization will be required. Unfortunately, this won\u0027t be enough because there are some scripts that don\u0027t even rely on Nova\u0027s glance code but build their own URL\u0027s and use urllib to call Glance.\n\nhttps://github.com/openstack/nova/blob/master/plugins/xenserver/xenapi/etc/xapi.d/plugins/glance","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2f3d023fd09728e7f861daee3687c48df652b4c5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Note, we will only update the default to Glance v2 if the gate is passing,"},{"line_number":108,"context_line":"and all the third party CI systems are passing. We will not deprecate the"},{"line_number":109,"context_line":"Glance v1 support in liberty if we are unable to change the default to"},{"line_number":110,"context_line":"Glance v2. Given the late merging of this spec, it is likely that these"},{"line_number":111,"context_line":"changes will be delayed until the M release, but should everything get done"},{"line_number":112,"context_line":"sooner than expected, we do not want to exclude the possibility of all this"},{"line_number":113,"context_line":"work being completed during liberty."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_bf61b7d5","line":110,"in_reply_to":"ba3cc151_1243ff6d","updated":"2015-07-06 10:31:52.000000000","message":"Maybe. We have defaults that don\u0027t work for drivers already, this is just one more.\n\nPS\nI can describe why the above is needed, its more than a little nasty, and due to being dependent on python24. But lets take that offline.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2c436f3d3b19fd470c550ab011d1d9280e9718a6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Note, we will only update the default to Glance v2 if the gate is passing,"},{"line_number":108,"context_line":"and all the third party CI systems are passing. We will not deprecate the"},{"line_number":109,"context_line":"Glance v1 support in liberty if we are unable to change the default to"},{"line_number":110,"context_line":"Glance v2. Given the late merging of this spec, it is likely that these"},{"line_number":111,"context_line":"changes will be delayed until the M release, but should everything get done"},{"line_number":112,"context_line":"sooner than expected, we do not want to exclude the possibility of all this"},{"line_number":113,"context_line":"work being completed during liberty."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_97b9fa7b","line":110,"in_reply_to":"ba3cc151_bf61b7d5","updated":"2015-07-07 13:11:08.000000000","message":"I\u0027d like to hear that as well ;)","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"296446aa4e97fd7e73bd4b1aeb9e803880baf103","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Ideally there would be a common library for both Cinder and Nova to use to"},{"line_number":119,"context_line":"upload and download images, with a stable API, that is maintained by Glance,"},{"line_number":120,"context_line":"similar to Cinder\u0027s brick library. But this is not currently the case, and"},{"line_number":121,"context_line":"we have waited too long for this support to delay this work any further."},{"line_number":122,"context_line":"However, it is assumed that is library will exist before Nova needs to add"},{"line_number":123,"context_line":"support for the currently planned Glance v2 API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_8de61443","line":120,"updated":"2015-07-06 08:38:21.000000000","message":"No, why?\n\nCinder\u0027s brick library serves different purposes. If anything, I believe this is what glanceclient is for. The separation between glance_store and glanceclient was kept on purpose but we\u0027ve talked about allowing the later to consume the former as soon as there are better security policies in glance-api.\n\nThe problem here is not the lack of a library to reduce the common code between Nova and Cinder but the lack of consistency, integrity and backwards compatibility in glanceclient which helped things like this to happen.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2c436f3d3b19fd470c550ab011d1d9280e9718a6","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Ideally there would be a common library for both Cinder and Nova to use to"},{"line_number":119,"context_line":"upload and download images, with a stable API, that is maintained by Glance,"},{"line_number":120,"context_line":"similar to Cinder\u0027s brick library. But this is not currently the case, and"},{"line_number":121,"context_line":"we have waited too long for this support to delay this work any further."},{"line_number":122,"context_line":"However, it is assumed that is library will exist before Nova needs to add"},{"line_number":123,"context_line":"support for the currently planned Glance v2 API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_779f9603","line":120,"in_reply_to":"ba3cc151_8de61443","updated":"2015-07-07 13:11:08.000000000","message":"++ as mentioned in the last PS.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"689b7d84f1b403f157f9abbb2bea93f60725e64d","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Ideally there would be a common library for both Cinder and Nova to use to"},{"line_number":119,"context_line":"upload and download images, with a stable API, that is maintained by Glance,"},{"line_number":120,"context_line":"similar to Cinder\u0027s brick library. But this is not currently the case, and"},{"line_number":121,"context_line":"we have waited too long for this support to delay this work any further."},{"line_number":122,"context_line":"However, it is assumed that is library will exist before Nova needs to add"},{"line_number":123,"context_line":"support for the currently planned Glance v2 API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_5f892725","line":120,"in_reply_to":"ba3cc151_8de61443","updated":"2015-07-08 02:54:04.000000000","message":"+1\nGiven openstack is  moving to openstack common client, so if we really want to go for a \u0027lib\u0027 to do this, then let\u0027s do it in current glance client instead of creating a new wheel.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"454de7388ed576bf4f60bafeb8b8087b99fe926d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"upload and download images, with a stable API, that is maintained by Glance,"},{"line_number":120,"context_line":"similar to Cinder\u0027s brick library. But this is not currently the case, and"},{"line_number":121,"context_line":"we have waited too long for this support to delay this work any further."},{"line_number":122,"context_line":"However, it is assumed that is library will exist before Nova needs to add"},{"line_number":123,"context_line":"support for the currently planned Glance v2 API."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Dropping Nova\u0027s Image API would make this work a lot simpler."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_022e6da4","line":122,"updated":"2015-07-03 16:06:45.000000000","message":"s/is library/this library/","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"454de7388ed576bf4f60bafeb8b8087b99fe926d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"However, it is assumed that is library will exist before Nova needs to add"},{"line_number":123,"context_line":"support for the currently planned Glance v2 API."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Dropping Nova\u0027s Image API would make this work a lot simpler."},{"line_number":126,"context_line":"However the Image API has become part for Nova\u0027s REST API, and as such, we"},{"line_number":127,"context_line":"should not break our API users by removing this API."},{"line_number":128,"context_line":"It is possible we could drop the API with in a new microversion, and start"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_82103d5a","line":125,"updated":"2015-07-03 16:06:45.000000000","message":"Yep.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"454de7388ed576bf4f60bafeb8b8087b99fe926d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"However the Image API has become part for Nova\u0027s REST API, and as such, we"},{"line_number":127,"context_line":"should not break our API users by removing this API."},{"line_number":128,"context_line":"It is possible we could drop the API with in a new microversion, and start"},{"line_number":129,"context_line":"the deprecation timer for that API, but is not a focus for Liberty."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Another alternative is to do nothing. But that would mean Nova still depends"},{"line_number":132,"context_line":"on the Glance v1 API, so it would either force Glance to keep the v1 API,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_02050d12","line":129,"updated":"2015-07-03 16:06:45.000000000","message":"s/is not/this is not/","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"454de7388ed576bf4f60bafeb8b8087b99fe926d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"A config section would be added that would be applicable for the nova-api,"},{"line_number":181,"context_line":"compute-manager and virt-drivers if applicable. The config option would enable"},{"line_number":182,"context_line":"Nova to choose the api version of Glance to talk to. Default value would be 2"},{"line_number":183,"context_line":"for the reasons described above."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"For existing Glance installations that still just support v1, deployers would"},{"line_number":186,"context_line":"have to set the api version to v1 explicitly."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_40b54e2f","line":183,"updated":"2015-07-03 16:06:45.000000000","message":"I\u0027m -1 on adding new configuration options. We already have the glance_api_servers CONF option. Version information can be discovered from Glance itself. We can do the following:\n\nChange the glance_api_servers CONF option to allow EITHER:\n\na) Force a particular version of Glance to be used by having the glance_api_servers URI(s) contain a version indicator. e.g.:\n\n glance_api_servers \u003d https://images.example.org/v1/\n\nb) Allow the CURRENT version of Glance\u0027s API to be used by Nova by leaving off the version indicator from the URI:\n\n glance_api_servers \u003d https://images.example.org/","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2f3d023fd09728e7f861daee3687c48df652b4c5","unresolved":false,"context_lines":[{"line_number":180,"context_line":"A config section would be added that would be applicable for the nova-api,"},{"line_number":181,"context_line":"compute-manager and virt-drivers if applicable. The config option would enable"},{"line_number":182,"context_line":"Nova to choose the api version of Glance to talk to. Default value would be 2"},{"line_number":183,"context_line":"for the reasons described above."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"For existing Glance installations that still just support v1, deployers would"},{"line_number":186,"context_line":"have to set the api version to v1 explicitly."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_1c2231ba","line":183,"in_reply_to":"ba3cc151_2d9d8859","updated":"2015-07-06 10:31:52.000000000","message":"So I like that alternative, jay has here, that seems better.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2c436f3d3b19fd470c550ab011d1d9280e9718a6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"A config section would be added that would be applicable for the nova-api,"},{"line_number":181,"context_line":"compute-manager and virt-drivers if applicable. The config option would enable"},{"line_number":182,"context_line":"Nova to choose the api version of Glance to talk to. Default value would be 2"},{"line_number":183,"context_line":"for the reasons described above."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"For existing Glance installations that still just support v1, deployers would"},{"line_number":186,"context_line":"have to set the api version to v1 explicitly."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_97d49abd","line":183,"in_reply_to":"ba3cc151_40b54e2f","updated":"2015-07-07 13:11:08.000000000","message":"I\u0027m prefectly fine with this as long as it\u0027s documented properly.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"296446aa4e97fd7e73bd4b1aeb9e803880baf103","unresolved":false,"context_lines":[{"line_number":180,"context_line":"A config section would be added that would be applicable for the nova-api,"},{"line_number":181,"context_line":"compute-manager and virt-drivers if applicable. The config option would enable"},{"line_number":182,"context_line":"Nova to choose the api version of Glance to talk to. Default value would be 2"},{"line_number":183,"context_line":"for the reasons described above."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"For existing Glance installations that still just support v1, deployers would"},{"line_number":186,"context_line":"have to set the api version to v1 explicitly."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_2d9d8859","line":183,"in_reply_to":"ba3cc151_40b54e2f","updated":"2015-07-06 08:38:21.000000000","message":"I\u0027m with Jay here","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"38580415f80cb120767b3b2f87597f9605889b02","unresolved":false,"context_lines":[{"line_number":181,"context_line":"compute-manager and virt-drivers if applicable. The config option would enable"},{"line_number":182,"context_line":"Nova to choose the api version of Glance to talk to. Default value would be 2"},{"line_number":183,"context_line":"for the reasons described above."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"For existing Glance installations that still just support v1, deployers would"},{"line_number":186,"context_line":"have to set the api version to v1 explicitly."},{"line_number":187,"context_line":"Users will also get deprecation warnings, tell them to Upgrade Glance and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_1b8501ac","line":184,"updated":"2015-07-07 20:09:34.000000000","message":"I agree that this recommendation should be included.  Excellent input.","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"296446aa4e97fd7e73bd4b1aeb9e803880baf103","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Full support for Glance v2 by the Nova Image API is dependent on:"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"https://blueprints.launchpad.net/glance/+spec/v2-additional-filtering"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"Testing"},{"line_number":236,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_0dfd246e","line":233,"updated":"2015-07-06 08:38:21.000000000","message":"Can we, eventually, drop Nova\u0027s Image API?","commit_id":"c0efc808558b2156507a98881d4700262779be29"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2f3d023fd09728e7f861daee3687c48df652b4c5","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Full support for Glance v2 by the Nova Image API is dependent on:"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"https://blueprints.launchpad.net/glance/+spec/v2-additional-filtering"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"Testing"},{"line_number":236,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_9c1c0179","line":233,"in_reply_to":"ba3cc151_0dfd246e","updated":"2015-07-06 10:31:52.000000000","message":"It will be some years sadly, partly as its now required by DefCore.\n\nBut thats a separate discussion we have \"officially\" punted until barcelona","commit_id":"c0efc808558b2156507a98881d4700262779be29"}]}