)]}'
{"specs/liberty/approved/split-network-plane-for-live-migration.rst":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"daea8e79a3e4dd6118f2b6db367aa79d3d3d3c40","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Data model impact"},{"line_number":68,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_5f649db7","line":65,"updated":"2015-06-24 10:38:35.000000000","message":"According to the last comment from Daniel I can removed my -1 but at least can you refer the solution as alternative.","commit_id":"f5e05135b02a81cb486091642eebda08760d06a4"}],"specs/mitaka/approved/split-network-plane-for-live-migration.rst":[{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"51f89513fff551337c19a6bd56e61add81f53c95","unresolved":false,"context_lines":[{"line_number":56,"context_line":"remains as it is now."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This spec is focuses on QEMU/KVM driver, the implementation for other drivers"},{"line_number":59,"context_line":"are out of scope."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_abf961ca","line":59,"updated":"2015-08-24 13:26:00.000000000","message":"suggestion:  s/is focuses on/focuses on the/","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"remains as it is now."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This spec is focuses on QEMU/KVM driver, the implementation for other drivers"},{"line_number":59,"context_line":"are out of scope."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_87ab1089","line":59,"in_reply_to":"fa1b9901_abf961ca","updated":"2015-08-25 01:56:33.000000000","message":"Done","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d9f71fed71974fb91a56c90f06fe02f1dde6c11e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"live_migration_ip column to compute_nodes table, with null as its default"},{"line_number":84,"context_line":"value. It will have no impact on existing data. ComputeNode object will an new"},{"line_number":85,"context_line":"attribute live_migration_ip, nullable \u003d True. Because of this reason,"},{"line_number":86,"context_line":"ComputeNode and ComputeNodeList need to dump to new version."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_e2aeafe6","line":86,"updated":"2015-08-24 02:31:44.000000000","message":"s/dump/bump","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"live_migration_ip column to compute_nodes table, with null as its default"},{"line_number":84,"context_line":"value. It will have no impact on existing data. ComputeNode object will an new"},{"line_number":85,"context_line":"attribute live_migration_ip, nullable \u003d True. Because of this reason,"},{"line_number":86,"context_line":"ComputeNode and ComputeNodeList need to dump to new version."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_47f9787f","line":86,"in_reply_to":"fa1b9901_e2aeafe6","updated":"2015-08-25 01:56:33.000000000","message":"\u0027should be dumped\u0027 looks better, sorry for my poor English.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"51f89513fff551337c19a6bd56e61add81f53c95","unresolved":false,"context_lines":[{"line_number":95,"context_line":"---------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"This feature have no impact for security. Split data transfer and management"},{"line_number":98,"context_line":"will improve security on some level."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_0bb96d79","line":98,"updated":"2015-08-24 13:26:00.000000000","message":"s/ have no/has no negative/\n\ns/security on some level./security somewhat by reducing the chance of a management plane denial of service.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"---------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"This feature have no impact for security. Split data transfer and management"},{"line_number":98,"context_line":"will improve security on some level."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_8799d070","line":98,"in_reply_to":"fa1b9901_0bb96d79","updated":"2015-08-25 01:56:33.000000000","message":"Done","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d9f71fed71974fb91a56c90f06fe02f1dde6c11e","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Performance Impact"},{"line_number":113,"context_line":"------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Using specifically planed network plane, when live migration, the impact of"},{"line_number":116,"context_line":"data transfer on network performance will no longer exist. The impact of live"},{"line_number":117,"context_line":"migration on network performance will be limited to its own network plane."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_226d87cc","line":114,"updated":"2015-08-24 02:31:44.000000000","message":"hmm.. we can add \u0027None\u0027 in front , so reviewers will not worry about it.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Performance Impact"},{"line_number":113,"context_line":"------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Using specifically planed network plane, when live migration, the impact of"},{"line_number":116,"context_line":"data transfer on network performance will no longer exist. The impact of live"},{"line_number":117,"context_line":"migration on network performance will be limited to its own network plane."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_c79588e4","line":114,"in_reply_to":"fa1b9901_226d87cc","updated":"2015-08-25 01:56:33.000000000","message":"This spec enhance the performance of live-migration, so I think this section shouldn\u0027t be None.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"51f89513fff551337c19a6bd56e61add81f53c95","unresolved":false,"context_lines":[{"line_number":125,"context_line":"existing live migration mechanism remains, if the option of"},{"line_number":126,"context_line":"CONF.my_live_migration_ip has been set, this option will be used for live"},{"line_number":127,"context_line":"migration\u0027s target uri. If the deployers want to use this function, a separated"},{"line_number":128,"context_line":"network plane have to be planed in advance."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_0bae4d98","line":128,"updated":"2015-08-24 13:26:00.000000000","message":"s/plane have to be planed/plane will have to be planned/","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"existing live migration mechanism remains, if the option of"},{"line_number":126,"context_line":"CONF.my_live_migration_ip has been set, this option will be used for live"},{"line_number":127,"context_line":"migration\u0027s target uri. If the deployers want to use this function, a separated"},{"line_number":128,"context_line":"network plane have to be planed in advance."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_c7dd8815","line":128,"in_reply_to":"fa1b9901_0bae4d98","updated":"2015-08-25 01:56:33.000000000","message":"Done","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d9f71fed71974fb91a56c90f06fe02f1dde6c11e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"* Add new column live_migration_ip in compute_nodes database table, add"},{"line_number":153,"context_line":"  function for updating compute_nodes table in db/migration.py."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Add new attribute live_migration_ip in ComputeNode object and dump new"},{"line_number":156,"context_line":"  version for ComputeNode and ComputeNodeList object."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"* Add new configuration option CONF.my_live_migration_ip, modify"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_4771addf","line":155,"updated":"2015-08-24 02:31:44.000000000","message":"s/dump/bump ?","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"* Add new column live_migration_ip in compute_nodes database table, add"},{"line_number":153,"context_line":"  function for updating compute_nodes table in db/migration.py."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Add new attribute live_migration_ip in ComputeNode object and dump new"},{"line_number":156,"context_line":"  version for ComputeNode and ComputeNodeList object."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"* Add new configuration option CONF.my_live_migration_ip, modify"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_c7c7c810","line":155,"in_reply_to":"fa1b9901_4771addf","updated":"2015-08-25 01:56:33.000000000","message":"I think it\u0027s \u0027dump\u0027","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d9f71fed71974fb91a56c90f06fe02f1dde6c11e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Add new attribute live_migration_ip in ComputeNode object and dump new"},{"line_number":156,"context_line":"  version for ComputeNode and ComputeNodeList object."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"* Add new configuration option CONF.my_live_migration_ip, modify"},{"line_number":159,"context_line":"  ResourceTracker\u0027s update_available_resource() function to enable update"},{"line_number":160,"context_line":"  CONF.my_live_migration_ip to database."},{"line_number":161,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_e239cfd9","line":158,"updated":"2015-08-24 02:31:44.000000000","message":"so what the section of CONF option will be added ?\n[default] or [libvirt] ?\naccording your description above in developer impact, this feature can be used to other drivers, so it would be clearly that if you can clarify where the configuration option will be added.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Add new attribute live_migration_ip in ComputeNode object and dump new"},{"line_number":156,"context_line":"  version for ComputeNode and ComputeNodeList object."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"* Add new configuration option CONF.my_live_migration_ip, modify"},{"line_number":159,"context_line":"  ResourceTracker\u0027s update_available_resource() function to enable update"},{"line_number":160,"context_line":"  CONF.my_live_migration_ip to database."},{"line_number":161,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_c77908fe","line":158,"in_reply_to":"fa1b9901_e239cfd9","updated":"2015-08-25 01:56:33.000000000","message":"Thank you, I think it\u0027s a common option for all drivers, so [default] group looks good.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d9f71fed71974fb91a56c90f06fe02f1dde6c11e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Changes will be made for DB, object, ResourceTracker and live migration, thus"},{"line_number":179,"context_line":"related unit tests will be added."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Documentation Impact"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_c72b7d93","line":179,"updated":"2015-08-24 02:31:44.000000000","message":"hmm... may be we need function testing? or at least tempest test case to cover this.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"51f89513fff551337c19a6bd56e61add81f53c95","unresolved":false,"context_lines":[{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Changes will be made for DB, object, ResourceTracker and live migration, thus"},{"line_number":179,"context_line":"related unit tests will be added."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Documentation Impact"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_8bd6ddef","line":179,"in_reply_to":"fa1b9901_c72b7d93","updated":"2015-08-24 13:26:00.000000000","message":"I agree","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Changes will be made for DB, object, ResourceTracker and live migration, thus"},{"line_number":179,"context_line":"related unit tests will be added."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Documentation Impact"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_124c206f","line":179,"in_reply_to":"fa1b9901_c72b7d93","updated":"2015-08-25 01:56:33.000000000","message":"This feature don\u0027t impact live-migration API, it\u0027s just a internal improvement, so I\u0027m not sure the function/tempest testing should be added.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d9f71fed71974fb91a56c90f06fe02f1dde6c11e","unresolved":false,"context_lines":[{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"The instruction for new configuration option CONF.my_live_migration_ip will be"},{"line_number":185,"context_line":"added."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"References"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_4748cd87","line":185,"updated":"2015-08-24 02:31:44.000000000","message":"hmm, I think here should be what  CONF.my_live_migration_ip stands of rand how operator use this new feature.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"The instruction for new configuration option CONF.my_live_migration_ip will be"},{"line_number":185,"context_line":"added."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"References"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_277d64b1","line":185,"in_reply_to":"fa1b9901_4748cd87","updated":"2015-08-25 01:56:33.000000000","message":"thanks, I will add an example.","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"51f89513fff551337c19a6bd56e61add81f53c95","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"The instruction for new configuration option CONF.my_live_migration_ip will be"},{"line_number":185,"context_line":"added."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"References"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_2beeb18b","line":186,"updated":"2015-08-24 13:26:00.000000000","message":"s/for/for a/\n\ns/added/added to the OpenStack Configuration Reference manual/","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"cc75745a13c5dc92c7a941f96f0317bf6553488e","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"The instruction for new configuration option CONF.my_live_migration_ip will be"},{"line_number":185,"context_line":"added."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"References"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_27732417","line":186,"in_reply_to":"fa1b9901_2beeb18b","updated":"2015-08-25 01:56:33.000000000","message":"Done","commit_id":"e0e6d541ed126772e670aa0d577d8812538efac8"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e3050c446011cd6eedfe384880cb1098ce5388de","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When we do live migration with QEMU/KVM driver, we use hostname of target"},{"line_number":22,"context_line":"compute node as the target of live migration. So the RPC call and data transfer"},{"line_number":23,"context_line":"of live migration will be in same network plane. Live migration will have"},{"line_number":24,"context_line":"impact on network performance, this impact is obvious when lots of live"},{"line_number":25,"context_line":"migration occur at the same time, even if CONF.libvirt.live_migration_bandwidth"},{"line_number":26,"context_line":"is set."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_9cade08a","line":23,"updated":"2015-09-25 12:49:02.000000000","message":"I do not think that the RPC call is a big issue here","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When we do live migration with QEMU/KVM driver, we use hostname of target"},{"line_number":22,"context_line":"compute node as the target of live migration. So the RPC call and data transfer"},{"line_number":23,"context_line":"of live migration will be in same network plane. Live migration will have"},{"line_number":24,"context_line":"impact on network performance, this impact is obvious when lots of live"},{"line_number":25,"context_line":"migration occur at the same time, even if CONF.libvirt.live_migration_bandwidth"},{"line_number":26,"context_line":"is set."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_7bf45bf1","line":23,"in_reply_to":"9a1a9d01_38704a72","updated":"2015-09-29 07:58:00.000000000","message":"Yes, Dan is right, live migration traffic will impact the RPC call if they are in the same network, I hope to solve it in this specification.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"8fc28c9d6c11040e8f383abe4d9091c171950175","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When we do live migration with QEMU/KVM driver, we use hostname of target"},{"line_number":22,"context_line":"compute node as the target of live migration. So the RPC call and data transfer"},{"line_number":23,"context_line":"of live migration will be in same network plane. Live migration will have"},{"line_number":24,"context_line":"impact on network performance, this impact is obvious when lots of live"},{"line_number":25,"context_line":"migration occur at the same time, even if CONF.libvirt.live_migration_bandwidth"},{"line_number":26,"context_line":"is set."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_38ae0a2f","line":23,"in_reply_to":"9a1a9d01_38704a72","updated":"2015-09-25 20:02:15.000000000","message":"s/data transfer of live migration/live migration traffic/","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When we do live migration with QEMU/KVM driver, we use hostname of target"},{"line_number":22,"context_line":"compute node as the target of live migration. So the RPC call and data transfer"},{"line_number":23,"context_line":"of live migration will be in same network plane. Live migration will have"},{"line_number":24,"context_line":"impact on network performance, this impact is obvious when lots of live"},{"line_number":25,"context_line":"migration occur at the same time, even if CONF.libvirt.live_migration_bandwidth"},{"line_number":26,"context_line":"is set."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_9bf7eff4","line":23,"in_reply_to":"9a1a9d01_38ae0a2f","updated":"2015-09-29 07:58:00.000000000","message":"Done","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a6f673648b64924eb40f71b82d4d585d982b0d11","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When we do live migration with QEMU/KVM driver, we use hostname of target"},{"line_number":22,"context_line":"compute node as the target of live migration. So the RPC call and data transfer"},{"line_number":23,"context_line":"of live migration will be in same network plane. Live migration will have"},{"line_number":24,"context_line":"impact on network performance, this impact is obvious when lots of live"},{"line_number":25,"context_line":"migration occur at the same time, even if CONF.libvirt.live_migration_bandwidth"},{"line_number":26,"context_line":"is set."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_38704a72","line":23,"in_reply_to":"9a1a9d01_9cade08a","updated":"2015-09-25 19:38:14.000000000","message":"Having the live migration traffic on the same network as RPC (et al) _is_ a problem, which is what I assume the author was referencing here.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"8fc28c9d6c11040e8f383abe4d9091c171950175","unresolved":false,"context_lines":[{"line_number":23,"context_line":"of live migration will be in same network plane. Live migration will have"},{"line_number":24,"context_line":"impact on network performance, this impact is obvious when lots of live"},{"line_number":25,"context_line":"migration occur at the same time, even if CONF.libvirt.live_migration_bandwidth"},{"line_number":26,"context_line":"is set."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_5309612b","line":26,"updated":"2015-09-25 20:02:15.000000000","message":"s/this impact is obvious when lots of live migration occur at the same time/and this impact is significant when lots of live \tmigration occurs concurrently/","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":23,"context_line":"of live migration will be in same network plane. Live migration will have"},{"line_number":24,"context_line":"impact on network performance, this impact is obvious when lots of live"},{"line_number":25,"context_line":"migration occur at the same time, even if CONF.libvirt.live_migration_bandwidth"},{"line_number":26,"context_line":"is set."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_bb0673cc","line":26,"in_reply_to":"9a1a9d01_5309612b","updated":"2015-09-29 07:58:00.000000000","message":"Done","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e3050c446011cd6eedfe384880cb1098ce5388de","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Add an new option CONF.my_live_migration_ip in configuration file, set None as"},{"line_number":48,"context_line":"default value. When compute node refreshes the resources, if this option is"},{"line_number":49,"context_line":"set, update it to the compute_nodes table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Add a new string type column: live_migration_ip in compute_nodes database"},{"line_number":52,"context_line":"table. When live migration, in QEMU/KVM environment, hostname is used to query"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_f5f66fd6","line":49,"updated":"2015-09-25 12:49:02.000000000","message":"once this option is there it could be always set to a value if the operator doesn\u0027t want/have a separate network could just put the hostname or the  host_ip value","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Add an new option CONF.my_live_migration_ip in configuration file, set None as"},{"line_number":48,"context_line":"default value. When compute node refreshes the resources, if this option is"},{"line_number":49,"context_line":"set, update it to the compute_nodes table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Add a new string type column: live_migration_ip in compute_nodes database"},{"line_number":52,"context_line":"table. When live migration, in QEMU/KVM environment, hostname is used to query"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_1addec6e","line":49,"in_reply_to":"9a1a9d01_f5f66fd6","updated":"2015-09-29 07:58:00.000000000","message":"If the operator doesn\u0027t want/have a separate network, he shouldn\u0027t set the option, live-migration will execute like the current implement if the option is None.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e3050c446011cd6eedfe384880cb1098ce5388de","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Add a new string type column: live_migration_ip in compute_nodes database"},{"line_number":52,"context_line":"table. When live migration, in QEMU/KVM environment, hostname is used to query"},{"line_number":53,"context_line":"for ComputeNode object and live_migration_ip property, if this property is not"},{"line_number":54,"context_line":"None, this ip address is used to generate CONF.libvirt.live_migration_uri as"},{"line_number":55,"context_line":"the uri for live migration, if this property is None, then the mechanism"},{"line_number":56,"context_line":"remains as it is now."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_bc90e4ed","line":54,"updated":"2015-09-25 12:49:02.000000000","message":"it is confusing saying \"generate the CONF.libvirt.live_migration_uri\" it seems that we modify that configuration value every time instead we are generating just the live_migration_uri","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Add a new string type column: live_migration_ip in compute_nodes database"},{"line_number":52,"context_line":"table. When live migration, in QEMU/KVM environment, hostname is used to query"},{"line_number":53,"context_line":"for ComputeNode object and live_migration_ip property, if this property is not"},{"line_number":54,"context_line":"None, this ip address is used to generate CONF.libvirt.live_migration_uri as"},{"line_number":55,"context_line":"the uri for live migration, if this property is None, then the mechanism"},{"line_number":56,"context_line":"remains as it is now."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_ba0160b1","line":54,"in_reply_to":"9a1a9d01_bc90e4ed","updated":"2015-09-29 07:58:00.000000000","message":"sorry, \u0027instead of\u0027 is more clear.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e3050c446011cd6eedfe384880cb1098ce5388de","unresolved":false,"context_lines":[{"line_number":56,"context_line":"remains as it is now."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This spec focuses on the QEMU/KVM driver, the implementation for other drivers"},{"line_number":59,"context_line":"are out of scope."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_c855d7c6","line":59,"updated":"2015-09-25 12:49:02.000000000","message":"nit: s/are/is","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a6f673648b64924eb40f71b82d4d585d982b0d11","unresolved":false,"context_lines":[{"line_number":56,"context_line":"remains as it is now."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This spec focuses on the QEMU/KVM driver, the implementation for other drivers"},{"line_number":59,"context_line":"are out of scope."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_f88df27b","line":59,"in_reply_to":"9a1a9d01_c855d7c6","updated":"2015-09-25 19:38:14.000000000","message":"Actually, I think it should be s/implementation/implementations/ and leave \"are\" :)\n\nAlso, I think that you should not leave the other drivers out of scope here. You\u0027re adding a new top-level configuration variable -- having that only apply to one driver is confusing.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":56,"context_line":"remains as it is now."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This spec focuses on the QEMU/KVM driver, the implementation for other drivers"},{"line_number":59,"context_line":"are out of scope."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_da71b445","line":59,"in_reply_to":"9a1a9d01_f88df27b","updated":"2015-09-29 07:58:00.000000000","message":"I\u0027m not familiar with other drivers, so I hope to implement this feature on QEMU/KVM driver at first, and implement on other driver in separate blueprint.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"ed635812cc5d42e7a36386669c246fbe4da4a851","unresolved":false,"context_lines":[{"line_number":56,"context_line":"remains as it is now."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This spec focuses on the QEMU/KVM driver, the implementation for other drivers"},{"line_number":59,"context_line":"are out of scope."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_2ef22870","line":59,"in_reply_to":"9a1a9d01_f88df27b","updated":"2015-09-28 08:03:07.000000000","message":"ah, I knew it was an hazard for me trying to correct english grammar.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a6f673648b64924eb40f71b82d4d585d982b0d11","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Data model impact"},{"line_number":79,"context_line":"-----------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Add a new nullable string type column live_migration_ip in compute_nodes table,"},{"line_number":82,"context_line":"using null as its default value. When performing database migration, just add"},{"line_number":83,"context_line":"live_migration_ip column to compute_nodes table, with null as its default"},{"line_number":84,"context_line":"value. It will have no impact on existing data. ComputeNode object will an new"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_587c1e72","line":81,"updated":"2015-09-25 19:38:14.000000000","message":"Why? Can\u0027t we just have the compute node return the IP it wants the sender to use in the migration data returned from the pre-live-migration check? Writing this into the database and storing it doesn\u0027t seem particularly useful to me.\n\nThis makes it easier to honor in the other drivers too.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Data model impact"},{"line_number":79,"context_line":"-----------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Add a new nullable string type column live_migration_ip in compute_nodes table,"},{"line_number":82,"context_line":"using null as its default value. When performing database migration, just add"},{"line_number":83,"context_line":"live_migration_ip column to compute_nodes table, with null as its default"},{"line_number":84,"context_line":"value. It will have no impact on existing data. ComputeNode object will an new"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_15029f3d","line":81,"in_reply_to":"9a1a9d01_587c1e72","updated":"2015-09-29 07:58:00.000000000","message":"Good idea, thank you very much.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e3050c446011cd6eedfe384880cb1098ce5388de","unresolved":false,"context_lines":[{"line_number":82,"context_line":"using null as its default value. When performing database migration, just add"},{"line_number":83,"context_line":"live_migration_ip column to compute_nodes table, with null as its default"},{"line_number":84,"context_line":"value. It will have no impact on existing data. ComputeNode object will an new"},{"line_number":85,"context_line":"attribute live_migration_ip, nullable \u003d True. Because of this reason,"},{"line_number":86,"context_line":"ComputeNode and ComputeNodeList should be dumped to new version."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_08cf4f80","line":85,"updated":"2015-09-25 12:49:02.000000000","message":"The sentence starting with ComputeNode doesn\u0027t make sense, can you correct it, please?","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":82,"context_line":"using null as its default value. When performing database migration, just add"},{"line_number":83,"context_line":"live_migration_ip column to compute_nodes table, with null as its default"},{"line_number":84,"context_line":"value. It will have no impact on existing data. ComputeNode object will an new"},{"line_number":85,"context_line":"attribute live_migration_ip, nullable \u003d True. Because of this reason,"},{"line_number":86,"context_line":"ComputeNode and ComputeNodeList should be dumped to new version."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_f5604b03","line":85,"in_reply_to":"9a1a9d01_08cf4f80","updated":"2015-09-29 07:58:00.000000000","message":"this section will be removed in next patch in whole.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e3050c446011cd6eedfe384880cb1098ce5388de","unresolved":false,"context_lines":[{"line_number":83,"context_line":"live_migration_ip column to compute_nodes table, with null as its default"},{"line_number":84,"context_line":"value. It will have no impact on existing data. ComputeNode object will an new"},{"line_number":85,"context_line":"attribute live_migration_ip, nullable \u003d True. Because of this reason,"},{"line_number":86,"context_line":"ComputeNode and ComputeNodeList should be dumped to new version."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_1c6d5004","line":86,"updated":"2015-09-25 12:49:02.000000000","message":"dumped or bumped?","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e3050c446011cd6eedfe384880cb1098ce5388de","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Using specifically planed network plane, when live migration, the impact of"},{"line_number":117,"context_line":"data transfer on network performance will no longer exist. The impact of live"},{"line_number":118,"context_line":"migration on network performance will be limited to its own network plane."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Other deployer impact"},{"line_number":122,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_5c31880a","line":119,"updated":"2015-09-25 12:49:02.000000000","message":"we should mention that we need to query the DB to get the right IP to create the live_migration_uri","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Using specifically planed network plane, when live migration, the impact of"},{"line_number":117,"context_line":"data transfer on network performance will no longer exist. The impact of live"},{"line_number":118,"context_line":"migration on network performance will be limited to its own network plane."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Other deployer impact"},{"line_number":122,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_f50e0b3a","line":119,"in_reply_to":"9a1a9d01_5c31880a","updated":"2015-09-29 07:58:00.000000000","message":"According to Dan\u0027s suggestion ,we don\u0027t need to query DB anymore.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e3050c446011cd6eedfe384880cb1098ce5388de","unresolved":false,"context_lines":[{"line_number":153,"context_line":"* Add new column live_migration_ip in compute_nodes database table, add"},{"line_number":154,"context_line":"  function for updating compute_nodes table in db/migration.py."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"* Add new attribute live_migration_ip in ComputeNode object and dump new"},{"line_number":157,"context_line":"  version for ComputeNode and ComputeNodeList object."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* Add new configuration option CONF.my_live_migration_ip into [DEFAULT] group,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_fc93bca1","line":156,"updated":"2015-09-25 12:49:02.000000000","message":"I think you meant bump and not dump","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6ac4c52cdb1544849151e3a3bbf9f9924e10b915","unresolved":false,"context_lines":[{"line_number":153,"context_line":"* Add new column live_migration_ip in compute_nodes database table, add"},{"line_number":154,"context_line":"  function for updating compute_nodes table in db/migration.py."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"* Add new attribute live_migration_ip in ComputeNode object and dump new"},{"line_number":157,"context_line":"  version for ComputeNode and ComputeNodeList object."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* Add new configuration option CONF.my_live_migration_ip into [DEFAULT] group,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_1916594c","line":156,"in_reply_to":"9a1a9d01_fc93bca1","updated":"2015-09-29 07:58:00.000000000","message":"these part will be removed in next patch.","commit_id":"41721a51e7ba4b009c88605522b75b2d80b9139d"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"f8505b5bd138fff8c3cbe17a4b78ff335a05b30b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Performance Impact"},{"line_number":105,"context_line":"------------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Using specifically planed network plane, when live migration, the impact of"},{"line_number":108,"context_line":"data transfer on network performance will no longer exist. The impact of live"},{"line_number":109,"context_line":"migration on network performance will be limited to its own network plane."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a1a9d01_24f82d7c","line":107,"updated":"2015-10-02 14:36:30.000000000","message":"planed or planned?\nspecifically or specific?\nI think the sentence could be a bit easier to read.","commit_id":"b56eb214380662cfcc29713cb4d9e4919eff15f3"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"fa00087d26a8c76ecedaa9f6b3d8c86bceee805e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Project Priority"},{"line_number":40,"context_line":"----------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a26ad4f_e37f23a9","line":42,"updated":"2015-11-02 13:59:49.000000000","message":"Project priorities are decided, this should be: Live Migration","commit_id":"d13bbe94978798bfc23bb3c6b37dc009b8d906da"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"664a03f674e3674ee9550321fd4e6e0c4768bb84","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Project Priority"},{"line_number":40,"context_line":"----------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a26ad4f_82a89178","line":42,"in_reply_to":"1a26ad4f_6741dea8","updated":"2015-11-03 03:53:22.000000000","message":"ok, it\u0027s a minor format issue, if others have some suggestions about the workflow, I will fix these together in next patch.","commit_id":"d13bbe94978798bfc23bb3c6b37dc009b8d906da"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"e3bfefe31930baacfa99fa6b61b7f088497445aa","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Project Priority"},{"line_number":40,"context_line":"----------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_07802f8a","line":42,"in_reply_to":"1a26ad4f_82a89178","updated":"2015-11-11 09:49:20.000000000","message":"Sorry - I know it seems silly but this is public documentation. It should be in the correct format.","commit_id":"d13bbe94978798bfc23bb3c6b37dc009b8d906da"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"d1e06c914764a835bd5820203303a9b3762fa464","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Project Priority"},{"line_number":40,"context_line":"----------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a26ad4f_6741dea8","line":42,"in_reply_to":"1a26ad4f_e37f23a9","updated":"2015-11-02 14:15:52.000000000","message":"Actually - ignore that - this section is no longer included and should be removed.","commit_id":"d13bbe94978798bfc23bb3c6b37dc009b8d906da"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"4ed93d713220aaf47ea97f4edfffaad70ec79338","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Project Priority"},{"line_number":40,"context_line":"----------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_5df928c6","line":42,"in_reply_to":"da85f559_07802f8a","updated":"2015-11-11 10:26:18.000000000","message":"Actually, changing this to a nit - correct if you do another patch set. Otherwise we can correct the documentation later with another change.","commit_id":"d13bbe94978798bfc23bb3c6b37dc009b8d906da"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c9e4fa7817cbddcbf49c585cb9e0c9f423df0a91","unresolved":false,"context_lines":[{"line_number":113,"context_line":"---------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The added configuration option CONF.my_live_migration_ip will be available for"},{"line_number":116,"context_line":"all drivers, the default value is None. Thus, when OpenStack upgrades, the"},{"line_number":117,"context_line":"existing live migration mechanism remains, if the option of"},{"line_number":118,"context_line":"CONF.my_live_migration_ip has been set, this option will be used for live"},{"line_number":119,"context_line":"migration\u0027s target uri. If the deployers want to use this function, a separated"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_9bd517e6","line":116,"updated":"2015-11-12 12:02:30.000000000","message":"nit: not sure we should say \"all drivers\" here if you are only implementing this for libvirt.","commit_id":"d13bbe94978798bfc23bb3c6b37dc009b8d906da"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c9e4fa7817cbddcbf49c585cb9e0c9f423df0a91","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Work Items"},{"line_number":142,"context_line":"----------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* Add new configuration option CONF.my_live_migration_ip into [DEFAULT] group."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"* Modify the existing implementation of live migration, when"},{"line_number":147,"context_line":"  pre_live_migration() execute in destination host, set the option into"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da85f559_7e4aa156","line":144,"updated":"2015-11-12 12:02:30.000000000","message":"Nit: not sure I like the name of the config option here.\n\nlive_migration_transport_ip feels more descriptive, but lets leave that for the code review, since we already have a +2 here.","commit_id":"d13bbe94978798bfc23bb3c6b37dc009b8d906da"}]}