)]}'
{"specs/liberty/approved/service-version-number.rst":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c47ddc2e46739d374a3b79ab8615e273cb158d90","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Initially, the column will be created with a default of NULL, and the"},{"line_number":64,"context_line":"Service object will treat NULL as \"version 1\". Subsequent changes will"},{"line_number":65,"context_line":"set versions to 2. Any time we do an online data migration, we will"},{"line_number":66,"context_line":"need to bump the service version number."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"We need to do this in L so that we can leverage it in M. If we delay"},{"line_number":69,"context_line":"this until M, we won\u0027t be able to rely on it until N."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_def09d93","line":66,"updated":"2015-06-24 16:20:29.000000000","message":"This versioning could also be beneficial for rpc upgrade levels rather than relying on configs.  Though this is targeted at db migrations I think we should answer whether we want this version to accommodate both, leave rpc upgrade levels as is indefinitely, or add a second version later.","commit_id":"ea0e1394447802071651a92a6321a6a23a6d547d"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c47ddc2e46739d374a3b79ab8615e273cb158d90","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Service object will treat NULL as \"version 1\". Subsequent changes will"},{"line_number":65,"context_line":"set versions to 2. Any time we do an online data migration, we will"},{"line_number":66,"context_line":"need to bump the service version number."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"We need to do this in L so that we can leverage it in M. If we delay"},{"line_number":69,"context_line":"this until M, we won\u0027t be able to rely on it until N."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_dee3bda2","line":67,"updated":"2015-06-24 16:20:29.000000000","message":"I think it\u0027s beneficial to mention what should happen if a service is started up that\u0027s older than the current MIN(versions).  In that case it\u0027s likely that it won\u0027t be able to properly communicate with other services as they\u0027ll be using newer objects so it should probably refuse to start with an error message, or run but do nothing except log it\u0027s legacy status.","commit_id":"ea0e1394447802071651a92a6321a6a23a6d547d"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c47ddc2e46739d374a3b79ab8615e273cb158d90","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Testing"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"This should be fully testable with unit tests. "},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Documentation Impact"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_5e0a4d7a","line":162,"range":{"start_line":162,"start_character":46,"end_line":162,"end_character":47},"updated":"2015-06-24 16:20:29.000000000","message":"Whitespace.","commit_id":"ea0e1394447802071651a92a6321a6a23a6d547d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"913df8828691eb9a97c1e068f304c75909238b9a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"beginning to convert data to expand into new schema before older"},{"line_number":26,"context_line":"conductors and other control services are ready. If you upgrade all"},{"line_number":27,"context_line":"your control services together, this works well, but if you don\u0027t (as"},{"line_number":28,"context_line":"would be more realistic) you have the potential to break some of the"},{"line_number":29,"context_line":"older control services."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_37dd8ee0","line":28,"updated":"2015-06-30 20:18:33.000000000","message":"An example case might be helpful here.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b1c6c54f926d26e64f043d7a5101332ce9a086c5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"beginning to convert data to expand into new schema before older"},{"line_number":26,"context_line":"conductors and other control services are ready. If you upgrade all"},{"line_number":27,"context_line":"your control services together, this works well, but if you don\u0027t (as"},{"line_number":28,"context_line":"would be more realistic) you have the potential to break some of the"},{"line_number":29,"context_line":"older control services."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_3ab1f547","line":28,"in_reply_to":"ba3cc151_37dd8ee0","updated":"2015-06-30 20:24:49.000000000","message":"Sure, I\u0027ll add another paragraph.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"913df8828691eb9a97c1e068f304c75909238b9a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"config reload."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Initially, the column will be created with a default of NULL, and the"},{"line_number":64,"context_line":"Service object will treat NULL as \"version 1\". Subsequent changes will"},{"line_number":65,"context_line":"set versions to 2. Any time we do an online data migration, we will"},{"line_number":66,"context_line":"need to bump the service version number."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_17a72a50","line":64,"updated":"2015-06-30 20:18:33.000000000","message":"Since we have semver versions for the actual package now, i.e. 12.0.0 is Liberty, I\u0027d suggest we use that for the versions in the database so it\u0027s a bit more obvious what the version on the service maps to in the code, i.e. my conductor service is 12.0.0 but my api service is 13.0.0, I\u0027ve upgraded API to \u0027M\u0027 but conductor is still running Liberty code.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b1c6c54f926d26e64f043d7a5101332ce9a086c5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"config reload."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Initially, the column will be created with a default of NULL, and the"},{"line_number":64,"context_line":"Service object will treat NULL as \"version 1\". Subsequent changes will"},{"line_number":65,"context_line":"set versions to 2. Any time we do an online data migration, we will"},{"line_number":66,"context_line":"need to bump the service version number."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_3adfb56a","line":64,"in_reply_to":"ba3cc151_17a72a50","updated":"2015-06-30 20:24:49.000000000","message":"I\u0027m pretty strongly opposed to making this semver\u0027d, and also opposed to tying it to release numbering in any way.\n\nThis is a monotonic vector that we use for positioning ourselves in time, and with which we drive other policies. The version number doesn\u0027t have any semantics associated with it, but the things we use the version to control will.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"04f0b61189db74b3912f9190831d15cf5b778597","unresolved":false,"context_lines":[{"line_number":61,"context_line":"config reload."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Initially, the column will be created with a default of NULL, and the"},{"line_number":64,"context_line":"Service object will treat NULL as \"version 1\". Subsequent changes will"},{"line_number":65,"context_line":"set versions to 2. Any time we do an online data migration, we will"},{"line_number":66,"context_line":"need to bump the service version number."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_babbc5e4","line":64,"in_reply_to":"ba3cc151_3adfb56a","updated":"2015-06-30 20:28:03.000000000","message":"FINE! :)\n\nMight be worthwhile calling that out specifically in here somewhere as a thing you don\u0027t want to do, because I\u0027m guessing I won\u0027t be the first to bring it up.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"913df8828691eb9a97c1e068f304c75909238b9a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"-----------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"A schema migration will be written to add a version column to the"},{"line_number":101,"context_line":"table. The version will be an integer, nullable, default to NULL."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The Service object will be extended to support this version, and will"},{"line_number":104,"context_line":"treat a NULL version as version \"1\", which will avoid us having to do"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_d73542f7","line":101,"updated":"2015-06-30 20:18:33.000000000","message":"If we use the package version, e.g. 12.0.0, then it could still be an integer, we\u0027d just have to normalize it like 012000000 or something.  We do that today with libvirt version checking.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"68c01b12c6246bdd34171153643a84638f61b147","unresolved":false,"context_lines":[{"line_number":98,"context_line":"-----------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"A schema migration will be written to add a version column to the"},{"line_number":101,"context_line":"table. The version will be an integer, nullable, default to NULL."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The Service object will be extended to support this version, and will"},{"line_number":104,"context_line":"treat a NULL version as version \"1\", which will avoid us having to do"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_fa6dcd98","line":101,"in_reply_to":"ba3cc151_d73542f7","updated":"2015-06-30 20:26:06.000000000","message":"I was thinking something similar and asked Dan about it in irc.  If it\u0027s thought of more as a vector then other systems can use it to drive their own upgrade semantics.  For instance, I would tie the versioning to compatibility of something, like we do for rpc pinning today.  But if the version is going to drive both db upgrades and potentially rpc pins in the future then trying to embed semantic meaning into the version itself becomes overly complicated.  I think it may end up being better to leave this as a monotonic integer and allow clients to derive their own meaning from it.  Like db model x works for versions 20-36 and then an update is necessary and rpc method foo() has 4 arguments for versions 25-42 and then adds a fifth in 43.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"04f0b61189db74b3912f9190831d15cf5b778597","unresolved":false,"context_lines":[{"line_number":98,"context_line":"-----------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"A schema migration will be written to add a version column to the"},{"line_number":101,"context_line":"table. The version will be an integer, nullable, default to NULL."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The Service object will be extended to support this version, and will"},{"line_number":104,"context_line":"treat a NULL version as version \"1\", which will avoid us having to do"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_9ab841e7","line":101,"in_reply_to":"ba3cc151_fa6dcd98","updated":"2015-06-30 20:28:03.000000000","message":"Yeah, sure, I think the reasons against semver should be called out in the spec then since it\u0027s already coming up in IRC during review.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"913df8828691eb9a97c1e068f304c75909238b9a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"Testing"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"This should be fully testable with unit tests."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Documentation Impact"},{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_3727cecb","line":178,"updated":"2015-06-30 20:18:33.000000000","message":"Anything to test here with grenade?","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b1c6c54f926d26e64f043d7a5101332ce9a086c5","unresolved":false,"context_lines":[{"line_number":175,"context_line":"Testing"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"This should be fully testable with unit tests."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Documentation Impact"},{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_9a45a118","line":178,"in_reply_to":"ba3cc151_3727cecb","updated":"2015-06-30 20:24:49.000000000","message":"This spec is purely about adding the counter. Starting the clock so to speak. Realistically, M is the earliest we\u0027ll be able to leverage this, so I just want to get it in so that it\u0027s available then. The things we drive from this (like rpc versioning or driving online migrations) would be the things we test with grenade. Otherwise, this is invisible to anything higher level like grenade or tempest.","commit_id":"2a414ab6e7480e50e2585deb240aaa4ed79e45d8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eb3f5d5a766ae7d97fad23bce9cdd9ccff1ecf90","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"For example, in Kilo we can apply the database schema before starting"},{"line_number":32,"context_line":"to upgrade any of the code. However, once we upgrade any one component"},{"line_number":33,"context_line":"that talks to the database directly, online migrations will begin to"},{"line_number":34,"context_line":"happen, and any other nodes that read from the database directly will"},{"line_number":35,"context_line":"be confused as things are starting to move. If we had this service"},{"line_number":36,"context_line":"version number available, we could avoid doing any online migrations"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_bac8a523","line":33,"updated":"2015-06-30 20:35:15.000000000","message":"talks to the database directly, like nova-api or nova-conductor, online...","commit_id":"2ce86bca216374653484406b1760f4ea47c13f49"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9dbf8af752bb4c6ad39e9126fd676132a0449e5b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"The Service object will be extended to support this version, and will"},{"line_number":132,"context_line":"treat a NULL version as version \"1\", which will avoid us having to do"},{"line_number":133,"context_line":"any data migrations on existing service records. New saves will"},{"line_number":134,"context_line":"initially write version \"2\" for all services."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"REST API impact"},{"line_number":137,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_1f3d43bb","line":134,"updated":"2015-07-10 14:50:05.000000000","message":"So this should also have implications for the service group API, but lets deal with that later.","commit_id":"4a50f6a47cf4b92de3f4ec68c707215c99871fa3"}]}
