)]}'
{"specs/backlog/approved/virt-device-role-tagging.rst":[{"author":{"_account_id":16774,"name":"Karim Boumedhel","email":"karimboumedhel@gmail.com","username":"karmab"},"change_message_id":"f0f4cb8b929f6a4286b5d4cf4bcb783bc12b4c95","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      --block-device volume_id\u003d56789,bus\u003dvirtio,tag\u003dsquidcache \\"},{"line_number":126,"context_line":"      mynfvapp"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Libvirt could then auto-generate a metadata file that"},{"line_number":129,"context_line":"contained the following information"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_6f084f2e","line":128,"updated":"2015-06-26 17:33:31.000000000","message":"Wouldnt that rather be nova generating this file?","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"734daf9a67b4324f4856742cbfadaad3556cb3bc","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      --block-device volume_id\u003d56789,bus\u003dvirtio,tag\u003dsquidcache \\"},{"line_number":126,"context_line":"      mynfvapp"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Libvirt could then auto-generate a metadata file that"},{"line_number":129,"context_line":"contained the following information"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a41bdd9_16c43c3e","line":128,"in_reply_to":"ba3cc151_5096fcf0","updated":"2015-07-17 11:41:55.000000000","message":"Yes, typo, it should obviously be nova.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"291bc730afdeaab1b8f424cef470e86e97fa36cc","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      --block-device volume_id\u003d56789,bus\u003dvirtio,tag\u003dsquidcache \\"},{"line_number":126,"context_line":"      mynfvapp"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Libvirt could then auto-generate a metadata file that"},{"line_number":129,"context_line":"contained the following information"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_5096fcf0","line":128,"in_reply_to":"fa32b979_6f084f2e","updated":"2015-07-08 01:13:28.000000000","message":"Yeah, it would be Nova.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":16774,"name":"Karim Boumedhel","email":"karimboumedhel@gmail.com","username":"karmab"},"change_message_id":"f0f4cb8b929f6a4286b5d4cf4bcb783bc12b4c95","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  address, of USB port, or IDE channel, etc."},{"line_number":169,"context_line":"* The network device MAC address"},{"line_number":170,"context_line":"* The disk drive serial string (if set)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Note that not all architectures support PCI buses, for"},{"line_number":173,"context_line":"example armv7 and s390 don\u0027t, so in general all of the"},{"line_number":174,"context_line":"attributes would be considered optional. The virt driver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_9207fa17","line":171,"updated":"2015-06-26 17:33:31.000000000","message":"How do we expect nova to grab this information (pci/scsi addresses) ?","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"734daf9a67b4324f4856742cbfadaad3556cb3bc","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  address, of USB port, or IDE channel, etc."},{"line_number":169,"context_line":"* The network device MAC address"},{"line_number":170,"context_line":"* The disk drive serial string (if set)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Note that not all architectures support PCI buses, for"},{"line_number":173,"context_line":"example armv7 and s390 don\u0027t, so in general all of the"},{"line_number":174,"context_line":"attributes would be considered optional. The virt driver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a41bdd9_56d164fa","line":171,"in_reply_to":"ba3cc151_935fae0e","updated":"2015-07-17 11:41:55.000000000","message":"Yes, either Nova just reads it back from libvirt after defining the XML, but before starting the guest, or alternatively, Nova can explicitly set the PCI/SCSI/etc addresses when creating the XML. The former is probably the simpler approach for initial impl.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"291bc730afdeaab1b8f424cef470e86e97fa36cc","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  address, of USB port, or IDE channel, etc."},{"line_number":169,"context_line":"* The network device MAC address"},{"line_number":170,"context_line":"* The disk drive serial string (if set)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Note that not all architectures support PCI buses, for"},{"line_number":173,"context_line":"example armv7 and s390 don\u0027t, so in general all of the"},{"line_number":174,"context_line":"attributes would be considered optional. The virt driver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_935fae0e","line":171,"in_reply_to":"fa32b979_9207fa17","updated":"2015-07-08 01:13:28.000000000","message":"It\u0027s in libvirt\u0027s domain xml file.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":19285,"name":"Alfonso Tierno","email":"alf.tierno@gmail.com"},"change_message_id":"ce6327a7f312259cb1c40b0a8762ef749970db15","unresolved":false,"context_lines":[{"line_number":190,"context_line":"learn that. In view of this, it is considered inappropriate"},{"line_number":191,"context_line":"to allow tenant users to control the guest device addressing"},{"line_number":192,"context_line":"via the REST API."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"As noted in the problem description another approach is for"},{"line_number":195,"context_line":"the tenant user to manually set tags via the existing mechanism"},{"line_number":196,"context_line":"for providing user metadata to guests. This however relies on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_4d5b352f","line":193,"updated":"2015-11-13 11:02:02.000000000","message":"For the network interfaces case upon NFV, this solution, though appreciated, is not enough. Cloud-init in the guest will run after the Linux network configuration is done (it gets metadata using the IP address from one of its control interfaces). This is OK when all the interfaces are configured to use IP and attached to a \"controlled by\" Neutron net. But in NFV you can have one interface with IP for control, and several others without IP (e.g. MPLS); and in addition they can be attached to a provider network (outside the Neutron control). What if a Linux guest changes the order of the interfaces and configures the wrong interface as IP?. In this case the VM will not be able to get the metadata. For this reason I think it should be allowed to inject vPCI information into the guest, to ensure a proper configuration based on vPCI address.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ccce9f102bd2b9920eac3d19b0525af52e105c46","unresolved":false,"context_lines":[{"line_number":190,"context_line":"learn that. In view of this, it is considered inappropriate"},{"line_number":191,"context_line":"to allow tenant users to control the guest device addressing"},{"line_number":192,"context_line":"via the REST API."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"As noted in the problem description another approach is for"},{"line_number":195,"context_line":"the tenant user to manually set tags via the existing mechanism"},{"line_number":196,"context_line":"for providing user metadata to guests. This however relies on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_c83e45b8","line":193,"in_reply_to":"ba8a016a_bc6c6609","updated":"2015-11-17 18:15:05.000000000","message":"If there are VNF that have hardcoded specific PCI addresses, then unfortunately they are going to have to be fixed to be more configurable. As explained above, there is no way we are going allow openstack tenant users to specify guest PCI addresses when booting guests.  This spec proposes a mechanism that allows for guest self-configuration automatically which should be sufficient to allow any code to be adapted for a cloud environment.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ccce9f102bd2b9920eac3d19b0525af52e105c46","unresolved":false,"context_lines":[{"line_number":190,"context_line":"learn that. In view of this, it is considered inappropriate"},{"line_number":191,"context_line":"to allow tenant users to control the guest device addressing"},{"line_number":192,"context_line":"via the REST API."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"As noted in the problem description another approach is for"},{"line_number":195,"context_line":"the tenant user to manually set tags via the existing mechanism"},{"line_number":196,"context_line":"for providing user metadata to guests. This however relies on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_30e60bb5","line":193,"in_reply_to":"ba8a016a_f7e95d1b","updated":"2015-11-17 18:15:05.000000000","message":"Specifying a MAC address has non of the issues I list here wrt to PCI addresses. The rules for choosing MAC address don\u0027t change across hypervisor, or across hypervisor version, or across machine type, or across architecture, or any other way. A MAC address can be chosen and it\u0027ll essentially \"just work\" with any Nova deployment, as long as its unique on the network segment.  A PCI address cannot be chosen in any easy way, without having detailed knowledge of the cloud architecture and software versions and deployment setup. So the comparison is not really appropriate / useful.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"bfcd827f98f38253e5d5005fe35992cab4401322","unresolved":false,"context_lines":[{"line_number":190,"context_line":"learn that. In view of this, it is considered inappropriate"},{"line_number":191,"context_line":"to allow tenant users to control the guest device addressing"},{"line_number":192,"context_line":"via the REST API."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"As noted in the problem description another approach is for"},{"line_number":195,"context_line":"the tenant user to manually set tags via the existing mechanism"},{"line_number":196,"context_line":"for providing user metadata to guests. This however relies on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_906296ac","line":193,"in_reply_to":"da85f559_4d5b352f","updated":"2015-11-13 11:27:37.000000000","message":"NB you are commenting on an ancient patchset version - in future it is preferrable to put your comments on the most recent patchset.\n\nExposing this data via the metadata network service is just one channel. It can also be exposed via config drive. QEMU is also developing a method to provide metadata to the guest OS via a firmware blob which the guest kernel will then expose in sysfs. Furthermore, there\u0027s no reason an OS can\u0027t setup minimal networking required to reach the metadata service, fetch the data, and the perform the full networking setup.\n\nSo long term there\u0027s at least two alternatives to using network for obtaining the data from the host, and the network approach can be made to work.\n\nTo be clear, this alternative is just listed for the sake of completeness. Nova will not ever provide the ability for tenants to explicitly decide what PCI address each device uses as such a feature is the antithesis of the cloud paradigm as it requires the tenant to have intimate knowledge of multiple aspects of the backend hypervisor software which is just not appropriate.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":19284,"name":"Pablo Montes","email":"pablo.montesmoreno@telefonica.com","username":"PabloMontes"},"change_message_id":"df751a1fe993e957fb5c2c89789f87fe7020b520","unresolved":false,"context_lines":[{"line_number":190,"context_line":"learn that. In view of this, it is considered inappropriate"},{"line_number":191,"context_line":"to allow tenant users to control the guest device addressing"},{"line_number":192,"context_line":"via the REST API."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"As noted in the problem description another approach is for"},{"line_number":195,"context_line":"the tenant user to manually set tags via the existing mechanism"},{"line_number":196,"context_line":"for providing user metadata to guests. This however relies on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_bc6c6609","line":193,"in_reply_to":"da85f559_60a073a6","updated":"2015-11-16 14:18:14.000000000","message":"We understand that the destination PCI requirement is not aligned to cloud deployments, but the point is that we are trying to modify openstack, when required, to allow the deployment of dataplane intensive VNF.\n\nAttending to dpdk recommendation, many current dataplane intensive VNF are using in their code specific PCI addresses so creating a bluepring to allow the specification of the destination PCI address would be the only way to run these VNF.\n\nThe method described in this blueprint requires the VNF to be prepared for it, allowing the inclussion of an script to retrieve the metadata and then use this information to identify interfaces (so current VNFs should be modified, not being possible to use them as the vendors released them). Moreover, VNFs are not always based on standard Linux so the inclusion of this script could be problematic.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":19212,"name":"Antonio López","email":"antonio.lopezgracia@telefonica.com","username":"alogra"},"change_message_id":"863d2ee33b6c88531efe3f262eae10682a96c19f","unresolved":false,"context_lines":[{"line_number":190,"context_line":"learn that. In view of this, it is considered inappropriate"},{"line_number":191,"context_line":"to allow tenant users to control the guest device addressing"},{"line_number":192,"context_line":"via the REST API."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"As noted in the problem description another approach is for"},{"line_number":195,"context_line":"the tenant user to manually set tags via the existing mechanism"},{"line_number":196,"context_line":"for providing user metadata to guests. This however relies on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_f7e95d1b","line":193,"in_reply_to":"da85f559_906296ac","updated":"2015-11-17 17:19:46.000000000","message":"I do not understand why specifying the vPCI in the guest is the antithesis of the cloud paradigm, but specifying the mac address of a network interface in the guest is allowed. Would you mind to explain? Thanks","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":19285,"name":"Alfonso Tierno","email":"alf.tierno@gmail.com"},"change_message_id":"7da2a7e245ddb740859de7a2e4c1d949c7d8f983","unresolved":false,"context_lines":[{"line_number":190,"context_line":"learn that. In view of this, it is considered inappropriate"},{"line_number":191,"context_line":"to allow tenant users to control the guest device addressing"},{"line_number":192,"context_line":"via the REST API."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"As noted in the problem description another approach is for"},{"line_number":195,"context_line":"the tenant user to manually set tags via the existing mechanism"},{"line_number":196,"context_line":"for providing user metadata to guests. This however relies on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_a5198d24","line":193,"in_reply_to":"da85f559_906296ac","updated":"2015-11-13 14:59:48.000000000","message":"Sorry for comment on an ancient patchset. I noticed it after posting.\n\nI was not aware of the future firmware blob. Injecting metadata by \"config drive\" is one posibility, but is it available at openstack right know? . The option of partial network configuration though possible, seams complicated to implement.\n\nAnother problems I see: what happens if you make a live migration? Are the vPCI maintained?\n\nFinally, I do not fully understand why this issue implies that the tenant needs to have intimate knowledge of backend hypervisor. It is not needed to know what others vPCI has been asigned, neither the physical PCI that hosts this device. MAC address injection for example is allowed. \nMy suggestion is that at boot, Nova tries to assign this vPCI if requested. What if the hypervisor does not allow to? Return an error. What happens e.g. if later you try to add an interface and this vPCI is already use? Just return and error (propagate libvirt error). Indeed this can be limited only to interfaces (devices) defined at booting time.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b22a5c22c5940cc424ce1ff9a432e0865fdb065a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"learn that. In view of this, it is considered inappropriate"},{"line_number":191,"context_line":"to allow tenant users to control the guest device addressing"},{"line_number":192,"context_line":"via the REST API."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"As noted in the problem description another approach is for"},{"line_number":195,"context_line":"the tenant user to manually set tags via the existing mechanism"},{"line_number":196,"context_line":"for providing user metadata to guests. This however relies on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_60a073a6","line":193,"in_reply_to":"da85f559_a5198d24","updated":"2015-11-13 15:14:09.000000000","message":"As a bit of historical knowledge - the concept of the firmware blob is something that was originally proposed in Feb this year, as a way to pass arbitrary metadata to the guest\n\n  https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg00371.html\n\nThe implementation is in progress still\n\n  https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg01800.html\n\nProbably still a few months away before it can be used though.\n\nFor metadata today, OpenStack already supports both the config drive and metadata service. Cloud deployments may enable one or other of them, or both, so to be portable guests need to be capable of using either.  The firmware blob method would be a 3rd possible option. Metadata service obviously has the slight advantage that it can do live updates when hotplugging devices.\n\nWith live migration, libvirt takes great care to ensure device addresses *never* change. Allowing the device address to change would result in an almost immediate guest OS crash.\n\nThere are many complications with dealing with PCI addresses. First not all architectures use PCI. Within a single architecture, the topology of the PCI bus is arbitrarily defined by the hypervisor machine type setup. eg whether QEMU emulates a PIIX4 or a Q35 machine type changes where you can plug in devices. The choice of default machine type can change across different QEMU versions or different vendor builds. If the guest has PCI-E this places further restrictions / rules on what devices must be attached to which PCI/PCI-E bus. When the guest OS has multiple NUMA nodes, the PCI root you choose to attach the the device to affects which guest NUMA node the device will be associated with. IOW, allowing the tenant to choose PCI addresses results in a totally non-portable setup that is liable to break any time the hypervisor platform is upgraded, or break between different vendor\u0027s cloud deployments.","commit_id":"7206ae4a43a6964e86635f8c54767f0ab9e66fb9"}],"specs/mitaka/approved/virt-device-role-tagging.rst":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0e184d6f7a027c4a7f1b438991229c6edfc2145c","unresolved":false,"context_lines":[{"line_number":289,"context_line":"Documentation Impact"},{"line_number":290,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"The API documentation will ned to be updated to list the new tag"},{"line_number":293,"context_line":"parameter that is allowed against disk and network devices"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"The user documentation for cloud-init will need to describe the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a4dcd0f_952b4f94","line":292,"updated":"2015-08-04 16:43:51.000000000","message":"s/ned/need","commit_id":"0986c9f76a8194699c9cc431f6f3f989c38f7e54"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3ac5ad17f7dd61897f52e1d1230a8cc5fbd7129c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This will provide a mechanism for the user to tag a device they"},{"line_number":14,"context_line":"have assigned to their guest with a specific role. The tag will"},{"line_number":15,"context_line":"be matched to the hardware address of the device and this mapping"},{"line_number":16,"context_line":"exposed to the guest OS via metadata service/cloud-init"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_3138e9ee","line":16,"updated":"2015-09-17 13:14:16.000000000","message":"femtonit: full stop","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"5312fc06d44be394dfb8b3064f8762cf8449fa17","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The problem is that because Nova tries to hide as much detail"},{"line_number":51,"context_line":"of the guest hardware setup as possible, it is not easy for"},{"line_number":52,"context_line":"the tenant user to know what the unique idenfiers for each"},{"line_number":53,"context_line":"device are. For example, while with emulated NICs, it is"},{"line_number":54,"context_line":"possible to know the MAC address before booting the instance,"},{"line_number":55,"context_line":"when using PCI assigned devices, this is not available."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_f469238d","line":52,"updated":"2015-09-04 10:52:43.000000000","message":"s/idenfiers/identifiers/","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"5312fc06d44be394dfb8b3064f8762cf8449fa17","unresolved":false,"context_lines":[{"line_number":62,"context_line":"guarantee around the device ordering in the guest. By good"},{"line_number":63,"context_line":"fortune, the order in which disks are listed on the nova boot"},{"line_number":64,"context_line":"command line, often matches the order in which device letters"},{"line_number":65,"context_line":"are assigned by Linux, but nothing gaurantees this to be the"},{"line_number":66,"context_line":"case long term."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_94df8739","line":65,"updated":"2015-09-04 10:52:43.000000000","message":"s\\gaurantees/guarantees/","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3ac5ad17f7dd61897f52e1d1230a8cc5fbd7129c","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The proposal is to extend the REST API so that when adding"},{"line_number":97,"context_line":"disks or network interfaces to a guest instance, it is"},{"line_number":98,"context_line":"possible to pass an opaque string \"tag\"."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"When booting a guest, Nova will determine what PCI, USB,"},{"line_number":101,"context_line":"SCSI address corresponds to the device the user asked"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_8c43de41","line":98,"range":{"start_line":98,"start_character":35,"end_line":98,"end_character":38},"updated":"2015-09-17 13:14:16.000000000","message":"\"tag\" implies multiplicity to me, I strongly prefer \"label\".","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"38dfd39ff883902aff59d0af4698f4607e10dce8","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The proposal is to extend the REST API so that when adding"},{"line_number":97,"context_line":"disks or network interfaces to a guest instance, it is"},{"line_number":98,"context_line":"possible to pass an opaque string \"tag\"."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"When booting a guest, Nova will determine what PCI, USB,"},{"line_number":101,"context_line":"SCSI address corresponds to the device the user asked"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_541088a8","line":98,"in_reply_to":"ba15a1d1_8c43de41","updated":"2015-09-21 10:08:55.000000000","message":"I don\u0027t think that makes any difference at all.","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3ac5ad17f7dd61897f52e1d1230a8cc5fbd7129c","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"When the guest OS image boots up, it will read this metadata"},{"line_number":109,"context_line":"file to determine which devices need to be used for particular"},{"line_number":110,"context_line":"application services running in the instance. How the guest"},{"line_number":111,"context_line":"OS does this is outside the scope of this spec. Nova merely"},{"line_number":112,"context_line":"has to provide sufficient information in the metadata for the"},{"line_number":113,"context_line":"guest OS to reliably identify the devices."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_d1808dc1","line":111,"range":{"start_line":110,"start_character":46,"end_line":111,"end_character":46},"updated":"2015-09-17 13:14:16.000000000","message":"I\u0027d like some links at least, EG in the references section. It\u0027s not worth merging a feature which is only useful to BeOS guests.","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"38dfd39ff883902aff59d0af4698f4607e10dce8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"When the guest OS image boots up, it will read this metadata"},{"line_number":109,"context_line":"file to determine which devices need to be used for particular"},{"line_number":110,"context_line":"application services running in the instance. How the guest"},{"line_number":111,"context_line":"OS does this is outside the scope of this spec. Nova merely"},{"line_number":112,"context_line":"has to provide sufficient information in the metadata for the"},{"line_number":113,"context_line":"guest OS to reliably identify the devices."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_548728d7","line":111,"in_reply_to":"ba15a1d1_d1808dc1","updated":"2015-09-21 10:08:55.000000000","message":"This is an entirely new concept - there is no existing tools / OS which will deal with this file format, so there\u0027s nothing to link to. It is not tied to any OS - it is a simple structured text file, which any guest OS/app can interpret.","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3ac5ad17f7dd61897f52e1d1230a8cc5fbd7129c","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* The type of bus the device is attached to. This can be"},{"line_number":164,"context_line":"  pci, scsi, usb, ide and similar things. This is basically"},{"line_number":165,"context_line":"  saying how to interpret the device address"},{"line_number":166,"context_line":"* The device address. The format of the address varies"},{"line_number":167,"context_line":"  based on the bus, but would be the PCI address, or SCSI"},{"line_number":168,"context_line":"  address, of USB port, or IDE channel, etc."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_5156bd2a","line":165,"updated":"2015-09-17 13:14:16.000000000","message":"femtonit: full stop","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3ac5ad17f7dd61897f52e1d1230a8cc5fbd7129c","unresolved":false,"context_lines":[{"line_number":167,"context_line":"  based on the bus, but would be the PCI address, or SCSI"},{"line_number":168,"context_line":"  address, of USB port, or IDE channel, etc."},{"line_number":169,"context_line":"* The network device MAC address"},{"line_number":170,"context_line":"* The disk drive serial string (if set)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Note that not all architectures support PCI buses, for"},{"line_number":173,"context_line":"example armv7 and s390 don\u0027t, so in general all of the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_912775c9","line":170,"updated":"2015-09-17 13:14:16.000000000","message":"femtonit: full stops","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3ac5ad17f7dd61897f52e1d1230a8cc5fbd7129c","unresolved":false,"context_lines":[{"line_number":282,"context_line":"Testing"},{"line_number":283,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"It would be possible to write a new tempest test which created a guest"},{"line_number":286,"context_line":"with various NICs and disks, assigned tags to them, and then checked"},{"line_number":287,"context_line":"the guest facing metadata file."},{"line_number":288,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_cca236fc","line":285,"range":{"start_line":285,"start_character":0,"end_line":285,"end_character":20},"updated":"2015-09-17 13:14:16.000000000","message":"\"A tempest test will be written\" please","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"5312fc06d44be394dfb8b3064f8762cf8449fa17","unresolved":false,"context_lines":[{"line_number":289,"context_line":"Documentation Impact"},{"line_number":290,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"The API documentation will ned to be updated to list the new tag"},{"line_number":293,"context_line":"parameter that is allowed against disk and network devices"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"The user documentation for cloud-init will need to describe the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_34d0fb1e","line":292,"updated":"2015-09-04 10:52:43.000000000","message":"s/ned/need/","commit_id":"3bc96972cb176ea92b2e77199f11187f02a1cdcf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1039720a218539757f38d9be57c72359a17cb397","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      --block-device volume_id\u003d56789,bus\u003dvirtio,tag\u003dsquidcache \\"},{"line_number":128,"context_line":"      mynfvapp"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Libvirt could then auto-generate a metadata file that"},{"line_number":131,"context_line":"contained the following information"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_f12548ae","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":7},"updated":"2015-09-24 15:30:47.000000000","message":"This would actually be nova\u0027s responsibility, right?","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"efedb6e29c1b7eacd0797c3c50e50b09b67d68a5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      --block-device volume_id\u003d56789,bus\u003dvirtio,tag\u003dsquidcache \\"},{"line_number":128,"context_line":"      mynfvapp"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Libvirt could then auto-generate a metadata file that"},{"line_number":131,"context_line":"contained the following information"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_7cba51e3","line":130,"in_reply_to":"9a1a9d01_f12548ae","updated":"2015-09-25 08:36:16.000000000","message":"Yeah, badly worded. The Nova libvirt driver would figure out the actual metadata that needs presenting, and Nova generic code would generate the final file.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1039720a218539757f38d9be57c72359a17cb397","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            \"mac\": \"01:22:22:42:22:21\","},{"line_number":146,"context_line":"        },"},{"line_number":147,"context_line":"    },"},{"line_number":148,"context_line":"    \"disk-tags\": {"},{"line_number":149,"context_line":"        \"oracledb\": {"},{"line_number":150,"context_line":"            \"bus\": \"scsi\","},{"line_number":151,"context_line":"            \"address\": \"1:0:2:0\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_b157d0c9","line":148,"updated":"2015-09-24 15:30:47.000000000","message":"Not that it\u0027s a real problem, but do we need ${func}-tags groups?\n\nSeems like we could use something like \"uid\" as the unique identifier field, which would be mac for network, serial for disk, index for serial, etc. The reason I ask is...","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c4cbee28a6b5ecad94e5d1e94ab520827d9aad07","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            \"mac\": \"01:22:22:42:22:21\","},{"line_number":146,"context_line":"        },"},{"line_number":147,"context_line":"    },"},{"line_number":148,"context_line":"    \"disk-tags\": {"},{"line_number":149,"context_line":"        \"oracledb\": {"},{"line_number":150,"context_line":"            \"bus\": \"scsi\","},{"line_number":151,"context_line":"            \"address\": \"1:0:2:0\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_9fb945ec","line":148,"in_reply_to":"9a1a9d01_3c35b945","updated":"2015-09-25 16:36:28.000000000","message":"Ah, good point. I was thinking more about the leaf keys, but wasn\u0027t thinking about the tag collision.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"efedb6e29c1b7eacd0797c3c50e50b09b67d68a5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            \"mac\": \"01:22:22:42:22:21\","},{"line_number":146,"context_line":"        },"},{"line_number":147,"context_line":"    },"},{"line_number":148,"context_line":"    \"disk-tags\": {"},{"line_number":149,"context_line":"        \"oracledb\": {"},{"line_number":150,"context_line":"            \"bus\": \"scsi\","},{"line_number":151,"context_line":"            \"address\": \"1:0:2:0\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_3c35b945","line":148,"in_reply_to":"9a1a9d01_b157d0c9","updated":"2015-09-25 08:36:16.000000000","message":"Well the tag names are only intended to be unique within the context of the device type. eg, it would be valid to use the tag \"database\" against both a disk and a network interface. Having the device type grouping also lets us define in the schema for what kind of device type specific elements will be present (eg mac addr vs serial)","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1039720a218539757f38d9be57c72359a17cb397","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \"serial\": \"disk-vol-24235252\""},{"line_number":158,"context_line":"        },"},{"line_number":159,"context_line":"    }"},{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"In this example, we have provide a few bits of information about"},{"line_number":163,"context_line":"the devices"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_f12b0832","line":160,"updated":"2015-09-24 15:30:47.000000000","message":"After this sample, could you put the jsonschema representation? We\u0027d surely want to make sure this is tightly controlled and verified as it would be part of our guest \"ABI\" once it\u0027s in metadata. This is one reason it may be easier to avoid the grouping sections, so that it\u0027s easier for us to add new things later (i.e. serial, etc).","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"efedb6e29c1b7eacd0797c3c50e50b09b67d68a5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \"serial\": \"disk-vol-24235252\""},{"line_number":158,"context_line":"        },"},{"line_number":159,"context_line":"    }"},{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"In this example, we have provide a few bits of information about"},{"line_number":163,"context_line":"the devices"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_fc7c2122","line":160,"in_reply_to":"9a1a9d01_f12b0832","updated":"2015-09-25 08:36:16.000000000","message":"Yeah, I should have clearly stated this is ABI sensitive. We\u0027d want to define a set of standard internal classes to represent this data in a manner that we can guarantee virt drivers all follow the same format. It could potentially be worthwhile using Nova^Holso.versioned objects here and their default JSON serialization schema for this purpose.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c4cbee28a6b5ecad94e5d1e94ab520827d9aad07","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \"serial\": \"disk-vol-24235252\""},{"line_number":158,"context_line":"        },"},{"line_number":159,"context_line":"    }"},{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"In this example, we have provide a few bits of information about"},{"line_number":163,"context_line":"the devices"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_9fe2a502","line":160,"in_reply_to":"9a1a9d01_fc7c2122","updated":"2015-09-25 16:36:28.000000000","message":"Yeah, maybe but that would be a more complicated structure to parse if all you have in the guest is JSON. I think I would stick to a specific JSON structure with a schema specified unless lots of people thing that a serialized object is correct here.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1039720a218539757f38d9be57c72359a17cb397","unresolved":false,"context_lines":[{"line_number":176,"context_line":"attributes would be considered optional. The virt driver"},{"line_number":177,"context_line":"in Nova would endeavour to make available as much information"},{"line_number":178,"context_line":"as it had readily available depending on the guest config"},{"line_number":179,"context_line":"and hypervisor / architecture constraints."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"The implementation will be written for the libvirt driver with"},{"line_number":182,"context_line":"a view towards KVM, however, the concepts described here are"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_9192cc56","line":179,"updated":"2015-09-24 15:30:47.000000000","message":"Certainly we can just have something in the bus and address fields that make sense even for weirdo platforms, right? I\u0027d really aim for consistency here as stuff like this will be parsed by bash init scripts and overly-simple-and-not-always-well-tested python helpers.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c4cbee28a6b5ecad94e5d1e94ab520827d9aad07","unresolved":false,"context_lines":[{"line_number":176,"context_line":"attributes would be considered optional. The virt driver"},{"line_number":177,"context_line":"in Nova would endeavour to make available as much information"},{"line_number":178,"context_line":"as it had readily available depending on the guest config"},{"line_number":179,"context_line":"and hypervisor / architecture constraints."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"The implementation will be written for the libvirt driver with"},{"line_number":182,"context_line":"a view towards KVM, however, the concepts described here are"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_7fab118a","line":179,"in_reply_to":"9a1a9d01_5c118dab","updated":"2015-09-25 16:36:28.000000000","message":"Just a counter/index for those seems like it should be plenty. But yeah, anyway, less optional stuff is better IMHO.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"efedb6e29c1b7eacd0797c3c50e50b09b67d68a5","unresolved":false,"context_lines":[{"line_number":176,"context_line":"attributes would be considered optional. The virt driver"},{"line_number":177,"context_line":"in Nova would endeavour to make available as much information"},{"line_number":178,"context_line":"as it had readily available depending on the guest config"},{"line_number":179,"context_line":"and hypervisor / architecture constraints."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"The implementation will be written for the libvirt driver with"},{"line_number":182,"context_line":"a view towards KVM, however, the concepts described here are"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_5c118dab","line":179,"in_reply_to":"9a1a9d01_9192cc56","updated":"2015-09-25 08:36:16.000000000","message":"We can certainly make sure we always have something in the bus field. I\u0027m not so sure about the address field - will have to research those odd architectures some more...","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1039720a218539757f38d9be57c72359a17cb397","unresolved":false,"context_lines":[{"line_number":182,"context_line":"a view towards KVM, however, the concepts described here are"},{"line_number":183,"context_line":"applicable to any virtualization driver in Nova. Implementing"},{"line_number":184,"context_line":"this for non-libvirt drivers will be left as an exercise for"},{"line_number":185,"context_line":"their respective maintainers."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Alternatives"},{"line_number":188,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_91796c32","line":185,"updated":"2015-09-24 15:30:47.000000000","message":"I kinda think that if this is going into metadata we should have a plan in place for all the current drivers. That doesn\u0027t seem overly burdensome to me.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1039720a218539757f38d9be57c72359a17cb397","unresolved":false,"context_lines":[{"line_number":213,"context_line":"gain a freeform string attribute, named \"tag\"."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The NetworkRequest object (and associated table) will"},{"line_number":216,"context_line":"gain a freeform string attribute, named \"tag\"."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"REST API impact"},{"line_number":219,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_b134b04a","line":216,"updated":"2015-09-24 15:30:47.000000000","message":"Obviously disk and network are the key things here, but could we at least spec out what other devices are likely to want this, even if it\u0027s not part of the initial implementation?\n\nI can see this being extremely important for multiple PCI device passthrough scenarios. Even though I use serial above, that\u0027s probably not a good example for cloud, but it _is_ simple to enumerate.\n\nWhat about consoles? In a spice multi-display VDI situation, perhaps they would utilize tags as well?","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"efedb6e29c1b7eacd0797c3c50e50b09b67d68a5","unresolved":false,"context_lines":[{"line_number":213,"context_line":"gain a freeform string attribute, named \"tag\"."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The NetworkRequest object (and associated table) will"},{"line_number":216,"context_line":"gain a freeform string attribute, named \"tag\"."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"REST API impact"},{"line_number":219,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_fc542155","line":216,"in_reply_to":"9a1a9d01_b134b04a","updated":"2015-09-25 08:36:16.000000000","message":"Agree, PCI device passthrough is certainly an important scenario.\n\nWe do already have multiple serial port support. This is just represented as a image prop giving the serial port count, but if we did ever expand that, we could potentially tag serial ports with specific purposes. We could certainly do the same if we ever did multi-head VDI.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1039720a218539757f38d9be57c72359a17cb397","unresolved":false,"context_lines":[{"line_number":225,"context_line":"terms of Nova client this would be visible as a new"},{"line_number":226,"context_line":"supported key against the --block-device flag. e.g."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  nova boot --block-device id\u003dUUID,source\u003dimage,tag\u003ddatabase"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"The server create API gain a new freeform string parameter"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_b18270c7","line":228,"updated":"2015-09-24 15:30:47.000000000","message":"Since you mention interface-attach below, volume-attach here as well?","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"efedb6e29c1b7eacd0797c3c50e50b09b67d68a5","unresolved":false,"context_lines":[{"line_number":225,"context_line":"terms of Nova client this would be visible as a new"},{"line_number":226,"context_line":"supported key against the --block-device flag. e.g."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  nova boot --block-device id\u003dUUID,source\u003dimage,tag\u003ddatabase"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"The server create API gain a new freeform string parameter"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_bc4ea9bf","line":228,"in_reply_to":"9a1a9d01_b18270c7","updated":"2015-09-25 08:36:16.000000000","message":"Yep, good point.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1039720a218539757f38d9be57c72359a17cb397","unresolved":false,"context_lines":[{"line_number":241,"context_line":"as a new flag. e.g."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"  nova interface-attach UUID --net-id UUID --port-id UUID --tag database"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Security impact"},{"line_number":246,"context_line":"---------------"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_11cc7c34","line":244,"updated":"2015-09-24 15:30:47.000000000","message":"Maybe I missed it above, but is there a uniqueness constraint on a given tag per instance? Presumably it\u0027s per-instance-per-device-type, such that it\u0027s okay for me to tag a disk and nic as \"squid\", right?","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"efedb6e29c1b7eacd0797c3c50e50b09b67d68a5","unresolved":false,"context_lines":[{"line_number":241,"context_line":"as a new flag. e.g."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"  nova interface-attach UUID --net-id UUID --port-id UUID --tag database"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Security impact"},{"line_number":246,"context_line":"---------------"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_3cd139ce","line":244,"in_reply_to":"9a1a9d01_11cc7c34","updated":"2015-09-25 08:36:16.000000000","message":"Yes, uniqueness is assumed to be per instance per device type.","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c4cbee28a6b5ecad94e5d1e94ab520827d9aad07","unresolved":false,"context_lines":[{"line_number":241,"context_line":"as a new flag. e.g."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"  nova interface-attach UUID --net-id UUID --port-id UUID --tag database"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Security impact"},{"line_number":246,"context_line":"---------------"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_7f0c7194","line":244,"in_reply_to":"9a1a9d01_3cd139ce","updated":"2015-09-25 16:36:28.000000000","message":"So we\u0027ll want to be extra careful not to allow this. It\u0027s easy to do in the API for a boot request, but we\u0027d want to be sure that two volume- or interface-attach requests don\u0027t race to add duplicates. Not sure what my suggestion is here, so just a note for the future at least :)","commit_id":"f478205c53976f99515cb3bacc1482c2794f6e0b"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"130e753fc57d99076b53009850c9facce3c373f4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"      --nic net-id\u003d12345,tag\u003dnfvfunc1 \\"},{"line_number":121,"context_line":"      --nic net-id\u003d56789,tag\u003dnfvfunc2 \\"},{"line_number":122,"context_line":"      --block-device volume_id\u003d12345,bus\u003dscsi,tag\u003doracledb \\"},{"line_number":123,"context_line":"      --block-device volume_id\u003d56789,bus\u003dvirtio,tag\u003dsquidcache \\"},{"line_number":124,"context_line":"      mynfvapp"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The Nova could then auto-generate a metadata file that contained"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a29b11f_60dedb40","line":123,"updated":"2015-10-20 14:48:37.000000000","message":"With Xen HVM guests may start with an emulated device (i.e. on one bus) and negotiate up to PV devices.  In the case of an installer, PV drivers may not be included in the kernel.\n\nThese two devices will be referenced in different ways (e.g. scsi vs xenbus)","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"130e753fc57d99076b53009850c9facce3c373f4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        \"nfvfunc2\": {"},{"line_number":140,"context_line":"            \"bus\": \"pci\","},{"line_number":141,"context_line":"            \"address\": \"0000:00:03.0\","},{"line_number":142,"context_line":"            \"mac\": \"01:22:22:42:22:21\""},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":"    },"},{"line_number":145,"context_line":"    \"disktags\": {"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a29b11f_a0bdd369","line":142,"updated":"2015-10-20 14:48:37.000000000","message":"Two nics with the same MAC is fun","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"efec259aba202a11530939caf27758461fbca2b7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            \"serial\": \"disk-vol-24235252\""},{"line_number":155,"context_line":"        }"},{"line_number":156,"context_line":"     }"},{"line_number":157,"context_line":"  }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"In this example, we have provide a few bits of information about"},{"line_number":160,"context_line":"the devices"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_0d1e7bba","line":157,"updated":"2015-11-17 04:29:10.000000000","message":"Instead of the nictags, disktags, pcitags, and misctags top-level keys in the returned dictionary, how about we just have a /latest/meta-data/devices resource in the metadata endpoint that returned a file with device information in the following format:\n\n [\n   {\n     \"type\": \"disk\",\n     \"address\": \"1:0:2:0\",\n     \"bus\": \"scsi\",\n     \"serial\": \"disk-vol-2323423\",\n     \"tags\": [\"oracledb\"]\n   },\n   {\n     \"type\": \"disk\",\n     \"address\": \"0000:00:7.0\",\n     \"bus\": \"virtio\",\n     \"serial\": \"disk-vol-2323452\",\n     \"tags\": [\"squidcache\"]\n   },\n   {\n     \"type\": \"nic\",\n     \"address\": \"0000:00:02.0\",\n     \"bus\": \"pci\",\n     \"mac\": \"01:22:22:42:22:21\",\n     \"tags\": [\"nfvfunc1\"]\n   },\n   {\n     \"type\": \"nic\",\n     \"address\": \"0000:00:03.0\",\n     \"bus\": \"pci\",\n     \"mac\": \"01:22:22:42:22:22\",\n     \"tags\": [\"nfvfunc2\"]\n   }\n ]\n\nI think the above format would be a bit more future-proof (it doesn\u0027t require additional top-level keys to be parsed if you add additional types of devices) and has the advantage of allowing multiple tags per device instead of encoding a single tag as the key for a device in the top-level dict as your original suggested format.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e200bff367ca5d3318523741894b71b57138b828","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            \"serial\": \"disk-vol-24235252\""},{"line_number":155,"context_line":"        }"},{"line_number":156,"context_line":"     }"},{"line_number":157,"context_line":"  }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"In this example, we have provide a few bits of information about"},{"line_number":160,"context_line":"the devices"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_2b647d47","line":157,"in_reply_to":"ba8a016a_0d1e7bba","updated":"2015-11-17 10:19:36.000000000","message":"FWIW, the main reason it was structured the way I showed was to encode a guarantee that tag names were unique per device type. ie, do not allow 2 nics both with the same tag \"nfvfunc1\".   Now I guess we can guarantee that in the Nova code, so its not the end of the world if the metadata json doesn\u0027t guarantee it too..","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"795100be392b9ede57ae4d8c99516c477071a5ee","unresolved":false,"context_lines":[{"line_number":245,"context_line":"              },"},{"line_number":246,"context_line":"              \"required\": [ \"bus\" ]"},{"line_number":247,"context_line":"          },"},{"line_number":248,"context_line":"          \"idedevice\": {"},{"line_number":249,"context_line":"              \"type\": \"object\","},{"line_number":250,"context_line":"              \"properties\": {"},{"line_number":251,"context_line":"                  \"bus\": {"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a29b11f_fb637cda","line":248,"updated":"2015-10-20 14:50:34.000000000","message":"Would be nice to include a PV device example, and an example for LXC.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"change_message_id":"b8aca744085826d32b8fbbabe9142bba8758a20a","unresolved":false,"context_lines":[{"line_number":245,"context_line":"              },"},{"line_number":246,"context_line":"              \"required\": [ \"bus\" ]"},{"line_number":247,"context_line":"          },"},{"line_number":248,"context_line":"          \"idedevice\": {"},{"line_number":249,"context_line":"              \"type\": \"object\","},{"line_number":250,"context_line":"              \"properties\": {"},{"line_number":251,"context_line":"                  \"bus\": {"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_3af83749","line":248,"in_reply_to":"3a29b11f_fb637cda","updated":"2015-11-17 15:04:41.000000000","message":"I\u0027d like to see an lxc also.  Its may make sense in lxc to explicitly provide \u0027path\u0027 (/dev/newdevice).","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f7ea58342956fb3ff008b05a89001d1259b536f4","unresolved":false,"context_lines":[{"line_number":321,"context_line":"these classes with the data associated with each instance."},{"line_number":322,"context_line":"The initial implementation will be done for the Libvirt"},{"line_number":323,"context_line":"driver, however, other virt driver maintainers are"},{"line_number":324,"context_line":"encouraged to provide the same functionality."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The metadata API will be extended to be capable of reporting"},{"line_number":327,"context_line":"this data associated with a guest instance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a2ca52d_31f372a0","line":324,"updated":"2015-10-14 18:36:55.000000000","message":"So, I feel like this probably means \"libvirt will be the only driver to ever support this\". I know it\u0027s hardly fair to require you to do the work for the others, but I also think it probably means that this isn\u0027t going to see a lot of cross-driver review and implementation.\n\nI\u0027d really like to see if we can get at least one other driver author to sign up to work on this for their driver, and thus review it for applicability.\n\nI would think claudiu would be interested from the hyper-v perspective, and maybe gary on vmware.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b85dd5d681e0cb16042d8f4d50a0eb68e914f9e1","unresolved":false,"context_lines":[{"line_number":321,"context_line":"these classes with the data associated with each instance."},{"line_number":322,"context_line":"The initial implementation will be done for the Libvirt"},{"line_number":323,"context_line":"driver, however, other virt driver maintainers are"},{"line_number":324,"context_line":"encouraged to provide the same functionality."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The metadata API will be extended to be capable of reporting"},{"line_number":327,"context_line":"this data associated with a guest instance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a2ca52d_cc54b822","line":324,"in_reply_to":"5a2ca52d_31f372a0","updated":"2015-10-15 14:15:43.000000000","message":"I also think that the tags may be covered in https://review.openstack.org/128940. So we need to see that there is no overlap here.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"130e753fc57d99076b53009850c9facce3c373f4","unresolved":false,"context_lines":[{"line_number":321,"context_line":"these classes with the data associated with each instance."},{"line_number":322,"context_line":"The initial implementation will be done for the Libvirt"},{"line_number":323,"context_line":"driver, however, other virt driver maintainers are"},{"line_number":324,"context_line":"encouraged to provide the same functionality."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The metadata API will be extended to be capable of reporting"},{"line_number":327,"context_line":"this data associated with a guest instance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a29b11f_80af7793","line":324,"in_reply_to":"5a2ca52d_31f372a0","updated":"2015-10-20 14:48:37.000000000","message":"We\u0027d like to track this from XenAPI perspective too","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e9a12d6034856484db6589a1509ff4d0c5aec750","unresolved":false,"context_lines":[{"line_number":321,"context_line":"these classes with the data associated with each instance."},{"line_number":322,"context_line":"The initial implementation will be done for the Libvirt"},{"line_number":323,"context_line":"driver, however, other virt driver maintainers are"},{"line_number":324,"context_line":"encouraged to provide the same functionality."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The metadata API will be extended to be capable of reporting"},{"line_number":327,"context_line":"this data associated with a guest instance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a2ca52d_e7faefbc","line":324,"in_reply_to":"5a2ca52d_cc54b822","updated":"2015-10-15 14:20:46.000000000","message":"As far as I can tell, that patch is for tags on entire instances. Here we\u0027re proposing tags on individual devices.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8729c91e975df160da88994f8174ecabba0d284b","unresolved":false,"context_lines":[{"line_number":321,"context_line":"these classes with the data associated with each instance."},{"line_number":322,"context_line":"The initial implementation will be done for the Libvirt"},{"line_number":323,"context_line":"driver, however, other virt driver maintainers are"},{"line_number":324,"context_line":"encouraged to provide the same functionality."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The metadata API will be extended to be capable of reporting"},{"line_number":327,"context_line":"this data associated with a guest instance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a2ca52d_42ce31b5","line":324,"in_reply_to":"5a2ca52d_cc54b822","updated":"2015-10-15 14:36:36.000000000","message":"Per our discussion on IRC, that instance tagging spec is orthogonal to this spec - they\u0027re both separate pieces of work / features that just happen to share the word \"tag\" to refer to a user specified opaque string.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6f412e87c75d79b7a1c8b7d56beb1fbd96f8376d","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"The config driver generator will be extended to be capable"},{"line_number":330,"context_line":"of including this JSON data associated with a guest instance."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"Alternatives"},{"line_number":333,"context_line":"------------"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a29b11f_207ea319","line":331,"updated":"2015-10-20 14:41:17.000000000","message":"This is outside the scope of Nova itself, but we almost certainly want to provide some kind of standard guest tooling support.\n\nFor Linux this could entail providing a script which reads the metadata file, locates the devices, and then sets an OPENSTACK_DEV_TAG\u003d$TAGNAME property against the device in the udev database. Such a script could be invoked from cloud-init\n\nThat way an application can simply query udev for device with the matching tag, and it would not need to directly care about accessing this metadata file itself. This insulates apps from knowing about different device buses / addresses / etc too, which is desirable.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"795100be392b9ede57ae4d8c99516c477071a5ee","unresolved":false,"context_lines":[{"line_number":402,"context_line":"ensure that the supplied \"tag\" string is unique within the"},{"line_number":403,"context_line":"scope of (instance, device-type). ie you cannot have two"},{"line_number":404,"context_line":"NICs on the same instance with the same \"tag\", but you can"},{"line_number":405,"context_line":"have a disk and a NIC with the same \"tag\"."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"This will require a new API microversion"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a29b11f_405b9f54","line":405,"updated":"2015-10-20 14:50:34.000000000","message":"Can we please define what happens when no tag is defined.\n\nIts tempting to default to something like \"disk1\" and \"vif1\" by default.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"795100be392b9ede57ae4d8c99516c477071a5ee","unresolved":false,"context_lines":[{"line_number":404,"context_line":"NICs on the same instance with the same \"tag\", but you can"},{"line_number":405,"context_line":"have a disk and a NIC with the same \"tag\"."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"This will require a new API microversion"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"Security impact"},{"line_number":410,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a29b11f_002cc7a9","line":407,"updated":"2015-10-20 14:50:34.000000000","message":"For consistency, I feel we should really return this tag in the server details, not just inside the guest, ideally.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"77325f73099815edcbc821c7ee5edb8278851c65","unresolved":false,"context_lines":[{"line_number":404,"context_line":"NICs on the same instance with the same \"tag\", but you can"},{"line_number":405,"context_line":"have a disk and a NIC with the same \"tag\"."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"This will require a new API microversion"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"Security impact"},{"line_number":410,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a29b11f_acbefe62","line":407,"in_reply_to":"3a29b11f_002cc7a9","updated":"2015-10-21 12:37:43.000000000","message":"Agreed, anything we provide in on the API should be seeable by the API later.","commit_id":"4d8ac0f18504566580a0776c7e29847679e40265"},{"author":{"_account_id":18797,"name":"Alexander Duyck","email":"alexander.duyck@gmail.com","username":"ahduyck"},"change_message_id":"e2fb844ce66267cadf4acd419c242113c8f541e0","unresolved":false,"context_lines":[{"line_number":161,"context_line":"      }"},{"line_number":162,"context_line":"    ]"},{"line_number":163,"context_line":"  }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"In this example, we have provide a few bits of information about"},{"line_number":166,"context_line":"the devices"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a8ffd7b_ae567204","line":164,"updated":"2015-11-24 13:44:49.000000000","message":"It looks like you have a typo in your example here.  Shouldn\u0027t the two nics be nfvfunc1 and nfvfunc2 and the disks  be oracledb and switchcache?","commit_id":"13ac327b3f7a58161f074cd8b8588e4e4fbba74e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"263b57ef814a8f66a4714c8e6c90181add856d16","unresolved":false,"context_lines":[{"line_number":161,"context_line":"      }"},{"line_number":162,"context_line":"    ]"},{"line_number":163,"context_line":"  }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"In this example, we have provide a few bits of information about"},{"line_number":166,"context_line":"the devices"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a8ffd7b_6bee258d","line":164,"in_reply_to":"9a8ffd7b_ae567204","updated":"2015-11-24 19:36:06.000000000","message":"looking at the commands on lines 119-123 yes the tags for the nics and disks are swapped.","commit_id":"13ac327b3f7a58161f074cd8b8588e4e4fbba74e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"263b57ef814a8f66a4714c8e6c90181add856d16","unresolved":false,"context_lines":[{"line_number":482,"context_line":"          \"tags\": [\"nfvfunc2\"]"},{"line_number":483,"context_line":"      }"},{"line_number":484,"context_line":"    ]"},{"line_number":485,"context_line":"  }"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"Some things to note about this LXC example:"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a8ffd7b_ab588d57","line":485,"updated":"2015-11-24 19:36:06.000000000","message":"same as Alexander pointed out above i guess the tags are reversed if this is trying to be consistent with lines 119-123.","commit_id":"13ac327b3f7a58161f074cd8b8588e4e4fbba74e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f02698c398071508051d1ec823381870a9bc51da","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  nova boot \\"},{"line_number":118,"context_line":"      --image mywebappimage \\"},{"line_number":119,"context_line":"      --flavor m1.large \\"},{"line_number":120,"context_line":"      --nic net-id\u003d12345,tag\u003dnfvfunc1 \\"},{"line_number":121,"context_line":"      --nic net-id\u003d56789,tag\u003dnfvfunc2 \\"},{"line_number":122,"context_line":"      --block-device volume_id\u003d12345,bus\u003dscsi,tag\u003doracledb \\"},{"line_number":123,"context_line":"      --block-device volume_id\u003d56789,bus\u003dvirtio,tag\u003dsquidcache \\"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a8ffd7b_ce2b69ea","line":120,"updated":"2015-11-25 16:11:32.000000000","message":"nit: I would rather the example used a pre-created port uuid, but anyways.","commit_id":"3f95ef64f61d5275b24e3438f19c100f8b5d013c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f02698c398071508051d1ec823381870a9bc51da","unresolved":false,"context_lines":[{"line_number":384,"context_line":"needing to deal with the countless different device bus types"},{"line_number":385,"context_line":"or addressing formats."},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"Example for Xen HVM with dual-disk devices"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"::"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a8ffd7b_4e55394e","line":387,"updated":"2015-11-25 16:11:32.000000000","message":"Thank you for covering this nasty example.\n\nI though we also get double VIFs, but lets ignore that.","commit_id":"3f95ef64f61d5275b24e3438f19c100f8b5d013c"}]}
