)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"2ac013451aeb159dccbe4d527f471db93a3b4c46","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ghanshyam \u003cghanshyam.mann@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-30 13:24:22 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pec for \"tenant_id\" \"user_id\" filter implies \"all_tenant\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"APIImpact"},{"line_number":10,"context_line":"Implements: blueprint list-filter-with-tenant-or-user-id-should-implies-all-tenants"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a1a9d01_b517ee43","line":7,"updated":"2015-09-30 14:14:34.000000000","message":"spec","commit_id":"933699e0a26e400aebefaab39c363671b535ad2d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9c12013b5e942b0c1bd951eebed63898f3fa68f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ghanshyam \u003cghanshyam.mann@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-30 13:24:22 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pec for \"tenant_id\" \"user_id\" filter implies \"all_tenant\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"APIImpact"},{"line_number":10,"context_line":"Implements: blueprint list-filter-with-tenant-or-user-id-should-implies-all-tenants"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_3aaeb998","line":7,"in_reply_to":"9a1a9d01_b517ee43","updated":"2015-10-08 01:54:02.000000000","message":"ops. Thanks","commit_id":"933699e0a26e400aebefaab39c363671b535ad2d"}],"specs/liberty/approved/list-filter-with-tenant-id-should-implies-all-tenants.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"624052453376696d52221ba3ea9b784104365323","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/list-filter-with-tenant-id-should-implies-all-tenants"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Admin request to server list filter with \"tenant_id\" should implies"},{"line_number":14,"context_line":"\"all_tenants\" flag to get correct list of servers for requested tenant."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_a4cc8389","line":13,"updated":"2015-07-03 08:46:14.000000000","message":"nit: s/request/requests/","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"026f41282c7ac71c936f8bfc49f2831d7ebd28b3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/list-filter-with-tenant-id-should-implies-all-tenants"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Admin request to server list filter with \"tenant_id\" should implies"},{"line_number":14,"context_line":"\"all_tenants\" flag to get correct list of servers for requested tenant."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_3fa71cbe","line":13,"in_reply_to":"ba3cc151_a4cc8389","updated":"2015-07-03 09:03:56.000000000","message":"Done","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c0148ba4c3102f6a5c96d1ad7dd966b34f8587ff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Flag \"all_tenants\" should not be required for \"tenant_id\" filter to"},{"line_number":43,"context_line":"function properly."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If admin is searching servers with filter \"tenant_id\" then, this should"},{"line_number":46,"context_line":"imply that all_tenants is also enabled unless that is explicitly disabled."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_218e252e","line":43,"updated":"2015-07-03 08:05:23.000000000","message":"Better describe whether --all_tenants\u003dTrue and --tenant_id\u003d* keep same behavior","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"026f41282c7ac71c936f8bfc49f2831d7ebd28b3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Flag \"all_tenants\" should not be required for \"tenant_id\" filter to"},{"line_number":43,"context_line":"function properly."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If admin is searching servers with filter \"tenant_id\" then, this should"},{"line_number":46,"context_line":"imply that all_tenants is also enabled unless that is explicitly disabled."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_9f23c855","line":43,"in_reply_to":"ba3cc151_218e252e","updated":"2015-07-03 09:03:56.000000000","message":"Done","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c0148ba4c3102f6a5c96d1ad7dd966b34f8587ff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"function properly."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If admin is searching servers with filter \"tenant_id\" then, this should"},{"line_number":46,"context_line":"imply that all_tenants is also enabled unless that is explicitly disabled."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_e1acbda0","line":46,"updated":"2015-07-03 08:05:23.000000000","message":"better to describe what will return when --all_tenants\u003dFalse and --tenant_id specified","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"026f41282c7ac71c936f8bfc49f2831d7ebd28b3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"function properly."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If admin is searching servers with filter \"tenant_id\" then, this should"},{"line_number":46,"context_line":"imply that all_tenants is also enabled unless that is explicitly disabled."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_bf1ecc09","line":46,"in_reply_to":"ba3cc151_e1acbda0","updated":"2015-07-03 09:03:56.000000000","message":"Done","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4aa598d225414ca0276dc2bf048fdd9abd235f9d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Request::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    GET /servers?tenant_id\u003d\u003cid\u003e"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_411c8969","line":63,"updated":"2015-07-03 07:55:20.000000000","message":"Please just state about adding a microversion, and what happens for old requests.","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"624052453376696d52221ba3ea9b784104365323","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Request::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    GET /servers?tenant_id\u003d\u003cid\u003e"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_c4b2e705","line":63,"in_reply_to":"ba3cc151_411c8969","updated":"2015-07-03 08:46:14.000000000","message":"+1, nice point.\nWe will be able to know the difference between new and old behaviors.","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"026f41282c7ac71c936f8bfc49f2831d7ebd28b3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Request::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    GET /servers?tenant_id\u003d\u003cid\u003e"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_5f19c020","line":63,"in_reply_to":"ba3cc151_411c8969","updated":"2015-07-03 09:03:56.000000000","message":"Done","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e82511653c501d7a8f64f0b6bf9c3de64b046fa0","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The request and response headers, body and possible codes are unchanged from"},{"line_number":68,"context_line":"current behavior. The \"tenant_id\" filter will work properly."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Security impact"},{"line_number":71,"context_line":"---------------"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_21886570","line":69,"updated":"2015-07-03 07:56:23.000000000","message":"if the user requests one of these flags, but they are not allowed it, we should start returning BadRequest.\n\nMaybe its a good time to do that now?","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"026f41282c7ac71c936f8bfc49f2831d7ebd28b3","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The request and response headers, body and possible codes are unchanged from"},{"line_number":68,"context_line":"current behavior. The \"tenant_id\" filter will work properly."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Security impact"},{"line_number":71,"context_line":"---------------"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_011be181","line":69,"in_reply_to":"ba3cc151_21886570","updated":"2015-07-03 09:03:56.000000000","message":"Yea it should be BadRequest, currently we just log and strip out those filter - https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/servers.py#L276\n\nBy doing that, it makes list server backward incompatible (as its going to return error for users who are passing not-allowed filter).\n\nI think we should do that as separate version not to mix with this fix. So that users can opt version easily/clearly.","commit_id":"5817a8a091cf15e2148663dd5c39efff26207975"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"04138e6d8c9c6e21301ec5d146b925357407bb59","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"For example:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- nova list --tenant xyz --all-tenants 1"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"If \"all_tenants\" flag is not mentioned, then it returns empty list with"},{"line_number":28,"context_line":"200 response code."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a41bdd9_e7b0118e","line":25,"updated":"2015-07-13 02:36:33.000000000","message":"There is same problem with user_id\n\ncurl -g -i -X GET http://hp-pc:8774/v2/475f5b67eb9a4f3f8bef785e66912a60/servers/detail?user_id\u003df2f600122fcf4ee4adf697cfb9b385f4 -H \"User-Agent: python-novaclient\" -H \"Accept: application/json\" -H \"X-Auth-Token: 542d4a251aa54a918525a0b300dde5bf\"\nHTTP/1.1 200 OK\nContent-Type: application/json\nContent-Length: 15\nX-Openstack-Nova-Api-Version: 2.1\nVary: X-OpenStack-Nova-API-Version\nX-Compute-Request-Id: req-dbca364e-f938-4213-a940-05d865bb1c65\nDate: Mon, 13 Jul 2015 02:41:47 GMT\n\n{\"servers\": []}\n\n\nShould we fix this also?","commit_id":"a39fbfe62f8fa70a1317246f649538a390b0a23d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0622c2311f9b7ea3f60a8c6e5aba6222934fde7b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"For example:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- nova list --tenant xyz --all-tenants 1"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"If \"all_tenants\" flag is not mentioned, then it returns empty list with"},{"line_number":28,"context_line":"200 response code."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a41bdd9_939ffe02","line":25,"in_reply_to":"9a41bdd9_e7b0118e","updated":"2015-07-13 08:32:13.000000000","message":"Yes, Nice catch. There is same issue with user_id filter also.\n\nI think we should fix all issues related to server list filter together. I will update the spec accordingly.\n\nCurrently novaclient set all_tenant flag to 1 explicitly in case of --user or --tenant - https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L1347\n\nWe should remove that too when novaclient request with this microversion.","commit_id":"a39fbfe62f8fa70a1317246f649538a390b0a23d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"04138e6d8c9c6e21301ec5d146b925357407bb59","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"::"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - nova list server --tenant_id\u003d\u003cid\u003e --all_tenants\u003dTrue"},{"line_number":60,"context_line":"    No Change"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  - nova list server --tenant_id\u003d\u003cid\u003e --all_tenants\u003dFalse"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a41bdd9_67ee418d","line":59,"updated":"2015-07-13 02:36:33.000000000","message":"Emm...this isn\u0027t exactly right, although I understand what you mean.\n\nFor list server, the cli is \"nova list\"\n\nFor --tenant_id, it should be \"--tenant id\"\n\nFor --all_tenants\u003dTrue, it should be \"--all-tenants 0|1\"","commit_id":"a39fbfe62f8fa70a1317246f649538a390b0a23d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0622c2311f9b7ea3f60a8c6e5aba6222934fde7b","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"::"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - nova list server --tenant_id\u003d\u003cid\u003e --all_tenants\u003dTrue"},{"line_number":60,"context_line":"    No Change"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  - nova list server --tenant_id\u003d\u003cid\u003e --all_tenants\u003dFalse"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a41bdd9_d6d01456","line":59,"in_reply_to":"9a41bdd9_67ee418d","updated":"2015-07-13 08:32:13.000000000","message":"Done","commit_id":"a39fbfe62f8fa70a1317246f649538a390b0a23d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"04138e6d8c9c6e21301ec5d146b925357407bb59","unresolved":false,"context_lines":[{"line_number":142,"context_line":"----------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* Add a new microversion and change v3/server.py to make \"tenant_id\" filter"},{"line_number":145,"context_line":"  work properly."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Dependencies"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a41bdd9_c7a70d4e","line":145,"updated":"2015-07-13 02:36:33.000000000","message":"update the python-novaclient","commit_id":"a39fbfe62f8fa70a1317246f649538a390b0a23d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0622c2311f9b7ea3f60a8c6e5aba6222934fde7b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"----------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* Add a new microversion and change v3/server.py to make \"tenant_id\" filter"},{"line_number":145,"context_line":"  work properly."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Dependencies"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a41bdd9_96ca8ca0","line":145,"in_reply_to":"9a41bdd9_c7a70d4e","updated":"2015-07-13 08:32:13.000000000","message":"Done","commit_id":"a39fbfe62f8fa70a1317246f649538a390b0a23d"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"240c6d0a1cc5bb52d063e2d9edd0dc5a3129cf0e","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  - nova list [--tenant [\u003ctenant\u003e]] [--user [\u003cuser\u003e]]"},{"line_number":65,"context_line":"    Old behavior - Return empty list"},{"line_number":66,"context_line":"    New behavior - Return expected list of server"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Alternatives"},{"line_number":69,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_ae4bac5e","line":66,"updated":"2015-08-14 16:34:22.000000000","message":"Might be clearer to say it\u0027ll return the list of servers for the provided tenant and user.","commit_id":"1d94ca3e60680fd364916394b74d5b9cb9edc36e"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"240c6d0a1cc5bb52d063e2d9edd0dc5a3129cf0e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Alternatives"},{"line_number":69,"context_line":"------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"It can be fixed as bug fix without requiring a new API microversion. But to"},{"line_number":72,"context_line":"advertise that it is working fine now, microversion.."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_0eb50030","line":71,"updated":"2015-08-14 16:34:22.000000000","message":"It\u0027s not really a bug per se, so much as awkward API behavior.","commit_id":"1d94ca3e60680fd364916394b74d5b9cb9edc36e"}]}