)]}'
{"specs/mitaka/approved/limits-quota-usage-from-neutron.rst":[{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"a6baa57cf35743929ea5690a2c18737b30be460c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"* 1. fail - Patch located here: https://review.openstack.org/#/c/199604/"},{"line_number":66,"context_line":"    - Since we already return data, which is incorrect, it is more consistent"},{"line_number":67,"context_line":"        to continue returning data, but the correct data"},{"line_number":68,"context_line":"* 2. return -1 or some other indicator for floating ips and security groups "},{"line_number":69,"context_line":"        indicating that Nova doesn\u0027t know the information without going to"},{"line_number":70,"context_line":"        Neutron."},{"line_number":71,"context_line":"    - Not a great solution since we don\u0027t give a reason why we aren\u0027t"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_4f8ec628","line":68,"updated":"2015-08-09 00:53:22.000000000","message":"Please remove the trailing spaces in your .rst file corresponding to where the red marks are above and at the bottom of the file","commit_id":"8d11377357c8c75d628c138d18ae8c5d171cc808"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8af37e94ce3b0b27e48e670ed1776bcc7efbd9d4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        indicating that Nova doesn\u0027t know the information without going to"},{"line_number":70,"context_line":"        Neutron."},{"line_number":71,"context_line":"    - Not a great solution since we don\u0027t give a reason why we aren\u0027t"},{"line_number":72,"context_line":"        returning the data"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_85f2136e","line":72,"updated":"2015-09-28 19:58:10.000000000","message":"I guess I feel like we\u0027ve said that we\u0027re not adding new unnecessary proxy interfaces. This is a straight proxy, which doesn\u0027t seem to offer much, IMHO. I think I\u0027d prefer either of the above two options from the nova perspective. It sounds like the neutron perspective is (unsurprisingly) to just proxy.\n\nSo, I dunno what to say here, other than:   :/","commit_id":"8d11377357c8c75d628c138d18ae8c5d171cc808"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5c0ae42a27f764e04581efec1fdf35d8f520a4df","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        indicating that Nova doesn\u0027t know the information without going to"},{"line_number":70,"context_line":"        Neutron."},{"line_number":71,"context_line":"    - Not a great solution since we don\u0027t give a reason why we aren\u0027t"},{"line_number":72,"context_line":"        returning the data"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_cb435412","line":72,"in_reply_to":"9a1a9d01_85f2136e","updated":"2015-11-23 16:03:21.000000000","message":"My preferred approach is to remove the proxy items in a new micro version of the API.\n\nIn older versions return some place holder, like -1, rather than returning totally incorrect values.","commit_id":"8d11377357c8c75d628c138d18ae8c5d171cc808"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6fb1826e202de82bc7e5bf38022d179e7f797fa","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        indicating that Nova doesn\u0027t know the information without going to"},{"line_number":70,"context_line":"        Neutron."},{"line_number":71,"context_line":"    - Not a great solution since we don\u0027t give a reason why we aren\u0027t"},{"line_number":72,"context_line":"        returning the data"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_c707c47f","line":72,"in_reply_to":"ba8a016a_cb435412","updated":"2015-11-23 16:50:56.000000000","message":"We should not return -1 in a quota/limits API since that has a very specific meaning of unlimited quota, which is not what we should be returning if we don\u0027t know.\n\nWe need to also refer to the mailing list discussion on this:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-July/069513.html\n\nThat\u0027s what prompted this spec.\n\nRe: John\u0027s reply, I think it\u0027s a good idea to just remove the resources from the response that we would otherwise have to proxy, and today are incorrect values. That\u0027s an indication that you can\u0027t get those from nova, get them from neutron instead. I don\u0027t think we would change any previous versions, we\u0027d just document that those values are in valid until you get to this microversion that removes them.","commit_id":"8d11377357c8c75d628c138d18ae8c5d171cc808"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8af37e94ce3b0b27e48e670ed1776bcc7efbd9d4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"There will be a small amount of overhead while calling the Neutron API, but"},{"line_number":104,"context_line":"the performance impact should be minimal."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Other deployer impact"},{"line_number":107,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_657a5ff3","line":104,"updated":"2015-09-28 19:58:10.000000000","message":"This is actually not so minor. We do it elsewhere, but it sounds like this will be a straight proxy call so that any time we\u0027re asked for this, we block and call out to neutron. That\u0027s something best avoided for API workers, when possible.","commit_id":"8d11377357c8c75d628c138d18ae8c5d171cc808"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8af37e94ce3b0b27e48e670ed1776bcc7efbd9d4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"* Test v2.2 with Neutron configured"},{"line_number":152,"context_line":"* Test v2.2 without Neutron configured"},{"line_number":153,"context_line":"* Test v2 and v2.1 to ensure Neutron data is not returned"},{"line_number":154,"context_line":"* Test passthru of errors from Neutron"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_85645349","line":154,"updated":"2015-09-28 19:58:10.000000000","message":"This is supposed to be \"what tests are you going to write?\" not \"what tests are you going to run?\"\n\nPresumably you need a tempest test that knows if we\u0027re using neutron and probes to validate the proper output? Or are you just going to write functional tests?\n\nHow are you going to test passthrough of errors from neutron? Presumably just with a functional or unit test?","commit_id":"8d11377357c8c75d628c138d18ae8c5d171cc808"}]}