)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"eaace6ba8d1e430f465f3753e85288ab00e5e253","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add project id information in os-server-group API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I167141676ef4f597a1c022c1fd5dc96fd55d02ad"},{"line_number":12,"context_line":"Closes-Bug: 1481210"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_113e3c8b","line":12,"updated":"2015-08-11 13:57:03.000000000","message":"This isn\u0027t close bug, it is partial","commit_id":"145b5946d15ef18e3afa343e2aee46ce0bfc2eaf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d0921b552346967646c561ae334f6de9ffdce1a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"be returned for os-server-group API"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I167141676ef4f597a1c022c1fd5dc96fd55d02ad"},{"line_number":16,"context_line":"Partial-Bug: 1481210"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da20952f_6e4a60ae","line":16,"updated":"2015-08-28 02:43:40.000000000","message":"You should have a blueprint in launchpad for a spec, not just a bug.","commit_id":"b589dc1796d117871de27330c942a3a370529b34"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"b682970c541995c59a184247e5e6f613e8b45214","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add project id and user id information in os-server-group API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add project id and user id information in"},{"line_number":10,"context_line":"os-server-group API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact: Project id and user id information will"},{"line_number":13,"context_line":"be returned for os-server-group API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3a29b11f_f615aee4","line":10,"updated":"2015-10-21 08:28:06.000000000","message":"Duplicates the subject line. Not needed.","commit_id":"6aa884645702f79f598a3aff0bd15fd84d16cfe9"}],"specs/liberty/approved/add-project-id-in-os-server-groups-api.rst":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3cc498c38f071f53c7be222ad04b626505c4976e","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Show the \u0027project_id\u0027 information of the server groups in"},{"line_number":14,"context_line":"os-server-groups API. This fix will allow admin user to"},{"line_number":15,"context_line":"identify server group more easier."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_71cd4030","line":15,"updated":"2015-08-11 14:36:01.000000000","message":"s/more//","commit_id":"145b5946d15ef18e3afa343e2aee46ce0bfc2eaf"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3cc498c38f071f53c7be222ad04b626505c4976e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Project Priority"},{"line_number":34,"context_line":"----------------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_b4a4164b","line":36,"updated":"2015-08-11 14:36:01.000000000","message":"should be low now?","commit_id":"145b5946d15ef18e3afa343e2aee46ce0bfc2eaf"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a5b0dfa79486dfe251010855d87ccb6a46fb8d2f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Project Priority"},{"line_number":34,"context_line":"----------------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_ef314d0c","line":36,"in_reply_to":"1a4dcd0f_b4a4164b","updated":"2015-08-12 02:02:17.000000000","message":"Hi, I don\u0027t know it yet, let just keep it for now.","commit_id":"145b5946d15ef18e3afa343e2aee46ce0bfc2eaf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39cc5721da57c3189d7f8856275dd02a5f78aa05","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a new API microversion to the os-server-groups API extension such that if"},{"line_number":42,"context_line":"the version on the API GET request satisfies the minimum version required,"},{"line_number":43,"context_line":"include the \u0027project_id\u0027 information of the server group in the response data."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_6aca38a3","line":43,"updated":"2015-08-25 08:12:11.000000000","message":"Response data of GET APIs (list and show both) ? I think it should be in both.\n\nAnd not in POST request.","commit_id":"2e8a51f889fc82f100c85e94aa57c53a686e3f98"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39cc5721da57c3189d7f8856275dd02a5f78aa05","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Modifications for the method"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  * Add project id information to the current response data."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Example use case:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_2ae8c0e1","line":64,"updated":"2015-08-25 08:12:11.000000000","message":"please mention which all request (GET, POST etc) response gets updated.","commit_id":"2e8a51f889fc82f100c85e94aa57c53a686e3f98"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39cc5721da57c3189d7f8856275dd02a5f78aa05","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      ],"},{"line_number":94,"context_line":"      \"name\": \"test2\","},{"line_number":95,"context_line":"      \"members\": [],"},{"line_number":96,"context_line":"      \"project_id\": \"b8112a8d8227490eba99419b8a8c2555\","},{"line_number":97,"context_line":"      \"id\": \"b1af831c-69b5-4d42-be44-d710f2b8954c\","},{"line_number":98,"context_line":"      \"metadata\": {}"},{"line_number":99,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_4a47341d","line":96,"updated":"2015-08-25 08:12:11.000000000","message":"Does adding user_id also make sense here?\n\nIn case any tenant want to know which user own those server groups.","commit_id":"2e8a51f889fc82f100c85e94aa57c53a686e3f98"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"809f02287b9e529a66a314c96e323f3342d98756","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      ],"},{"line_number":94,"context_line":"      \"name\": \"test2\","},{"line_number":95,"context_line":"      \"members\": [],"},{"line_number":96,"context_line":"      \"project_id\": \"b8112a8d8227490eba99419b8a8c2555\","},{"line_number":97,"context_line":"      \"id\": \"b1af831c-69b5-4d42-be44-d710f2b8954c\","},{"line_number":98,"context_line":"      \"metadata\": {}"},{"line_number":99,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_6c01f569","line":96,"in_reply_to":"fa1b9901_4a47341d","updated":"2015-08-25 08:44:09.000000000","message":"Good idea!","commit_id":"2e8a51f889fc82f100c85e94aa57c53a686e3f98"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39cc5721da57c3189d7f8856275dd02a5f78aa05","unresolved":false,"context_lines":[{"line_number":115,"context_line":"---------------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* The v2.1 python-novaclient server-group-list command could be updated to"},{"line_number":118,"context_line":"  show the \u0027project_id\u0027 information in it\u0027s output."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Performance Impact"},{"line_number":121,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_8a5b0cf6","line":118,"updated":"2015-08-25 08:12:11.000000000","message":"If it is in Show also then show command also need updates.","commit_id":"2e8a51f889fc82f100c85e94aa57c53a686e3f98"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"44967a136413f33e27a6f5df0e35bd4606a2230b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"----------"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Add a new microversion and change"},{"line_number":156,"context_line":"  nova/api/openstack/plugins/v3/server_groups.py to use it to determine"},{"line_number":157,"context_line":"  if the \u0027project_id\u0027 information of the server group should be returned."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_86b91d31","line":156,"updated":"2015-08-27 02:06:50.000000000","message":"nit, the file path is changed now.","commit_id":"b589dc1796d117871de27330c942a3a370529b34"}],"specs/mitaka/approved/add-project-id-in-os-server-groups-api.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46add0f3ef08d488b56c0543da2d74aed19b8fa8","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The proposed change just updates the GET response data in the os-server-groups"},{"line_number":61,"context_line":"API extension to include the \u0027project_id\u0027 and \u0027user_id\u0027 field if the request"},{"line_number":62,"context_line":"has a minimum supported version."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Modifications for the method"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_912e7ca3","line":62,"updated":"2015-09-17 21:28:53.000000000","message":"minimum supported version and if the context is admin and all_projects is in the request:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_groups.py#L118\n\nYour spec doesn\u0027t mention this only happening when all_projects is used, you should add that for clarification.","commit_id":"5d075556a00055c0d151ca77eeb8e7ae6a6d96c9"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"35d5e07785b4526dfa9ade67598525c740bb4caa","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The proposed change just updates the GET response data in the os-server-groups"},{"line_number":61,"context_line":"API extension to include the \u0027project_id\u0027 and \u0027user_id\u0027 field if the request"},{"line_number":62,"context_line":"has a minimum supported version."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Modifications for the method"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_c5f6928e","line":62,"in_reply_to":"ba15a1d1_912e7ca3","updated":"2015-09-24 02:44:16.000000000","message":"Thanks for the comments.","commit_id":"5d075556a00055c0d151ca77eeb8e7ae6a6d96c9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46add0f3ef08d488b56c0543da2d74aed19b8fa8","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  * Add project id information to the current response data."},{"line_number":67,"context_line":"  * Add user id information to the current response data."},{"line_number":68,"context_line":"  * GET and POST requests response data will be affected."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Example use case:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_7c7a9f89","line":68,"updated":"2015-09-17 21:28:53.000000000","message":"Why POST?  Seems redundant since the tenant creating the server group already knows their project_id/user_id.  Since the code is the same for formatting the server group in the response I guess it\u0027s not a big deal to return it though.","commit_id":"5d075556a00055c0d151ca77eeb8e7ae6a6d96c9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46add0f3ef08d488b56c0543da2d74aed19b8fa8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Request:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"GET --header \"X-OpenStack-Nova-API-Version: 2.12\" \\"},{"line_number":75,"context_line":"http://127.0.0.1:8774/v2.1/e0c1f4c0b9444fa086fa13881798144f/os-server-groups"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Response:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_bc5cb719","line":75,"updated":"2015-09-17 21:28:53.000000000","message":"This should have the all_projects query parameter in it.","commit_id":"5d075556a00055c0d151ca77eeb8e7ae6a6d96c9"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"fd265e901e099497b6ec15101419121c696d52a5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"---------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* The v2.1 python-novaclient server-group-list and server-group-show command"},{"line_number":123,"context_line":"  could be updated to show the \u0027project_id\u0027and \u0027user_id\u0027 information in it\u0027s"},{"line_number":124,"context_line":"  output."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_2a52cfde","line":123,"updated":"2015-09-23 16:29:51.000000000","message":"supernit: missing a whitespace","commit_id":"5d075556a00055c0d151ca77eeb8e7ae6a6d96c9"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"fd265e901e099497b6ec15101419121c696d52a5","unresolved":false,"context_lines":[{"line_number":156,"context_line":"* Add a new microversion and change"},{"line_number":157,"context_line":"  nova/api/openstack/compute/server_groups.py to use it to determine"},{"line_number":158,"context_line":"  if the \u0027project_id\u0027 information of the server group should be returned."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Dependencies"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_4ab86311","line":159,"updated":"2015-09-23 16:29:51.000000000","message":"you mention the user_id as well.","commit_id":"5d075556a00055c0d151ca77eeb8e7ae6a6d96c9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f19bba4f26c74f2e00baff789f7714f24edf4ec2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-project-id-and-user-id"},{"line_number":12,"context_line":"https://bugs.launchpad.net/python-novaclient/+bug/1481210"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Show the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server"},{"line_number":15,"context_line":"groups in os-server-groups API. This fix will allow admin user"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_cebb9574","line":12,"updated":"2015-10-02 12:28:19.000000000","message":"seems only need #11 according to template?","commit_id":"3918a31433592a551baec421d115cd4dd255bbfa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"362acfb23b688651a8f002ced31720b37bf0474a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-project-id-and-user-id"},{"line_number":12,"context_line":"https://bugs.launchpad.net/python-novaclient/+bug/1481210"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Show the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server"},{"line_number":15,"context_line":"groups in os-server-groups API. This fix will allow admin user"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7a2fa921_114d5b72","line":12,"in_reply_to":"9a1a9d01_cebb9574","updated":"2015-10-05 21:01:35.000000000","message":"Yeah we don\u0027t need the wishlist bug listed here.  It\u0027s fine to have it in the References section at the end though.","commit_id":"3918a31433592a551baec421d115cd4dd255bbfa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"362acfb23b688651a8f002ced31720b37bf0474a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Other end user impact"},{"line_number":123,"context_line":"---------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* The v2.1 python-novaclient server-group-list and server-group-show command"},{"line_number":126,"context_line":"  could be updated to show the \u0027project_id\u0027 and \u0027user_id\u0027 information in it\u0027s"},{"line_number":127,"context_line":"  output."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7a2fa921_e79eda06","line":125,"updated":"2015-10-05 21:01:35.000000000","message":"It\u0027s a bit confusing to say v2.1 novaclient here.  Maybe you mean the novaclient.v2 code path?  I\u0027d just omit that part and say python-novaclient will be updated to handle the microversion to show the project_id/user_id if the requested microversion provides that information.\n\nNote that I reverted your previous python-novaclient change related to this:\n\nhttps://review.openstack.org/#/c/231125/","commit_id":"3918a31433592a551baec421d115cd4dd255bbfa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"362acfb23b688651a8f002ced31720b37bf0474a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Testing"},{"line_number":172,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"* Unit tests and possibly API samples functional tests in the nova tree."},{"line_number":175,"context_line":"* There are currently not any compute API microversions tested in Tempest"},{"line_number":176,"context_line":"  beyond v2.1. We could add support for testing the new version in Tempest"},{"line_number":177,"context_line":"  but so far the API is already at least at v2.10 without changes to Tempest."}],"source_content_type":"text/x-rst","patch_set":14,"id":"7a2fa921_e7b57a7e","line":174,"updated":"2015-10-05 21:01:35.000000000","message":"s/possibly//\n\nThere needs to be functional test coverage for this.","commit_id":"3918a31433592a551baec421d115cd4dd255bbfa"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"14ba63414ff6f797a3705121609618764447544a","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"GET --header \"X-OpenStack-Nova-API-Version: 2.12\" \\"},{"line_number":76,"context_line":"http://127.0.0.1:8774/v2.1/e0c1f4c0b9444fa086fa13881798144f/os-server-groups"},{"line_number":77,"context_line":"?all_projects"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Response:"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a2fa921_b4eba712","line":77,"updated":"2015-10-08 13:05:09.000000000","message":"I think we should add \u0027project_id\u0027 and \u0027user_id\u0027 to the show\u0027s response also. Because admin user can show another user\u0027s server group.\n\nSo for consistent, I think we can add project_id and user_id for all the response(create, show, index) of server-groups API.","commit_id":"c85ca66d7d841290873afa43d47873c69f00536e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b71178b225327cb0faed5807e27fbdb43d657fb9","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"GET --header \"X-OpenStack-Nova-API-Version: 2.12\" \\"},{"line_number":76,"context_line":"http://127.0.0.1:8774/v2.1/e0c1f4c0b9444fa086fa13881798144f/os-server-groups"},{"line_number":77,"context_line":"?all_projects"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Response:"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a2fa921_d4ce632d","line":77,"in_reply_to":"7a2fa921_b4eba712","updated":"2015-10-08 13:11:46.000000000","message":"ok...from other paragraph, you mentioned add new attributes to \u0027show\u0027 which I missed. But for consistent data model, I prefer add new attributes to \u0027create\u0027 response also.","commit_id":"c85ca66d7d841290873afa43d47873c69f00536e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0d086c97a0323f468632a9cda1c4af411a53fd3b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Documentation Impact"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"The nova/api/openstack/rest_api_version_history.rst document will be updated."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a2fa921_b4df270c","line":184,"updated":"2015-10-08 13:09:53.000000000","message":"we should update api-ref at https://github.com/openstack/api-site also","commit_id":"c85ca66d7d841290873afa43d47873c69f00536e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"95e66651c3bec9e04803fa179c38bb441c75068f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"the version on the API GET(both \u0027list\u0027 and \u0027show\u0027) and POST(the return data"},{"line_number":43,"context_line":"of \u0027create\u0027 also includes detailed information about the created server group)"},{"line_number":44,"context_line":"request satisfies the minimum version required with the admin context and"},{"line_number":45,"context_line":"all_projects is in the request include the \u0027project_id\u0027 and \u0027user_id\u0027 information"},{"line_number":46,"context_line":"of the server group in the response data."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a2fa921_6e2afa91","line":45,"updated":"2015-10-09 02:16:39.000000000","message":"This line is too long.","commit_id":"b263bb34ce71d3c9f1694d7f4020bc6114e8f4a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3025dd0ea205ee8c6288dcc9f4009e0830f7e76","unresolved":false,"context_lines":[{"line_number":42,"context_line":"the version on the API GET(both \u0027list\u0027 and \u0027show\u0027) and POST(the return data"},{"line_number":43,"context_line":"of \u0027create\u0027 also includes detailed information about the created server group)"},{"line_number":44,"context_line":"request satisfies the minimum version required with the admin context and"},{"line_number":45,"context_line":"all_projects is in the request include the \u0027project_id\u0027 and \u0027user_id\u0027 information"},{"line_number":46,"context_line":"of the server group in the response data."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a2fa921_e9592436","line":45,"in_reply_to":"7a2fa921_6e2afa91","updated":"2015-10-09 02:22:05.000000000","message":"Also, this is confusing now because all_projects is only on list, it\u0027s not used in create or show, so if you\u0027re going to include that information in here, you should distinguish the usage of all_projects to list only.","commit_id":"b263bb34ce71d3c9f1694d7f4020bc6114e8f4a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3025dd0ea205ee8c6288dcc9f4009e0830f7e76","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The proposed change updates the GET and POST response data in the os-server-groups"},{"line_number":62,"context_line":"API extension to include the \u0027project_id\u0027 and \u0027user_id\u0027 field if the request"},{"line_number":63,"context_line":"has a minimum supported version with the admin context and all_projects is in"},{"line_number":64,"context_line":"the request."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Modifications for the method"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a2fa921_4949385f","line":63,"updated":"2015-10-09 02:22:05.000000000","message":"Same here.","commit_id":"b263bb34ce71d3c9f1694d7f4020bc6114e8f4a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3025dd0ea205ee8c6288dcc9f4009e0830f7e76","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Documentation Impact"},{"line_number":206,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"The nova/api/openstack/rest_api_version_history.rst document will be updated,"},{"line_number":209,"context_line":"api-ref at https://github.com/openstack/api-site will also be updated."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a2fa921_e97044a6","line":208,"updated":"2015-10-09 02:22:05.000000000","message":"Rather than a comma, make these two items separate, using * for bullets.","commit_id":"b263bb34ce71d3c9f1694d7f4020bc6114e8f4a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3025dd0ea205ee8c6288dcc9f4009e0830f7e76","unresolved":false,"context_lines":[{"line_number":206,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"The nova/api/openstack/rest_api_version_history.rst document will be updated,"},{"line_number":209,"context_line":"api-ref at https://github.com/openstack/api-site will also be updated."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a2fa921_496058cf","line":209,"updated":"2015-10-09 02:22:05.000000000","message":"We can list this, but I\u0027m not sure that anyone has actually documented new microversion stuff in api-site yet.  I think it\u0027s OK to leave this in here to investigate it though, we\u0027d have to consult with the docs team.","commit_id":"b263bb34ce71d3c9f1694d7f4020bc6114e8f4a1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e5ecb338fe0bbdfe5bfe364dd88a50458e235ec8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a new API microversion to the os-server-groups API extension such that if:"},{"line_number":42,"context_line":" * The version on the API \u0027list\u0027 request satisfies the minimum version"},{"line_number":43,"context_line":"   required with the admin context and all_projects is in the request include"},{"line_number":44,"context_line":"   the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server group in the"},{"line_number":45,"context_line":"   response data."}],"source_content_type":"text/x-rst","patch_set":18,"id":"7a2fa921_e4eaa973","line":42,"updated":"2015-10-09 03:26:28.000000000","message":"the minimum version is a little confuse. Sounds like you said the Microversion minimum version 2.1. But I know you point to the new version you bump for add project_id and user_id. Maybe we said as  \"The version on the API \u0027list\u0027 request satisfies the new Mciroversion\", but please don\u0027t trust my English.....","commit_id":"e5276b43bdc5040c8bb67df17c7e3b44b427bcd9"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b78e24bdf0d8000fd626a9f82abfb069cf0aaa49","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a new API microversion to the os-server-groups API extension such that if:"},{"line_number":42,"context_line":" * The version on the API \u0027list\u0027 request satisfies the minimum version"},{"line_number":43,"context_line":"   required with the admin context and all_projects is in the request include"},{"line_number":44,"context_line":"   the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server group in the"},{"line_number":45,"context_line":"   response data."}],"source_content_type":"text/x-rst","patch_set":18,"id":"7a2fa921_a45d9148","line":42,"in_reply_to":"7a2fa921_e4eaa973","updated":"2015-10-09 03:39:24.000000000","message":"Hi, I think it is ok as it is now, I copied this representation from Matt\u0027s spec about key pairs which has already been merged.","commit_id":"e5276b43bdc5040c8bb67df17c7e3b44b427bcd9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e5ecb338fe0bbdfe5bfe364dd88a50458e235ec8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"The proposed change updates the GET response data in the os-server-groups"},{"line_number":67,"context_line":"API extension to include the \u0027project_id\u0027 and \u0027user_id\u0027 field if the request"},{"line_number":68,"context_line":"has a minimum supported version with the admin context and all_projects is in"},{"line_number":69,"context_line":"the request."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The proposed change also updates the POST response data in the"},{"line_number":72,"context_line":"os-server-groups API extension to include the \u0027project_id\u0027 and \u0027user_id\u0027"}],"source_content_type":"text/x-rst","patch_set":18,"id":"7a2fa921_64ed39b6","line":69,"updated":"2015-10-09 03:26:28.000000000","message":"do you mean only return \u0027project_id\u0027 and \u0027user_id\u0027 when request is admin user and request all_projects? This one I missed from previous review, sorry for that.\n\nI prefer we just return project_id and user_id all the time. Then we have consistent response, this is more easy for user write their client code.","commit_id":"e5276b43bdc5040c8bb67df17c7e3b44b427bcd9"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b78e24bdf0d8000fd626a9f82abfb069cf0aaa49","unresolved":false,"context_lines":[{"line_number":66,"context_line":"The proposed change updates the GET response data in the os-server-groups"},{"line_number":67,"context_line":"API extension to include the \u0027project_id\u0027 and \u0027user_id\u0027 field if the request"},{"line_number":68,"context_line":"has a minimum supported version with the admin context and all_projects is in"},{"line_number":69,"context_line":"the request."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The proposed change also updates the POST response data in the"},{"line_number":72,"context_line":"os-server-groups API extension to include the \u0027project_id\u0027 and \u0027user_id\u0027"}],"source_content_type":"text/x-rst","patch_set":18,"id":"7a2fa921_2438a1ee","line":69,"in_reply_to":"7a2fa921_64ed39b6","updated":"2015-10-09 03:39:24.000000000","message":"Ok, that\u0027s better, in fact, it is also true that the \u0027project id\u0027 and \u0027user id\u0027 will always return.","commit_id":"e5276b43bdc5040c8bb67df17c7e3b44b427bcd9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e5ecb338fe0bbdfe5bfe364dd88a50458e235ec8","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      \"project_id\": \"b8112a8d8227490eba99419b8a8c2555\","},{"line_number":140,"context_line":"      \"id\": \"e64b6ae1-4d05-4faa-9f53-72c71f8e6f1a\","},{"line_number":141,"context_line":"      \"metadata\": {}"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* There should not be any impacts to policy.json files for this change."},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"7a2fa921_644459b6","line":142,"updated":"2015-10-09 03:26:28.000000000","message":"So we have consistent response for show, list, and create, then we can just write one JSON-Schema of response at here.\n\nYou can copy this and doing a little modification\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/server_groups.py#L23","commit_id":"e5276b43bdc5040c8bb67df17c7e3b44b427bcd9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e5ecb338fe0bbdfe5bfe364dd88a50458e235ec8","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Other end user impact"},{"line_number":157,"context_line":"---------------------"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* The python-novaclient server-group-list and server-group-show command"},{"line_number":160,"context_line":"  will be updated to handle microversions to show the \u0027project_id\u0027 and"},{"line_number":161,"context_line":"  \u0027user_id\u0027 information in it\u0027s output if the requested microversion"},{"line_number":162,"context_line":"  provides that infomation."}],"source_content_type":"text/x-rst","patch_set":18,"id":"7a2fa921_64721913","line":159,"updated":"2015-10-09 03:26:28.000000000","message":"also server-group-create","commit_id":"e5276b43bdc5040c8bb67df17c7e3b44b427bcd9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c9f6a20b8062f0c0133f07699ac26957e0114a68","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      \"id\": \"e64b6ae1-4d05-4faa-9f53-72c71f8e6f1a\","},{"line_number":102,"context_line":"      \"metadata\": {}"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Request:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"POST --header \"X-OpenStack-Nova-API-Version: 2.12\" \\"}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a2fa921_51f23e07","line":104,"updated":"2015-10-09 04:41:03.000000000","message":"oops, missting \u0027]\u0027 and \u0027}\u0027","commit_id":"4e6d160c7663455dcb56dd551711a6c1899fbcf2"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c9f6a20b8062f0c0133f07699ac26957e0114a68","unresolved":false,"context_lines":[{"line_number":113,"context_line":"::"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"   {"},{"line_number":116,"context_line":"    \"server_groups\": ["},{"line_number":117,"context_line":"    {"},{"line_number":118,"context_line":"      \"user_id\": \"ed64bccd0227444fa02dbd7695769a7d\","},{"line_number":119,"context_line":"      \"policies\": ["}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a2fa921_11c846a5","line":116,"updated":"2015-10-09 04:41:03.000000000","message":"The post shouldn\u0027t a list.","commit_id":"4e6d160c7663455dcb56dd551711a6c1899fbcf2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9ce2c186b04620d2ac96f242473f1c5b2a8195b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"::"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"   {"},{"line_number":116,"context_line":"    \"server_groups\": ["},{"line_number":117,"context_line":"    {"},{"line_number":118,"context_line":"      \"user_id\": \"ed64bccd0227444fa02dbd7695769a7d\","},{"line_number":119,"context_line":"      \"policies\": ["}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a2fa921_37e69215","line":116,"in_reply_to":"7a2fa921_11c846a5","updated":"2015-10-09 06:02:38.000000000","message":"@Alex - m thinking whether we should provide project and user id in POST response or not?\n\ncreate request will come from owner only SO mentioned use case in this spec does not apply for POST request right?","commit_id":"4e6d160c7663455dcb56dd551711a6c1899fbcf2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"082ed7b8b370a2d45c362a76e3e88a62cb2134b6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"::"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"   {"},{"line_number":116,"context_line":"    \"server_groups\": ["},{"line_number":117,"context_line":"    {"},{"line_number":118,"context_line":"      \"user_id\": \"ed64bccd0227444fa02dbd7695769a7d\","},{"line_number":119,"context_line":"      \"policies\": ["}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a2fa921_c288ba73","line":116,"in_reply_to":"7a2fa921_178d96d5","updated":"2015-10-09 06:27:50.000000000","message":"Yea that\u0027s implementation vise might be easy. but from user prospective that will not be much useful information. I think we should provide few necessary information on create and provide detail information on GET. Like we do for server APIs.","commit_id":"4e6d160c7663455dcb56dd551711a6c1899fbcf2"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"0708580bac835968c709d4447d82211e2780dbbf","unresolved":false,"context_lines":[{"line_number":113,"context_line":"::"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"   {"},{"line_number":116,"context_line":"    \"server_groups\": ["},{"line_number":117,"context_line":"    {"},{"line_number":118,"context_line":"      \"user_id\": \"ed64bccd0227444fa02dbd7695769a7d\","},{"line_number":119,"context_line":"      \"policies\": ["}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a2fa921_178d96d5","line":116,"in_reply_to":"7a2fa921_37e69215","updated":"2015-10-09 06:16:31.000000000","message":"Hi, thanks for the review. I think it will be no harm to show the project and user ID in the response of POST. And actually, they are using the same function, it will be more work if we don\u0027t make the response of POST contain these.","commit_id":"4e6d160c7663455dcb56dd551711a6c1899fbcf2"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7dd0b2a0ab73b9bcd314579122f9fab0af155a38","unresolved":false,"context_lines":[{"line_number":113,"context_line":"::"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"   {"},{"line_number":116,"context_line":"    \"server_groups\": ["},{"line_number":117,"context_line":"    {"},{"line_number":118,"context_line":"      \"user_id\": \"ed64bccd0227444fa02dbd7695769a7d\","},{"line_number":119,"context_line":"      \"policies\": ["}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a2fa921_a3634041","line":116,"in_reply_to":"7a2fa921_c288ba73","updated":"2015-10-09 08:09:10.000000000","message":"Hi, Gman, Actually I think it is useful for user. The user needn\u0027t wrote his code with different branch for POST and GET response. Consistent and Easy.","commit_id":"4e6d160c7663455dcb56dd551711a6c1899fbcf2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ce81e5488ce73b96e1df86d7e1ad814eb55d1fe","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"As a cloud administrator, I want to easily identify which server group"},{"line_number":31,"context_line":"belongs to which project."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Project Priority"}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a2fa921_198b6820","line":30,"updated":"2015-10-09 19:19:42.000000000","message":"You don\u0027t mention admin after this point, but the main use case is for the admin to list server groups from all projects, which requires an admin context and the all_projects parameter on the request, and you seem to have dropped the all_projects portion from your examples in one of the last several patch sets.  I think it\u0027s fairly important to make that distinction since that\u0027s how this is going to be used.","commit_id":"6d8abab03a7578220da617144d890756e0f3bde6"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"ba2d1878e88e37772cf9f84ac96c352449ddb7aa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"As a cloud administrator, I want to easily identify which server group"},{"line_number":31,"context_line":"belongs to which project."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Project Priority"}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a2fa921_e36eeefe","line":30,"in_reply_to":"7a2fa921_198b6820","updated":"2015-10-10 01:57:26.000000000","message":"Done","commit_id":"6d8abab03a7578220da617144d890756e0f3bde6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ce81e5488ce73b96e1df86d7e1ad814eb55d1fe","unresolved":false,"context_lines":[{"line_number":30,"context_line":"As a cloud administrator, I want to easily identify which server group"},{"line_number":31,"context_line":"belongs to which project."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Project Priority"},{"line_number":34,"context_line":"----------------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a2fa921_19ecc828","line":33,"updated":"2015-10-09 19:19:42.000000000","message":"You can remove this section since the project priority stuff was dropped from the spec template.","commit_id":"6d8abab03a7578220da617144d890756e0f3bde6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ce81e5488ce73b96e1df86d7e1ad814eb55d1fe","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Add a new API microversion to the os-server-groups API extension such that if:"},{"line_number":42,"context_line":" * The version on the API \u0027list\u0027 request satisfies the minimum version"},{"line_number":43,"context_line":"   required, the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server"},{"line_number":44,"context_line":"   group in the response data."},{"line_number":45,"context_line":" * The version on the API \u0027show\u0027 request satisfies the minimum version include"},{"line_number":46,"context_line":"   the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server group in the"},{"line_number":47,"context_line":"   response data."}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a2fa921_994e9839","line":44,"updated":"2015-10-09 19:19:42.000000000","message":"s/group in the/group is included in the/","commit_id":"6d8abab03a7578220da617144d890756e0f3bde6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ce81e5488ce73b96e1df86d7e1ad814eb55d1fe","unresolved":false,"context_lines":[{"line_number":45,"context_line":" * The version on the API \u0027show\u0027 request satisfies the minimum version include"},{"line_number":46,"context_line":"   the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server group in the"},{"line_number":47,"context_line":"   response data."},{"line_number":48,"context_line":" * The version on the API \u0027create\u0027 request satisfies the minimum version"},{"line_number":49,"context_line":"   include the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server group in"},{"line_number":50,"context_line":"   the response data."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a2fa921_9923f855","line":48,"updated":"2015-10-09 19:19:42.000000000","message":"I tend to agree with gmann that this seems kind of unnecessary to return in the POST response, but it\u0027s not a big deal either way to me.","commit_id":"6d8abab03a7578220da617144d890756e0f3bde6"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"ba2d1878e88e37772cf9f84ac96c352449ddb7aa","unresolved":false,"context_lines":[{"line_number":45,"context_line":" * The version on the API \u0027show\u0027 request satisfies the minimum version include"},{"line_number":46,"context_line":"   the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server group in the"},{"line_number":47,"context_line":"   response data."},{"line_number":48,"context_line":" * The version on the API \u0027create\u0027 request satisfies the minimum version"},{"line_number":49,"context_line":"   include the \u0027project_id\u0027 and \u0027user_id\u0027 information of the server group in"},{"line_number":50,"context_line":"   the response data."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a2fa921_a37556cb","line":48,"in_reply_to":"7a2fa921_9923f855","updated":"2015-10-10 01:57:26.000000000","message":"Let\u0027s keep it this way, it will make no harm.","commit_id":"6d8abab03a7578220da617144d890756e0f3bde6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ce81e5488ce73b96e1df86d7e1ad814eb55d1fe","unresolved":false,"context_lines":[{"line_number":192,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"* Unit tests and API samples functional tests in the nova tree."},{"line_number":195,"context_line":"* Functional test coverage."},{"line_number":196,"context_line":"* There are currently not any compute API microversions tested in Tempest"},{"line_number":197,"context_line":"  beyond v2.1. We could add support for testing the new version in Tempest"},{"line_number":198,"context_line":"  but so far the API is already at least at v2.10 without changes to Tempest."}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a2fa921_59f000c9","line":195,"updated":"2015-10-09 19:19:42.000000000","message":"nit: this is redundant with the first bullet.","commit_id":"6d8abab03a7578220da617144d890756e0f3bde6"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2d436591636c3aa30a3009ca94cfff488f2f97ba","unresolved":false,"context_lines":[{"line_number":39,"context_line":" * The version on the API \u0027list\u0027 request satisfies the minimum version"},{"line_number":40,"context_line":"   required with the admin context and all_projects is in the request,"},{"line_number":41,"context_line":"   the \u0027project_id\u0027 and \u0027user_id\u0027 information of server groups in the"},{"line_number":42,"context_line":"   response data."},{"line_number":43,"context_line":" * The version on the API \u0027show\u0027 request satisfies the minimum version include"},{"line_number":44,"context_line":"   the \u0027project_id\u0027 and \u0027user_id\u0027 information of server groups in the response"},{"line_number":45,"context_line":"   data."}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a2fa921_e6583c33","line":42,"updated":"2015-10-10 02:07:56.000000000","message":"Emm....looks like Matt only ask add all_projects in the example, not the only show project_id and user_id when all_projects is specified.\n\nBut let\u0027s check with Matt.","commit_id":"a00777d73ff1fdfededc1f2d913d21a0ac0ab758"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"b0dc7f03eddb8150caed45f30153853c78b41f50","unresolved":false,"context_lines":[{"line_number":176,"context_line":"* The python-novaclient server-group-list, server-group-show"},{"line_number":177,"context_line":"  server-group-create command will be updated to handle microversions"},{"line_number":178,"context_line":"  to show the \u0027project_id\u0027 and \u0027user_id\u0027 information in it\u0027s output"},{"line_number":179,"context_line":"  if the requested microversion provides that infomation."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Performance Impact"},{"line_number":182,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a29b11f_c0bb3ae4","line":179,"updated":"2015-10-20 11:24:41.000000000","message":"typo: s/infomation/information","commit_id":"a00777d73ff1fdfededc1f2d913d21a0ac0ab758"}]}
