)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b0e9e9c6526bc3a8176e5dea130c18e700176183","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8363474dc82f5705727825c91a23007ec5721560"},{"line_number":10,"context_line":"APIImpact: adds new attribute to hypervisor-list API"},{"line_number":11,"context_line":"Implements: os-hypervisors-ipaddress"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_8beab6d9","line":11,"updated":"2015-08-21 09:25:18.000000000","message":"you need to add blueprint os-hypervisors-ipaddress for the system to work correctly.\n\nFor more details, please see here:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"a188ed72bb24b41015b8724538660c6907edb240"}],"specs/mitaka/approved/os-hypervisors-ipaddress.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a02552e9a90cf5b15320a157239a2c03c8a411a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"We are not modifying the DB as the data is already stored in compute_nodes table. We are changing nova API to add one more attribute to the JSON it returns. The attribute name is \u0027host_ip\u0027."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"And we also require to change Nova client to display the Host IP column in the table as follows."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_ef3baecf","line":36,"updated":"2015-09-28 18:45:09.000000000","message":"Please wrap your lines.","commit_id":"29f745b823d2085ef1ceb9619e1e1a3068854635"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a02552e9a90cf5b15320a157239a2c03c8a411a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    ]"},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Security impact"},{"line_number":84,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_ef42ce3d","line":81,"updated":"2015-09-28 18:45:09.000000000","message":"I believe the requirement for new API changes is to include the scatual schema change involved.","commit_id":"29f745b823d2085ef1ceb9619e1e1a3068854635"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a02552e9a90cf5b15320a157239a2c03c8a411a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"----------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Return \u0027host_ip\u0027 attribute in addition to ID and Hypervisor hostname."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Dependencies"},{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_af6376db","line":127,"updated":"2015-09-28 18:45:09.000000000","message":"Add novaclient changes here.","commit_id":"29f745b823d2085ef1ceb9619e1e1a3068854635"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a02552e9a90cf5b15320a157239a2c03c8a411a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Testing"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Unit tests and possibly API samples functional tests in the nova tree."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_4f72daae","line":137,"range":{"start_line":137,"start_character":17,"end_line":137,"end_character":25},"updated":"2015-09-28 18:45:09.000000000","message":"s/possibly//","commit_id":"29f745b823d2085ef1ceb9619e1e1a3068854635"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e093e7f45af69a0a48fdbf357ae63b0760be99d6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"As part of the blueprint https://blueprints.launchpad.net/nova/+spec/no-"},{"line_number":20,"context_line":"compute-fanout-to-scheduler we store the \u0027host_ip\u0027 and \u0027supported_instances\u0027"},{"line_number":21,"context_line":"into compute_nodes table. But while getting the  hypervisor-list we get only"},{"line_number":22,"context_line":"the  ID and  hostname."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_9c92294b","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":24},"updated":"2015-10-16 20:31:49.000000000","message":"Not sure I see a problem with that sentence. You just want to get the host_ip, but it\u0027s not yet there, right?","commit_id":"3ff23b616f3a724c3dc5e727a0a3d45de6975d7d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e093e7f45af69a0a48fdbf357ae63b0760be99d6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Project Priority"},{"line_number":30,"context_line":"-----------------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_3ca2f599","line":32,"updated":"2015-10-16 20:31:49.000000000","message":"please remove that section, it\u0027s no longer needed","commit_id":"3ff23b616f3a724c3dc5e727a0a3d45de6975d7d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e093e7f45af69a0a48fdbf357ae63b0760be99d6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            }"},{"line_number":82,"context_line":"        ]"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Security impact"},{"line_number":86,"context_line":"---------------"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_3cc99559","line":84,"updated":"2015-10-16 20:31:49.000000000","message":"please mention that you\u0027ll need to add a microversion with a backwards compatiblity for the earlier versions by not returning the host_ip field.","commit_id":"3ff23b616f3a724c3dc5e727a0a3d45de6975d7d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e093e7f45af69a0a48fdbf357ae63b0760be99d6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"----------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* Return \u0027host_ip\u0027 attribute in addition to ID and Hypervisor hostname."},{"line_number":129,"context_line":"* Add column for \u0027HOST IP\u0027 in python novaclient."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_3cf7558c","line":129,"updated":"2015-10-16 20:31:49.000000000","message":"you should mention that the novaclient needs to provide a backwards compatible method IMHO","commit_id":"3ff23b616f3a724c3dc5e727a0a3d45de6975d7d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e093e7f45af69a0a48fdbf357ae63b0760be99d6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Unit tests and API samples functional tests in the nova tree."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Documentation Impact"},{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_fcec7dbc","line":141,"updated":"2015-10-16 20:31:49.000000000","message":"I\u0027d love to see some novaclient functional test for running the microversion you\u0027ll be adding","commit_id":"3ff23b616f3a724c3dc5e727a0a3d45de6975d7d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e093e7f45af69a0a48fdbf357ae63b0760be99d6","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Documentation Impact"},{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The nova/api/openstack/rest_api_version_history.rst document will be updated."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_5c349148","line":146,"updated":"2015-10-16 20:31:49.000000000","message":"not sure it\u0027s needed to mention that.","commit_id":"3ff23b616f3a724c3dc5e727a0a3d45de6975d7d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a001c3268069847dbbe3c156f04b6460f8a97e82","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"As of now, we do not get the IP Address of hypervisors in nova hypervisor-list."},{"line_number":20,"context_line":"To get those details, we need to run nova hypervisor-show \u003cname\u003e for each"},{"line_number":21,"context_line":"hypervisor. This spec describes how to add the IPaddress details to"},{"line_number":22,"context_line":"hypervisor-list."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba8a016a_febeb1ac","line":21,"updated":"2015-11-19 11:40:48.000000000","message":"Actually we have \u0027GET /v2.1/​{tenant_id}​/os-hypervisors/detail\u0027, then you can get a list which include the host ip. https://github.com/openstack/nova/blob/master/doc/api_samples/os-hypervisors/hypervisors-detail-resp.json\n\nI think the only we need to do is add nova client command, hypervisor-detail\n\nAnd fix this doc http://developer.openstack.org/api-ref-compute-v2.1.html#os-hypervisors-v2.1","commit_id":"9ec882372b12974c868cf4c7fd69d3ed7b5929ee"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6c20617c836f9fc698d8ac85a290b6b7e0c6df58","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"As of now, we do not get the IP Address of hypervisors in nova hypervisor-list."},{"line_number":20,"context_line":"To get those details, we need to run nova hypervisor-show \u003cname\u003e for each"},{"line_number":21,"context_line":"hypervisor. This spec describes how to add the IPaddress details to"},{"line_number":22,"context_line":"hypervisor-list."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba8a016a_9503620d","line":21,"in_reply_to":"ba8a016a_febeb1ac","updated":"2015-11-20 21:55:58.000000000","message":"Damn Alex, good catch ! Yeah, it seems this spec is no longer needed and the blueprint could be specless.","commit_id":"9ec882372b12974c868cf4c7fd69d3ed7b5929ee"}]}