)]}'
{"specs/mitaka/approved/libvirt-pvpanic.rst":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9c641cc99b04260e064f70780095c1efd399a404","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"A Panic device has been introduced to QEMU and has Libvirt support since"},{"line_number":19,"context_line":"version 1.2.1 Using this device, the guest can notify the host once a guest"},{"line_number":20,"context_line":"panic has occurred, by sending an event to qemu, that in it\u0027s turn will notify"},{"line_number":21,"context_line":"Libvirt. Libvirt has controls for how it can react to such an event; either by"},{"line_number":22,"context_line":"restarting or shunting down the guest."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_e3a16bf9","line":19,"updated":"2015-09-04 09:23:21.000000000","message":"nit - punctuation","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9c641cc99b04260e064f70780095c1efd399a404","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"A Panic device has been introduced to QEMU and has Libvirt support since"},{"line_number":19,"context_line":"version 1.2.1 Using this device, the guest can notify the host once a guest"},{"line_number":20,"context_line":"panic has occurred, by sending an event to qemu, that in it\u0027s turn will notify"},{"line_number":21,"context_line":"Libvirt. Libvirt has controls for how it can react to such an event; either by"},{"line_number":22,"context_line":"restarting or shunting down the guest."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_03b7bf3a","line":20,"updated":"2015-09-04 09:23:21.000000000","message":"nit - remove `it\u0027s`","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3c5604fba43903e7060ff8d658f78c8204ef79a6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"version 1.2.1 Using this device, the guest can notify the host once a guest"},{"line_number":20,"context_line":"panic has occurred, by sending an event to qemu, that in it\u0027s turn will notify"},{"line_number":21,"context_line":"Libvirt. Libvirt has controls for how it can react to such an event; either by"},{"line_number":22,"context_line":"restarting or shunting down the guest."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"In addition, Libvirt has a mechanism to automatically save guest crash dumps"},{"line_number":25,"context_line":"to a dedicated location on a host. Enabling the panic device for guest"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_3633ffac","line":22,"range":{"start_line":22,"start_character":14,"end_line":22,"end_character":22},"updated":"2015-09-17 12:54:58.000000000","message":"shutting","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9c641cc99b04260e064f70780095c1efd399a404","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"In addition, Libvirt has a mechanism to automatically save guest crash dumps"},{"line_number":25,"context_line":"to a dedicated location on a host. Enabling the panic device for guest"},{"line_number":26,"context_line":"instances will allows a crash dump of it to be taken, without the need of"},{"line_number":27,"context_line":"kdump running within the guest."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"If kdump and pvpanic are both enabled for the same guest, kdump takes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_038edf78","line":26,"updated":"2015-09-04 09:23:21.000000000","message":"nit - allow","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9c641cc99b04260e064f70780095c1efd399a404","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Use Cases"},{"line_number":34,"context_line":"----------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Operators and anyone who is interested in debugging guest instances crushes,"},{"line_number":37,"context_line":"will benefit from the additional flexibility in obtaining these core dump files"},{"line_number":38,"context_line":"directly from the server hosting these instance or from a configurable central"},{"line_number":39,"context_line":"location."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_a3f5b3ed","line":36,"updated":"2015-09-04 09:23:21.000000000","message":"nit - crashes","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b691759fbcca1373791e6de17d9f1ad70d2234a6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"This location can be set in the configuration file /etc/libvirt/qemu.conf"},{"line_number":41,"context_line":"The auto_dump_path parameter specifies the path name to the directory where"},{"line_number":42,"context_line":"dump files will be stored. The default is /var/lib/libvirt/qemu/dump."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Project Priority"},{"line_number":46,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_ac7189e2","line":43,"updated":"2015-09-02 10:41:50.000000000","message":"Instead of just have it in host. Can we have something more evaluate. We can create a volume based on that dump and share that volume to owner of the instance.\n\nSo users can have access to dumps without help of operators.","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9c641cc99b04260e064f70780095c1efd399a404","unresolved":false,"context_lines":[{"line_number":40,"context_line":"This location can be set in the configuration file /etc/libvirt/qemu.conf"},{"line_number":41,"context_line":"The auto_dump_path parameter specifies the path name to the directory where"},{"line_number":42,"context_line":"dump files will be stored. The default is /var/lib/libvirt/qemu/dump."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Project Priority"},{"line_number":46,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_43c6179b","line":43,"in_reply_to":"da20952f_ac7189e2","updated":"2015-09-04 09:23:21.000000000","message":"While useful I wouldn\u0027t include that in the initial version of this feature. It opens up a long list of potential security problems with the sharing of the core within a tenant, amongst users etc.","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"891b0997d5a26067a53a50216cadaa0fc5294f83","unresolved":false,"context_lines":[{"line_number":41,"context_line":"The auto_dump_path parameter specifies the path name to the directory where"},{"line_number":42,"context_line":"dump files will be stored. The default is /var/lib/libvirt/qemu/dump."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Project Priority"},{"line_number":46,"context_line":"-----------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_9f8a24be","line":44,"updated":"2015-09-04 23:39:00.000000000","message":"I was going to ask if we want to have some kind of rotation policy or time limit on how long we keep these by default? I don\u0027t think we can have this enabled by default (that is, available for the tenants to access using image props) if we don\u0027t in the default implementation have a way to ensure the tenant can\u0027t continue generating dumps indefinitely regardless of the space taken up (to avoid this admin would need to put specific management on /var/lib/libvirt/qemu/dump themselves as proposed)?","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3c5604fba43903e7060ff8d658f78c8204ef79a6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Add an image property setting for controlling the Panic device for instances."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    Ex: hw_panic_device\u003denabled"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_b6daafe6","line":56,"updated":"2015-09-17 12:54:58.000000000","message":"This section needs a lot of filling out! Some of the use case info should be here instead.\n\nHow do we configure libvirt\u0027s responses to a guest panic? How do we prevent dumps forming a denial of service vs drive space? How are operators expected to retrieve dumps? What is the default for hw_panic_device?","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bc40a722a4676161d36fde40bcc75fdd576fd8e2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Security impact"},{"line_number":79,"context_line":"---------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Notifications impact"},{"line_number":84,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_4eba0d0c","line":81,"updated":"2015-10-20 03:09:45.000000000","message":"Well there are several around data privacy.  I my not want the operator/tennanat admin to be able to read a kernel panic in *my* guest","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3c5604fba43903e7060ff8d658f78c8204ef79a6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Other deployer impact"},{"line_number":99,"context_line":"---------------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"No Impact in general. However, deployers maybe interested in changing the"},{"line_number":102,"context_line":"default core dumps location to a central storage instead of a local host"},{"line_number":103,"context_line":"directory."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_76e09796","line":101,"range":{"start_line":101,"start_character":41,"end_line":101,"end_character":46},"updated":"2015-09-17 12:54:58.000000000","message":"nit: may be","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"891b0997d5a26067a53a50216cadaa0fc5294f83","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"No Impact in general. However, deployers maybe interested in changing the"},{"line_number":102,"context_line":"default core dumps location to a central storage instead of a local host"},{"line_number":103,"context_line":"directory."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Developer impact"},{"line_number":106,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_bf87e8b3","line":103,"updated":"2015-09-04 23:39:00.000000000","message":"Per my comment under use case I think there is actually a fair bit of deployer impact as proposed in that if I understand correctly in the default case:\n1) The feature will be available/enabled.\n2) The dump location will be set.\n3) Tenants will be able to enable it per image.\n4) I\u0027m *assuming* there is no way to control what image properties can be used by policy.\n\nI would suggest that in the either we need a mechanism to limit the amount of space these can take up or it should be disabled by default (maybe instead of another flag for enabling simply default the path to blank and only if a path is set by the admin enable it - I\u0027m just spitballing though).","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bc40a722a4676161d36fde40bcc75fdd576fd8e2","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"No Impact in general. However, deployers maybe interested in changing the"},{"line_number":102,"context_line":"default core dumps location to a central storage instead of a local host"},{"line_number":103,"context_line":"directory."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Developer impact"},{"line_number":106,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_0ed41545","line":103,"in_reply_to":"da20952f_bf87e8b3","updated":"2015-10-20 03:09:45.000000000","message":"I totally agree.  We need to be able to limit the resource consumption of this.  Either include it in the user quota or have a well defined retention protocol.","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3c5604fba43903e7060ff8d658f78c8204ef79a6","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Documentation Impact"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Documentation for the Panic device features and it\u0027s configuration options"},{"line_number":146,"context_line":"in libvirt is required."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_9679abca","line":145,"range":{"start_line":145,"start_character":48,"end_line":145,"end_character":52},"updated":"2015-09-17 12:54:58.000000000","message":"\"it\u0027s\" means \"it is\"; possessive form of \"it\" is a special case in English, \"its\".","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9c641cc99b04260e064f70780095c1efd399a404","unresolved":false,"context_lines":[{"line_number":152,"context_line":"* https://libvirt.org/formatdomain.html#elementsPanic"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"History"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Optional section for Mitaka intended to be used each time the spec"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_c35f87e3","line":155,"updated":"2015-09-04 09:23:21.000000000","message":"nit - clear this section.","commit_id":"fb08567d946df4c059723a44518346d6babb8e64"}]}