)]}'
{"specs/mitaka/approved/add-os-win-library.rst":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5bc40ce16cdaecc9965645b816f6a73aa353cb26","unresolved":false,"context_lines":[{"line_number":16,"context_line":"A common library can be created in order to reduce the code duplication between"},{"line_number":17,"context_line":"all these components (utils classes, which interacts directly with Hyper-V"},{"line_number":18,"context_line":"through WMI), making it easier to maintain, review and propose new changes to"},{"line_number":19,"context_line":"current and future components."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_34911e9a","line":19,"updated":"2015-10-20 04:41:12.000000000","message":"I think moving OS specific code into a standalone library like oslo.vmware is a great idea.  I think that needs an oslo spec to create the new library.  Once that library exists I think it\u0027s just a spec-less blueprint to move nova(and neutron etc) over to using that library.","commit_id":"6d9fed9d80fb4eafaf0dbf7fc56fc1065331db01"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69cbbf5b62d737e70dfccb8a61d292e98ca60c7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"A common library can be created in order to reduce the code duplication between"},{"line_number":17,"context_line":"all these components (utils classes, which interacts directly with Hyper-V"},{"line_number":18,"context_line":"through WMI), making it easier to maintain, review and propose new changes to"},{"line_number":19,"context_line":"current and future components."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_3f632ede","line":19,"in_reply_to":"3a29b11f_34911e9a","updated":"2015-10-20 10:21:39.000000000","message":"Actually, that was the original plan, to have \"oslo.windows\". But the oslo team suggested that os-win should be a standalone project, as otherwise the oslo team would also have to maintain in and there aren\u0027t many / anyone that specializes in this platform.\n\nDims / Doug Hellmann can confirm this.","commit_id":"6d9fed9d80fb4eafaf0dbf7fc56fc1065331db01"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ee2fdd28164dd3996b485bf30fe8b41b5be2697e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"A common library can be created in order to reduce the code duplication between"},{"line_number":17,"context_line":"all these components (utils classes, which interacts directly with Hyper-V"},{"line_number":18,"context_line":"through WMI), making it easier to maintain, review and propose new changes to"},{"line_number":19,"context_line":"current and future components."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_dadec110","line":19,"in_reply_to":"3a29b11f_3f632ede","updated":"2015-10-20 13:17:21.000000000","message":"Right, we recommended that the Hyper-V team manage this library themselves.","commit_id":"6d9fed9d80fb4eafaf0dbf7fc56fc1065331db01"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5bc40ce16cdaecc9965645b816f6a73aa353cb26","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The primary changes that needs to be done are as follows:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* add os-win in requirements.txt"},{"line_number":54,"context_line":"* replace ``nova.virt.hyperv.vmutils.HyperVException`` references to"},{"line_number":55,"context_line":"  ``os_win.HyperVException``"},{"line_number":56,"context_line":"* replace all ``nova.virt.hyperv.utilsfactory`` imports used by the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_34e83e10","line":53,"updated":"2015-10-20 04:41:12.000000000","message":"Actually add it to global-requirements.txt in the openstack/requirements repo and then add it to nova\u0027s requirements.txt file","commit_id":"6d9fed9d80fb4eafaf0dbf7fc56fc1065331db01"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69cbbf5b62d737e70dfccb8a61d292e98ca60c7","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The primary changes that needs to be done are as follows:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* add os-win in requirements.txt"},{"line_number":54,"context_line":"* replace ``nova.virt.hyperv.vmutils.HyperVException`` references to"},{"line_number":55,"context_line":"  ``os_win.HyperVException``"},{"line_number":56,"context_line":"* replace all ``nova.virt.hyperv.utilsfactory`` imports used by the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_ff829651","line":53,"in_reply_to":"3a29b11f_34e83e10","updated":"2015-10-20 10:21:39.000000000","message":"It already merged in global-requirements.txt. This line refers to adding to nova\u0027s requirements.txt, as you say.","commit_id":"6d9fed9d80fb4eafaf0dbf7fc56fc1065331db01"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5bc40ce16cdaecc9965645b816f6a73aa353cb26","unresolved":false,"context_lines":[{"line_number":110,"context_line":"* nova commit, implementing the blueprint and using the changes made in os-win."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"As a rule of thumb, if the nova commit requires a certain os-win commit, it"},{"line_number":113,"context_line":"should be referenced by ChangeID in the commit message."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementation"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_74c5568c","line":113,"updated":"2015-10-20 04:41:12.000000000","message":"And additional impact is that after adoption backports become harder as kilo, liberty will not have the os-win library so you\u0027ll end up with two sest of fixes.","commit_id":"6d9fed9d80fb4eafaf0dbf7fc56fc1065331db01"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69cbbf5b62d737e70dfccb8a61d292e98ca60c7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"* nova commit, implementing the blueprint and using the changes made in os-win."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"As a rule of thumb, if the nova commit requires a certain os-win commit, it"},{"line_number":113,"context_line":"should be referenced by ChangeID in the commit message."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementation"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_ffe9361b","line":113,"in_reply_to":"3a29b11f_74c5568c","updated":"2015-10-20 10:21:39.000000000","message":"True, good point. The stable backports should then include both (cherry picked from commit commit_id) lines.","commit_id":"6d9fed9d80fb4eafaf0dbf7fc56fc1065331db01"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"fb14812ea6bef0755d474c99f0c1f6bd751b326c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"A common library can be created in order to reduce the code duplication between"},{"line_number":17,"context_line":"all these components (utils classes, which interacts directly with Hyper-V"},{"line_number":18,"context_line":"through WMI), making it easier to maintain, review and propose new changes to"},{"line_number":19,"context_line":"current and future components."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_c3326410","line":19,"updated":"2015-10-20 12:10:48.000000000","message":"I guess you want to create a new library os-win at my first glance :-),  \nCan you declare  a libary os-win was created  and nova can leverage that library ?","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"20f62173a9d0e26f09afdd2ceeb506af15566f0a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"A common library can be created in order to reduce the code duplication between"},{"line_number":17,"context_line":"all these components (utils classes, which interacts directly with Hyper-V"},{"line_number":18,"context_line":"through WMI), making it easier to maintain, review and propose new changes to"},{"line_number":19,"context_line":"current and future components."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_6979f12e","line":19,"in_reply_to":"3a29b11f_c3326410","updated":"2015-10-20 12:36:38.000000000","message":"True, makes sense.","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"fb14812ea6bef0755d474c99f0c1f6bd751b326c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"There are many Hyper-V utils modules duplicated across several projects,"},{"line_number":25,"context_line":"which can be refactored into a single project, reducing the code duplication"},{"line_number":26,"context_line":"and making it easier to maintain. Plus, the review process will be simplified,"},{"line_number":27,"context_line":"as reviewers won\u0027t have to review Hyper-V related code, in which not everyone"},{"line_number":28,"context_line":"is proeficient."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_8658fa33","line":25,"updated":"2015-10-20 12:10:48.000000000","message":"single project means os-win, right ?","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"20f62173a9d0e26f09afdd2ceeb506af15566f0a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"There are many Hyper-V utils modules duplicated across several projects,"},{"line_number":25,"context_line":"which can be refactored into a single project, reducing the code duplication"},{"line_number":26,"context_line":"and making it easier to maintain. Plus, the review process will be simplified,"},{"line_number":27,"context_line":"as reviewers won\u0027t have to review Hyper-V related code, in which not everyone"},{"line_number":28,"context_line":"is proeficient."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_2973f94e","line":25,"in_reply_to":"3a29b11f_8658fa33","updated":"2015-10-20 12:36:38.000000000","message":"yep.","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e143f771c7408f146f0c77effda710ac6b0f5322","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Data model impact"},{"line_number":72,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_faee248a","line":69,"updated":"2015-10-20 11:11:57.000000000","message":"I wonder if we should include the oslo story here, for reference.","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f6fcb1d53176ff91cfa21ef4e72fb19dc8de183d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Data model impact"},{"line_number":72,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_202c6eaa","line":69,"in_reply_to":"3a29b11f_e03bd69a","updated":"2015-10-20 11:38:44.000000000","message":"Sorry, I was unclear, just a sentence about why its not an oslo lib is fine.","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"339a38e27a75de544aff85495bc6f0b629b4b8ae","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Data model impact"},{"line_number":72,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_e03bd69a","line":69,"in_reply_to":"3a29b11f_faee248a","updated":"2015-10-20 11:21:38.000000000","message":"I will have to dig through IRC logs from 1-2 months ago, that\u0027s going to take some time..","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e143f771c7408f146f0c77effda710ac6b0f5322","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* nova commit, implementing the blueprint and using the changes made in os-win."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"As a rule of thumb, if the nova commit requires a certain os-win commit, it"},{"line_number":117,"context_line":"should be referenced by ChangeID in the commit message."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"For bugfixes, there are chances that they require 2 patches: one for nova and"},{"line_number":120,"context_line":"one for os-win. The backported bugfix must be a squashed version of the 2"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_3aab3c1f","line":117,"updated":"2015-10-20 11:11:57.000000000","message":"So I am afraid that will not work, as a library, we depend on a specific version, so you would actually need to release a new version of the library, and then update the global-dependencies, etc, before using the new code :( But you can depend on the global-requirements update, maybe?\n\nNow most libs are starting to release once a week, and have a standard cycle of updates.","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"339a38e27a75de544aff85495bc6f0b629b4b8ae","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* nova commit, implementing the blueprint and using the changes made in os-win."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"As a rule of thumb, if the nova commit requires a certain os-win commit, it"},{"line_number":117,"context_line":"should be referenced by ChangeID in the commit message."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"For bugfixes, there are chances that they require 2 patches: one for nova and"},{"line_number":120,"context_line":"one for os-win. The backported bugfix must be a squashed version of the 2"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_2000eea9","line":117,"in_reply_to":"3a29b11f_3aab3c1f","updated":"2015-10-20 11:21:38.000000000","message":"Makes sense.","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"fb14812ea6bef0755d474c99f0c1f6bd751b326c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"os-win added to global-requirements.txt:"},{"line_number":173,"context_line":"    https://review.openstack.org/#/c/230394/"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"History"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_860a3a20","line":173,"updated":"2015-10-20 12:10:48.000000000","message":"a  link  for os-win library ?  https://github.com/openstack/os-win","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"20f62173a9d0e26f09afdd2ceeb506af15566f0a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"os-win added to global-requirements.txt:"},{"line_number":173,"context_line":"    https://review.openstack.org/#/c/230394/"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"History"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_49a515a0","line":173,"in_reply_to":"3a29b11f_860a3a20","updated":"2015-10-20 12:36:38.000000000","message":"Done","commit_id":"ce9f0e425cf3bd136e26fda666e52d5e41c5a080"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f3cf2bbccccc79b339a27a206c2f10aea4b675a5","unresolved":false,"context_lines":[{"line_number":117,"context_line":"* nova commit, implementing the blueprint and using the changes made in os-win."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"If a nova commit requires a newer version of os-win, the patch to"},{"line_number":120,"context_line":"global-requirements should be referenced with Depends-On in the commit message."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"For bugfixes, there are chances that they require 2 patches: one for nova and"},{"line_number":123,"context_line":"one for os-win. The backported bugfix must be a squashed version of the 2"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_d108df93","line":120,"updated":"2015-10-20 15:58:27.000000000","message":"Not 100% sure if that works, but it states the key bit, that os-win needs releasing.","commit_id":"fcda996715867e3926cf303f7f96ae93be93e0bd"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"8bfb9ec43a31d6e5abae7d41c55cc79f8789c0e2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"* nova commit, implementing the blueprint and using the changes made in os-win."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"If a nova commit requires a newer version of os-win, the patch to"},{"line_number":120,"context_line":"global-requirements should be referenced with Depends-On in the commit message."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"For bugfixes, there are chances that they require 2 patches: one for nova and"},{"line_number":123,"context_line":"one for os-win. The backported bugfix must be a squashed version of the 2"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_cac6d799","line":120,"in_reply_to":"3a29b11f_38ffb335","updated":"2015-10-20 22:50:27.000000000","message":"This captures the key point that nova\u0027s requirements will need to be bumped to get bug fixes from os-win.","commit_id":"fcda996715867e3926cf303f7f96ae93be93e0bd"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"147bba7f70c341c4e4545da2428477d49eb8d16e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"* nova commit, implementing the blueprint and using the changes made in os-win."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"If a nova commit requires a newer version of os-win, the patch to"},{"line_number":120,"context_line":"global-requirements should be referenced with Depends-On in the commit message."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"For bugfixes, there are chances that they require 2 patches: one for nova and"},{"line_number":123,"context_line":"one for os-win. The backported bugfix must be a squashed version of the 2"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_38ffb335","line":120,"in_reply_to":"3a29b11f_d108df93","updated":"2015-10-20 16:43:04.000000000","message":"Well, the Depends-On commits are applied to their respective projects beforehand (even if it isn\u0027t on the same project). I\u0027ve seen it a couple of times while reviewing.","commit_id":"fcda996715867e3926cf303f7f96ae93be93e0bd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f3cf2bbccccc79b339a27a206c2f10aea4b675a5","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  or incompatible changes has been made to the library, that requires changes"},{"line_number":157,"context_line":"  in the HyperVDriver."},{"line_number":158,"context_line":"* **Patch version**. Bumped if ompatible changes has been made to the library,"},{"line_number":159,"context_line":"  does not require any change in the HyperVDriver."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Testing"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_f2ee3ab3","line":159,"updated":"2015-10-20 15:58:27.000000000","message":"Sorry, I didn\u0027t spot this bit before. we don\u0027t really want this detail in the spec, it should probably just say \"uses SemVer\" or something similar. Not sure you will want to bump the major version every openstack release, for example.\n\nI would just delete this bit.","commit_id":"fcda996715867e3926cf303f7f96ae93be93e0bd"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"147bba7f70c341c4e4545da2428477d49eb8d16e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  or incompatible changes has been made to the library, that requires changes"},{"line_number":157,"context_line":"  in the HyperVDriver."},{"line_number":158,"context_line":"* **Patch version**. Bumped if ompatible changes has been made to the library,"},{"line_number":159,"context_line":"  does not require any change in the HyperVDriver."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Testing"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_3886d3b9","line":159,"in_reply_to":"3a29b11f_f2ee3ab3","updated":"2015-10-20 16:43:04.000000000","message":"Done","commit_id":"fcda996715867e3926cf303f7f96ae93be93e0bd"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"350815ed7ccc97bc9ee7fe0a17e6f6f8f379abea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-os-win-library"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hyper-V is involved in many of OpenStack components (nova, neutron, cinder,"},{"line_number":14,"context_line":"ceilometer, etc.) and will be involved with other components in the future."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"A common library has been created, named os-win, in order to reduce the code"},{"line_number":17,"context_line":"duplication between all these components (utils classes, which interacts"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_4ad2c75d","line":14,"updated":"2015-10-20 22:51:41.000000000","message":"I\u0027d really like to see evidence that these projects are on board.  Without the library being used there I feel like this is additional work for you.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-os-win-library"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hyper-V is involved in many of OpenStack components (nova, neutron, cinder,"},{"line_number":14,"context_line":"ceilometer, etc.) and will be involved with other components in the future."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"A common library has been created, named os-win, in order to reduce the code"},{"line_number":17,"context_line":"duplication between all these components (utils classes, which interacts"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_b221beb6","line":14,"in_reply_to":"3a29b11f_0847d0bc","updated":"2015-11-09 18:08:49.000000000","message":"Yeah, I think of this like the oslo.vmware library.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"0eb269671d9153b4f32d41f39568059a27213fa3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-os-win-library"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hyper-V is involved in many of OpenStack components (nova, neutron, cinder,"},{"line_number":14,"context_line":"ceilometer, etc.) and will be involved with other components in the future."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"A common library has been created, named os-win, in order to reduce the code"},{"line_number":17,"context_line":"duplication between all these components (utils classes, which interacts"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_0847d0bc","line":14,"in_reply_to":"3a29b11f_4ad2c75d","updated":"2015-10-21 16:07:21.000000000","message":"For the record, Mike Perez agreed to this during the Cinder mid-cycle meeting. I will take care of using os-win for our Cinder drivers ASAP, as well as os-brick.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9cf05accf1911d206ccbc406226d17d53527d4fb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-os-win-library"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Hyper-V is involved in many of OpenStack components (nova, neutron, cinder,"},{"line_number":14,"context_line":"ceilometer, etc.) and will be involved with other components in the future."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"A common library has been created, named os-win, in order to reduce the code"},{"line_number":17,"context_line":"duplication between all these components (utils classes, which interacts"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_5056e2ce","line":14,"in_reply_to":"3a29b11f_4ad2c75d","updated":"2015-10-21 10:23:08.000000000","message":"I am OK without that, if this is the direction the Hyper-V team want.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":25,"context_line":"which can be refactored into os-win, reducing the code duplication and making"},{"line_number":26,"context_line":"it easier to maintain. Plus, the review process will be simplified, as"},{"line_number":27,"context_line":"reviewers won\u0027t have to review Hyper-V related code, in which not everyone is"},{"line_number":28,"context_line":"proeficient."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_b208de2e","line":28,"updated":"2015-11-09 18:08:49.000000000","message":"s/proeficient/proficient/","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":25,"context_line":"which can be refactored into os-win, reducing the code duplication and making"},{"line_number":26,"context_line":"it easier to maintain. Plus, the review process will be simplified, as"},{"line_number":27,"context_line":"reviewers won\u0027t have to review Hyper-V related code, in which not everyone is"},{"line_number":28,"context_line":"proeficient."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_5262cdae","line":28,"in_reply_to":"da85f559_b208de2e","updated":"2015-11-09 19:29:18.000000000","message":"Done","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Reviewers will not have to review low level Hyper-V related code. Thus, the"},{"line_number":38,"context_line":"amount of code that needs to be reviewed will be reduced by approximately 50%."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Project Priority"},{"line_number":41,"context_line":"-----------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_3d035f0f","line":40,"updated":"2015-11-09 18:08:49.000000000","message":"We could drop the priority section.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Reviewers will not have to review low level Hyper-V related code. Thus, the"},{"line_number":38,"context_line":"amount of code that needs to be reviewed will be reduced by approximately 50%."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Project Priority"},{"line_number":41,"context_line":"-----------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_325f09e7","line":40,"in_reply_to":"da85f559_3d035f0f","updated":"2015-11-09 19:29:18.000000000","message":"Done","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The primary changes that needs to be done on nova are as follows:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* add os-win in requirements.txt"},{"line_number":54,"context_line":"* replace ``nova.virt.hyperv.vmutils.HyperVException`` references to"},{"line_number":55,"context_line":"  ``os_win.HyperVException``"},{"line_number":56,"context_line":"* replace all ``nova.virt.hyperv.utilsfactory`` imports used by the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_3d2a7f7f","line":53,"updated":"2015-11-09 18:08:49.000000000","message":"It\u0027s in global-requirements already so that\u0027s good:\n\nhttps://github.com/openstack/requirements/blob/16f6a3eff6896fca556efaff2e2a3bca387186d6/global-requirements.txt#L107","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Originally, os-win was planned to be part of Oslo, it was suggested that os-win"},{"line_number":70,"context_line":"should be a standalone project, as otherwise the Oslo team would also have to"},{"line_number":71,"context_line":"maintain in and there aren\u0027t many / anyone that specializes in Windows /"},{"line_number":72,"context_line":"Hyper-V related code."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_fda877dd","line":71,"updated":"2015-11-09 18:08:49.000000000","message":"I\u0027m interested in why it\u0027s different for oslo.vmware, except I assume that was just because Dims did a lot of work on that too.  I guess it\u0027s similar to os-brick then, that\u0027s not maintained by oslo cores since it originated mostly in nova and cinder and has been maintained now by cinder cores.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Originally, os-win was planned to be part of Oslo, it was suggested that os-win"},{"line_number":70,"context_line":"should be a standalone project, as otherwise the Oslo team would also have to"},{"line_number":71,"context_line":"maintain in and there aren\u0027t many / anyone that specializes in Windows /"},{"line_number":72,"context_line":"Hyper-V related code."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_f241810c","line":71,"in_reply_to":"da85f559_fda877dd","updated":"2015-11-09 19:29:18.000000000","message":"It is already explained in this paragraph: the Oslo team decided that os-win should be a standalone project, as almost or no one in the Oslo team specializes in Windows specific bits and pieces.\n\nThey also said that, in retrospect, oslo.vmware should have been the same as os-win, a standalone project.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Performance Impact"},{"line_number":100,"context_line":"------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The new library will offer better error handling and better performance."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Other deployer impact"},{"line_number":105,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_9d4ccb43","line":102,"updated":"2015-11-09 18:08:49.000000000","message":"How?  I would have probably just left this as None.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Performance Impact"},{"line_number":100,"context_line":"------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The new library will offer better error handling and better performance."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Other deployer impact"},{"line_number":105,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_d2ab1dd5","line":102,"in_reply_to":"da85f559_9d4ccb43","updated":"2015-11-09 19:29:18.000000000","message":"Done","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Other deployer impact"},{"line_number":105,"context_line":"---------------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"None, os-win dependency will be installed automatically."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Developer impact"},{"line_number":110,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_7d680788","line":107,"updated":"2015-11-09 18:08:49.000000000","message":"Mmmm, I wouldn\u0027t consider this None really since there are people that deploy from packages which means they\u0027ll need to now also package up os-win since they probably won\u0027t be getting it from a distro for awhile.  But this isn\u0027t a blocker by any means.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Other deployer impact"},{"line_number":105,"context_line":"---------------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"None, os-win dependency will be installed automatically."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Developer impact"},{"line_number":110,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_529f2db4","line":107,"in_reply_to":"da85f559_7d680788","updated":"2015-11-09 19:29:18.000000000","message":"Done","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":119,"context_line":"If a nova commit requires a newer version of os-win, the patch to"},{"line_number":120,"context_line":"global-requirements should be referenced with Depends-On in the commit message."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"For bugfixes, there are chances that they require 2 patches: one for nova and"},{"line_number":123,"context_line":"one for os-win. The backported bugfix must be a squashed version of the 2"},{"line_number":124,"context_line":"patches, referencing both commit IDs in the commit message::"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_fde077fc","line":122,"updated":"2015-11-09 18:08:49.000000000","message":"Yeah, this has been painful for backports in the case of os-brick, e.g.:\n\nhttps://review.openstack.org/#/c/229152/\n\nBut as long as the backports are more targeted it shouldn\u0027t be as big a problem.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":119,"context_line":"If a nova commit requires a newer version of os-win, the patch to"},{"line_number":120,"context_line":"global-requirements should be referenced with Depends-On in the commit message."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"For bugfixes, there are chances that they require 2 patches: one for nova and"},{"line_number":123,"context_line":"one for os-win. The backported bugfix must be a squashed version of the 2"},{"line_number":124,"context_line":"patches, referencing both commit IDs in the commit message::"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_d236bde6","line":122,"in_reply_to":"da85f559_fde077fc","updated":"2015-11-09 19:29:18.000000000","message":"True.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Adds os-win library as a dependency."},{"line_number":153,"context_line":"os-win uses SemVer."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Testing"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_1dbbfbe6","line":153,"updated":"2015-11-09 18:08:49.000000000","message":"Is this just a statement or something that needs to happen yet?  Seems odd to list the semver thing here.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Adds os-win library as a dependency."},{"line_number":153,"context_line":"os-win uses SemVer."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Testing"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_f220a19d","line":153,"in_reply_to":"da85f559_1dbbfbe6","updated":"2015-11-09 19:29:18.000000000","message":"Done","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Documentation Impact"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"None"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"References"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_fd85d706","line":164,"updated":"2015-11-09 18:08:49.000000000","message":"This docs page would probably need updates as far as installing the new dependency:\n\nhttp://docs.openstack.org/liberty/config-reference/content/hyper-v-virtualization-platform.html","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Documentation Impact"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"None"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"References"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_5203ad0d","line":164,"in_reply_to":"da85f559_fd85d706","updated":"2015-11-09 19:29:18.000000000","message":"Done","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7ce55a8f2359330738675763fd9951721fb349","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        https://github.com/openstack/os-win"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"History"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_5d77433a","line":176,"updated":"2015-11-09 18:08:49.000000000","message":"There is something in the template for this, so the first row would just be something like \u0027Mitaka: Introduced\u0027.","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e5be88bd9abaa0b1ac933c62b79149ce345d0550","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        https://github.com/openstack/os-win"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"History"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_deb6c989","line":176,"in_reply_to":"da85f559_5d77433a","updated":"2015-11-09 19:29:18.000000000","message":"Done","commit_id":"4b8618b578d7528972b21d425261eb6b850dfc31"}]}