)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc9011eb0ae324a4d01ec90741c0fcf0c677b5c2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"or updated. Allow users to get the server description, and filter server lists"},{"line_number":11,"context_line":"by description."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API Impact"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6d2a6d11bf38255df1a87348550ae897f8fd05a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba8a016a_aaa1aef9","line":13,"updated":"2015-11-19 17:28:53.000000000","message":"The tag is actually APIImpact.\n\nhttp://git.openstack.org/cgit/openstack/nova-specs/tree/specs/mitaka-template.rst#n74","commit_id":"3bb1f77a60ceb95bfa31185a738c4e13372c8525"}],"specs/mitaka/approved/user-settable-server-description.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/user-settable-server-description"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Allow users to set the description of a server when it is created"},{"line_number":16,"context_line":"or updated. Allow users to get the server description, and filter server lists"},{"line_number":17,"context_line":"by description."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_ac4105ab","line":16,"updated":"2015-10-08 20:58:56.000000000","message":"We shouldn\u0027t allow filtering by description, that\u0027s what tags are for.  The description is really just free form prose that can be updated as needed, not a filtering toggle so let\u0027s remove that part.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"302b3a4169bb8be1d7956462cb6cfc782e7d14ac","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/user-settable-server-description"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Allow users to set the description of a server when it is created"},{"line_number":16,"context_line":"or updated. Allow users to get the server description, and filter server lists"},{"line_number":17,"context_line":"by description."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_46be80d5","line":16,"in_reply_to":"7a2fa921_ac4105ab","updated":"2015-10-14 13:31:37.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently, when a server is created, the description is hardcoded to be the"},{"line_number":23,"context_line":"server name."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Users cannot set a description on the server, retrieve the description,"},{"line_number":26,"context_line":"nor filter servers based on the description. Currently, they need to use"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_cc256109","line":23,"updated":"2015-10-08 20:58:56.000000000","message":"s/name/display name/ for clarity since there are a few server \u0027name\u0027s in the code, like the actual instance.name which isn\u0027t in the database, it\u0027s generated from CONF.instance_name_template.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"302b3a4169bb8be1d7956462cb6cfc782e7d14ac","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently, when a server is created, the description is hardcoded to be the"},{"line_number":23,"context_line":"server name."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Users cannot set a description on the server, retrieve the description,"},{"line_number":26,"context_line":"nor filter servers based on the description. Currently, they need to use"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_468c4035","line":23,"in_reply_to":"7a2fa921_cc256109","updated":"2015-10-14 13:31:37.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":23,"context_line":"server name."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Users cannot set a description on the server, retrieve the description,"},{"line_number":26,"context_line":"nor filter servers based on the description. Currently, they need to use"},{"line_number":27,"context_line":"other fields, such as the server name or meta-data, to provide a description."},{"line_number":28,"context_line":"These are overloading the name and meta-data fields in an unnatural way."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_6c1e8dbc","line":26,"updated":"2015-10-08 20:58:56.000000000","message":"Remove the filtering part.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"302b3a4169bb8be1d7956462cb6cfc782e7d14ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"server name."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Users cannot set a description on the server, retrieve the description,"},{"line_number":26,"context_line":"nor filter servers based on the description. Currently, they need to use"},{"line_number":27,"context_line":"other fields, such as the server name or meta-data, to provide a description."},{"line_number":28,"context_line":"These are overloading the name and meta-data fields in an unnatural way."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_e6feac6a","line":26,"in_reply_to":"7a2fa921_6c1e8dbc","updated":"2015-10-14 13:31:37.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Users cannot set a description on the server, retrieve the description,"},{"line_number":26,"context_line":"nor filter servers based on the description. Currently, they need to use"},{"line_number":27,"context_line":"other fields, such as the server name or meta-data, to provide a description."},{"line_number":28,"context_line":"These are overloading the name and meta-data fields in an unnatural way."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_2c62d53e","line":27,"updated":"2015-10-08 20:58:56.000000000","message":"metadata is really for config drive and the metadata service, but people probably abuse it for this.  Tags is probably more appropriate than metadata.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"302b3a4169bb8be1d7956462cb6cfc782e7d14ac","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Users cannot set a description on the server, retrieve the description,"},{"line_number":26,"context_line":"nor filter servers based on the description. Currently, they need to use"},{"line_number":27,"context_line":"other fields, such as the server name or meta-data, to provide a description."},{"line_number":28,"context_line":"These are overloading the name and meta-data fields in an unnatural way."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_068728d8","line":27,"in_reply_to":"7a2fa921_2c62d53e","updated":"2015-10-14 13:31:37.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Users cannot set a description on the server, retrieve the description,"},{"line_number":26,"context_line":"nor filter servers based on the description. Currently, they need to use"},{"line_number":27,"context_line":"other fields, such as the server name or meta-data, to provide a description."},{"line_number":28,"context_line":"These are overloading the name and meta-data fields in an unnatural way."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_ac56e559","line":28,"updated":"2015-10-08 20:58:56.000000000","message":"I agree with it being wrong to use metadata this way.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"302b3a4169bb8be1d7956462cb6cfc782e7d14ac","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Users cannot set a description on the server, retrieve the description,"},{"line_number":26,"context_line":"nor filter servers based on the description. Currently, they need to use"},{"line_number":27,"context_line":"other fields, such as the server name or meta-data, to provide a description."},{"line_number":28,"context_line":"These are overloading the name and meta-data fields in an unnatural way."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_a66e742d","line":28,"in_reply_to":"7a2fa921_ac56e559","updated":"2015-10-14 13:31:37.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* The End User wishes to provide a description when creating a server."},{"line_number":34,"context_line":"* The End User wishes to get the server\u0027s description."},{"line_number":35,"context_line":"* The End User wishes to change the server\u0027s description."},{"line_number":36,"context_line":"* The End User wishes to filter the server list based on a description regex."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Project Priority"},{"line_number":39,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_6c4c4dc8","line":36,"updated":"2015-10-08 20:58:56.000000000","message":"Removing filtering.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"302b3a4169bb8be1d7956462cb6cfc782e7d14ac","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* The End User wishes to provide a description when creating a server."},{"line_number":34,"context_line":"* The End User wishes to get the server\u0027s description."},{"line_number":35,"context_line":"* The End User wishes to change the server\u0027s description."},{"line_number":36,"context_line":"* The End User wishes to filter the server list based on a description regex."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Project Priority"},{"line_number":39,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_66fdbc39","line":36,"in_reply_to":"7a2fa921_6c4c4dc8","updated":"2015-10-14 13:31:37.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The End User wishes to change the server\u0027s description."},{"line_number":36,"context_line":"* The End User wishes to filter the server list based on a description regex."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Project Priority"},{"line_number":39,"context_line":"-----------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_ecce1d2c","line":38,"updated":"2015-10-08 20:58:56.000000000","message":"Remove this section since it\u0027s been dropped from the template.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"f07c4536bebaca3263734a188592bf84dfb8bcce","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The End User wishes to change the server\u0027s description."},{"line_number":36,"context_line":"* The End User wishes to filter the server list based on a description regex."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Project Priority"},{"line_number":39,"context_line":"-----------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_f1373aae","line":38,"in_reply_to":"5a2ca52d_2696e4f0","updated":"2015-10-14 18:29:09.000000000","message":"I need this section, otherwise tox fails.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0f6c233af6630543ecfe533922924ba74683d3d6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The End User wishes to change the server\u0027s description."},{"line_number":36,"context_line":"* The End User wishes to filter the server list based on a description regex."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Project Priority"},{"line_number":39,"context_line":"-----------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_3177f23b","line":38,"in_reply_to":"5a2ca52d_f1373aae","updated":"2015-10-14 18:32:27.000000000","message":"seems template is already updated? maybe rebase needed?","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"302b3a4169bb8be1d7956462cb6cfc782e7d14ac","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The End User wishes to change the server\u0027s description."},{"line_number":36,"context_line":"* The End User wishes to filter the server list based on a description regex."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Project Priority"},{"line_number":39,"context_line":"-----------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_2696e4f0","line":38,"in_reply_to":"7a2fa921_ecce1d2c","updated":"2015-10-14 13:31:37.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  * Add an optional description parameter to the Create Server and Update"},{"line_number":49,"context_line":"    Server APIs."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    * No default description for new servers (set to NULL in the database)."},{"line_number":52,"context_line":"    * If a null description string is specified on the server update, then"},{"line_number":53,"context_line":"      the description is set to NULL in the database (description is removed)"},{"line_number":54,"context_line":"    * If the description parameter is not specified on the server update,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_6ce3eda4","line":51,"updated":"2015-10-08 20:58:56.000000000","message":"I wonder if for backwards compat we should default to the display_name like we do today.  I guess since we don\u0027t actually expose the description in the response today it doesn\u0027t matter so defaulting to None is fine.  It\u0027s nullable on the Instance object too:\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/instance.py#L128","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  * Add an optional description parameter to the Create Server and Update"},{"line_number":49,"context_line":"    Server APIs."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    * No default description for new servers (set to NULL in the database)."},{"line_number":52,"context_line":"    * If a null description string is specified on the server update, then"},{"line_number":53,"context_line":"      the description is set to NULL in the database (description is removed)"},{"line_number":54,"context_line":"    * If the description parameter is not specified on the server update,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_310620cf","line":51,"in_reply_to":"7a2fa921_6ce3eda4","updated":"2015-10-14 15:16:33.000000000","message":"My reasoning was that the user didn\u0027t want a description for new servers.  Defaulting the description to the name would look redundant in a server display. \n\nFor existing servers, we would now return the defaulted description from the name.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      then the description is not changed."},{"line_number":56,"context_line":"    * An empty description string is allowed."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  * The Get Server Details API returns the description in the JSON response"},{"line_number":59,"context_line":"    if it is not NULL."},{"line_number":60,"context_line":"  * Add an optional description regex parameter to the List Servers and"},{"line_number":61,"context_line":"    List Details for Servers APIs."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_6c7f6dab","line":58,"updated":"2015-10-08 20:58:56.000000000","message":"We should return it regardless, it\u0027s just show up as null in the json response.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      then the description is not changed."},{"line_number":56,"context_line":"    * An empty description string is allowed."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  * The Get Server Details API returns the description in the JSON response"},{"line_number":59,"context_line":"    if it is not NULL."},{"line_number":60,"context_line":"  * Add an optional description regex parameter to the List Servers and"},{"line_number":61,"context_line":"    List Details for Servers APIs."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_31c86022","line":58,"in_reply_to":"7a2fa921_6c7f6dab","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  * The Get Server Details API returns the description in the JSON response"},{"line_number":59,"context_line":"    if it is not NULL."},{"line_number":60,"context_line":"  * Add an optional description regex parameter to the List Servers and"},{"line_number":61,"context_line":"    List Details for Servers APIs."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* Nova V2 client"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_2c4c159d","line":60,"updated":"2015-10-08 20:58:56.000000000","message":"Remove the parts about filtering on description.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  * The Get Server Details API returns the description in the JSON response"},{"line_number":59,"context_line":"    if it is not NULL."},{"line_number":60,"context_line":"  * Add an optional description regex parameter to the List Servers and"},{"line_number":61,"context_line":"    List Details for Servers APIs."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* Nova V2 client"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_917db4b3","line":60,"in_reply_to":"7a2fa921_2c4c159d","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  * Add an optional description parameter to the server create and"},{"line_number":66,"context_line":"    server update methods."},{"line_number":67,"context_line":"  * Return the description on server details methods if it is not NULL."},{"line_number":68,"context_line":"  * Add an optional description regex to the server list method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Openstack V2 compute client"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_cc2481c6","line":67,"updated":"2015-10-08 20:58:56.000000000","message":"I\u0027d think we\u0027d still have the description entry in the server table in the CLI output, the value would just be empty.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  * Add an optional description parameter to the server create and"},{"line_number":66,"context_line":"    server update methods."},{"line_number":67,"context_line":"  * Return the description on server details methods if it is not NULL."},{"line_number":68,"context_line":"  * Add an optional description regex to the server list method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Openstack V2 compute client"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_f2dd0643","line":67,"in_reply_to":"7a2fa921_cc2481c6","updated":"2015-10-14 15:16:33.000000000","message":"I think you are right.\n\nI will add a line to distinguish the show server and server list with details.   Will do the same for the REST API section.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  * Add an optional description parameter to the server create and"},{"line_number":66,"context_line":"    server update methods."},{"line_number":67,"context_line":"  * Return the description on server details methods if it is not NULL."},{"line_number":68,"context_line":"  * Add an optional description regex to the server list method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Openstack V2 compute client"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_8c2a098f","line":68,"updated":"2015-10-08 20:58:56.000000000","message":"Remove.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  * Add an optional description parameter to the server create and"},{"line_number":66,"context_line":"    server update methods."},{"line_number":67,"context_line":"  * Return the description on server details methods if it is not NULL."},{"line_number":68,"context_line":"  * Add an optional description regex to the server list method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Openstack V2 compute client"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_4c78df8f","line":68,"in_reply_to":"7a2fa921_8c2a098f","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  * Return the description on server details methods if it is not NULL."},{"line_number":68,"context_line":"  * Add an optional description regex to the server list method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Openstack V2 compute client"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  * Add an optional description parameter to CreateServer and UpdateServer."},{"line_number":73,"context_line":"  * Return the description on ShowServer if it is not null."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_e706361b","line":70,"updated":"2015-10-08 20:58:56.000000000","message":"I\u0027m wondering how the python-openstackclient guys handle specs but I\u0027d say the same rules apply here as for novaclient above, so show description regardless of whether or not it\u0027s None, and don\u0027t do any filtering on description.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  * Return the description on server details methods if it is not NULL."},{"line_number":68,"context_line":"  * Add an optional description regex to the server list method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Openstack V2 compute client"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  * Add an optional description parameter to CreateServer and UpdateServer."},{"line_number":73,"context_line":"  * Return the description on ShowServer if it is not null."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_72c5763a","line":70,"in_reply_to":"7a2fa921_12eb7279","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  * Return the description on server details methods if it is not NULL."},{"line_number":68,"context_line":"  * Add an optional description regex to the server list method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Openstack V2 compute client"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  * Add an optional description parameter to CreateServer and UpdateServer."},{"line_number":73,"context_line":"  * Return the description on ShowServer if it is not null."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_32bb7ee7","line":70,"in_reply_to":"7a2fa921_e706361b","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"840b402787c912e977eda00f0d00e1df2445fdb0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  * Return the description on server details methods if it is not NULL."},{"line_number":68,"context_line":"  * Add an optional description regex to the server list method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Openstack V2 compute client"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  * Add an optional description parameter to CreateServer and UpdateServer."},{"line_number":73,"context_line":"  * Return the description on ShowServer if it is not null."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_12eb7279","line":70,"in_reply_to":"7a2fa921_e706361b","updated":"2015-10-08 21:36:12.000000000","message":"just open a bug against osc, and fix it when the server side and nova v2 client code is finished","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  * Return the description on ShowServer if it is not null."},{"line_number":74,"context_line":"  * Add an optional description regex to ListServer."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Nova CLI"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  * Add an optional --description argument to the nova boot CLI."},{"line_number":79,"context_line":"  * Return the description on the nova show CLI if it is not NULL."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_671b0674","line":76,"updated":"2015-10-08 20:58:56.000000000","message":"This is redundant with Nova V2 Client above, the Nova CLI is python-novaclient unless you\u0027re talking about nova-manage, which we shouldn\u0027t be updating for this probably.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  * Return the description on ShowServer if it is not null."},{"line_number":74,"context_line":"  * Add an optional description regex to ListServer."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Nova CLI"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  * Add an optional --description argument to the nova boot CLI."},{"line_number":79,"context_line":"  * Return the description on the nova show CLI if it is not NULL."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_f25ae682","line":76,"in_reply_to":"7a2fa921_671b0674","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  * Add an optional --description regex argument to the nova list CLI."},{"line_number":81,"context_line":"  * Note that nova does not have a server update CLI."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Openstack CLI"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  * Add an optional --description argument to the openstack create server CLI."},{"line_number":86,"context_line":"  * Return the description on the openstack server show CLI if it not NULL."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_8718a276","line":83,"updated":"2015-10-08 20:58:56.000000000","message":"Redundant with Openstack V2 compute client above.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"840b402787c912e977eda00f0d00e1df2445fdb0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  * Add an optional --description regex argument to the nova list CLI."},{"line_number":81,"context_line":"  * Note that nova does not have a server update CLI."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Openstack CLI"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  * Add an optional --description argument to the openstack create server CLI."},{"line_number":86,"context_line":"  * Return the description on the openstack server show CLI if it not NULL."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_92722210","line":83,"in_reply_to":"7a2fa921_8718a276","updated":"2015-10-08 21:36:12.000000000","message":"++","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  * Add an optional --description regex argument to the nova list CLI."},{"line_number":81,"context_line":"  * Note that nova does not have a server update CLI."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Openstack CLI"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  * Add an optional --description argument to the openstack create server CLI."},{"line_number":86,"context_line":"  * Return the description on the openstack server show CLI if it not NULL."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_a6d74fec","line":83,"in_reply_to":"7a2fa921_8718a276","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  * Add an optional --description regex argument to the nova list CLI."},{"line_number":81,"context_line":"  * Note that nova does not have a server update CLI."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Openstack CLI"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  * Add an optional --description argument to the openstack create server CLI."},{"line_number":86,"context_line":"  * Return the description on the openstack server show CLI if it not NULL."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_66085792","line":83,"in_reply_to":"7a2fa921_92722210","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9733e557e61a200096a13e5c962f40f8772b5426","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  * Note that the openstack does not have a server update CLI."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Note: A description field already exists in the database, so the change is"},{"line_number":92,"context_line":"to add API/CLI support for setting, getting, and filtering on the"},{"line_number":93,"context_line":"description."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Other projects possibly impacted:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_f0db327a","line":92,"updated":"2015-10-09 13:01:04.000000000","message":"remove this filtering , too","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  * Note that the openstack does not have a server update CLI."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Note: A description field already exists in the database, so the change is"},{"line_number":92,"context_line":"to add API/CLI support for setting, getting, and filtering on the"},{"line_number":93,"context_line":"description."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Other projects possibly impacted:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_86f3339e","line":92,"in_reply_to":"7a2fa921_f0db327a","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Data model impact"},{"line_number":106,"context_line":"-----------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None.  The database column for description already exists as 255 characters."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_472daa93","line":108,"updated":"2015-10-08 20:58:56.000000000","message":"And is nullable.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8c94ae815202562664444b4670ea7ec4d295ee8f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Data model impact"},{"line_number":106,"context_line":"-----------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None.  The database column for description already exists as 255 characters."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_c98a9cbf","line":108,"in_reply_to":"7a2fa921_472daa93","updated":"2015-10-14 15:16:33.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"918cfb31c543c321709c4c11be09ca71bda46eaa","unresolved":false,"context_lines":[{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    description \u003d {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 0, \u0027maxLength\u0027: 255,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_d8698afa","line":119,"updated":"2015-10-09 08:54:54.000000000","message":"As previous lines description, we enable null, so the type should be \"type\u0027: [\u0027string\u0027, \u0027null\u0027],\"\n\nAnother problem is we should think about wehther leading/trailing spaces, spaces in the middle, and the case of all character are spaces","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    description \u003d {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 0, \u0027maxLength\u0027: 255,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_274f4e6c","line":119,"updated":"2015-10-08 20:58:56.000000000","message":"The name parameter validation includes unicode validation, so that\u0027s something we have to take into account I think.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a3d563ce4c98590a7167cc6fa5ce77304b0b6fec","unresolved":false,"context_lines":[{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    description \u003d {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 0, \u0027maxLength\u0027: 255,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_8bcd735f","line":119,"in_reply_to":"7a2fa921_1057ceca","updated":"2015-10-14 18:04:42.000000000","message":"Yes, that\u0027s what I was thinking - it can be any printable unicode string.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9733e557e61a200096a13e5c962f40f8772b5426","unresolved":false,"context_lines":[{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    description \u003d {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 0, \u0027maxLength\u0027: 255,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_b0661ab9","line":119,"in_reply_to":"7a2fa921_274f4e6c","updated":"2015-10-09 13:01:04.000000000","message":"++","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a3d563ce4c98590a7167cc6fa5ce77304b0b6fec","unresolved":false,"context_lines":[{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    description \u003d {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 0, \u0027maxLength\u0027: 255,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_eb88a724","line":119,"in_reply_to":"7a2fa921_274f4e6c","updated":"2015-10-14 18:04:42.000000000","message":"I will allow any printable unicode string.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a3d563ce4c98590a7167cc6fa5ce77304b0b6fec","unresolved":false,"context_lines":[{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    description \u003d {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 0, \u0027maxLength\u0027: 255,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_0b8c0334","line":119,"in_reply_to":"7a2fa921_b0661ab9","updated":"2015-10-14 18:04:42.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a3d563ce4c98590a7167cc6fa5ce77304b0b6fec","unresolved":false,"context_lines":[{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    description \u003d {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 0, \u0027maxLength\u0027: 255,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_2bc53f3b","line":119,"in_reply_to":"7a2fa921_d8698afa","updated":"2015-10-14 18:04:42.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9733e557e61a200096a13e5c962f40f8772b5426","unresolved":false,"context_lines":[{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    description \u003d {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 0, \u0027maxLength\u0027: 255,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_1057ceca","line":119,"in_reply_to":"7a2fa921_d8698afa","updated":"2015-10-09 13:01:04.000000000","message":"guess description is description and you can add whatever you want if it\u0027s string?","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Change the following APIs under a new microversion:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"`Create Server \u003chttp://developer.openstack.org/api-ref-compute-v2.html#createServer\u003e`_"},{"line_number":126,"context_line":"......................................................................................"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"New request parameter:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_e73e368a","line":125,"updated":"2015-10-08 20:58:56.000000000","message":"Here and elsewhere below, it should be the v2.1 docs, like:\n\nhttp://developer.openstack.org/api-ref-compute-v2.1.html","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a3d563ce4c98590a7167cc6fa5ce77304b0b6fec","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Change the following APIs under a new microversion:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"`Create Server \u003chttp://developer.openstack.org/api-ref-compute-v2.html#createServer\u003e`_"},{"line_number":126,"context_line":"......................................................................................"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"New request parameter:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_ae0f1de0","line":125,"in_reply_to":"7a2fa921_e73e368a","updated":"2015-10-14 18:04:42.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":145,"context_line":"                \u0027properties\u0027: {"},{"line_number":146,"context_line":"                    \u0027name\u0027: parameter_types.hostname,"},{"line_number":147,"context_line":"                    \u0027description\u0027: parameter_types.description,"},{"line_number":148,"context_line":"                    \u0027imageRef\u0027: parameter_types.image_ref,"},{"line_number":149,"context_line":"                    \u0027flavorRef\u0027: parameter_types.flavor_ref,"},{"line_number":150,"context_line":"                    \u0027adminPass\u0027: parameter_types.admin_password,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_ecb37d98","line":147,"updated":"2015-10-08 20:58:56.000000000","message":"This doesn\u0027t exist:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py\n\nWhat would you set it to?  It\u0027s tempting to say it\u0027s the same as parameter_types.name but that requires a min length of 1 where we\u0027d allow a 0 length description.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a3d563ce4c98590a7167cc6fa5ce77304b0b6fec","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":145,"context_line":"                \u0027properties\u0027: {"},{"line_number":146,"context_line":"                    \u0027name\u0027: parameter_types.hostname,"},{"line_number":147,"context_line":"                    \u0027description\u0027: parameter_types.description,"},{"line_number":148,"context_line":"                    \u0027imageRef\u0027: parameter_types.image_ref,"},{"line_number":149,"context_line":"                    \u0027flavorRef\u0027: parameter_types.flavor_ref,"},{"line_number":150,"context_line":"                    \u0027adminPass\u0027: parameter_types.admin_password,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_6e96e54d","line":147,"in_reply_to":"7a2fa921_30ad2a9b","updated":"2015-10-14 18:04:42.000000000","message":"Yes, I mention it above.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9733e557e61a200096a13e5c962f40f8772b5426","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":145,"context_line":"                \u0027properties\u0027: {"},{"line_number":146,"context_line":"                    \u0027name\u0027: parameter_types.hostname,"},{"line_number":147,"context_line":"                    \u0027description\u0027: parameter_types.description,"},{"line_number":148,"context_line":"                    \u0027imageRef\u0027: parameter_types.image_ref,"},{"line_number":149,"context_line":"                    \u0027flavorRef\u0027: parameter_types.flavor_ref,"},{"line_number":150,"context_line":"                    \u0027adminPass\u0027: parameter_types.admin_password,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_30ad2a9b","line":147,"in_reply_to":"7a2fa921_ecb37d98","updated":"2015-10-09 13:01:04.000000000","message":"I think line #118 mentioned it","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":210,"context_line":"  or longer than 255 characters."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"`List Servers \u003chttp://developer.openstack.org/api-ref-compute-v2.html#listServers\u003e`_"},{"line_number":214,"context_line":"...................................................................................."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"New request parameter:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_4754cafd","line":213,"updated":"2015-10-08 20:58:56.000000000","message":"We shouldn\u0027t filter on description.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a3d563ce4c98590a7167cc6fa5ce77304b0b6fec","unresolved":false,"context_lines":[{"line_number":210,"context_line":"  or longer than 255 characters."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"`List Servers \u003chttp://developer.openstack.org/api-ref-compute-v2.html#listServers\u003e`_"},{"line_number":214,"context_line":"...................................................................................."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"New request parameter:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_2eaead85","line":213,"in_reply_to":"7a2fa921_4754cafd","updated":"2015-10-14 18:04:42.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":223,"context_line":"+---------------------+------+-------+---------------------------------------+"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"`List Detail Servers \u003chttp://developer.openstack.org/api-ref-compute-v2.html#listDetailServers\u003e`_"},{"line_number":227,"context_line":"................................................................................................."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"New request parameter:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_e754f6fe","line":226,"updated":"2015-10-08 20:58:56.000000000","message":"Same.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a3d563ce4c98590a7167cc6fa5ce77304b0b6fec","unresolved":false,"context_lines":[{"line_number":223,"context_line":"+---------------------+------+-------+---------------------------------------+"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"`List Detail Servers \u003chttp://developer.openstack.org/api-ref-compute-v2.html#listDetailServers\u003e`_"},{"line_number":227,"context_line":"................................................................................................."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"New request parameter:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_4ea9a97a","line":226,"in_reply_to":"7a2fa921_e754f6fe","updated":"2015-10-14 18:04:42.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"None"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"Notifications impact"},{"line_number":273,"context_line":"--------------------"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"* Change to existing notification on instance update if description changes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_a7b11e49","line":272,"updated":"2015-10-08 20:58:56.000000000","message":"Hmm, I\u0027m not sure about this.  Notifications aren\u0027t versioned.  Adding things to the payload is not as bad as changing keys or removing things though, so maybe this is OK.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"None"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"Notifications impact"},{"line_number":273,"context_line":"--------------------"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"* Change to existing notification on instance update if description changes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_eedd1515","line":272,"in_reply_to":"7a2fa921_a7b11e49","updated":"2015-10-14 18:18:08.000000000","message":"Ok, so I assume these are useful additions.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Developer impact"},{"line_number":293,"context_line":"----------------"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"Horizon can add the description to the GUI."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_27842e5c","line":295,"updated":"2015-10-08 20:58:56.000000000","message":"This doesn\u0027t seem to fit here.  Would be more appropriate in other end user impact above I\u0027d think.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9733e557e61a200096a13e5c962f40f8772b5426","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Developer impact"},{"line_number":293,"context_line":"----------------"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"Horizon can add the description to the GUI."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_507c66eb","line":295,"in_reply_to":"7a2fa921_27842e5c","updated":"2015-10-09 13:01:04.000000000","message":"++\nseems no developer impact","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Developer impact"},{"line_number":293,"context_line":"----------------"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"Horizon can add the description to the GUI."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_4e1c49c1","line":295,"in_reply_to":"7a2fa921_27842e5c","updated":"2015-10-14 18:18:08.000000000","message":"ok, moving it","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":292,"context_line":"Developer impact"},{"line_number":293,"context_line":"----------------"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"Horizon can add the description to the GUI."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_ee7995fd","line":295,"in_reply_to":"7a2fa921_507c66eb","updated":"2015-10-14 18:18:08.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"1) Implement the nova API changes."},{"line_number":314,"context_line":"2) Implement the novaclient and openstackclient changes."},{"line_number":315,"context_line":"3) Implement the nova and openstack CLI changes."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_077fb266","line":315,"updated":"2015-10-08 20:58:56.000000000","message":"This is redundant with #2.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"1) Implement the nova API changes."},{"line_number":314,"context_line":"2) Implement the novaclient and openstackclient changes."},{"line_number":315,"context_line":"3) Implement the nova and openstack CLI changes."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_6e6ee530","line":315,"in_reply_to":"7a2fa921_077fb266","updated":"2015-10-14 18:18:08.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9733e557e61a200096a13e5c962f40f8772b5426","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"1) Implement the nova API changes."},{"line_number":314,"context_line":"2) Implement the novaclient and openstackclient changes."},{"line_number":315,"context_line":"3) Implement the nova and openstack CLI changes."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_30d3ead6","line":315,"in_reply_to":"7a2fa921_077fb266","updated":"2015-10-09 13:01:04.000000000","message":"maybe openstackclient and novaclient?","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"1) Implement the nova API changes."},{"line_number":314,"context_line":"2) Implement the novaclient and openstackclient changes."},{"line_number":315,"context_line":"3) Implement the nova and openstack CLI changes."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_2e78edf1","line":315,"in_reply_to":"7a2fa921_30d3ead6","updated":"2015-10-14 18:18:08.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    * Check that the description is unchanged if not specified on the API."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"  * Check that the description is returned as part of server details."},{"line_number":338,"context_line":"  * Check that the server list can be filtered by a description regex."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"* Tempest compute API tests"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_47f04afe","line":338,"updated":"2015-10-08 20:58:56.000000000","message":"Remove.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    * Check that the description is unchanged if not specified on the API."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"  * Check that the description is returned as part of server details."},{"line_number":338,"context_line":"  * Check that the server list can be filtered by a description regex."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"* Tempest compute API tests"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_8e502160","line":338,"in_reply_to":"7a2fa921_47f04afe","updated":"2015-10-14 18:18:08.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"* Tempest compute API tests"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"  * Same test cases as above, except under tempest."},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"* Python nova-client and openstack-client.  For the client tests and"},{"line_number":345,"context_line":"  the CLI tests:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_e7c71696","line":342,"updated":"2015-10-08 20:58:56.000000000","message":"Honestly I\u0027m not sure if we even need Tempest coverage for this, it\u0027s completely isolated within nova-api so it\u0027d be redundant to be in Tempest. We could ask mtreinish and/or sdague.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"* Tempest compute API tests"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"  * Same test cases as above, except under tempest."},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"* Python nova-client and openstack-client.  For the client tests and"},{"line_number":345,"context_line":"  the CLI tests:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_ae44fd73","line":342,"in_reply_to":"7a2fa921_e7c71696","updated":"2015-10-14 18:18:08.000000000","message":"ok, removed","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"  * Add a description to the tests that create a server."},{"line_number":348,"context_line":"  * Check that the description is returned as part of server details."},{"line_number":349,"context_line":"  * Check that the server list can be filtered by a description regex."},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"* Error cases:"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_a7c6fe97","line":349,"updated":"2015-10-08 20:58:56.000000000","message":"remove filtering","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"  * Add a description to the tests that create a server."},{"line_number":348,"context_line":"  * Check that the description is returned as part of server details."},{"line_number":349,"context_line":"  * Check that the server list can be filtered by a description regex."},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"* Error cases:"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_ceeb7977","line":349,"in_reply_to":"7a2fa921_a7c6fe97","updated":"2015-10-14 18:18:08.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":365,"context_line":"* API spec: http://developer.openstack.org/api-ref-compute-v2.html"},{"line_number":366,"context_line":"  including the API samples."},{"line_number":367,"context_line":"* Client: novaclient and openstackclient"},{"line_number":368,"context_line":"* CLI: nova and openstack man pages"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"References"},{"line_number":371,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_c74a1a26","line":368,"updated":"2015-10-08 20:58:56.000000000","message":"redundant with 2nd bullet","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":365,"context_line":"* API spec: http://developer.openstack.org/api-ref-compute-v2.html"},{"line_number":366,"context_line":"  including the API samples."},{"line_number":367,"context_line":"* Client: novaclient and openstackclient"},{"line_number":368,"context_line":"* CLI: nova and openstack man pages"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"References"},{"line_number":371,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_6e8a65c1","line":368,"in_reply_to":"7a2fa921_c74a1a26","updated":"2015-10-14 18:18:08.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d299a7c6a5880340f3237d6dbc973433fd85811","unresolved":false,"context_lines":[{"line_number":377,"context_line":"History"},{"line_number":378,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"Optional section for Mitaka intended to be used each time the spec"},{"line_number":381,"context_line":"is updated to describe new design, API or any database schema"},{"line_number":382,"context_line":"updated. Useful to let reader understand what\u0027s happened along the"},{"line_number":383,"context_line":"time."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a2fa921_4765aab2","line":380,"updated":"2015-10-08 20:58:56.000000000","message":"You can remove this blurb from the template.","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"4b9a7840fb178280ac8697fb7982f0a0774d6904","unresolved":false,"context_lines":[{"line_number":377,"context_line":"History"},{"line_number":378,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"Optional section for Mitaka intended to be used each time the spec"},{"line_number":381,"context_line":"is updated to describe new design, API or any database schema"},{"line_number":382,"context_line":"updated. Useful to let reader understand what\u0027s happened along the"},{"line_number":383,"context_line":"time."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_2e822d95","line":380,"in_reply_to":"7a2fa921_4765aab2","updated":"2015-10-14 18:18:08.000000000","message":"Done","commit_id":"d36c23e44d9aa9fa277c32464044a3a905c7d128"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"9f71023db55065728eff68f3dcd9c6f0ea082256","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Users cannot set the description on the server or retrieve the description."},{"line_number":25,"context_line":"Currently, they need to use other fields, such as the server name or meta-data,"},{"line_number":26,"context_line":"to provide a description. These are overloading the name and meta-data"},{"line_number":27,"context_line":"fields in an unnatural way."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a29b11f_c99af061","line":27,"updated":"2015-10-23 10:37:15.000000000","message":"The server description is metadata, why is it being stored with metadata unnatural? Also \"unnatural\" isn\u0027t a scientific objection, what does that even mean?\n\nA better reason might be if it\u0027d be useful to see the description in the list view for fast server identification by humans.","commit_id":"aca7722a42ce94d412685d8ec84c80b2f8607d9a"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"69a9d42205c25525f6fb218fc48097a35c9265f2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Users cannot set the description on the server or retrieve the description."},{"line_number":25,"context_line":"Currently, they need to use other fields, such as the server name or meta-data,"},{"line_number":26,"context_line":"to provide a description. These are overloading the name and meta-data"},{"line_number":27,"context_line":"fields in an unnatural way."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a29b11f_03643847","line":27,"in_reply_to":"3a29b11f_c99af061","updated":"2015-10-23 15:46:51.000000000","message":"I will clear this up.","commit_id":"aca7722a42ce94d412685d8ec84c80b2f8607d9a"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"9f71023db55065728eff68f3dcd9c6f0ea082256","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    * An empty description string is allowed."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  * The Get Server Details API returns the description in the JSON response."},{"line_number":52,"context_line":"    This can be NULL."},{"line_number":53,"context_line":"  * The List Details for Servers API returns the description for each server."},{"line_number":54,"context_line":"    A description can be NULL."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a29b11f_69295ce5","line":52,"updated":"2015-10-23 10:37:15.000000000","message":"maybe it should simply be omitted if NULL?","commit_id":"aca7722a42ce94d412685d8ec84c80b2f8607d9a"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"69a9d42205c25525f6fb218fc48097a35c9265f2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    * An empty description string is allowed."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  * The Get Server Details API returns the description in the JSON response."},{"line_number":52,"context_line":"    This can be NULL."},{"line_number":53,"context_line":"  * The List Details for Servers API returns the description for each server."},{"line_number":54,"context_line":"    A description can be NULL."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a29b11f_c33e40da","line":52,"in_reply_to":"3a29b11f_69295ce5","updated":"2015-10-23 15:46:51.000000000","message":"I had it this way originally, but Matt had this comment:\n\n\t\nMatt Riedemann\t\tOct 8 3:58 PM\n\nWe should return it regardless, it\u0027s just show up as null in the json response.\n\nI\u0027m not sure which is the proper json, but I think returning null indicates that we didn\u0027t \"forget\" to return it.  I\u0027ll return null if thats ok.","commit_id":"aca7722a42ce94d412685d8ec84c80b2f8607d9a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1241add3521a97dbb63ca92d02d3537056028766","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  * Add an optional description parameter to the Create Server and Update"},{"line_number":44,"context_line":"    Server APIs."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    * No default description for new servers (set to NULL in the database)."},{"line_number":47,"context_line":"    * If a null description string is specified on the server update, then"},{"line_number":48,"context_line":"      the description is set to NULL in the database (description is removed)"},{"line_number":49,"context_line":"    * If the description parameter is not specified on the server update,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_f5a107f9","line":46,"updated":"2015-11-02 21:10:08.000000000","message":"We could continue to default to the display name, but if we\u0027re going to be showing this in responses now I\u0027d agree that NULL is better as the default. Any existing servers are going to have the display name as the description in the database though and those will be shown in the response. Not a big deal IMO, just something to be aware of.","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8ce28d14b33c4ecb53fa6af79bbfe0812308a233","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  * Add an optional description parameter to the Create Server and Update"},{"line_number":44,"context_line":"    Server APIs."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    * No default description for new servers (set to NULL in the database)."},{"line_number":47,"context_line":"    * If a null description string is specified on the server update, then"},{"line_number":48,"context_line":"      the description is set to NULL in the database (description is removed)"},{"line_number":49,"context_line":"    * If the description parameter is not specified on the server update,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_881695a5","line":46,"in_reply_to":"1a26ad4f_f5a107f9","updated":"2015-11-10 17:31:46.000000000","message":"thanks","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1241add3521a97dbb63ca92d02d3537056028766","unresolved":false,"context_lines":[{"line_number":58,"context_line":"* Nova V2 client"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  * Add an optional description parameter to the server create method."},{"line_number":61,"context_line":"  * Add new methods for server set_description and clear_description."},{"line_number":62,"context_line":"    These will implement new CLI sub-commands."},{"line_number":63,"context_line":"  * Return the description on server show method. This can be null."},{"line_number":64,"context_line":"  * If detail is requested, return the description on each server"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_d55f2be3","line":61,"updated":"2015-11-02 21:10:08.000000000","message":"So I guess today we have \u0027nova rename\u0027 to rename an instance:\n\nhttp://docs.openstack.org/cli-reference/content/novaclient_commands.html#novaclient_subcommand_rename\n\nWe\u0027d be adding something like \u0027nova set-description\u0027 and \u0027nova clear-description\u0027?  I\u0027d prefer to just have something simple like \u0027nova describe\u0027 where you can change the description or pass the empty string to clear it out.","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8ce28d14b33c4ecb53fa6af79bbfe0812308a233","unresolved":false,"context_lines":[{"line_number":58,"context_line":"* Nova V2 client"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  * Add an optional description parameter to the server create method."},{"line_number":61,"context_line":"  * Add new methods for server set_description and clear_description."},{"line_number":62,"context_line":"    These will implement new CLI sub-commands."},{"line_number":63,"context_line":"  * Return the description on server show method. This can be null."},{"line_number":64,"context_line":"  * If detail is requested, return the description on each server"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_887d35e9","line":61,"in_reply_to":"1a26ad4f_d55f2be3","updated":"2015-11-10 17:31:46.000000000","message":"Ok, I\u0027ll change this.","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"03936adc29bb595dde574b5c218e629c775397a7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  * If detail is requested, return the description on each server"},{"line_number":65,"context_line":"    returned by the server list method.   A description can be null."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Openstack V2 compute client"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * NOTE:  Changes to the Openstack V2 compute client will be"},{"line_number":70,"context_line":"    implemented under a bug report, and not under this spec."}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba8a016a_b0e7adab","line":67,"updated":"2015-11-16 13:05:22.000000000","message":"I think we can say v2.1 since this is the one you will change","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"0e447a39fd0a85098476f5f44e3643b064572819","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  * If detail is requested, return the description on each server"},{"line_number":65,"context_line":"    returned by the server list method.   A description can be null."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Openstack V2 compute client"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * NOTE:  Changes to the Openstack V2 compute client will be"},{"line_number":70,"context_line":"    implemented under a bug report, and not under this spec."}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba8a016a_82a4e307","line":67,"in_reply_to":"ba8a016a_b0e7adab","updated":"2015-11-19 13:47:54.000000000","message":"Done","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1241add3521a97dbb63ca92d02d3537056028766","unresolved":false,"context_lines":[{"line_number":239,"context_line":"Notifications impact"},{"line_number":240,"context_line":"--------------------"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* Change to existing notification on instance update if description changes."},{"line_number":243,"context_line":"* Change to existing notification on instance create to add description."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_5560fb00","line":242,"updated":"2015-11-02 21:10:08.000000000","message":"There is no notification sent for updating the name of a server:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L766\n\nSo I\u0027d omit anything here about sending notifications about description updates.","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8ce28d14b33c4ecb53fa6af79bbfe0812308a233","unresolved":false,"context_lines":[{"line_number":239,"context_line":"Notifications impact"},{"line_number":240,"context_line":"--------------------"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* Change to existing notification on instance update if description changes."},{"line_number":243,"context_line":"* Change to existing notification on instance create to add description."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_814c2b71","line":242,"in_reply_to":"1a26ad4f_5560fb00","updated":"2015-11-10 17:31:46.000000000","message":"I believe a notification is sent when instance.save() is called and a field has changed:\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/instance.py#L678\n\nI could add the description to the payload here:\n\nhttps://github.com/openstack/nova/blob/master/nova/notifications.py#L397\n\nI could always include the description in the payload, just like the name.  \n\nI\u0027m not sure if I should include the old description with the new description, like old name and new name are included:\n\nhttps://github.com/openstack/nova/blob/master/nova/notifications.py#L152","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"0e447a39fd0a85098476f5f44e3643b064572819","unresolved":false,"context_lines":[{"line_number":239,"context_line":"Notifications impact"},{"line_number":240,"context_line":"--------------------"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* Change to existing notification on instance update if description changes."},{"line_number":243,"context_line":"* Change to existing notification on instance create to add description."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba8a016a_35b44f7e","line":242,"in_reply_to":"da85f559_2b2a622d","updated":"2015-11-19 13:47:54.000000000","message":"Thanks... I will update the spec.","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7f7bbfebbdf01af9cb09452f8ce77a9903db24b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"Notifications impact"},{"line_number":240,"context_line":"--------------------"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* Change to existing notification on instance update if description changes."},{"line_number":243,"context_line":"* Change to existing notification on instance create to add description."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_9f5ab64f","line":242,"in_reply_to":"da85f559_814c2b71","updated":"2015-11-13 02:26:04.000000000","message":"Hmm, we should probably ask the new notifications sub-team about this. Adding things to the notifications payload is probably not the end of the world, removing or changing keys is a no-no.\n\nThe problem with this is the microversion stuff from the compute API doesn\u0027t get down the notifications payload, so we can\u0027t pass the description based on that or not, we\u0027d just start doing - which could be a separate change in itself as part of this blueprint.\n\nAnyway, I think the notifications sub-team has a weekly meeting, we should bring this up there (the meeting time is in the openstack-dev mailing list).","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a0e43316aa2986e4b91f9c5bf02f9a17e8aa7773","unresolved":false,"context_lines":[{"line_number":239,"context_line":"Notifications impact"},{"line_number":240,"context_line":"--------------------"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* Change to existing notification on instance update if description changes."},{"line_number":243,"context_line":"* Change to existing notification on instance create to add description."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_bf6459e5","line":242,"in_reply_to":"da85f559_9f5ab64f","updated":"2015-11-13 02:30:17.000000000","message":"For this spec what I\u0027d probably say is we need to add a TODO to add display_description to the notification payload, but it has to be on a versioned notification update, which is dependent on blueprint versioned-notification-api (need to read the spec for that).  So the instance.save() will send a notification but w/o display_description in the payload nothing changes.","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"843637e3a7a9fc463ad7f3def26dc2dab376f4f9","unresolved":false,"context_lines":[{"line_number":239,"context_line":"Notifications impact"},{"line_number":240,"context_line":"--------------------"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* Change to existing notification on instance update if description changes."},{"line_number":243,"context_line":"* Change to existing notification on instance create to add description."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_2b2a622d","line":242,"in_reply_to":"da85f559_bf6459e5","updated":"2015-11-13 08:32:24.000000000","message":"I agree with Matt\u0027s proposal. During the versioned notification API work we will create a new versioned notification for the instance.update. The new versioned notification will contain the whole instance object so the description will be included as well. I guess putting a TODO in the code make sense not to forget having a specific test for it as soon as we add the new notification.","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1241add3521a97dbb63ca92d02d3537056028766","unresolved":false,"context_lines":[{"line_number":240,"context_line":"--------------------"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* Change to existing notification on instance update if description changes."},{"line_number":243,"context_line":"* Change to existing notification on instance create to add description."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Other end user impact"},{"line_number":246,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_5954b5fd","line":243,"updated":"2015-11-02 21:10:08.000000000","message":"Nova currently doesn\u0027t have versioned notifications, so adding instance.display_description to the notification payload would be an unversioned API change:\n\nhttps://github.com/openstack/nova/blob/master/nova/notifications.py#L397\n\nHowever, it\u0027s technically backward compatible since it\u0027s adding a key/value to the notification payload, not changing a key or removing something, so it should be OK to add that.","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8ce28d14b33c4ecb53fa6af79bbfe0812308a233","unresolved":false,"context_lines":[{"line_number":240,"context_line":"--------------------"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* Change to existing notification on instance update if description changes."},{"line_number":243,"context_line":"* Change to existing notification on instance create to add description."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Other end user impact"},{"line_number":246,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_419c03c0","line":243,"in_reply_to":"1a26ad4f_5954b5fd","updated":"2015-11-10 17:31:46.000000000","message":"ok","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1241add3521a97dbb63ca92d02d3537056028766","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    * Check that the description can be changed or removed."},{"line_number":303,"context_line":"    * Check that the description is unchanged if not specified on the API."},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  * Check that the description is returned as part of server details for"},{"line_number":306,"context_line":"    for an individual server or a server list."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"* Python nova-client and openstack-client.  For the client tests and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_b9b14949","line":305,"updated":"2015-11-02 21:10:08.000000000","message":"s/for for/for/","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8ce28d14b33c4ecb53fa6af79bbfe0812308a233","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    * Check that the description can be changed or removed."},{"line_number":303,"context_line":"    * Check that the description is unchanged if not specified on the API."},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  * Check that the description is returned as part of server details for"},{"line_number":306,"context_line":"    for an individual server or a server list."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"* Python nova-client and openstack-client.  For the client tests and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_e1abb7d4","line":305,"in_reply_to":"1a26ad4f_b9b14949","updated":"2015-11-10 17:31:46.000000000","message":"Done","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1241add3521a97dbb63ca92d02d3537056028766","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Documentation updates to:"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"* API spec: http://developer.openstack.org/api-ref-compute-v2.html"},{"line_number":331,"context_line":"  including the API samples."},{"line_number":332,"context_line":"* Client: novaclient and openstackclient"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_59f035fe","line":330,"updated":"2015-11-02 21:10:08.000000000","message":"This is the v2 API which we aren\u0027t changing, you\u0027re looking for:\n\nhttp://developer.openstack.org/api-ref-compute-v2.1.html","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"8ce28d14b33c4ecb53fa6af79bbfe0812308a233","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Documentation updates to:"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"* API spec: http://developer.openstack.org/api-ref-compute-v2.html"},{"line_number":331,"context_line":"  including the API samples."},{"line_number":332,"context_line":"* Client: novaclient and openstackclient"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_61d4a746","line":330,"in_reply_to":"1a26ad4f_59f035fe","updated":"2015-11-10 17:31:46.000000000","message":"Done","commit_id":"7c4ff989d4bada116f47cbbfb79f795e39b2dde3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f94a9d146433506253db92c7cec5bee25458c89e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"REST API impact"},{"line_number":104,"context_line":"---------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Add the following parameter validation:"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"::"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba8a016a_b920b84a","line":106,"updated":"2015-11-23 12:12:14.000000000","message":"Nit: I like when this says, \"In a new micro-version, adding the following\".","commit_id":"9d57b3642386ba6e9df8643806e3b2d32b4ba058"}]}