)]}'
{"specs/mitaka/approved/service-version-behavior.rst":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"bce9011a647d19449de5c96a5e2f8741ae81f314","unresolved":false,"context_lines":[{"line_number":75,"context_line":"to other code by doing the lookup in the compute_rpcapi module once at"},{"line_number":76,"context_line":"startup, and again on signals like SIGHUP. This will only be done if"},{"line_number":77,"context_line":"the version pin is set to \"auto\", requiring operators to opt-in to"},{"line_number":78,"context_line":"this new behavior while it is smoke tested."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"The second change thing we will automate is checking of the minimum"},{"line_number":81,"context_line":"service version during service record create/update. This will prevent"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_b574f267","line":78,"updated":"2015-09-29 19:09:06.000000000","message":"I would expect some logging on startup or version change to indicate which version was selected.  Perhaps an implementation detail, but a concern that might be nice to note here.","commit_id":"b9200ba8a8c84bc5af63522c3e902ce65b503f8b"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"bce9011a647d19449de5c96a5e2f8741ae81f314","unresolved":false,"context_lines":[{"line_number":82,"context_line":"ancient services from joining the deployment if they are too old. This"},{"line_number":83,"context_line":"will be done in the Service object, and it will compare its own"},{"line_number":84,"context_line":"version to the minimum version of other services in the database. If"},{"line_number":85,"context_line":"it is older than all the other nodes, then it will refuse to start."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Alternatives"},{"line_number":88,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_3501c205","line":85,"updated":"2015-09-29 19:09:06.000000000","message":"It should be noisy about refusing to start.  That\u0027s an implementation detail that can be worked out in the code review, but may be worth calling out here.","commit_id":"b9200ba8a8c84bc5af63522c3e902ce65b503f8b"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"bce9011a647d19449de5c96a5e2f8741ae81f314","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Notifications impact"},{"line_number":113,"context_line":"--------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"None"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Other end user impact"},{"line_number":118,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_55a236fe","line":115,"updated":"2015-09-29 19:09:06.000000000","message":"I think notifications would on service and RPC versions would be useful to operators.  However that is better handled in https://review.openstack.org/#/c/182350/.","commit_id":"b9200ba8a8c84bc5af63522c3e902ce65b503f8b"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"bce9011a647d19449de5c96a5e2f8741ae81f314","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Checking the minimum version in the database on compute_rpcapi module"},{"line_number":126,"context_line":"startup will incur a small performance penalty and additional database"},{"line_number":127,"context_line":"load. This will only happen once per startup (or signal) and is"},{"line_number":128,"context_line":"expected to be massively less impactful than the effort requried to"},{"line_number":129,"context_line":"manually perform the steps being automated."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"It would also be trivial for conductor to cache the minimum versions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_d5ae46e5","line":128,"updated":"2015-09-29 19:09:06.000000000","message":"s/requried/required/","commit_id":"b9200ba8a8c84bc5af63522c3e902ce65b503f8b"},{"author":{"_account_id":17789,"name":"Zhao Lei","email":"zhaolei@cn.fujitsu.com","username":"zhaolei"},"change_message_id":"761cff0088dcd167be44bce1c15c03ae16a6097c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"version to the minimum version of other services in the database. If"},{"line_number":89,"context_line":"it is older than all the other nodes, then it will refuse to start. If"},{"line_number":90,"context_line":"we refuse to start, we\u0027ll log the versions involved and the reason for"},{"line_number":91,"context_line":"the refusal visibly to make it clear what happend and what needs"},{"line_number":92,"context_line":"fixing."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_92b21793","line":91,"updated":"2015-09-30 02:21:44.000000000","message":"happened","commit_id":"61e66e9509bdb48a9b86ff46289ef95e36fb6885"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bddd644743ca82422f3637cd7a78d27164b82543","unresolved":false,"context_lines":[{"line_number":88,"context_line":"version to the minimum version of other services in the database. If"},{"line_number":89,"context_line":"it is older than all the other nodes, then it will refuse to start. If"},{"line_number":90,"context_line":"we refuse to start, we\u0027ll log the versions involved and the reason for"},{"line_number":91,"context_line":"the refusal visibly to make it clear what happend and what needs"},{"line_number":92,"context_line":"fixing."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_a32eeaf8","line":91,"in_reply_to":"9a1a9d01_92b21793","updated":"2015-09-30 08:28:42.000000000","message":"we can fix that in a follow on patch.","commit_id":"61e66e9509bdb48a9b86ff46289ef95e36fb6885"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bddd644743ca82422f3637cd7a78d27164b82543","unresolved":false,"context_lines":[{"line_number":166,"context_line":"* Add a minimum version query to the Service object"},{"line_number":167,"context_line":"* Automate selection of the compute RPC version when the pin is set to auto"},{"line_number":168,"context_line":"* Automate service failure on startup when the service version is too old"},{"line_number":169,"context_line":"* Hook re-checking of the minimum version to receiving a SIGHUP"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Dependencies"},{"line_number":172,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_638212ca","line":169,"updated":"2015-09-30 08:28:42.000000000","message":"Its tempting to add an API call that triggers the re-load (but it should certainly happen on SIGHUP) and tempting to extend the service list to report the version. But those feel like sugar on top of this important base functionality.","commit_id":"61e66e9509bdb48a9b86ff46289ef95e36fb6885"}]}