)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"eafdbf0a60702195d45abe95d755e7502e67de55","unresolved":false,"context_lines":[{"line_number":10,"context_line":"image metadata properties at instance creation time. This avoids the"},{"line_number":11,"context_line":"need to upload the same image to glance multiple times in order to"},{"line_number":12,"context_line":"set slightly different properties for special use cases."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I47e3df44cd868b965ef2b6cffad509b2895cb02a"},{"line_number":15,"context_line":"Blueprint: virt-image-props-boot-override"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_38d71325","line":13,"updated":"2015-10-12 13:06:33.000000000","message":"we need APIImpact tag","commit_id":"1a5183d17a3d377299c5a0ba86547062702929c1"}],"specs/mitaka/approved/virt-image-props-boot-override.rst":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"eafdbf0a60702195d45abe95d755e7502e67de55","unresolved":false,"context_lines":[{"line_number":54,"context_line":"created."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Project Priority"},{"line_number":57,"context_line":"-----------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"None"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a2fa921_f8299b38","line":57,"updated":"2015-10-12 13:06:33.000000000","message":"this can be removed","commit_id":"1a5183d17a3d377299c5a0ba86547062702929c1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"eafdbf0a60702195d45abe95d755e7502e67de55","unresolved":false,"context_lines":[{"line_number":130,"context_line":"The \u0027create\u0027 method on the nova servers resource that is used to boot"},{"line_number":131,"context_line":"new instances will gain a new parameter \"image_props\". This will be a"},{"line_number":132,"context_line":"simple dict of key/value strings. The accepted keys will be any of those"},{"line_number":133,"context_line":"permitted by the nova.objects.ImageMetaProps object."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Security impact"},{"line_number":136,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a2fa921_58020fb6","line":133,"updated":"2015-10-12 13:06:33.000000000","message":"will this be a API change which need microversion according to http://docs.openstack.org/developer/nova/api_microversion_dev.html ?","commit_id":"1a5183d17a3d377299c5a0ba86547062702929c1"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"187e907f8296735e9cf210f445e91a106724b146","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Nova has the ability to use various metadata properties recordered against"},{"line_number":22,"context_line":"images in glance, to tailor the way an instance is configured at boot time."},{"line_number":23,"context_line":"For example, it might customize the type of hardware devices exposed, or"},{"line_number":24,"context_line":"set a specific NUMA topology, or specify kernel command line arguments."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_0201f204","line":21,"range":{"start_line":21,"start_character":56,"end_line":21,"end_character":66},"updated":"2015-10-21 15:31:34.000000000","message":"nit: recorded","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3b426a6015d8f653d913565efc00a03f04d0f6dc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  nova boot \\"},{"line_number":77,"context_line":"      --image IMAGE-ID \\"},{"line_number":78,"context_line":"      --image-prop \"hw_os_command_line\u003dconsole\u003dttyS0\" \\"},{"line_number":79,"context_line":"      --image-prop \"hw_numa_nodes\u003d2\" \\"},{"line_number":80,"context_line":"      --flavour m1.small \\"},{"line_number":81,"context_line":"      ...other args..."},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da85f559_7f99a81e","line":79,"updated":"2015-11-10 16:17:05.000000000","message":"not to bikeshed, but I would prefer something more explicit like image-property-override or something like that?","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3b426a6015d8f653d913565efc00a03f04d0f6dc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"would be deciding just which properties to allow override of at boot time."},{"line_number":92,"context_line":"This would likely result in a never ending stream of requests from users to"},{"line_number":93,"context_line":"add support for \"just one more\" property. Thus it is is considered simpler"},{"line_number":94,"context_line":"to just allow override of any property defined by the ImageMetaProps object."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Instead of doing image metadata property overide, special case the specific"},{"line_number":97,"context_line":"features that are needed. For example, the boot API could gain a new \"kernel"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da85f559_b219877b","line":94,"updated":"2015-11-10 16:17:05.000000000","message":"You hit on an important issue here I feel, glance has a concept of protected properties, that this appears to violate:\nhttp://docs.openstack.org/developer/glance/property-protections.html","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f8995c6943bc5f0e649f9b38e068afb9bbd194cc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"would be deciding just which properties to allow override of at boot time."},{"line_number":92,"context_line":"This would likely result in a never ending stream of requests from users to"},{"line_number":93,"context_line":"add support for \"just one more\" property. Thus it is is considered simpler"},{"line_number":94,"context_line":"to just allow override of any property defined by the ImageMetaProps object."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Instead of doing image metadata property overide, special case the specific"},{"line_number":97,"context_line":"features that are needed. For example, the boot API could gain a new \"kernel"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da85f559_f2086f2f","line":94,"in_reply_to":"da85f559_b219877b","updated":"2015-11-10 16:28:51.000000000","message":"Sigh, having glance decide what properties can/cant be used to configure virtual machines feels rather flawed to me. Really you\u0027d want Nova to decide what properties can/canot be used with Nova, not least because in a heterogenoous hypervisor deployment nova may wish to allow properties to be used with one hypervisor but not another and glance doesn\u0027t have context to support that kind of restriction.\n\nSince fixing that mess feel out of scope, it seems like the simplest option is to just add a nova.conf entry that lets the admin whitelist or blacklist ImageMetaProps fields from being used at boot time.","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"187e907f8296735e9cf210f445e91a106724b146","unresolved":false,"context_lines":[{"line_number":109,"context_line":"approach for users though, particularly when every single instance wants a"},{"line_number":110,"context_line":"slightly different override, as would be the case when using Nova to run distro"},{"line_number":111,"context_line":"OS installers automatically."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Data model impact"},{"line_number":115,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_1da8738c","line":112,"updated":"2015-10-21 15:31:34.000000000","message":"another alternative - implement soft-clone with reference counting in Glance, so you can cheaply and easily have one blob look like multiple images with different metadata. My Glance insider says this may be possible in V3? Although that\u0027s still experimental.","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3b426a6015d8f653d913565efc00a03f04d0f6dc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"approach for users though, particularly when every single instance wants a"},{"line_number":110,"context_line":"slightly different override, as would be the case when using Nova to run distro"},{"line_number":111,"context_line":"OS installers automatically."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Data model impact"},{"line_number":115,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da85f559_d269abbf","line":112,"in_reply_to":"3a29b11f_1da8738c","updated":"2015-11-10 16:17:05.000000000","message":"honestly, we basically create a soft clone of the image properties on boot, we store them in system_metatadata. They can change after that point, and we ignore the changes.","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"187e907f8296735e9cf210f445e91a106724b146","unresolved":false,"context_lines":[{"line_number":128,"context_line":"simple dict of key/value strings. The accepted keys will be any of those"},{"line_number":129,"context_line":"permitted by the nova.objects.ImageMetaProps object."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"This will new a new API microversion"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Security impact"},{"line_number":134,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_afd346d4","line":131,"range":{"start_line":131,"start_character":10,"end_line":131,"end_character":13},"updated":"2015-10-21 15:31:34.000000000","message":"nit: s/new/need/, s/$/./","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3b426a6015d8f653d913565efc00a03f04d0f6dc","unresolved":false,"context_lines":[{"line_number":129,"context_line":"permitted by the nova.objects.ImageMetaProps object."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"This will new a new API microversion"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Security impact"},{"line_number":134,"context_line":"---------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da85f559_bff8704a","line":132,"updated":"2015-11-10 16:17:05.000000000","message":"Please see the template on the level of detail required here.\n\nWe need a json schema for the new property you are adding here.","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"62f3e0d57bf0991219c3665196342dba91fcade4","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Security impact"},{"line_number":134,"context_line":"---------------"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"None"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Notifications impact"},{"line_number":139,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_5e1d22bc","line":136,"updated":"2015-10-18 02:21:36.000000000","message":"Currently I believe an administrator can use policy to prevent users uploading images and/or editing image properties. For many being able to override the image properties without changing those on the original image will no doubt be seen as an enhancement, but does there need to be a way to restrict this ability for those clouds that don\u0027t necessarily want people to be able to change them per instance?","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"187e907f8296735e9cf210f445e91a106724b146","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Security impact"},{"line_number":134,"context_line":"---------------"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"None"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Notifications impact"},{"line_number":139,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_6fda0eea","line":136,"in_reply_to":"3a29b11f_5e1d22bc","updated":"2015-10-21 15:31:34.000000000","message":"+1","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3b426a6015d8f653d913565efc00a03f04d0f6dc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Security impact"},{"line_number":134,"context_line":"---------------"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"None"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Notifications impact"},{"line_number":139,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da85f559_52837b56","line":136,"in_reply_to":"3a29b11f_6fda0eea","updated":"2015-11-10 16:17:05.000000000","message":"I think we need to honor glance\u0027s protected properties somehow.","commit_id":"185e3f1a9886e20d79e9a4a38e6a2507b1bed337"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"ec1e06a6241b5e371a3b405fe171ebc1375baefc","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  nova boot \\"},{"line_number":78,"context_line":"      --image IMAGE-ID \\"},{"line_number":79,"context_line":"      --image-prop-override \"hw_os_command_line\u003dconsole\u003dttyS0\" \\"},{"line_number":80,"context_line":"      --image-prop-override \"hw_numa_nodes\u003d2\" \\"},{"line_number":81,"context_line":"      --flavour m1.small \\"},{"line_number":82,"context_line":"      ...other args..."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_82730615","line":80,"updated":"2015-11-17 12:00:26.000000000","message":"Can we store these new values to override current image prop metadata into somewhere such as flavor extra-spec? \n\nhttps://review.openstack.org/#/c/246154/1\n\nIn my use case, we\u0027d like to provide a feature that user can override hypervisor_type when they want to boot a glance image at another hypervisor type. But user doesn\u0027t know which hypervisor type they can deploy the glance image. I think we should provide choices for user to avoid confusion in any way.\n\nSo, I think it is better to support both overriding through command line and overriding through flavor extra-spec(this is just example).\n\nPlease let me know your opinion.","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"941e850f9bffba27730c94cd9cb3a25a5323d485","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  nova boot \\"},{"line_number":78,"context_line":"      --image IMAGE-ID \\"},{"line_number":79,"context_line":"      --image-prop-override \"hw_os_command_line\u003dconsole\u003dttyS0\" \\"},{"line_number":80,"context_line":"      --image-prop-override \"hw_numa_nodes\u003d2\" \\"},{"line_number":81,"context_line":"      --flavour m1.small \\"},{"line_number":82,"context_line":"      ...other args..."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_fdeb9376","line":80,"in_reply_to":"ba8a016a_5df2dfd3","updated":"2015-11-17 12:16:56.000000000","message":"I understand the scope of this proposal. Thank you.","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0f92874637217df055ef683e31c4d3cb2a1a7ca2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  nova boot \\"},{"line_number":78,"context_line":"      --image IMAGE-ID \\"},{"line_number":79,"context_line":"      --image-prop-override \"hw_os_command_line\u003dconsole\u003dttyS0\" \\"},{"line_number":80,"context_line":"      --image-prop-override \"hw_numa_nodes\u003d2\" \\"},{"line_number":81,"context_line":"      --flavour m1.small \\"},{"line_number":82,"context_line":"      ...other args..."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_5df2dfd3","line":80,"in_reply_to":"ba8a016a_82730615","updated":"2015-11-17 12:07:38.000000000","message":"The image metadata for a VM is already stored in the instance.system_metadata database field. These overrides will get stored in that same place.\n\nThis spec isn\u0027t considering the issue of overriding via the flavour, only the boot time override. If override via flavour is desired, that can be proposed as a separate spec.","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"07236128e08ca7155ea3f9f7bc1d2806f17dc4bc","unresolved":false,"context_lines":[{"line_number":135,"context_line":"The POST method on the \u0027/servers\u0027 location will be extended to gain a"},{"line_number":136,"context_line":"new \u0027image_props_override\u0027 parameter. This will be a simple dict of"},{"line_number":137,"context_line":"key/value strings. The accepted keys will be any of those permitted"},{"line_number":138,"context_line":"by the nova.objects.ImageMetaProps object."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Taking the \u0027nova boot\u0027 example earlier, the JSON passed in the request"},{"line_number":141,"context_line":"would look like this:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_a458da8b","line":138,"updated":"2015-11-20 11:43:11.000000000","message":"Ok, just an implementation note, we\u0027ll need to convert that into json schema as part of this for the enforcement.","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"07236128e08ca7155ea3f9f7bc1d2806f17dc4bc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"          \u0027metadata\u0027 : {"},{"line_number":153,"context_line":"            \u0027My Server Name\u0027 : \u0027Apache1\u0027"},{"line_number":154,"context_line":"          },"},{"line_number":155,"context_line":"          \u0027image_props_override\u0027 : {"},{"line_number":156,"context_line":"            \u0027hw_os_command_line\u0027 : \u0027console\u003dttyS0\u0027,"},{"line_number":157,"context_line":"            \u0027hw_numa_nodes\u0027 : \u00272\u0027,"},{"line_number":158,"context_line":"          }"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_a4977a39","line":155,"updated":"2015-11-20 11:43:11.000000000","message":"super nit, but this is an HTTP POST document, so lets just make this image_property_override","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ac2cdce48fc7582ad710f8011d173669c9300093","unresolved":false,"context_lines":[{"line_number":152,"context_line":"          \u0027metadata\u0027 : {"},{"line_number":153,"context_line":"            \u0027My Server Name\u0027 : \u0027Apache1\u0027"},{"line_number":154,"context_line":"          },"},{"line_number":155,"context_line":"          \u0027image_props_override\u0027 : {"},{"line_number":156,"context_line":"            \u0027hw_os_command_line\u0027 : \u0027console\u003dttyS0\u0027,"},{"line_number":157,"context_line":"            \u0027hw_numa_nodes\u0027 : \u00272\u0027,"},{"line_number":158,"context_line":"          }"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_60c3fb89","line":155,"in_reply_to":"ba8a016a_a4977a39","updated":"2015-11-27 15:47:55.000000000","message":"+1 I made that comment on patch set 2 also.","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"07236128e08ca7155ea3f9f7bc1d2806f17dc4bc","unresolved":false,"context_lines":[{"line_number":169,"context_line":"overrides are completely done in Nova, this is invisible to glance\u0027s access"},{"line_number":170,"context_line":"control rules. To deal with this there will be a nova.conf property provided"},{"line_number":171,"context_line":"that whitelists/blacklists what properties can be overridden at instance"},{"line_number":172,"context_line":"boot time."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Notifications impact"},{"line_number":175,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_e477c206","line":172,"updated":"2015-11-20 11:43:11.000000000","message":"I kind of wonder if we should actually do this enforcement by building the json schema for this bit a little bit dynamically and apply the base + security guards together.","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ac2cdce48fc7582ad710f8011d173669c9300093","unresolved":false,"context_lines":[{"line_number":169,"context_line":"overrides are completely done in Nova, this is invisible to glance\u0027s access"},{"line_number":170,"context_line":"control rules. To deal with this there will be a nova.conf property provided"},{"line_number":171,"context_line":"that whitelists/blacklists what properties can be overridden at instance"},{"line_number":172,"context_line":"boot time."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Notifications impact"},{"line_number":175,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_8025bf5c","line":172,"in_reply_to":"ba8a016a_e477c206","updated":"2015-11-27 15:47:55.000000000","message":"In theory it should be a policy setting, but I think this is a pragmatic way forward, just a simple yes/no.","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"c1b47622aef059f0a29451a1c23600604d8f65fe","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Notifications impact"},{"line_number":175,"context_line":"--------------------"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"None"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Other end user impact"},{"line_number":180,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_5e7c87eb","line":177,"updated":"2015-11-28 04:35:10.000000000","message":"Its a nit, but I wonder if we should emit a notification here saying this occurred? That would help admins do analysis on how their standard flavors are meeting the needs of users?","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"07236128e08ca7155ea3f9f7bc1d2806f17dc4bc","unresolved":false,"context_lines":[{"line_number":196,"context_line":"updated too."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Developer impact"},{"line_number":199,"context_line":"----------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"None"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_c4707edf","line":199,"updated":"2015-11-20 11:43:11.000000000","message":"It\u0027s going to be important to explain to folks in the API docs that this field might not be accessible to them.","commit_id":"09f2c640f0b95ae2485c33fc2888d189a7f185e4"}]}