)]}'
{"specs/mitaka/approved/volume-snapshot-improvements.rst":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"765c18bac72dcc0f1b5babef4e32488894ba7f0b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Cinder will translate this to a relevant volume state transition"},{"line_number":91,"context_line":"on its side."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Same as above for deleting, with \u0027delete_compute_complete\u0027."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"This allows Cinder to distinguish whether Nova is currently processing"},{"line_number":96,"context_line":"information or whether Cinder has control of that snapshot again."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_7bca9e1c","line":93,"range":{"start_line":93,"start_character":34,"end_line":93,"end_character":57},"updated":"2015-10-22 15:21:24.000000000","message":"probably too late to change this but... we should say create + delete, or creating + deleting. Creating + delete is asymmetric.","commit_id":"7b157bd67896b6311ed713de01ed7b61cc49e98f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9cda281a521f5fac5ff90db6a224c88bccb926b5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Cinder will translate this to a relevant volume state transition"},{"line_number":91,"context_line":"on its side."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Same as above for deleting, with \u0027delete_compute_complete\u0027."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"This allows Cinder to distinguish whether Nova is currently processing"},{"line_number":96,"context_line":"information or whether Cinder has control of that snapshot again."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_bef21e05","line":93,"range":{"start_line":93,"start_character":34,"end_line":93,"end_character":57},"in_reply_to":"3a29b11f_7bca9e1c","updated":"2015-11-03 15:28:00.000000000","message":"Thats a good spot, it would be annoying.\n\nCan we still change this?","commit_id":"7b157bd67896b6311ed713de01ed7b61cc49e98f"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"3b90252061e0396f81da0afdc7e5b3fef6f5f2cc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Cinder will translate this to a relevant volume state transition"},{"line_number":91,"context_line":"on its side."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Same as above for deleting, with \u0027delete_compute_complete\u0027."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"This allows Cinder to distinguish whether Nova is currently processing"},{"line_number":96,"context_line":"information or whether Cinder has control of that snapshot again."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_13055ec1","line":93,"in_reply_to":"fa80f949_bef21e05","updated":"2015-11-08 11:31:18.000000000","message":"Yes, its already done in the patch. Pls see :\n\nhttps://review.openstack.org/#/c/194538/12/nova/objects/fields.py\nLines 144-147\n\nWill send another patch to fix the nit here.","commit_id":"7b157bd67896b6311ed713de01ed7b61cc49e98f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c08945947f8c3447ab3051c3d9bde4d1c60eac9f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"manipulating snapshot files.  Cinder needs to keep track of the format"},{"line_number":24,"context_line":"of each file (raw, qcow2, vhd, etc.) to maintain security and data"},{"line_number":25,"context_line":"integrity.  Currently it has to guess about the outcome of a snapshot"},{"line_number":26,"context_line":"operation for this information."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Nova currently sends a hard-coded \u002790%\u0027 progress value to indicate a"},{"line_number":29,"context_line":"state transition at the end of a snapshot operation.  This should be"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_847f04df","line":26,"updated":"2015-11-19 16:14:46.000000000","message":"There\u0027s probably a bit of knowledge I\u0027m missing, but on the surface it feels like Cinder shouldn\u0027t need to be told the format of a snapshot.  If we have a cinder volume A with format qcow2, and we take a snapshot of it resulting in volume B, surely Cinder knows that volume B has the same format as volume A, ie qcow2. Why does it need Nova to tell it this ?\n\nCan you clarify this problem description to explain why this (presumably) isn\u0027t the case.","commit_id":"b2084855b776b17ba6bac9d26356387aba537aa9"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"c19d5deb6d3487896bc4635e5d79acb5ec739087","unresolved":false,"context_lines":[{"line_number":23,"context_line":"manipulating snapshot files.  Cinder needs to keep track of the format"},{"line_number":24,"context_line":"of each file (raw, qcow2, vhd, etc.) to maintain security and data"},{"line_number":25,"context_line":"integrity.  Currently it has to guess about the outcome of a snapshot"},{"line_number":26,"context_line":"operation for this information."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Nova currently sends a hard-coded \u002790%\u0027 progress value to indicate a"},{"line_number":29,"context_line":"state transition at the end of a snapshot operation.  This should be"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_d7858b07","line":26,"in_reply_to":"ba8a016a_847f04df","updated":"2015-11-20 12:56:02.000000000","message":"Hi Dan,\n  For hypevisor assisted snapshots, based on blockRebase or blockCommit on the Nova side, the format of the active file may change and thus Cinder needs to be told by Nova of the active file\u0027s format, post the snap create/delete ops.","commit_id":"b2084855b776b17ba6bac9d26356387aba537aa9"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"327ce895be8024e92d3705ca9466c198645e14c6","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"For the libvirt volume driver, this information can be obtained by"},{"line_number":62,"context_line":"querying the instance VM\u0027s disk backing chain information via"},{"line_number":63,"context_line":"the domain.XMLDesc() output."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For snapshot_create, determine the format of the new file, return"},{"line_number":66,"context_line":"this from _volume_snapshot_create() and add a dict such as::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_ef73c2b2","line":63,"updated":"2015-11-16 02:20:56.000000000","message":"I feel like this glosses over some of the details with format tracking.And this will be made more complex with the inclusion of: http://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/runtime-image-type.html","commit_id":"b2084855b776b17ba6bac9d26356387aba537aa9"}]}