)]}'
{"specs/mitaka/approved/use-libvirt-storage-pools.rst":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"e041f57cce7be8b0c7d943b7891996bc53b13d75","unresolved":false,"context_lines":[{"line_number":35,"context_line":"---------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Use of storage pools will enable us to implement migration of"},{"line_number":38,"context_line":"non active instances, see https://review.openstack.org/#/c/126979"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_8880bec0","line":38,"updated":"2015-10-16 10:58:06.000000000","message":"This implementation of non active instances is not the use cases for this specs, or not the only one.\nIn my understanding the main use case is to move the complexity of managing images, disks, and whatever can go in a storage pool, down to the libvirt layer.","commit_id":"35d2954c78a1fcb80b0f4af445e43024b562cd47"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"8d63a88f8127cdabea2ea4bb9921b4c280c92a2b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"---------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Use of storage pools will enable us to implement migration of"},{"line_number":38,"context_line":"non active instances, see https://review.openstack.org/#/c/126979"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a29b11f_6181484a","line":38,"in_reply_to":"5a2ca52d_8880bec0","updated":"2015-10-29 04:02:12.000000000","message":"Done","commit_id":"35d2954c78a1fcb80b0f4af445e43024b562cd47"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"50079f3f617d3bf0e9e1b8b226ea2d68cea577e6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"---------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Use of storage pools will enable us to implement migration of"},{"line_number":38,"context_line":"non active instances, see https://review.openstack.org/#/c/126979"},{"line_number":39,"context_line":"It will also better align the nova libvirt driver implementation with"},{"line_number":40,"context_line":"the features and capabilities of the latest version of the libvirt"},{"line_number":41,"context_line":"library.  This will simplify future enhancements an maintanence of this"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_7658e132","line":38,"updated":"2015-10-20 15:15:28.000000000","message":"nit: full stop and maybe para break","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"a87cf62ac8d9a243a04335d580a5d38db5a8f42c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"---------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Use of storage pools will enable us to implement migration of"},{"line_number":38,"context_line":"non active instances, see https://review.openstack.org/#/c/126979"},{"line_number":39,"context_line":"It will also better align the nova libvirt driver implementation with"},{"line_number":40,"context_line":"the features and capabilities of the latest version of the libvirt"},{"line_number":41,"context_line":"library.  This will simplify future enhancements an maintanence of this"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_a16982c0","line":38,"in_reply_to":"3a29b11f_7658e132","updated":"2015-10-29 04:21:41.000000000","message":"Done","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"50079f3f617d3bf0e9e1b8b226ea2d68cea577e6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Use of storage pools will enable us to implement migration of"},{"line_number":38,"context_line":"non active instances, see https://review.openstack.org/#/c/126979"},{"line_number":39,"context_line":"It will also better align the nova libvirt driver implementation with"},{"line_number":40,"context_line":"the features and capabilities of the latest version of the libvirt"},{"line_number":41,"context_line":"library.  This will simplify future enhancements an maintanence of this"},{"line_number":42,"context_line":"code by allowing it to leverage the volume management features provided"},{"line_number":43,"context_line":"by libvirt."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_76a6a111","line":40,"range":{"start_line":40,"start_character":37,"end_line":40,"end_character":51},"updated":"2015-10-20 15:15:28.000000000","message":"What about the minimum version we require?","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"a87cf62ac8d9a243a04335d580a5d38db5a8f42c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Use of storage pools will enable us to implement migration of"},{"line_number":38,"context_line":"non active instances, see https://review.openstack.org/#/c/126979"},{"line_number":39,"context_line":"It will also better align the nova libvirt driver implementation with"},{"line_number":40,"context_line":"the features and capabilities of the latest version of the libvirt"},{"line_number":41,"context_line":"library.  This will simplify future enhancements an maintanence of this"},{"line_number":42,"context_line":"code by allowing it to leverage the volume management features provided"},{"line_number":43,"context_line":"by libvirt."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_215fb2e6","line":40,"in_reply_to":"3a29b11f_76a6a111","updated":"2015-10-29 04:21:41.000000000","message":"Done","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"50079f3f617d3bf0e9e1b8b226ea2d68cea577e6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"non active instances, see https://review.openstack.org/#/c/126979"},{"line_number":39,"context_line":"It will also better align the nova libvirt driver implementation with"},{"line_number":40,"context_line":"the features and capabilities of the latest version of the libvirt"},{"line_number":41,"context_line":"library.  This will simplify future enhancements an maintanence of this"},{"line_number":42,"context_line":"code by allowing it to leverage the volume management features provided"},{"line_number":43,"context_line":"by libvirt."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_b683d955","line":41,"range":{"start_line":41,"start_character":49,"end_line":41,"end_character":51},"updated":"2015-10-20 15:15:28.000000000","message":"nit: s/ an / and /","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"a87cf62ac8d9a243a04335d580a5d38db5a8f42c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"non active instances, see https://review.openstack.org/#/c/126979"},{"line_number":39,"context_line":"It will also better align the nova libvirt driver implementation with"},{"line_number":40,"context_line":"the features and capabilities of the latest version of the libvirt"},{"line_number":41,"context_line":"library.  This will simplify future enhancements an maintanence of this"},{"line_number":42,"context_line":"code by allowing it to leverage the volume management features provided"},{"line_number":43,"context_line":"by libvirt."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_e158dafc","line":41,"in_reply_to":"3a29b11f_b683d955","updated":"2015-10-29 04:21:41.000000000","message":"Done","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"50079f3f617d3bf0e9e1b8b226ea2d68cea577e6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The cache of images downloaded from Glance would be placed into a volume pool"},{"line_number":49,"context_line":"(:code:`nova-base-images-pool`).  This is done simply by instructing libvirt"},{"line_number":50,"context_line":"that Nova\u0027s image cache directory (e.g. :code:`/var/lib/nova/_base`) is a"},{"line_number":51,"context_line":"volume pool, and as such does not affect directory layout (and is thus"},{"line_number":52,"context_line":"compatible with both the legacy image backends and the new image backend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_b6d19959","line":49,"range":{"start_line":49,"start_character":1,"end_line":49,"end_character":30},"updated":"2015-10-20 15:15:28.000000000","message":"nit: not sure what this :code: stuff is about, do you just want ``monospace``? Generally I think people just use `emphasis`.","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"a87cf62ac8d9a243a04335d580a5d38db5a8f42c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The cache of images downloaded from Glance would be placed into a volume pool"},{"line_number":49,"context_line":"(:code:`nova-base-images-pool`).  This is done simply by instructing libvirt"},{"line_number":50,"context_line":"that Nova\u0027s image cache directory (e.g. :code:`/var/lib/nova/_base`) is a"},{"line_number":51,"context_line":"volume pool, and as such does not affect directory layout (and is thus"},{"line_number":52,"context_line":"compatible with both the legacy image backends and the new image backend"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_2106d2ce","line":49,"in_reply_to":"3a29b11f_b6d19959","updated":"2015-10-29 04:21:41.000000000","message":"Done","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"50079f3f617d3bf0e9e1b8b226ea2d68cea577e6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"proposed below)."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"A new image backend, :code:`LibvirtStorage`, would be introduced.  This would"},{"line_number":56,"context_line":"support being used in place of all of the current types (with the exeception of"},{"line_number":57,"context_line":"RBD support, which for the time being would need a subclass [1]_)."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"If we are not using COW, the libvirt :code:`pool.createXMLFrom` method"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_7659c1fd","line":56,"range":{"start_line":56,"start_character":66,"end_line":56,"end_character":76},"updated":"2015-10-20 15:15:28.000000000","message":"nit: exception","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"a87cf62ac8d9a243a04335d580a5d38db5a8f42c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"proposed below)."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"A new image backend, :code:`LibvirtStorage`, would be introduced.  This would"},{"line_number":56,"context_line":"support being used in place of all of the current types (with the exeception of"},{"line_number":57,"context_line":"RBD support, which for the time being would need a subclass [1]_)."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"If we are not using COW, the libvirt :code:`pool.createXMLFrom` method"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_41098edc","line":56,"in_reply_to":"3a29b11f_7659c1fd","updated":"2015-10-29 04:21:41.000000000","message":"Done","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"50079f3f617d3bf0e9e1b8b226ea2d68cea577e6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"   `Red Hat BZ 1089079 \u003chttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1089079\u003e`_."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. [2] Note that this functionality will most likely have to wait until the"},{"line_number":101,"context_line":"   OpenStack K release to be enabled by default, since such functionality would"},{"line_number":102,"context_line":"   be difficult to implement while supporting instances using both the legacy"},{"line_number":103,"context_line":"   and new backend -- see the `Other deployer impact`_ section below.  It could"},{"line_number":104,"context_line":"   be enabled in Mikata by setting the :code:`images_type` configuration option"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_b69679ee","line":101,"range":{"start_line":101,"start_character":13,"end_line":101,"end_character":22},"updated":"2015-10-20 15:15:28.000000000","message":"K release? Do you mean N?","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"a87cf62ac8d9a243a04335d580a5d38db5a8f42c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"   `Red Hat BZ 1089079 \u003chttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1089079\u003e`_."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. [2] Note that this functionality will most likely have to wait until the"},{"line_number":101,"context_line":"   OpenStack K release to be enabled by default, since such functionality would"},{"line_number":102,"context_line":"   be difficult to implement while supporting instances using both the legacy"},{"line_number":103,"context_line":"   and new backend -- see the `Other deployer impact`_ section below.  It could"},{"line_number":104,"context_line":"   be enabled in Mikata by setting the :code:`images_type` configuration option"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_81ffa6a9","line":101,"in_reply_to":"3a29b11f_b69679ee","updated":"2015-10-29 04:21:41.000000000","message":"Done","commit_id":"ae8eab1ecb51575a7861cabd2c8a7e7c39eca3e0"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"f3e10873fba57cd37109d17f54dad04b8499fe4a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"version of 1.0.5. This will simplify future enhancements and maintanence"},{"line_number":44,"context_line":"of this code by allowing it to leverage the volume management features"},{"line_number":45,"context_line":"provided by libvirt."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_070caaeb","line":46,"updated":"2015-11-02 14:08:34.000000000","message":"Project priority section is missing.\nProject priorities are decided, this should be: Live Migration\nNote that this was specifically included in the scope of the priority.","commit_id":"f4150ea50b0236a1b35d126e403f2a3ba70634b2"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"1be672915b6462e37bc649eae81642029e33b7e1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"version of 1.0.5. This will simplify future enhancements and maintanence"},{"line_number":44,"context_line":"of this code by allowing it to leverage the volume management features"},{"line_number":45,"context_line":"provided by libvirt."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_1cb74a87","line":46,"in_reply_to":"1a26ad4f_070caaeb","updated":"2015-11-10 16:35:12.000000000","message":"Done","commit_id":"f4150ea50b0236a1b35d126e403f2a3ba70634b2"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"3c54f3e587f79917824f0601300fedd6485a8f05","unresolved":false,"context_lines":[{"line_number":43,"context_line":"version of 1.0.5. This will simplify future enhancements and maintanence"},{"line_number":44,"context_line":"of this code by allowing it to leverage the volume management features"},{"line_number":45,"context_line":"provided by libvirt."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a26ad4f_a7b37699","line":46,"in_reply_to":"1a26ad4f_070caaeb","updated":"2015-11-02 14:18:34.000000000","message":"My mistake - that section is no longer used. Please ignore above comment.","commit_id":"f4150ea50b0236a1b35d126e403f2a3ba70634b2"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"1be672915b6462e37bc649eae81642029e33b7e1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"version of 1.0.5. This will simplify future enhancements and maintanence"},{"line_number":44,"context_line":"of this code by allowing it to leverage the volume management features"},{"line_number":45,"context_line":"provided by libvirt."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_7cc0d6e0","line":46,"in_reply_to":"1a26ad4f_a7b37699","updated":"2015-11-10 16:35:12.000000000","message":"Done","commit_id":"f4150ea50b0236a1b35d126e403f2a3ba70634b2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4b5d6c232d044ff6b09d5234e61247b556b2acbc","unresolved":false,"context_lines":[{"line_number":200,"context_line":"   would be deleted, leaving the new hard link as the only remaining reference"},{"line_number":201,"context_line":"   to the disk image file.  For filesystems where hard linking isn\u0027t supported,"},{"line_number":202,"context_line":"   a block live migration would be necessary to migrate the VM to the new image"},{"line_number":203,"context_line":"   backend."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Developer impact"},{"line_number":206,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_55cd402f","line":203,"updated":"2015-11-12 11:14:01.000000000","message":"This appears to be from:\nhttp://specs.openstack.org/openstack/nova-specs/specs/juno/approved/use-libvirt-storage-pools.html\n\nand not from:\nhttp://specs.openstack.org/openstack/nova-specs/specs/kilo/approved/use-libvirt-storage-pools.html","commit_id":"f4150ea50b0236a1b35d126e403f2a3ba70634b2"}]}