)]}'
{"specs/mitaka/approved/pagination-for-hypervisor.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b9c662d66202065ecedb1927eadf92df634b265e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Changes are going to be in the following places:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* DB api `compute_node_get_all` will be refactored by adding params limit,"},{"line_number":33,"context_line":"  marker, sort_key, and sort_dir."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Compute node object `get_all` method will be refactored to support"},{"line_number":36,"context_line":"  pagination."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_48e3dd33","line":33,"updated":"2015-10-20 07:37:55.000000000","message":"In server case, there is a different method like\n\n 660 def instance_get_all(context, columns_to_join\u003dNone):\n 661     \"\"\"Get all instances.\"\"\"\n 662     return IMPL.instance_get_all(context, columns_to_join\u003dcolumns_to_join)\n 663\n 664\n 665 def instance_get_all_by_filters(context, filters, sort_key\u003d\u0027created_at\u0027,\n 666                                 sort_dir\u003d\u0027desc\u0027, limit\u003dNone, marker\u003dNone,\n 667                                 columns_to_join\u003dNone, use_slave\u003dFalse):\n\nSo how about adding compute_node_get_all_by_filters like server method?\n\nIn this way, I guess the other filter methods(compute_node_search_by_hypervisor, etc) also can be merged.","commit_id":"b512f8334ce3ca25f41a7b32919fde0043f7b75b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"1bb9333e32e6d5b81a7eed95a7937083b071aafd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Changes are going to be in the following places:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* DB api `compute_node_get_all` will be refactored by adding params limit,"},{"line_number":33,"context_line":"  marker, sort_key, and sort_dir."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Compute node object `get_all` method will be refactored to support"},{"line_number":36,"context_line":"  pagination."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_b35d1217","line":33,"in_reply_to":"3a29b11f_48e3dd33","updated":"2015-10-21 00:44:08.000000000","message":"Seems reasonable to me. Done","commit_id":"b512f8334ce3ca25f41a7b32919fde0043f7b75b"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"8189ed4c85dc9caef3c535758548cd0d0b0ba763","unresolved":false,"context_lines":[{"line_number":32,"context_line":"* New DB api `compute_node_get_all_by_filters` will be added with"},{"line_number":33,"context_line":"  params filters, limit, marker, sort_key, and sort_dir, so other filter"},{"line_number":34,"context_line":"  methods(compute_node_search_by_hypervisor, etc) also can be merged to use"},{"line_number":35,"context_line":"  this."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* New compute node object `get_by_filters` method will be added which calls"},{"line_number":38,"context_line":"  the new db api `compute_node_get_all_by_filters`."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_d328cee4","line":35,"updated":"2015-10-21 01:10:32.000000000","message":"Are you proposing to also expose pagination on those methods? or just refactor the underlying implementation to use your new compute_node_get_all_by_filter() function?","commit_id":"bc4c458a844e4bea1695f2ab846244a4e8febb95"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b75c489b81672e4c08fadfc97019cfde1daca4dc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"* New DB api `compute_node_get_all_by_filters` will be added with"},{"line_number":33,"context_line":"  params filters, limit, marker, sort_key, and sort_dir, so other filter"},{"line_number":34,"context_line":"  methods(compute_node_search_by_hypervisor, etc) also can be merged to use"},{"line_number":35,"context_line":"  this."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* New compute node object `get_by_filters` method will be added which calls"},{"line_number":38,"context_line":"  the new db api `compute_node_get_all_by_filters`."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_d3b20e94","line":35,"in_reply_to":"3a29b11f_d328cee4","updated":"2015-10-21 01:18:19.000000000","message":"Just refactor to use the new db method.","commit_id":"bc4c458a844e4bea1695f2ab846244a4e8febb95"}]}