)]}'
{"specs/mitaka/approved/delete-on-termination-modification.rst":[{"author":{"_account_id":18247,"name":"Mark Doffman","email":"mdoffman@linux.vnet.ibm.com","username":"doffm"},"change_message_id":"939951e6150893e320ae4211f63f4e7c28bd3d04","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * Method type: PUT"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  * \"/v2/​{tenant_id}​/servers/​{server_id}​/os-volume_attachments\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  * Normal response code: 200"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a2ca52d_1f70ef71","line":133,"updated":"2015-10-13 20:18:37.000000000","message":"I\u0027m not sure that \u0027PUT\u0027 is being used here correctly. Since we are modifying the details of a particular attachment the url for a put should include some sort of attachment ID. \n\n\"/v2/{tenant_id}/servers/{server_id}/os-volume_attachments/{attachment_id}\"\n\nThe resource that is being modified should be in the url. I\u0027m possibly being pedantic here, but I don\u0027t see anywhere else in the nova API where this isn\u0027t the case.\n\nOf course there is the fact that there isn\u0027t an attachment ID. The \u0027update\u0027 vs \u0027attach\u0027 methods could be part of the json body and both go as a post, but that would miss the idempotency of the \u0027update\u0027 method.","commit_id":"13ed984bee4a16d95c730f05cddd6093e1b4394d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0d9b30b7fe73c07473960cdd8356dfc44cea1e1c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        \u0027pattern\u0027: ("},{"line_number":97,"context_line":"                            \u0027(^/dev/x{0,1}[a-z]{0,1}d{0,1})([a-z]+)[0-9]*$\u0027)"},{"line_number":98,"context_line":"                    },"},{"line_number":99,"context_line":"                    \u0027deleteOnTermination\u0027: parameter_types.boolean"},{"line_number":100,"context_line":"                },"},{"line_number":101,"context_line":"                \u0027required\u0027: [\u0027volumeId\u0027],"},{"line_number":102,"context_line":"                \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_faa3e7af","line":99,"updated":"2015-11-30 10:40:10.000000000","message":"This isn\u0027t the API-WG suggested naming style http://specs.openstack.org/openstack/api-wg/guidelines/naming.html\n\nWe should use delete_on_termination","commit_id":"bfed4952911c0ade45858d38340799a663528306"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20c5d85659381f6f349cf175e5efcc24b545feb9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        \u0027pattern\u0027: ("},{"line_number":97,"context_line":"                            \u0027(^/dev/x{0,1}[a-z]{0,1}d{0,1})([a-z]+)[0-9]*$\u0027)"},{"line_number":98,"context_line":"                    },"},{"line_number":99,"context_line":"                    \u0027deleteOnTermination\u0027: parameter_types.boolean"},{"line_number":100,"context_line":"                },"},{"line_number":101,"context_line":"                \u0027required\u0027: [\u0027volumeId\u0027],"},{"line_number":102,"context_line":"                \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_2fc0492a","line":99,"in_reply_to":"9a8ffd7b_faa3e7af","updated":"2015-11-30 13:14:45.000000000","message":"+1 as we are adding properties, we agreed we should use the new style names.","commit_id":"bfed4952911c0ade45858d38340799a663528306"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20c5d85659381f6f349cf175e5efcc24b545feb9","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  * Changes properties of an attached volume."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * Method type: PUT"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"``/v2/​{tenant_id}​/servers/​{server_id}​/os-volume_attachments/"},{"line_number":134,"context_line":"{attachment_id}``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_efd6c126","line":131,"updated":"2015-11-30 13:14:45.000000000","message":"should this not be POST, because the resource already exists? I am probably overthinking that.","commit_id":"bfed4952911c0ade45858d38340799a663528306"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0d9b30b7fe73c07473960cdd8356dfc44cea1e1c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  * Method type: PUT"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"``/v2/​{tenant_id}​/servers/​{server_id}​/os-volume_attachments/"},{"line_number":134,"context_line":"{attachment_id}``"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  * Normal response code: 200"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_3ac3af39","line":134,"updated":"2015-11-30 10:40:10.000000000","message":"The update action is actually for swap volume, it isn\u0027t just a updated for existed attached volume.","commit_id":"bfed4952911c0ade45858d38340799a663528306"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0d9b30b7fe73c07473960cdd8356dfc44cea1e1c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027volumeAttachment\u0027: {"},{"line_number":149,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":150,"context_line":"                \u0027properties\u0027: {"},{"line_number":151,"context_line":"                    \u0027deleteOnTermination\u0027: parameter_types.boolean"},{"line_number":152,"context_line":"                },"},{"line_number":153,"context_line":"                \u0027required\u0027: [\u0027deleteOnTermination\u0027],"},{"line_number":154,"context_line":"                \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_bafc7f72","line":151,"updated":"2015-11-30 10:40:10.000000000","message":"There is existed field \u0027volumeId\u0027, that is the volume used to swap.\n\nMaybe we should have more clear description at here.\n\nLike if volumeId field didn\u0027t provided, then swap volume won\u0027t be executed.\n\nIf volumeId field and delete_on_termination provided, the volume will be swapped and delete_on_termination will be updated.","commit_id":"bfed4952911c0ade45858d38340799a663528306"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20c5d85659381f6f349cf175e5efcc24b545feb9","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027volumeAttachment\u0027: {"},{"line_number":149,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":150,"context_line":"                \u0027properties\u0027: {"},{"line_number":151,"context_line":"                    \u0027deleteOnTermination\u0027: parameter_types.boolean"},{"line_number":152,"context_line":"                },"},{"line_number":153,"context_line":"                \u0027required\u0027: [\u0027deleteOnTermination\u0027],"},{"line_number":154,"context_line":"                \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_4ff82dc5","line":151,"in_reply_to":"9a8ffd7b_bafc7f72","updated":"2015-11-30 13:14:45.000000000","message":"good point, you mean volume_id is optional, and should really be noted here.","commit_id":"bfed4952911c0ade45858d38340799a663528306"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20c5d85659381f6f349cf175e5efcc24b545feb9","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    No response body is returned."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* There should not be any impacts to policy.json files for this change."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Security impact"},{"line_number":168,"context_line":"---------------"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_4fa26d9c","line":166,"updated":"2015-11-30 13:14:45.000000000","message":"I think we probably want something similar for BDM v2, for the on boot changes?\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/block_device_mapping.py#L21","commit_id":"bfed4952911c0ade45858d38340799a663528306"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5e57b9ff405747c7815e64664a0aacc1cae90513","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Specification for the method"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  * Attaches a volume to the specified server."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  * Method type: POST"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_321e9c5f","line":73,"updated":"2015-12-03 14:27:49.000000000","message":"is there not also this API call?\nhttp://developer.openstack.org/api-ref-compute-v2.1.html#attach","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"change_message_id":"1b8da98f4c53aaf3dc1602ddb536b41d4da88ab2","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Specification for the method"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  * Attaches a volume to the specified server."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  * Method type: POST"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_f186a264","line":73,"in_reply_to":"9a8ffd7b_321e9c5f","updated":"2015-12-03 15:18:27.000000000","message":"John, it is this API call. I\u0027m just adding the delete_on_termination. That\u0027s all.","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"878b86d4d409259e4c9e559e68c7d6c86dfe749c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            \"id\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":117,"context_line":"            \"serverId\": \"0c92f3f6-c253-4c9b-bd43-e880a8d2eb0a\","},{"line_number":118,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":119,"context_line":"            \"deleteOnTermination\": false"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"    }"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_f66b481c","line":119,"updated":"2015-12-03 03:19:28.000000000","message":"Why isn\u0027t here \"delete_on_termination\" instead of \"deleteOnTermination\" ?\n\nThis seems a new attribute and nice to make them consistent and follow api-wg guideline:\n\n Fields in an API request or response body\n    * Field names should use snake_case style, not CamelCase or MixedCase style.\n\nfrom https://github.com/openstack/api-wg/blob/master/guidelines/naming.rst","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5e57b9ff405747c7815e64664a0aacc1cae90513","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            \"id\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":117,"context_line":"            \"serverId\": \"0c92f3f6-c253-4c9b-bd43-e880a8d2eb0a\","},{"line_number":118,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":119,"context_line":"            \"deleteOnTermination\": false"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"    }"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_af7f87a9","line":119,"in_reply_to":"9a8ffd7b_f66b481c","updated":"2015-12-03 14:27:49.000000000","message":"I am torn on that, but we did agree to start adding all new names in the correct style, so this needs fixing, but due to the deadlines, I think we can do this in the next revision of the spec.","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"change_message_id":"1b8da98f4c53aaf3dc1602ddb536b41d4da88ab2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            \"id\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":117,"context_line":"            \"serverId\": \"0c92f3f6-c253-4c9b-bd43-e880a8d2eb0a\","},{"line_number":118,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":119,"context_line":"            \"deleteOnTermination\": false"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"    }"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_11900e95","line":119,"in_reply_to":"9a8ffd7b_f66b481c","updated":"2015-12-03 15:18:27.000000000","message":"My bad. Went fixing it.","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"878b86d4d409259e4c9e559e68c7d6c86dfe749c","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* There should not be any impacts to policy.json files for this change."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"1. Updates the \"update\" method"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Specification for the method"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_56325411","line":125,"updated":"2015-12-03 03:19:28.000000000","message":"s/1. /2. /","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"change_message_id":"1b8da98f4c53aaf3dc1602ddb536b41d4da88ab2","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* There should not be any impacts to policy.json files for this change."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"1. Updates the \"update\" method"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Specification for the method"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_51dd366f","line":125,"in_reply_to":"9a8ffd7b_56325411","updated":"2015-12-03 15:18:27.000000000","message":"My bad.","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5e57b9ff405747c7815e64664a0aacc1cae90513","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* There should not be any impacts to policy.json files for this change."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"1. Updates the \"update\" method"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Specification for the method"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_afc22732","line":125,"in_reply_to":"9a8ffd7b_56325411","updated":"2015-12-03 14:27:49.000000000","message":"honestly, the formatting of all this looks a bit strange. I think you mean to indent the bullets one extra level:\nhttp://docs-draft.openstack.org/69/234269/7/check/gate-nova-specs-docs/36fefd3//doc/build/html/specs/mitaka/approved/delete-on-termination-modification.html#rest-api-impact","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5e57b9ff405747c7815e64664a0aacc1cae90513","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    No response body is returned."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* There should not be any impacts to policy.json files for this change."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Security impact"},{"line_number":154,"context_line":"---------------"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_aff0e791","line":152,"updated":"2015-12-03 14:27:49.000000000","message":"I think we need to look at the BDMv2 schema, and make changes there, so it matches the above changes.","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"},{"author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"change_message_id":"1b8da98f4c53aaf3dc1602ddb536b41d4da88ab2","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    No response body is returned."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* There should not be any impacts to policy.json files for this change."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Security impact"},{"line_number":154,"context_line":"---------------"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_91407e09","line":152,"in_reply_to":"9a8ffd7b_aff0e791","updated":"2015-12-03 15:18:27.000000000","message":"John, sorry again, my unpublished comment had information that the BDMv2 schema already has everything needed for delete_on_termination functionality. It derives it.","commit_id":"12e35d3aa1a964445ad582624a5007111d5a01f7"}]}