)]}'
{"specs/mitaka/approved/libvirt-imagebackend-clvm.rst":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"509f4948396513defd73e06d999ee4f16b953ee3","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Cluster LVM support as Libvirt image backend"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/libvirt-imagebackend-clvm"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_813e7d8a","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":7},"updated":"2015-10-21 04:59:45.000000000","message":"nit: Clustered\n\nHere are the rest of the document","commit_id":"c4bf07da02ceaaa5b2d6880ecbe107dcdb7654b4"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"485a530612d9bd0cae9de74ec53c05cf96849268","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Cluster LVM support as Libvirt image backend"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/libvirt-imagebackend-clvm"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_04dd9b6e","line":8,"in_reply_to":"3a29b11f_813e7d8a","updated":"2015-10-21 05:50:41.000000000","message":"Done","commit_id":"c4bf07da02ceaaa5b2d6880ecbe107dcdb7654b4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"509f4948396513defd73e06d999ee4f16b953ee3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Add is_shared_block_storage() to nova.virt.libvirt.imagebackend.Lvm class:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def is_shared_block_storage():"},{"line_number":48,"context_line":"        \"\"\"True if the backend puts images on a shared block storage.\"\"\""},{"line_number":49,"context_line":"        return CONF.libvirt.clvm_enabled"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_417145a7","line":46,"updated":"2015-10-21 04:59:45.000000000","message":"nit: stick this in a code-block::","commit_id":"c4bf07da02ceaaa5b2d6880ecbe107dcdb7654b4"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"485a530612d9bd0cae9de74ec53c05cf96849268","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Add is_shared_block_storage() to nova.virt.libvirt.imagebackend.Lvm class:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def is_shared_block_storage():"},{"line_number":48,"context_line":"        \"\"\"True if the backend puts images on a shared block storage.\"\"\""},{"line_number":49,"context_line":"        return CONF.libvirt.clvm_enabled"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_240d37e8","line":46,"in_reply_to":"3a29b11f_417145a7","updated":"2015-10-21 05:50:41.000000000","message":"Done","commit_id":"c4bf07da02ceaaa5b2d6880ecbe107dcdb7654b4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"509f4948396513defd73e06d999ee4f16b953ee3","unresolved":false,"context_lines":[{"line_number":145,"context_line":"         def __init__(self, instance\u003dNone, disk_name\u003dNone, path\u003dNone):"},{"line_number":146,"context_line":"             super(Lvm, self).__init__(\"block\", \"raw\", is_block_dev\u003dTrue)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Add some unit tests for the above."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_c15d5516","line":148,"updated":"2015-10-21 04:59:45.000000000","message":"Wait it\u0027s just a config option and a single function?","commit_id":"c4bf07da02ceaaa5b2d6880ecbe107dcdb7654b4"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"485a530612d9bd0cae9de74ec53c05cf96849268","unresolved":false,"context_lines":[{"line_number":145,"context_line":"         def __init__(self, instance\u003dNone, disk_name\u003dNone, path\u003dNone):"},{"line_number":146,"context_line":"             super(Lvm, self).__init__(\"block\", \"raw\", is_block_dev\u003dTrue)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Add some unit tests for the above."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_4444f319","line":148,"in_reply_to":"3a29b11f_c15d5516","updated":"2015-10-21 05:50:41.000000000","message":"Exactly. It enables VM live-migration (not block migration) with CLVM.","commit_id":"c4bf07da02ceaaa5b2d6880ecbe107dcdb7654b4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"509f4948396513defd73e06d999ee4f16b953ee3","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Pacemaker for cluster resource management."},{"line_number":156,"context_line":"* Linux distributed lock manager (DLM) for exclusive lock."},{"line_number":157,"context_line":"* Cluster LVM daemon (clvmd) for shared LVM metadata management."},{"line_number":158,"context_line":"* SAN storage device (FC, iSCSI and other block device) for storage pool."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_01410d38","line":158,"updated":"2015-10-21 04:59:45.000000000","message":"These aren\u0027t python dependancies right, so you can omit them.","commit_id":"c4bf07da02ceaaa5b2d6880ecbe107dcdb7654b4"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"485a530612d9bd0cae9de74ec53c05cf96849268","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Pacemaker for cluster resource management."},{"line_number":156,"context_line":"* Linux distributed lock manager (DLM) for exclusive lock."},{"line_number":157,"context_line":"* Cluster LVM daemon (clvmd) for shared LVM metadata management."},{"line_number":158,"context_line":"* SAN storage device (FC, iSCSI and other block device) for storage pool."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a29b11f_04203b47","line":158,"in_reply_to":"3a29b11f_01410d38","updated":"2015-10-21 05:50:41.000000000","message":"Done","commit_id":"c4bf07da02ceaaa5b2d6880ecbe107dcdb7654b4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3099cb5ccc04ab39722bfc72a13809ca912f6257","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    +        return CONF.libvirt.clvm_enabled"},{"line_number":144,"context_line":"    +"},{"line_number":145,"context_line":"         def __init__(self, instance\u003dNone, disk_name\u003dNone, path\u003dNone):"},{"line_number":146,"context_line":"             super(Lvm, self).__init__(\"block\", \"raw\", is_block_dev\u003dTrue)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Add a few unit tests for the above."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a29b11f_a12db9a9","line":146,"updated":"2015-10-21 05:31:56.000000000","message":"Cool, the implementation is already done :-)\n\nI feel this code image is a little overkill at this stage because this requires code review.\nSo line 117 only seems enough.","commit_id":"ddefbf0935a5b4d16011ab69bfbf7e04f2da3a0c"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"f66dbbe67cb005571263f44aa9ce425ae128e42b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    +        return CONF.libvirt.clvm_enabled"},{"line_number":144,"context_line":"    +"},{"line_number":145,"context_line":"         def __init__(self, instance\u003dNone, disk_name\u003dNone, path\u003dNone):"},{"line_number":146,"context_line":"             super(Lvm, self).__init__(\"block\", \"raw\", is_block_dev\u003dTrue)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Add a few unit tests for the above."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a29b11f_4485d304","line":146,"in_reply_to":"3a29b11f_a12db9a9","updated":"2015-10-21 05:51:51.000000000","message":"Done","commit_id":"ddefbf0935a5b4d16011ab69bfbf7e04f2da3a0c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4fb9ffb824a44bab3cea5f0fe5dd2a4c92ea0b5a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        return CONF.libvirt.clvm_enabled"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"clvm_enabled is a boolean variable (defalut is False). True is set"},{"line_number":54,"context_line":"when CLVM is used as image backend."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_417ac3f2","line":54,"updated":"2015-11-10 17:38:25.000000000","message":"How do you know which hosts it is shared with?\n\nThe idea, as I understand it is ceph is shared between all hosts, so its always shared.\n\nFor NFS, we need to check which hosts it is shared with, which is why it is False, and does this file check:\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5120\n\nMaybe you should instead update the check to work with caching images and seeing if its visible on the other host.","commit_id":"1cdf9aedef799b60714811e141018006fe5a9636"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"e6167821016acf70c7dd10ebf189b864976a943a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        return CONF.libvirt.clvm_enabled"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"clvm_enabled is a boolean variable (defalut is False). True is set"},{"line_number":54,"context_line":"when CLVM is used as image backend."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba8a016a_e3ae26e5","line":54,"in_reply_to":"da85f559_4123a2a7","updated":"2015-11-19 07:51:15.000000000","message":"Perhaps, nova-compute needs common checking framework and each image backend should implement its own methods to check that the destination node can access ephemeral images/block devices of the instance to migrate.\n\nBut, IMO, it\u0027s out of scope of this spec.","commit_id":"1cdf9aedef799b60714811e141018006fe5a9636"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0dcf7a672e626c0ea487fe642164ebf7c864e561","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        return CONF.libvirt.clvm_enabled"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"clvm_enabled is a boolean variable (defalut is False). True is set"},{"line_number":54,"context_line":"when CLVM is used as image backend."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_4123a2a7","line":54,"in_reply_to":"da85f559_417ac3f2","updated":"2015-11-10 17:44:09.000000000","message":"This is really crying out for Jay\u0027s resource pool modelling work, which would let us describe what hosts share what LVM resource. Even with Ceph you have the possibility that different hosts see different ceph clusters.\n\nI don\u0027t much like blocking features based on other features which do not yet exist, but I do feel like we\u0027re going to cause ourselves more pain by adding more shared storage methods.","commit_id":"1cdf9aedef799b60714811e141018006fe5a9636"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4fb9ffb824a44bab3cea5f0fe5dd2a4c92ea0b5a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"---------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Each host is able to access all images on the CLVM pool. But it\u0027s not"},{"line_number":75,"context_line":"a problem because using NFS image backend is the same."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_413883a0","line":75,"updated":"2015-11-10 17:38:25.000000000","message":"doesn\u0027t this break how the image cache management works?","commit_id":"1cdf9aedef799b60714811e141018006fe5a9636"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"e6167821016acf70c7dd10ebf189b864976a943a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"---------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Each host is able to access all images on the CLVM pool. But it\u0027s not"},{"line_number":75,"context_line":"a problem because using NFS image backend is the same."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba8a016a_48be3166","line":75,"in_reply_to":"da85f559_216c5ecf","updated":"2015-11-19 07:51:15.000000000","message":"Looks no problem. Each nova-compute downloads a base image into local (i.e. not shared) /var/lib/nova/_base/ and imports it to the target LV as a raw image. Base images may be purged when not used locally, but the ephemeral LVs remain without deleting their instances.","commit_id":"1cdf9aedef799b60714811e141018006fe5a9636"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0dcf7a672e626c0ea487fe642164ebf7c864e561","unresolved":false,"context_lines":[{"line_number":72,"context_line":"---------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Each host is able to access all images on the CLVM pool. But it\u0027s not"},{"line_number":75,"context_line":"a problem because using NFS image backend is the same."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_216c5ecf","line":75,"in_reply_to":"da85f559_413883a0","updated":"2015-11-10 17:44:09.000000000","message":"Yeah, I\u0027d be surprised if image cache management worked without race conditions being present in logic for purging \"unused\" images.","commit_id":"1cdf9aedef799b60714811e141018006fe5a9636"}]}
