)]}'
{"specs/mitaka/approved/vm-boot-with-unaddressed-port.rst":[{"author":{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},"change_message_id":"6a10ef2a39678e597dbbbe5b395e32829ecc9b7b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"----------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"1. Remove the code of IP checking and subnet checking when creating VM."},{"line_number":101,"context_line":"   "},{"line_number":102,"context_line":"2. Add unit test cases."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_5e02e970","line":101,"updated":"2015-10-26 02:14:19.000000000","message":"Please refer to pep8!","commit_id":"d59b238a268fc2b8936f520efe394c30345fba7e"},{"author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"change_message_id":"edd2b69f0167cc8603778d4dc6ee9f4f65198767","unresolved":false,"context_lines":[{"line_number":98,"context_line":"----------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"1. Remove the code of IP checking and subnet checking when creating VM."},{"line_number":101,"context_line":"   "},{"line_number":102,"context_line":"2. Add unit test cases."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_beda1d16","line":101,"updated":"2015-10-26 02:10:45.000000000","message":"check this ,The blank space","commit_id":"d59b238a268fc2b8936f520efe394c30345fba7e"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"5230669de8953bf9340c0f345ec28b9fee2b2df7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"----------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"1. Remove the code of IP checking and subnet checking when creating VM."},{"line_number":101,"context_line":"   "},{"line_number":102,"context_line":"2. Add unit test cases."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_197d38e7","line":101,"in_reply_to":"3a29b11f_5e02e970","updated":"2015-11-10 05:48:17.000000000","message":"Done","commit_id":"d59b238a268fc2b8936f520efe394c30345fba7e"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"5230669de8953bf9340c0f345ec28b9fee2b2df7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"----------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"1. Remove the code of IP checking and subnet checking when creating VM."},{"line_number":101,"context_line":"   "},{"line_number":102,"context_line":"2. Add unit test cases."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_b983cccb","line":101,"in_reply_to":"3a29b11f_beda1d16","updated":"2015-11-10 05:48:17.000000000","message":"Done","commit_id":"d59b238a268fc2b8936f520efe394c30345fba7e"},{"author":{"_account_id":7055,"name":"Tapio Tallgren","username":"tapiotallgren","inactive":true},"change_message_id":"48cdea6e063daf63d26479eee5f7b5a2393eaa03","unresolved":false,"context_lines":[{"line_number":20,"context_line":"L2 and L3 assigned addresses are intrinsic attributes. But if consider the port"},{"line_number":21,"context_line":"of a firewall service VM, work as a truck, and the port which is just for"},{"line_number":22,"context_line":"forwarding all the traffic, they do not need a IP. Assigning a IP address is"},{"line_number":23,"context_line":"waste and bring the system a pointless burden."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_bb652246","line":23,"updated":"2015-11-17 07:42:19.000000000","message":"\"Trunk\" misspelled. Should probably say \"trunk port\" for clarity.","commit_id":"017e67b1389057e51e80f8dfe0cf3ced9571a49f"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"441979fce3e00732a17295d13341c0b3fa01d32b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"L2 and L3 assigned addresses are intrinsic attributes. But if consider the port"},{"line_number":21,"context_line":"of a firewall service VM, work as a truck, and the port which is just for"},{"line_number":22,"context_line":"forwarding all the traffic, they do not need a IP. Assigning a IP address is"},{"line_number":23,"context_line":"waste and bring the system a pointless burden."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_3eba6024","line":23,"in_reply_to":"ba8a016a_bb652246","updated":"2015-12-05 04:19:36.000000000","message":"Done","commit_id":"017e67b1389057e51e80f8dfe0cf3ced9571a49f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c30df0c296287fd620da4f891076cd4488a51a1e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Other deployer impact"},{"line_number":82,"context_line":"---------------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Developer impact"},{"line_number":87,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_de3ddbc4","line":84,"updated":"2015-11-19 15:48:56.000000000","message":"Deployers need to be made aware of the security implicaations of allowing this feature to be used, since it removes IP anti-spoofing protections IIUC.","commit_id":"017e67b1389057e51e80f8dfe0cf3ced9571a49f"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"441979fce3e00732a17295d13341c0b3fa01d32b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Other deployer impact"},{"line_number":82,"context_line":"---------------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Developer impact"},{"line_number":87,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_be6e50c7","line":84,"in_reply_to":"ba8a016a_de3ddbc4","updated":"2015-12-05 04:19:36.000000000","message":"Done","commit_id":"017e67b1389057e51e80f8dfe0cf3ced9571a49f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c30df0c296287fd620da4f891076cd4488a51a1e","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"http://specs.openstack.org/openstack/neutron-specs/specs/liberty/unaddressed-port.html"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"https://review.openstack.org/#/c/241968/"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_1edcc344","line":127,"updated":"2015-11-19 15:48:56.000000000","message":"This is a dependency for the Nova change, so should be listed in the Dependencies prt of the spec.","commit_id":"017e67b1389057e51e80f8dfe0cf3ced9571a49f"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"441979fce3e00732a17295d13341c0b3fa01d32b","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"http://specs.openstack.org/openstack/neutron-specs/specs/liberty/unaddressed-port.html"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"https://review.openstack.org/#/c/241968/"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_dea8fcdd","line":127,"in_reply_to":"ba8a016a_1edcc344","updated":"2015-12-05 04:19:36.000000000","message":"after discussed with KevinBenton, I think neutron has officially announced the port could be no IP and created from network without subnet, and also port could be updated to remove the IP addr.\n\nSo there is no dependency here. Nova\u0027s verification here also should not depend some port\u0027s attr which indicate it\u0027s a trunk port. We just need remove the verification and fix the problems if there is.","commit_id":"017e67b1389057e51e80f8dfe0cf3ced9571a49f"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"ecbbd318d085794c1d876b5cc260f586df02af73","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Other deployer impact"},{"line_number":83,"context_line":"---------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Deployers need to be made aware of the security implicaations of allowing this"},{"line_number":86,"context_line":"feature to be used, since it removes IP anti-spoofing protections."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a740942_a56e37c7","line":85,"updated":"2015-12-05 15:23:12.000000000","message":"s/implicaations/implications/","commit_id":"b2e30bc78f1a1de80fc8d9a0a2c45db2f4fb0672"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"8f4033474853067a2885002f2a273739b8a6dfb3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Other deployer impact"},{"line_number":83,"context_line":"---------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Deployers need to be made aware of the security implicaations of allowing this"},{"line_number":86,"context_line":"feature to be used, since it removes IP anti-spoofing protections."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a740942_acb7c6f3","line":85,"in_reply_to":"7a740942_a56e37c7","updated":"2015-12-07 19:44:50.000000000","message":"Done","commit_id":"b2e30bc78f1a1de80fc8d9a0a2c45db2f4fb0672"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1954a425f434311d3e3c6e9541150a771419dee2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"nor IPv6 in nature, one that accepts is a superset of v4 and v6 traffic, or one"},{"line_number":31,"context_line":"that accepts traffic for a very wide address range (for either forwarding or"},{"line_number":32,"context_line":"termination) and where the port has no primary address."},{"line_number":33,"context_line":"In such cases, the VM is not a conventional application VM."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_faadd99b","line":33,"updated":"2015-12-10 12:11:43.000000000","message":"Neutron is looking at adding a \"trunk\" port as top level part of neutron, this does seem to be conflicting with that effort.\n\nWe really need to get some neutron votes on this spec before we merge it in Nova.","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"01c7f5063eb18ffb75109ebfb9e8f0e01fe8f02e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"nor IPv6 in nature, one that accepts is a superset of v4 and v6 traffic, or one"},{"line_number":31,"context_line":"that accepts traffic for a very wide address range (for either forwarding or"},{"line_number":32,"context_line":"termination) and where the port has no primary address."},{"line_number":33,"context_line":"In such cases, the VM is not a conventional application VM."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_ee018905","line":33,"in_reply_to":"7a740942_faadd99b","updated":"2015-12-10 16:36:23.000000000","message":"Thanks John, I will call kevin to join the review","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"974edfc67ad88ef62692de16ff7aaa301642bc91","unresolved":false,"context_lines":[{"line_number":30,"context_line":"nor IPv6 in nature, one that accepts is a superset of v4 and v6 traffic, or one"},{"line_number":31,"context_line":"that accepts traffic for a very wide address range (for either forwarding or"},{"line_number":32,"context_line":"termination) and where the port has no primary address."},{"line_number":33,"context_line":"In such cases, the VM is not a conventional application VM."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_796eb7ca","line":33,"in_reply_to":"7a740942_faadd99b","updated":"2015-12-10 21:13:13.000000000","message":"This is orthogonal to the trunk port stuff. The trunk port is about pushing tags down to the VM. This work is just to allow a VM to boot if the port is on a network that doesn\u0027t have a subnet, in which cast it won\u0027t get an IP allocation.\n\nThere are some scenarios where the user doesn\u0027t want Neutron to handle any of the addressing or the IP level filtering because a completely separate system is managing that.","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"974edfc67ad88ef62692de16ff7aaa301642bc91","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Neutron has officially announced the port could have no IP and be created from"},{"line_number":40,"context_line":"network with or without any subnet, and also port could be updated to remove"},{"line_number":41,"context_line":"the IP addr."},{"line_number":42,"context_line":"So we can just remove the current checking code for port with IP and network"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_195e9312","line":39,"updated":"2015-12-10 21:13:13.000000000","message":"I would remove this part that says Neutron officially announced it. It\u0027s been something that has actually worked for quite a while by just creating a network and attaching a port to it without creating a subnet.\n\nSo just change to to say \"Neutron allows ports that do not have an IP address on them\".","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"7a62d36cc5f10abd3f2c047c77fd6e53cf10ddb9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Neutron has officially announced the port could have no IP and be created from"},{"line_number":40,"context_line":"network with or without any subnet, and also port could be updated to remove"},{"line_number":41,"context_line":"the IP addr."},{"line_number":42,"context_line":"So we can just remove the current checking code for port with IP and network"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_9426c5b8","line":39,"in_reply_to":"7a740942_195e9312","updated":"2015-12-11 03:55:21.000000000","message":"Done","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1954a425f434311d3e3c6e9541150a771419dee2","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Neutron has officially announced the port could have no IP and be created from"},{"line_number":40,"context_line":"network with or without any subnet, and also port could be updated to remove"},{"line_number":41,"context_line":"the IP addr."},{"line_number":42,"context_line":"So we can just remove the current checking code for port with IP and network"},{"line_number":43,"context_line":"with subnet, and carefully deal with the err path when creating VM port."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_9aca954e","line":41,"updated":"2015-12-10 12:11:43.000000000","message":"What do you mean \"remove\" the IP address. Do you really me, do not try to assign an IP address for these kinds of ports? I assume any IP address assignment on such ports would fail?","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"974edfc67ad88ef62692de16ff7aaa301642bc91","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Neutron has officially announced the port could have no IP and be created from"},{"line_number":40,"context_line":"network with or without any subnet, and also port could be updated to remove"},{"line_number":41,"context_line":"the IP addr."},{"line_number":42,"context_line":"So we can just remove the current checking code for port with IP and network"},{"line_number":43,"context_line":"with subnet, and carefully deal with the err path when creating VM port."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_d9ec8b2b","line":41,"in_reply_to":"7a740942_9aca954e","updated":"2015-12-10 21:13:13.000000000","message":"Either the ports can\u0027t get an IP because there is no subnet associated with the network or they have had them removed with an explicit API call setting fixed_ips to [].\n\nThere isn\u0027t anything special about these ports otherwise.","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"01c7f5063eb18ffb75109ebfb9e8f0e01fe8f02e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Neutron has officially announced the port could have no IP and be created from"},{"line_number":40,"context_line":"network with or without any subnet, and also port could be updated to remove"},{"line_number":41,"context_line":"the IP addr."},{"line_number":42,"context_line":"So we can just remove the current checking code for port with IP and network"},{"line_number":43,"context_line":"with subnet, and carefully deal with the err path when creating VM port."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_aef5c1ed","line":41,"in_reply_to":"7a740942_9aca954e","updated":"2015-12-10 16:36:23.000000000","message":"thanks John, I mean neutron has support port without IP, user could add/remove the ip address in neutron. I will update it.","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"7a62d36cc5f10abd3f2c047c77fd6e53cf10ddb9","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Neutron has officially announced the port could have no IP and be created from"},{"line_number":40,"context_line":"network with or without any subnet, and also port could be updated to remove"},{"line_number":41,"context_line":"the IP addr."},{"line_number":42,"context_line":"So we can just remove the current checking code for port with IP and network"},{"line_number":43,"context_line":"with subnet, and carefully deal with the err path when creating VM port."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_b429818b","line":41,"in_reply_to":"7a740942_d9ec8b2b","updated":"2015-12-11 03:55:21.000000000","message":"Done","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1954a425f434311d3e3c6e9541150a771419dee2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"---------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Some spoofing check based on IP would be removed, but the check based on MAC"},{"line_number":65,"context_line":"would still be reserved."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Notifications impact"},{"line_number":68,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_bacc3162","line":65,"updated":"2015-12-10 12:11:43.000000000","message":"But thats a Neutron impact not a Nova impact, I assume? I guess its still relevant here, just feels like it would be better to make it super clear its not something Nova needs to do.","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"01c7f5063eb18ffb75109ebfb9e8f0e01fe8f02e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"---------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Some spoofing check based on IP would be removed, but the check based on MAC"},{"line_number":65,"context_line":"would still be reserved."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Notifications impact"},{"line_number":68,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_ce360db4","line":65,"in_reply_to":"7a740942_bacc3162","updated":"2015-12-10 16:36:23.000000000","message":"right, it\u0027s a not a nova impact, will remove it.","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"974edfc67ad88ef62692de16ff7aaa301642bc91","unresolved":false,"context_lines":[{"line_number":62,"context_line":"---------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Some spoofing check based on IP would be removed, but the check based on MAC"},{"line_number":65,"context_line":"would still be reserved."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Notifications impact"},{"line_number":68,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_59473b1d","line":65,"in_reply_to":"7a740942_ce360db4","updated":"2015-12-10 21:13:13.000000000","message":"+1 to removing it. The spoofing stuff is all Neutron related.","commit_id":"c8084c4d6d12604fb084f5482526f32d911be0af"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"49430c00f46abe73b022a3dec3efe7347aadadc9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Neutron has officially announced the port could have no IP and be created from"},{"line_number":40,"context_line":"network with or without any subnet, and user already could update port to"},{"line_number":41,"context_line":"remove the IP addr."},{"line_number":42,"context_line":"So we can just remove the current checking code in NOVA for port with IP and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_d961eba9","line":39,"updated":"2015-12-10 21:14:58.000000000","message":"see comments on PS4 about this.","commit_id":"d3c195a1ed55053ef8a1f0fc8f187d2edf9a48ca"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"763621579fad1ad9ac0d26c346db3ed60d401e00","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Neutron has officially announced the port could have no IP and be created from"},{"line_number":40,"context_line":"network with or without any subnet, and user already could update port to"},{"line_number":41,"context_line":"remove the IP addr."},{"line_number":42,"context_line":"So we can just remove the current checking code in NOVA for port with IP and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_71380b3e","line":39,"in_reply_to":"7a740942_d961eba9","updated":"2015-12-11 03:55:40.000000000","message":"Done","commit_id":"d3c195a1ed55053ef8a1f0fc8f187d2edf9a48ca"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"49430c00f46abe73b022a3dec3efe7347aadadc9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"---------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Some spoofing check based on IP would be removed, but the check based on MAC"},{"line_number":66,"context_line":"would still be reserved."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Notifications impact"},{"line_number":69,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_39734f82","line":66,"updated":"2015-12-10 21:14:58.000000000","message":"pull this out. it\u0027s not a security impact to Nova.","commit_id":"d3c195a1ed55053ef8a1f0fc8f187d2edf9a48ca"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"763621579fad1ad9ac0d26c346db3ed60d401e00","unresolved":false,"context_lines":[{"line_number":63,"context_line":"---------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Some spoofing check based on IP would be removed, but the check based on MAC"},{"line_number":66,"context_line":"would still be reserved."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Notifications impact"},{"line_number":69,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_d1f21f9a","line":66,"in_reply_to":"7a740942_39734f82","updated":"2015-12-11 03:55:40.000000000","message":"Done","commit_id":"d3c195a1ed55053ef8a1f0fc8f187d2edf9a48ca"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"b77ef596ace7746bd44f505e3c4a773b22e5e8d3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"the addressing or the IP level filtering because a completely separate system"},{"line_number":23,"context_line":"is managing that."},{"line_number":24,"context_line":"Suppose a firewall service VM, and the port which is used to forward all the"},{"line_number":25,"context_line":"traffic, they do not need a IP and want to remove some filter based on IP."},{"line_number":26,"context_line":"Assigning a IP address is waste and bring the system a pointless burden."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_5a64b8b7","line":25,"updated":"2015-12-13 05:27:36.000000000","message":"a IP -\u003e an IP","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"5f045f6f32430465a269724e5e79ba032b79d9ae","unresolved":false,"context_lines":[{"line_number":22,"context_line":"the addressing or the IP level filtering because a completely separate system"},{"line_number":23,"context_line":"is managing that."},{"line_number":24,"context_line":"Suppose a firewall service VM, and the port which is used to forward all the"},{"line_number":25,"context_line":"traffic, they do not need a IP and want to remove some filter based on IP."},{"line_number":26,"context_line":"Assigning a IP address is waste and bring the system a pointless burden."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a710552_fe717fe1","line":25,"in_reply_to":"7a740942_5a64b8b7","updated":"2015-12-15 00:23:06.000000000","message":"Done","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"b77ef596ace7746bd44f505e3c4a773b22e5e8d3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"is managing that."},{"line_number":24,"context_line":"Suppose a firewall service VM, and the port which is used to forward all the"},{"line_number":25,"context_line":"traffic, they do not need a IP and want to remove some filter based on IP."},{"line_number":26,"context_line":"Assigning a IP address is waste and bring the system a pointless burden."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_fa5484c6","line":26,"updated":"2015-12-13 05:27:36.000000000","message":"ditto","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"5f045f6f32430465a269724e5e79ba032b79d9ae","unresolved":false,"context_lines":[{"line_number":23,"context_line":"is managing that."},{"line_number":24,"context_line":"Suppose a firewall service VM, and the port which is used to forward all the"},{"line_number":25,"context_line":"traffic, they do not need a IP and want to remove some filter based on IP."},{"line_number":26,"context_line":"Assigning a IP address is waste and bring the system a pointless burden."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a710552_9e771bd4","line":26,"in_reply_to":"7a740942_fa5484c6","updated":"2015-12-15 00:23:06.000000000","message":"Done","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bfa1a6f349c49c9d5781e2aa58dc901a6127ec60","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Data model impact"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"None."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_45704c72","line":58,"updated":"2015-12-14 02:43:23.000000000","message":"In nova side, we build up a model for caching instance network info. I\u0027m not sure how much it affect this effort. But it\u0027s worth to take a look at https://github.com/openstack/nova/blob/master/nova/network/model.py","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fd553e59cd41e30a8516f23fc39b1a26122fcf2a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_384d503e","line":63,"updated":"2015-12-11 19:50:33.000000000","message":"you sure?","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7dd18514674696c55217ebe93fae4f4f8eb161c5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_4d362752","line":63,"in_reply_to":"7a740942_25750063","updated":"2015-12-14 10:14:25.000000000","message":"So this one feels a little borderline.\n\nThere is a extra setting on the port that says, no IP address wanted, so we keep the check for all existing ports.\n\nWhether we restrict that to new micro-version requests, or allow that for all versions, I would still like to see a micro-version bump to advertise that we have added that feature. We can talk more in the API meeting on this one.","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"5f045f6f32430465a269724e5e79ba032b79d9ae","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a710552_84b6ea3b","line":63,"in_reply_to":"7a740942_25750063","updated":"2015-12-15 00:23:06.000000000","message":"Thanks Alex, I will add this part.","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"5ce6c01bbe0a8812c46a38b32e94d5ff7da2a424","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_f6def43c","line":63,"in_reply_to":"7a740942_384d503e","updated":"2015-12-11 22:29:41.000000000","message":"Thanks Armax for point it out!\n\nMy understanding is that it would not break the current nova API. Fix me if I am wrong.\nnova still specify the uuid of \"networks\" or \"port\" when booting vm with network.\n\nthe usecase would like this:\n--nic port-id\u003d$PORT\nIf the PORT without IP, vm should be able to attach to this port.\n\n--nic net-id\u003d$NET\nIf NET has subnets, neutron\u0027s auto assign IP and create port, then VM attach to this port.\nIf NET not have subnets, neutron\u0027s create unaddressed port and then VM attach to this port.\n\n--nic net-id\u003d$NET fixed-ip\u003d\"\"\neven if NET has subnets,  neutron will create unaddressed port and nova use it.","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"5fe8e8f8d71e989d77d3ca539307d8a1b52550c8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_5a3d988d","line":63,"in_reply_to":"7a740942_428dbbd1","updated":"2015-12-13 05:17:15.000000000","message":"yes, thanks Armax!","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"5f045f6f32430465a269724e5e79ba032b79d9ae","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a710552_0473dab2","line":63,"in_reply_to":"7a740942_4d362752","updated":"2015-12-15 00:23:06.000000000","message":"thanks John, I will join the API meeting.","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bfa1a6f349c49c9d5781e2aa58dc901a6127ec60","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_25750063","line":63,"in_reply_to":"7a740942_5a3d988d","updated":"2015-12-14 02:43:23.000000000","message":"Yes, this needs Microversion in Nova side. We also have API for attach/detach interface, the API also return the IP address. We need describe that.","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b0f75dd2b9f3a8d8bafe1626c5e2a156f9ae0174","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REST API impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_428dbbd1","line":63,"in_reply_to":"7a740942_f6def43c","updated":"2015-12-12 02:21:35.000000000","message":"What I mean is that the API used to return an error condition that no longer occurs now, so this spec does have an impact to the API.","commit_id":"6532b1842415ed7a7a242613d56bbfdaff88a0a4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e9026d34c6bc172838245a50499840949a0dfa33","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Neutron allows ports that do not have an IP address for a while, which means"},{"line_number":43,"context_line":"port could have no IP and be created from network with or without any subnet,"},{"line_number":44,"context_line":"and user already could set the fixed_ips to [] from port by neutron API."},{"line_number":45,"context_line":"So it\u0027s unnessary to keep the current checking code in NOVA for port with IP"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a710552_c2ba86e1","line":42,"range":{"start_line":42,"start_character":52,"end_line":42,"end_character":63},"updated":"2015-12-15 12:34:01.000000000","message":"I am not sure this blueprint has yet been merged?\nhttps://blueprints.launchpad.net/neutron/+spec/vm-without-l3-address","commit_id":"f89da3e6976fb3866abb441aede322fb2d392da2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ccae51fec31bb2cd88079e87362a2839e535f4b4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Neutron allows ports that do not have an IP address for a while, which means"},{"line_number":43,"context_line":"port could have no IP and be created from network with or without any subnet,"},{"line_number":44,"context_line":"and user already could set the fixed_ips to [] from port by neutron API."},{"line_number":45,"context_line":"So it\u0027s unnessary to keep the current checking code in NOVA for port with IP"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a710552_cb4ffa90","line":42,"in_reply_to":"5a710552_c2ba86e1","updated":"2015-12-15 14:48:57.000000000","message":"Even without that spec you can create a network without a subnet right now and attach a port to it. You can also use the API to set an empty fixed-ip list after the fact to a port to remove it\u0027s IPs.\n\nThose are just extra features to make it easier to work with.","commit_id":"f89da3e6976fb3866abb441aede322fb2d392da2"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"a95579450003ae7c005b5a16b43aa18225178af8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Neutron allows ports that do not have an IP address for a while, which means"},{"line_number":43,"context_line":"port could have no IP and be created from network with or without any subnet,"},{"line_number":44,"context_line":"and user already could set the fixed_ips to [] from port by neutron API."},{"line_number":45,"context_line":"So it\u0027s unnessary to keep the current checking code in NOVA for port with IP"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a710552_41944b8a","line":42,"in_reply_to":"5a710552_cb4ffa90","updated":"2015-12-15 15:35:40.000000000","message":"+1 \n\nlimited-portsec just add API to distinguish the fully port-sec and partly port-pec. And of cause it will verify the port has ip or not.\n\nBut port already could have no IP while NOT enable limited-portsec extension.\n\nThe current action of neutron when you specify the empty fixed-ip is that, creating the port without ip, but with others by default, default secgroup, default port-sec enabled(True if portsec added in extension driver). \n\nMy understanding is that nova has these verification just help neutron to avoid some undefined issue. we won\u0027t concern that the port\u0027s spoof issue, like the port in shared network, because the new limited-portsec API will explicitly help user to remove the L3 spoofing, and the current portsec API will help to remove L2/L3 spoofing.","commit_id":"f89da3e6976fb3866abb441aede322fb2d392da2"}],"specs/newton/approved/vm-boot-with-unaddressed-port.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7788f1f7c0309a8758b5bd8f324421ad94d5164c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Remove the checking code for port with IP and network with subnet, and"},{"line_number":38,"context_line":"carefully deal with the err path when creating VM port, make sure roll back"},{"line_number":39,"context_line":"all the ports including this kind of port."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_4f065721","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":42},"updated":"2016-05-13 00:50:24.000000000","message":"You\u0027re going to need to be a lot more specific here about what code in question in the nova.network.neutronv2.api.API class needs to change here and why, because it\u0027s not clear to me.\n\nWe really don\u0027t want more proxy code in Nova, so if this is about adding more code to Nova to create different types of ports in Neutron, then -1 to that. If you can create the port in Neutron first and then just provide it to Nova when booting the instance, that\u0027s how this should be done.","commit_id":"48d97df1223c58329c7e956ef2941dedba289c8b"}]}