)]}'
{"specs/mitaka/approved/runtime-image-type.rst":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"3565424b01bc7e8b5134b4a66fb697d8ff37f7a0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"when compute service starts. Let it be in an instance property rather than a"},{"line_number":39,"context_line":"property of the compute service property."},{"line_number":40,"context_line":"Not to interfere with current behaviour we can introduce a new image backend"},{"line_number":41,"context_line":"type called \u0027Runtime\u0027 or something like this."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_ce75a798","line":41,"updated":"2015-10-30 02:48:51.000000000","message":"Instead of just having a plain list of acceptable formats, we might need to consider having a mapping.\n\neg say\n\n  qcow2 source image -\u003e qcow2 node storage\n  raw source image -\u003e LVM node storage","commit_id":"c741db5d9c7997db3dc5c49899908a3d5471a047"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"a5eec08917ff942802babc740eaf5eda28f60cb7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"when compute service starts. Let it be in an instance property rather than a"},{"line_number":39,"context_line":"property of the compute service property."},{"line_number":40,"context_line":"Not to interfere with current behaviour we can introduce a new image backend"},{"line_number":41,"context_line":"type called \u0027Runtime\u0027 or something like this."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_2e59b5fe","line":41,"in_reply_to":"1a26ad4f_4eb19746","updated":"2015-11-05 19:14:58.000000000","message":"What about something like this:\nimages_type \u003d qcow2:qcow2, raw:lvm, ploop:ploop\n?","commit_id":"c741db5d9c7997db3dc5c49899908a3d5471a047"},{"author":{"_account_id":3189,"name":"Chet Burgess","email":"cfb@metacloud.com","username":"cfb-n"},"change_message_id":"6aad4178165dc4893c9385ca5570b936deb73986","unresolved":false,"context_lines":[{"line_number":38,"context_line":"when compute service starts. Let it be in an instance property rather than a"},{"line_number":39,"context_line":"property of the compute service property."},{"line_number":40,"context_line":"Not to interfere with current behaviour we can introduce a new image backend"},{"line_number":41,"context_line":"type called \u0027Runtime\u0027 or something like this."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_4eb19746","line":41,"in_reply_to":"1a26ad4f_ce75a798","updated":"2015-10-30 02:50:34.000000000","message":"I like this.","commit_id":"c741db5d9c7997db3dc5c49899908a3d5471a047"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"029b0948ab631b539d579e4cdbfd2e5dab307cf0","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":102,"context_line":"primary author and contact."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Primary assignee:"},{"line_number":105,"context_line":"  Maxim Nestratov mnestratov@virtuozzo.com"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_019d78bb","line":103,"updated":"2015-11-06 15:07:22.000000000","message":"Please remove the two previous paragraphs","commit_id":"c741db5d9c7997db3dc5c49899908a3d5471a047"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"f4ca9dd20ae71a9e27677d7d613b3967ea171213","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":102,"context_line":"primary author and contact."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Primary assignee:"},{"line_number":105,"context_line":"  Maxim Nestratov mnestratov@virtuozzo.com"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_45d625f2","line":103,"in_reply_to":"fa80f949_019d78bb","updated":"2015-11-06 17:41:23.000000000","message":"Done","commit_id":"c741db5d9c7997db3dc5c49899908a3d5471a047"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"029b0948ab631b539d579e4cdbfd2e5dab307cf0","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"A new nova.conf images_type option should be mentioned in documentation with"},{"line_number":129,"context_line":"description."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"References"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_615004d5","line":130,"updated":"2015-11-06 15:07:22.000000000","message":"as we have discussed at the summit I think we do not need to create a new parameter but we can use the existing one and we add more logic when we manage its value, like the first in the list is the default one.","commit_id":"c741db5d9c7997db3dc5c49899908a3d5471a047"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"f4ca9dd20ae71a9e27677d7d613b3967ea171213","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"A new nova.conf images_type option should be mentioned in documentation with"},{"line_number":129,"context_line":"description."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"References"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_a5fb517a","line":130,"in_reply_to":"fa80f949_615004d5","updated":"2015-11-06 17:41:23.000000000","message":"Agree. Done.","commit_id":"c741db5d9c7997db3dc5c49899908a3d5471a047"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"65ce89cf9d162944a24f85b9f0a5c2eb6c505211","unresolved":false,"context_lines":[{"line_number":38,"context_line":"LibvirtDriver has a field called image_backend which is initialized just once"},{"line_number":39,"context_line":"when compute service starts. Let it be in an instance property rather than a"},{"line_number":40,"context_line":"property of the compute service."},{"line_number":41,"context_line":"Parameter images_type becomes a list of mappings as follows:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"images_type \u003d \u003csource image type1\u003e:\u003cbackend image type1\u003e,"},{"line_number":44,"context_line":"              \u003csource image type2\u003e:\u003cbackend image type2\u003e ... and so on."}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_7e9fca5f","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":9},"updated":"2015-11-08 22:53:54.000000000","message":"Here you\u0027re talking about the config option right?","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"8c432f60488f754654844d700a43eeb7a5f229c3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"LibvirtDriver has a field called image_backend which is initialized just once"},{"line_number":39,"context_line":"when compute service starts. Let it be in an instance property rather than a"},{"line_number":40,"context_line":"property of the compute service."},{"line_number":41,"context_line":"Parameter images_type becomes a list of mappings as follows:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"images_type \u003d \u003csource image type1\u003e:\u003cbackend image type1\u003e,"},{"line_number":44,"context_line":"              \u003csource image type2\u003e:\u003cbackend image type2\u003e ... and so on."}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_f0dd2271","line":41,"in_reply_to":"da85f559_7e9fca5f","updated":"2015-11-09 07:47:33.000000000","message":"Right.","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"65ce89cf9d162944a24f85b9f0a5c2eb6c505211","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Or in short form:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"images_type \u003d \u003cimage type1\u003e, \u003cimage type2\u003e, ... and so on."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Which means that \"source image type1\" is the same as \"backend image type1\"."},{"line_number":51,"context_line":"Both forms can be used and mixed. For image types that are not represented"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_1eb0fef3","line":48,"updated":"2015-11-08 22:53:54.000000000","message":"IIRC Only the this short form was discussed at the summit and meets the problem description and use case.  If you want to add the new mapping feature please provide a more detailed problem description and use case.\n\nNote: I\u0027m not against the mapping and doing it now makes some sense.","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"8c432f60488f754654844d700a43eeb7a5f229c3","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Or in short form:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"images_type \u003d \u003cimage type1\u003e, \u003cimage type2\u003e, ... and so on."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Which means that \"source image type1\" is the same as \"backend image type1\"."},{"line_number":51,"context_line":"Both forms can be used and mixed. For image types that are not represented"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_535d18e8","line":48,"in_reply_to":"da85f559_1eb0fef3","updated":"2015-11-09 07:47:33.000000000","message":"Actually short form doesn\u0027t give us an opportunity to be flexible when you want some images be backed by lvm for instance while other be as is. But if everyone is agree that this is ok, I don\u0027t object.","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"65ce89cf9d162944a24f85b9f0a5c2eb6c505211","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Which means that \"source image type1\" is the same as \"backend image type1\"."},{"line_number":51,"context_line":"Both forms can be used and mixed. For image types that are not represented"},{"line_number":52,"context_line":"by corresponding glance image formats (like lmv and rbd), only one usage of"},{"line_number":53,"context_line":"a short form is allowed."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Not to interfere with current behaviour, if a provided image is not specified"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_7ef10acd","line":52,"range":{"start_line":52,"start_character":44,"end_line":52,"end_character":47},"updated":"2015-11-08 22:53:54.000000000","message":"typo: lvm","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"8c432f60488f754654844d700a43eeb7a5f229c3","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Which means that \"source image type1\" is the same as \"backend image type1\"."},{"line_number":51,"context_line":"Both forms can be used and mixed. For image types that are not represented"},{"line_number":52,"context_line":"by corresponding glance image formats (like lmv and rbd), only one usage of"},{"line_number":53,"context_line":"a short form is allowed."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Not to interfere with current behaviour, if a provided image is not specified"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_7005b2c0","line":52,"in_reply_to":"da85f559_7ef10acd","updated":"2015-11-09 07:47:33.000000000","message":"I\u0027ll fix it in next version.","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"65ce89cf9d162944a24f85b9f0a5c2eb6c505211","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Examples:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Correct:"},{"line_number":62,"context_line":"images_type \u003d"},{"line_number":63,"context_line":"images_type \u003d qcow2"},{"line_number":64,"context_line":"images_type \u003d lvm"},{"line_number":65,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_9e9cee6a","line":62,"updated":"2015-11-08 22:53:54.000000000","message":"How is this correct?","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"8c432f60488f754654844d700a43eeb7a5f229c3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Examples:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Correct:"},{"line_number":62,"context_line":"images_type \u003d"},{"line_number":63,"context_line":"images_type \u003d qcow2"},{"line_number":64,"context_line":"images_type \u003d lvm"},{"line_number":65,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_101ea60c","line":62,"in_reply_to":"da85f559_9e9cee6a","updated":"2015-11-09 07:47:33.000000000","message":"qcow2 is the default in such a case. I\u0027m sure it is valid now and we should keep backward compatibility.","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"65ce89cf9d162944a24f85b9f0a5c2eb6c505211","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Incorrect:"},{"line_number":69,"context_line":"images_type \u003d qcow2, qcow2:lvm"},{"line_number":70,"context_line":"images_type \u003d lvm, raw:lvm, ploop"},{"line_number":71,"context_line":"images_type \u003d rbd, lvm, raw"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_be7c5221","line":71,"updated":"2015-11-08 22:53:54.000000000","message":"Why are these 3 examples incorrect?  Please add explanations.","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"8c432f60488f754654844d700a43eeb7a5f229c3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Incorrect:"},{"line_number":69,"context_line":"images_type \u003d qcow2, qcow2:lvm"},{"line_number":70,"context_line":"images_type \u003d lvm, raw:lvm, ploop"},{"line_number":71,"context_line":"images_type \u003d rbd, lvm, raw"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_d017beeb","line":71,"in_reply_to":"da85f559_be7c5221","updated":"2015-11-09 07:47:33.000000000","message":"ok","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"65ce89cf9d162944a24f85b9f0a5c2eb6c505211","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Other end user impact"},{"line_number":99,"context_line":"---------------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Just a new nova.conf option for images_type parameter in libvirt section."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Performance Impact"},{"line_number":104,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_7e76ea3f","line":101,"updated":"2015-11-08 22:53:54.000000000","message":"We\u0027re now converting CONF.libvirt.images_type from a StrOpt to a ListOpt, which should be seamless in upgrade.","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"8c432f60488f754654844d700a43eeb7a5f229c3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Other end user impact"},{"line_number":99,"context_line":"---------------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Just a new nova.conf option for images_type parameter in libvirt section."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Performance Impact"},{"line_number":104,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_30abaa8b","line":101,"in_reply_to":"da85f559_7e76ea3f","updated":"2015-11-09 07:47:33.000000000","message":"Yeah, that\u0027s right. Forgot to update","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"65ce89cf9d162944a24f85b9f0a5c2eb6c505211","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Work Items"},{"line_number":134,"context_line":"----------"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"To be done."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Dependencies"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_dea03693","line":136,"updated":"2015-11-08 22:53:54.000000000","message":"Sure :)","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"8c432f60488f754654844d700a43eeb7a5f229c3","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Work Items"},{"line_number":134,"context_line":"----------"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"To be done."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Dependencies"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_1638ded2","line":136,"in_reply_to":"da85f559_dea03693","updated":"2015-11-09 07:47:33.000000000","message":"done :)","commit_id":"9ceec13805539f861baa1d827810375d1e914efe"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"b985a00342c320ae785c039fab4c54d523e769d8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"---------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Correct:"},{"line_number":63,"context_line":"images_type \u003d"},{"line_number":64,"context_line":"images_type \u003d qcow2"},{"line_number":65,"context_line":"images_type \u003d lvm"},{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_d64b312a","line":63,"updated":"2015-11-09 09:49:51.000000000","message":"at the moment it is not possible to define an empty value, the accepted values are:\n\u0027raw\u0027, \u0027qcow2\u0027, \u0027lvm\u0027, \u0027rbd\u0027, \u0027ploop\u0027, \u0027default\u0027\nand if default is specified then the use_cow_images flag is used.\n\nIf we do not have one of the above values we raise a RuntimeError","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"cb098bf6ff721be472ae4b409f47d92c0541ffc4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"---------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Correct:"},{"line_number":63,"context_line":"images_type \u003d"},{"line_number":64,"context_line":"images_type \u003d qcow2"},{"line_number":65,"context_line":"images_type \u003d lvm"},{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_56ee618c","line":63,"in_reply_to":"da85f559_d64b312a","updated":"2015-11-09 10:06:58.000000000","message":"Indeed. I thought it was defaulted to qcow2 or raw depending on use_cow_images parameter.","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"b985a00342c320ae785c039fab4c54d523e769d8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"images_type \u003d qcow2"},{"line_number":65,"context_line":"images_type \u003d lvm"},{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"},{"line_number":67,"context_line":"images_type \u003d qcow2, raw:lvm, ploop"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Incorrect:"},{"line_number":70,"context_line":"# ambiguous conversion rule for qcow2 format (qcow2-\u003eqcow2 or qcow2-\u003elvm)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_e2f9d04e","line":67,"updated":"2015-11-09 09:49:51.000000000","message":"In this case if we have lvm as source what will be the destination?","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"56effbffb26eaccc11bf9850db0e40fd1a1a34f9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"images_type \u003d qcow2"},{"line_number":65,"context_line":"images_type \u003d lvm"},{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"},{"line_number":67,"context_line":"images_type \u003d qcow2, raw:lvm, ploop"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Incorrect:"},{"line_number":70,"context_line":"# ambiguous conversion rule for qcow2 format (qcow2-\u003eqcow2 or qcow2-\u003elvm)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_cca39e9d","line":67,"in_reply_to":"da85f559_36495d8c","updated":"2015-11-09 10:36:23.000000000","message":"oh yes, you are right","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"cb098bf6ff721be472ae4b409f47d92c0541ffc4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"images_type \u003d qcow2"},{"line_number":65,"context_line":"images_type \u003d lvm"},{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"},{"line_number":67,"context_line":"images_type \u003d qcow2, raw:lvm, ploop"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Incorrect:"},{"line_number":70,"context_line":"# ambiguous conversion rule for qcow2 format (qcow2-\u003eqcow2 or qcow2-\u003elvm)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_36495d8c","line":67,"in_reply_to":"da85f559_e2f9d04e","updated":"2015-11-09 10:06:58.000000000","message":"Is there any way to have lvm as a source?","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"b985a00342c320ae785c039fab4c54d523e769d8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"},{"line_number":67,"context_line":"images_type \u003d qcow2, raw:lvm, ploop"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Incorrect:"},{"line_number":70,"context_line":"# ambiguous conversion rule for qcow2 format (qcow2-\u003eqcow2 or qcow2-\u003elvm)"},{"line_number":71,"context_line":"images_type \u003d qcow2, qcow2:lvm"},{"line_number":72,"context_line":"# duplicate conversion rule to lvm backend (raw-\u003elvm, raw-\u003elvm)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_02b1748f","line":69,"updated":"2015-11-09 09:49:51.000000000","message":"are we going to have a kind of validation or it is up to the operators to correct set the values for the image_type param?","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"cb098bf6ff721be472ae4b409f47d92c0541ffc4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"},{"line_number":67,"context_line":"images_type \u003d qcow2, raw:lvm, ploop"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Incorrect:"},{"line_number":70,"context_line":"# ambiguous conversion rule for qcow2 format (qcow2-\u003eqcow2 or qcow2-\u003elvm)"},{"line_number":71,"context_line":"images_type \u003d qcow2, qcow2:lvm"},{"line_number":72,"context_line":"# duplicate conversion rule to lvm backend (raw-\u003elvm, raw-\u003elvm)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_b6030d0f","line":69,"in_reply_to":"da85f559_02b1748f","updated":"2015-11-09 10:06:58.000000000","message":"Incorrect values I beleve should throw exeption RuntimeError(\u0027Invalid images_type list\")","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"c29855e12eb5d6c24ee4d7a154cda02e11947b01","unresolved":false,"context_lines":[{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"},{"line_number":67,"context_line":"images_type \u003d qcow2, raw:lvm, ploop"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Incorrect:"},{"line_number":70,"context_line":"# ambiguous conversion rule for qcow2 format (qcow2-\u003eqcow2 or qcow2-\u003elvm)"},{"line_number":71,"context_line":"images_type \u003d qcow2, qcow2:lvm"},{"line_number":72,"context_line":"# duplicate conversion rule to lvm backend (raw-\u003elvm, raw-\u003elvm)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_5bc20187","line":69,"in_reply_to":"da85f559_8cdb561b","updated":"2015-11-09 12:42:58.000000000","message":"done","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"56effbffb26eaccc11bf9850db0e40fd1a1a34f9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"images_type \u003d qcow2:lvm, raw:rbd"},{"line_number":67,"context_line":"images_type \u003d qcow2, raw:lvm, ploop"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Incorrect:"},{"line_number":70,"context_line":"# ambiguous conversion rule for qcow2 format (qcow2-\u003eqcow2 or qcow2-\u003elvm)"},{"line_number":71,"context_line":"images_type \u003d qcow2, qcow2:lvm"},{"line_number":72,"context_line":"# duplicate conversion rule to lvm backend (raw-\u003elvm, raw-\u003elvm)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_8cdb561b","line":69,"in_reply_to":"da85f559_b6030d0f","updated":"2015-11-09 10:36:23.000000000","message":"so the idea is to check the conversion rule in the code, probably it is worth to mention it in the spec","commit_id":"908520e4a3e6fde96f534c5eb8aac3c5f9726304"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e2b1bece8c2c2e5a788cfc385d163d6e3632a725","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Not to interfere with current behaviour, if a provided image is not specified"},{"line_number":57,"context_line":"in images_type mapping string, then it will be converted to the first"},{"line_number":58,"context_line":"destiantion backend in the list."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Correctness of the supplied CONF.libvirt.images_type should be made by code."},{"line_number":61,"context_line":"In case of invalid input an exception should be thrown by a parsing function."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_5bf68190","line":58,"updated":"2015-11-09 12:52:30.000000000","message":"I find the mixing of  long and short forms somewhat confusing - paroticularly when looking at the Correct vs Incorrect examples, without the comments it is not entirely obvious what\u0027s wrong. Special casing the first element in the list adds to that confusion IMHO. I understand why you allow the the short form - to retain compat with existing usage.\n\nHow about a slight alternative proposal.\n\n- Keep \u0027images_type\u0027 syntax unchanged - just allows a single image backend name. This denotes the default conversion scheme\n\n- Add a new \u0027images_type_mapping\u0027 which only allows the long format you describe above.\n\nFor any source image type for which there is no entry in \"images_type_mapping\", we use images_type as the default.","commit_id":"aea2d3d577aa6472383cb2449d60883c949a77cf"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"daddcf8473faf8fb33292b6d4bd4eb9db5451c9d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Not to interfere with current behaviour, if a provided image is not specified"},{"line_number":57,"context_line":"in images_type mapping string, then it will be converted to the first"},{"line_number":58,"context_line":"destiantion backend in the list."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Correctness of the supplied CONF.libvirt.images_type should be made by code."},{"line_number":61,"context_line":"In case of invalid input an exception should be thrown by a parsing function."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_5e750fc9","line":58,"in_reply_to":"da85f559_5bf68190","updated":"2015-11-09 13:19:40.000000000","message":"I like it.","commit_id":"aea2d3d577aa6472383cb2449d60883c949a77cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e4324546555e31a4ca65f2c8db847e21d1f76829","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# invalid source format (lvm and rbd can\u0027t be specified as a source)"},{"line_number":84,"context_line":"images_type \u003d default"},{"line_number":85,"context_line":"images_type_mapping \u003d lvm:rbd, rbd:rbd"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Alternatives"},{"line_number":88,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da85f559_3dfc64b7","line":85,"updated":"2015-11-11 10:24:16.000000000","message":"Nice examples.","commit_id":"c3315e3d6cf040dcdece14516b5c97255eaa9b29"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"f9f48e1c05bd7f028e7d91792057a3e271229343","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Performance Impact"},{"line_number":119,"context_line":"------------------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"None."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Other deployer impact"},{"line_number":124,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da85f559_f1515fd9","line":121,"updated":"2015-11-10 11:33:29.000000000","message":"Probably we have some performance gain as we support different types of image at runtime and we do not need to convert them if they are in the list of allowed images.","commit_id":"c3315e3d6cf040dcdece14516b5c97255eaa9b29"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e4324546555e31a4ca65f2c8db847e21d1f76829","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Performance Impact"},{"line_number":119,"context_line":"------------------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"None."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Other deployer impact"},{"line_number":124,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da85f559_3d4ea43b","line":121,"in_reply_to":"da85f559_31d847ef","updated":"2015-11-11 10:24:16.000000000","message":"Nice to have, but like you say, lets not respin just for that.","commit_id":"c3315e3d6cf040dcdece14516b5c97255eaa9b29"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"51d7b9df8e3a4db9f1cafc6b501dbe6bf5d9bdd1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Performance Impact"},{"line_number":119,"context_line":"------------------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"None."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Other deployer impact"},{"line_number":124,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da85f559_31d847ef","line":121,"in_reply_to":"da85f559_f1515fd9","updated":"2015-11-10 11:43:56.000000000","message":"Yep, you are right. I interpreted this section as something about negative impact. That\u0027s why None is here. But if you want me to mention the positive effect, I\u0027ll do this.","commit_id":"c3315e3d6cf040dcdece14516b5c97255eaa9b29"}]}