)]}'
{"specs/mitaka/approved/add-live-migration-progress-to-instance-info.rst":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"15f87b95fd2eb19c777c120a0d039993876218a4","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"At present details about the progress of the migration operations are"},{"line_number":64,"context_line":"collected by the libvirt the virtualization driver and written to the"},{"line_number":65,"context_line":"log file at 5 second intervals during the migration process. It is"},{"line_number":66,"context_line":"proposed that the _live_migration_monitor method of the LibvirtDriver"},{"line_number":67,"context_line":"class be enhanced to update the migration object and call the save()"},{"line_number":68,"context_line":"method to update the database row.  This will mean adding the migration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_96d7a022","line":65,"updated":"2015-11-10 14:03:46.000000000","message":"Actually we also update   instance.progress attribute with the data:\n\nhttps://review.openstack.org/gitweb?p\u003dopenstack/nova.git;a\u003dblob;f\u003dnova/virt/libvirt/driver.py;h\u003dc96dd858f09f297f304d169102f99e3d0720b588;hb\u003dHEAD#l6010","commit_id":"77277f75f3c6a27df44c0c7c66cb5b2b45560baa"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"e252ab3801fb7f92499bb23dc7411df5c37f475c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"At present details about the progress of the migration operations are"},{"line_number":64,"context_line":"collected by the libvirt the virtualization driver and written to the"},{"line_number":65,"context_line":"log file at 5 second intervals during the migration process. It is"},{"line_number":66,"context_line":"proposed that the _live_migration_monitor method of the LibvirtDriver"},{"line_number":67,"context_line":"class be enhanced to update the migration object and call the save()"},{"line_number":68,"context_line":"method to update the database row.  This will mean adding the migration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_595ba92e","line":65,"in_reply_to":"da85f559_96d7a022","updated":"2015-11-10 14:47:47.000000000","message":"oh, missed that!","commit_id":"77277f75f3c6a27df44c0c7c66cb5b2b45560baa"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"15f87b95fd2eb19c777c120a0d039993876218a4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"-----------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Add a new column to migrations table called \u0027progress\u0027 with a default"},{"line_number":89,"context_line":"value of -1."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"REST API impact"},{"line_number":92,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_76a23cb0","line":89,"updated":"2015-11-10 14:03:46.000000000","message":"I\u0027m not seeing a clear reason to add this, when we already have instance.progress recording live migration progress.  IIUC, the instance.progress is intended to be a generic field for providing progress information about the currently running task for an instance. This seems preferrable than having progress recorded in a different place for each different type of task.","commit_id":"77277f75f3c6a27df44c0c7c66cb5b2b45560baa"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"e252ab3801fb7f92499bb23dc7411df5c37f475c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"-----------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Add a new column to migrations table called \u0027progress\u0027 with a default"},{"line_number":89,"context_line":"value of -1."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"REST API impact"},{"line_number":92,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_87868863","line":89,"in_reply_to":"da85f559_76a23cb0","updated":"2015-11-10 14:47:47.000000000","message":"Agreed, we don\u0027t need this extra column for the purposes of this spec, which I will now abandon since the functionality I was trying to achieve already exists!","commit_id":"77277f75f3c6a27df44c0c7c66cb5b2b45560baa"}]}