)]}'
{"specs/mitaka/approved/virt-image-props-boot-override-via-flavor.rst":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f69343fd4b7a606b4d07f9ddf161db8c6e56e94c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  $  nova boot \\"},{"line_number":93,"context_line":"      --flavor m1.small.vmware \\"},{"line_number":94,"context_line":"      --image vmware-image"},{"line_number":95,"context_line":"      ...other args..."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Alternatives"},{"line_number":98,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_938e6c2c","line":95,"updated":"2015-11-19 15:35:48.000000000","message":"In I agree in principal that we need to formalize the relationship between image properties and flavour extra specs.\n\nThere are already cases where we have synchronized flavour extra specs and image properties. eg some of the NUMA / CPU pinning properties use similar naming schemes, though flavour uses \u0027hw:\u0027 and image uses \u0027hw_\u0027 prefix. We have some priority rules too, about what is honoured in each case. In some cases, the flavour always takes priority, I thin we have other cases where the flavour provides the default and the image can customize that.\n\n\nSo before we allow arbitrary image property overide by a flavour extra spec, I feel we need to clearly understand what flavour extra specs we already have and how they interact with existing image properties\n\nUnfortunately I think this is a pretty large job. We\u0027ll need to define a FlavourExtraSpecs object and audit the code to find all extra specs we currently use and then define object properties for them all. Then we\u0027ll need to convert all the code to use the object instead of dict. Finally we\u0027ll have to look at relationship between image and flavour properties to understand priority/override rules we already have.  Only then, can we really consider defining a general override rule between images and flaovurs IMHO","commit_id":"16d42326ebae1b60c758283b1b9c1fec30c1c7a7"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"19b948a0b9cf6d96ff112a0eb0949ab593979949","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  $  nova boot \\"},{"line_number":93,"context_line":"      --flavor m1.small.vmware \\"},{"line_number":94,"context_line":"      --image vmware-image"},{"line_number":95,"context_line":"      ...other args..."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Alternatives"},{"line_number":98,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_6ed7ddbf","line":95,"in_reply_to":"ba8a016a_938e6c2c","updated":"2015-11-25 16:08:48.000000000","message":"Hi Daniel,\n\nThank you for your considerations. I agree on your proposal. We need to understand the current situation of flavour extra spec clearly, and then we will implement FlavourExtraSpecs and related stuffs.\n\nI will consider this approach. Thanks again.","commit_id":"16d42326ebae1b60c758283b1b9c1fec30c1c7a7"}]}