)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"79257c7c871950a75ac3467f7f5d1f94d0ae6a36","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Expand Instance Actions Coverage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We propose to expand the range of instance actions that are covered"},{"line_number":10,"context_line":"by the os-instance-actions API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"blueprint expand-instance-actions-coverage"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9abb7d3a_98c39438","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":31},"updated":"2016-06-02 10:04:48.000000000","message":"Please add APIImpact here","commit_id":"571d67127fb3805f867815a8b8240481d80336d7"}],"specs/newton/approved/expand-instance-actions-coverage.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"df9a8d013e5672c52fa052439e3558d666a1f4f2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"---------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The \u0027action\u0027 field of the os-instance-actions API response will contain"},{"line_number":63,"context_line":"additional values."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_a6a05bf5","line":63,"updated":"2016-05-16 15:30:34.000000000","message":"This will need an API micro-version, to allow the extra values.","commit_id":"256ec52376ebc4cd18baf1be14faf7bfc645e4fd"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3966465fab08c12ef6d39198a78e5217fe9e0204","unresolved":false,"context_lines":[{"line_number":60,"context_line":"---------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The \u0027action\u0027 field of the os-instance-actions API response will contain"},{"line_number":63,"context_line":"additional values."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_d244104b","line":63,"in_reply_to":"9abb7d3a_af24870c","updated":"2016-06-01 13:57:28.000000000","message":"oops, misunderstand this words, ignore previous comment.\n\nYeh, it needs microversion, although i hope not.","commit_id":"256ec52376ebc4cd18baf1be14faf7bfc645e4fd"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"320b58b88850fb077ede4ebeeef782772051726b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"---------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The \u0027action\u0027 field of the os-instance-actions API response will contain"},{"line_number":63,"context_line":"additional values."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_af24870c","line":63,"in_reply_to":"dab17558_a6a05bf5","updated":"2016-06-01 13:53:51.000000000","message":"or move this out of this specs, merged this \u0027action\u0027 field into the spec about \"finish_time\"?","commit_id":"256ec52376ebc4cd18baf1be14faf7bfc645e4fd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"df9a8d013e5672c52fa052439e3558d666a1f4f2","unresolved":false,"context_lines":[{"line_number":99,"context_line":"-----------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Primary assignee:"},{"line_number":102,"context_line":"  toan-nguyen"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Other contributors:"},{"line_number":105,"context_line":"  brian-rosmaita"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_a6797b95","line":102,"updated":"2016-05-16 15:30:34.000000000","message":"really?","commit_id":"256ec52376ebc4cd18baf1be14faf7bfc645e4fd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"df9a8d013e5672c52fa052439e3558d666a1f4f2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Work Items"},{"line_number":108,"context_line":"----------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"#. Add instance-actions coverage for the \"new\" actions."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_26946b89","line":110,"updated":"2016-05-16 15:30:34.000000000","message":"I think there are two steps here:\n* add instance actions\n* expose via the API in a microversion.","commit_id":"256ec52376ebc4cd18baf1be14faf7bfc645e4fd"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"91d85eddcfcd0176a1bc0b89619c2a9cda0a13f1","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* snapshot"},{"line_number":38,"context_line":"* backup"},{"line_number":39,"context_line":"* shelve_offload"},{"line_number":40,"context_line":"* lock"},{"line_number":41,"context_line":"* unlock"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_f9ee4b20","line":39,"updated":"2016-06-01 17:48:16.000000000","message":"Instance-actions reflect API initiated actions. shelve_offload is not something that can be initiated via the API afaik.","commit_id":"e19481d48bfcb7d9cced63c133da2b2980436b6e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6f26edd302630556485843967c226303cfd790a5","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* snapshot"},{"line_number":38,"context_line":"* backup"},{"line_number":39,"context_line":"* shelve_offload"},{"line_number":40,"context_line":"* lock"},{"line_number":41,"context_line":"* unlock"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_15c0147c","line":39,"in_reply_to":"9abb7d3a_f9ee4b20","updated":"2016-06-02 08:23:00.000000000","message":"Yeah, I was thinking a similar thing actually, we should probably drop that.","commit_id":"e19481d48bfcb7d9cced63c133da2b2980436b6e"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"91d85eddcfcd0176a1bc0b89619c2a9cda0a13f1","unresolved":false,"context_lines":[{"line_number":139,"context_line":"The os-instance-actions API documentation currently does not explicitly list"},{"line_number":140,"context_line":"the possible values of the \"action\" field in the response.  So either there"},{"line_number":141,"context_line":"will be no change (if we want to preserve the status quo) or the docs can be"},{"line_number":142,"context_line":"updated to include a complete list of values."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"References"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_19086fd9","line":142,"updated":"2016-06-01 17:48:16.000000000","message":"The action should match the API request. I don\u0027t think an exhaustive list is needed in the docs, just an explanation that each API call could be an action.\n\nWhat I want to avoid is getting to a point where adding an action is a microversion bump. Changing the schema of an action would be, but adding/removing actions shouldn\u0027t be IMO.","commit_id":"e19481d48bfcb7d9cced63c133da2b2980436b6e"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"2830c930f04d87f7252bef74475daa3eea012ad4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"The os-instance-actions API documentation currently does not explicitly list"},{"line_number":140,"context_line":"the possible values of the \"action\" field in the response.  So either there"},{"line_number":141,"context_line":"will be no change (if we want to preserve the status quo) or the docs can be"},{"line_number":142,"context_line":"updated to include a complete list of values."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"References"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_a74590b4","line":142,"in_reply_to":"9abb7d3a_15f5b4ca","updated":"2016-06-02 13:02:22.000000000","message":"Here\u0027s my issue with a microversion: I don\u0027t think we should filter out new actions from older microversions. If we advertise a new microversion to indicate that a new action will be reported that\u0027s fine, but I don\u0027t think we should gate the visibility of a new action with a microversion.\n\nAnd instance-action-events were never intended to be a contractual thing in the API, which is a part of the reason they are admin only. Instance-actions are tied to the API request so they will be fairly stable, but instance-action-events are tied to the compute manager methods and we need those to remain malleable. So I think instance-action-events should definitely not be microversioned.","commit_id":"e19481d48bfcb7d9cced63c133da2b2980436b6e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6f26edd302630556485843967c226303cfd790a5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"The os-instance-actions API documentation currently does not explicitly list"},{"line_number":140,"context_line":"the possible values of the \"action\" field in the response.  So either there"},{"line_number":141,"context_line":"will be no change (if we want to preserve the status quo) or the docs can be"},{"line_number":142,"context_line":"updated to include a complete list of values."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"References"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_15f5b4ca","line":142,"in_reply_to":"9abb7d3a_19086fd9","updated":"2016-06-02 08:23:00.000000000","message":"So I think it has to be a microversion, as described above. Else as a user, how do you tell if you can see the progress of action XYZ?\n\nNow I think the cool thing, is we generally add actions in a micro-version anyways, so I don\u0027t think that will turn out to be that big of a deal, once we get the backlog of actions dealt with.","commit_id":"e19481d48bfcb7d9cced63c133da2b2980436b6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7fc4a666acae5b979c8e22cbc54fefadf959fd30","unresolved":false,"context_lines":[{"line_number":139,"context_line":"The os-instance-actions API documentation currently does not explicitly list"},{"line_number":140,"context_line":"the possible values of the \"action\" field in the response.  So either there"},{"line_number":141,"context_line":"will be no change (if we want to preserve the status quo) or the docs can be"},{"line_number":142,"context_line":"updated to include a complete list of values."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"References"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da7fb54a_81031a0f","line":142,"in_reply_to":"9abb7d3a_a74590b4","updated":"2016-09-02 15:30:30.000000000","message":"Agree with Laski here, I actually think we can consider gaps in instance actions coverage as bug fixes.","commit_id":"e19481d48bfcb7d9cced63c133da2b2980436b6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"446d88fa7282463d4ea65cf03de2134b5bc48e33","unresolved":false,"context_lines":[{"line_number":61,"context_line":"The \u0027action\u0027 field of the os-instance-actions API response will contain"},{"line_number":62,"context_line":"additional values. This is be exposed in a new microversion."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The new actions that will be included will be:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* snapshot"},{"line_number":67,"context_line":"* backup"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da7fb54a_e19ea606","line":64,"updated":"2016-09-02 15:28:56.000000000","message":"I was looking for instance actions on swap volume today, which is an operation on a server, just not in this list or in the API ref docs about server actions:\n\nhttp://developer.openstack.org/api-ref/compute/?expanded\u003dupdate-a-volume-attachment-detail#update-a-volume-attachment\n\nIt\u0027s an admin-only operation by default and is mainly in nova for the purpose of cinder calling it as part of it\u0027s volume migration/retype operation, so it\u0027s really just part of a larger orchestrated operation between cinder and nova, but I think for that reason we should have instance actions for it since as a user you might not even know that actions are being performed on your server like changing the volumes that are attached to it.","commit_id":"571d67127fb3805f867815a8b8240481d80336d7"}]}