)]}'
{"specs/mitaka/approved/multi-attach-volume.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":59,"context_line":"instance_uuid, it does not have to be stored in Nova."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"By default libvirt assumes all disks are exclusively used for a single guest."},{"line_number":62,"context_line":"If you want to share disks between instances, you need to tell libvirt"},{"line_number":63,"context_line":"when configuring the guest XML for that disk via setting the sharable flag"},{"line_number":64,"context_line":"for the disk. This means that the hypervisor will not try to take an exclusive"},{"line_number":65,"context_line":"lock on the disk, that all I/O caching is disabled, and any SELinux labeling"},{"line_number":66,"context_line":"allows use by all domains."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_57cbac72","line":64,"range":{"start_line":62,"start_character":46,"end_line":64,"end_character":12},"updated":"2016-01-08 02:44:25.000000000","message":"I know this is not part of this change, but in reading the entire spec again, I was wondering what version constraints there would be with the libvirt driver and it looks like 1.2.2 might be a minimum requirement for this to work with libvirt given:\n\nhttps://libvirt.org/formatdomain.html\n\n\"shareable\nIf present, this indicates the device is expected to be shared between domains (assuming the hypervisor and OS support this). Only supported by SCSI host device. Since 1.0.6\nNote: Although shareable was introduced in 1.0.6, it did not work as as expected until 1.2.2.\"\n\nlibvirt 1.2.2 is what we test with in the gate since that\u0027s what\u0027s in ubuntu 14.04, but the minimum supported version of libvirt in mitaka is 0.9.11:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L360\n\nI think we\u0027re supposed to be moving that up to 0.10.2 in mitaka per:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L365\n\nThat should happen here:\n\nhttps://review.openstack.org/#/c/231917/\n\nBut still, that\u0027s only libvirt 0.10.2.\n\nSo I\u0027m thinking we need a libvirt version check for the multi-attach capability to require libvirt\u003e\u003d1.2.2 per the libvirt docs. We should probably see what danpb thinks about this, or if we should set a workaround flag or something so we can at least test that the operation doesn\u0027t fail in the gate.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":59,"context_line":"instance_uuid, it does not have to be stored in Nova."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"By default libvirt assumes all disks are exclusively used for a single guest."},{"line_number":62,"context_line":"If you want to share disks between instances, you need to tell libvirt"},{"line_number":63,"context_line":"when configuring the guest XML for that disk via setting the sharable flag"},{"line_number":64,"context_line":"for the disk. This means that the hypervisor will not try to take an exclusive"},{"line_number":65,"context_line":"lock on the disk, that all I/O caching is disabled, and any SELinux labeling"},{"line_number":66,"context_line":"allows use by all domains."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_2f18fb74","line":64,"range":{"start_line":62,"start_character":46,"end_line":64,"end_character":12},"in_reply_to":"fa69d971_57cbac72","updated":"2016-01-08 10:25:48.000000000","message":"I read that description, but missed the check what\u0027s the minimum version that Nova supports. Let\u0027s wait to see danpb\u0027s opinion too.\n\nI will check the code in the meantime to add a check for this and update the capabilities dict accordingly.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"acff7debde038a3c01d97b0c877ba4c3bdd33440","unresolved":false,"context_lines":[{"line_number":59,"context_line":"instance_uuid, it does not have to be stored in Nova."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"By default libvirt assumes all disks are exclusively used for a single guest."},{"line_number":62,"context_line":"If you want to share disks between instances, you need to tell libvirt"},{"line_number":63,"context_line":"when configuring the guest XML for that disk via setting the sharable flag"},{"line_number":64,"context_line":"for the disk. This means that the hypervisor will not try to take an exclusive"},{"line_number":65,"context_line":"lock on the disk, that all I/O caching is disabled, and any SELinux labeling"},{"line_number":66,"context_line":"allows use by all domains."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_b51bcb7f","line":64,"range":{"start_line":62,"start_character":46,"end_line":64,"end_character":12},"in_reply_to":"fa69d971_57cbac72","updated":"2016-01-08 15:26:51.000000000","message":"You\u0027re are reading the wrong docs here. That \u0027shareable\u0027 flag doc you quote is the doc for the \u003chostdev\u003e device type, *not* the \u003cdisk\u003e device type. There is no min version requirement for the \u003cshareable\u003e flag wrt \u003cdisk\u003e devices","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5b916be1ec96512472d63813fccb00bcf45847","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Nova needs to set this sharable flag for the multi-attach disks of the"},{"line_number":69,"context_line":"instances. Only the libvirt driver is modified to support multi-attach, for"},{"line_number":70,"context_line":"the rest this capability is disabled, the information is stored among the virt"},{"line_number":71,"context_line":"driver capabilities dict."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"There are features of the Nova API that has to be handled by care or disabled"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_e6dc8276","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":8},"updated":"2016-01-07 21:57:10.000000000","message":"I\u0027d replace \u0027the rest\u0027 with something more specific, like \u0027for all other virt drivers\u0027.\n\nWe could actually just default to multiattach support in the base ComputeDriver as being disabled and then the libvirt driver would opt-in by enabling it via it\u0027s capabilities. That\u0027s probably easiest.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Nova needs to set this sharable flag for the multi-attach disks of the"},{"line_number":69,"context_line":"instances. Only the libvirt driver is modified to support multi-attach, for"},{"line_number":70,"context_line":"the rest this capability is disabled, the information is stored among the virt"},{"line_number":71,"context_line":"driver capabilities dict."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"There are features of the Nova API that has to be handled by care or disabled"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_206250d9","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":8},"in_reply_to":"fa69d971_e6dc8276","updated":"2016-01-08 10:25:48.000000000","message":"Yeah, this is exactly how I implemented it: https://review.openstack.org/#/c/193135/69/nova/virt/libvirt/driver.py\n\nDone","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5b916be1ec96512472d63813fccb00bcf45847","unresolved":false,"context_lines":[{"line_number":70,"context_line":"the rest this capability is disabled, the information is stored among the virt"},{"line_number":71,"context_line":"driver capabilities dict."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"There are features of the Nova API that has to be handled by care or disabled"},{"line_number":74,"context_line":"completely for now for volumes that support multi-attach. In this sense"},{"line_number":75,"context_line":"\u0027create_volume_snapshot\u0027 is disabled as we cannot identify the BDM without"},{"line_number":76,"context_line":"the instance_uuid."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_a619aa24","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":57},"updated":"2016-01-07 21:57:10.000000000","message":"I might make this a start to a new sub-section about impacts to other existing compute APIs (besides the volume attach action).\n\nThen you\u0027d have a section for the os-assisted-volume-snapshots API (create_volume_snapshot) and for boot from volume, and go into details there.\n\nIt would just help break up the big blocks of prose in this section if there were focused sub-sections on the impacted APIs.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":70,"context_line":"the rest this capability is disabled, the information is stored among the virt"},{"line_number":71,"context_line":"driver capabilities dict."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"There are features of the Nova API that has to be handled by care or disabled"},{"line_number":74,"context_line":"completely for now for volumes that support multi-attach. In this sense"},{"line_number":75,"context_line":"\u0027create_volume_snapshot\u0027 is disabled as we cannot identify the BDM without"},{"line_number":76,"context_line":"the instance_uuid."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_8091bc9c","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":57},"in_reply_to":"fa69d971_57c72c45","updated":"2016-01-08 10:25:48.000000000","message":"I will add it to the REST API part, the format of the specs is checked if I remember correctly.\n\nDone","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":70,"context_line":"the rest this capability is disabled, the information is stored among the virt"},{"line_number":71,"context_line":"driver capabilities dict."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"There are features of the Nova API that has to be handled by care or disabled"},{"line_number":74,"context_line":"completely for now for volumes that support multi-attach. In this sense"},{"line_number":75,"context_line":"\u0027create_volume_snapshot\u0027 is disabled as we cannot identify the BDM without"},{"line_number":76,"context_line":"the instance_uuid."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_57c72c45","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":57},"in_reply_to":"fa69d971_a619aa24","updated":"2016-01-08 02:44:25.000000000","message":"Another idea is moving these parts to the REST API Impacts section below.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"031b2b3b349152b3fe9b9a1755d1bd4eb9564ac5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"There are features of the Nova API that has to be handled by care or disabled"},{"line_number":74,"context_line":"completely for now for volumes that support multi-attach. In this sense"},{"line_number":75,"context_line":"\u0027create_volume_snapshot\u0027 is disabled as we cannot identify the BDM without"},{"line_number":76,"context_line":"the instance_uuid."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Another feature that needs limitations is the \u0027boot from volume\u0027 (BFV). In case"},{"line_number":79,"context_line":"of this feature two aspects need further investigation. The first is the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_69e86517","line":76,"updated":"2016-01-07 22:16:21.000000000","message":"Just thinking out loud, we wouldn\u0027t need any kind of microversion for this change since it\u0027s not really a regression, it\u0027s just something that\u0027s not supported. If we were to support this, we\u0027d have to change the API to take a server id along with the volume id and *that* would require a microversion. This is simply protecting us from a limitation.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":73,"context_line":"There are features of the Nova API that has to be handled by care or disabled"},{"line_number":74,"context_line":"completely for now for volumes that support multi-attach. In this sense"},{"line_number":75,"context_line":"\u0027create_volume_snapshot\u0027 is disabled as we cannot identify the BDM without"},{"line_number":76,"context_line":"the instance_uuid."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Another feature that needs limitations is the \u0027boot from volume\u0027 (BFV). In case"},{"line_number":79,"context_line":"of this feature two aspects need further investigation. The first is the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_e00438c7","line":76,"in_reply_to":"fa69d971_69e86517","updated":"2016-01-08 10:25:48.000000000","message":"This change does not add limitation to what was supported earlier, so I agree with the protection comment for this point, added a note.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5b916be1ec96512472d63813fccb00bcf45847","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Another feature that needs limitations is the \u0027boot from volume\u0027 (BFV). In case"},{"line_number":79,"context_line":"of this feature two aspects need further investigation. The first is the"},{"line_number":80,"context_line":"\u0027delete_on_termination\u0027 flag, which if set to True is intended to remove the"},{"line_number":81,"context_line":"volume that is attached to the instance. This option does not cause problem as"},{"line_number":82,"context_line":"Cinder takes care of not deleting a volume if it still has active attachments."},{"line_number":83,"context_line":"Nova will receive an error from Cinder that the volume deletion failed, which"},{"line_number":84,"context_line":"will then be logged, but will not affect the instance termination process."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_46e1cefd","line":81,"range":{"start_line":81,"start_character":31,"end_line":81,"end_character":39},"updated":"2016-01-07 21:57:10.000000000","message":"When the instance is deleted.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Another feature that needs limitations is the \u0027boot from volume\u0027 (BFV). In case"},{"line_number":79,"context_line":"of this feature two aspects need further investigation. The first is the"},{"line_number":80,"context_line":"\u0027delete_on_termination\u0027 flag, which if set to True is intended to remove the"},{"line_number":81,"context_line":"volume that is attached to the instance. This option does not cause problem as"},{"line_number":82,"context_line":"Cinder takes care of not deleting a volume if it still has active attachments."},{"line_number":83,"context_line":"Nova will receive an error from Cinder that the volume deletion failed, which"},{"line_number":84,"context_line":"will then be logged, but will not affect the instance termination process."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_c3857ecf","line":81,"range":{"start_line":81,"start_character":31,"end_line":81,"end_character":39},"in_reply_to":"fa69d971_46e1cefd","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5b916be1ec96512472d63813fccb00bcf45847","unresolved":false,"context_lines":[{"line_number":81,"context_line":"volume that is attached to the instance. This option does not cause problem as"},{"line_number":82,"context_line":"Cinder takes care of not deleting a volume if it still has active attachments."},{"line_number":83,"context_line":"Nova will receive an error from Cinder that the volume deletion failed, which"},{"line_number":84,"context_line":"will then be logged, but will not affect the instance termination process."},{"line_number":85,"context_line":"According to this this flag will be allowed to use along with multi-attach."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"The second aspect of BFV is the boot process. In this case the only issue"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_86a586b6","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":19},"updated":"2016-01-07 21:57:10.000000000","message":"I\u0027d suggest providing a reference to that code since it already exists:\n\nhttps://github.com/openstack/nova/blob/295224c41e7da07c5ddbdafc72ac5abf2d708c69/nova/compute/manager.py#L2369","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":81,"context_line":"volume that is attached to the instance. This option does not cause problem as"},{"line_number":82,"context_line":"Cinder takes care of not deleting a volume if it still has active attachments."},{"line_number":83,"context_line":"Nova will receive an error from Cinder that the volume deletion failed, which"},{"line_number":84,"context_line":"will then be logged, but will not affect the instance termination process."},{"line_number":85,"context_line":"According to this this flag will be allowed to use along with multi-attach."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"The second aspect of BFV is the boot process. In this case the only issue"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_6354d253","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":19},"in_reply_to":"fa69d971_86a586b6","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5b916be1ec96512472d63813fccb00bcf45847","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Cinder takes care of not deleting a volume if it still has active attachments."},{"line_number":83,"context_line":"Nova will receive an error from Cinder that the volume deletion failed, which"},{"line_number":84,"context_line":"will then be logged, but will not affect the instance termination process."},{"line_number":85,"context_line":"According to this this flag will be allowed to use along with multi-attach."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"The second aspect of BFV is the boot process. In this case the only issue"},{"line_number":88,"context_line":"comes with the bootable volumes, which are specified in the boot request as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_a6752a33","line":85,"updated":"2016-01-07 21:57:10.000000000","message":"So basically I think you\u0027re saying here that there are actually no changes to be made to deal with boot from volume where the volume provided is multiattach\u003dTrue and the delete_on_termination\u003dTrue flag is passed in. If that\u0027s right, we might want to be clear about that here (no changes necessary, just stating here for completeness).","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Cinder takes care of not deleting a volume if it still has active attachments."},{"line_number":83,"context_line":"Nova will receive an error from Cinder that the volume deletion failed, which"},{"line_number":84,"context_line":"will then be logged, but will not affect the instance termination process."},{"line_number":85,"context_line":"According to this this flag will be allowed to use along with multi-attach."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"The second aspect of BFV is the boot process. In this case the only issue"},{"line_number":88,"context_line":"comes with the bootable volumes, which are specified in the boot request as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_46467c50","line":85,"in_reply_to":"fa69d971_a6752a33","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5b916be1ec96512472d63813fccb00bcf45847","unresolved":false,"context_lines":[{"line_number":95,"context_line":"case the request will return an error that this operation is not supported"},{"line_number":96,"context_line":"for multi-attach volumes."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"For cases, where Nova creates the volume itself it should not enable"},{"line_number":99,"context_line":"multi-attach for the volume for now."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_a6ac4a8d","line":98,"range":{"start_line":98,"start_character":41,"end_line":98,"end_character":47},"updated":"2016-01-07 21:57:10.000000000","message":"itself, i.e. source_type is blank/image/snapshot, it should...","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":95,"context_line":"case the request will return an error that this operation is not supported"},{"line_number":96,"context_line":"for multi-attach volumes."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"For cases, where Nova creates the volume itself it should not enable"},{"line_number":99,"context_line":"multi-attach for the volume for now."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_c67eec69","line":98,"range":{"start_line":98,"start_character":41,"end_line":98,"end_character":47},"in_reply_to":"fa69d971_a6ac4a8d","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":134,"context_line":"The OpenStack volume encryption capability is supposed to work out of the"},{"line_number":135,"context_line":"box with this use case also, it should not break how the encryptor works"},{"line_number":136,"context_line":"below the clustered file system, by using the same key for all connections."},{"line_number":137,"context_line":"The issues, if there will be any will be handled on the run."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Notifications impact"},{"line_number":140,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_d77d5ce8","line":137,"range":{"start_line":137,"start_character":33,"end_line":137,"end_character":60},"updated":"2016-01-08 02:44:25.000000000","message":"What does \u0027handled on the run\u0027 mean?\n\nWe should probably have a tempest test for this case where we\u0027re trying to attach an encrypted volume to two different instances and see if anything blows up.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":134,"context_line":"The OpenStack volume encryption capability is supposed to work out of the"},{"line_number":135,"context_line":"box with this use case also, it should not break how the encryptor works"},{"line_number":136,"context_line":"below the clustered file system, by using the same key for all connections."},{"line_number":137,"context_line":"The issues, if there will be any will be handled on the run."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Notifications impact"},{"line_number":140,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_46b99c14","line":137,"range":{"start_line":137,"start_character":33,"end_line":137,"end_character":60},"in_reply_to":"fa69d971_d77d5ce8","updated":"2016-01-08 10:25:48.000000000","message":"I will rephrase this.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Other deployer impact"},{"line_number":156,"context_line":"---------------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Developer impact"},{"line_number":161,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_9a72abac","line":158,"updated":"2016-01-08 02:44:25.000000000","message":"The libvirt 1.2.2 version issue should probably be documented here.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Other deployer impact"},{"line_number":156,"context_line":"---------------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Developer impact"},{"line_number":161,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_062f243f","line":158,"in_reply_to":"fa69d971_9a72abac","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Testing"},{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"We\u0027ll have to add new Tempest tests to support the new Cinder volume sharable"},{"line_number":206,"context_line":"flag. The new cinder sharable flag is what allows a volume to be attached"},{"line_number":207,"context_line":"more than once or not. Have to look into a tempest test for attaching the"},{"line_number":208,"context_line":"same volume to multiple instances."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_fa6ba783","line":205,"range":{"start_line":205,"start_character":69,"end_line":205,"end_character":77},"updated":"2016-01-08 02:44:25.000000000","message":"This is really the multiattach flag right?\n\nhttps://github.com/openstack/cinder/blob/master/cinder/api/v2/volumes.py#L410","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Testing"},{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"We\u0027ll have to add new Tempest tests to support the new Cinder volume sharable"},{"line_number":206,"context_line":"flag. The new cinder sharable flag is what allows a volume to be attached"},{"line_number":207,"context_line":"more than once or not. Have to look into a tempest test for attaching the"},{"line_number":208,"context_line":"same volume to multiple instances."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_86f474cf","line":205,"range":{"start_line":205,"start_character":69,"end_line":205,"end_character":77},"in_reply_to":"fa69d971_fa6ba783","updated":"2016-01-08 10:25:48.000000000","message":"Yes, I missed this one to change, when I updated the spec.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":205,"context_line":"We\u0027ll have to add new Tempest tests to support the new Cinder volume sharable"},{"line_number":206,"context_line":"flag. The new cinder sharable flag is what allows a volume to be attached"},{"line_number":207,"context_line":"more than once or not. Have to look into a tempest test for attaching the"},{"line_number":208,"context_line":"same volume to multiple instances."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_da8ca337","line":208,"updated":"2016-01-08 02:44:25.000000000","message":"This should probably include:\n\n1. boot from volume multiattach\n2. encrypted volume multiattach\n3. negative testing:\n  - boot from volume multiple instances with same volume but boot_index\u003d0\n  - trying to attach a non-multiattach volume to multiple instances","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":205,"context_line":"We\u0027ll have to add new Tempest tests to support the new Cinder volume sharable"},{"line_number":206,"context_line":"flag. The new cinder sharable flag is what allows a volume to be attached"},{"line_number":207,"context_line":"more than once or not. Have to look into a tempest test for attaching the"},{"line_number":208,"context_line":"same volume to multiple instances."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_29bebbff","line":208,"in_reply_to":"fa69d971_da8ca337","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"We will have to update the documentations to discuss the new ability to"},{"line_number":215,"context_line":"attach a volume to multiple instances if the cinder sharable flag is set on a"},{"line_number":216,"context_line":"volume. It is also need to be added to the documentation that the volume"},{"line_number":217,"context_line":"creation for these types of volumes will not be supported by Nova due to"},{"line_number":218,"context_line":"the deprecation of the volume creation API. If a volume needs to allow"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_7a98176b","line":215,"range":{"start_line":215,"start_character":52,"end_line":215,"end_character":60},"updated":"2016-01-08 02:44:25.000000000","message":"multiattach","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"We will have to update the documentations to discuss the new ability to"},{"line_number":215,"context_line":"attach a volume to multiple instances if the cinder sharable flag is set on a"},{"line_number":216,"context_line":"volume. It is also need to be added to the documentation that the volume"},{"line_number":217,"context_line":"creation for these types of volumes will not be supported by Nova due to"},{"line_number":218,"context_line":"the deprecation of the volume creation API. If a volume needs to allow"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_097c17ea","line":215,"range":{"start_line":215,"start_character":52,"end_line":215,"end_character":60},"in_reply_to":"fa69d971_7a98176b","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":214,"context_line":"We will have to update the documentations to discuss the new ability to"},{"line_number":215,"context_line":"attach a volume to multiple instances if the cinder sharable flag is set on a"},{"line_number":216,"context_line":"volume. It is also need to be added to the documentation that the volume"},{"line_number":217,"context_line":"creation for these types of volumes will not be supported by Nova due to"},{"line_number":218,"context_line":"the deprecation of the volume creation API. If a volume needs to allow"},{"line_number":219,"context_line":"multiple volume attachments it has to be created on the Cinder side with"},{"line_number":220,"context_line":"the needed properties specified."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_3af85f7c","line":217,"range":{"start_line":217,"start_character":61,"end_line":217,"end_character":65},"updated":"2016-01-08 02:44:25.000000000","message":"\"the Nova API\" - otherwise this is a bit confusing b/c it sounds like Nova doesn\u0027t support creating multiattach volumes (which the nova api doesn\u0027t), but it doesn\u0027t stop cinder from doing that and nova using them.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":214,"context_line":"We will have to update the documentations to discuss the new ability to"},{"line_number":215,"context_line":"attach a volume to multiple instances if the cinder sharable flag is set on a"},{"line_number":216,"context_line":"volume. It is also need to be added to the documentation that the volume"},{"line_number":217,"context_line":"creation for these types of volumes will not be supported by Nova due to"},{"line_number":218,"context_line":"the deprecation of the volume creation API. If a volume needs to allow"},{"line_number":219,"context_line":"multiple volume attachments it has to be created on the Cinder side with"},{"line_number":220,"context_line":"the needed properties specified."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_690cb342","line":217,"range":{"start_line":217,"start_character":61,"end_line":217,"end_character":65},"in_reply_to":"fa69d971_3af85f7c","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":215,"context_line":"attach a volume to multiple instances if the cinder sharable flag is set on a"},{"line_number":216,"context_line":"volume. It is also need to be added to the documentation that the volume"},{"line_number":217,"context_line":"creation for these types of volumes will not be supported by Nova due to"},{"line_number":218,"context_line":"the deprecation of the volume creation API. If a volume needs to allow"},{"line_number":219,"context_line":"multiple volume attachments it has to be created on the Cinder side with"},{"line_number":220,"context_line":"the needed properties specified."},{"line_number":221,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_1aef9bb1","line":218,"range":{"start_line":218,"start_character":39,"end_line":218,"end_character":42},"updated":"2016-01-08 02:44:25.000000000","message":"\"Nova API\"","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":215,"context_line":"attach a volume to multiple instances if the cinder sharable flag is set on a"},{"line_number":216,"context_line":"volume. It is also need to be added to the documentation that the volume"},{"line_number":217,"context_line":"creation for these types of volumes will not be supported by Nova due to"},{"line_number":218,"context_line":"the deprecation of the volume creation API. If a volume needs to allow"},{"line_number":219,"context_line":"multiple volume attachments it has to be created on the Cinder side with"},{"line_number":220,"context_line":"the needed properties specified."},{"line_number":221,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_d42536ae","line":218,"range":{"start_line":218,"start_character":39,"end_line":218,"end_character":42},"in_reply_to":"fa69d971_1aef9bb1","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7256393c4f4d0e34eb854105b7f8aad0a56d51ae","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"It also needs to be outlined in the documentation that attaching a volume"},{"line_number":223,"context_line":"multiple times in read-write mode can cause data corruption, if not handled"},{"line_number":224,"context_line":"correctly. It is the users\u0027 responsibility to add some type of exclusion"},{"line_number":225,"context_line":"(at the file system or network file system layer) to prevent multiple writers"},{"line_number":226,"context_line":"from corrupting the data."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_5a519361","line":226,"range":{"start_line":224,"start_character":11,"end_line":226,"end_character":25},"updated":"2016-01-08 02:44:25.000000000","message":"Are there documented examples/references/recommendations on how to do this?","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"It also needs to be outlined in the documentation that attaching a volume"},{"line_number":223,"context_line":"multiple times in read-write mode can cause data corruption, if not handled"},{"line_number":224,"context_line":"correctly. It is the users\u0027 responsibility to add some type of exclusion"},{"line_number":225,"context_line":"(at the file system or network file system layer) to prevent multiple writers"},{"line_number":226,"context_line":"from corrupting the data."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_345db215","line":226,"range":{"start_line":224,"start_character":11,"end_line":226,"end_character":25},"in_reply_to":"fa69d971_5a519361","updated":"2016-01-08 10:25:48.000000000","message":"I will add a note here that it should be provided if possible.","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5b916be1ec96512472d63813fccb00bcf45847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa69d971_c6b5be31","line":234,"updated":"2016-01-07 21:57:10.000000000","message":"Can you add the History section here which was missing from the original version of the spec? The History is how we document amendments.\n\nhttp://git.openstack.org/cgit/openstack/nova-specs/tree/specs/mitaka-template.rst#n384","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eeea4da488cc34e598869a90203208f05feffb72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa69d971_94825ec7","line":234,"in_reply_to":"fa69d971_c6b5be31","updated":"2016-01-08 10:25:48.000000000","message":"Done","commit_id":"0df72d90f3d484783b38e386f1d34c82a2c85fde"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"98a87bd1d67b411bb623146312b56265f9033dfa","unresolved":false,"context_lines":[{"line_number":127,"context_line":"For cases, where Nova creates the volume itself, i.e. source_type is"},{"line_number":128,"context_line":"blank/image/snapshot, it should not enable multi-attach for the volume for now."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The desired REST API changes are listed in a follow up spec."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa69d971_2351e4d8","line":130,"updated":"2016-01-08 15:10:15.000000000","message":"Nit: s/The/More/","commit_id":"979515a9f6b902fd063ae480b14d5c1ebbd996ed"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"bb7bac580169d435e44c438d6a030231b83c8cf3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"For cases, where Nova creates the volume itself, i.e. source_type is"},{"line_number":128,"context_line":"blank/image/snapshot, it should not enable multi-attach for the volume for now."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The desired REST API changes are listed in a follow up spec."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa69d971_3a6ee296","line":130,"in_reply_to":"fa69d971_2351e4d8","updated":"2016-01-08 17:05:00.000000000","message":"Done","commit_id":"979515a9f6b902fd063ae480b14d5c1ebbd996ed"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"98a87bd1d67b411bb623146312b56265f9033dfa","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Other deployer impact"},{"line_number":162,"context_line":"---------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"The \u0027shareable\u0027 flag is supported from Libvirt 1.2.2 properly therefore the"},{"line_number":165,"context_line":"multi-attach support in Nova needs to be limited to this version or above."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa69d971_e3150c9b","line":164,"updated":"2016-01-08 15:10:15.000000000","message":"Nit: s/properly//","commit_id":"979515a9f6b902fd063ae480b14d5c1ebbd996ed"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"9f72043f110c255ba321ee79075d7dcc3fdb5506","unresolved":false,"context_lines":[{"line_number":162,"context_line":"---------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"The \u0027shareable\u0027 flag is supported from Libvirt 1.2.2 properly therefore the"},{"line_number":165,"context_line":"multi-attach support in Nova needs to be limited to this version or above."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Developer impact"},{"line_number":168,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa69d971_955ec7e7","line":165,"range":{"start_line":165,"start_character":13,"end_line":165,"end_character":20},"updated":"2016-01-08 15:17:15.000000000","message":"Where does this 1.2.2 version come from ?!??! The \u003cshareable/\u003e flag has existed in libvirt for the entire lifetime of QEMU driver, so there\u0027s no version dependency for this feature.","commit_id":"979515a9f6b902fd063ae480b14d5c1ebbd996ed"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"bb7bac580169d435e44c438d6a030231b83c8cf3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"---------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"The \u0027shareable\u0027 flag is supported from Libvirt 1.2.2 properly therefore the"},{"line_number":165,"context_line":"multi-attach support in Nova needs to be limited to this version or above."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Developer impact"},{"line_number":168,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa69d971_fa15aae4","line":165,"range":{"start_line":165,"start_character":13,"end_line":165,"end_character":20},"in_reply_to":"fa69d971_955ec7e7","updated":"2016-01-08 17:05:00.000000000","message":"Happily removed. Thank you very much for the info!","commit_id":"979515a9f6b902fd063ae480b14d5c1ebbd996ed"}]}