)]}'
{"specs/newton/approved/servers-by-host-status.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0147abbee9871848fc55b830dcc7f862891cedac","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        ]"},{"line_number":92,"context_line":"    }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"In case host_status filter is not matching to allowed values: \"UP\", \"DOWN\","},{"line_number":95,"context_line":"\"MAINTENANCE\", \"UNKNOWN\" or \"\", it will cause error::"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    {\"badRequest\": {\"message\": \"Invalid host_status filter, \"code\": 400}}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Security impact"},{"line_number":100,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7af24918_c52677cd","line":97,"range":{"start_line":94,"start_character":0,"end_line":97,"end_character":73},"updated":"2016-03-02 19:57:21.000000000","message":"I didn\u0027t see this kind of behavior on nova APIs.\nFor example, \"get a list of servers\" API returns empty list if status filter is invalid:\n\n nova/api/openstack/compute/servers.py\n 312         search_opts.pop(\u0027status\u0027, None)\n 313         if \u0027status\u0027 in req.GET.keys():\n 314             statuses \u003d req.GET.getall(\u0027status\u0027)\n 315             states \u003d common.task_and_vm_state_from_status(statuses)\n 316             vm_state, task_state \u003d states\n 317             if not vm_state and not task_state:\n 318                 return {\u0027servers\u0027: []}  \u003c\u003cHERE\u003e\u003e\n\nThe current above behavior seems reasonable for me, because that seems there is not any servers which are matched on the filter.\n\nSo we can remove this lines or clarify to return empty list on this case.","commit_id":"1fac184c1984999fb9f7eefd59199dfcd9cab5e9"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"01ddb05190002920ee1afc395c5cbbfbf53b1029","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        ]"},{"line_number":92,"context_line":"    }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"In case host_status filter is not matching to allowed values: \"UP\", \"DOWN\","},{"line_number":95,"context_line":"\"MAINTENANCE\", \"UNKNOWN\" or \"\", it will cause error::"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    {\"badRequest\": {\"message\": \"Invalid host_status filter, \"code\": 400}}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Security impact"},{"line_number":100,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7af24918_6bebdb13","line":97,"range":{"start_line":94,"start_character":0,"end_line":97,"end_character":73},"in_reply_to":"7af24918_c52677cd","updated":"2016-03-03 06:33:17.000000000","message":"Thanks Ken\u0027ichi. I change spec accordingly.","commit_id":"1fac184c1984999fb9f7eefd59199dfcd9cab5e9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"485bc1f1b17093404cef0f49d2da00612107ee13","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Admin or if in some deployment the default policy is changed also owner of"},{"line_number":20,"context_line":"server wants to query his servers to get servers that has host in specific"},{"line_number":21,"context_line":"state. Currently one get all the servers as there is no filtering implemented"},{"line_number":22,"context_line":"to get by a specific host state."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a061dce_675595c4","line":19,"range":{"start_line":19,"start_character":43,"end_line":19,"end_character":49},"updated":"2016-04-07 12:18:36.000000000","message":"how do we distinguish general user with/without this capability? through policy?","commit_id":"b10485532b42f528384105bb5dc8728a8aa21fce"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0f64a4833390bb0ec5d6a1090df81c731ab62ccc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Admin or if in some deployment the default policy is changed also owner of"},{"line_number":20,"context_line":"server wants to query his servers to get servers that has host in specific"},{"line_number":21,"context_line":"state. Currently one get all the servers as there is no filtering implemented"},{"line_number":22,"context_line":"to get by a specific host state."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_411113ac","line":19,"range":{"start_line":19,"start_character":43,"end_line":19,"end_character":49},"in_reply_to":"9a061dce_477cd1b4","updated":"2016-04-11 12:20:02.000000000","message":"ok, found it ,added at v2.16, thanks!","commit_id":"b10485532b42f528384105bb5dc8728a8aa21fce"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"d2761b8d20d7765bc1d3365806e4187f0f7fbbd2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Admin or if in some deployment the default policy is changed also owner of"},{"line_number":20,"context_line":"server wants to query his servers to get servers that has host in specific"},{"line_number":21,"context_line":"state. Currently one get all the servers as there is no filtering implemented"},{"line_number":22,"context_line":"to get by a specific host state."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a061dce_477cd1b4","line":19,"range":{"start_line":19,"start_character":43,"end_line":19,"end_character":49},"in_reply_to":"9a061dce_675595c4","updated":"2016-04-07 12:27:37.000000000","message":"host_status is already having a policy. By default it is \"os_compute_api:servers:show:host_status\": \"rule:admin_api\", but in Telco case should be configured \"rule:admin_or_owner\".","commit_id":"b10485532b42f528384105bb5dc8728a8aa21fce"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dd96b140bd6256b1322d5322e429c6014b710217","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_b81bf6c9","line":50,"updated":"2016-05-02 15:11:57.000000000","message":"There will be some impact to the data model, at least in terms of access, right? In this section, can you describe the changes you will make to the SQLA API?","commit_id":"b10485532b42f528384105bb5dc8728a8aa21fce"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"9be5932baa7d95a70c22bee5fc7e0aaa65975c58","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_0fabafd7","line":50,"in_reply_to":"1a122d0e_2c4af927","updated":"2016-05-03 06:38:46.000000000","message":"Seems I actually thought this already when made this. So one just cannot filter on DB level as because the SG driver. Cannot first filter by service_disabled or forced_down and then result is already onyl those and cannot anymore filter by SG driver. Meaning only way to filter is at the end when host_status is fully formed.","commit_id":"b10485532b42f528384105bb5dc8728a8aa21fce"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"f37e025ce7a03a9b3d22e9ae59af61eae07d6b6a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_2c4af927","line":50,"in_reply_to":"1a122d0e_b81bf6c9","updated":"2016-05-03 06:11:25.000000000","message":"host_status is only known when it is fully build. Meaning you kind of can only filter it from the results in extended_server_attributes.py. Anyhow now thinking it: UP and UNKNOWN comes from SG driver at the end. DOWN is overriding that and MAINTENANCE is finally overriding that. Meaning while one has not build host_status, one could filter service_disabled or forced_down on DB level, but the implementation might get quite interesting as given host_status filter would need translation to service_disabled or forced_down before filtering in DB. Finally one would still filter by SG driver when building the result.","commit_id":"b10485532b42f528384105bb5dc8728a8aa21fce"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dd96b140bd6256b1322d5322e429c6014b710217","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Performance Impact"},{"line_number":117,"context_line":"------------------"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Other deployer impact"},{"line_number":122,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_588102c3","line":119,"updated":"2016-05-02 15:11:57.000000000","message":"This could be a large performance impact, depending on how it\u0027s queried. Can you go into detail here about how this is not going to be an issue?","commit_id":"b10485532b42f528384105bb5dc8728a8aa21fce"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"f37e025ce7a03a9b3d22e9ae59af61eae07d6b6a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Performance Impact"},{"line_number":117,"context_line":"------------------"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Other deployer impact"},{"line_number":122,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_8c618dab","line":119,"in_reply_to":"1a122d0e_588102c3","updated":"2016-05-03 06:11:25.000000000","message":"Same thing as above. Performance the same as without filter if not going to do some tweaking mentioned in comment on line 50.","commit_id":"b10485532b42f528384105bb5dc8728a8aa21fce"}]}
