)]}'
{"specs/newton/approved/sched-with-device-capabilities.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a362a923e8d420c07e403b9b25635a49cfefdaa4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This make it very hard to add additional device and capabilities."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This blueprint address the qualitative (i.e capabilities) part of the request"},{"line_number":39,"context_line":"spec and how to easily extend nova for adding new device with capabilities."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_b1c52c8f","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":75},"updated":"2016-05-26 15:42:10.000000000","message":"While I think it\u0027s a good start point, I wonder if we should rather first discuss on the abstractions rather how to use them, ie. having https://review.openstack.org/309762 as a dependency here.","commit_id":"e985da1c64b3e44b4c320f2a972d9a8dfca95ab5"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"cc234c4ed1565b22619c271bcefe03c8830d9bc6","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This make it very hard to add additional device and capabilities."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This blueprint address the qualitative (i.e capabilities) part of the request"},{"line_number":39,"context_line":"spec and how to easily extend nova for adding new device with capabilities."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9abb7d3a_deafc992","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":75},"in_reply_to":"bab6814e_b1c52c8f","updated":"2016-05-27 08:06:11.000000000","message":"I agree with you. I will update the spec once I understand the direction of Standardize capabilities spec","commit_id":"e985da1c64b3e44b4c320f2a972d9a8dfca95ab5"}],"specs/newton/approved/sched-with-nic-capabilities.rst":[{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"booted on a hypervisor with special capabilities as described above."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently nova compute is not aware of the capabilities attributes of the"},{"line_number":23,"context_line":"network adapters on its compute nodes, so it doesn\u0027t consider these attributes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_542dedfc","line":20,"updated":"2016-03-17 13:53:43.000000000","message":"The underline must be ~~~~~~ for second level headings.","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"23b7dc3b1ba4ded8c4b6a817ceca9e1cdb223250","unresolved":false,"context_lines":[{"line_number":17,"context_line":"booted on a hypervisor with special capabilities as described above."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently nova compute is not aware of the capabilities attributes of the"},{"line_number":23,"context_line":"network adapters on its compute nodes, so it doesn\u0027t consider these attributes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_d76f3f29","line":20,"in_reply_to":"1af94dfe_542dedfc","updated":"2016-03-21 16:05:53.000000000","message":"No, this is correct as it is. This formatting is what is in specs/newton-template.rst which people must follow.","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   or link speed."},{"line_number":31,"context_line":"2. A guest running RDMA Application requires NIC with RDMA capability."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Project Priority"},{"line_number":34,"context_line":"-----------------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_977ad775","line":33,"updated":"2016-03-17 13:53:43.000000000","message":"Priority must be priority","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"23b7dc3b1ba4ded8c4b6a817ceca9e1cdb223250","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   or link speed."},{"line_number":31,"context_line":"2. A guest running RDMA Application requires NIC with RDMA capability."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Project Priority"},{"line_number":34,"context_line":"-----------------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_f7723b10","line":33,"in_reply_to":"1af94dfe_977ad775","updated":"2016-03-21 16:05:53.000000000","message":"The project priority section should not even exist. It was removed from the template","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The change focuses on scheduling with MACVTAP/DIRECT port as in this case"},{"line_number":42,"context_line":"we already know the name of NIC (pci device) on the computes. In the future"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_141fe5b7","line":39,"updated":"2016-03-17 13:53:43.000000000","message":"ditto as in line 20","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"23b7dc3b1ba4ded8c4b6a817ceca9e1cdb223250","unresolved":false,"context_lines":[{"line_number":36,"context_line":"None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The change focuses on scheduling with MACVTAP/DIRECT port as in this case"},{"line_number":42,"context_line":"we already know the name of NIC (pci device) on the computes. In the future"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_d7561f5b","line":39,"in_reply_to":"1af94dfe_141fe5b7","updated":"2016-03-21 16:05:53.000000000","message":"No, this is correct as is","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"48f42cadddf884fa0c24f8b4d44a06fec4d6b861","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"link_speed\": \"10000\""},{"line_number":86,"context_line":"        \"parent\": \"0000:03:00.1\""},{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The user will set the guest image properties to request certain NIC"},{"line_number":91,"context_line":"capabilities. The properties in the image will be matched against NIC"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_34894176","line":88,"updated":"2016-03-17 13:40:01.000000000","message":"When I look to the future I have a hard time believing that we should add a column that is specific to one particular type of device. You happen to want some details about network interfaces. Tomorrow someone will want details about video devices to help with scheduling for vGPU assignment. Then someone will want details about TPM devices to assist in scheduling for secure boot. Then someone will want info about disk devices for picking SSD vs HDD. etc etc.\n\nNot to mention that we already have a bunch of info reported about PCI devices in this table, and there\u0027s no way to correlate info you\u0027re adding here with NICs that happen to be PCI devices.\n\nThis is all an example of why the libvirt APIs provided a generic way to retrieve information about devices in general.\n\nI rather feel like Nova needs to consider doing something similar rather than extending compute_nodes in an ad-hoc manner for each specific piece of information.\n\nIgnoring JSON, but considering object modelling, I could imagine something like\n\n   DeviceInfo\n     - capabilities: objects.ListOfDeviceCapability\n     - address: objects.DeviceAddress\n     - parent_address: objects.DeviceAddress\n\n\n   DeviceCapability\n    |\n    +- NetworkDeviceCapability\n    +     - link_speed\n    +- DiskDeviceCapability\n    +- VideoDeviceCapability\n    +- ... more subclasses for each device type we care about...\n\n   DeviceAddress\n    +- PCIDeviceAddress\n    +- USBDeviceAddress\n    +- SCSIDeviceAddress\n    +- .. more subclasses for other device address types...\n\nwhich is extensible to fully describe any aspect of any device on the compute node, and not tailored specifically to PCI device assignment, or to network device scheduling filters, or to another specific use case, but generically usable.","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6297ceee8e61742bd318c1b69406a3edb20a139d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"link_speed\": \"10000\""},{"line_number":86,"context_line":"        \"parent\": \"0000:03:00.1\""},{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The user will set the guest image properties to request certain NIC"},{"line_number":91,"context_line":"capabilities. The properties in the image will be matched against NIC"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_e34947d2","line":88,"in_reply_to":"1af94dfe_34894176","updated":"2016-03-21 15:10:22.000000000","message":"First, I think that your generic \"capabilities\" approach is the right way to go. We should not treat one device differently then another. So given this, I am trying to understand how to model your proposal in the database and here is what I came up with:\n\nwe can add a generic column called \"devices\" which will contain a JSON of device_type (network/disk/video) with a list of the ID of the devices for that type.\n\nFor example for a host with two NICs, two Disks and one graphics card we will have:\n{\n\t\"network\": [\"net1_id\", \"net2_id\"],\n\t\"disk\": [\"disk1_id\", \"disk2_id\"],\n\t\"video\": [\"video1_id\"]\n}\n\n\nNow, each device type will be represented in a separate table. For instance, there will be one network_capability table that will contain ALL the NICs in the all the compute nodes. Each line in this table will be of the form:\n\u003cid, device_vendor, link_speed, gso, tso, rmda,..., constrains \u003e\n\nI have added, for future reference, a column named \"constrains\". This column will hold special constrains on the capability (e.g. some NIC capabilities can\u0027t work with others for example CX3 card can\u0027t provide rdma and tx-udp_tnl-segmentation concurrently) so that in the future the scheduler can take these constrains into account.\n\ndisk_capability table:\n...\n\nvideo_capability table:\n...\n\n\n\nRegarding your pci comment: In my current spec I am saving the pci_address of the net device so there is no problem to look in the pci_devices table and get the exta info. \n\nNote that there are some capabilities that we have already exposed, e.g. VF/PF, through another table (pci_devices) and if we go with the generic capabilities approach above, we will probably need to move these capabilities to their new \"home\" - e.g. PF/VF capabilities will move to network capabilities.","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"48f42cadddf884fa0c24f8b4d44a06fec4d6b861","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"E.g"},{"line_number":95,"context_line":"    My image needs tx-checksum, rx-checksum and tcp segmentation offloads."},{"line_number":96,"context_line":"    glance image-update \u003cIMAGE\u003e --property nic-caps\u003drx,tx,tso"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    My image needs RDMA and a 40G capable NIC."},{"line_number":99,"context_line":"    glance image-update \u003cIMAGE\u003e --property nic-caps\u003drdma,40000"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_d4745d69","line":96,"range":{"start_line":96,"start_character":58,"end_line":96,"end_character":61},"updated":"2016-03-17 13:40:01.000000000","message":"\u0027nic-caps\u0027 is not an acceptable property name - we have a number of defined prefixes that are permitted \u0027os_\u0027, \u0027img_\u0027 and \u0027hw_\u0027. This probably fits under \u0027img_\u0027.\n\nDoing this against the image though is openning a can of worms. eg if only a handful of compute nodes have 10-Gig-E network cards, you don\u0027t want any user to be able to force their guests onto 10-Gig-E nodes by simply setting an image property.\n\nIMHO this needs to be controlled via the flavour so the admin retains control over who uses finite hardware resources.","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6297ceee8e61742bd318c1b69406a3edb20a139d","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"E.g"},{"line_number":95,"context_line":"    My image needs tx-checksum, rx-checksum and tcp segmentation offloads."},{"line_number":96,"context_line":"    glance image-update \u003cIMAGE\u003e --property nic-caps\u003drx,tx,tso"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    My image needs RDMA and a 40G capable NIC."},{"line_number":99,"context_line":"    glance image-update \u003cIMAGE\u003e --property nic-caps\u003drdma,40000"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_56e9d019","line":96,"range":{"start_line":96,"start_character":58,"end_line":96,"end_character":61},"in_reply_to":"1af94dfe_d4745d69","updated":"2016-03-21 15:10:22.000000000","message":"Ok I will update the spec to be flavor and not image property","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"image via image properties."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Performance Impact"},{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"This feature will ensure that a guest with certain NIC capabilities will be"},{"line_number":146,"context_line":"scheduled on a compute node that provides these capabilities."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_34514137","line":143,"updated":"2016-03-17 13:53:43.000000000","message":"It must be \"impact\"","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"23b7dc3b1ba4ded8c4b6a817ceca9e1cdb223250","unresolved":false,"context_lines":[{"line_number":140,"context_line":"image via image properties."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Performance Impact"},{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"This feature will ensure that a guest with certain NIC capabilities will be"},{"line_number":146,"context_line":"scheduled on a compute node that provides these capabilities."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_57c96f25","line":143,"in_reply_to":"1af94dfe_34514137","updated":"2016-03-21 16:05:53.000000000","message":"No, this matches the template","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Implementation"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Assignee(s)"},{"line_number":163,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_948135c6","line":160,"updated":"2016-03-17 13:53:43.000000000","message":"ditto as in line 20","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"23b7dc3b1ba4ded8c4b6a817ceca9e1cdb223250","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Implementation"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Assignee(s)"},{"line_number":163,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_77d46bbc","line":160,"in_reply_to":"1af94dfe_948135c6","updated":"2016-03-21 16:05:53.000000000","message":"Again this matches the template","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  aviramb"},{"line_number":170,"context_line":"  lennyb"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Work Items"},{"line_number":173,"context_line":"----------"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Update Database migration with net_device column in compute_nodes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_574faf6a","line":172,"updated":"2016-03-17 13:53:43.000000000","message":"Items must be \"items\"","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"23b7dc3b1ba4ded8c4b6a817ceca9e1cdb223250","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  aviramb"},{"line_number":170,"context_line":"  lennyb"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Work Items"},{"line_number":173,"context_line":"----------"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Update Database migration with net_device column in compute_nodes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_b7da73e6","line":172,"in_reply_to":"1af94dfe_574faf6a","updated":"2016-03-21 16:05:53.000000000","message":"No, this matches the template. All your other comments are wrong for the same reason, so I won\u0027t continue commenting on each on.","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Dependencies"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"This feature depends on the extra functionality added to libvirt 1.2.18. See"},{"line_number":189,"context_line":"references section for more detail."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_1476c505","line":186,"updated":"2016-03-17 13:53:43.000000000","message":"ditto as in line 20","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Testing"},{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Unit Testing will be added for this feature."},{"line_number":196,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_745d8978","line":193,"updated":"2016-03-17 13:53:43.000000000","message":"dittoas in line 20","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Unit Testing will be added for this feature."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Documentation Impact"},{"line_number":198,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Documentation will be added to describe the use of nic-caps image property."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_14052513","line":197,"updated":"2016-03-17 13:53:43.000000000","message":"Impact must be \"impact\"","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Unit Testing will be added for this feature."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Documentation Impact"},{"line_number":198,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Documentation will be added to describe the use of nic-caps image property."},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_54c96d25","line":198,"updated":"2016-03-17 13:53:43.000000000","message":"dittoas in line 20","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"27bd07d898ae3fb89a8ff3a453555329fb4f356c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"Documentation will be added to describe the use of nic-caps image property."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"References"},{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"* http://www.mail-archive.com/libvir-list@redhat.com/msg103951.html"},{"line_number":206,"context_line":"* https://www.redhat.com/archives/libvir-list/2015-July/msg00793.html"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af94dfe_b4da71e6","line":203,"updated":"2016-03-17 13:53:43.000000000","message":"dittoas in line 20","commit_id":"3d73cb69ede1f0da4f4e3c1310932d1538c55f2d"}]}