)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bfa6f9ad82124dc5ab45f2fb941278722c01fdf9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"host capabilities. Details about it will be added"},{"line_number":16,"context_line":"later, after finding a proper way to do it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Previously-approved: Mitaka"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I24b4eb67f98dfe1a77c3e267086baf571ee49542"},{"line_number":21,"context_line":"Implements: blueprint expose-host-capabilities"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa0719c6_9bf4ddf2","line":18,"updated":"2016-03-22 21:26:19.000000000","message":"I think you should probably remove this given the changes. I think it\u0027s fine to point out the other spec was originally approved in mitaka, but now there are several changes so it should be re-assessed.","commit_id":"def7b62b34c21c62f52e0eeb60899c3089eddb68"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"c6a2d507e2bd808520e7429d160bd91700fd82b4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"host capabilities. Details about it will be added"},{"line_number":16,"context_line":"later, after finding a proper way to do it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Previously-approved: Mitaka"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I24b4eb67f98dfe1a77c3e267086baf571ee49542"},{"line_number":21,"context_line":"Implements: blueprint expose-host-capabilities"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_bcd740ec","line":18,"in_reply_to":"fa0719c6_9bf4ddf2","updated":"2016-04-13 07:59:30.000000000","message":"Done","commit_id":"def7b62b34c21c62f52e0eeb60899c3089eddb68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"04d5156ad57e3b32b2ec5a4ad323a437a29336bd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"later, after finding a proper way to do it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APIImpact"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I24b4eb67f98dfe1a77c3e267086baf571ee49542"},{"line_number":21,"context_line":"Implements: blueprint expose-host-capabilities"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_6ef405cf","line":19,"updated":"2016-05-01 23:13:50.000000000","message":"You need this in here:\n\nPreviously-approved: Mitaka\n\nThe specs team regularly checks for re-proposed specs since they are usually simple to fast approve, but since the tag wasn\u0027t on this one I missed it.","commit_id":"cffa6beb47d32ba2521c52f129d2bd11ff6e1051"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2a41738b315679f0104618c1c78ec5fb2e94c72a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"later, after finding a proper way to do it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APIImpact"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I24b4eb67f98dfe1a77c3e267086baf571ee49542"},{"line_number":21,"context_line":"Implements: blueprint expose-host-capabilities"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_d87ab376","line":19,"in_reply_to":"1a122d0e_6ef405cf","updated":"2016-05-10 10:41:01.000000000","message":"In the previous patchset, you said to remove it...","commit_id":"cffa6beb47d32ba2521c52f129d2bd11ff6e1051"}],"specs/newton/approved/expose-host-capabilities.rst":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"2f2172b0da7efbccc3e97230dfc09563016a854f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Also, the nova drivers will no longer report supported instance types as a"},{"line_number":103,"context_line":"resource, but as a host capability."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"A new filter will be implemented which will match the instance features"},{"line_number":106,"context_line":"requested with the host capabilities as previously described. It will only"},{"line_number":107,"context_line":"take into account fields defined in the ``HostCapabilities``. If a field in the"},{"line_number":108,"context_line":"``HostCapabilities`` instance has not been set, that capability will be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_e171bb77","line":105,"range":{"start_line":105,"start_character":6,"end_line":105,"end_character":12},"updated":"2016-04-14 13:02:01.000000000","message":"ImagePropertiesFilter can be reused as it\u0027s used before for arch, vm type etc filter or delete it per new host filter?","commit_id":"cffa6beb47d32ba2521c52f129d2bd11ff6e1051"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"2f2172b0da7efbccc3e97230dfc09563016a854f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"Drivers will have to implement the new ``get_host_capabilities`` method. It"},{"line_number":279,"context_line":"should return an instance of ``HostCapabilities``."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"In order for a new capability to be accepted in ``HostCapabilities``, a version"},{"line_number":282,"context_line":"increment for will be necessary."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_41acef8b","line":281,"range":{"start_line":281,"start_character":72,"end_line":281,"end_character":79},"updated":"2016-04-14 13:02:01.000000000","message":"microversion bump?","commit_id":"cffa6beb47d32ba2521c52f129d2bd11ff6e1051"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b983c75b42ad670422d6607d1b5b6ee74b51a7eb","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"In heterogenous deployments, instances requiring a certain subset of the"},{"line_number":61,"context_line":"available host capabilities will be easier to deploy, as they won\u0027t require"},{"line_number":62,"context_line":"a specific host aggregate that contains those capabilities."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Proposed change"},{"line_number":65,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_b203ea72","line":62,"updated":"2016-05-18 18:37:42.000000000","message":"These aren\u0027t really use cases. I would expect something more along the classic \"As a X, I want Y so that I can Z\".","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8a512f1fd22c4b2d0ca8713d9064309f56f0e25c","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"In heterogenous deployments, instances requiring a certain subset of the"},{"line_number":61,"context_line":"available host capabilities will be easier to deploy, as they won\u0027t require"},{"line_number":62,"context_line":"a specific host aggregate that contains those capabilities."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Proposed change"},{"line_number":65,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_fef9b8c9","line":62,"in_reply_to":"bab6814e_b203ea72","updated":"2016-05-18 21:26:30.000000000","message":"Sure.","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f402f45a33eb4eeb39903cde5b4010fcbe4e8fba","unresolved":false,"context_lines":[{"line_number":262,"context_line":"A new microversion will be required each time a *new* capability has been"},{"line_number":263,"context_line":"added to the ``HostCapabilities`` object, but not when a capability\u0027s set"},{"line_number":264,"context_line":"of values is extended. This has been decided during the Newton Design Summit."},{"line_number":265,"context_line":"[5]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Security impact"},{"line_number":268,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dab17558_54b0878b","line":265,"updated":"2016-05-13 16:29:06.000000000","message":"I\u0027ve said this at the Summit as well: I really don\u0027t like this idea. Adding a new nova-api microversion seems like an overkill to me, especially since adding one is not easy and it end up in merge conflict quite often, which then would require a non-trivial rebase.\n\nAlso, we could potentially have dozens of capabilities in the future, which will translate to dozens of microversions just for this.","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b983c75b42ad670422d6607d1b5b6ee74b51a7eb","unresolved":false,"context_lines":[{"line_number":262,"context_line":"A new microversion will be required each time a *new* capability has been"},{"line_number":263,"context_line":"added to the ``HostCapabilities`` object, but not when a capability\u0027s set"},{"line_number":264,"context_line":"of values is extended. This has been decided during the Newton Design Summit."},{"line_number":265,"context_line":"[5]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Security impact"},{"line_number":268,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_32041a16","line":265,"in_reply_to":"dab17558_54b0878b","updated":"2016-05-18 18:37:42.000000000","message":"Agree 100%. Any attempt to define these to N things will result in N+1 being proposed right away; hell, N+100 won\u0027t be far behind. This is a recipe for maintenance nightmares, as each new capability will have to be met with:\n\n- blueprint / spec (microversions *always* require specs)\n- code change / data migration\n- documentation change\n\nSo unless capabilities are granted magical snowflake priority, any changes to this will typically take a year to go from being released in hardware / virt software to being supported in Nova.","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b983c75b42ad670422d6607d1b5b6ee74b51a7eb","unresolved":false,"context_lines":[{"line_number":298,"context_line":"In order for a new capability to be accepted in ``HostCapabilities``, there"},{"line_number":299,"context_line":"are a couple of steps that have to be done:"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"* Define the new capability and its possible values."},{"line_number":302,"context_line":"* Add it to the ``HostCapabilities`` object model and increment the object"},{"line_number":303,"context_line":"  version."},{"line_number":304,"context_line":"* Add a new nova-api microversion to the ``os-hypervisors`` version."}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_0d429b3e","line":301,"updated":"2016-05-18 18:37:42.000000000","message":"This would be a spec, correct?","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8a512f1fd22c4b2d0ca8713d9064309f56f0e25c","unresolved":false,"context_lines":[{"line_number":298,"context_line":"In order for a new capability to be accepted in ``HostCapabilities``, there"},{"line_number":299,"context_line":"are a couple of steps that have to be done:"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"* Define the new capability and its possible values."},{"line_number":302,"context_line":"* Add it to the ``HostCapabilities`` object model and increment the object"},{"line_number":303,"context_line":"  version."},{"line_number":304,"context_line":"* Add a new nova-api microversion to the ``os-hypervisors`` version."}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_7e04a87d","line":301,"in_reply_to":"bab6814e_0d429b3e","updated":"2016-05-18 21:26:30.000000000","message":"Yep. AFAIK, any new fields added to an object requires a spec. If not, it is required for the nova-api microversion anyways.","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b983c75b42ad670422d6607d1b5b6ee74b51a7eb","unresolved":false,"context_lines":[{"line_number":301,"context_line":"* Define the new capability and its possible values."},{"line_number":302,"context_line":"* Add it to the ``HostCapabilities`` object model and increment the object"},{"line_number":303,"context_line":"  version."},{"line_number":304,"context_line":"* Add a new nova-api microversion to the ``os-hypervisors`` version."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"A nova-api microversion is not required if a capability\u0027s set of values has"},{"line_number":307,"context_line":"been extended. (e.g.: if the set of values for the capability ``foo``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_6d79a793","line":304,"updated":"2016-05-18 18:37:42.000000000","message":"Would this be another spec, or part of the same one?","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8a512f1fd22c4b2d0ca8713d9064309f56f0e25c","unresolved":false,"context_lines":[{"line_number":301,"context_line":"* Define the new capability and its possible values."},{"line_number":302,"context_line":"* Add it to the ``HostCapabilities`` object model and increment the object"},{"line_number":303,"context_line":"  version."},{"line_number":304,"context_line":"* Add a new nova-api microversion to the ``os-hypervisors`` version."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"A nova-api microversion is not required if a capability\u0027s set of values has"},{"line_number":307,"context_line":"been extended. (e.g.: if the set of values for the capability ``foo``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_de3cb431","line":304,"in_reply_to":"bab6814e_6d79a793","updated":"2016-05-18 21:26:30.000000000","message":"I suggest it to be part of the same one. I see no reason to split the spec in two, since the spec will talk about the new capability, why it\u0027s added and what it is used for. It would just add review overhead.","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b983c75b42ad670422d6607d1b5b6ee74b51a7eb","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"A nova-api microversion is not required if a capability\u0027s set of values has"},{"line_number":307,"context_line":"been extended. (e.g.: if the set of values for the capability ``foo``"},{"line_number":308,"context_line":"has been extended from ``[\u0027bar1\u0027, \u0027bar2\u0027]`` to ``[\u0027bar1\u0027, \u0027bar2\u0027, \u0027bar3\u0027]``)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"Implementation"},{"line_number":311,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_2db79f3a","line":308,"updated":"2016-05-18 18:37:42.000000000","message":"So this means that a request for `foo\u003dbar3` would return a 400 one day and a 200 the next? That sure seems like an API change to me.","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8a512f1fd22c4b2d0ca8713d9064309f56f0e25c","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"A nova-api microversion is not required if a capability\u0027s set of values has"},{"line_number":307,"context_line":"been extended. (e.g.: if the set of values for the capability ``foo``"},{"line_number":308,"context_line":"has been extended from ``[\u0027bar1\u0027, \u0027bar2\u0027]`` to ``[\u0027bar1\u0027, \u0027bar2\u0027, \u0027bar3\u0027]``)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"Implementation"},{"line_number":311,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_1e2d9ca7","line":308,"in_reply_to":"bab6814e_2db79f3a","updated":"2016-05-18 21:26:30.000000000","message":"Yeah, there\u0027s been a discussion about this at the summit. Check [6]. They decided that it isn\u0027t. But if it is, then this would then require a microversion as well. It\u0027s already an overkill having to add a microversion for each new capability, it would be an over-overkill if we have to add a microversion for a new capability value.\n\nAlso, if I\u0027m not mistaken, adding a new item in the Enum won\u0027t require an object version increment either.","commit_id":"56da6eb3492be5cc1f0eb1641cb6d7735781f572"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"c5d6023dadabb2f31392372cba125160ead75494","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* ``capabilities``. This table contains all the currently defined capabilities."},{"line_number":166,"context_line":"  Enumerating these capabilities and their value is being done in another spec"},{"line_number":167,"context_line":"  (see *Dependency* section). This table contains the following columns:"},{"line_number":168,"context_line":"  ``id`` and ``capability_name``."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* ``provider_capabilities``. This table represents the mapping between"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_c903e00e","line":167,"range":{"start_line":167,"start_character":3,"end_line":167,"end_character":27},"updated":"2016-05-26 19:29:47.000000000","message":"I don\u0027t see that section :)","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8c0e003e3b8c210e8aeb2a63ad1fe895d12fd296","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* ``capabilities``. This table contains all the currently defined capabilities."},{"line_number":166,"context_line":"  Enumerating these capabilities and their value is being done in another spec"},{"line_number":167,"context_line":"  (see *Dependency* section). This table contains the following columns:"},{"line_number":168,"context_line":"  ``id`` and ``capability_name``."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* ``provider_capabilities``. This table represents the mapping between"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_153debc3","line":167,"range":{"start_line":167,"start_character":3,"end_line":167,"end_character":27},"in_reply_to":"bab6814e_c903e00e","updated":"2016-05-27 03:17:43.000000000","message":"Done","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"c5d6023dadabb2f31392372cba125160ead75494","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"New database models will have to be added for the new tables."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"New ``HostCapabilities`` object will be added, containing all the capabilities"},{"line_number":179,"context_line":"currently acceptable by Nova. If any of the object\u0027s fields is not set, then"},{"line_number":180,"context_line":"that capability will be considered as not present."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"The ``supported_instances`` column will be dropped from the ``compute_nodes``"},{"line_number":183,"context_line":"database model and table, and coresponding object model."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_24df313b","line":180,"range":{"start_line":178,"start_character":0,"end_line":180,"end_character":50},"updated":"2016-05-26 19:29:47.000000000","message":"So any new capability will have to be proposed as a Nova code change, and wait for at least one cycle before it can be used? In other words, no possibility of dynamic capabilities?","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8c0e003e3b8c210e8aeb2a63ad1fe895d12fd296","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"New database models will have to be added for the new tables."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"New ``HostCapabilities`` object will be added, containing all the capabilities"},{"line_number":179,"context_line":"currently acceptable by Nova. If any of the object\u0027s fields is not set, then"},{"line_number":180,"context_line":"that capability will be considered as not present."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"The ``supported_instances`` column will be dropped from the ``compute_nodes``"},{"line_number":183,"context_line":"database model and table, and coresponding object model."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9abb7d3a_6fb9d12e","line":180,"range":{"start_line":178,"start_character":0,"end_line":180,"end_character":50},"in_reply_to":"bab6814e_24df313b","updated":"2016-05-27 03:17:43.000000000","message":"Yep.\n\nWell, first of all, a good chunk of those capabilities are requested via image metadata properties, which are standardized and object-ized. So, this already requires Nova code change and one cycle before it can be used.\n\nFor flavor extra_spec, I wouldn\u0027t be surprised if one day it will become an object as well. It seems that the general direction of Nova is towards standardization and objectifying everything.\n\nSecondly, in order for a compute node to report that new capability, it will require some Nova code change (e.g.: check if it\u0027s available, set the appropriate value(s) to the right field in the HostCapabilities object).\n\nPlus, in order to actually use that capability, it will probably require some code written in one of the drivers.\n\nThirdly, for each capability you have define something like a matching rule for the scheduler: when can you consider that a host X can satisfy a requested capability ``foo``?\n\nAlso, some Nova cores will probably dislike the idea of having compute nodes reporting bizzare capabilities that they don\u0027t know anything about.\n\nI could go on. :)","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"c5d6023dadabb2f31392372cba125160ead75494","unresolved":false,"context_lines":[{"line_number":205,"context_line":"              \"state\": \"up\","},{"line_number":206,"context_line":"              \"disk_available_least\": 0,"},{"line_number":207,"context_line":"              \"host_ip\": \"1.1.1.1\","},{"line_number":208,"context_line":"              \"host_capabilities\": {\"hw_machine_type\": [\"fake_type_1\", \"fake_type_2\"]},"},{"line_number":209,"context_line":"              \"free_disk_gb\": 1028,"},{"line_number":210,"context_line":"              \"free_ram_mb\": 7680,"},{"line_number":211,"context_line":"              \"hypervisor_hostname\": \"fake-mini\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_e4a089f6","line":208,"range":{"start_line":208,"start_character":15,"end_line":208,"end_character":32},"updated":"2016-05-26 19:29:47.000000000","message":"So is the only change to the response (here and below) adding this key, with a JSON dict blob as the value? You might want to state that clearly, as it\u0027s hard to see a diff with the current return value.","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8c0e003e3b8c210e8aeb2a63ad1fe895d12fd296","unresolved":false,"context_lines":[{"line_number":205,"context_line":"              \"state\": \"up\","},{"line_number":206,"context_line":"              \"disk_available_least\": 0,"},{"line_number":207,"context_line":"              \"host_ip\": \"1.1.1.1\","},{"line_number":208,"context_line":"              \"host_capabilities\": {\"hw_machine_type\": [\"fake_type_1\", \"fake_type_2\"]},"},{"line_number":209,"context_line":"              \"free_disk_gb\": 1028,"},{"line_number":210,"context_line":"              \"free_ram_mb\": 7680,"},{"line_number":211,"context_line":"              \"hypervisor_hostname\": \"fake-mini\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_2229d7e6","line":208,"range":{"start_line":208,"start_character":15,"end_line":208,"end_character":32},"in_reply_to":"bab6814e_e4a089f6","updated":"2016-05-27 03:17:43.000000000","message":"yep, makes sense.","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"c5d6023dadabb2f31392372cba125160ead75494","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"The new scheduler filter and the host capabilities that can be scheduled using"},{"line_number":351,"context_line":"the new filter will have to be documented."},{"line_number":352,"context_line":"The new config option group ``host_capabilities`` will have to be documented."},{"line_number":353,"context_line":"The new nova API microversion will have to be documented."},{"line_number":354,"context_line":"The deployer impact will have to be documented."},{"line_number":355,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_247e116a","line":352,"range":{"start_line":352,"start_character":4,"end_line":352,"end_character":27},"updated":"2016-05-26 19:29:47.000000000","message":"What config options are being proposed?","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8c0e003e3b8c210e8aeb2a63ad1fe895d12fd296","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"The new scheduler filter and the host capabilities that can be scheduled using"},{"line_number":351,"context_line":"the new filter will have to be documented."},{"line_number":352,"context_line":"The new config option group ``host_capabilities`` will have to be documented."},{"line_number":353,"context_line":"The new nova API microversion will have to be documented."},{"line_number":354,"context_line":"The deployer impact will have to be documented."},{"line_number":355,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_42717b0b","line":352,"range":{"start_line":352,"start_character":4,"end_line":352,"end_character":27},"in_reply_to":"bab6814e_247e116a","updated":"2016-05-27 03:17:43.000000000","message":"sorry, this was proposed on an older PS, but it was removed. It seems that I forgot about this line.","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"c5d6023dadabb2f31392372cba125160ead75494","unresolved":false,"context_lines":[{"line_number":351,"context_line":"the new filter will have to be documented."},{"line_number":352,"context_line":"The new config option group ``host_capabilities`` will have to be documented."},{"line_number":353,"context_line":"The new nova API microversion will have to be documented."},{"line_number":354,"context_line":"The deployer impact will have to be documented."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_24cc51ba","line":354,"range":{"start_line":354,"start_character":4,"end_line":354,"end_character":19},"updated":"2016-05-26 19:29:47.000000000","message":"You state above that there is no deployer impact. So what needs to be documented here? Or did you mean \u0027developer impact\u0027?","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8c0e003e3b8c210e8aeb2a63ad1fe895d12fd296","unresolved":false,"context_lines":[{"line_number":351,"context_line":"the new filter will have to be documented."},{"line_number":352,"context_line":"The new config option group ``host_capabilities`` will have to be documented."},{"line_number":353,"context_line":"The new nova API microversion will have to be documented."},{"line_number":354,"context_line":"The deployer impact will have to be documented."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_551c9369","line":354,"range":{"start_line":354,"start_character":4,"end_line":354,"end_character":19},"in_reply_to":"bab6814e_24cc51ba","updated":"2016-05-27 03:17:43.000000000","message":"good catch.\n\nThere used to be a deployer impact before, but reviewers suggested to remove it.\n\nhttps://review.openstack.org/#/c/222200/5/specs/mitaka/approved/expose-host-capabilities.rst","commit_id":"2e17f8381392fe2e3144731236e484ac28d20806"}]}