)]}'
{"specs/newton/approved/support-list-locked-instances.rst":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4fca23eadf5b254129405db9e1b888ccab04339b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"it will take forever to check one by one to find out all the locked instances."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"As an admin, if I can list all locked instances in one call, life will be"},{"line_number":35,"context_line":"much easier."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa0719c6_4388f3e7","line":35,"updated":"2016-03-21 12:31:30.000000000","message":"Please explain a real world situation where this is needed. Locked is used in very specific cases.","commit_id":"a97d0ba1cd0502744acc8086200a59d09e1125f9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4fca23eadf5b254129405db9e1b888ccab04339b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    * /v2.1/servers/detail?locked\u003dtrue:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Request method:"},{"line_number":63,"context_line":"    * GET"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa0719c6_23605f35","line":63,"updated":"2016-03-21 12:31:30.000000000","message":"Requires a microversion","commit_id":"a97d0ba1cd0502744acc8086200a59d09e1125f9"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"ab183510aa3f225d59d5150d4a1ef3b6f36b4e7f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    * /v2.1/servers/detail?locked\u003dtrue:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Request method:"},{"line_number":63,"context_line":"    * GET"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Security impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa0719c6_c2569ad1","line":63,"in_reply_to":"fa0719c6_23605f35","updated":"2016-03-22 01:45:50.000000000","message":"Done","commit_id":"a97d0ba1cd0502744acc8086200a59d09e1125f9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"48eb3f8a10ba1e988e997d0e6858b262d0733de5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"As in large scale deployment, a large number of instances may be locked"},{"line_number":31,"context_line":"due to various reasons, we have to unlock them before perform other options,"},{"line_number":32,"context_line":"it will take forever to check one by one to find out all the locked instances."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"As an admin, I may have to lock all the instances on one host before"},{"line_number":35,"context_line":"performing maintenance operations, such as upgrade; in this kind of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_aec72111","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":20},"updated":"2016-04-05 02:28:02.000000000","message":"nit: s/forever/long time/","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"024da661aa6632fe7d7a2a3889ef6b18d91ed23e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"ACTIVE, so we don\u0027t want the instances to be able to perform any"},{"line_number":38,"context_line":"actions that can cause trouble. Currently, I have to show all the"},{"line_number":39,"context_line":"instances one by one to check whether all of them are locked, if"},{"line_number":40,"context_line":"I can list all locked instances in one call, life will be much easier."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As a user, I may want to lock some of my instances to prevent them from"},{"line_number":43,"context_line":"accidental changes, it will be much better if I can check all my locked"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_0c08c090","line":40,"updated":"2016-03-22 08:47:16.000000000","message":"Emm....there is flaw with this process. If an instance was already locked by owner, then admin lock the instance again, the lock_by will update to admin. Then admin unlock all the locked instance, finally the owner\u0027s lock will disappear. I need think about if there is better way.","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"4715c8a7db66a5f98d4631004c5bce86bbfb4955","unresolved":false,"context_lines":[{"line_number":37,"context_line":"ACTIVE, so we don\u0027t want the instances to be able to perform any"},{"line_number":38,"context_line":"actions that can cause trouble. Currently, I have to show all the"},{"line_number":39,"context_line":"instances one by one to check whether all of them are locked, if"},{"line_number":40,"context_line":"I can list all locked instances in one call, life will be much easier."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As a user, I may want to lock some of my instances to prevent them from"},{"line_number":43,"context_line":"accidental changes, it will be much better if I can check all my locked"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_2cbdc468","line":40,"in_reply_to":"fa0719c6_0c08c090","updated":"2016-03-22 08:51:59.000000000","message":"Hi, this patch aims to add a \u0027locked\u0027 filter for list API for users, not on the lock logic itself, if this is not added, the problem can still happen.","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"e35c3c7b8519758fd1daf86f2829a35fb1638f8a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"ACTIVE, so we don\u0027t want the instances to be able to perform any"},{"line_number":38,"context_line":"actions that can cause trouble. Currently, I have to show all the"},{"line_number":39,"context_line":"instances one by one to check whether all of them are locked, if"},{"line_number":40,"context_line":"I can list all locked instances in one call, life will be much easier."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As a user, I may want to lock some of my instances to prevent them from"},{"line_number":43,"context_line":"accidental changes, it will be much better if I can check all my locked"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_dfbaec22","line":40,"in_reply_to":"fa0719c6_2cbdc468","updated":"2016-03-22 08:58:57.000000000","message":"Maybe you are talking about a bug for lock itself? For your problem, I think it is OK, the admin\u0027s authority is higher than normal user, they can do options as you mentioned.","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"3407a1bc620de4cbc4fda93bcea0a3a2c5f3fb74","unresolved":false,"context_lines":[{"line_number":37,"context_line":"ACTIVE, so we don\u0027t want the instances to be able to perform any"},{"line_number":38,"context_line":"actions that can cause trouble. Currently, I have to show all the"},{"line_number":39,"context_line":"instances one by one to check whether all of them are locked, if"},{"line_number":40,"context_line":"I can list all locked instances in one call, life will be much easier."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As a user, I may want to lock some of my instances to prevent them from"},{"line_number":43,"context_line":"accidental changes, it will be much better if I can check all my locked"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_309232a0","line":40,"in_reply_to":"fa0719c6_53ced3b4","updated":"2016-03-22 10:57:26.000000000","message":"Yes, I see, I think maybe admin can have that kind of authority.","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"98df01a6359bc9c72fb50af4fae5279f9a35655f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"ACTIVE, so we don\u0027t want the instances to be able to perform any"},{"line_number":38,"context_line":"actions that can cause trouble. Currently, I have to show all the"},{"line_number":39,"context_line":"instances one by one to check whether all of them are locked, if"},{"line_number":40,"context_line":"I can list all locked instances in one call, life will be much easier."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As a user, I may want to lock some of my instances to prevent them from"},{"line_number":43,"context_line":"accidental changes, it will be much better if I can check all my locked"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_53ced3b4","line":40,"in_reply_to":"fa0719c6_dfbaec22","updated":"2016-03-22 10:15:09.000000000","message":"Zhengyu, I try to think about the whole story of user how to use lock API. Try to find a good design for user use our API conveniently","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"48eb3f8a10ba1e988e997d0e6858b262d0733de5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Add a new microversion to support for ``locked`` filter when"},{"line_number":50,"context_line":"calling ``List`` API."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_8ef33d73","line":50,"range":{"start_line":50,"start_character":10,"end_line":50,"end_character":14},"updated":"2016-04-05 02:28:02.000000000","message":"s/List/List servers/","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"48eb3f8a10ba1e988e997d0e6858b262d0733de5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"---------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* URL:"},{"line_number":69,"context_line":"    * /v2.1/servers/detail?locked\u003dtrue:"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Request method:"},{"line_number":72,"context_line":"    * GET"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_2eb15190","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":39},"updated":"2016-04-05 02:28:02.000000000","message":"Is it fine that this filter works only for /v2.1/servers/detail or /v2.1/servers also?\n\nIf this works for /v2.1/servers also, it is easy to get list of locked servers without a plenty of response data.","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"48eb3f8a10ba1e988e997d0e6858b262d0733de5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"* Request method:"},{"line_number":72,"context_line":"    * GET"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* API microversion:"},{"line_number":75,"context_line":"    * X-OpenStack-Nova-API-Version: 2.26"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Security impact"},{"line_number":78,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_0e00cd33","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":40},"updated":"2016-04-05 02:28:02.000000000","message":"We cannot promise actual microversion number because the development is race.\nSo it is fine here if just\n\n * Require a new microversion\n\nor something.","commit_id":"2f3b6b6230a763cba7df7d97fbaa8408782e03e5"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"bb533401006fbdb78ffdbc0afac7c84ae5f93173","unresolved":false,"context_lines":[{"line_number":31,"context_line":"due to various reasons, we have to unlock them before perform other options,"},{"line_number":32,"context_line":"it will take forever to check one by one to find out all the locked instances."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"As an admin, I may have to lock all the instances on one host before"},{"line_number":35,"context_line":"performing maintenance operations, such as upgrade; in this kind of"},{"line_number":36,"context_line":"scenario, nova-compute will be stopped, but the instances can stay"},{"line_number":37,"context_line":"ACTIVE, so we don\u0027t want the instances to be able to perform any"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_2c71c20f","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":13},"updated":"2016-04-07 12:12:32.000000000","message":"I assume it\u0027s for admin, for general user seems not so useful\n\nI got 4 instances , \n\n+--------------------------------------+------+\n| ID                                   | Name |\n+--------------------------------------+------+\n| 650ab3e6-ec3d-4d63-b0c8-8c391ca079e3 | abc  |\n| 80f8749c-4a78-4ad4-81b9-76cb86a755e6 | abcd |\n| afb7b3d9-9e5d-4db6-9820-49430da62dfd | demo |\n| ec35962b-0c4c-4a44-8049-70782e60a4e3 | ji1  |\n+--------------------------------------+------+\n\njichen@ubuntuneutron:~$ nova show ji1\n....\n| locked                               | True                                                           |\n\nuse this API\njichen@ubuntuneutron:~$  curl -g -i -X GET http://192.168.122.105:8774/v2.1/1cbcd4ec6bc440e59caeb0882869c085/servers?locked\u003d1 -H \"User-Agent: python-novaclient\" -H \"Accept: application/json\" -H \"X-OpenStack-Nova-API-Version: 2.18\" -H \"X-Auth-Token: b69e526329fd4c71b5765f8386b8662f\"\nHTTP/1.1 200 OK\nContent-Length: 364\nContent-Type: application/json\nX-Openstack-Nova-Api-Version: 2.18\nVary: X-OpenStack-Nova-API-Version\nX-Compute-Request-Id: req-0ba09a1d-31e1-42c2-bb6d-c4f573311d8f\nDate: Thu, 07 Apr 2016 12:07:41 GMT\n\n{\"servers\": [{\"id\": \"ec35962b-0c4c-4a44-8049-70782e60a4e3\", \"links\": [{\"href\": \"http://192.168.122.105:8774/v2.1/1cbcd4ec6bc440e59caeb0882869c085/servers/ec35962b-0c4c-4a44-8049-70782e60a4e3\", \"rel\": \"self\"}, {\"href\": \"http://192.168.122.105:8774/1cbcd4ec6bc440e59caeb0882869c085/servers/ec35962b-0c4c-4a44-8049-70782e60a4e3\", \"rel\": \"bookmark\"}], \"name\": \"ji1\"}]}\n\nso I assume this is a only CLI thing, the reason is the admin can use almost all db schema to query what they want currently","commit_id":"48f70b481ab5f564d66005fef2dd910254d36173"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"78ea78ee94b34e878a8bda12eefef26202ffbca1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"due to various reasons, we have to unlock them before perform other options,"},{"line_number":32,"context_line":"it will take forever to check one by one to find out all the locked instances."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"As an admin, I may have to lock all the instances on one host before"},{"line_number":35,"context_line":"performing maintenance operations, such as upgrade; in this kind of"},{"line_number":36,"context_line":"scenario, nova-compute will be stopped, but the instances can stay"},{"line_number":37,"context_line":"ACTIVE, so we don\u0027t want the instances to be able to perform any"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_31dc2918","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":13},"in_reply_to":"1a122d0e_7c1fadb7","updated":"2016-04-21 19:30:55.000000000","message":"ok :) thanks","commit_id":"48f70b481ab5f564d66005fef2dd910254d36173"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"a39233241b86f8148686384677e40bd6b0bb9ebd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"due to various reasons, we have to unlock them before perform other options,"},{"line_number":32,"context_line":"it will take forever to check one by one to find out all the locked instances."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"As an admin, I may have to lock all the instances on one host before"},{"line_number":35,"context_line":"performing maintenance operations, such as upgrade; in this kind of"},{"line_number":36,"context_line":"scenario, nova-compute will be stopped, but the instances can stay"},{"line_number":37,"context_line":"ACTIVE, so we don\u0027t want the instances to be able to perform any"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_7c1fadb7","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":13},"in_reply_to":"9a061dce_2c71c20f","updated":"2016-04-21 13:02:35.000000000","message":"Hi Chen,\n\n try putting a space before to get monospace :)","commit_id":"48f70b481ab5f564d66005fef2dd910254d36173"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"78ea78ee94b34e878a8bda12eefef26202ffbca1","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* URL:"},{"line_number":69,"context_line":"    * /v2.1/servers/detail?locked\u003dtrue"},{"line_number":70,"context_line":"    * /v2.1/servers/?locked\u003dtrue"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Request method:"},{"line_number":73,"context_line":"    * GET"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_d1d7b5eb","line":70,"range":{"start_line":70,"start_character":19,"end_line":70,"end_character":21},"updated":"2016-04-21 19:30:55.000000000","message":"also, the / is a typo?","commit_id":"48f70b481ab5f564d66005fef2dd910254d36173"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"a39233241b86f8148686384677e40bd6b0bb9ebd","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* URL:"},{"line_number":69,"context_line":"    * /v2.1/servers/detail?locked\u003dtrue"},{"line_number":70,"context_line":"    * /v2.1/servers/?locked\u003dtrue"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Request method:"},{"line_number":73,"context_line":"    * GET"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_5c73d115","line":70,"updated":"2016-04-21 13:02:35.000000000","message":"will this also support false? I can see that being useful","commit_id":"48f70b481ab5f564d66005fef2dd910254d36173"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"47a6236579d02cb44616ccecca7ff652eda1883b","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* URL:"},{"line_number":69,"context_line":"    * /v2.1/servers/detail?locked\u003dtrue"},{"line_number":70,"context_line":"    * /v2.1/servers/?locked\u003dtrue"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Request method:"},{"line_number":73,"context_line":"    * GET"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_bcbae56f","line":70,"in_reply_to":"1a122d0e_5c73d115","updated":"2016-04-21 13:04:23.000000000","message":"Thanks, thats a good idea.","commit_id":"48f70b481ab5f564d66005fef2dd910254d36173"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"9721e025a5c5e8bce22eeb949a89e5676812673a","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* URL:"},{"line_number":69,"context_line":"    * /v2.1/servers/detail?locked\u003dtrue"},{"line_number":70,"context_line":"    * /v2.1/servers/?locked\u003dtrue"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Request method:"},{"line_number":73,"context_line":"    * GET"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_21ee49b4","line":70,"range":{"start_line":70,"start_character":19,"end_line":70,"end_character":21},"in_reply_to":"1a122d0e_d1d7b5eb","updated":"2016-05-04 02:55:57.000000000","message":"Done","commit_id":"48f70b481ab5f564d66005fef2dd910254d36173"}]}