)]}'
{"specs/newton/approved/allow-user-defined-shutdown-for-stop.rst":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"43ec370124cea833431b213557e022a50d0b7787","unresolved":false,"context_lines":[{"line_number":27,"context_line":"know or instance have some problems that cannot perform"},{"line_number":28,"context_line":"clean shutdown(os got stuck). It will be meaningless to try"},{"line_number":29,"context_line":"clean shutdown, allow users to perform force shutdown"},{"line_number":30,"context_line":"directly through API will be much more efficient in this"},{"line_number":31,"context_line":"kind of scenario."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_c13668e6","line":30,"updated":"2016-04-06 03:47:02.000000000","message":"it seems a useful API improvement.","commit_id":"03b50bac06b2e5d959b5add7b67cf18c8e6227ac"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"43ec370124cea833431b213557e022a50d0b7787","unresolved":false,"context_lines":[{"line_number":128,"context_line":"----------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"1. Add new parameter ``force-shutdown`` for ``os-stop`` API."},{"line_number":131,"context_line":"2. Add support for novaclient."},{"line_number":132,"context_line":"3. Add related tests."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_c1f5c8cb","line":131,"updated":"2016-04-06 03:47:02.000000000","message":"It seems better to give a warning ahead for force_shutdown, in case miss-using this option too much?","commit_id":"03b50bac06b2e5d959b5add7b67cf18c8e6227ac"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"da735e765f6148a7766c9daa477c11bb49c6f8b7","unresolved":false,"context_lines":[{"line_number":128,"context_line":"----------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"1. Add new parameter ``force-shutdown`` for ``os-stop`` API."},{"line_number":131,"context_line":"2. Add support for novaclient."},{"line_number":132,"context_line":"3. Add related tests."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_2178042a","line":131,"in_reply_to":"9a061dce_c1f5c8cb","updated":"2016-04-06 03:54:34.000000000","message":"Thanks for your review, I will add infomation in help meassage, but the function as you asked should be done in Horizon :)","commit_id":"03b50bac06b2e5d959b5add7b67cf18c8e6227ac"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"adbc8621ad98eb319a9518a92fe58c0500136a00","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Documentation Impact"},{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_f825f708","line":151,"range":{"start_line":151,"start_character":0,"end_line":151,"end_character":0},"updated":"2016-05-10 10:55:53.000000000","message":"I think you could mention here that the nova REST API doc should change to include the new parameter.\n\nhttp://developer.openstack.org/api-ref-compute-v2.1.html#stop","commit_id":"f4e91b18c508138ba78f6b35c40941c78d3edebe"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e45fda701c55e931aabdb4bdc26d4567a6c9414b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* JSON request body for \u0027os-stop\u0027::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        {"},{"line_number":79,"context_line":"            \"os-stop\": null,"},{"line_number":80,"context_line":"            \"type\": \"soft\""},{"line_number":81,"context_line":"        }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        {"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_5adbe2ed","line":80,"range":{"start_line":79,"start_character":12,"end_line":80,"end_character":26},"updated":"2016-05-18 07:48:42.000000000","message":"The body should be: {\"os-stop\": {\"type\": \"soft\"}}, this is the consistent style with other nova api","commit_id":"c013c8a9ad81173f958f6a6b31c28fa9f2931835"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e45fda701c55e931aabdb4bdc26d4567a6c9414b","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        {"},{"line_number":84,"context_line":"            \"os-stop\": null,"},{"line_number":85,"context_line":"            \"type\": \"hard\""},{"line_number":86,"context_line":"        }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_dabb5274","line":85,"updated":"2016-05-18 07:48:42.000000000","message":"Is this parameter optional or required? So I suggest we have json-schema at here. It will provide a good description for the api.","commit_id":"c013c8a9ad81173f958f6a6b31c28fa9f2931835"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"49daf90a9a25cdaaa024abb602c8e020f8ebb172","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, when stop an instance, we will first try to have a clean shutdown."},{"line_number":21,"context_line":"There are two parameters controls the whole operation:"},{"line_number":22,"context_line":"timeout and retry interval, for the default options, we will"},{"line_number":23,"context_line":"have to wait for 10 minutes trying to perform clean shutdown"},{"line_number":24,"context_line":"before we force shutdown the instance."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_d35d067b","line":22,"range":{"start_line":22,"start_character":44,"end_line":22,"end_character":51},"updated":"2016-05-23 19:41:18.000000000","message":"even thought not very related \n we might add those logic info here:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2101","commit_id":"8e3cd72568a9c1d04b19c5b47d335953b16b53c0"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"856242699a29b833fd10e416634c08868a890cea","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, when stop an instance, we will first try to have a clean shutdown."},{"line_number":21,"context_line":"There are two parameters controls the whole operation:"},{"line_number":22,"context_line":"timeout and retry interval, for the default options, we will"},{"line_number":23,"context_line":"have to wait for 10 minutes trying to perform clean shutdown"},{"line_number":24,"context_line":"before we force shutdown the instance."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_f03e35d9","line":22,"range":{"start_line":22,"start_character":44,"end_line":22,"end_character":51},"in_reply_to":"bab6814e_d35d067b","updated":"2016-05-24 01:13:56.000000000","message":"Done","commit_id":"8e3cd72568a9c1d04b19c5b47d335953b16b53c0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"49daf90a9a25cdaaa024abb602c8e020f8ebb172","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Currently, when stop an instance, we will first try to have a clean shutdown."},{"line_number":21,"context_line":"There are two parameters controls the whole operation:"},{"line_number":22,"context_line":"timeout and retry interval, for the default options, we will"},{"line_number":23,"context_line":"have to wait for 10 minutes trying to perform clean shutdown"},{"line_number":24,"context_line":"before we force shutdown the instance."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This is troublesome for some scenarios, for example, we already"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_13782e2b","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":19},"updated":"2016-05-23 19:41:18.000000000","message":"this is 1 min, not 10 min?\n\nhttps://github.com/openstack/nova/blob/master/nova/conf/compute.py#L260\n\n1 min is better.....","commit_id":"8e3cd72568a9c1d04b19c5b47d335953b16b53c0"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"856242699a29b833fd10e416634c08868a890cea","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Currently, when stop an instance, we will first try to have a clean shutdown."},{"line_number":21,"context_line":"There are two parameters controls the whole operation:"},{"line_number":22,"context_line":"timeout and retry interval, for the default options, we will"},{"line_number":23,"context_line":"have to wait for 10 minutes trying to perform clean shutdown"},{"line_number":24,"context_line":"before we force shutdown the instance."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This is troublesome for some scenarios, for example, we already"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_103ad9e7","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":19},"in_reply_to":"bab6814e_13782e2b","updated":"2016-05-24 01:13:56.000000000","message":"Yes, the default timeout is 1min but we will try for 10 times:\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L507\n\nWhich make it 10 mins before the force shutdown is performed, anyway, I will write all these to be more clear.","commit_id":"8e3cd72568a9c1d04b19c5b47d335953b16b53c0"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"392d364ea4acd8d115b479c535fe2db6c32c27e9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Add a new parameter for ``os-stop`` API"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* URL:"},{"line_number":74,"context_line":"    * /v2.1/servers/{server_id}/action/{server_id}/action:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Request method:"},{"line_number":77,"context_line":"    * POST"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_6bb8f811","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":58},"updated":"2016-07-12 10:56:32.000000000","message":"It should be /v2.1/{tenant_id}/servers/{server_id}/action.","commit_id":"2fdd103114eac5de25cc91d66485fafd40850ee0"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"21d7cb20a2c4de9304e560e833ee040329ea9495","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        {"},{"line_number":82,"context_line":"          \"os-stop\":{"},{"line_number":83,"context_line":"            \"type\": \"soft\""},{"line_number":84,"context_line":"          }"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_f405eac1","line":83,"range":{"start_line":83,"start_character":12,"end_line":83,"end_character":26},"updated":"2016-07-12 10:34:09.000000000","message":"Do we need a \"timeout\" parameter here?\nAs in the following spec, seems that parameter is demanded.\nhttps://review.openstack.org/#/c/186700","commit_id":"2fdd103114eac5de25cc91d66485fafd40850ee0"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"392d364ea4acd8d115b479c535fe2db6c32c27e9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"          }"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        {"},{"line_number":88,"context_line":"          \"os-stop\":{"},{"line_number":89,"context_line":"            \"type\": \"hard\""},{"line_number":90,"context_line":"          }"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* This operation does not return a response body"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_6bec78bb","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":9},"updated":"2016-07-12 10:56:32.000000000","message":"The valid types are specified in the schema section below, so one sample is enough.","commit_id":"2fdd103114eac5de25cc91d66485fafd40850ee0"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"21d7cb20a2c4de9304e560e833ee040329ea9495","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                \u0027properties\u0027: {"},{"line_number":107,"context_line":"                    \u0027type\u0027: {"},{"line_number":108,"context_line":"                        \u0027enum\u0027: [\u0027HARD\u0027, \u0027Hard\u0027, \u0027hard\u0027, \u0027SOFT\u0027, \u0027Soft\u0027, \u0027soft\u0027]"},{"line_number":109,"context_line":"                    }"},{"line_number":110,"context_line":"                },"},{"line_number":111,"context_line":"                \u0027required\u0027: [\u0027type\u0027],"},{"line_number":112,"context_line":"                \u0027additionalProperties\u0027: False"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_34a8128c","line":109,"updated":"2016-07-12 10:34:09.000000000","message":"As mentioned above, we should add the validation of timeout, for instance:\n\u0027timeout\u0027: parameter_types.non_negative_integer","commit_id":"2fdd103114eac5de25cc91d66485fafd40850ee0"}]}