)]}'
{"specs/newton/approved/cells-mq-connection-switching.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"416fb6503d9f3b9ea35f90adaeb8aad02a395745","unresolved":false,"context_lines":[{"line_number":95,"context_line":"is the same as in Cells v1 as both Transport objects and RPCClient objects"},{"line_number":96,"context_line":"are created dynamically for each message sent to a cell. There is the"},{"line_number":97,"context_line":"possibility of caching objects keyed off of hashes of \u0027mq_connection\u0027 along"},{"line_number":98,"context_line":"with an expiration scheme if overhead becomes problematic."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Other deployer impact"},{"line_number":101,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a18252c_6fde6312","line":98,"updated":"2016-04-13 17:43:17.000000000","message":"What is the real performance overhead of re-creating these objects all the time? Is it more than just standard python object init? Meaning, you\u0027re not including the db lookup and stuff in this, or are you?","commit_id":"31ce600cf682e309d03bb551c51ce8d0ec41624a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"41de7b66fe94643ead6f34feb40a5fb6c461809f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"is the same as in Cells v1 as both Transport objects and RPCClient objects"},{"line_number":96,"context_line":"are created dynamically for each message sent to a cell. There is the"},{"line_number":97,"context_line":"possibility of caching objects keyed off of hashes of \u0027mq_connection\u0027 along"},{"line_number":98,"context_line":"with an expiration scheme if overhead becomes problematic."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Other deployer impact"},{"line_number":101,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_9c1e65b9","line":98,"in_reply_to":"5a18252c_6fde6312","updated":"2016-04-20 01:56:54.000000000","message":"I\u0027m thinking of recreation of the messaging driver object along with connection pools, connecting to the broker, etc.","commit_id":"31ce600cf682e309d03bb551c51ce8d0ec41624a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"416fb6503d9f3b9ea35f90adaeb8aad02a395745","unresolved":false,"context_lines":[{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Since no user visible changes will occur with this change, the current suite of"},{"line_number":149,"context_line":"Tempest or functional tests should be sufficient."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Documentation Impact"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a18252c_2fa10ba4","line":149,"updated":"2016-04-13 17:43:17.000000000","message":"Maybe just say something here about general cellsv2 testing improvements we could make in the future (i.e. multiple cells) but that is out of scope for this specifically and that normal-path testing will cover basically everything.","commit_id":"31ce600cf682e309d03bb551c51ce8d0ec41624a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"41de7b66fe94643ead6f34feb40a5fb6c461809f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Since no user visible changes will occur with this change, the current suite of"},{"line_number":149,"context_line":"Tempest or functional tests should be sufficient."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Documentation Impact"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_7c4429b6","line":149,"in_reply_to":"5a18252c_2fa10ba4","updated":"2016-04-20 01:56:54.000000000","message":"Done","commit_id":"31ce600cf682e309d03bb551c51ce8d0ec41624a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"416fb6503d9f3b9ea35f90adaeb8aad02a395745","unresolved":false,"context_lines":[{"line_number":157,"context_line":"References"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"History"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a18252c_6f902344","line":160,"updated":"2016-04-13 17:43:17.000000000","message":"You have a patch up to do this, right? I\u0027d put that in here.","commit_id":"31ce600cf682e309d03bb551c51ce8d0ec41624a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"41de7b66fe94643ead6f34feb40a5fb6c461809f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"References"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"History"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_bc1881d4","line":160,"in_reply_to":"5a18252c_6f902344","updated":"2016-04-20 01:56:54.000000000","message":"Done","commit_id":"31ce600cf682e309d03bb551c51ce8d0ec41624a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"efd2cee3b9eb37c0e96a53f647a24b8dc813f675","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Message queue connection switching for cells"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/cells-mq-connection-switching"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_91853daf","line":11,"updated":"2016-04-21 19:37:47.000000000","message":"oops, think I was supposed to remove this","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"c59d2244b0c61251f6af25a94831f39fec32250b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Message queue connection switching for cells"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/cells-mq-connection-switching"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_a19db467","line":11,"in_reply_to":"1a122d0e_91853daf","updated":"2016-04-29 14:26:24.000000000","message":"the web ui editor is quite handy for fixing things like this?","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"720b24bb95cbb289ce53ac5ef34d14851551e1a7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Message queue connection switching for cells"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/cells-mq-connection-switching"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_d2b2aa48","line":11,"in_reply_to":"1a122d0e_a19db467","updated":"2016-05-04 21:16:15.000000000","message":"Yeah, I wanted to collect others comments and fix them all in a batch","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"c59d2244b0c61251f6af25a94831f39fec32250b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"the RequestContext where it can be used by the RPC API layer to interact with"},{"line_number":44,"context_line":"the cell message queue. Currently, there is only one message queue that can be"},{"line_number":45,"context_line":"used at the RPC API layer and it is a global transport. We will want to be able"},{"line_number":46,"context_line":"to create a transport dynamically based on message queue connection data if it"},{"line_number":47,"context_line":"is present in the RequestContext. The field \u0027mq_connection\u0027 will be added to"},{"line_number":48,"context_line":"RequestContext to store the transport object for the cell message queue."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_41c78044","line":46,"range":{"start_line":46,"start_character":22,"end_line":46,"end_character":33},"updated":"2016-04-29 14:26:24.000000000","message":"are these expensive to create? do we want to pool them? come to that, should we just have one transport per cell that we look up? we won\u0027t have thousands of cells so that should be affordable","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"720b24bb95cbb289ce53ac5ef34d14851551e1a7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"the RequestContext where it can be used by the RPC API layer to interact with"},{"line_number":44,"context_line":"the cell message queue. Currently, there is only one message queue that can be"},{"line_number":45,"context_line":"used at the RPC API layer and it is a global transport. We will want to be able"},{"line_number":46,"context_line":"to create a transport dynamically based on message queue connection data if it"},{"line_number":47,"context_line":"is present in the RequestContext. The field \u0027mq_connection\u0027 will be added to"},{"line_number":48,"context_line":"RequestContext to store the transport object for the cell message queue."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_12eee221","line":46,"range":{"start_line":46,"start_character":22,"end_line":46,"end_character":33},"in_reply_to":"1a122d0e_41c78044","updated":"2016-05-04 21:16:15.000000000","message":"I explain this in the Performance Impact section","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f79eddf4d47e70e38a03cf921c6047d24bda99cd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"the RequestContext where it can be used by the RPC API layer to interact with"},{"line_number":44,"context_line":"the cell message queue. Currently, there is only one message queue that can be"},{"line_number":45,"context_line":"used at the RPC API layer and it is a global transport. We will want to be able"},{"line_number":46,"context_line":"to create a transport dynamically based on message queue connection data if it"},{"line_number":47,"context_line":"is present in the RequestContext. The field \u0027mq_connection\u0027 will be added to"},{"line_number":48,"context_line":"RequestContext to store the transport object for the cell message queue."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_b2960e92","line":46,"range":{"start_line":46,"start_character":22,"end_line":46,"end_character":33},"in_reply_to":"1a122d0e_41c78044","updated":"2016-05-04 21:17:45.000000000","message":"Ultimately I do think we\u0027ll want to pool these. For now I\u0027m comfortable with just having the functionality in place and we can look at optimizations later.","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"c59d2244b0c61251f6af25a94831f39fec32250b","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"What other ways could we do this thing? Why aren\u0027t we using those? This doesn\u0027t"},{"line_number":60,"context_line":"have to be a full literature review, but it should demonstrate that thought has"},{"line_number":61,"context_line":"been put into why the proposed solution is an appropriate one."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Data model impact"},{"line_number":64,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_019aa861","line":61,"updated":"2016-04-29 14:26:24.000000000","message":"template language","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"720b24bb95cbb289ce53ac5ef34d14851551e1a7","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"What other ways could we do this thing? Why aren\u0027t we using those? This doesn\u0027t"},{"line_number":60,"context_line":"have to be a full literature review, but it should demonstrate that thought has"},{"line_number":61,"context_line":"been put into why the proposed solution is an appropriate one."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Data model impact"},{"line_number":64,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_726ab6b6","line":61,"in_reply_to":"1a122d0e_019aa861","updated":"2016-05-04 21:16:15.000000000","message":"Gah, how did I miss this? Thanks.","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f79eddf4d47e70e38a03cf921c6047d24bda99cd","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"What other ways could we do this thing? Why aren\u0027t we using those? This doesn\u0027t"},{"line_number":60,"context_line":"have to be a full literature review, but it should demonstrate that thought has"},{"line_number":61,"context_line":"been put into why the proposed solution is an appropriate one."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Data model impact"},{"line_number":64,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_52cb3aa4","line":61,"in_reply_to":"1a122d0e_019aa861","updated":"2016-05-04 21:17:45.000000000","message":"Heh, yeah this should be updated.","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"c59d2244b0c61251f6af25a94831f39fec32250b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"----------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"This change means that developers should be aware that cell message queue"},{"line_number":114,"context_line":"connection information is contained in the RequestContext and be mindful that"},{"line_number":115,"context_line":"it could contain sensitive data. Developers will need to use the interfaces"},{"line_number":116,"context_line":"for getting message queue connection information from a CellMapping and setting"},{"line_number":117,"context_line":"it in a RequestContext in order to interact with a cell message queue."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_e1968cee","line":115,"range":{"start_line":114,"start_character":62,"end_line":115,"end_character":31},"updated":"2016-04-29 14:26:24.000000000","message":"there\u0027s some code somewhere that ensures passwords are elided when the context is printed, can you make sure that\u0027s updated if required please?","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1d32aa07cd2165266e41d39db2fe1b09c03967ff","unresolved":false,"context_lines":[{"line_number":111,"context_line":"----------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"This change means that developers should be aware that cell message queue"},{"line_number":114,"context_line":"connection information is contained in the RequestContext and be mindful that"},{"line_number":115,"context_line":"it could contain sensitive data. Developers will need to use the interfaces"},{"line_number":116,"context_line":"for getting message queue connection information from a CellMapping and setting"},{"line_number":117,"context_line":"it in a RequestContext in order to interact with a cell message queue."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_526e9a00","line":115,"range":{"start_line":114,"start_character":62,"end_line":115,"end_character":31},"in_reply_to":"1a122d0e_325e7ee9","updated":"2016-05-04 21:32:59.000000000","message":"I found only selected attributes in the RequestContext are part of the str format [1][2][3] and our attributes \u0027db_connection\u0027 and \u0027mq_connection\u0027 are not part of it.\n\n[1] https://github.com/openstack/nova/blob/666a05c/nova/context.py#L219-L220\n\n[2] https://github.com/openstack/nova/blob/666a05c/nova/context.py#L176-L195\n\n[3] https://github.com/openstack/oslo.context/blob/c63a359/oslo_context/context.py#L101-L122","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f79eddf4d47e70e38a03cf921c6047d24bda99cd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"----------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"This change means that developers should be aware that cell message queue"},{"line_number":114,"context_line":"connection information is contained in the RequestContext and be mindful that"},{"line_number":115,"context_line":"it could contain sensitive data. Developers will need to use the interfaces"},{"line_number":116,"context_line":"for getting message queue connection information from a CellMapping and setting"},{"line_number":117,"context_line":"it in a RequestContext in order to interact with a cell message queue."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_325e7ee9","line":115,"range":{"start_line":114,"start_character":62,"end_line":115,"end_character":31},"in_reply_to":"1a122d0e_e1968cee","updated":"2016-05-04 21:17:45.000000000","message":"I don\u0027t believe that\u0027s affected by this change. But caution should be taken if code in that area does change.","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"720b24bb95cbb289ce53ac5ef34d14851551e1a7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"----------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"This change means that developers should be aware that cell message queue"},{"line_number":114,"context_line":"connection information is contained in the RequestContext and be mindful that"},{"line_number":115,"context_line":"it could contain sensitive data. Developers will need to use the interfaces"},{"line_number":116,"context_line":"for getting message queue connection information from a CellMapping and setting"},{"line_number":117,"context_line":"it in a RequestContext in order to interact with a cell message queue."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_32379eb1","line":115,"range":{"start_line":114,"start_character":62,"end_line":115,"end_character":31},"in_reply_to":"1a122d0e_e1968cee","updated":"2016-05-04 21:16:15.000000000","message":"I\u0027ll check into that","commit_id":"a168ba6c8399b03140c3c60f84fce5976d25482c"}]}
