)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"05108dd41909299b46b443527babd2e5cf5f8801","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is a proposal for adding support for live migration in the VMware"},{"line_number":10,"context_line":"driver. When the VMware driver is used, each nova-compute is managing a"},{"line_number":11,"context_line":"single vCenter cluster. For the purposes of this proposal we assume that"},{"line_number":12,"context_line":"all nova-computes are managing clusters under the same vCenter server."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"blueprint vmware-live-migration"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_62254709","line":12,"updated":"2016-04-01 22:58:11.000000000","message":"The obvious question here is \"ok, but what happens in an environment where this assumption is not in fact valid\". I\u0027m guessing you make this assumption because it\u0027s not feasible to live migrate across vCenter\u0027s, but what\u0027s the behavior if this proposal is acted on and there are in fact multiple vCenter\u0027s. Is the live migrate option not available at all? Is it available but fails out if it lands on a host that is under the other vCenter? Is it available but always works, migration *within* the vCenter the guest is already in? Etc. I think even if cross-vCenter live migration isn\u0027t supported what happens in environments with \u003e than 1 vCenter cluster being managed by Nova needs to be addressed/documented.","commit_id":"c5a1220a07831ef41913f4b9a53cd4c366b33624"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"d82632d03abd3117e8ba111c5e1762ff6ba15cc4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is a proposal for adding support for live migration in the VMware"},{"line_number":10,"context_line":"driver. When the VMware driver is used, each nova-compute is managing a"},{"line_number":11,"context_line":"single vCenter cluster. For the purposes of this proposal we assume that"},{"line_number":12,"context_line":"all nova-computes are managing clusters under the same vCenter server."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"blueprint vmware-live-migration"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_37db98ef","line":12,"in_reply_to":"ba0121b8_62254709","updated":"2016-04-04 07:34:54.000000000","message":"Migrating VMs across vCenter servers is supported starting from vSphere 6.0. I plan this as a next step after we have migrations within the same vCenter because it will require more resources in our CI. We can easily check if both nova-computes are in fact under the same vCenter and give appropriate errors if this is not the case.","commit_id":"c5a1220a07831ef41913f4b9a53cd4c366b33624"}],"specs/newton/approved/vmware-live-migration.rst":[{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"b603c6858462433f5d7a7761c19a4ba5d2495a5a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This is a proposal for adding support for live migration in the VMware"},{"line_number":14,"context_line":"driver. When the VMware driver is used, each nova-compute is managing a"},{"line_number":15,"context_line":"single vCenter cluster. For the purposes of this proposal we assume that"},{"line_number":16,"context_line":"all nova-computes are managing clusters under the same vCenter server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_9d16acef","line":16,"updated":"2016-04-05 15:33:20.000000000","message":"What I was getting at in my earlier comment is I would like to see this spec address, with specifics, what will happen in this initial implementation in cases where this assumption is invalid. Options might include:\n\n* Not migrating and generating an error.\n* Migrating but only to clusters within the same vCenter.\n* Some other action???\n\nGiven that such deployments may already exist I do not think it is good enough to say that it is assumed that they don\u0027t exist and will be addressed later without defining what will happen to those that do have such a setup and try to use this functionality in this initial implementation.","commit_id":"db95b94d535d19f9d42c0577e5d9732b0696c12d"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"62433d253cd68435840c5943f19d3ca2091afd34","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This is a proposal for adding support for live migration in the VMware"},{"line_number":14,"context_line":"driver. When the VMware driver is used, each nova-compute is managing a"},{"line_number":15,"context_line":"single vCenter cluster. For the purposes of this proposal we assume that"},{"line_number":16,"context_line":"all nova-computes are managing clusters under the same vCenter server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_849339a3","line":16,"in_reply_to":"9a061dce_9d16acef","updated":"2016-04-11 12:28:03.000000000","message":"Done","commit_id":"db95b94d535d19f9d42c0577e5d9732b0696c12d"},{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"b603c6858462433f5d7a7761c19a4ba5d2495a5a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"---------"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"As an End User I want to live migrate instances from one vCenter cluster"},{"line_number":27,"context_line":"(nova-compute host) to another vCenter cluster (nova-compute host)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_fdd36836","line":27,"updated":"2016-04-05 15:33:20.000000000","message":"This use case does not appear to exclude the case that is excluded by the assumption above.","commit_id":"db95b94d535d19f9d42c0577e5d9732b0696c12d"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"62433d253cd68435840c5943f19d3ca2091afd34","unresolved":false,"context_lines":[{"line_number":24,"context_line":"---------"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"As an End User I want to live migrate instances from one vCenter cluster"},{"line_number":27,"context_line":"(nova-compute host) to another vCenter cluster (nova-compute host)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_e4902d98","line":27,"in_reply_to":"9a061dce_fdd36836","updated":"2016-04-11 12:28:03.000000000","message":"Done","commit_id":"db95b94d535d19f9d42c0577e5d9732b0696c12d"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"35ac2aaf19c54a0e2a82accaae7bba3a31196f17","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"VMware live migration"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/vmware-live-migration"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_2ae699af","line":9,"updated":"2016-04-29 15:21:47.000000000","message":"femtonit the length should match title","commit_id":"b5b23d59f15dfeba96ac363d456a0c777390c05c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"d17d367f0d1011fba2f2616891cd3f7e698916ff","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"VMware live migration"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/vmware-live-migration"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_e935b0a8","line":9,"in_reply_to":"1a122d0e_2ae699af","updated":"2016-05-12 10:53:29.000000000","message":"Done","commit_id":"b5b23d59f15dfeba96ac363d456a0c777390c05c"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"35ac2aaf19c54a0e2a82accaae7bba3a31196f17","unresolved":false,"context_lines":[{"line_number":37,"context_line":"and the datastore regex of the target compute host. If the instance is located"},{"line_number":38,"context_line":"on a datastore shared between the two clusters, it will remain there."},{"line_number":39,"context_line":"Otherwise we will choose a datastore that matches the datastore_regex of the"},{"line_number":40,"context_line":"target host and migrate the instance there."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_8a7a4db8","line":40,"updated":"2016-04-29 15:21:47.000000000","message":"can we have some info on how these 2 pieces of information will be obtained, stored and passed about please? Look at some published specs to get an idea of the level of detail usually given.","commit_id":"b5b23d59f15dfeba96ac363d456a0c777390c05c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"d17d367f0d1011fba2f2616891cd3f7e698916ff","unresolved":false,"context_lines":[{"line_number":37,"context_line":"and the datastore regex of the target compute host. If the instance is located"},{"line_number":38,"context_line":"on a datastore shared between the two clusters, it will remain there."},{"line_number":39,"context_line":"Otherwise we will choose a datastore that matches the datastore_regex of the"},{"line_number":40,"context_line":"target host and migrate the instance there."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_c4025309","line":40,"in_reply_to":"1a122d0e_8a7a4db8","updated":"2016-05-12 10:53:29.000000000","message":"Done","commit_id":"b5b23d59f15dfeba96ac363d456a0c777390c05c"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"587a863734c78837a350cb2abfd3c4a92fa987c0","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":43,"context_line":"cluster name and the datastore regex of the target compute host. Both of them"},{"line_number":44,"context_line":"are obtained from the nova config (CONF.vmware.cluster_name and "},{"line_number":45,"context_line":"CONF.vmware.datastore_regex)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dab17558_084c6975","line":44,"range":{"start_line":44,"start_character":63,"end_line":44,"end_character":64},"updated":"2016-05-12 12:18:15.000000000","message":"nit trailing space","commit_id":"e4b8637f48d13ba3f3f8ddc10137b3dd510292bc"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"587a863734c78837a350cb2abfd3c4a92fa987c0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":43,"context_line":"cluster name and the datastore regex of the target compute host. Both of them"},{"line_number":44,"context_line":"are obtained from the nova config (CONF.vmware.cluster_name and "},{"line_number":45,"context_line":"CONF.vmware.datastore_regex)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dab17558_0549f48e","line":45,"updated":"2016-05-12 12:18:15.000000000","message":"huh, I\u0027d have expected this to be specified per-request? Like this, a given host can only ever migrate VMs to one other host, which is not the usual design.","commit_id":"e4b8637f48d13ba3f3f8ddc10137b3dd510292bc"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"1a5f24a47f4dc9874da878b74cf888ee2e4ac3be","unresolved":false,"context_lines":[{"line_number":42,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":43,"context_line":"cluster name and the datastore regex of the target compute host. Both of them"},{"line_number":44,"context_line":"are obtained from the nova config (CONF.vmware.cluster_name and "},{"line_number":45,"context_line":"CONF.vmware.datastore_regex)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dab17558_ee800d4c","line":45,"in_reply_to":"dab17558_0549f48e","updated":"2016-05-12 12:47:44.000000000","message":"The target compute host is specified in the request. Then check_can_live_migrate_destination() is executed on the target host and VMwareLiveMigrateData is created and populated with the config properties. See https://review.openstack.org/#/c/270116/5/nova/virt/vmwareapi/driver.py","commit_id":"e4b8637f48d13ba3f3f8ddc10137b3dd510292bc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc911bb8559c989bebad998baac7d74af5efc819","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This is a proposal for adding support for live migration in the VMware"},{"line_number":14,"context_line":"driver. When the VMware driver is used, each nova-compute is managing a"},{"line_number":15,"context_line":"single vCenter cluster. For the purposes of this proposal we assume that"},{"line_number":16,"context_line":"all nova-computes are managing clusters under the same vCenter server. If"},{"line_number":17,"context_line":"migration across different vCenter servers is attempted, an error message"},{"line_number":18,"context_line":"will be generated and no migration will occur."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a8bc5a2_90a6980e","line":18,"range":{"start_line":16,"start_character":71,"end_line":18,"end_character":46},"updated":"2016-09-23 21:07:16.000000000","message":"Is this something that vcenter / vsphere will fail with or something that the vmware driver in nova is going to have to detect before attempting the live migration?","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"907dd3602f380f9e42d3834a2abbcaff75f3eee5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This is a proposal for adding support for live migration in the VMware"},{"line_number":14,"context_line":"driver. When the VMware driver is used, each nova-compute is managing a"},{"line_number":15,"context_line":"single vCenter cluster. For the purposes of this proposal we assume that"},{"line_number":16,"context_line":"all nova-computes are managing clusters under the same vCenter server. If"},{"line_number":17,"context_line":"migration across different vCenter servers is attempted, an error message"},{"line_number":18,"context_line":"will be generated and no migration will occur."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a8bc5a2_34410aaa","line":18,"range":{"start_line":16,"start_character":71,"end_line":18,"end_character":46},"in_reply_to":"5a8bc5a2_90a6980e","updated":"2016-09-26 11:22:33.000000000","message":"we can detect this in the Nova driver before attempting live migration in vsphere","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc911bb8559c989bebad998baac7d74af5efc819","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Add support for live migration in the VMware driver."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a8bc5a2_10bb6828","line":23,"updated":"2016-09-23 21:07:16.000000000","message":"nit: this isn\u0027t really a problem description.","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"907dd3602f380f9e42d3834a2abbcaff75f3eee5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Add support for live migration in the VMware driver."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a8bc5a2_7749d45f","line":23,"in_reply_to":"5a8bc5a2_10bb6828","updated":"2016-09-26 11:22:33.000000000","message":"Done","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc911bb8559c989bebad998baac7d74af5efc819","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"---------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As an End User I want to live migrate instances from one compute cluster"},{"line_number":29,"context_line":"(nova-compute host) to another compute cluster (nova-compute host) in the"},{"line_number":30,"context_line":"same vCenter server."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a8bc5a2_907db870","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":14},"updated":"2016-09-23 21:07:16.000000000","message":"Really an operator/admin since live migration is not something end users of the cloud do by default.","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"907dd3602f380f9e42d3834a2abbcaff75f3eee5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"---------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As an End User I want to live migrate instances from one compute cluster"},{"line_number":29,"context_line":"(nova-compute host) to another compute cluster (nova-compute host) in the"},{"line_number":30,"context_line":"same vCenter server."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a8bc5a2_1486ceda","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":14},"in_reply_to":"5a8bc5a2_907db870","updated":"2016-09-26 11:22:33.000000000","message":"Done","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc911bb8559c989bebad998baac7d74af5efc819","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Testing"},{"line_number":115,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The VMware CI will provision two nova-computes and will execute the live"},{"line_number":118,"context_line":"migration tests from tempest."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Documentation Impact"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a8bc5a2_10c0c87a","line":118,"range":{"start_line":117,"start_character":0,"end_line":118,"end_character":29},"updated":"2016-09-23 21:07:16.000000000","message":"The VMware NSX CI has been pretty flaky the last release or so, so I\u0027ve got my doubts about this actually happening. I\u0027d like to say that this should be something that\u0027s complete by the end of Ocata - but if it doesn\u0027t happen I\u0027m not sure if we\u0027ll disable the feature or not.\n\nI think at the very least this should go in with a warning that it\u0027s considered experimental until the multi-compute vmware CI shows up to test it.","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"907dd3602f380f9e42d3834a2abbcaff75f3eee5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Testing"},{"line_number":115,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The VMware CI will provision two nova-computes and will execute the live"},{"line_number":118,"context_line":"migration tests from tempest."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Documentation Impact"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a8bc5a2_d450e634","line":118,"range":{"start_line":117,"start_character":0,"end_line":118,"end_character":29},"in_reply_to":"5a8bc5a2_10c0c87a","updated":"2016-09-26 11:22:33.000000000","message":"We are trying to make our CI stable again. I am OK to put warning message until we have good CI coverage for this feature.","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"dc483979e76c304a2b3c6bc0e27496c46f3b0f1c","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"History"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_7d4b3ab1","line":134,"updated":"2016-05-27 11:48:44.000000000","message":"please update this section as well.","commit_id":"7e838b639a0c3d71f7362e84f1c0c16ab62ceba6"}],"specs/pike/approved/vmware-live-migration.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9a10be15db20c4abe4f9a4df5e47a05011d6e6c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Testing"},{"line_number":115,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The VMware CI will provision two nova-computes and will execute the live"},{"line_number":118,"context_line":"migration tests from tempest."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Documentation Impact"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ffe62b97_5384715e","line":118,"range":{"start_line":117,"start_character":0,"end_line":118,"end_character":29},"updated":"2017-03-24 21:36:09.000000000","message":"Sorry but I\u0027m a hard stop on adding this feature until the \"existing\" vmware third party CI can even function on single-compute tests and changes. I have to ask about the health of the vmware CI in the mailing list about once per quarter because it seems to just randomly not work and it\u0027s always being \"worked on\" but that\u0027s been the response from vmware for many months now. So I\u0027m -1 on adding more features for vmware until the CI is stable.","commit_id":"188685e15fe135cd9a1c739bd0b9dad11dd907a3"}],"specs/queens/approved/vmware-live-migration.rst":[{"author":{"_account_id":20157,"name":"xuan0802","email":"thespring1989@gmail.com","username":"xuan0802"},"change_message_id":"b6eb0c1d1d280882abe9d526c1b0758899dbd98a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"---------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As an Operator I want to live migrate instances from one compute cluster"},{"line_number":29,"context_line":"(nova-compute host) to another compute cluster (nova-compute host) in the"},{"line_number":30,"context_line":"same vCenter server."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_55e1019a","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":7},"updated":"2017-09-25 08:55:33.000000000","message":"O --\u003e o","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"b4ed4036028e369a6cf610e1b87939a3d686c273","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"---------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As an Operator I want to live migrate instances from one compute cluster"},{"line_number":29,"context_line":"(nova-compute host) to another compute cluster (nova-compute host) in the"},{"line_number":30,"context_line":"same vCenter server."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_047eb5e3","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":7},"in_reply_to":"7f515b1d_55e1019a","updated":"2017-09-25 12:09:50.000000000","message":"Use case actors are written with capital letters, see specs/queens-template.rst","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":20157,"name":"xuan0802","email":"thespring1989@gmail.com","username":"xuan0802"},"change_message_id":"b6eb0c1d1d280882abe9d526c1b0758899dbd98a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"(nova-compute host) to another compute cluster (nova-compute host) in the"},{"line_number":30,"context_line":"same vCenter server."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Relocating VMs to another cluster/datastore is a simple matter of calling the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_d5bcd16a","line":32,"range":{"start_line":32,"start_character":9,"end_line":32,"end_character":15},"updated":"2017-09-25 08:55:33.000000000","message":"change --\u003e changes","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"b4ed4036028e369a6cf610e1b87939a3d686c273","unresolved":false,"context_lines":[{"line_number":29,"context_line":"(nova-compute host) to another compute cluster (nova-compute host) in the"},{"line_number":30,"context_line":"same vCenter server."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Relocating VMs to another cluster/datastore is a simple matter of calling the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_c412ddb1","line":32,"range":{"start_line":32,"start_character":9,"end_line":32,"end_character":15},"in_reply_to":"7f515b1d_d5bcd16a","updated":"2017-09-25 12:09:50.000000000","message":"It is \"Proposed change\" in the template, see specs/queens-template.rst","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"347ead1070af3f3eaaaa16b118c78c42455e2a8f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Relocating VMs to another cluster/datastore is a simple matter of calling the"},{"line_number":36,"context_line":"RelocateVM_Task() API. The source compute host needs to know the cluster name"},{"line_number":37,"context_line":"and the datastore regex of the target compute host. If the instance is located"},{"line_number":38,"context_line":"on a datastore shared between the two clusters, it will remain there."},{"line_number":39,"context_line":"Otherwise we will choose a datastore that matches the datastore_regex of the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_2be5a8dc","line":36,"updated":"2017-09-27 16:43:57.000000000","message":"clarify whose API this is","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8e026a780d01ac871d9ec3237d8771c01bfafdce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Relocating VMs to another cluster/datastore is a simple matter of calling the"},{"line_number":36,"context_line":"RelocateVM_Task() API. The source compute host needs to know the cluster name"},{"line_number":37,"context_line":"and the datastore regex of the target compute host. If the instance is located"},{"line_number":38,"context_line":"on a datastore shared between the two clusters, it will remain there."},{"line_number":39,"context_line":"Otherwise we will choose a datastore that matches the datastore_regex of the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_7c243d5e","line":36,"in_reply_to":"7f515b1d_2be5a8dc","updated":"2017-10-02 09:39:02.000000000","message":"Done","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e999d90009e91c27990141902b7b0cd4674a1256","unresolved":false,"context_lines":[{"line_number":37,"context_line":"and the datastore regex of the target compute host. If the instance is located"},{"line_number":38,"context_line":"on a datastore shared between the two clusters, it will remain there."},{"line_number":39,"context_line":"Otherwise we will choose a datastore that matches the datastore_regex of the"},{"line_number":40,"context_line":"target host and migrate the instance there."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":43,"context_line":"cluster name and the datastore regex of the target compute host. Both of them"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_d01eadb9","line":40,"updated":"2017-09-28 09:12:19.000000000","message":"Most drivers have a check live-migration is possible phase. Based on what you say in this spec, I guess at a minimum you should also check that both hosts are using the same vCenter?\n\nThe idea with the check being we can rollback the live-migration before we start setting up ports and storage on the destination host.\n\nMaybe you also need to check CPU compatibility and such, I am unsure. Is there a hypervisor API to call for that? checkRelocate seems to be that kind of thing:\n\nhttps://www.vmware.com/support/developer/converter-sdk/conv61_apireference/vim.vm.check.ProvisioningChecker.html#checkRelocate","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8e026a780d01ac871d9ec3237d8771c01bfafdce","unresolved":false,"context_lines":[{"line_number":37,"context_line":"and the datastore regex of the target compute host. If the instance is located"},{"line_number":38,"context_line":"on a datastore shared between the two clusters, it will remain there."},{"line_number":39,"context_line":"Otherwise we will choose a datastore that matches the datastore_regex of the"},{"line_number":40,"context_line":"target host and migrate the instance there."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":43,"context_line":"cluster name and the datastore regex of the target compute host. Both of them"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_bce515de","line":40,"in_reply_to":"7f515b1d_d01eadb9","updated":"2017-10-02 09:39:02.000000000","message":"You are looking at the wrong place -- this API is part of the converter SDK which has nothing to do with the VIM API. There is no API that will check and guarantee if the relocate will be successful or not. We can check if both clusters are on the VC though.","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e999d90009e91c27990141902b7b0cd4674a1256","unresolved":false,"context_lines":[{"line_number":42,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":43,"context_line":"cluster name and the datastore regex of the target compute host. Both of them"},{"line_number":44,"context_line":"are obtained from the nova config (CONF.vmware.cluster_name and"},{"line_number":45,"context_line":"CONF.vmware.datastore_regex)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_b070d109","line":45,"updated":"2017-09-28 09:12:19.000000000","message":"Some more detail here would be good. I would state at what stage of the live-migration the data is collected, what comes from the source, what comes from the destination, what is needed for the checkRelocate call vs the relocatevm_task call, etc.\n\nI only really ask that, because when it comes to code review, it will make it much easier to get the VMware data model straight in my head.","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8e026a780d01ac871d9ec3237d8771c01bfafdce","unresolved":false,"context_lines":[{"line_number":42,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":43,"context_line":"cluster name and the datastore regex of the target compute host. Both of them"},{"line_number":44,"context_line":"are obtained from the nova config (CONF.vmware.cluster_name and"},{"line_number":45,"context_line":"CONF.vmware.datastore_regex)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_1ced49b6","line":45,"in_reply_to":"7f515b1d_b070d109","updated":"2017-10-02 09:39:02.000000000","message":"Both cluster name and datastore regex come from the target compute node as I have already said in the spec. We may need to put host_ip as well if we want to check if both clusters are on the same VC. Will add that.","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e999d90009e91c27990141902b7b0cd4674a1256","unresolved":false,"context_lines":[{"line_number":57,"context_line":"REST API impact"},{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"None"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Security impact"},{"line_number":63,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_10d20501","line":60,"updated":"2017-09-28 09:12:19.000000000","message":"I think its worth adding more detail here.\n\nExplicitly state there are no API changes, the destination host specified remains the hostname of the nova-compute node. (Even though this may not mean too much to the VMware OpenStack operator.)\n\nI only say this because previous proposals didn\u0027t seem to take the above approach, which was a deal breaker for me.","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8e026a780d01ac871d9ec3237d8771c01bfafdce","unresolved":false,"context_lines":[{"line_number":57,"context_line":"REST API impact"},{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"None"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Security impact"},{"line_number":63,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_7c58bd86","line":60,"in_reply_to":"7f515b1d_10d20501","updated":"2017-10-02 09:39:02.000000000","message":"We are not making any REST API changes and the spec is pretty clear about that by saying the REST API Impact is \"None\". What could be more explicit than this?\n\nI have no idea what are those previous proposals that you are talking about.","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"347ead1070af3f3eaaaa16b118c78c42455e2a8f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Work Items"},{"line_number":104,"context_line":"----------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"It will be implemented in a single patch."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_ab4638bf","line":106,"updated":"2017-09-27 16:43:57.000000000","message":"Instead of saying how it will be implemented say what will be implemented. You\u0027ve listed them already up in the proposed change, do it again here","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8e026a780d01ac871d9ec3237d8771c01bfafdce","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Work Items"},{"line_number":104,"context_line":"----------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"It will be implemented in a single patch."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f515b1d_37901e95","line":106,"in_reply_to":"7f515b1d_ab4638bf","updated":"2017-10-02 09:39:02.000000000","message":"Done","commit_id":"a9a190b15dc845168aa4a4137ed29e6b19321d05"}],"specs/rocky/approved/vmware-live-migration.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d26acc8dd9b72d11675642cc8c54fbd6c28f7e1d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"be a pre live-migration check that will verify that both source and"},{"line_number":42,"context_line":"destination compute nodes correspond to clusters in the same vCenter server."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":45,"context_line":"host IP, the cluster name and the datastore regex of the target compute host."},{"line_number":46,"context_line":"All of them are obtained from the nova config (CONF.vmware.host_ip,"},{"line_number":47,"context_line":"CONF.vmware.cluster_name and CONF.vmware.datastore_regex)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_edb4e9d3","line":44,"range":{"start_line":44,"start_character":33,"end_line":44,"end_character":54},"updated":"2018-06-05 10:26:23.000000000","message":"...will be introduced, ``VMWareLiveMigrateData``, which will..","commit_id":"f8440e02bd2e8a6493da3d75a96ff37382a1cf56"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f90076621e7b2e4bf309c56fcd854f0e6694df1c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"destination compute nodes correspond to clusters in the same vCenter server."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":45,"context_line":"host IP, the cluster name and the datastore regex of the target compute host."},{"line_number":46,"context_line":"All of them are obtained from the nova config (CONF.vmware.host_ip,"},{"line_number":47,"context_line":"CONF.vmware.cluster_name and CONF.vmware.datastore_regex)."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_7fa37a01","line":45,"range":{"start_line":45,"start_character":50,"end_line":45,"end_character":77},"updated":"2018-06-06 16:22:14.000000000","message":"TBC, when pre_live_migrate() is called, there is a migrate_data object that is passed over the wire to the destination compute.\n\nIf you plan to get the VMwareLiveMigrateData object to be populated there and brought back to the source compute service within _do_live_migrate(), you somehow need to hook into this and call the virt driver so that you can raise the exception.\n\nThat looks like an implementation detail so I won\u0027t hold this spec, but maybe a spec update to clarify the implementation work items would be nice.","commit_id":"f8440e02bd2e8a6493da3d75a96ff37382a1cf56"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"698d69e3f429c94cab334fc9b2d22dd2da96e89e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"destination compute nodes correspond to clusters in the same vCenter server."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":45,"context_line":"host IP, the cluster name and the datastore regex of the target compute host."},{"line_number":46,"context_line":"All of them are obtained from the nova config (CONF.vmware.host_ip,"},{"line_number":47,"context_line":"CONF.vmware.cluster_name and CONF.vmware.datastore_regex)."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_7f9dba08","line":45,"range":{"start_line":45,"start_character":50,"end_line":45,"end_character":77},"in_reply_to":"5f7c97a3_7f829a02","updated":"2018-06-06 16:38:48.000000000","message":"Okay, so : \n- pre_live_migrate() (on destination) would populate migrate_data with destination details\n- source would get migrate_data and call self.driver_live_migration() \n- if the above method would raise an exception, it would fail here :\nhttps://github.com/openstack/nova/blob/47423dfb7fb22924b6b06b99bb571c49bbc54af8/nova/compute/manager.py#L6097-L6101","commit_id":"f8440e02bd2e8a6493da3d75a96ff37382a1cf56"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f08fe0402538585819168d230f52e1596206373d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"destination compute nodes correspond to clusters in the same vCenter server."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":45,"context_line":"host IP, the cluster name and the datastore regex of the target compute host."},{"line_number":46,"context_line":"All of them are obtained from the nova config (CONF.vmware.host_ip,"},{"line_number":47,"context_line":"CONF.vmware.cluster_name and CONF.vmware.datastore_regex)."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_7f829a02","line":45,"range":{"start_line":45,"start_character":50,"end_line":45,"end_character":77},"in_reply_to":"5f7c97a3_7fa37a01","updated":"2018-06-06 16:26:01.000000000","message":"Actually conductor is first to get the migrate_data from the destination compute:\n\nhttps://github.com/openstack/nova/blob/47423dfb7fb22924b6b06b99bb571c49bbc54af8/nova/conductor/tasks/live_migrate.py#L221\n\nAnd then it passes that down to live_migration on the source host:\n\nhttps://github.com/openstack/nova/blob/47423dfb7fb22924b6b06b99bb571c49bbc54af8/nova/conductor/tasks/live_migrate.py#L109\n\nWhich then rpc calls to the dest compute\u0027s pre_live_migration to do more setup on the dest host and pass that back to the source. If pre_live_migration() fails, the source handles it and errors out the live migration:\n\nhttps://github.com/openstack/nova/blob/47423dfb7fb22924b6b06b99bb571c49bbc54af8/nova/compute/manager.py#L6077\n\nThis flow is all documented btw:\n\nhttps://docs.openstack.org/nova/latest/reference/live-migration.html","commit_id":"f8440e02bd2e8a6493da3d75a96ff37382a1cf56"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d26acc8dd9b72d11675642cc8c54fbd6c28f7e1d","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"A new object will be introduced (VMwareLiveMigrateData) which will carry the"},{"line_number":45,"context_line":"host IP, the cluster name and the datastore regex of the target compute host."},{"line_number":46,"context_line":"All of them are obtained from the nova config (CONF.vmware.host_ip,"},{"line_number":47,"context_line":"CONF.vmware.cluster_name and CONF.vmware.datastore_regex)."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_2dbbc1c4","line":47,"range":{"start_line":46,"start_character":47,"end_line":47,"end_character":56},"updated":"2018-06-05 10:26:23.000000000","message":"style nit: Each of these should be a ``literal``","commit_id":"f8440e02bd2e8a6493da3d75a96ff37382a1cf56"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f90076621e7b2e4bf309c56fcd854f0e6694df1c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"----------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* Add ``VMwareLiveMigrateData`` object"},{"line_number":114,"context_line":"* Implement pre live-migration checks"},{"line_number":115,"context_line":"* Implement methods for selecting target ESX host and datastore"},{"line_number":116,"context_line":"* Ensure CI coverage for live-migration"},{"line_number":117,"context_line":"* Update support-matrix"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_bf5ef2e6","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":37},"updated":"2018-06-06 16:22:14.000000000","message":"that\u0027s where I\u0027m a bit confused about where you plan to integrate the checks.","commit_id":"f8440e02bd2e8a6493da3d75a96ff37382a1cf56"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f90076621e7b2e4bf309c56fcd854f0e6694df1c","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* Add ``VMwareLiveMigrateData`` object"},{"line_number":114,"context_line":"* Implement pre live-migration checks"},{"line_number":115,"context_line":"* Implement methods for selecting target ESX host and datastore"},{"line_number":116,"context_line":"* Ensure CI coverage for live-migration"},{"line_number":117,"context_line":"* Update support-matrix"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_ff6b0a82","line":115,"range":{"start_line":115,"start_character":10,"end_line":115,"end_character":20},"updated":"2018-06-06 16:22:14.000000000","message":"I\u0027m assuming those methods are in the virt driver, obviously.","commit_id":"f8440e02bd2e8a6493da3d75a96ff37382a1cf56"}]}