)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3892bece2ff60a64dfea6ad5e795d4a438f35b21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Ironic Shellinabox HTTP proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec is intended to add Ironic shellinabox console support."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1c33d8fc1ca5609ae8bc37cb7892050c6a1eba47"},{"line_number":12,"context_line":"Implements: blueprint shellinabox-http-proxy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_159f55b5","line":10,"updated":"2016-04-08 14:10:33.000000000","message":"You need to add the APIImpact tag to the commit message on it\u0027s own line.","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"100934a9bba4a1c6efd6bf8fc7960017de9c4b0e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Ironic Shellinabox HTTP proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec is intended to add Ironic shellinabox console support."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1c33d8fc1ca5609ae8bc37cb7892050c6a1eba47"},{"line_number":12,"context_line":"Implements: blueprint shellinabox-http-proxy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a1b2928_d0c4cb41","line":10,"in_reply_to":"9a061dce_159f55b5","updated":"2016-04-11 13:35:25.000000000","message":"Done","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"}],"specs/newton/approved/shellinabox-http-proxy.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3892bece2ff60a64dfea6ad5e795d4a438f35b21","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Ironic currently supports a shellinabox serial console but it\u0027s not compatible"},{"line_number":20,"context_line":"with nova serial console, this causes ironic driver instances can\u0027t provide"},{"line_number":21,"context_line":"console functionality for tenants"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_7211875d","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":24},"updated":"2016-04-08 14:10:33.000000000","message":"Why not? Can that be changed to make it compatible?","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"0d58c7bf1c6d870fc3680368a56974440d39396a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Ironic currently supports a shellinabox serial console but it\u0027s not compatible"},{"line_number":20,"context_line":"with nova serial console, this causes ironic driver instances can\u0027t provide"},{"line_number":21,"context_line":"console functionality for tenants"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_8b1a3d16","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":24},"in_reply_to":"9a061dce_7211875d","updated":"2016-04-11 04:21:38.000000000","message":"shellinabox is a web based terminal, but unfortunately we don\u0027t have any HTTP proxy in nova, and shellinabox is a common console driver in Ironic, so I think it\u0027s worth to add support for it, also the new proxy can be used for other drivers if they have web based console.\n\nOn Ironic side, we will add other console drivers in future, like a socket proxy which can be compatible with nova websocket proxy, but I think it\u0027s not conflict.","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3892bece2ff60a64dfea6ad5e795d4a438f35b21","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"None."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_555b8d2e","line":139,"updated":"2016-04-08 14:10:33.000000000","message":"What about https://bugs.launchpad.net/ironic/+bug/1526371 ?","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"100934a9bba4a1c6efd6bf8fc7960017de9c4b0e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"None."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_d0620bd8","line":139,"in_reply_to":"7a1b2928_0bdd8d42","updated":"2016-04-11 13:35:25.000000000","message":"and the horizon bp should depend on this :)","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aed05090327c8ba7ae51a8a3a852ea2823a49381","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"None."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_d5683d8a","line":139,"in_reply_to":"9a061dce_3536d9b4","updated":"2016-04-08 14:13:10.000000000","message":"Oh the latter is horizon, I thought that was ironic.","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e7c05de5a0a50b288e2144d3f069f342ed44f9c3","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"None."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_3536d9b4","line":139,"in_reply_to":"9a061dce_555b8d2e","updated":"2016-04-08 14:12:13.000000000","message":"What about this ironic blueprint?\n\nhttps://blueprints.launchpad.net/horizon/+spec/ironic-shellinabox-console","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"0d58c7bf1c6d870fc3680368a56974440d39396a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Dependencies"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"None."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_0bdd8d42","line":139,"in_reply_to":"9a061dce_d5683d8a","updated":"2016-04-11 04:21:38.000000000","message":"yes, will update soon, thanks Matt.","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3892bece2ff60a64dfea6ad5e795d4a438f35b21","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Unit tests should be added to cover this feature."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Documentation Impact"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_1578f58e","line":144,"updated":"2016-04-08 14:10:33.000000000","message":"Would it be possible to test this at all from one of the ironic CI jobs?","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"0d58c7bf1c6d870fc3680368a56974440d39396a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Unit tests should be added to cover this feature."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Documentation Impact"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a1b2928_ab8c5936","line":144,"in_reply_to":"9a061dce_1578f58e","updated":"2016-04-11 04:21:38.000000000","message":"not sure we can do that, but will explore it more.","commit_id":"6105051f07dd424d6c138874c9a9adac7494bdd1"}]}