)]}'
{"specs/newton/approved/keypair-notification.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c85bbe3d5eaa150e7702be9417a317459e3e8bb2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* keypair.delete.end"},{"line_number":38,"context_line":"* keypair.import.start"},{"line_number":39,"context_line":"* keypair.import.end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"},{"line_number":43,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_29e6ca43","line":40,"updated":"2016-05-17 12:40:16.000000000","message":"I think it is worth to mention that these notifications exist as legacy notifications. As far as I understand this spec will transform them to versioned notification and at the same time extend them with extra data to support the above use case.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1b3c9e7acca2641f68d55f769eafa70f5a54ceb8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* keypair.delete.end"},{"line_number":38,"context_line":"* keypair.import.start"},{"line_number":39,"context_line":"* keypair.import.end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"},{"line_number":43,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_8a621fd7","line":40,"in_reply_to":"dab17558_29e6ca43","updated":"2016-05-18 06:01:53.000000000","message":"I got the point.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d2ee4fc9ebe8defe05a32af7ec02bec758fe64fd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":69,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":70,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"},{"line_number":71,"context_line":"            \u0027tenant_id\u0027: (\u0027keypair\u0027, \u0027tenant_id\u0027),"},{"line_number":72,"context_line":"            \u0027user_id\u0027: (\u0027keypair\u0027, \u0027user_id\u0027)"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"        VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_505fa140","line":71,"updated":"2016-05-16 17:19:55.000000000","message":"we should probably got with project_id, given thats what keystone v3 currently likes","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c85bbe3d5eaa150e7702be9417a317459e3e8bb2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":69,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":70,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"},{"line_number":71,"context_line":"            \u0027tenant_id\u0027: (\u0027keypair\u0027, \u0027tenant_id\u0027),"},{"line_number":72,"context_line":"            \u0027user_id\u0027: (\u0027keypair\u0027, \u0027user_id\u0027)"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"        VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_e94162aa","line":71,"in_reply_to":"dab17558_505fa140","updated":"2016-05-17 12:40:16.000000000","message":"+1","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1b3c9e7acca2641f68d55f769eafa70f5a54ceb8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":69,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":70,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"},{"line_number":71,"context_line":"            \u0027tenant_id\u0027: (\u0027keypair\u0027, \u0027tenant_id\u0027),"},{"line_number":72,"context_line":"            \u0027user_id\u0027: (\u0027keypair\u0027, \u0027user_id\u0027)"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"        VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_ca9a67c5","line":71,"in_reply_to":"dab17558_e94162aa","updated":"2016-05-18 06:01:53.000000000","message":"I got the point.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c85bbe3d5eaa150e7702be9417a317459e3e8bb2","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                \"created_at\": \"2016-04-04T04:18:30.000000\","},{"line_number":123,"context_line":"                \"deleted_at\": None"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Other end user impact"},{"line_number":128,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_c979fe30","line":125,"updated":"2016-05-17 12:40:16.000000000","message":"The versioned notification will be a bit different on the wire. Something like:\n\n{\n    \"priority\": \"INFO\",\n    \"payload\": {\n        \"nova_object.namespace\": \"nova\",\n        \"nova_object.name\": \"KeypairPayload\",\n        \"nova_object.version\": \"1.0\",\n        \"nova_object.data\": {\n            \"id\": 1,\n            \"key_name\": \"key1\",\n            \"key_type\": \"ssh\",\n            \"fingerprint\": \"6d:a1:2c:a3:.....\",\n            \"public_key\": \"Public key: ssh-rsa AAAAB3Nza......\",\n            \"tenant_id\": \"2a9db238db8f455fb2ec71da188c04c9\",\n            \"user_id\": \"5ed98568284443b09b82f2a519a3f1d5\",\n            \"created_at\": \"2016-04-04T04:18:30.000000\",\n            \"deleted_at\": None\n        }\n    },\n    \"event_type\": \"keypair.create.end\",\n    \"publisher_id\": \"nova-compute:host1\"\n}","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1b3c9e7acca2641f68d55f769eafa70f5a54ceb8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                \"created_at\": \"2016-04-04T04:18:30.000000\","},{"line_number":123,"context_line":"                \"deleted_at\": None"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Other end user impact"},{"line_number":128,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_eaa92be1","line":125,"in_reply_to":"dab17558_c979fe30","updated":"2016-05-18 06:01:53.000000000","message":"Thanks.\nI modify this as you say.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d2ee4fc9ebe8defe05a32af7ec02bec758fe64fd","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Work Items"},{"line_number":153,"context_line":"----------"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Delete a legacy notification of keypairs which have an unversioned payload."},{"line_number":156,"context_line":"* Add a new notification of keypairs which have a versioned payload."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_701aa5c7","line":155,"updated":"2016-05-16 17:19:55.000000000","message":"There is an agreed approach to moving to the versioned notifications, where we keep both notifications available in parallel for some time. We should do that here.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c85bbe3d5eaa150e7702be9417a317459e3e8bb2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Work Items"},{"line_number":153,"context_line":"----------"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Delete a legacy notification of keypairs which have an unversioned payload."},{"line_number":156,"context_line":"* Add a new notification of keypairs which have a versioned payload."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_89fff664","line":155,"in_reply_to":"dab17558_701aa5c7","updated":"2016-05-17 12:40:16.000000000","message":"+1\nSo just keep the legacy in place as well. We will remove the legacy ones as soon as we have feature parity in the versioned side.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1b3c9e7acca2641f68d55f769eafa70f5a54ceb8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Work Items"},{"line_number":153,"context_line":"----------"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Delete a legacy notification of keypairs which have an unversioned payload."},{"line_number":156,"context_line":"* Add a new notification of keypairs which have a versioned payload."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_0a7c6f71","line":155,"in_reply_to":"dab17558_89fff664","updated":"2016-05-18 06:01:53.000000000","message":"I got the point.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c85bbe3d5eaa150e7702be9417a317459e3e8bb2","unresolved":false,"context_lines":[{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Besides unit test new functional test cases will be added to cover the"},{"line_number":166,"context_line":"improved notifications."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Documentation Impact"},{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_e9dde2e0","line":166,"updated":"2016-05-17 12:40:16.000000000","message":"Just a note, you have to add notification samples and a related tests.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1b3c9e7acca2641f68d55f769eafa70f5a54ceb8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Besides unit test new functional test cases will be added to cover the"},{"line_number":166,"context_line":"improved notifications."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Documentation Impact"},{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_6ab6db3e","line":166,"in_reply_to":"dab17558_e9dde2e0","updated":"2016-05-18 06:01:53.000000000","message":"I see.","commit_id":"211a74351fc0a16f4ac3a412df8e2b7b62112f7f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"246094cbc70f17a33e295f604ae1953c63255d45","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # Version 1.0: Initial version"},{"line_number":67,"context_line":"        SCHEMA \u003d {"},{"line_number":68,"context_line":"            \u0027id\u0027: (\u0027keypair\u0027, \u0027id\u0027),"},{"line_number":69,"context_line":"            \u0027key_name\u0027: (\u0027keypair\u0027, \u0027key_name\u0027),"},{"line_number":70,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":71,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":72,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_e62affe6","line":69,"range":{"start_line":69,"start_character":37,"end_line":69,"end_character":45},"updated":"2016-05-18 09:03:47.000000000","message":"nova.object.KeyPair object call this field \u0027name\u0027 so you have to read it from there.\nI don\u0027t have hard opinion about calling this field \u0027key_name\u0027 or \u0027name\u0027 in the notification but it seem \u0027key\u0027 is a bit redundant as the event_type already scoping it into keypair","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1abb9b953096266c0cd98b89837c2812b187c841","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # Version 1.0: Initial version"},{"line_number":67,"context_line":"        SCHEMA \u003d {"},{"line_number":68,"context_line":"            \u0027id\u0027: (\u0027keypair\u0027, \u0027id\u0027),"},{"line_number":69,"context_line":"            \u0027key_name\u0027: (\u0027keypair\u0027, \u0027key_name\u0027),"},{"line_number":70,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":71,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":72,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_be16feee","line":69,"range":{"start_line":69,"start_character":37,"end_line":69,"end_character":45},"in_reply_to":"bab6814e_e62affe6","updated":"2016-05-19 08:13:26.000000000","message":"I agree with your opinion.\nI change the name from \u0027key_name\u0027 to \u0027name\u0027.","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"246094cbc70f17a33e295f604ae1953c63255d45","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        SCHEMA \u003d {"},{"line_number":68,"context_line":"            \u0027id\u0027: (\u0027keypair\u0027, \u0027id\u0027),"},{"line_number":69,"context_line":"            \u0027key_name\u0027: (\u0027keypair\u0027, \u0027key_name\u0027),"},{"line_number":70,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":71,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":72,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"},{"line_number":73,"context_line":"            \u0027project_id\u0027: (\u0027keypair\u0027, \u0027project_id\u0027),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_46230b06","line":70,"range":{"start_line":70,"start_character":37,"end_line":70,"end_character":45},"updated":"2016-05-18 09:03:47.000000000","message":"Keypair object call this \u0027type\u0027","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1abb9b953096266c0cd98b89837c2812b187c841","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        SCHEMA \u003d {"},{"line_number":68,"context_line":"            \u0027id\u0027: (\u0027keypair\u0027, \u0027id\u0027),"},{"line_number":69,"context_line":"            \u0027key_name\u0027: (\u0027keypair\u0027, \u0027key_name\u0027),"},{"line_number":70,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":71,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":72,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"},{"line_number":73,"context_line":"            \u0027project_id\u0027: (\u0027keypair\u0027, \u0027project_id\u0027),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_1ed46a1e","line":70,"range":{"start_line":70,"start_character":37,"end_line":70,"end_character":45},"in_reply_to":"bab6814e_46230b06","updated":"2016-05-19 08:13:26.000000000","message":"I change the name from \u0027key_type\u0027 to \u0027type\u0027.","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"246094cbc70f17a33e295f604ae1953c63255d45","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":71,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":72,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"},{"line_number":73,"context_line":"            \u0027project_id\u0027: (\u0027keypair\u0027, \u0027project_id\u0027),"},{"line_number":74,"context_line":"            \u0027user_id\u0027: (\u0027keypair\u0027, \u0027user_id\u0027)"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":"        VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_01f8cde4","line":73,"updated":"2016-05-18 09:03:47.000000000","message":"There is no project_id or tenant_id field in the nova.objects.KeyPair so you have no place to copy this info directly from. Where do you plan to get this?","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1abb9b953096266c0cd98b89837c2812b187c841","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027key_type\u0027: (\u0027keypair\u0027, \u0027key_type\u0027),"},{"line_number":71,"context_line":"            \u0027fingerprint\u0027: (\u0027keypair\u0027, \u0027fingerprint\u0027),"},{"line_number":72,"context_line":"            \u0027public_key\u0027: (\u0027keypair\u0027, \u0027public_key\u0027),"},{"line_number":73,"context_line":"            \u0027project_id\u0027: (\u0027keypair\u0027, \u0027project_id\u0027),"},{"line_number":74,"context_line":"            \u0027user_id\u0027: (\u0027keypair\u0027, \u0027user_id\u0027)"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":"        VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_def2e2d1","line":73,"in_reply_to":"bab6814e_01f8cde4","updated":"2016-05-19 08:13:26.000000000","message":"Sorry.\nAs you say, keypair object doesn\u0027t have a \u0027project_id\u0027 field, so I delete it.","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"246094cbc70f17a33e295f604ae1953c63255d45","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \u0027key_type\u0027: fields.StringField(),"},{"line_number":81,"context_line":"            \u0027fingerprint\u0027: fields.StringField(),"},{"line_number":82,"context_line":"            \u0027public_key\u0027: fields.StringField(),"},{"line_number":83,"context_line":"            \u0027tenant_id\u0027: fields.UUIDField(),"},{"line_number":84,"context_line":"            \u0027user_id\u0027: fields.UUIDField(),"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":"        def __init__(self, key_name):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_e1e82919","line":83,"updated":"2016-05-18 09:03:47.000000000","message":"I think John previously commented to call this project_id instead of tenant_id","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1abb9b953096266c0cd98b89837c2812b187c841","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \u0027key_type\u0027: fields.StringField(),"},{"line_number":81,"context_line":"            \u0027fingerprint\u0027: fields.StringField(),"},{"line_number":82,"context_line":"            \u0027public_key\u0027: fields.StringField(),"},{"line_number":83,"context_line":"            \u0027tenant_id\u0027: fields.UUIDField(),"},{"line_number":84,"context_line":"            \u0027user_id\u0027: fields.UUIDField(),"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":"        def __init__(self, key_name):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_beed5ef1","line":83,"in_reply_to":"bab6814e_e1e82919","updated":"2016-05-19 08:13:26.000000000","message":"I delete project_id field.","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"246094cbc70f17a33e295f604ae1953c63255d45","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027tenant_id\u0027: fields.UUIDField(),"},{"line_number":84,"context_line":"            \u0027user_id\u0027: fields.UUIDField(),"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":"        def __init__(self, key_name):"},{"line_number":87,"context_line":"            super(KeypairPayload, self).__init__()"},{"line_number":88,"context_line":"            self.populate_schema(key_name\u003dkey_name)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_61cef984","line":86,"range":{"start_line":86,"start_character":27,"end_line":86,"end_character":35},"updated":"2016-05-18 09:03:47.000000000","message":"You have to pass down the whole KeyPair object here so the the framework can copy the values out of it according your SCHEMA so the name is misleading.","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1abb9b953096266c0cd98b89837c2812b187c841","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027tenant_id\u0027: fields.UUIDField(),"},{"line_number":84,"context_line":"            \u0027user_id\u0027: fields.UUIDField(),"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":"        def __init__(self, key_name):"},{"line_number":87,"context_line":"            super(KeypairPayload, self).__init__()"},{"line_number":88,"context_line":"            self.populate_schema(key_name\u003dkey_name)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_febd26d8","line":86,"range":{"start_line":86,"start_character":27,"end_line":86,"end_character":35},"in_reply_to":"bab6814e_61cef984","updated":"2016-05-19 08:13:26.000000000","message":"I got the point.\nI change the name from \u0027key_name\u0027 to \u0027keypair\u0027.","commit_id":"a757dd55a8ed325c69c5b50eb555d8b827bd5d22"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3286464853a89921dd2d7ad8d270798d5b675c35","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        fields \u003d {"},{"line_number":77,"context_line":"            \u0027id\u0027: fields.IntegerField(),"},{"line_number":78,"context_line":"            \u0027name\u0027: fields.StringField(),"},{"line_number":79,"context_line":"            \u0027type\u0027: fields.StringField(),"},{"line_number":80,"context_line":"            \u0027fingerprint\u0027: fields.StringField(),"},{"line_number":81,"context_line":"            \u0027public_key\u0027: fields.StringField(),"},{"line_number":82,"context_line":"            \u0027user_id\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_3f5ebe76","line":79,"range":{"start_line":79,"start_character":27,"end_line":79,"end_character":38},"updated":"2016-05-24 09:19:57.000000000","message":"We should be more specific, I think we can have an enum type with ssh and x509, or something like that?\n\nA bit like this one:\nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L150","commit_id":"6d13f37c9c8b70dabf53b93953cb11c5c1654000"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"7399edc86b8f70cc1b351ca10554f29facdc4809","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        fields \u003d {"},{"line_number":77,"context_line":"            \u0027id\u0027: fields.IntegerField(),"},{"line_number":78,"context_line":"            \u0027name\u0027: fields.StringField(),"},{"line_number":79,"context_line":"            \u0027type\u0027: fields.StringField(),"},{"line_number":80,"context_line":"            \u0027fingerprint\u0027: fields.StringField(),"},{"line_number":81,"context_line":"            \u0027public_key\u0027: fields.StringField(),"},{"line_number":82,"context_line":"            \u0027user_id\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_c3496690","line":79,"range":{"start_line":79,"start_character":27,"end_line":79,"end_character":38},"in_reply_to":"bab6814e_3f5ebe76","updated":"2016-05-25 07:03:15.000000000","message":"I got the point.\nI\u0027ll add a new enum for keypair type.","commit_id":"6d13f37c9c8b70dabf53b93953cb11c5c1654000"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f4eeee5afd94ec8f06489829dffc3873420f3b00","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        VERSION \u003d \u00271.0\u0027"},{"line_number":76,"context_line":"        fields \u003d {"},{"line_number":77,"context_line":"            \u0027id\u0027: fields.IntegerField(),"},{"line_number":78,"context_line":"            \u0027name\u0027: fields.StringField(),"},{"line_number":79,"context_line":"            \u0027type\u0027: fields.KeypairTypeField(),"},{"line_number":80,"context_line":"            \u0027fingerprint\u0027: fields.StringField(),"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_9e507860","line":77,"updated":"2016-06-02 20:43:10.000000000","message":"Why do we want to expose the row primary key id in the notification from the nova db? Seems like something we shouldn\u0027t expose from any Nova API.","commit_id":"f9a71ef27353576768b65d1e61711d596823083e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8afa9c268a8ce89d8ec5e59a33816bb86318ed26","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        VERSION \u003d \u00271.0\u0027"},{"line_number":76,"context_line":"        fields \u003d {"},{"line_number":77,"context_line":"            \u0027id\u0027: fields.IntegerField(),"},{"line_number":78,"context_line":"            \u0027name\u0027: fields.StringField(),"},{"line_number":79,"context_line":"            \u0027type\u0027: fields.KeypairTypeField(),"},{"line_number":80,"context_line":"            \u0027fingerprint\u0027: fields.StringField(),"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_f0f0b968","line":77,"in_reply_to":"9abb7d3a_9e507860","updated":"2016-06-03 08:50:42.000000000","message":"It seems that the name field needs to be unique as that is used to address the resource on the REST API so I agree that the id is not something we need here.","commit_id":"f9a71ef27353576768b65d1e61711d596823083e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f4eeee5afd94ec8f06489829dffc3873420f3b00","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            \u0027type\u0027: fields.KeypairTypeField(),"},{"line_number":80,"context_line":"            \u0027fingerprint\u0027: fields.StringField(),"},{"line_number":81,"context_line":"            \u0027public_key\u0027: fields.StringField(),"},{"line_number":82,"context_line":"            \u0027user_id\u0027: fields.UUIDField(),"},{"line_number":83,"context_line":"        }"},{"line_number":84,"context_line":"        def __init__(self, keypair):"},{"line_number":85,"context_line":"            super(KeypairPayload, self).__init__()"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_1ecbe81f","line":82,"range":{"start_line":82,"start_character":30,"end_line":82,"end_character":39},"updated":"2016-06-02 20:43:10.000000000","message":"I\u0027m not totally sure that user_id has to be a uuid in keystone...","commit_id":"f9a71ef27353576768b65d1e61711d596823083e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8afa9c268a8ce89d8ec5e59a33816bb86318ed26","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            \u0027type\u0027: fields.KeypairTypeField(),"},{"line_number":80,"context_line":"            \u0027fingerprint\u0027: fields.StringField(),"},{"line_number":81,"context_line":"            \u0027public_key\u0027: fields.StringField(),"},{"line_number":82,"context_line":"            \u0027user_id\u0027: fields.UUIDField(),"},{"line_number":83,"context_line":"        }"},{"line_number":84,"context_line":"        def __init__(self, keypair):"},{"line_number":85,"context_line":"            super(KeypairPayload, self).__init__()"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_90896dcd","line":82,"range":{"start_line":82,"start_character":30,"end_line":82,"end_character":39},"in_reply_to":"9abb7d3a_1ecbe81f","updated":"2016-06-03 08:50:42.000000000","message":"Let\u0027s go with a StringField as that is the only thing we can guarantee from nova object model perspective","commit_id":"f9a71ef27353576768b65d1e61711d596823083e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f4eeee5afd94ec8f06489829dffc3873420f3b00","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Documentation Impact"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":"None"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"References"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_fea9c425","line":196,"updated":"2016-06-02 20:43:10.000000000","message":"We should document this stuff somewhere. I think gibi said he\u0027s created a wiki, but it seems like we should put this in the nova developer documentation. Long-term it would be awesome to automatically generate these, but that\u0027s not required for this.","commit_id":"f9a71ef27353576768b65d1e61711d596823083e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"964da46e1387d9a57f9838acbae93fd9bd941c23","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Documentation Impact"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":"None"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"References"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_ccb98cee","line":196,"in_reply_to":"9abb7d3a_50b6e58a","updated":"2016-06-03 14:21:40.000000000","message":"Cool, thanks.","commit_id":"f9a71ef27353576768b65d1e61711d596823083e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8afa9c268a8ce89d8ec5e59a33816bb86318ed26","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Documentation Impact"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":"None"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"References"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_50b6e58a","line":196,"in_reply_to":"9abb7d3a_fea9c425","updated":"2016-06-03 08:50:42.000000000","message":"The basic automatic doc generation is already merged in Mitaka [1].  If there is a notification sample for this, then \nthe table at the bottom of the  notification devref [2] is updated automatically. :)\n\n[1] https://github.com/openstack/nova/blob/master/doc/ext/versioned_notifications.py\n[2] http://docs.openstack.org/developer/nova/notifications.html#existing-versioned-notifications","commit_id":"f9a71ef27353576768b65d1e61711d596823083e"}]}
