)]}'
{"specs/newton/approved/server-create-secgroups-response-link.rst":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc2a6c3a29b5d6d832fdff2f878e336939ed1322","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"When using Neutron, we don\u0027t know what security groups are going to be applied"},{"line_number":32,"context_line":"to an instance (port/network) from the Nova API, and defaulting to \u0027default\u0027 in"},{"line_number":33,"context_line":"the response when no specific security groups are requested can be wrong."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"},{"line_number":36,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_e81d2010","line":33,"updated":"2016-05-05 11:41:30.000000000","message":"I think there are a couple of axes of wrong in the current behavior.\n\nWe always inject \u0027default\u0027 even if it\u0027s not a thing (use_neutron\u003dTrue and port_security_enabled\u003dFalse). We shouldn\u0027t do that.\n\nWhat phases are we going through?\n\nIs there a point where we don\u0027t know anything?\n\nIs there a point where we know some details and can express to the user?\n\nIs there a reasonable summary of attributes we can keep in the server object once we know it?","commit_id":"e4140f590a128f3062cb5e5e7fc699ab93fe99b7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5af2e19793dcceabfdc0b823630ee97a2bc1e3f3","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"When using Neutron, we don\u0027t know what security groups are going to be applied"},{"line_number":32,"context_line":"to an instance (port/network) from the Nova API, and defaulting to \u0027default\u0027 in"},{"line_number":33,"context_line":"the response when no specific security groups are requested can be wrong."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"},{"line_number":36,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_7d17c2ed","line":33,"in_reply_to":"1a122d0e_e81d2010","updated":"2016-05-06 01:38:16.000000000","message":"The ML thread on this goes into a lot of the details and possible options, of which we landed on this one.\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2016-April/091162.html\n\nIt definitely gets messy. The REST API would have to call a new thing in the nova.network.neutronv2.api and pass the request and have that build what it thinks is going to be the security groups that get applied based on the networks that are available and used when doing network allocation, which could change by the time we get to the actual compute to do the network allocation (that\u0027s already a race we have today, assuming the user isn\u0027t providing a port or network when booting the instance).\n\nSo given all of that mess, as described and discussed in the ML thread, we said it was best to just provide a link to the existing API we have to day that will get the security groups applied to the ports for the given instance - which would be the most true thing we have once we\u0027ve allocated the network (ports) for the instance (once it\u0027s ACTIVE).","commit_id":"e4140f590a128f3062cb5e5e7fc699ab93fe99b7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e8bdb208d0a2ec4c9937f3a9751cee9820e14da0","unresolved":false,"context_lines":[{"line_number":109,"context_line":"::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   \"security_groups\": [{"},{"line_number":112,"context_line":"       \"href\": \"http://127.0.0.1:8774/f3203f02b9ec4c2faf6d0fd77a2f78bf/\\"},{"line_number":113,"context_line":"            servers/762c6a19-2097-4910-9af6-4ec8b19d0b6d/os-security-groups\","},{"line_number":114,"context_line":"       \"rel\": \"bookmark\"}]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"More details and discussion are in the openstack-dev `mailing list thread`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a061dce_88085593","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":77},"updated":"2016-04-08 23:37:58.000000000","message":"This seems always the same value, IIUC.\nIs it necessary to return it?\n\nThat means the format likes\n\n \"href\": \"http://\u003cnova-api\u003e/servers/\u003cserver-id\u003e/os-security-groups\"\n\n\u003cserver-id\u003e is already passed as an \"id\" on the same response body. So users can get it from \"id\" even if not passing this value.","commit_id":"e4140f590a128f3062cb5e5e7fc699ab93fe99b7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc2a6c3a29b5d6d832fdff2f878e336939ed1322","unresolved":false,"context_lines":[{"line_number":109,"context_line":"::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   \"security_groups\": [{"},{"line_number":112,"context_line":"       \"href\": \"http://127.0.0.1:8774/f3203f02b9ec4c2faf6d0fd77a2f78bf/\\"},{"line_number":113,"context_line":"            servers/762c6a19-2097-4910-9af6-4ec8b19d0b6d/os-security-groups\","},{"line_number":114,"context_line":"       \"rel\": \"bookmark\"}]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"More details and discussion are in the openstack-dev `mailing list thread`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_88b62cda","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":77},"in_reply_to":"1a122d0e_87903150","updated":"2016-05-05 11:41:30.000000000","message":"If we are going to use HATEOS links, we should probably keep those within something called \u0027links\u0027, which means nesting further - https://spring.io/understanding/HATEOAS\n\nBut, that being said, it does seem slight weird to keep a security groups representation which is a LIST level command, and not GET commands. In seeing this written out, it seems odd. And I think I need to ponder a bit more.","commit_id":"e4140f590a128f3062cb5e5e7fc699ab93fe99b7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76527033041e24a30c4f4eb64cb0b5bc601ca537","unresolved":false,"context_lines":[{"line_number":109,"context_line":"::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   \"security_groups\": [{"},{"line_number":112,"context_line":"       \"href\": \"http://127.0.0.1:8774/f3203f02b9ec4c2faf6d0fd77a2f78bf/\\"},{"line_number":113,"context_line":"            servers/762c6a19-2097-4910-9af6-4ec8b19d0b6d/os-security-groups\","},{"line_number":114,"context_line":"       \"rel\": \"bookmark\"}]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"More details and discussion are in the openstack-dev `mailing list thread`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_87903150","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":77},"in_reply_to":"9a061dce_88085593","updated":"2016-04-22 18:19:11.000000000","message":"I\u0027m not really understanding the comment. I was basically copying this from how the server response links to os-flavors:\n\nhttps://github.com/openstack/nova/blob/master/doc/api_samples/servers/server-get-resp.json#L20","commit_id":"e4140f590a128f3062cb5e5e7fc699ab93fe99b7"}]}