)]}'
{"specs/newton/approved/image-vif-model-sriov.rst":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f0a6e69dac18e1806bfd8ec0214ae76ba739f778","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/image-vif-model-sriov"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint describes the extension of the glance image properties in order"},{"line_number":14,"context_line":"to be able to specify a VIF model of type SR-IOV for network attachments.  This"},{"line_number":15,"context_line":"feature improve the usability of SR-IOV network devices.  Currently booting a"},{"line_number":16,"context_line":"guest with NIC SR-IOV attachment requires the user to first create a Neutron"},{"line_number":17,"context_line":"port making it a multi-steps procedure."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_434a4627","line":14,"range":{"start_line":14,"start_character":73,"end_line":14,"end_character":75},"updated":"2016-05-10 15:18:23.000000000","message":"extra space","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/image-vif-model-sriov"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint describes the extension of the glance image properties in order"},{"line_number":14,"context_line":"to be able to specify a VIF model of type SR-IOV for network attachments.  This"},{"line_number":15,"context_line":"feature improve the usability of SR-IOV network devices.  Currently booting a"},{"line_number":16,"context_line":"guest with NIC SR-IOV attachment requires the user to first create a Neutron"},{"line_number":17,"context_line":"port making it a multi-steps procedure."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_1a2bb695","line":14,"range":{"start_line":14,"start_character":73,"end_line":14,"end_character":75},"in_reply_to":"dab17558_434a4627","updated":"2016-05-25 14:33:21.000000000","message":"Done","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f0a6e69dac18e1806bfd8ec0214ae76ba739f778","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint describes the extension of the glance image properties in order"},{"line_number":14,"context_line":"to be able to specify a VIF model of type SR-IOV for network attachments.  This"},{"line_number":15,"context_line":"feature improve the usability of SR-IOV network devices.  Currently booting a"},{"line_number":16,"context_line":"guest with NIC SR-IOV attachment requires the user to first create a Neutron"},{"line_number":17,"context_line":"port making it a multi-steps procedure."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_23dbc250","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":15},"updated":"2016-05-10 15:18:23.000000000","message":"s/improve/improves","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint describes the extension of the glance image properties in order"},{"line_number":14,"context_line":"to be able to specify a VIF model of type SR-IOV for network attachments.  This"},{"line_number":15,"context_line":"feature improve the usability of SR-IOV network devices.  Currently booting a"},{"line_number":16,"context_line":"guest with NIC SR-IOV attachment requires the user to first create a Neutron"},{"line_number":17,"context_line":"port making it a multi-steps procedure."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_ba126a60","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":15},"in_reply_to":"dab17558_23dbc250","updated":"2016-05-25 14:33:21.000000000","message":"Done","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f0a6e69dac18e1806bfd8ec0214ae76ba739f778","unresolved":false,"context_lines":[{"line_number":61,"context_line":"that are booted with this specific image to be loaded with the corresponding"},{"line_number":62,"context_line":"network drivers."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"For example, a VIF model for an e1000 network device is configured as follow:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"::"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_86671cb6","line":64,"range":{"start_line":64,"start_character":15,"end_line":64,"end_character":37},"updated":"2016-05-10 15:18:23.000000000","message":"looking on the existing code there is virtualsriovethernetcard\nsee \nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L404-L405\n\nDo you know for what is used?","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":61,"context_line":"that are booted with this specific image to be loaded with the corresponding"},{"line_number":62,"context_line":"network drivers."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"For example, a VIF model for an e1000 network device is configured as follow:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"::"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_d5729fe2","line":64,"range":{"start_line":64,"start_character":15,"end_line":64,"end_character":37},"in_reply_to":"dab17558_86671cb6","updated":"2016-05-25 14:33:21.000000000","message":"I looked around, and I don\u0027t understand how this is used.\n\nBut it doesn\u0027t seems to impact this blueprint.\n\nThis is the supported vif model currently: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L47","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"723a423cc4befd58257a484882ce8ca749d38966","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"::"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  $ glance image-update --property vif_model\u003de1000 myimage.img"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"This proposal suggests to augment this mechanism in order to support a VIF"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_02415d38","line":68,"updated":"2016-05-10 14:05:42.000000000","message":"isn\u0027t this hw_vif_model?\nhttps://github.com/openstack/nova/blob/11dcbe7911a61229ea5a0df0e2cfa2c113f76b1c/nova/objects/image_meta.py#L306","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"::"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  $ glance image-update --property vif_model\u003de1000 myimage.img"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"This proposal suggests to augment this mechanism in order to support a VIF"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_b009e92e","line":68,"in_reply_to":"dab17558_02415d38","updated":"2016-05-25 14:33:21.000000000","message":"Done","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"723a423cc4befd58257a484882ce8ca749d38966","unresolved":false,"context_lines":[{"line_number":78,"context_line":"compute API then creates a corresponding PCI request for this particular"},{"line_number":79,"context_line":"port.  The PCI request is then used by the scheduler for selecting a compute"},{"line_number":80,"context_line":"that has hardware resources to accommodate SR-IOV networking.  In the end"},{"line_number":81,"context_line":"a PCI device (based on the PCI request) will be allocate on the target"},{"line_number":82,"context_line":"compute."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"In the case that interests us, the same logic needs to be applied for guests"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_626149d3","line":81,"updated":"2016-05-10 14:05:42.000000000","message":"nit: s/allocate/allocated/","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":78,"context_line":"compute API then creates a corresponding PCI request for this particular"},{"line_number":79,"context_line":"port.  The PCI request is then used by the scheduler for selecting a compute"},{"line_number":80,"context_line":"that has hardware resources to accommodate SR-IOV networking.  In the end"},{"line_number":81,"context_line":"a PCI device (based on the PCI request) will be allocate on the target"},{"line_number":82,"context_line":"compute."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"In the case that interests us, the same logic needs to be applied for guests"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_702661bb","line":81,"in_reply_to":"dab17558_626149d3","updated":"2016-05-25 14:33:21.000000000","message":"Done","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"723a423cc4befd58257a484882ce8ca749d38966","unresolved":false,"context_lines":[{"line_number":79,"context_line":"port.  The PCI request is then used by the scheduler for selecting a compute"},{"line_number":80,"context_line":"that has hardware resources to accommodate SR-IOV networking.  In the end"},{"line_number":81,"context_line":"a PCI device (based on the PCI request) will be allocate on the target"},{"line_number":82,"context_line":"compute."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"In the case that interests us, the same logic needs to be applied for guests"},{"line_number":85,"context_line":"that are using an image that specifies an SR-IOV VIF model.  Therefore we"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_a2c97128","line":82,"updated":"2016-05-10 14:05:42.000000000","message":"compute node.","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":79,"context_line":"port.  The PCI request is then used by the scheduler for selecting a compute"},{"line_number":80,"context_line":"that has hardware resources to accommodate SR-IOV networking.  In the end"},{"line_number":81,"context_line":"a PCI device (based on the PCI request) will be allocate on the target"},{"line_number":82,"context_line":"compute."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"In the case that interests us, the same logic needs to be applied for guests"},{"line_number":85,"context_line":"that are using an image that specifies an SR-IOV VIF model.  Therefore we"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_f03a51cc","line":82,"in_reply_to":"dab17558_a2c97128","updated":"2016-05-25 14:33:21.000000000","message":"Done","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"723a423cc4befd58257a484882ce8ca749d38966","unresolved":false,"context_lines":[{"line_number":97,"context_line":"nova libvirt driver.  This component (more specifically the VIF objects) will"},{"line_number":98,"context_line":"be modified to support SR-IOV so that the corresponding network device can be"},{"line_number":99,"context_line":"properly specified in the instance XML (the format is dictated by libvirt)."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_0254bd50","line":100,"updated":"2016-05-10 14:05:42.000000000","message":"can you also add the revised to steps to boot an instance with this proposal.\nespecially, what is the value for hw_vif_model for sr-iov and direct pass through?","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":97,"context_line":"nova libvirt driver.  This component (more specifically the VIF objects) will"},{"line_number":98,"context_line":"be modified to support SR-IOV so that the corresponding network device can be"},{"line_number":99,"context_line":"properly specified in the instance XML (the format is dictated by libvirt)."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_30ae9985","line":100,"in_reply_to":"dab17558_0254bd50","updated":"2016-05-25 14:33:21.000000000","message":"Done","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f0a6e69dac18e1806bfd8ec0214ae76ba739f778","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_a64ce0c8","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":4},"updated":"2016-05-10 15:18:23.000000000","message":"the Alternatives is this bp https://review.openstack.org/#/c/138808/","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_905b05f6","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":4},"in_reply_to":"dab17558_a64ce0c8","updated":"2016-05-25 14:33:21.000000000","message":"Done","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"723a423cc4befd58257a484882ce8ca749d38966","unresolved":false,"context_lines":[{"line_number":132,"context_line":"Other end user impact"},{"line_number":133,"context_line":"---------------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"None"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_227f4116","line":135,"updated":"2016-05-10 14:05:42.000000000","message":"with this approach, only catch is that when there are multiple devices required on an instance, say management and data, then all of them will be of same model i.e sr-iov in this case. In such scenario, I guess we will have to use the approach given at L30?","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":132,"context_line":"Other end user impact"},{"line_number":133,"context_line":"---------------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"None"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_70d02154","line":135,"in_reply_to":"dab17558_227f4116","updated":"2016-05-25 14:33:21.000000000","message":"I agree, or maybe we can extend the proposal to support multiple hw_vif_model in the image ?","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f0a6e69dac18e1806bfd8ec0214ae76ba739f778","unresolved":false,"context_lines":[{"line_number":173,"context_line":"* Modify the nova.network.neutronv2.API."},{"line_number":174,"context_line":"* Modify the nova.virt.libvirt.vif to handle the specification of SR-IOV VIF"},{"line_number":175,"context_line":"  model via the image properties."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Dependencies"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_0685ec05","line":176,"updated":"2016-05-10 15:18:23.000000000","message":"you will need to update the VIFModel Enum in nova/objects/fields.py","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3d1b35d059e1c56f32f9439bef8a19ad6e04daba","unresolved":false,"context_lines":[{"line_number":173,"context_line":"* Modify the nova.network.neutronv2.API."},{"line_number":174,"context_line":"* Modify the nova.virt.libvirt.vif to handle the specification of SR-IOV VIF"},{"line_number":175,"context_line":"  model via the image properties."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Dependencies"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_f002513d","line":176,"in_reply_to":"dab17558_0685ec05","updated":"2016-05-25 14:33:21.000000000","message":"I think we just care about that:\nhttps://github.com/openstack/nova/blob/master/nova/network/model.py#L116","commit_id":"962fda7c794e424b397a1d91b1138bbb787d9ee7"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"05923fbc16fb7debc154848131081b6eee15d66f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Neutron port by having Nova do the work on the behalf of the user. The goal"},{"line_number":38,"context_line":"is to improve the usability of booting instances with SR-IOV network devices."},{"line_number":39,"context_line":"Better usability can limit errors (specifying wrong arguments) or limit race"},{"line_number":40,"context_line":"conditions (such as multiple instances trying to bind with the same port)."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Nova already creates neutron port for requested networks that are specified"},{"line_number":43,"context_line":"when spawning an instance. The use case of creating a neutron port for an"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_77b8fbc8","line":40,"updated":"2016-05-31 12:36:47.000000000","message":"In addition, admins/image owners would want to specify using SR-IOV device for the instance in order to meet the SLA requirements of the VNFs.\nOtherwise, if the control is given to tenant/user, then booting the instance with different vif model may not yield the desired performance.","commit_id":"32643abb6559b9d33dbcf57ee40509180758013d"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"05923fbc16fb7debc154848131081b6eee15d66f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Use Cases"},{"line_number":49,"context_line":"---------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A user wants to launch a guest with an SR-IOV network device and they want"},{"line_number":52,"context_line":"nova to create the neutron port for him like it does for any other type of"},{"line_number":53,"context_line":"ports."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_977f5f65","line":51,"updated":"2016-05-31 12:36:47.000000000","message":"nit: /A user/Users/ \n/an SR-IOV/SR-IOV/\nor may be rephrase as:\nUsers want to launch an instance with SR-IOV device and expect nova to create the neutron port like it does for any other type of ports.","commit_id":"32643abb6559b9d33dbcf57ee40509180758013d"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"05923fbc16fb7debc154848131081b6eee15d66f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"::"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  $ glance image-update --property hw_vif_model\u003dsriov myimage.img"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Alternatives"},{"line_number":110,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_b7b42382","line":107,"updated":"2016-05-31 12:36:47.000000000","message":"Looking at L94 and L107, would be better if we consistently use\nvnic_type\u003dhw_vif_model\u003dsriov i.e VFs and\nvnic_type\u003dhw_vif_model\u003ddirect for direct passthrough i.e PFs","commit_id":"32643abb6559b9d33dbcf57ee40509180758013d"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"05923fbc16fb7debc154848131081b6eee15d66f","unresolved":false,"context_lines":[{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"The glance user documentation guide will need to be modified"},{"line_number":206,"context_line":"(http://docs.openstack.org/user-guide/common/cli_manage_images.html)."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_f24d193f","line":206,"updated":"2016-05-31 12:36:47.000000000","message":"and also sr-iov admin guide can be updated.","commit_id":"32643abb6559b9d33dbcf57ee40509180758013d"}]}