)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},"change_message_id":"fc35c08cfca28cab052de87d15e9e1fb3467f91e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Live Migration of Rescued Instances"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an instance is rescued the libvirt driver creates a file in the."},{"line_number":10,"context_line":"instance directory that contains the original instance xml. This file"},{"line_number":11,"context_line":"is used when unrescuing the instance to revert to the original disk"},{"line_number":12,"context_line":"configuration. However, this file is not necessary to restore the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dab17558_b0d868f0","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":69},"updated":"2016-05-17 10:38:03.000000000","message":"nit: random full-stop in the middle of a sentence","commit_id":"358ec6fe0efa0fefa5304b1c3ecec223b61a7022"}],"specs/newton/approved/live-migrate-rescued-instances.rst":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"9072d576f716fd137d86c81e63b2012396d127eb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"REST API impact"},{"line_number":69,"context_line":"---------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"None."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Security impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_ca3353f5","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":5},"updated":"2016-05-03 16:24:07.000000000","message":"I think we need a new API version as at the moment the live migration is not allowed when an instance is in RESCUED state, so basically we return the status code for the API call","commit_id":"d0aba147240321f854ecca50b44783a8553cc84c"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"1f282e99ea1ad8ba2a4130c99dc252b857521f6a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"REST API impact"},{"line_number":69,"context_line":"---------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"None."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Security impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_913de6df","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":5},"in_reply_to":"1a122d0e_ca3353f5","updated":"2016-05-04 14:42:26.000000000","message":"my last sentence is not clear, sorry for that.\nI meant:\nthe live migration is not allowed at the moment for instances in RESCUED state, allowing that is a new API version because we change the return code for the API from a 4xx code to a 2xx code. \nBecause of that I think we need a new microversion","commit_id":"d0aba147240321f854ecca50b44783a8553cc84c"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5558031fedce16876d5613c442b0cefa0d1192f2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Blueprint:https://blueprints.launchpad.net/nova/+spec/live-migrate-rescued-instances"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When an instance is rescued the libvirt driver creates a file in the."},{"line_number":14,"context_line":"instance directory that contains the original instance xml. This file"},{"line_number":15,"context_line":"is used when unrescuing the instance to revert to the original disk"},{"line_number":16,"context_line":"configuration. However, this file is not necessary to restore the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_8567a4e9","line":13,"range":{"start_line":13,"start_character":68,"end_line":13,"end_character":69},"updated":"2016-05-12 12:14:13.000000000","message":"s/.//","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"2d9e110d2c1f7b29b0c3ccc91774dda7a4f7c501","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Blueprint:https://blueprints.launchpad.net/nova/+spec/live-migrate-rescued-instances"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When an instance is rescued the libvirt driver creates a file in the."},{"line_number":14,"context_line":"instance directory that contains the original instance xml. This file"},{"line_number":15,"context_line":"is used when unrescuing the instance to revert to the original disk"},{"line_number":16,"context_line":"configuration. However, this file is not necessary to restore the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_88da19e8","line":13,"range":{"start_line":13,"start_character":68,"end_line":13,"end_character":69},"in_reply_to":"dab17558_8567a4e9","updated":"2016-05-12 12:30:31.000000000","message":"Done","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5558031fedce16876d5613c442b0cefa0d1192f2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"----------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"As an operator of an OpenStack cloud, I like to live migrations all"},{"line_number":32,"context_line":"instances on a node in order to perform maintenance."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_65d9e083","line":31,"range":{"start_line":31,"start_character":53,"end_line":31,"end_character":63},"updated":"2016-05-12 12:14:13.000000000","message":"migrate","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"2d9e110d2c1f7b29b0c3ccc91774dda7a4f7c501","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"----------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"As an operator of an OpenStack cloud, I like to live migrations all"},{"line_number":32,"context_line":"instances on a node in order to perform maintenance."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_08ed898e","line":31,"range":{"start_line":31,"start_character":53,"end_line":31,"end_character":63},"in_reply_to":"dab17558_65d9e083","updated":"2016-05-12 12:30:31.000000000","message":"Done","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5558031fedce16876d5613c442b0cefa0d1192f2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"The unrescue method will be amended to remove the attempt to read the"},{"line_number":41,"context_line":"unrescue.xml file and delete the libvirt.xml file."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The unrescue method will _reboot_hard method call to restore the"},{"line_number":44,"context_line":"instance to an active state."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Live migration process will be amended to permit migration of instances"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_050454c4","line":43,"range":{"start_line":43,"start_character":25,"end_line":43,"end_character":49},"updated":"2016-05-12 12:14:13.000000000","message":"call _reboot_hard method","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"2d9e110d2c1f7b29b0c3ccc91774dda7a4f7c501","unresolved":false,"context_lines":[{"line_number":40,"context_line":"The unrescue method will be amended to remove the attempt to read the"},{"line_number":41,"context_line":"unrescue.xml file and delete the libvirt.xml file."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The unrescue method will _reboot_hard method call to restore the"},{"line_number":44,"context_line":"instance to an active state."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Live migration process will be amended to permit migration of instances"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_c8fb8146","line":43,"range":{"start_line":43,"start_character":25,"end_line":43,"end_character":49},"in_reply_to":"dab17558_050454c4","updated":"2016-05-12 12:30:31.000000000","message":"Done","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5558031fedce16876d5613c442b0cefa0d1192f2","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Live migration process will be amended to permit migration of instances"},{"line_number":47,"context_line":"in a rescued state.  It already preserves the current instance status"},{"line_number":48,"context_line":"whether the migration successful or rolled back."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Alternatives"},{"line_number":51,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_65f560ca","line":48,"range":{"start_line":48,"start_character":21,"end_line":48,"end_character":22},"updated":"2016-05-12 12:14:13.000000000","message":"is","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"2d9e110d2c1f7b29b0c3ccc91774dda7a4f7c501","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Live migration process will be amended to permit migration of instances"},{"line_number":47,"context_line":"in a rescued state.  It already preserves the current instance status"},{"line_number":48,"context_line":"whether the migration successful or rolled back."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Alternatives"},{"line_number":51,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_a8f8bd4a","line":48,"range":{"start_line":48,"start_character":21,"end_line":48,"end_character":22},"in_reply_to":"dab17558_65f560ca","updated":"2016-05-12 12:30:31.000000000","message":"Done","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5558031fedce16876d5613c442b0cefa0d1192f2","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Another option is to write the original libvirt xml to the database"},{"line_number":57,"context_line":"during the rescue operation so that it can be retrieved by the target"},{"line_number":58,"context_line":"compute node during unrescue. However this unnecessary and would require"},{"line_number":59,"context_line":"a database schema change to add a table to store this information (no"},{"line_number":60,"context_line":"existing suitable table has a field big enough to accommodate the xml"},{"line_number":61,"context_line":"text)."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_252a382d","line":58,"range":{"start_line":58,"start_character":42,"end_line":58,"end_character":43},"updated":"2016-05-12 12:14:13.000000000","message":"is","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"2d9e110d2c1f7b29b0c3ccc91774dda7a4f7c501","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Another option is to write the original libvirt xml to the database"},{"line_number":57,"context_line":"during the rescue operation so that it can be retrieved by the target"},{"line_number":58,"context_line":"compute node during unrescue. However this unnecessary and would require"},{"line_number":59,"context_line":"a database schema change to add a table to store this information (no"},{"line_number":60,"context_line":"existing suitable table has a field big enough to accommodate the xml"},{"line_number":61,"context_line":"text)."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_489e7108","line":58,"range":{"start_line":58,"start_character":42,"end_line":58,"end_character":43},"in_reply_to":"dab17558_252a382d","updated":"2016-05-12 12:30:31.000000000","message":"Done","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5558031fedce16876d5613c442b0cefa0d1192f2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"User attemting to unrescue an instance whilst a migration was in"},{"line_number":90,"context_line":"progress.would be prevented from doing so until the migoration was"},{"line_number":91,"context_line":"complete."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_a5c4685f","line":90,"range":{"start_line":90,"start_character":52,"end_line":90,"end_character":62},"updated":"2016-05-12 12:14:13.000000000","message":"migration","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"5558031fedce16876d5613c442b0cefa0d1192f2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"User attemting to unrescue an instance whilst a migration was in"},{"line_number":90,"context_line":"progress.would be prevented from doing so until the migoration was"},{"line_number":91,"context_line":"complete."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_45b3fc0a","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":9},"updated":"2016-05-12 12:14:13.000000000","message":"s/./ /","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"2d9e110d2c1f7b29b0c3ccc91774dda7a4f7c501","unresolved":false,"context_lines":[{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"User attemting to unrescue an instance whilst a migration was in"},{"line_number":90,"context_line":"progress.would be prevented from doing so until the migoration was"},{"line_number":91,"context_line":"complete."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_e8bf655e","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":9},"in_reply_to":"dab17558_45b3fc0a","updated":"2016-05-12 12:30:31.000000000","message":"Done","commit_id":"5f589405c2d39cbf27a183c39b12ce577476fe6a"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"17e30fc81dbb0373de9fea4f5bf8fc5820072d10","unresolved":false,"context_lines":[{"line_number":29,"context_line":"----------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"As an operator of an OpenStack cloud, I like to live migrate all"},{"line_number":32,"context_line":"instances on a node in order to perform maintenance."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_433fe6b3","line":32,"updated":"2016-05-16 14:13:33.000000000","message":"nit: all *active* instances - ones that are down are cold migrated. Only a nit because you could assume this is implied, but change if you need to roll this again.","commit_id":"358ec6fe0efa0fefa5304b1c3ecec223b61a7022"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"22ced2b8de81fc80fbac1f6d1b53d4668f754486","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Live migration method in the compute manager will be amended to"},{"line_number":38,"context_line":"permit migration of instances in a rescued state."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The libvirt driver will be enhanced as follows to enable live migration"},{"line_number":41,"context_line":"of instances in a rescued state."}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_11a8788c","line":38,"updated":"2016-05-20 18:53:49.000000000","message":"So I get that live migration is wanted to clear a system for maintenance. But in the rescued server case, the server isn\u0027t actually running production services right? You\u0027ve booted them up to look at disks. Do you really need to live migrate them? Couldn\u0027t it just be stopped and started up on another server?","commit_id":"358ec6fe0efa0fefa5304b1c3ecec223b61a7022"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"51bbef711be5cfe87948b0095a13af6efcce3431","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Live migration method in the compute manager will be amended to"},{"line_number":38,"context_line":"permit migration of instances in a rescued state."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The libvirt driver will be enhanced as follows to enable live migration"},{"line_number":41,"context_line":"of instances in a rescued state."}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_84f24404","line":38,"in_reply_to":"bab6814e_11a8788c","updated":"2016-05-23 07:32:41.000000000","message":"Nope, if a customer rescues their instance to perform data recovery or try to address issues preventing it from  booting then stopping the instance would interfere with that activity.","commit_id":"358ec6fe0efa0fefa5304b1c3ecec223b61a7022"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"22ced2b8de81fc80fbac1f6d1b53d4668f754486","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Other drivers do not support live migration of instances in a rescued"},{"line_number":53,"context_line":"state so a new driver capabilities flag will be added called"},{"line_number":54,"context_line":"code:`supports_live_migrate_rescued`.  This will be set to False for"},{"line_number":55,"context_line":"all drivers except the libvirt driver."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"If the driver supports live migration of instances in a rescued state"},{"line_number":58,"context_line":"the os-migrateLive action API call will return a response code of 202"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_113358ac","line":55,"updated":"2016-05-20 18:53:49.000000000","message":"It looks like only vmware and xenapi support rescue at all at this point. It would be nice to have a 30 minute chat with each  of those teams to understand what this means to them, and how it would fit there.","commit_id":"358ec6fe0efa0fefa5304b1c3ecec223b61a7022"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"51bbef711be5cfe87948b0095a13af6efcce3431","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Other drivers do not support live migration of instances in a rescued"},{"line_number":53,"context_line":"state so a new driver capabilities flag will be added called"},{"line_number":54,"context_line":"code:`supports_live_migrate_rescued`.  This will be set to False for"},{"line_number":55,"context_line":"all drivers except the libvirt driver."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"If the driver supports live migration of instances in a rescued state"},{"line_number":58,"context_line":"the os-migrateLive action API call will return a response code of 202"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_4477bc9f","line":55,"in_reply_to":"bab6814e_113358ac","updated":"2016-05-23 07:32:41.000000000","message":"I spoke to John Garbutt and if I understood him correctly he said that xen stores information in a local database when rescuing an instance so live migration of rescued instance with xen is not possible.  Happy to explore this further with John or other xen experts if this would be useful.\n\nWho should I talk to about vmware?\n\nDoes hyperv support rescue?","commit_id":"358ec6fe0efa0fefa5304b1c3ecec223b61a7022"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"21b5fab18a7a69aef795f4cf64a00dc9cd424948","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Other drivers do not support live migration of instances in a rescued"},{"line_number":53,"context_line":"state so a new driver capabilities flag will be added called"},{"line_number":54,"context_line":"code:`supports_live_migrate_rescued`.  This will be set to False for"},{"line_number":55,"context_line":"all drivers except the libvirt driver."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"If the driver supports live migration of instances in a rescued state"},{"line_number":58,"context_line":"the os-migrateLive action API call will return a response code of 202"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_a26e0394","line":55,"in_reply_to":"bab6814e_4477bc9f","updated":"2016-05-24 13:57:17.000000000","message":"Its probably worth an ML thread.","commit_id":"358ec6fe0efa0fefa5304b1c3ecec223b61a7022"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2e7e757405603e3245e4ad404990e2fa7b4851d5","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Live migration method in the compute manager will be amended to"},{"line_number":38,"context_line":"permit migration of instances in a rescued state. The implementation"},{"line_number":39,"context_line":"of rescue and live migration operations are different for each driver."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HyperV"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_ee9a5f6d","line":39,"updated":"2016-05-31 10:42:40.000000000","message":"not really sure about this. When I tested live migration of rescued instances on Hyper-V, all I had to do was add vm_states.RESCUED to the nova.compute.api.API.live_migrate check_instance_state decorator and it worked.","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"00fa538ac5bdffc59962e07774f9e9318f1ebbe8","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Live migration method in the compute manager will be amended to"},{"line_number":38,"context_line":"permit migration of instances in a rescued state. The implementation"},{"line_number":39,"context_line":"of rescue and live migration operations are different for each driver."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HyperV"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_990ddbea","line":39,"in_reply_to":"9abb7d3a_ee9a5f6d","updated":"2016-05-31 10:55:02.000000000","message":"So in HyperV case no code changes are needed to support live migration of rescued instances but in other cases (XenAPI ans libvirt) changes are required, this is the point I was making","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2e7e757405603e3245e4ad404990e2fa7b4851d5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"permit migration of instances in a rescued state. The implementation"},{"line_number":39,"context_line":"of rescue and live migration operations are different for each driver."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HyperV"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Have recently added support for rescue and live migration of rescued"},{"line_number":44,"context_line":"instances is supported."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_2e32a75f","line":41,"updated":"2016-05-31 10:42:40.000000000","message":"femtonit: Hyper-V and VMware are trademarked names, which means that their names should be used exactly.\n\nSo, Hyper-V here, and VMWare below.\n\nBut, it is just a suggestion. :)","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"00fa538ac5bdffc59962e07774f9e9318f1ebbe8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"permit migration of instances in a rescued state. The implementation"},{"line_number":39,"context_line":"of rescue and live migration operations are different for each driver."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HyperV"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Have recently added support for rescue and live migration of rescued"},{"line_number":44,"context_line":"instances is supported."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_f9d6a7ef","line":41,"in_reply_to":"9abb7d3a_2e32a75f","updated":"2016-05-31 10:55:02.000000000","message":"Done","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"5e9b082d5536190ba1b035ad2ae639252528766f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"permit migration of instances in a rescued state. The implementation"},{"line_number":39,"context_line":"of rescue and live migration operations are different for each driver."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HyperV"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Have recently added support for rescue and live migration of rescued"},{"line_number":44,"context_line":"instances is supported."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_d93c83ca","line":41,"in_reply_to":"9abb7d3a_2e32a75f","updated":"2016-05-31 10:44:13.000000000","message":"oups - I meant VMware. :)","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4f449a7fa1efcdc10329596806cb66d86ec2dc33","unresolved":false,"context_lines":[{"line_number":38,"context_line":"permit migration of instances in a rescued state. The implementation"},{"line_number":39,"context_line":"of rescue and live migration operations are different for each driver."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"HyperV"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Have recently added support for rescue and live migration of rescued"},{"line_number":44,"context_line":"instances is supported."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_79e0f7fa","line":41,"in_reply_to":"9abb7d3a_d93c83ca","updated":"2016-05-31 10:52:32.000000000","message":"They are, we should fix that up in a follow up patch.","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2e7e757405603e3245e4ad404990e2fa7b4851d5","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Vmware"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Do not currently support live migration of instances across compute"},{"line_number":49,"context_line":"nodes but proposed patch https://review.openstack.org/#/c/270116/ will"},{"line_number":50,"context_line":"address this. When this is implemented live migration of rescued"},{"line_number":51,"context_line":"instances will be supported."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_4e144b9f","line":48,"updated":"2016-05-31 10:42:40.000000000","message":"Does not","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"00fa538ac5bdffc59962e07774f9e9318f1ebbe8","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Vmware"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Do not currently support live migration of instances across compute"},{"line_number":49,"context_line":"nodes but proposed patch https://review.openstack.org/#/c/270116/ will"},{"line_number":50,"context_line":"address this. When this is implemented live migration of rescued"},{"line_number":51,"context_line":"instances will be supported."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_99979b39","line":48,"in_reply_to":"9abb7d3a_4e144b9f","updated":"2016-05-31 10:55:02.000000000","message":"Done","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2e7e757405603e3245e4ad404990e2fa7b4851d5","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"XenAPI and Libvirt"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Do not currently support the live migration of rescued instances due"},{"line_number":56,"context_line":"to information stored locally on the compute node when an instance is"},{"line_number":57,"context_line":"rescued. Live migration does not copy this information to the target"},{"line_number":58,"context_line":"compute node so a subsequent unrescue operation would fail."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_ee725f10","line":55,"updated":"2016-05-31 10:42:40.000000000","message":"ditto.","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"00fa538ac5bdffc59962e07774f9e9318f1ebbe8","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"XenAPI and Libvirt"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Do not currently support the live migration of rescued instances due"},{"line_number":56,"context_line":"to information stored locally on the compute node when an instance is"},{"line_number":57,"context_line":"rescued. Live migration does not copy this information to the target"},{"line_number":58,"context_line":"compute node so a subsequent unrescue operation would fail."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_f91b47c8","line":55,"in_reply_to":"9abb7d3a_ee725f10","updated":"2016-05-31 10:55:02.000000000","message":"I think \u0027Do not\u0027 is correct here it reads better that way when talking about two items?","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"3fc43244090ce678e4b3fbec004cccb53c61213e","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"A similar approach is proposed for XenAPI."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"To support drivers that do not support live migration of instances in a"},{"line_number":76,"context_line":"rescued state so a new driver capabilities flag will be added called"},{"line_number":77,"context_line":"code:`supports_live_migrate_rescued`. This will be set to False for"},{"line_number":78,"context_line":"drivers that do not support the migration of rescued instances."}],"source_content_type":"text/x-rst","patch_set":11,"id":"bab6814e_e3389ff0","line":75,"updated":"2016-05-26 10:58:49.000000000","message":"nit: (only do this if you have to change the spec again anyway - you can clean up the text as a separate patch after this is approved). This sentence does not make sense. It also follows on from the XenAPI/libvirt discussion (you put headings for each hypervisor above, so you could put a heading like\"Hypervisors that do not live migration rescued instances\" before this paragraph.","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"00fa538ac5bdffc59962e07774f9e9318f1ebbe8","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"A similar approach is proposed for XenAPI."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"To support drivers that do not support live migration of instances in a"},{"line_number":76,"context_line":"rescued state so a new driver capabilities flag will be added called"},{"line_number":77,"context_line":"code:`supports_live_migrate_rescued`. This will be set to False for"},{"line_number":78,"context_line":"drivers that do not support the migration of rescued instances."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9abb7d3a_f9718745","line":75,"in_reply_to":"bab6814e_e3389ff0","updated":"2016-05-31 10:55:02.000000000","message":"Done","commit_id":"8a8e5a49cafb80bee446d9ebcd3354958f052bb5"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"8c3778380ed3c603de8c4f37833e88f03ddb4ca9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9abb7d3a_ac466c4c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":60},"updated":"2016-06-01 06:46:25.000000000","message":"missing title","commit_id":"85f5bf2ae37e1f686b9db57d4c6f82a15736443c"}]}