)]}'
{"specs/newton/approved/direct-upload-for-file.rst":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"52c7497317177865ac33bf0c15fefe2e9d7e2922","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Added new file upload scheme for Nova."},{"line_number":35,"context_line":"With that change Nova can upload snapshot images directly"},{"line_number":36,"context_line":"from snapshot working directory to glance file backend."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_d1f71057","line":36,"updated":"2016-05-20 19:03:27.000000000","message":"Does glance already hand out these urls? Are there glance changes?","commit_id":"7aed8287912332bd43d7ed4dce9b0e579acad8b1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"52c7497317177865ac33bf0c15fefe2e9d7e2922","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Nova service just uses direct_url for uploading glance images."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Instead of sending through glance node,"},{"line_number":48,"context_line":"nova-compute service can directly upload image"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_d11b90c8","line":45,"updated":"2016-05-20 19:03:27.000000000","message":"The proposed change section could use a lot more detail. Provide specific points in the code that would be changed, and what these urls look like, how authentication happens to them, what happens during a partial upload and network hicup.","commit_id":"7aed8287912332bd43d7ed4dce9b0e579acad8b1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"52c7497317177865ac33bf0c15fefe2e9d7e2922","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    3. if anything failes in the process,"},{"line_number":56,"context_line":"        the image will be uploaded through glance node as before."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Failures will be reported in the form of stack traces in the nova compute logs."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Alternatives"},{"line_number":61,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_f147b4b9","line":58,"updated":"2016-05-20 19:03:27.000000000","message":"We should never add stack traces to the nova compute logs.","commit_id":"7aed8287912332bd43d7ed4dce9b0e579acad8b1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"52c7497317177865ac33bf0c15fefe2e9d7e2922","unresolved":false,"context_lines":[{"line_number":75,"context_line":"Security impact"},{"line_number":76,"context_line":"---------------"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"None"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Notifications impact"},{"line_number":81,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_d1727010","line":78,"updated":"2016-05-20 19:03:27.000000000","message":"If we aren\u0027t talking to Glance API, we\u0027ve bypassed keystone for this opperation. How do we get credentials for the backend?","commit_id":"7aed8287912332bd43d7ed4dce9b0e579acad8b1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"52c7497317177865ac33bf0c15fefe2e9d7e2922","unresolved":false,"context_lines":[{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Other deployer impact"},{"line_number":96,"context_line":"---------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"None"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_3162dc3e","line":96,"updated":"2016-05-20 19:03:27.000000000","message":"What configurations would this work for.","commit_id":"7aed8287912332bd43d7ed4dce9b0e579acad8b1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"52c7497317177865ac33bf0c15fefe2e9d7e2922","unresolved":false,"context_lines":[{"line_number":131,"context_line":"The unit tests will of course cover the new code."},{"line_number":132,"context_line":"As direct upload is enabled automatically, there is no need to change the"},{"line_number":133,"context_line":"tempest tests."},{"line_number":134,"context_line":"And make sure that the direct url is used when configured conrrectly"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Documentation Impact"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_11ceb82d","line":134,"updated":"2016-05-20 19:03:27.000000000","message":"This definitely needs more than unit tests.","commit_id":"7aed8287912332bd43d7ed4dce9b0e579acad8b1"}]}