)]}'
{"specs/newton/approved/async-live-migration-rest-check.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5b05a5648aaf3ba45170ffd5e9e0369478a4d139","unresolved":false,"context_lines":[{"line_number":16,"context_line":"way, and is quite complex by itself, from api service request is send over"},{"line_number":17,"context_line":"RPC call to conductor, which triggers 2 more rpc calls to compute, and only if"},{"line_number":18,"context_line":"everything is OK, request triggers rpc cast to compute, to start process, and"},{"line_number":19,"context_line":"REST API layer response with 202."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_c98ff2ca","line":19,"updated":"2016-05-24 13:37:39.000000000","message":"I suggest you shrink this intro paragraph to something like.\n\nThe existing nova live-migration operation is complex: Verification of the environment is required before accepting and triggering the live-migration. This verification is done in a synchronous manner with several RPC calls that must all be successful before the process can being and the REST API layer can respond. It would be better to make the checks asynchronous and have the REST API respond with an immediate 202.\n\nAnd then add detail about the rpc calls into the problem description below","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"26c61eea7388dd1e3ea0860f8750e7b75f0e71ad","unresolved":false,"context_lines":[{"line_number":16,"context_line":"way, and is quite complex by itself, from api service request is send over"},{"line_number":17,"context_line":"RPC call to conductor, which triggers 2 more rpc calls to compute, and only if"},{"line_number":18,"context_line":"everything is OK, request triggers rpc cast to compute, to start process, and"},{"line_number":19,"context_line":"REST API layer response with 202."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_085e0645","line":19,"in_reply_to":"bab6814e_c98ff2ca","updated":"2016-05-24 17:23:24.000000000","message":"Done","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5b05a5648aaf3ba45170ffd5e9e0369478a4d139","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Existing workflow is complex, and leaves space for timeouts, and also blocks"},{"line_number":26,"context_line":"HTTP request, which in general is bad."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_89084a2f","line":26,"updated":"2016-05-24 13:37:39.000000000","message":"What about:\n\nThe existing workflow for the environment verification required before a live-migration involves several steps: an RPC call is made to the conductor which triggers two more RPC calls to the relevant compute nodes. Only once those are okay is there an RPC cast to trigger the migration and a response to the HTTP request.","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"26c61eea7388dd1e3ea0860f8750e7b75f0e71ad","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Existing workflow is complex, and leaves space for timeouts, and also blocks"},{"line_number":26,"context_line":"HTTP request, which in general is bad."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_e808e22f","line":26,"in_reply_to":"bab6814e_89084a2f","updated":"2016-05-24 17:23:24.000000000","message":"Done","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5b05a5648aaf3ba45170ffd5e9e0369478a4d139","unresolved":false,"context_lines":[{"line_number":30,"context_line":"---------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"From the user\u0027s point Nova will respond faster for it\u0027s live-migration request,"},{"line_number":33,"context_line":"forcing operators to check current status with `instance-actions`."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_4c5b102f","line":33,"updated":"2016-05-24 13:37:39.000000000","message":"A user doing a live migration would like to have a fast response to a live-migration request and use the `instance-actions` service to get valid status.","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"26c61eea7388dd1e3ea0860f8750e7b75f0e71ad","unresolved":false,"context_lines":[{"line_number":30,"context_line":"---------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"From the user\u0027s point Nova will respond faster for it\u0027s live-migration request,"},{"line_number":33,"context_line":"forcing operators to check current status with `instance-actions`."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_9b24feaf","line":33,"in_reply_to":"bab6814e_4c5b102f","updated":"2016-05-24 17:23:24.000000000","message":"Done","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5b05a5648aaf3ba45170ffd5e9e0369478a4d139","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Instead of doing all check in blocking way this spec propose to record"},{"line_number":39,"context_line":"conductor\u0027s method with `wrap_instance_event` so it will be possible to check"},{"line_number":40,"context_line":"live-migration status. Nova API should send rpc cast to conductor, so response"},{"line_number":41,"context_line":"will be immediately send to operator."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_0c9f48b5","line":41,"updated":"2016-05-24 13:37:39.000000000","message":"check live-migration status. Upon receiving a request for a live-migration the Nova API will send an RPC cast to the conductor and then respond immediately to the HTTP response.","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5b05a5648aaf3ba45170ffd5e9e0369478a4d139","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Leave things as is."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Data model impact"},{"line_number":49,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_ac955c89","line":46,"updated":"2016-05-24 13:37:39.000000000","message":"s/as is/as they are/","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"26c61eea7388dd1e3ea0860f8750e7b75f0e71ad","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Leave things as is."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Data model impact"},{"line_number":49,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_1b312eed","line":46,"in_reply_to":"bab6814e_ac955c89","updated":"2016-05-24 17:23:24.000000000","message":"Done","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5b05a5648aaf3ba45170ffd5e9e0369478a4d139","unresolved":false,"context_lines":[{"line_number":54,"context_line":"---------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"As this change makes all check to be done in background, REST API will stop to"},{"line_number":57,"context_line":"response with `badRequest(400)`."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Security impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_8c6e9894","line":57,"updated":"2016-05-24 13:37:39.000000000","message":"As this change will cause verification checks to be done in the background, the number of cases in which the live-migration API will respond with `badRequest(400)` will be limited to receipt of bad input.","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"26c61eea7388dd1e3ea0860f8750e7b75f0e71ad","unresolved":false,"context_lines":[{"line_number":54,"context_line":"---------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"As this change makes all check to be done in background, REST API will stop to"},{"line_number":57,"context_line":"response with `badRequest(400)`."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Security impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_9b723eac","line":57,"in_reply_to":"bab6814e_8c6e9894","updated":"2016-05-24 17:23:24.000000000","message":"Done","commit_id":"9155001cb9df7c44fa66bf6826cbfddbd9d3d3be"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1214331b4e7d3c7accc1dbd82a1ee94cd67021bf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The existing nova live-migration operation is complex: verification of"},{"line_number":14,"context_line":"the environment is required before accepting and triggering the live-migration."},{"line_number":15,"context_line":"This verification is done in a synchronous manner with several RPC calls that"},{"line_number":16,"context_line":"must all be successful before the process can being and the REST API layer can"},{"line_number":17,"context_line":"respond. It would be better to make the checks asynchronous and have the REST"},{"line_number":18,"context_line":"API respond with an immediate 202."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_9e718ce3","line":16,"updated":"2016-05-24 17:45:59.000000000","message":"s/being/begin/","commit_id":"ceaaba190bdda9ea60935684f60a629e0782ea5b"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"02d6c168f77d1c15da8df571c66c7c094129b879","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The existing nova live-migration operation is complex: verification of"},{"line_number":14,"context_line":"the environment is required before accepting and triggering the live-migration."},{"line_number":15,"context_line":"This verification is done in a synchronous manner with several RPC calls that"},{"line_number":16,"context_line":"must all be successful before the process can being and the REST API layer can"},{"line_number":17,"context_line":"respond. It would be better to make the checks asynchronous and have the REST"},{"line_number":18,"context_line":"API respond with an immediate 202."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_6ed193fb","line":16,"in_reply_to":"bab6814e_9e718ce3","updated":"2016-05-24 20:46:51.000000000","message":"Done","commit_id":"ceaaba190bdda9ea60935684f60a629e0782ea5b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1214331b4e7d3c7accc1dbd82a1ee94cd67021bf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Instead of doing all check in blocking way this spec propose to record"},{"line_number":42,"context_line":"conductor\u0027s method with `wrap_instance_event` so it will be possible to check"},{"line_number":43,"context_line":"live-migration status. Upon receiving a request for a live-migration the Nova"},{"line_number":44,"context_line":"API will send an RPC cast to the conductor and then respond immediately with"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_de5af44f","line":41,"updated":"2016-05-24 17:45:59.000000000","message":"proposes","commit_id":"ceaaba190bdda9ea60935684f60a629e0782ea5b"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"02d6c168f77d1c15da8df571c66c7c094129b879","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Instead of doing all check in blocking way this spec propose to record"},{"line_number":42,"context_line":"conductor\u0027s method with `wrap_instance_event` so it will be possible to check"},{"line_number":43,"context_line":"live-migration status. Upon receiving a request for a live-migration the Nova"},{"line_number":44,"context_line":"API will send an RPC cast to the conductor and then respond immediately with"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_4ecc8f61","line":41,"in_reply_to":"bab6814e_de5af44f","updated":"2016-05-24 20:46:51.000000000","message":"Done","commit_id":"ceaaba190bdda9ea60935684f60a629e0782ea5b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"232deee895b2d4c4d93c677aad713cde6b7702a7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"conductor\u0027s method with `wrap_instance_event` so it will be possible to check"},{"line_number":43,"context_line":"live-migration status. Upon receiving a request for a live-migration the Nova"},{"line_number":44,"context_line":"API will send an RPC cast to the conductor and then respond immediately with"},{"line_number":45,"context_line":"the HTTP response."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_4ad3a938","line":45,"updated":"2016-05-25 15:32:38.000000000","message":"So I assume that means users can use the instance_actions to see if the pre-checks have failed or not.","commit_id":"1af40aafd45f47a13dcde8c49cd27b2e7b1e92a0"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"3a8aff3d3083e5f3e8c3b845d5dcb120ff998a3d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"conductor\u0027s method with `wrap_instance_event` so it will be possible to check"},{"line_number":43,"context_line":"live-migration status. Upon receiving a request for a live-migration the Nova"},{"line_number":44,"context_line":"API will send an RPC cast to the conductor and then respond immediately with"},{"line_number":45,"context_line":"the HTTP response."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_cab0398e","line":45,"in_reply_to":"bab6814e_4ad3a938","updated":"2016-05-25 15:45:20.000000000","message":"yes, that\u0027s what I\u0027m planning to do","commit_id":"1af40aafd45f47a13dcde8c49cd27b2e7b1e92a0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"232deee895b2d4c4d93c677aad713cde6b7702a7","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"As this change will cause verification checks to be done in the background, the"},{"line_number":61,"context_line":"number of cases in which the live-migration API will respond with"},{"line_number":62,"context_line":"`badRequest(400)` will be limited to receipt of bad input."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Security impact"},{"line_number":65,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_0aaec184","line":62,"updated":"2016-05-25 15:32:38.000000000","message":"This is quite a semantic change to the API.\n\nI could see this breaking peoples scripts that currently assume they get a 400 error for most operations, and when the instance goes back to active, it must have completed the live-migration.\n\nI think we might need a microversion for this change.","commit_id":"1af40aafd45f47a13dcde8c49cd27b2e7b1e92a0"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"3a8aff3d3083e5f3e8c3b845d5dcb120ff998a3d","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"As this change will cause verification checks to be done in the background, the"},{"line_number":61,"context_line":"number of cases in which the live-migration API will respond with"},{"line_number":62,"context_line":"`badRequest(400)` will be limited to receipt of bad input."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Security impact"},{"line_number":65,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_c5e78a10","line":62,"in_reply_to":"bab6814e_0aaec184","updated":"2016-05-25 15:45:20.000000000","message":"Done","commit_id":"1af40aafd45f47a13dcde8c49cd27b2e7b1e92a0"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e1d809c1cbc3bfb578b7f80b10bec30c6ea5dd6b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The existing nova live-migration operation is complex: verification of"},{"line_number":14,"context_line":"the environment is required before accepting and triggering the live-migration."},{"line_number":15,"context_line":"This verification is done in a synchronous manner with several RPC calls that"},{"line_number":16,"context_line":"must all be successful before the process can being and the REST API layer can"},{"line_number":17,"context_line":"respond. It would be better to make the checks asynchronous and have the REST"},{"line_number":18,"context_line":"API respond with an immediate 202."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_ab4b09b0","line":16,"updated":"2016-05-26 13:50:22.000000000","message":"s/being/begin/ \u003c- snuck back in","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The existing nova live-migration operation is complex: verification of"},{"line_number":14,"context_line":"the environment is required before accepting and triggering the live-migration."},{"line_number":15,"context_line":"This verification is done in a synchronous manner with several RPC calls that"},{"line_number":16,"context_line":"must all be successful before the process can being and the REST API layer can"},{"line_number":17,"context_line":"respond. It would be better to make the checks asynchronous and have the REST"},{"line_number":18,"context_line":"API respond with an immediate 202."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_21fd5cb1","line":16,"in_reply_to":"bab6814e_ab4b09b0","updated":"2016-05-26 22:28:49.000000000","message":"Done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f6bb653d57a9a7407df61d8cf4a2d1234cca215d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This verification is done in a synchronous manner with several RPC calls that"},{"line_number":16,"context_line":"must all be successful before the process can being and the REST API layer can"},{"line_number":17,"context_line":"respond. It would be better to make the checks asynchronous and have the REST"},{"line_number":18,"context_line":"API respond with an immediate 202."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_dcb1eee1","line":18,"updated":"2016-05-26 14:49:56.000000000","message":"(nit) You could mention a textual definition of status 202 - Accepted to save some time to look up the number for folks like me, who keep forgetting status codes :P","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This verification is done in a synchronous manner with several RPC calls that"},{"line_number":16,"context_line":"must all be successful before the process can being and the REST API layer can"},{"line_number":17,"context_line":"respond. It would be better to make the checks asynchronous and have the REST"},{"line_number":18,"context_line":"API respond with an immediate 202."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_419ea063","line":18,"in_reply_to":"bab6814e_dcb1eee1","updated":"2016-05-26 22:28:49.000000000","message":"Done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f6bb653d57a9a7407df61d8cf4a2d1234cca215d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"live-migration involves several steps: an RPC call is made to the conductor"},{"line_number":26,"context_line":"which triggers two more RPC calls to the relevant compute nodes. Only once"},{"line_number":27,"context_line":"those are okay is there an RPC cast to trigger the migration and a response to"},{"line_number":28,"context_line":"the HTTP request."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_f7f4cbf1","line":28,"updated":"2016-05-26 14:49:56.000000000","message":"So the point is that these checks might be time consuming and you don\u0027t want API to block while we are waiting for replies? \n\nI think that\u0027s ok, as long as API users can use the returned request id value to ask for current status of migration.","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f6bb653d57a9a7407df61d8cf4a2d1234cca215d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Use Cases"},{"line_number":32,"context_line":"---------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A user doing a live migration would like to have a fast response to a"},{"line_number":35,"context_line":"live-migration request and use the `instance-actions` service to get valid"},{"line_number":36,"context_line":"status."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_d78f0721","line":34,"updated":"2016-05-26 14:49:56.000000000","message":"I\u0027m not sure that\u0027s the main motivation here: as an API user I\u0027d probably  prefer triggering of a live migration to be blocking, so that I don\u0027t have to poll the migration status to understand if it\u0027s valid or not (before it even started).\n\nOn the other hand, if this simplifies things on the API side (maybe RPC calls can potentially be time consuming and time out?), then it\u0027s ok.","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"bb53a0a3433d8928d0132372579e4946dd1ba0db","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Use Cases"},{"line_number":32,"context_line":"---------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A user doing a live migration would like to have a fast response to a"},{"line_number":35,"context_line":"live-migration request and use the `instance-actions` service to get valid"},{"line_number":36,"context_line":"status."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_fe2811e4","line":34,"in_reply_to":"bab6814e_d78f0721","updated":"2016-05-26 21:47:43.000000000","message":"They can potentially timeout. Looking at this from another angle it blocks change in how the conductor orchestrates this workflow. In Austin we discussed having the conductor manage the orchestration in a better way and setting Nova up for something like Taskflow here. If the API depends on having half of this flow happen before it returns a response we can\u0027t ever get really fancy and do things like restart an operation if the service crashes in the middle.","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Use Cases"},{"line_number":32,"context_line":"---------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"A user doing a live migration would like to have a fast response to a"},{"line_number":35,"context_line":"live-migration request and use the `instance-actions` service to get valid"},{"line_number":36,"context_line":"status."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_c1429067","line":34,"in_reply_to":"bab6814e_fe2811e4","updated":"2016-05-26 22:28:49.000000000","message":"Agree, It looks important to split API layer from conductor as much as possible. The same pattern is implemented for booting new instance where new instance is recorded to db, and then API `casts` to conductor. Actually we could also move Migration object creation to API layer, so nova will record attempt, and then conductor will actually try to do all things.","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e1d809c1cbc3bfb578b7f80b10bec30c6ea5dd6b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Instead of doing all check in blocking way this spec propose to record"},{"line_number":42,"context_line":"conductor\u0027s method with `wrap_instance_event` so it will be possible to check"},{"line_number":43,"context_line":"live-migration status. Upon receiving a request for a live-migration the Nova"},{"line_number":44,"context_line":"API will send an RPC cast to the conductor and then respond immediately with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_abe2e99d","line":41,"updated":"2016-05-26 13:50:22.000000000","message":"s/propose/proposes/ \u003c- this one too\n\nYou might change the entire first line to:\n\nInstead of doing all the checks in a block way, this spec proposes to record the conductor\u0027s method with...","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Instead of doing all check in blocking way this spec propose to record"},{"line_number":42,"context_line":"conductor\u0027s method with `wrap_instance_event` so it will be possible to check"},{"line_number":43,"context_line":"live-migration status. Upon receiving a request for a live-migration the Nova"},{"line_number":44,"context_line":"API will send an RPC cast to the conductor and then respond immediately with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_21c27c53","line":41,"in_reply_to":"bab6814e_abe2e99d","updated":"2016-05-26 22:28:49.000000000","message":"Done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e1d809c1cbc3bfb578b7f80b10bec30c6ea5dd6b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"live-migration status. Upon receiving a request for a live-migration the Nova"},{"line_number":44,"context_line":"API will send an RPC cast to the conductor and then respond immediately with"},{"line_number":45,"context_line":"the HTTP response. To separate blocking and non-blocking live-migration types"},{"line_number":46,"context_line":"new method will be introduced to conductor\u0027s  RPC API:"},{"line_number":47,"context_line":"* migrate_server - existing general method for cold migration, resize and"},{"line_number":48,"context_line":"live-migration. Will continue providing existing blocking behaviour, by sending"},{"line_number":49,"context_line":"RPC call from Nova API to conductor."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_6b03e142","line":46,"updated":"2016-05-26 13:50:22.000000000","message":"nit: there\u0027s extra space before \u0027R\u0027, in case you edit again","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"live-migration status. Upon receiving a request for a live-migration the Nova"},{"line_number":44,"context_line":"API will send an RPC cast to the conductor and then respond immediately with"},{"line_number":45,"context_line":"the HTTP response. To separate blocking and non-blocking live-migration types"},{"line_number":46,"context_line":"new method will be introduced to conductor\u0027s  RPC API:"},{"line_number":47,"context_line":"* migrate_server - existing general method for cold migration, resize and"},{"line_number":48,"context_line":"live-migration. Will continue providing existing blocking behaviour, by sending"},{"line_number":49,"context_line":"RPC call from Nova API to conductor."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_61948436","line":46,"in_reply_to":"bab6814e_6b03e142","updated":"2016-05-26 22:28:49.000000000","message":"Done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e1d809c1cbc3bfb578b7f80b10bec30c6ea5dd6b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"the HTTP response. To separate blocking and non-blocking live-migration types"},{"line_number":46,"context_line":"new method will be introduced to conductor\u0027s  RPC API:"},{"line_number":47,"context_line":"* migrate_server - existing general method for cold migration, resize and"},{"line_number":48,"context_line":"live-migration. Will continue providing existing blocking behaviour, by sending"},{"line_number":49,"context_line":"RPC call from Nova API to conductor."},{"line_number":50,"context_line":"* live_migrate_instance - new method for live-migration only. This method will"},{"line_number":51,"context_line":"implement non-blocking checks by using rpc cast from the Nova API layer."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_0ba17546","line":48,"updated":"2016-05-26 13:50:22.000000000","message":"s/Will/This will/","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"the HTTP response. To separate blocking and non-blocking live-migration types"},{"line_number":46,"context_line":"new method will be introduced to conductor\u0027s  RPC API:"},{"line_number":47,"context_line":"* migrate_server - existing general method for cold migration, resize and"},{"line_number":48,"context_line":"live-migration. Will continue providing existing blocking behaviour, by sending"},{"line_number":49,"context_line":"RPC call from Nova API to conductor."},{"line_number":50,"context_line":"* live_migrate_instance - new method for live-migration only. This method will"},{"line_number":51,"context_line":"implement non-blocking checks by using rpc cast from the Nova API layer."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_41ace08b","line":48,"in_reply_to":"bab6814e_0ba17546","updated":"2016-05-26 22:28:49.000000000","message":"Done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f6bb653d57a9a7407df61d8cf4a2d1234cca215d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* migrate_server - existing general method for cold migration, resize and"},{"line_number":48,"context_line":"live-migration. Will continue providing existing blocking behaviour, by sending"},{"line_number":49,"context_line":"RPC call from Nova API to conductor."},{"line_number":50,"context_line":"* live_migrate_instance - new method for live-migration only. This method will"},{"line_number":51,"context_line":"implement non-blocking checks by using rpc cast from the Nova API layer."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_3cdc7ae3","line":50,"updated":"2016-05-26 14:49:56.000000000","message":"(nit) not sure if we\u0027ve given up on the \"server\" term already,  but it would be nice to see naming be consistent for cold/live migration","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* migrate_server - existing general method for cold migration, resize and"},{"line_number":48,"context_line":"live-migration. Will continue providing existing blocking behaviour, by sending"},{"line_number":49,"context_line":"RPC call from Nova API to conductor."},{"line_number":50,"context_line":"* live_migrate_instance - new method for live-migration only. This method will"},{"line_number":51,"context_line":"implement non-blocking checks by using rpc cast from the Nova API layer."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_01cdb865","line":50,"in_reply_to":"bab6814e_3cdc7ae3","updated":"2016-05-26 22:28:49.000000000","message":"Done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e1d809c1cbc3bfb578b7f80b10bec30c6ea5dd6b","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"As this change will cause verification checks to be done in the background, the"},{"line_number":68,"context_line":"number of cases in which the live-migration API will respond with"},{"line_number":69,"context_line":"`badRequest(400)` will be limited to receipt of bad input. REST API"},{"line_number":70,"context_line":"microversion should be bumped, to retain possibility of switching to previous"},{"line_number":71,"context_line":"behaviour."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_c65e3fe8","line":69,"updated":"2016-05-26 13:50:22.000000000","message":"\"...input. In addition a request which previously returned 200 will return 202. Therefore the REST API...\"","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"As this change will cause verification checks to be done in the background, the"},{"line_number":68,"context_line":"number of cases in which the live-migration API will respond with"},{"line_number":69,"context_line":"`badRequest(400)` will be limited to receipt of bad input. REST API"},{"line_number":70,"context_line":"microversion should be bumped, to retain possibility of switching to previous"},{"line_number":71,"context_line":"behaviour."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_21d55ce4","line":69,"in_reply_to":"bab6814e_c65e3fe8","updated":"2016-05-26 22:28:49.000000000","message":"Actually existing code return 202 too, but it returns after all checks are done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f6bb653d57a9a7407df61d8cf4a2d1234cca215d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Performance Impact"},{"line_number":89,"context_line":"------------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Getting rid of blocking rest/rpc request will slightly improve overall"},{"line_number":92,"context_line":"performance."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_526965bd","line":91,"updated":"2016-05-26 14:49:56.000000000","message":"Could you please elaborate here? Do you mean that we increase the throughput of API here and it becomes non-blocking? (we are still doing the same amount of work + we store additional state in the DB, not sure this improves the performance of the system overall)","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Performance Impact"},{"line_number":89,"context_line":"------------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Getting rid of blocking rest/rpc request will slightly improve overall"},{"line_number":92,"context_line":"performance."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_411fc0b6","line":91,"in_reply_to":"bab6814e_526965bd","updated":"2016-05-26 22:28:49.000000000","message":"Done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f6bb653d57a9a7407df61d8cf4a2d1234cca215d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Test for checking that conductor\u0027s part of live-migration is recorded by"},{"line_number":135,"context_line":"instance-actions should be added to tempest."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_724f4934","line":135,"updated":"2016-05-26 14:49:56.000000000","message":"I understand that unit tests are kind of implied, but still you could mention them here :)\n\nTests for new API microversion? (do we currently test those in python-novaclient?)","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4a6b241217ee5c9e9b287807decc552dd11ca20f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Test for checking that conductor\u0027s part of live-migration is recorded by"},{"line_number":135,"context_line":"instance-actions should be added to tempest."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_81c9a828","line":135,"in_reply_to":"bab6814e_724f4934","updated":"2016-05-26 22:28:49.000000000","message":"Done","commit_id":"ea725a361e05c6189838957fe6c6e8fef756c268"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8221b3b6f224f22d2363b3ff00e8df6f870053a0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"live-migration. This will continue providing existing blocking behaviour, by"},{"line_number":49,"context_line":"sending RPC call from Nova API to conductor."},{"line_number":50,"context_line":"* live_migrate_server - new method for live-migration only. This method will"},{"line_number":51,"context_line":"implement non-blocking checks by using rpc cast from the Nova API layer."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_87684cbc","line":51,"updated":"2016-05-27 12:39:39.000000000","message":"As both paths should record the same async error records, the only difference should be the call vs cast in the rpcapi, I believe. It might be good to explicitly mention that here.","commit_id":"c626735d079044b1a0a1a9e2b3dbf387f3a94725"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"48713f526571c366b0b58a64e8228c0880829931","unresolved":false,"context_lines":[{"line_number":48,"context_line":"live-migration. This will continue providing existing blocking behaviour, by"},{"line_number":49,"context_line":"sending RPC call from Nova API to conductor."},{"line_number":50,"context_line":"* live_migrate_server - new method for live-migration only. This method will"},{"line_number":51,"context_line":"implement non-blocking checks by using rpc cast from the Nova API layer."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_87b04c8d","line":51,"in_reply_to":"9abb7d3a_87684cbc","updated":"2016-05-27 12:52:09.000000000","message":"Done","commit_id":"c626735d079044b1a0a1a9e2b3dbf387f3a94725"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f6b9f302b39ddc9318d496dc140d8cc7c5ce9223","unresolved":false,"context_lines":[{"line_number":48,"context_line":"live-migration. This will continue providing existing blocking behaviour, by"},{"line_number":49,"context_line":"sending RPC call from Nova API to conductor."},{"line_number":50,"context_line":"* live_migrate_server - new method for live-migration only. This method will"},{"line_number":51,"context_line":"implement non-blocking checks by using rpc cast from the Nova API layer."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_70afdce3","line":51,"in_reply_to":"9abb7d3a_87b04c8d","updated":"2016-05-27 13:28:33.000000000","message":"I disagree that it should be the same path with just call vs cast. That constrains the path to not changing very much because it still has to continue doing what it does today. The big benefit here is that the code in conductor/compute can change dramatically to clean it up.","commit_id":"c626735d079044b1a0a1a9e2b3dbf387f3a94725"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8221b3b6f224f22d2363b3ff00e8df6f870053a0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Leave things as they are."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Data model impact"},{"line_number":60,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_e703180c","line":57,"updated":"2016-05-27 12:39:39.000000000","message":"We should probably mention the alternative around not maintaining the \"call\" path, and not adding this as a microversion.","commit_id":"c626735d079044b1a0a1a9e2b3dbf387f3a94725"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"48713f526571c366b0b58a64e8228c0880829931","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Leave things as they are."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Data model impact"},{"line_number":60,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_67ad6831","line":57,"in_reply_to":"9abb7d3a_e703180c","updated":"2016-05-27 12:52:09.000000000","message":"Done","commit_id":"c626735d079044b1a0a1a9e2b3dbf387f3a94725"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"48a5fce4e2b7b7a301bc7403aecacf449956a465","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Leave things as they are. Another alternative would be to switch to"},{"line_number":60,"context_line":"non-blocking rpc cast without maintaining previous behavior and bumping Nova"},{"line_number":61,"context_line":"REST API microversion."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Data model impact"},{"line_number":64,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_300f14e3","line":61,"updated":"2016-05-27 13:32:38.000000000","message":"I would prefer this alternative, but I think it\u0027s unlikely to gain consensus.","commit_id":"d0a54897c736df5147b2cba46da7a4f3973f5f6b"}]}
