)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"ad857fb33bf3c6a25f60d293e7270369e1ef6889","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jinquanni \u003cni.jinquan@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-27 22:38:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify PCI without numa node info treatment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modify those PCI devices without numa node info treatment"},{"line_number":10,"context_line":"when launch an instance with some requirements of NUMA and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_117f06ac","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"updated":"2016-06-29 14:22:59.000000000","message":"Modify treatment of PCI without numa node info","commit_id":"626bf7c2b6a323f7c106d775fd1bbc6b7befd37e"}],"specs/ocata/approved/modify-pci-without-numa-node-info-treatment.rst":[{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"8d65804d7a00ba0b02167c78308ac457498393b1","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Method _filter_pools_for_numa_cells in nova/pci/stats.py will be change,"},{"line_number":56,"context_line":"when we filter these numa cells for pci devices, we need remove the numa cell"},{"line_number":57,"context_line":"which cell id equal null."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Data model impact"},{"line_number":60,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_e2602710","line":57,"updated":"2016-07-01 17:22:55.000000000","message":"It seems like you are listing this as an alternative but there is no other proposed detail of your change here so I assume this is still your actual proposal. As discussed previously when you proposed this as a bug fix simply removing the device where the cell id is None breaks existing use cases where people care about CPU/RAM placement but still want to be able use PCIe devices and their virtual functions on older chipsets that don\u0027t report PCIe NUMA locality. The original design and implementation quite intentionally allowed this, so this proposal needs to address how it is going to cater to those users with more exacting requirements (*must* have PCIe locality) while still meeting the needs of those using the feature on older chipsets (supported by the existing approach).\n\nThe question that needs to be addressed here is whether we need to further parameterize such that the user specifies the level of \"strictness\" they are after from the NUMATopologyFilter or whether it is considered the cloud deployer\u0027s responsibility to segregate their older hosts (that do not support PCIe NUMA locality, but do support PCIe) using host aggregates and configure the flavors exposed to users accessing PCIe support accordingly.\n\nAnother approach would be to simply weight nodes that are exposing locality as higher, this still leaves the possibility that a user expecting PCIe locality ends up on a node that doesn\u0027t expose it but only when the alternative was that their instance wouldn\u0027t schedule at all (no other nodes with PCIe devices available).\n\nAll in all I think this specification needs a lot more explanation of:\n\na) What is actually being proposed.\nb) What alternatives exist and why they are not appropriate.\nc) How existing users with differing hardware and expectations will continue to be catered to.","commit_id":"626bf7c2b6a323f7c106d775fd1bbc6b7befd37e"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"ad857fb33bf3c6a25f60d293e7270369e1ef6889","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Method _filter_pools_for_numa_cells in nova/pci/stats.py will be change,"},{"line_number":56,"context_line":"when we filter these numa cells for pci devices, we need remove the numa cell"},{"line_number":57,"context_line":"which cell id equal null."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Data model impact"},{"line_number":60,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_83844d0b","line":57,"range":{"start_line":57,"start_character":14,"end_line":57,"end_character":19},"updated":"2016-06-29 14:22:59.000000000","message":"equals or is equal to","commit_id":"626bf7c2b6a323f7c106d775fd1bbc6b7befd37e"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"f5ad18ae1f726385ad1efbaf3f95a86262d2cfba","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Method _filter_pools_for_numa_cells in nova/pci/stats.py will be change,"},{"line_number":56,"context_line":"when we filter these numa cells for pci devices, we need remove the numa cell"},{"line_number":57,"context_line":"which cell id equal null."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Data model impact"},{"line_number":60,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_ba5fcd0d","line":57,"range":{"start_line":57,"start_character":14,"end_line":57,"end_character":19},"in_reply_to":"3aaa91ec_83844d0b","updated":"2016-07-02 07:51:38.000000000","message":"Done","commit_id":"626bf7c2b6a323f7c106d775fd1bbc6b7befd37e"}]}