)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d7080dcc084e26a5215fd450f3dacc1538102c37","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhanced KVM Storage QoS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"https://blueprints.launchpad.net/nova/+spec/enhanced-kvm-storage-qos"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"QEMU 1.7 provides options to specify maximum burst IOPS and maximum burst"},{"line_number":12,"context_line":"bandwidth per disk. Additionally disk IO size can be specified as part of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dfeb2761_1117bdef","line":9,"updated":"2017-04-04 11:34:58.000000000","message":"you can change this to\n\nblueprint enhanced-kvm-storage-qos\n\nand put it near the bottom, to be more in keeping with the usual style","commit_id":"ec7e99474731d04b8715beb6c0ef539f4f9a7ce9"}],"specs/pike/approved/enhanced-kvm-storage-qos.rst":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d7b5498a11096fe10137d145bf82c48e90cd4aed","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* total_iops_sec_max - includes read/writes"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* size_iops_sec"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Alternatives"},{"line_number":94,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dfeb2761_e63db48f","line":91,"updated":"2017-04-04 14:40:07.000000000","message":"As Chris said, can we be a little more specific to what the scope of the change is here? This talks a lot about using the feature, but not as much about what the scope of changes are.\n\nAlso, is there any analog of this on other hypervisors? Before we do a libvirt only thing we should at least have a survey of if it would be possible to do this on any other hypervisor, and what that might be like, so that before we encode a libvirt specific name we know if this is ever going to translate.","commit_id":"ec7e99474731d04b8715beb6c0ef539f4f9a7ce9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"d14a1369cb48078407236e25013739d1efaa0be7","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* total_iops_sec_max - includes read/writes"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* size_iops_sec"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Alternatives"},{"line_number":94,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bff0334d_3f382eed","line":91,"in_reply_to":"dfeb2761_e63db48f","updated":"2017-04-10 14:11:44.000000000","message":"I will add examples of each XML line to each of these in the next patch. \nThese are very KVM/libvirt specific changes. Hyper-V has a limited subset of storage QoS that doesn\u0027t cover the existing libvirt settings, so we can do anything similar there. Xen doesn\u0027t have any disk QoS where you can set anything like IOPs, bandwidth, etc. that I am aware of.","commit_id":"ec7e99474731d04b8715beb6c0ef539f4f9a7ce9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d7b5498a11096fe10137d145bf82c48e90cd4aed","unresolved":false,"context_lines":[{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This feature will be tested by the libvirt CI. We\u0027ll add tempest tests"},{"line_number":162,"context_line":"verifying that these values are set correclty."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Documentation Impact"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dfeb2761_2616fcf2","line":162,"updated":"2017-04-04 14:40:07.000000000","message":"I don\u0027t actually understand how Tempest could test this. Can you be more specific?","commit_id":"ec7e99474731d04b8715beb6c0ef539f4f9a7ce9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"d14a1369cb48078407236e25013739d1efaa0be7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This feature will be tested by the libvirt CI. We\u0027ll add tempest tests"},{"line_number":162,"context_line":"verifying that these values are set correclty."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Documentation Impact"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bff0334d_7f72364b","line":162,"in_reply_to":"dfeb2761_2616fcf2","updated":"2017-04-10 14:11:44.000000000","message":"In the current Tempest tests, we are checking that the syntax of the KVM XML file is correct. I will just extend these current tests to include the new values.","commit_id":"ec7e99474731d04b8715beb6c0ef539f4f9a7ce9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d7b5498a11096fe10137d145bf82c48e90cd4aed","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"These additional QoS features should be described in the libvirt driver"},{"line_number":168,"context_line":"documentation."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"References"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dfeb2761_a62a0c29","line":168,"updated":"2017-04-04 14:40:07.000000000","message":"Which is where? I do get that there are hidden QoS values in our driver code today, but it seems much more likely that this is something that operators want to be able to set, so this should be in one of the operator guides, correct?","commit_id":"ec7e99474731d04b8715beb6c0ef539f4f9a7ce9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"d14a1369cb48078407236e25013739d1efaa0be7","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"These additional QoS features should be described in the libvirt driver"},{"line_number":168,"context_line":"documentation."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"References"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bff0334d_9f8f3a74","line":168,"in_reply_to":"dfeb2761_a62a0c29","updated":"2017-04-10 14:11:44.000000000","message":"Just checked and there is no OpenStack Storage QoS docs other than a high-level reference in the Cinder CLI client docs.\n\nWe should definitely add the current and these new options to the Operators doc set","commit_id":"ec7e99474731d04b8715beb6c0ef539f4f9a7ce9"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b0e6b439b389a8a06d6f41d7f831c08d4a8f71c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"blueprint enhanced-kvm-storage-qos"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"QEMU 1.7 provides options to specify maximum burst IOPS and maximum burst"},{"line_number":14,"context_line":"bandwidth per disk. Additionally disk IO size can be specified as part of"},{"line_number":15,"context_line":"this version of QEMU."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"bff0334d_5e8049f5","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":8},"updated":"2017-04-12 10:48:43.000000000","message":"nit - Can you provide a reference?","commit_id":"c100affd49aa15de5831ed4ad1ba097c6ec0be87"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b0e6b439b389a8a06d6f41d7f831c08d4a8f71c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* Set IOPs and bandwidth burst limits and block IO sizes for instance"},{"line_number":37,"context_line":"  attached disks by using Cinder extra specs"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Project Priority"},{"line_number":40,"context_line":"-----------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bff0334d_3e258509","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":4},"updated":"2017-04-12 10:48:43.000000000","message":"I\u0027m not sure where this section came from but it isn\u0027t in the template AFAICT.","commit_id":"c100affd49aa15de5831ed4ad1ba097c6ec0be87"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b0e6b439b389a8a06d6f41d7f831c08d4a8f71c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # attached to a KVM instance"},{"line_number":75,"context_line":"    nova volume-attach \u003cinstance_id\u003e \u003cvolume_id\u003e"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Available additonal QoS specs, where each will add an extra"},{"line_number":78,"context_line":"line into the libvirt XML definition, specifically in the \u003ciotune\u003e"},{"line_number":79,"context_line":"section for each device, are:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* read_bytes_sec_max"},{"line_number":82,"context_line":"    add \u003cread_bytes_sec_max\u003evalue\u003c/read_bytes_sec_max\u003e"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bff0334d_3ea0e58f","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":29},"updated":"2017-04-12 10:48:43.000000000","message":"nit - Again a reference to the libvirt docs for this would be useful.\n\nhttps://libvirt.org/formatdomain.html#elementsBlockTuning","commit_id":"c100affd49aa15de5831ed4ad1ba097c6ec0be87"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b0e6b439b389a8a06d6f41d7f831c08d4a8f71c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Work Items"},{"line_number":160,"context_line":"----------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Dependencies"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bff0334d_febefdab","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":70},"updated":"2017-04-12 10:48:43.000000000","message":"If you respin more details here would be useful. I\u0027m assuming it\u0027s going to be something along the lines of what I have in my native LUKS spec : \n\nhttps://review.openstack.org/#/c/437070/6/specs/pike/approved/libvirt-qemu-native-luks.rst@118","commit_id":"c100affd49aa15de5831ed4ad1ba097c6ec0be87"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b0e6b439b389a8a06d6f41d7f831c08d4a8f71c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Testing"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"These additonal feature will be incorporated in the libvirt CI."},{"line_number":173,"context_line":"We\u0027ll add additional parameters into existing tempest tests to"},{"line_number":174,"context_line":"verifying that these values."},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"bff0334d_7e01cd69","line":172,"range":{"start_line":172,"start_character":45,"end_line":172,"end_character":62},"updated":"2017-04-12 10:48:43.000000000","message":"nit - There isn\u0027t really a single libvirt CI as with other virt drivers, saying that this will be tested by introducing new tempest tests should be enough.","commit_id":"c100affd49aa15de5831ed4ad1ba097c6ec0be87"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b0e6b439b389a8a06d6f41d7f831c08d4a8f71c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"These additonal feature will be incorporated in the libvirt CI."},{"line_number":173,"context_line":"We\u0027ll add additional parameters into existing tempest tests to"},{"line_number":174,"context_line":"verifying that these values."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Documentation Impact"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bff0334d_be307557","line":174,"range":{"start_line":173,"start_character":0,"end_line":174,"end_character":28},"updated":"2017-04-12 10:48:43.000000000","message":"There\u0027s no real way of verifying that these values have been set in a Tempest env as any setting is also transparent to the instance. I wonder if a functional test would be useful here?","commit_id":"c100affd49aa15de5831ed4ad1ba097c6ec0be87"}],"specs/rocky/approved/enhanced-kvm-storage-qos.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Front-end QoS specs should be applied by Nova when the volume is attached."},{"line_number":44,"context_line":"These are applied per volume."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This blueprint proposes additional per volume QoS specs that will be"},{"line_number":47,"context_line":"specified using Cinder volume extra specs. The libvirt driver will apply"},{"line_number":48,"context_line":"those IOPS and bandwidth caps to the instance disks on a per volume basis."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Additionally, this blueprint proposes adding the block IO size control using"},{"line_number":51,"context_line":"cinder volume extra specs to cinder attached volumes on a per volume basis."}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_36930403","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":74},"updated":"2018-06-05 22:45:42.000000000","message":"Where does the compute/driver get these specs? Is nova-compute going to need to call the cinder QoS or volume types API for this information (which is admin-level information by default isn\u0027t it?), or is this something exposed via the connection_info per volume attachment?","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fac1ac1f84430914ea58a079ad236a745fcaf36b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Front-end QoS specs should be applied by Nova when the volume is attached."},{"line_number":44,"context_line":"These are applied per volume."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This blueprint proposes additional per volume QoS specs that will be"},{"line_number":47,"context_line":"specified using Cinder volume extra specs. The libvirt driver will apply"},{"line_number":48,"context_line":"those IOPS and bandwidth caps to the instance disks on a per volume basis."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Additionally, this blueprint proposes adding the block IO size control using"},{"line_number":51,"context_line":"cinder volume extra specs to cinder attached volumes on a per volume basis."}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_6102140c","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":74},"in_reply_to":"5f7c97a3_36930403","updated":"2018-06-05 22:50:21.000000000","message":"Looks like it comes from the per-attachment connection_info dict:\n\nhttps://review.openstack.org/#/c/558530/2/nova/virt/libvirt/volume/volume.py\n\nLet\u0027s be clear about that.","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8ff739849655ebf2f820cd6691b16b507f0bf207","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Front-end QoS specs should be applied by Nova when the volume is attached."},{"line_number":44,"context_line":"These are applied per volume."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This blueprint proposes additional per volume QoS specs that will be"},{"line_number":47,"context_line":"specified using Cinder volume extra specs. The libvirt driver will apply"},{"line_number":48,"context_line":"those IOPS and bandwidth caps to the instance disks on a per volume basis."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Additionally, this blueprint proposes adding the block IO size control using"},{"line_number":51,"context_line":"cinder volume extra specs to cinder attached volumes on a per volume basis."}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_5930fa9e","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":74},"in_reply_to":"5f7c97a3_6102140c","updated":"2018-06-07 19:16:56.000000000","message":"Yes. That is where it comes from. This is a tried and trusted method that has been used for Cinder Front-End QoS for many releases","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Additionally, this blueprint proposes adding the block IO size control using"},{"line_number":51,"context_line":"cinder volume extra specs to cinder attached volumes on a per volume basis."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Front-end volume specs will be supported only in case of volumes exported"},{"line_number":54,"context_line":"through Cinder"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Use case examples:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_56f32074","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":14},"updated":"2018-06-05 22:45:42.000000000","message":"What would be the alternative? Also, missing a period.","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8ff739849655ebf2f820cd6691b16b507f0bf207","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Additionally, this blueprint proposes adding the block IO size control using"},{"line_number":51,"context_line":"cinder volume extra specs to cinder attached volumes on a per volume basis."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Front-end volume specs will be supported only in case of volumes exported"},{"line_number":54,"context_line":"through Cinder"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Use case examples:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_790136af","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":14},"in_reply_to":"5f7c97a3_56f32074","updated":"2018-06-07 19:16:56.000000000","message":"There is no alternative at the moment. This is just adding additional parameters to the existing methodology that has been there for some time","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Other end user impact"},{"line_number":123,"context_line":"---------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"None"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Performance Impact"},{"line_number":128,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_56c1e0e3","line":125,"updated":"2018-06-05 22:45:42.000000000","message":"Nova supports N-1 version computes, so if I attach a volume with these new QoS specs to an instance that\u0027s running on a Queens compute node, it\u0027s not going to apply the QoS specs. It won\u0027t fail, it just wont honor the request. Also, as noted earlier in this review, other virt drivers aren\u0027t being considered here, so if my instance is running on a vmware driver, for example, it\u0027s not going to apply.\n\nAre the Cinder QoS specs that are known to be used documented anywhere?\n\nI guess at a minimum the best we can do with this is document something about cinder Qos spec support in the hypervisor support matrix within the nova docs:\n\nhttps://docs.openstack.org/nova/latest/user/support-matrix.html","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8ff739849655ebf2f820cd6691b16b507f0bf207","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Other end user impact"},{"line_number":123,"context_line":"---------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"None"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Performance Impact"},{"line_number":128,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_b9234ebe","line":125,"in_reply_to":"5f7c97a3_56c1e0e3","updated":"2018-06-07 19:16:56.000000000","message":"Will update this section","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"----------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver by"},{"line_number":161,"context_line":"  extending the `nova/virt/libvirt/volumes/` block volume drivers to pass"},{"line_number":162,"context_line":"  the new properties of a volume to `LibvirtConfigGuestDisk`"},{"line_number":163,"context_line":"* Make these new parameters valid in extra_specs when assigning front-end"},{"line_number":164,"context_line":"  QoS parameters to a volume"},{"line_number":165,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to add the disk burst limits"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_b6af142a","line":162,"range":{"start_line":161,"start_character":66,"end_line":162,"end_character":32},"updated":"2018-06-05 22:45:42.000000000","message":"Again, how are you proposing to get the QoS specs associated with the volume, via the volume type, down into the libvirt driver code. Is the compute manager going to make a new call to the volume API for this, and if so, are admin credentials required for that?","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8ff739849655ebf2f820cd6691b16b507f0bf207","unresolved":false,"context_lines":[{"line_number":158,"context_line":"----------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver by"},{"line_number":161,"context_line":"  extending the `nova/virt/libvirt/volumes/` block volume drivers to pass"},{"line_number":162,"context_line":"  the new properties of a volume to `LibvirtConfigGuestDisk`"},{"line_number":163,"context_line":"* Make these new parameters valid in extra_specs when assigning front-end"},{"line_number":164,"context_line":"  QoS parameters to a volume"},{"line_number":165,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to add the disk burst limits"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_f90d46e8","line":162,"range":{"start_line":161,"start_character":66,"end_line":162,"end_character":32},"in_reply_to":"5f7c97a3_b6af142a","updated":"2018-06-07 19:16:56.000000000","message":"Going to use the existing methodology. You are correct - this uses volume types and the per-connection attachment info","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":160,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver by"},{"line_number":161,"context_line":"  extending the `nova/virt/libvirt/volumes/` block volume drivers to pass"},{"line_number":162,"context_line":"  the new properties of a volume to `LibvirtConfigGuestDisk`"},{"line_number":163,"context_line":"* Make these new parameters valid in extra_specs when assigning front-end"},{"line_number":164,"context_line":"  QoS parameters to a volume"},{"line_number":165,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to add the disk burst limits"},{"line_number":166,"context_line":"  of a disk device [2]_"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_f6b58c7f","line":164,"range":{"start_line":163,"start_character":2,"end_line":164,"end_character":28},"updated":"2018-06-05 22:45:42.000000000","message":"This doesn\u0027t really have anything to do with nova, right?","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8ff739849655ebf2f820cd6691b16b507f0bf207","unresolved":false,"context_lines":[{"line_number":160,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver by"},{"line_number":161,"context_line":"  extending the `nova/virt/libvirt/volumes/` block volume drivers to pass"},{"line_number":162,"context_line":"  the new properties of a volume to `LibvirtConfigGuestDisk`"},{"line_number":163,"context_line":"* Make these new parameters valid in extra_specs when assigning front-end"},{"line_number":164,"context_line":"  QoS parameters to a volume"},{"line_number":165,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to add the disk burst limits"},{"line_number":166,"context_line":"  of a disk device [2]_"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_59623aaf","line":164,"range":{"start_line":163,"start_character":2,"end_line":164,"end_character":28},"in_reply_to":"5f7c97a3_f6b58c7f","updated":"2018-06-07 19:16:56.000000000","message":"True","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Dependencies"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"* QEMU 2.5 [1]_"},{"line_number":173,"context_line":"* Libvirt 1.2.11 [2]_ [3]_"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"QEMU included in Ubuntu 16.04 [4]_ [5]_ and libvirt at a higher version"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_76a97c22","line":172,"range":{"start_line":172,"start_character":2,"end_line":172,"end_character":10},"updated":"2018-06-05 22:45:42.000000000","message":"Up above it says QEMU 1.7 so which is it?","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2eb40045293af9a59ede45baac6712541c546f94","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Dependencies"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"* QEMU 2.5 [1]_"},{"line_number":173,"context_line":"* Libvirt 1.2.11 [2]_ [3]_"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"QEMU included in Ubuntu 16.04 [4]_ [5]_ and libvirt at a higher version"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_3413c5ba","line":172,"range":{"start_line":172,"start_character":2,"end_line":172,"end_character":10},"in_reply_to":"5f7c97a3_59bebad4","updated":"2018-06-07 19:38:37.000000000","message":"OK, but that\u0027s really confusing....just say 1.7. If you want to mention that the libvirt driver already requires 2.5 that\u0027s fine.","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8ff739849655ebf2f820cd6691b16b507f0bf207","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Dependencies"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"* QEMU 2.5 [1]_"},{"line_number":173,"context_line":"* Libvirt 1.2.11 [2]_ [3]_"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"QEMU included in Ubuntu 16.04 [4]_ [5]_ and libvirt at a higher version"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_59bebad4","line":172,"range":{"start_line":172,"start_character":2,"end_line":172,"end_character":10},"in_reply_to":"5f7c97a3_76a97c22","updated":"2018-06-07 19:16:56.000000000","message":"These options became available in QEMU 1.7, but I reference 2.5 as this is the version that is flagged in Nova as the minimum supported version when doing per volume QoS settings","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Unit tests"},{"line_number":182,"context_line":"* Existing tempest tests should trigger the use of this new functionality"},{"line_number":183,"context_line":"  assuming the required versions of Libvirt and QEMU are present."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Documentation Impact"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_767e5cb0","line":183,"range":{"start_line":182,"start_character":2,"end_line":183,"end_character":65},"updated":"2018-06-05 22:45:42.000000000","message":"Tempest likely won\u0027t be testing anything about this. I saw in an earlier response to sdague that the tempest tests look into the guest xml to see if the fields are set properly - that must be in a tempest plugin you have or something, because I don\u0027t think the QA team would ever accept a test that is that virt-specific.","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8ff739849655ebf2f820cd6691b16b507f0bf207","unresolved":false,"context_lines":[{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Unit tests"},{"line_number":182,"context_line":"* Existing tempest tests should trigger the use of this new functionality"},{"line_number":183,"context_line":"  assuming the required versions of Libvirt and QEMU are present."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Documentation Impact"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_794e16c2","line":183,"range":{"start_line":182,"start_character":2,"end_line":183,"end_character":65},"in_reply_to":"5f7c97a3_767e5cb0","updated":"2018-06-07 19:16:56.000000000","message":"So all I\u0027m doing here is adding to the existing tests to ensure the format, as you say, is correct.","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":188,"context_line":"The additional QoS features are described in the libvirt driver"},{"line_number":189,"context_line":"documentation [1]_."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Will plan to add a section in the Operators Guide to cover the front-end"},{"line_number":192,"context_line":"QoS for storage including existing and new parameters."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_1649288a","line":191,"range":{"start_line":191,"start_character":34,"end_line":191,"end_character":49},"updated":"2018-06-05 22:45:42.000000000","message":"This doesn\u0027t exist anymore - so where would this live now? Cinder admin guide, nova admin guide?\n\nhttps://docs.openstack.org/cinder/latest/admin/blockstorage-capacity-based-qos.html\n\nhttps://docs.openstack.org/nova/latest/admin/manage-volumes.html","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8ff739849655ebf2f820cd6691b16b507f0bf207","unresolved":false,"context_lines":[{"line_number":188,"context_line":"The additional QoS features are described in the libvirt driver"},{"line_number":189,"context_line":"documentation [1]_."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Will plan to add a section in the Operators Guide to cover the front-end"},{"line_number":192,"context_line":"QoS for storage including existing and new parameters."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_191042a8","line":191,"range":{"start_line":191,"start_character":34,"end_line":191,"end_character":49},"in_reply_to":"5f7c97a3_1649288a","updated":"2018-06-07 19:16:56.000000000","message":"Cinder Admin guide","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca4c867415f8c45215550d954687c53d79858a8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"History"},{"line_number":206,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_d65ad04e","line":208,"updated":"2018-06-05 22:45:42.000000000","message":"This should be:\n\n.. list-table:: Revisions\n   :header-rows: 1\n\n   * - Release Name\n     - Description\n   * - Rocky\n     - Introduced","commit_id":"dbc8e48953e4e4604e63a74d0a0ef0ee373b41d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2eb40045293af9a59ede45baac6712541c546f94","unresolved":false,"context_lines":[{"line_number":126,"context_line":"node running Queens, these new specs will be ignored. No error message will be provided"},{"line_number":127,"context_line":"from the Queens node."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Exisitng Cinder QoS specs are documented in the Cinder Administration documentation set.[8]_"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Performance Impact"},{"line_number":132,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f7c97a3_34dc2517","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":8},"updated":"2018-06-07 19:38:37.000000000","message":"Existing","commit_id":"7bf9b862d46b6746e1c475882c94ccd63670df78"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"239102e80bfc2d66fd276f02ec4eb6ef77d1756c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"node running Queens, these new specs will be ignored. No error message will be provided"},{"line_number":127,"context_line":"from the Queens node."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Exisitng Cinder QoS specs are documented in the Cinder Administration documentation set.[8]_"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Performance Impact"},{"line_number":132,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f7c97a3_f4b6ad8a","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":8},"in_reply_to":"5f7c97a3_34dc2517","updated":"2018-06-07 19:51:37.000000000","message":"Done","commit_id":"7bf9b862d46b6746e1c475882c94ccd63670df78"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2eb40045293af9a59ede45baac6712541c546f94","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver by"},{"line_number":165,"context_line":"  extending the `nova/virt/libvirt/volumes/` block volume drivers to pass"},{"line_number":166,"context_line":"  the new properties of a volume to `LibvirtConfigGuestDisk`"},{"line_number":167,"context_line":"* Make these new parameters valid in extra_specs when assigning front-end"},{"line_number":168,"context_line":"  QoS parameters to a volume"},{"line_number":169,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to add the disk burst limits"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f7c97a3_342ae5e6","line":166,"updated":"2018-06-07 19:38:37.000000000","message":"let\u0027s be clear, so add \"via the ``qos_specs`` in the ``connnection_info`` dict.\"","commit_id":"7bf9b862d46b6746e1c475882c94ccd63670df78"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"239102e80bfc2d66fd276f02ec4eb6ef77d1756c","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver by"},{"line_number":165,"context_line":"  extending the `nova/virt/libvirt/volumes/` block volume drivers to pass"},{"line_number":166,"context_line":"  the new properties of a volume to `LibvirtConfigGuestDisk`"},{"line_number":167,"context_line":"* Make these new parameters valid in extra_specs when assigning front-end"},{"line_number":168,"context_line":"  QoS parameters to a volume"},{"line_number":169,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to add the disk burst limits"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f7c97a3_5433e113","line":166,"in_reply_to":"5f7c97a3_342ae5e6","updated":"2018-06-07 19:51:37.000000000","message":"Done","commit_id":"7bf9b862d46b6746e1c475882c94ccd63670df78"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2eb40045293af9a59ede45baac6712541c546f94","unresolved":false,"context_lines":[{"line_number":164,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver by"},{"line_number":165,"context_line":"  extending the `nova/virt/libvirt/volumes/` block volume drivers to pass"},{"line_number":166,"context_line":"  the new properties of a volume to `LibvirtConfigGuestDisk`"},{"line_number":167,"context_line":"* Make these new parameters valid in extra_specs when assigning front-end"},{"line_number":168,"context_line":"  QoS parameters to a volume"},{"line_number":169,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to add the disk burst limits"},{"line_number":170,"context_line":"  of a disk device [2]_"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f7c97a3_b4f8357c","line":168,"range":{"start_line":167,"start_character":0,"end_line":168,"end_character":28},"updated":"2018-06-07 19:38:37.000000000","message":"Remove this, it has nothing to do with nova.","commit_id":"7bf9b862d46b6746e1c475882c94ccd63670df78"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"239102e80bfc2d66fd276f02ec4eb6ef77d1756c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"* Add burst and IO size QoS specs support in the libvirt volume driver by"},{"line_number":165,"context_line":"  extending the `nova/virt/libvirt/volumes/` block volume drivers to pass"},{"line_number":166,"context_line":"  the new properties of a volume to `LibvirtConfigGuestDisk`"},{"line_number":167,"context_line":"* Make these new parameters valid in extra_specs when assigning front-end"},{"line_number":168,"context_line":"  QoS parameters to a volume"},{"line_number":169,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to add the disk burst limits"},{"line_number":170,"context_line":"  of a disk device [2]_"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f7c97a3_f439cdf1","line":168,"range":{"start_line":167,"start_character":0,"end_line":168,"end_character":28},"in_reply_to":"5f7c97a3_b4f8357c","updated":"2018-06-07 19:51:37.000000000","message":"Done","commit_id":"7bf9b862d46b6746e1c475882c94ccd63670df78"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2eb40045293af9a59ede45baac6712541c546f94","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Dependencies"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"* QEMU 2.5 [1]_"},{"line_number":177,"context_line":"* Libvirt 1.2.11 [2]_ [3]_"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"QEMU included in Ubuntu 16.04 [4]_ [5]_ and libvirt at a higher version"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f7c97a3_541681a9","line":176,"updated":"2018-06-07 19:38:37.000000000","message":"This should say 1.7. If you want to mention that the libvirt driver already requires \u003e\u003d 2.5 in Rocky that\u0027s fine.","commit_id":"7bf9b862d46b6746e1c475882c94ccd63670df78"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"239102e80bfc2d66fd276f02ec4eb6ef77d1756c","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Dependencies"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"* QEMU 2.5 [1]_"},{"line_number":177,"context_line":"* Libvirt 1.2.11 [2]_ [3]_"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"QEMU included in Ubuntu 16.04 [4]_ [5]_ and libvirt at a higher version"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f7c97a3_143d69dc","line":176,"in_reply_to":"5f7c97a3_541681a9","updated":"2018-06-07 19:51:37.000000000","message":"Done","commit_id":"7bf9b862d46b6746e1c475882c94ccd63670df78"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"960d3ae5a4742e7b01f5affd8c608c32f22de219","unresolved":false,"context_lines":[{"line_number":51,"context_line":"cinder volume extra specs to cinder attached volumes on a per volume basis."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Front-end volume specs will be supported only in case of volumes exported"},{"line_number":54,"context_line":"through Cinder. No QoS specs are provided for local drives provided directly by Nova."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Use case examples:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5f7c97a3_eff1f402","line":54,"updated":"2018-06-07 20:07:51.000000000","message":"This line is apparently too long:\n\nhttp://logs.openstack.org/68/340168/17/check/openstack-tox-pep8/111d179/job-output.txt.gz#_2018-06-07_20_01_21_057510\n\ntox -e pep8","commit_id":"9c01acec28fb9ab14b07bee70381f8e77e9be71a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"960d3ae5a4742e7b01f5affd8c608c32f22de219","unresolved":false,"context_lines":[{"line_number":126,"context_line":"node running Queens, these new specs will be ignored. No error message will be provided"},{"line_number":127,"context_line":"from the Queens node."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Existing Cinder QoS specs are documented in the Cinder Administration documentation set.[8]_"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Performance Impact"},{"line_number":132,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5f7c97a3_0f80f045","line":129,"range":{"start_line":129,"start_character":88,"end_line":129,"end_character":92},"updated":"2018-06-07 20:07:51.000000000","message":"I think you need a space before this:\n\nhttp://logs.openstack.org/68/340168/17/check/build-openstack-sphinx-docs/5cb4dcf/job-output.txt.gz#_2018-06-07_20_01_38_276017\n\nYou can run:\n\ntox -e docs\n\nlocally to make sure the docs are good.","commit_id":"9c01acec28fb9ab14b07bee70381f8e77e9be71a"}]}