)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve usability of booting guest with SR-IOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This blueprint describes the addition of a new boot argument to the network"},{"line_number":10,"context_line":"options in order to be able to specify a VIF model of type SR-IOV for network"},{"line_number":11,"context_line":"attachments. This feature improves the usability of SR-IOV network devices."},{"line_number":12,"context_line":"Currently booting a guest with NIC SR-IOV attachment requires the user to"},{"line_number":13,"context_line":"first create a Neutron port making it a multi-steps procedure."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I876463f9a043e189b8cb27e8c230d575da485da3"},{"line_number":16,"context_line":"Implements: blueprint vif-model-sriov"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_ad679a4b","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":62},"updated":"2016-09-07 09:55:42.000000000","message":"nit: could you wrap this at 72 character?","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve usability of booting guest with SR-IOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This blueprint describes the addition of a new boot argument to the network"},{"line_number":10,"context_line":"options in order to be able to specify a VIF model of type SR-IOV for network"},{"line_number":11,"context_line":"attachments. This feature improves the usability of SR-IOV network devices."},{"line_number":12,"context_line":"Currently booting a guest with NIC SR-IOV attachment requires the user to"},{"line_number":13,"context_line":"first create a Neutron port making it a multi-steps procedure."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I876463f9a043e189b8cb27e8c230d575da485da3"},{"line_number":16,"context_line":"Implements: blueprint vif-model-sriov"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_91ccbfbc","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":62},"in_reply_to":"9a89bdaa_ad679a4b","updated":"2016-09-12 17:15:42.000000000","message":"Done","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"}],"specs/ocata/approved/vif-model-sriov.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Use Cases"},{"line_number":51,"context_line":"---------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"A user wants to launch a guest with an SR-IOV network device (or a PF"},{"line_number":54,"context_line":"passthrough) and they want nova to create the neutron port for him like it"},{"line_number":55,"context_line":"does for any other type of ports."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_008ccdd8","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":7},"updated":"2016-09-07 09:55:42.000000000","message":"As a user, I want...?","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The proposed solution is to extend the Nova compute REST API to support an"},{"line_number":62,"context_line":"extra parameter ‘vif-model’ in the list of requested networks.  The"},{"line_number":63,"context_line":"\u0027vif-model\u0027 is an opaque string.  The value is a valid model: either \u0027vf\u0027"},{"line_number":64,"context_line":"or \u0027pf\u0027."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The python-novaclient would be extended to support the new argument \u0027vif-model\u0027"},{"line_number":67,"context_line":"that can be associated with each requested network specified (\"--nic\")."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_e0a8c9dd","line":64,"range":{"start_line":63,"start_character":34,"end_line":64,"end_character":8},"updated":"2016-09-07 09:55:42.000000000","message":"Would it be helpful to add an implicit default for the standard virtio-based (?) drive nova would normally use? That way, folks could always pass the \u0027vif-model\u0027 argument and just explicitly request a standard vif type when that\u0027s all that\u0027s needed (think: scripting)","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The proposed solution is to extend the Nova compute REST API to support an"},{"line_number":62,"context_line":"extra parameter ‘vif-model’ in the list of requested networks.  The"},{"line_number":63,"context_line":"\u0027vif-model\u0027 is an opaque string.  The value is a valid model: either \u0027vf\u0027"},{"line_number":64,"context_line":"or \u0027pf\u0027."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The python-novaclient would be extended to support the new argument \u0027vif-model\u0027"},{"line_number":67,"context_line":"that can be associated with each requested network specified (\"--nic\")."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_31a213af","line":64,"range":{"start_line":63,"start_character":34,"end_line":64,"end_character":8},"in_reply_to":"9a89bdaa_e0a8c9dd","updated":"2016-09-12 17:15:42.000000000","message":"Done","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"In the case that interests us, the same logic needs to be applied for guests"},{"line_number":85,"context_line":"that are specifying a vif-model \u0027vf\u0027 or \u0027pf\u0027.  Therefore we suggest that the"},{"line_number":86,"context_line":"nova compute API gets modified consistently. Meaning that the nova compute API"},{"line_number":87,"context_line":"will create a PCI requests for each of the network requested that are"},{"line_number":88,"context_line":"specified with the SR-IOV or a PF passthrough VIF model."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The nova layer that interacts with neutron already supports the creation of"},{"line_number":91,"context_line":"ports following the requested networks specified when booting an instance."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_c03f4585","line":88,"range":{"start_line":86,"start_character":45,"end_line":88,"end_character":56},"updated":"2016-09-07 09:55:42.000000000","message":"What happens if the port is created but the PCI request fails?","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"In the case that interests us, the same logic needs to be applied for guests"},{"line_number":85,"context_line":"that are specifying a vif-model \u0027vf\u0027 or \u0027pf\u0027.  Therefore we suggest that the"},{"line_number":86,"context_line":"nova compute API gets modified consistently. Meaning that the nova compute API"},{"line_number":87,"context_line":"will create a PCI requests for each of the network requested that are"},{"line_number":88,"context_line":"specified with the SR-IOV or a PF passthrough VIF model."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The nova layer that interacts with neutron already supports the creation of"},{"line_number":91,"context_line":"ports following the requested networks specified when booting an instance."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_71801bc0","line":88,"range":{"start_line":86,"start_character":45,"end_line":88,"end_character":56},"in_reply_to":"9a89bdaa_c03f4585","updated":"2016-09-12 17:15:42.000000000","message":"The ports are created in\nhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L805.\n\nThis happens after the guest is scheduled and after the claim is done on the compute.\n\nIf an error occurs, this would be treated as any other ports.  \nThe ports are deleted when an instance is destroyed (see deallocate_for_instance()).","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  an an instance."},{"line_number":123,"context_line":"* The /v2.1/{tenant_id}/servers POST method needs to support the new"},{"line_number":124,"context_line":"  ‘vif-model’ argument."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The proposed change necessitate to add a new microversion to the REST"},{"line_number":127,"context_line":"API."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_80d53d1d","line":125,"updated":"2016-09-07 09:55:42.000000000","message":"Don\u0027t we need API response samples?","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  an an instance."},{"line_number":123,"context_line":"* The /v2.1/{tenant_id}/servers POST method needs to support the new"},{"line_number":124,"context_line":"  ‘vif-model’ argument."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The proposed change necessitate to add a new microversion to the REST"},{"line_number":127,"context_line":"API."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_f14b4baf","line":125,"in_reply_to":"9a89bdaa_80d53d1d","updated":"2016-09-12 17:15:42.000000000","message":"Done","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Other end user impact"},{"line_number":143,"context_line":"---------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Changes in openstack are required."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"We recommend to only support this feature through the command line interface"},{"line_number":148,"context_line":"for now.  But it\u0027s also possible to extend horizon as such."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_a0c16156","line":145,"range":{"start_line":145,"start_character":11,"end_line":145,"end_character":20},"updated":"2016-09-07 09:55:42.000000000","message":"other OpenStack projects?","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Other end user impact"},{"line_number":143,"context_line":"---------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Changes in openstack are required."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"We recommend to only support this feature through the command line interface"},{"line_number":148,"context_line":"for now.  But it\u0027s also possible to extend horizon as such."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_d1d9e7f4","line":145,"range":{"start_line":145,"start_character":11,"end_line":145,"end_character":20},"in_reply_to":"9a89bdaa_a0c16156","updated":"2016-09-12 17:15:42.000000000","message":"Meant openstack client ...\n\nFixed now.","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Changes in openstack are required."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"We recommend to only support this feature through the command line interface"},{"line_number":148,"context_line":"for now.  But it\u0027s also possible to extend horizon as such."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Performance Impact"},{"line_number":151,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_20ce3182","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":59},"updated":"2016-09-07 09:55:42.000000000","message":"The nova and openstack clients will gain support for this feature. Enhancements to the OpenStack dashboard are outside of the scope of this spec.","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Developer impact"},{"line_number":163,"context_line":"----------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"None"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_20cab14e","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":4},"updated":"2016-09-07 09:55:42.000000000","message":"Developers working on other hypervisors will need to implement support for this feature\nDevelopers working on the python-novaclient and python-openstackclient command line interfaces...\nDevelopers working on the OpenStack dashboard...","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"* Extend the Nova compute REST API."},{"line_number":185,"context_line":"* Extend openstack client."},{"line_number":186,"context_line":"* Change the nova.compute.API object to handle the creation of the PCI request."},{"line_number":187,"context_line":"* Modify the nova.network.neutronv2.API."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Dependencies"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_2002b13d","line":187,"range":{"start_line":187,"start_character":39,"end_line":187,"end_character":40},"updated":"2016-09-07 09:55:42.000000000","message":"to...?","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"* Extend the Nova compute REST API."},{"line_number":185,"context_line":"* Extend openstack client."},{"line_number":186,"context_line":"* Change the nova.compute.API object to handle the creation of the PCI request."},{"line_number":187,"context_line":"* Modify the nova.network.neutronv2.API."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Dependencies"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_d17567cb","line":187,"range":{"start_line":187,"start_character":39,"end_line":187,"end_character":40},"in_reply_to":"9a89bdaa_2002b13d","updated":"2016-09-12 17:15:42.000000000","message":"Done","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Testing"},{"line_number":196,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"As usual, tox unit tests will have to be written to properly test this new"},{"line_number":199,"context_line":"feature."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"This feature can\u0027t be tested in a virtual environment and require servers with"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_e0d449be","line":198,"range":{"start_line":198,"start_character":0,"end_line":198,"end_character":10},"updated":"2016-09-07 09:55:42.000000000","message":"Drop this","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Testing"},{"line_number":196,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"As usual, tox unit tests will have to be written to properly test this new"},{"line_number":199,"context_line":"feature."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"This feature can\u0027t be tested in a virtual environment and require servers with"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_60e1199a","line":198,"range":{"start_line":198,"start_character":25,"end_line":198,"end_character":41},"updated":"2016-09-07 09:55:42.000000000","message":"nit: will be","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Testing"},{"line_number":196,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"As usual, tox unit tests will have to be written to properly test this new"},{"line_number":199,"context_line":"feature."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"This feature can\u0027t be tested in a virtual environment and require servers with"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_b15f0340","line":198,"range":{"start_line":198,"start_character":25,"end_line":198,"end_character":41},"in_reply_to":"9a89bdaa_60e1199a","updated":"2016-09-12 17:15:42.000000000","message":"Done","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Testing"},{"line_number":196,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"As usual, tox unit tests will have to be written to properly test this new"},{"line_number":199,"context_line":"feature."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"This feature can\u0027t be tested in a virtual environment and require servers with"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_91467f79","line":198,"range":{"start_line":198,"start_character":0,"end_line":198,"end_character":10},"in_reply_to":"9a89bdaa_e0d449be","updated":"2016-09-12 17:15:42.000000000","message":"Done","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"   * - Release Name"},{"line_number":228,"context_line":"     - Description"},{"line_number":229,"context_line":"   * - Mitaka"},{"line_number":230,"context_line":"     - Introduced but no changes merged."},{"line_number":231,"context_line":"   * - ocata"},{"line_number":232,"context_line":"     - Re-proposed."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_4076d506","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":40},"updated":"2016-09-07 09:55:42.000000000","message":"nit: Drop this? (it\u0027s obvious)","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":227,"context_line":"   * - Release Name"},{"line_number":228,"context_line":"     - Description"},{"line_number":229,"context_line":"   * - Mitaka"},{"line_number":230,"context_line":"     - Introduced but no changes merged."},{"line_number":231,"context_line":"   * - ocata"},{"line_number":232,"context_line":"     - Re-proposed."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_31321311","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":40},"in_reply_to":"9a89bdaa_4076d506","updated":"2016-09-12 17:15:42.000000000","message":"Done","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"     - Description"},{"line_number":229,"context_line":"   * - Mitaka"},{"line_number":230,"context_line":"     - Introduced but no changes merged."},{"line_number":231,"context_line":"   * - ocata"},{"line_number":232,"context_line":"     - Re-proposed."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_e05d297a","line":231,"updated":"2016-09-07 09:55:42.000000000","message":"Newton?","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1942f904c1900dc543cd8f73344385cb2471b0c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"     - Description"},{"line_number":229,"context_line":"   * - Mitaka"},{"line_number":230,"context_line":"     - Introduced but no changes merged."},{"line_number":231,"context_line":"   * - ocata"},{"line_number":232,"context_line":"     - Re-proposed."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_604af9ad","line":231,"range":{"start_line":231,"start_character":7,"end_line":231,"end_character":12},"updated":"2016-09-07 09:55:42.000000000","message":"Ocata","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce13edef2e08e7b96622311c1f9fc981b1178c7f","unresolved":false,"context_lines":[{"line_number":228,"context_line":"     - Description"},{"line_number":229,"context_line":"   * - Mitaka"},{"line_number":230,"context_line":"     - Introduced but no changes merged."},{"line_number":231,"context_line":"   * - ocata"},{"line_number":232,"context_line":"     - Re-proposed."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_d10ac725","line":231,"in_reply_to":"9a89bdaa_e05d297a","updated":"2016-09-12 17:15:42.000000000","message":"Done","commit_id":"fcf6ec374850e515f8fc81bac7e3ba352039aa8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f9d1087afff88b93d67a8dfc6bcb1c4d08e0eb1b","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The proposed solution is to extend the Nova compute REST API to support an"},{"line_number":62,"context_line":"extra parameter ‘vif-model’ in the list of requested networks.  The"},{"line_number":63,"context_line":"\u0027vif-model\u0027 is an opaque string.  The value is a valid model: either \u0027vf\u0027"},{"line_number":64,"context_line":"or \u0027pf\u0027.  The default value for the vif-model is \u0027virtio\u0027."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The python-novaclient would be extended to support the new argument \u0027vif-model\u0027"},{"line_number":67,"context_line":"that can be associated with each requested network specified (\"--nic\")."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a8bc5a2_40cba71e","line":64,"range":{"start_line":63,"start_character":62,"end_line":64,"end_character":58},"updated":"2016-09-28 11:40:58.000000000","message":"How about:\n\n    ...model: `vf`, `pf`, or `virtio` (default)","commit_id":"fc30f0baf5fcf9dc431fbf021c752c079b4ea372"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"ff899f8cec9aabdc35ed7f379203583505a37c37","unresolved":false,"context_lines":[{"line_number":71,"context_line":"::"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  $ nova boot --image\u003dguest.img --flavor\u003dsmall \\"},{"line_number":74,"context_line":"              --nic net-id\u003d$NETID,vif-model\u003dvf guest0"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Currently booting an instance with an SR-IOV port demands that a neutron port"},{"line_number":77,"context_line":"is pre-populated before requesting booting such an instance. The nova"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_52bff6fa","line":74,"range":{"start_line":74,"start_character":34,"end_line":74,"end_character":47},"updated":"2016-09-29 07:17:55.000000000","message":"how would you know if you want macvtap or direct (tap attached to vf or vf pass-thorough)","commit_id":"fc30f0baf5fcf9dc431fbf021c752c079b4ea372"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"ff899f8cec9aabdc35ed7f379203583505a37c37","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This feature can\u0027t be tested in a virtual environment and require servers with"},{"line_number":204,"context_line":"NIC that supports SR-IOV. Specific tests could most likely be added to the"},{"line_number":205,"context_line":"Intel PCI CI to validate the changes."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_32cfca57","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":36},"updated":"2016-09-29 07:17:55.000000000","message":"the model\u003dvf can be tested in the Mellanox SR-IOV CI\n\nnot sure but isn\u0027t this change requires change in tempest?","commit_id":"fc30f0baf5fcf9dc431fbf021c752c079b4ea372"}]}