)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"77b2197c1a7ade6695e00073d6038cc455b830a5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec describe the deprecation of image-metadata API"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implement blueprint deprecate-image-meta-proxy-api"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie532bfde231b783d7d0cfc3d76e2c3a8cace5831"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_4c8795b4","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"updated":"2016-09-27 15:26:30.000000000","message":"need API impact?","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f62742ee9e1266ec69a8d97be80f9933d6e7609","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec describe the deprecation of image-metadata API"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implement blueprint deprecate-image-meta-proxy-api"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie532bfde231b783d7d0cfc3d76e2c3a8cace5831"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_a95e3810","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"in_reply_to":"5a8bc5a2_4c8795b4","updated":"2016-09-27 20:49:37.000000000","message":"Yes, needs the APIImpact tag.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dd11b81e69be55bf5c8b4ec4f781bf09239508df","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec describe the deprecation of image-metadata API"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implement blueprint deprecate-image-meta-proxy-api"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie532bfde231b783d7d0cfc3d76e2c3a8cace5831"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_7a5a2752","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"in_reply_to":"5a8bc5a2_a95e3810","updated":"2016-09-28 03:40:47.000000000","message":"yea, will update.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"}],"deprecate-image-meta-proxy-api.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af1f976219c0a89a1c37a2ab9259f0538a9190f3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"is one of them. It is just a proxy API for Glance API to operate the image"},{"line_number":22,"context_line":"metadata."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"There is quota check in `create_image/backup` APIs for extra metadatas, it"},{"line_number":25,"context_line":"enforces with Nova `metadata` quota. This quota check should be enforced by the"},{"line_number":26,"context_line":"Glance API directly. Nova shouldn\u0027t enforce quota for the resource which isn\u0027t"},{"line_number":27,"context_line":"managed by itself."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_2945c816","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":18},"updated":"2016-09-27 21:00:47.000000000","message":"Does glance enforce a quote on image metadata? I don\u0027t believe glance has a concept of quotas on image metadata/properties, only on total bytes allowed per tenant (so image size quota).\n\n(later)\n\nOK I guess glance does enforce quota on additional image properties via the image_property_quota config option, and the default is the same as nova, 128.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dd11b81e69be55bf5c8b4ec4f781bf09239508df","unresolved":false,"context_lines":[{"line_number":21,"context_line":"is one of them. It is just a proxy API for Glance API to operate the image"},{"line_number":22,"context_line":"metadata."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"There is quota check in `create_image/backup` APIs for extra metadatas, it"},{"line_number":25,"context_line":"enforces with Nova `metadata` quota. This quota check should be enforced by the"},{"line_number":26,"context_line":"Glance API directly. Nova shouldn\u0027t enforce quota for the resource which isn\u0027t"},{"line_number":27,"context_line":"managed by itself."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_1a3a03e8","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":18},"in_reply_to":"5a8bc5a2_2945c816","updated":"2016-09-28 03:40:47.000000000","message":"yes, just as you said, the config option \u0027image_property_quota\u0027 control that.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7920607f31c802ab79973e6a6a5dd2732fb1c6c5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"snapshot for the volume first, then create the image. That means the quota"},{"line_number":45,"context_line":"enforcement from Glance side is executed at the last minute in the API, and at"},{"line_number":46,"context_line":"that point all the volume\u0027s snapshop is already created. For an efficient API,"},{"line_number":47,"context_line":"the create_image API should fail in early stage for exceed quota limit. So the"},{"line_number":48,"context_line":"propose is Nova should create image first, then Nova can ensure the extra"},{"line_number":49,"context_line":"metadata doesn\u0027t exceed the quota limit in Glance side before create snapshot"},{"line_number":50,"context_line":"for the volume."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_c929c4f4","line":50,"range":{"start_line":47,"start_character":72,"end_line":50,"end_character":15},"updated":"2016-09-27 21:20:50.000000000","message":"Hmm, but what do we lose if we do the volume snapshot second, and this is going to have to be plumbed down through the compute API based on the microversion used in the REST API, or is it going to just be the default behavior for all microversions?","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b8771075922dceaedc98913d6b4b354ff74427ac","unresolved":false,"context_lines":[{"line_number":44,"context_line":"snapshot for the volume first, then create the image. That means the quota"},{"line_number":45,"context_line":"enforcement from Glance side is executed at the last minute in the API, and at"},{"line_number":46,"context_line":"that point all the volume\u0027s snapshop is already created. For an efficient API,"},{"line_number":47,"context_line":"the create_image API should fail in early stage for exceed quota limit. So the"},{"line_number":48,"context_line":"propose is Nova should create image first, then Nova can ensure the extra"},{"line_number":49,"context_line":"metadata doesn\u0027t exceed the quota limit in Glance side before create snapshot"},{"line_number":50,"context_line":"for the volume."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_2d304401","line":50,"range":{"start_line":47,"start_character":72,"end_line":50,"end_character":15},"in_reply_to":"3a98d1f4_51a0fe90","updated":"2016-09-29 10:48:11.000000000","message":"yea, right, so let me separate this into a bug","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76fa4e203c5eb3a367bd7bcafef96479eee543f7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"snapshot for the volume first, then create the image. That means the quota"},{"line_number":45,"context_line":"enforcement from Glance side is executed at the last minute in the API, and at"},{"line_number":46,"context_line":"that point all the volume\u0027s snapshop is already created. For an efficient API,"},{"line_number":47,"context_line":"the create_image API should fail in early stage for exceed quota limit. So the"},{"line_number":48,"context_line":"propose is Nova should create image first, then Nova can ensure the extra"},{"line_number":49,"context_line":"metadata doesn\u0027t exceed the quota limit in Glance side before create snapshot"},{"line_number":50,"context_line":"for the volume."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_51a0fe90","line":50,"range":{"start_line":47,"start_character":72,"end_line":50,"end_character":15},"in_reply_to":"3a98d1f4_5651d461","updated":"2016-09-28 14:19:05.000000000","message":"Right, cinder has a quota on snapshots, so if we create the image in glance first and then try to create the volume snapshot in cinder, that could fail on quota.\n\nI think either way if we don\u0027t clean up today, we have a bug and could just fix that separately. You could probably easily test it in devstack by creating a volume-backed instance, drop the image_property_quota to 0 in glance and try to create the snapshot and see if it fails and everything is cleaned up.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fbd07d0fad46be335528dc052114daa0044a07a8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"snapshot for the volume first, then create the image. That means the quota"},{"line_number":45,"context_line":"enforcement from Glance side is executed at the last minute in the API, and at"},{"line_number":46,"context_line":"that point all the volume\u0027s snapshop is already created. For an efficient API,"},{"line_number":47,"context_line":"the create_image API should fail in early stage for exceed quota limit. So the"},{"line_number":48,"context_line":"propose is Nova should create image first, then Nova can ensure the extra"},{"line_number":49,"context_line":"metadata doesn\u0027t exceed the quota limit in Glance side before create snapshot"},{"line_number":50,"context_line":"for the volume."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_5651d461","line":50,"range":{"start_line":47,"start_character":72,"end_line":50,"end_character":15},"in_reply_to":"5a8bc5a2_850f942d","updated":"2016-09-28 14:04:57.000000000","message":"Yeah, as in meeting, lets just keep this change out of here, and cover that else where, as both calls could fail.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dd11b81e69be55bf5c8b4ec4f781bf09239508df","unresolved":false,"context_lines":[{"line_number":44,"context_line":"snapshot for the volume first, then create the image. That means the quota"},{"line_number":45,"context_line":"enforcement from Glance side is executed at the last minute in the API, and at"},{"line_number":46,"context_line":"that point all the volume\u0027s snapshop is already created. For an efficient API,"},{"line_number":47,"context_line":"the create_image API should fail in early stage for exceed quota limit. So the"},{"line_number":48,"context_line":"propose is Nova should create image first, then Nova can ensure the extra"},{"line_number":49,"context_line":"metadata doesn\u0027t exceed the quota limit in Glance side before create snapshot"},{"line_number":50,"context_line":"for the volume."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_850f942d","line":50,"range":{"start_line":47,"start_character":72,"end_line":50,"end_character":15},"in_reply_to":"5a8bc5a2_c929c4f4","updated":"2016-09-28 03:40:47.000000000","message":"We need to rollback code for deleting image when volume snapshot second failed. But I will check more.\n\nThis should be default behaviour for all microversions. User won\u0027t feel any change from the old API. ( Only a little thing, the image created, and deleted when volume snapshot failed, but I think it\u0027s fine).","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7920607f31c802ab79973e6a6a5dd2732fb1c6c5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"REST API impact"},{"line_number":64,"context_line":"---------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Deprecated the `image-metadata` API and remove the image metadata quota"},{"line_number":67,"context_line":"enforcement with Nova `metadata` quota for create_image/backup APIs in new"},{"line_number":68,"context_line":"Microversion."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Security impact"},{"line_number":71,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_892edca3","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":13},"updated":"2016-09-27 21:20:50.000000000","message":"You may want to point out that this will work like the 2.36 microversion in that requesting these APIs after the microversion will result in a 404, at least for the os-image-metadata API.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dd11b81e69be55bf5c8b4ec4f781bf09239508df","unresolved":false,"context_lines":[{"line_number":63,"context_line":"REST API impact"},{"line_number":64,"context_line":"---------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Deprecated the `image-metadata` API and remove the image metadata quota"},{"line_number":67,"context_line":"enforcement with Nova `metadata` quota for create_image/backup APIs in new"},{"line_number":68,"context_line":"Microversion."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Security impact"},{"line_number":71,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_e524d8b3","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":13},"in_reply_to":"5a8bc5a2_892edca3","updated":"2016-09-28 03:40:47.000000000","message":"yea, will update","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7920607f31c802ab79973e6a6a5dd2732fb1c6c5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Other end user impact"},{"line_number":81,"context_line":"---------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The ``nova image-meta`` CLI is already deprecated. The API part will be cap to"},{"line_number":84,"context_line":"the new microversion also. User only can use this command in the old"},{"line_number":85,"context_line":"Microversion. and we\u0027ll plan to remove that in the first major"},{"line_number":86,"context_line":"python-novaclient release after Nova 15.0.0 is released."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_6908b02e","line":83,"range":{"start_line":83,"start_character":55,"end_line":83,"end_character":63},"updated":"2016-09-27 21:20:50.000000000","message":"To be clear, you mean the python API binding in python-novaclient, you should be explicit about that here.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dd11b81e69be55bf5c8b4ec4f781bf09239508df","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Other end user impact"},{"line_number":81,"context_line":"---------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The ``nova image-meta`` CLI is already deprecated. The API part will be cap to"},{"line_number":84,"context_line":"the new microversion also. User only can use this command in the old"},{"line_number":85,"context_line":"Microversion. and we\u0027ll plan to remove that in the first major"},{"line_number":86,"context_line":"python-novaclient release after Nova 15.0.0 is released."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_052aa47e","line":83,"range":{"start_line":83,"start_character":55,"end_line":83,"end_character":63},"in_reply_to":"5a8bc5a2_6908b02e","updated":"2016-09-28 03:40:47.000000000","message":"Done","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7920607f31c802ab79973e6a6a5dd2732fb1c6c5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Work Items"},{"line_number":114,"context_line":"----------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* Create image before create snapshot volume for the create image/backup API"},{"line_number":117,"context_line":"* Deprecated the `image-metadata` API and remove the quota check for create"},{"line_number":118,"context_line":"  image/back actions in new Microversion."},{"line_number":119,"context_line":"* Cap the image metadata in the python-novaclient."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_1c24ccad","line":116,"updated":"2016-09-27 21:20:50.000000000","message":"This seems non-trivial to me, so I\u0027d like to know if there are any issues with doing this we need to be aware of before we go forward with this. If there aren\u0027t, please explain in the spec why there won\u0027t be issues with changing this order, and if it\u0027s going to be dependent on the microversion or just a new change in behavior.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dd11b81e69be55bf5c8b4ec4f781bf09239508df","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Work Items"},{"line_number":114,"context_line":"----------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* Create image before create snapshot volume for the create image/backup API"},{"line_number":117,"context_line":"* Deprecated the `image-metadata` API and remove the quota check for create"},{"line_number":118,"context_line":"  image/back actions in new Microversion."},{"line_number":119,"context_line":"* Cap the image metadata in the python-novaclient."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_8536b4e5","line":116,"in_reply_to":"5a8bc5a2_1c24ccad","updated":"2016-09-28 03:40:47.000000000","message":"yea, I will explain more.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7920607f31c802ab79973e6a6a5dd2732fb1c6c5","unresolved":false,"context_lines":[{"line_number":130,"context_line":"after this microversion and return 404s."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"For Tempest, the ImagesMetadataTestJSON will need to be capped at the"},{"line_number":133,"context_line":"microversion. There are `ongoing discussions`_ on how to handle this"},{"line_number":134,"context_line":"in the openstack-dev mailing list."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Documentation Impact"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_dc77c49d","line":134,"range":{"start_line":133,"start_character":14,"end_line":134,"end_character":34},"updated":"2016-09-27 21:20:50.000000000","message":"This was never actually settled, just FYI. I don\u0027t know where the Tempest core team is sitting on this issue now, they were pretty divided the last time I tried moving it forward.\n\nhttps://review.openstack.org/#/c/346092/","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76fa4e203c5eb3a367bd7bcafef96479eee543f7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"after this microversion and return 404s."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"For Tempest, the ImagesMetadataTestJSON will need to be capped at the"},{"line_number":133,"context_line":"microversion. There are `ongoing discussions`_ on how to handle this"},{"line_number":134,"context_line":"in the openstack-dev mailing list."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Documentation Impact"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_51ce3e5b","line":134,"range":{"start_line":133,"start_character":14,"end_line":134,"end_character":34},"in_reply_to":"5a8bc5a2_455bcc2e","updated":"2016-09-28 14:19:05.000000000","message":"I think in Tempest it\u0027s pretty easy, any tests that call the image-metadata API in nova will just have to be capped at the microversion, or changed to call glance instead.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dd11b81e69be55bf5c8b4ec4f781bf09239508df","unresolved":false,"context_lines":[{"line_number":130,"context_line":"after this microversion and return 404s."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"For Tempest, the ImagesMetadataTestJSON will need to be capped at the"},{"line_number":133,"context_line":"microversion. There are `ongoing discussions`_ on how to handle this"},{"line_number":134,"context_line":"in the openstack-dev mailing list."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Documentation Impact"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_455bcc2e","line":134,"range":{"start_line":133,"start_character":14,"end_line":134,"end_character":34},"in_reply_to":"5a8bc5a2_dc77c49d","updated":"2016-09-28 03:40:47.000000000","message":"yea, I\u0027m a little confuse what we should do for now also","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7920607f31c802ab79973e6a6a5dd2732fb1c6c5","unresolved":false,"context_lines":[{"line_number":150,"context_line":"History"},{"line_number":151,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Optional section intended to be used each time the spec is updated to describe"},{"line_number":154,"context_line":"new design, API or any database schema updated. Useful to let reader understand"},{"line_number":155,"context_line":"what\u0027s happened along the time."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":".. list-table:: Revisions"},{"line_number":158,"context_line":"   :header-rows: 1"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_7c8f9075","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":31},"updated":"2016-09-27 21:20:50.000000000","message":"You can remove this text from the template.","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dd11b81e69be55bf5c8b4ec4f781bf09239508df","unresolved":false,"context_lines":[{"line_number":150,"context_line":"History"},{"line_number":151,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Optional section intended to be used each time the spec is updated to describe"},{"line_number":154,"context_line":"new design, API or any database schema updated. Useful to let reader understand"},{"line_number":155,"context_line":"what\u0027s happened along the time."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":".. list-table:: Revisions"},{"line_number":158,"context_line":"   :header-rows: 1"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_6540c836","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":31},"in_reply_to":"5a8bc5a2_7c8f9075","updated":"2016-09-28 03:40:47.000000000","message":"Done","commit_id":"331799efd7b1922407f8cadcf0f0dad7e628cf01"}],"specs/ocata/approved/deprecate-image-meta-proxy-api.rst":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7d3a8b15ce45754c05ddc808c5ad598ebc16325d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"REST API impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"With new microversion, the request to the `image-metadata` API will get"},{"line_number":59,"context_line":"response `HTTPNotFound 404`, and the image quota enforcement with Nova"},{"line_number":60,"context_line":"`metadata` will be removed also."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_f14d4773","line":58,"range":{"start_line":58,"start_character":43,"end_line":58,"end_character":48},"updated":"2016-09-29 14:07:19.000000000","message":"will this also affects limits API as well? \n\n[root@xcat ~] # nova limits\n+------+-----+-------+--------+------+----------------+\n| Verb | URI | Value | Remain | Unit | Next_Available |\n+------+-----+-------+--------+------+----------------+\n+------+-----+-------+--------+------+----------------+\n+--------------------+-------+--------+\n| Name               | Used  | Max    |\n+--------------------+-------+--------+\n| Cores              | 11    | 900    |\n| FloatingIps        | 0     | 10     |\n| ImageMeta          | -     | 128    |","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1aeaafdee16400881e371237cc563fc32a66d9f1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"REST API impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"With new microversion, the request to the `image-metadata` API will get"},{"line_number":59,"context_line":"response `HTTPNotFound 404`, and the image quota enforcement with Nova"},{"line_number":60,"context_line":"`metadata` will be removed also."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_a6baa0df","line":58,"range":{"start_line":58,"start_character":43,"end_line":58,"end_character":48},"in_reply_to":"3a98d1f4_1462a1ad","updated":"2016-09-29 15:30:34.000000000","message":"thanks for catch this! will update","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"60c1e7ad5c128d5e9d917ed8057e4fa8a2805ea4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"REST API impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"With new microversion, the request to the `image-metadata` API will get"},{"line_number":59,"context_line":"response `HTTPNotFound 404`, and the image quota enforcement with Nova"},{"line_number":60,"context_line":"`metadata` will be removed also."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_1462a1ad","line":58,"range":{"start_line":58,"start_character":43,"end_line":58,"end_character":48},"in_reply_to":"3a98d1f4_d14a0bac","updated":"2016-09-29 14:23:10.000000000","message":"I checked os-quota-sets because of:\n\nhttps://github.com/openstack/nova/blob/c95c2f2e7b9564b6908421a53ca8edd0a900284e/nova/api/openstack/compute/quota_sets.py#L41\n\nBut I don\u0027t think we return anything specific for image-meta-quota in that API given:\n\nDEBUG (session:366) RESP: [200] Content-Length: 283 Content-Type: application/json Openstack-Api-Version: compute 2.37 X-Openstack-Nova-Api-Version: 2.37 Vary: OpenStack-API-Version, X-OpenStack-Nova-API-Version X-Compute-Request-Id: req-6d9491a4-6423-4289-8234-9356bbc8d9c0 Date: Thu, 29 Sep 2016 14:22:38 GMT Connection: keep-alive\nRESP BODY: {\"quota_set\": {\"injected_file_content_bytes\": 10240, \"metadata_items\": 128, \"server_group_members\": 10, \"server_groups\": 10, \"ram\": 51200, \"key_pairs\": 100, \"injected_file_path_bytes\": 255, \"instances\": 10, \"injected_files\": 5, \"cores\": 20, \"id\": \"3991cc2488184b5abae9861c94b56107\"}}","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e9db5ae2f60488f7065d5a35bc83437ffc19248b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"REST API impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"With new microversion, the request to the `image-metadata` API will get"},{"line_number":59,"context_line":"response `HTTPNotFound 404`, and the image quota enforcement with Nova"},{"line_number":60,"context_line":"`metadata` will be removed also."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_d14a0bac","line":58,"range":{"start_line":58,"start_character":43,"end_line":58,"end_character":48},"in_reply_to":"3a98d1f4_f14d4773","updated":"2016-09-29 14:17:24.000000000","message":"Yeah, we\u0027ll need to not show the image metadata limit in limits here:\n\nhttps://github.com/openstack/nova/blob/c95c2f2e7b9564b6908421a53ca8edd0a900284e/nova/api/openstack/compute/views/limits.py#L37\n\nSomething like this:\n\nhttps://github.com/openstack/nova/blob/c95c2f2e7b9564b6908421a53ca8edd0a900284e/nova/api/openstack/compute/views/limits.py#L22","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc93a51e087ea73d116ae2b1735cfe2c87bc29f6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Other end user impact"},{"line_number":73,"context_line":"---------------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"The ``nova image-meta`` CLI is already deprecated. The python API binding in"},{"line_number":76,"context_line":"python-novaclient will be cap to the new microversion also. User only can use"},{"line_number":77,"context_line":"this command in the old Microversion. and we\u0027ll plan to remove that in the"},{"line_number":78,"context_line":"first major python-novaclient release after Nova 15.0.0 is released."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_74dcc5e4","line":75,"updated":"2016-09-29 14:30:28.000000000","message":"Just a note to myself, I don\u0027t think we\u0027ll need to do anything in the client for nova limits CLI because if we don\u0027t return the maxImageMeta value in the response from the API then the CLI won\u0027t show it.\n\nhttps://github.com/openstack/python-novaclient/blob/6.0.0/novaclient/v2/shell.py#L3401\n\nThat won\u0027t be used if the key isn\u0027t in the limits value passed in.","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1aeaafdee16400881e371237cc563fc32a66d9f1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Other end user impact"},{"line_number":73,"context_line":"---------------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"The ``nova image-meta`` CLI is already deprecated. The python API binding in"},{"line_number":76,"context_line":"python-novaclient will be cap to the new microversion also. User only can use"},{"line_number":77,"context_line":"this command in the old Microversion. and we\u0027ll plan to remove that in the"},{"line_number":78,"context_line":"first major python-novaclient release after Nova 15.0.0 is released."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_86c4c45f","line":75,"in_reply_to":"3a98d1f4_74dcc5e4","updated":"2016-09-29 15:30:34.000000000","message":"yea","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc93a51e087ea73d116ae2b1735cfe2c87bc29f6","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"The ``nova image-meta`` CLI is already deprecated. The python API binding in"},{"line_number":76,"context_line":"python-novaclient will be cap to the new microversion also. User only can use"},{"line_number":77,"context_line":"this command in the old Microversion. and we\u0027ll plan to remove that in the"},{"line_number":78,"context_line":"first major python-novaclient release after Nova 15.0.0 is released."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_54b8a9e5","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":41},"updated":"2016-09-29 14:30:28.000000000","message":"s/. and/ and/ ?","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1aeaafdee16400881e371237cc563fc32a66d9f1","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"The ``nova image-meta`` CLI is already deprecated. The python API binding in"},{"line_number":76,"context_line":"python-novaclient will be cap to the new microversion also. User only can use"},{"line_number":77,"context_line":"this command in the old Microversion. and we\u0027ll plan to remove that in the"},{"line_number":78,"context_line":"first major python-novaclient release after Nova 15.0.0 is released."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_c6a40cbb","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":41},"in_reply_to":"3a98d1f4_54b8a9e5","updated":"2016-09-29 15:30:34.000000000","message":"Done","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7d3a8b15ce45754c05ddc808c5ad598ebc16325d","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Update the `api-ref`_ about the image-metadata is deprecated in the new"},{"line_number":131,"context_line":"Microversion. Also need upgrade note for the deployer the quota check of"},{"line_number":132,"context_line":"image metadata doesn\u0027t enforce at Nova side anymore."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"References"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_de54da22","line":132,"range":{"start_line":132,"start_character":23,"end_line":132,"end_character":30},"updated":"2016-09-29 14:07:19.000000000","message":"maybe also deprecate this one\nnova.quota.quota_metadata_items ?","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1aeaafdee16400881e371237cc563fc32a66d9f1","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Update the `api-ref`_ about the image-metadata is deprecated in the new"},{"line_number":131,"context_line":"Microversion. Also need upgrade note for the deployer the quota check of"},{"line_number":132,"context_line":"image metadata doesn\u0027t enforce at Nova side anymore."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"References"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_4691dc51","line":132,"range":{"start_line":132,"start_character":23,"end_line":132,"end_character":30},"in_reply_to":"3a98d1f4_91ac0337","updated":"2016-09-29 15:30:34.000000000","message":"yea, just as Matt said","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e9db5ae2f60488f7065d5a35bc83437ffc19248b","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Update the `api-ref`_ about the image-metadata is deprecated in the new"},{"line_number":131,"context_line":"Microversion. Also need upgrade note for the deployer the quota check of"},{"line_number":132,"context_line":"image metadata doesn\u0027t enforce at Nova side anymore."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"References"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a98d1f4_91ac0337","line":132,"range":{"start_line":132,"start_character":23,"end_line":132,"end_character":30},"in_reply_to":"3a98d1f4_de54da22","updated":"2016-09-29 14:17:24.000000000","message":"We can\u0027t deprecate the config option since it\u0027s used for both server.metadata and image_meta.properties, we only want to not use this for the latter.","commit_id":"57b262dd8a3dc6e882554ce06c7ebf58694adf3e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e26b88abe01a2a39079be460255a45e5def56cb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Work Items"},{"line_number":107,"context_line":"----------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Deprecated the `image-metadata` API, remove the quota check for create"},{"line_number":110,"context_line":"  image/back actions and remove `maxImageMeta` field from `os-limits` API in"},{"line_number":111,"context_line":"  new Microversion."},{"line_number":112,"context_line":"* Cap the image metadata in the python-novaclient."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a98d1f4_0c5e1576","line":111,"range":{"start_line":109,"start_character":2,"end_line":111,"end_character":19},"updated":"2016-09-29 15:53:29.000000000","message":"nit: I find it easier to process work items as a list of individual items, rather than a big block of prose.","commit_id":"7fe98fa3b3e686f5eacf24cd597b112537cbee16"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"311f3921dc2b51b1fbe544083428eeec6e13e1a4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"after this microversion and return 404s."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For Tempest, the ImagesMetadataTestJSON will need to be capped at the"},{"line_number":128,"context_line":"microversion. There are `ongoing discussions`_ on how to handle this"},{"line_number":129,"context_line":"in the openstack-dev mailing list."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Documentation Impact"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a98d1f4_2d6c5634","line":129,"range":{"start_line":128,"start_character":14,"end_line":129,"end_character":34},"updated":"2016-10-01 01:41:11.000000000","message":"Maybe I am missing something..\n\nIs it fine to just cap the maximum microversion of the test class and add new test class for this feature with a new microversion?","commit_id":"885b09175b2d0863ef340e9b21e4baec9de0730b"}]}