)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"9409959db1f6ed7af512c305017ec45926835f4c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and `AggregateInstanceExtraSpecsFilter` scheduler filters."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"An operator wants to schedule instances for a specific image/flavor"},{"line_number":13,"context_line":"on a pre-defined group of hosts. In addition, he wants to strictly"},{"line_number":14,"context_line":"isolate this group of hosts for the image/flacor only and accept"},{"line_number":15,"context_line":"images/flavors without key scheduled to other hosts."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa6399be_f42511c2","line":13,"range":{"start_line":13,"start_character":46,"end_line":13,"end_character":48},"updated":"2016-10-19 17:09:04.000000000","message":"nit: prefer \"he or she\" or \"they\" (https://en.oxforddictionaries.com/usage/he-or-she-versus-they)","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"}],"specs/ocata/approved/strict_isolation_of_group_of_hosts_for_image_and_flavor.rst":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"19a9e1ca9f50daa7013042e02465484b9b6ba7ae","unresolved":false,"context_lines":[{"line_number":63,"context_line":"+----------------+------------+----------+----------+"},{"line_number":64,"context_line":"| key\u003dbar        | False      | False    | False    |"},{"line_number":65,"context_line":"+----------------+------------+----------+----------+"},{"line_number":66,"context_line":"| \u003cempty\u003e        | False      | False    | True     |"},{"line_number":67,"context_line":"+----------------+------------+----------+----------+"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"*Table 2: rows are image/flavor properties, columns are aggregate metadata*"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_069089eb","line":66,"updated":"2016-10-06 17:35:46.000000000","message":"It would help highlight the differences if you made the 4 new False statements bold.","commit_id":"81c4a6a4215967af31ab3ce9b19f75d8d58851a5"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"c0f804b441640c4450d5d6f2c0c249ec47808c81","unresolved":false,"context_lines":[{"line_number":63,"context_line":"+----------------+------------+----------+----------+"},{"line_number":64,"context_line":"| key\u003dbar        | False      | False    | False    |"},{"line_number":65,"context_line":"+----------------+------------+----------+----------+"},{"line_number":66,"context_line":"| \u003cempty\u003e        | False      | False    | True     |"},{"line_number":67,"context_line":"+----------------+------------+----------+----------+"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"*Table 2: rows are image/flavor properties, columns are aggregate metadata*"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_f027afc7","line":66,"in_reply_to":"1a95cdbc_069089eb","updated":"2016-10-07 11:29:27.000000000","message":"agree, done","commit_id":"81c4a6a4215967af31ab3ce9b19f75d8d58851a5"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"19a9e1ca9f50daa7013042e02465484b9b6ba7ae","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* An alternative solution would be to create new filters that inherits from"},{"line_number":97,"context_line":"  `AggregateImagePropertiesIsolation` and `AggregateInstanceExtraSpecsFilter`"},{"line_number":98,"context_line":"  filters."},{"line_number":99,"context_line":"* A more configurable solution could be to use two config options e.g."},{"line_number":100,"context_line":"  `allow_untagged_images_in_tagged_aggregate\u003dTrue` and"},{"line_number":101,"context_line":"  `allow_tagged_images_in_untagged_aggregate\u003dTrue` but currently we cannot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_66d22dd4","line":98,"updated":"2016-10-06 17:35:46.000000000","message":"I would actually prefer this option. I think it will be less confusing to have filters with one behavior that\u0027s not changed by a config option.\n\nBut others should weigh in as ultimately either way seems fine.","commit_id":"81c4a6a4215967af31ab3ce9b19f75d8d58851a5"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"c0f804b441640c4450d5d6f2c0c249ec47808c81","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* An alternative solution would be to create new filters that inherits from"},{"line_number":97,"context_line":"  `AggregateImagePropertiesIsolation` and `AggregateInstanceExtraSpecsFilter`"},{"line_number":98,"context_line":"  filters."},{"line_number":99,"context_line":"* A more configurable solution could be to use two config options e.g."},{"line_number":100,"context_line":"  `allow_untagged_images_in_tagged_aggregate\u003dTrue` and"},{"line_number":101,"context_line":"  `allow_tagged_images_in_untagged_aggregate\u003dTrue` but currently we cannot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_502b0394","line":98,"in_reply_to":"1a95cdbc_66d22dd4","updated":"2016-10-07 11:29:27.000000000","message":"Waiting for other opinions)","commit_id":"81c4a6a4215967af31ab3ce9b19f75d8d58851a5"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1e281def1ccf9e7aee71b5c68a2b6a39673698f5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"and `AggregateInstanceExtraSpecsFilter` scheduler filters."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"An operator wants to schedule instances for a specific image/flavor on a"},{"line_number":17,"context_line":"pre-defined group of hosts. In addition, he wants to strictly isolate this"},{"line_number":18,"context_line":"group of hosts for the image/flavor only and accept images/flavors"},{"line_number":19,"context_line":"without key scheduled to other hosts."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_0e0e5b34","line":19,"range":{"start_line":17,"start_character":28,"end_line":19,"end_character":37},"updated":"2016-10-10 20:46:17.000000000","message":"Maybe this would be clearer wording?\n\n\"The operator would also like to prevent images/flavors without keys from being placed on this group of hosts.\"","commit_id":"5f480fbba77b16e6d969d1de8546bd64d1050426"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"be18e91c036d403e337fb5b0f3740dfbc10260a8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"and `AggregateInstanceExtraSpecsFilter` scheduler filters."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"An operator wants to schedule instances for a specific image/flavor on a"},{"line_number":17,"context_line":"pre-defined group of hosts. In addition, he wants to strictly isolate this"},{"line_number":18,"context_line":"group of hosts for the image/flavor only and accept images/flavors"},{"line_number":19,"context_line":"without key scheduled to other hosts."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_e5e20f9f","line":19,"range":{"start_line":17,"start_character":28,"end_line":19,"end_character":37},"in_reply_to":"fa6399be_0e0e5b34","updated":"2016-10-11 10:21:52.000000000","message":"Done","commit_id":"5f480fbba77b16e6d969d1de8546bd64d1050426"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f9bbb89b744e2ea74d243a2991ba1520d2f9cf96","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Users want to schedule instances for a specific image/flavor on a"},{"line_number":48,"context_line":"pre-defined group of hosts and strictly isolate this group of hosts for the"},{"line_number":49,"context_line":"image/flavor."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Proposed change"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_213d94bb","line":49,"updated":"2016-10-19 12:57:04.000000000","message":"I think it would help to have a more real usecase, so make the need clear.\n\nYou have a set of flavors, and you add some new hardware with SSDs and a new set of flavors. You don\u0027t want any of the non-SSD flavors getting on the new hardware, but you don\u0027t really want to modify the old flavor either.\n\nAgain you add something with faster CPU, you only want those flavours building on that hardware.\n\nThere is a mix of versions, and one of the images will not work on that version, so you need to exclude those hosts.\n\nDoes that all work? I guess it does with the new scheme, but not with the old scheme?","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"9409959db1f6ed7af512c305017ec45926835f4c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Users want to schedule instances for a specific image/flavor on a"},{"line_number":48,"context_line":"pre-defined group of hosts and strictly isolate this group of hosts for the"},{"line_number":49,"context_line":"image/flavor."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Proposed change"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_ef961a93","line":49,"in_reply_to":"fa6399be_213d94bb","updated":"2016-10-19 17:09:04.000000000","message":"++\n\nThe operators we talked to especially don\u0027t like the fact that you need to modify the existing flavors/images or aggregates to make it work now.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9757a04187d7036c9808c53686e917b87d072246","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Users want to schedule instances for a specific image/flavor on a"},{"line_number":48,"context_line":"pre-defined group of hosts and strictly isolate this group of hosts for the"},{"line_number":49,"context_line":"image/flavor."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Proposed change"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_df7e4fae","line":49,"in_reply_to":"fa6399be_ef961a93","updated":"2016-10-20 09:58:11.000000000","message":"Thats a great thing to add in the problem description. Modifying existing flavors and aggregates is going to create issues when you do things like rebuild or evacuate, when we use the stored flavor to choose a host.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eab903c4c77552b6b6780670e5f3173246adc41e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We would like to add one new option to each filter to:"},{"line_number":55,"context_line":" * Make tagged aggregate refuse not-tagged images/flavors"},{"line_number":56,"context_line":" * Make not-tagged aggregate accept ONLY not-tagged images/flavors"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_bc3134a4","line":55,"updated":"2016-10-17 12:39:54.000000000","message":"Should this one not be a property set on the aggregate?\n\n  image_strict_isolation\u003dTrue\n  extra_spec_strict_isolation\u003dTrue\n\nTo be clear, if key1 and key2 are both set on a single aggregate, does that mean both are required? If key1 and key2 set on separate aggregates, does that mean either are required? Its not clear to me.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"9409959db1f6ed7af512c305017ec45926835f4c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We would like to add one new option to each filter to:"},{"line_number":55,"context_line":" * Make tagged aggregate refuse not-tagged images/flavors"},{"line_number":56,"context_line":" * Make not-tagged aggregate accept ONLY not-tagged images/flavors"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_aaddf043","line":55,"in_reply_to":"fa6399be_7ce578a6","updated":"2016-10-19 17:09:04.000000000","message":"Now that John mentioned it, I think, per aggregate settings would allow for greater flexibility than a config option of nova-scheduler and makes more sense for the following use case:\n\nOperator adds a new set of hosts that support AVX2 CPU instructions. These can be specifically matched by the new flavor, which requires AVX2. At the same time, AVX2 is not that precious to prevent other - non tagged - flavors matching the very same hosts.\n\nIf extra_spec_strict_isolation was a config option, then operator could only choose between supporting this use case and the \"SSD use case\" from the comment above:\n\nYou have a set of flavors, and you add some new hardware with SSDs and a new set of flavors. You don\u0027t want any of the non-SSD flavors getting on the new hardware, but you don\u0027t really want to modify the old flavor either.\n\nat the configuration time, not at runtime for each aggregate separately.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"42750ba55c7e18876ab8b34badc8112a49c6bbed","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We would like to add one new option to each filter to:"},{"line_number":55,"context_line":" * Make tagged aggregate refuse not-tagged images/flavors"},{"line_number":56,"context_line":" * Make not-tagged aggregate accept ONLY not-tagged images/flavors"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_ff8dd3d3","line":55,"in_reply_to":"fa6399be_aaddf043","updated":"2016-10-20 09:56:40.000000000","message":"I like that specific use case, its a good one. Lets capture that in the use case section.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"33ca445aa67d520922a177621c22aea831fef444","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We would like to add one new option to each filter to:"},{"line_number":55,"context_line":" * Make tagged aggregate refuse not-tagged images/flavors"},{"line_number":56,"context_line":" * Make not-tagged aggregate accept ONLY not-tagged images/flavors"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_e6065584","line":55,"in_reply_to":"fa6399be_bc3134a4","updated":"2016-10-19 12:01:27.000000000","message":"We don\u0027t set \u0027strict_isolation\u0027 options on aggregates.\n\nWe only have two global config options, that are used for all aggregates (we don\u0027t propose here \u0027per aggregate\u0027 isolation). If aggregate has key1\u003dval1 and key2\u003dval2, only image/flavor with both equal keys\u003dvalues will be accepted in strict mode.\n\n(non-strict case remains the same as before the spec)","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f9bbb89b744e2ea74d243a2991ba1520d2f9cf96","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We would like to add one new option to each filter to:"},{"line_number":55,"context_line":" * Make tagged aggregate refuse not-tagged images/flavors"},{"line_number":56,"context_line":" * Make not-tagged aggregate accept ONLY not-tagged images/flavors"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_7ce578a6","line":55,"in_reply_to":"fa6399be_e6065584","updated":"2016-10-19 12:57:04.000000000","message":"Right, I am suggesting that seems wrong.\n\nIt feels more like this should be specific to the aggregate. At least its not clear to be from the use cases whats going on.\n\nMaybe if we were moving towards the changing the default for these configs, so we isolate by default, that would be easier.\n\nMaybe I am with alaski, that alternative of a new subclass is better.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eab903c4c77552b6b6780670e5f3173246adc41e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We would like to add one new option to each filter to:"},{"line_number":55,"context_line":" * Make tagged aggregate refuse not-tagged images/flavors"},{"line_number":56,"context_line":" * Make not-tagged aggregate accept ONLY not-tagged images/flavors"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"+----------------+------------+------------+------------+"},{"line_number":59,"context_line":"| props \\\\ aggr  | key\u003dfoo    | key\u003dxxx    | \u003cempty\u003e    |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_9cbc70dd","line":56,"updated":"2016-10-17 12:39:54.000000000","message":"This has to be an conf variable.\n\nI presume hosts not in an aggregate, are also treated in the same way?","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"33ca445aa67d520922a177621c22aea831fef444","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We would like to add one new option to each filter to:"},{"line_number":55,"context_line":" * Make tagged aggregate refuse not-tagged images/flavors"},{"line_number":56,"context_line":" * Make not-tagged aggregate accept ONLY not-tagged images/flavors"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"+----------------+------------+------------+------------+"},{"line_number":59,"context_line":"| props \\\\ aggr  | key\u003dfoo    | key\u003dxxx    | \u003cempty\u003e    |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_c694f1e9","line":56,"in_reply_to":"fa6399be_9cbc70dd","updated":"2016-10-19 12:01:27.000000000","message":"As I said, we have two global config options \u0027aggregate_image_filter_strict_isolation\u0027 and \u0027aggregate_extra_specs_filter_strict_isolation\u0027 your names looks better :)\n\nIf host is not in any aggregate, we will have empty metadata returned, so for strict isolation only empty image/flavor will be accepted.\n\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/filters/utils.py#L36","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f9bbb89b744e2ea74d243a2991ba1520d2f9cf96","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We would like to add one new option to each filter to:"},{"line_number":55,"context_line":" * Make tagged aggregate refuse not-tagged images/flavors"},{"line_number":56,"context_line":" * Make not-tagged aggregate accept ONLY not-tagged images/flavors"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"+----------------+------------+------------+------------+"},{"line_number":59,"context_line":"| props \\\\ aggr  | key\u003dfoo    | key\u003dxxx    | \u003cempty\u003e    |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_bc9470e8","line":56,"in_reply_to":"fa6399be_c694f1e9","updated":"2016-10-19 12:57:04.000000000","message":"Agreed, we should just be specific I think, that a host that isn\u0027t in an aggregate is the same.\n\nWe don\u0027t want deployers thinking they need to add empty aggregates to make this all work.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eab903c4c77552b6b6780670e5f3173246adc41e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":61,"context_line":"| key\u003dfoo        | True       | False      | **False**  |"},{"line_number":62,"context_line":"+----------------+------------+------------+------------+"},{"line_number":63,"context_line":"| key\u003dbar        | False      | False      | **False**  |"},{"line_number":64,"context_line":"+----------------+------------+------------+------------+"},{"line_number":65,"context_line":"| \u003cempty\u003e        | **False**  | **False**  | True       |"},{"line_number":66,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_3c87e4b5","line":63,"updated":"2016-10-17 12:39:54.000000000","message":"what about key1\u003dfoo,key2\u003dbaz on an aggregate? or key1 and key2 set on separate aggregates? do we even care?\n\nIt feels like each one should work independently, except in isolation mode, you should be able to match any of the aggregates rather than all the aggregates? Maybe?","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"33ca445aa67d520922a177621c22aea831fef444","unresolved":false,"context_lines":[{"line_number":60,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":61,"context_line":"| key\u003dfoo        | True       | False      | **False**  |"},{"line_number":62,"context_line":"+----------------+------------+------------+------------+"},{"line_number":63,"context_line":"| key\u003dbar        | False      | False      | **False**  |"},{"line_number":64,"context_line":"+----------------+------------+------------+------------+"},{"line_number":65,"context_line":"| \u003cempty\u003e        | **False**  | **False**  | True       |"},{"line_number":66,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_6659655b","line":63,"in_reply_to":"fa6399be_3c87e4b5","updated":"2016-10-19 12:01:27.000000000","message":"In isolation mode we accept only images/flavors with the same keys\u003dvalues as in aggregate.\n\nSo if he have an aggregate with key1\u003dval1 and key2\u003dval2, flavor1 with key1\u003dval1, flavor2 with key1\u003dval1 and key\u003dval2, only flavor2 will be accepted (in nonstrict case both are ok).","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f9bbb89b744e2ea74d243a2991ba1520d2f9cf96","unresolved":false,"context_lines":[{"line_number":60,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":61,"context_line":"| key\u003dfoo        | True       | False      | **False**  |"},{"line_number":62,"context_line":"+----------------+------------+------------+------------+"},{"line_number":63,"context_line":"| key\u003dbar        | False      | False      | **False**  |"},{"line_number":64,"context_line":"+----------------+------------+------------+------------+"},{"line_number":65,"context_line":"| \u003cempty\u003e        | **False**  | **False**  | True       |"},{"line_number":66,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_bc30f008","line":63,"in_reply_to":"fa6399be_6659655b","updated":"2016-10-19 12:57:04.000000000","message":"I guess people can just create a new tag for that purpose.\n\nI feel we need to be clear on these details in this spec.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6abcd307f16ebcda4eab2b67310a1915208c116d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":61,"context_line":"| key\u003dfoo        | True       | False      | **False**  |"},{"line_number":62,"context_line":"+----------------+------------+------------+------------+"},{"line_number":63,"context_line":"| key\u003dbar        | False      | False      | **False**  |"},{"line_number":64,"context_line":"+----------------+------------+------------+------------+"},{"line_number":65,"context_line":"| \u003cempty\u003e        | **False**  | **False**  | True       |"},{"line_number":66,"context_line":"+----------------+------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_df2c8fae","line":63,"in_reply_to":"fa6399be_bc30f008","updated":"2016-10-20 09:59:45.000000000","message":"Based on the comments above, folks are not keen on creating new tags and messing about. Lets make it clear what happens with multiple aggregates, and the isolation params.","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eab903c4c77552b6b6780670e5f3173246adc41e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"* A more configurable solution could be to use two config options e.g."},{"line_number":97,"context_line":"  `allow_untagged_images_in_tagged_aggregate\u003dTrue` and"},{"line_number":98,"context_line":"  `allow_tagged_images_in_untagged_aggregate\u003dTrue` but currently we cannot"},{"line_number":99,"context_line":"  find any cases of using this alternative."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Data model impact"},{"line_number":102,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_7cc23c54","line":99,"updated":"2016-10-17 12:39:54.000000000","message":"What about my suggestion above?","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"33ca445aa67d520922a177621c22aea831fef444","unresolved":false,"context_lines":[{"line_number":96,"context_line":"* A more configurable solution could be to use two config options e.g."},{"line_number":97,"context_line":"  `allow_untagged_images_in_tagged_aggregate\u003dTrue` and"},{"line_number":98,"context_line":"  `allow_tagged_images_in_untagged_aggregate\u003dTrue` but currently we cannot"},{"line_number":99,"context_line":"  find any cases of using this alternative."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Data model impact"},{"line_number":102,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_a12fe786","line":99,"in_reply_to":"fa6399be_7cc23c54","updated":"2016-10-19 12:01:27.000000000","message":"could you please clarify your suggestion in more details","commit_id":"c8d7b499151d8de199bea7af67b6d3d07f380bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fe9150d2c87ad4a0bb7997368d8c2400c2f21619","unresolved":false,"context_lines":[{"line_number":74,"context_line":"New per-aggregate metadata support will be implemented on Nova objects level."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":77,"context_line":"| props \\\\ aggr | k1\u003dv1      | k1\u003dv2      | k1\u003dv1,k2\u003dv2   | \u003cempty\u003e    |"},{"line_number":78,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":79,"context_line":"| k1\u003dv1         | True       | False      | **False**     | **False**  |"},{"line_number":80,"context_line":"+---------------+------------+------------+---------------+------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_8b89da28","line":77,"range":{"start_line":77,"start_character":61,"end_line":77,"end_character":66},"updated":"2016-11-02 11:10:20.000000000","message":"Is this really *_strict_isoloation\u003dTrue on the aggregate?\n\nIf so, you could also have empty where we still allow things to be built, which may not be obvious here.","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"8140c629c4c295fa1cdd4f93b40deae1cddaa787","unresolved":false,"context_lines":[{"line_number":74,"context_line":"New per-aggregate metadata support will be implemented on Nova objects level."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":77,"context_line":"| props \\\\ aggr | k1\u003dv1      | k1\u003dv2      | k1\u003dv1,k2\u003dv2   | \u003cempty\u003e    |"},{"line_number":78,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":79,"context_line":"| k1\u003dv1         | True       | False      | **False**     | **False**  |"},{"line_number":80,"context_line":"+---------------+------------+------------+---------------+------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_9abbdee4","line":77,"range":{"start_line":77,"start_character":61,"end_line":77,"end_character":66},"in_reply_to":"ba5da102_8b89da28","updated":"2016-11-02 12:57:42.000000000","message":"I understand, actually aggregate metadata keys \u0027image_strict_isolation\u0027 and \u0027flavor_strict_isolation\u0027 are not considered here. So they can be presented in aggregate, but they really meant only strict or non-strict mode for aggregate","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"15735ab98126cfd42d838a473a5e7e4581f148d7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"New per-aggregate metadata support will be implemented on Nova objects level."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":77,"context_line":"| props \\\\ aggr | k1\u003dv1      | k1\u003dv2      | k1\u003dv1,k2\u003dv2   | \u003cempty\u003e    |"},{"line_number":78,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":79,"context_line":"| k1\u003dv1         | True       | False      | **False**     | **False**  |"},{"line_number":80,"context_line":"+---------------+------------+------------+---------------+------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_35402334","line":77,"range":{"start_line":77,"start_character":61,"end_line":77,"end_character":66},"in_reply_to":"ba5da102_9abbdee4","updated":"2016-11-02 13:11:53.000000000","message":"added paragraph about it after the table","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fe9150d2c87ad4a0bb7997368d8c2400c2f21619","unresolved":false,"context_lines":[{"line_number":76,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":77,"context_line":"| props \\\\ aggr | k1\u003dv1      | k1\u003dv2      | k1\u003dv1,k2\u003dv2   | \u003cempty\u003e    |"},{"line_number":78,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":79,"context_line":"| k1\u003dv1         | True       | False      | **False**     | **False**  |"},{"line_number":80,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":81,"context_line":"| k1\u003dv2         | False      | True       | False         | **False**  |"},{"line_number":82,"context_line":"+---------------+------------+------------+---------------+------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_2bf7ee8b","line":79,"range":{"start_line":79,"start_character":60,"end_line":79,"end_character":69},"updated":"2016-11-02 11:10:20.000000000","message":"This might need more definition. How do we define the k1, k2 list? Is that all keys that have the configured prefix and separator are for any aggregate in the system?","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fe9150d2c87ad4a0bb7997368d8c2400c2f21619","unresolved":false,"context_lines":[{"line_number":82,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":83,"context_line":"| k1\u003dv1,k2\u003dv2   | False      | False      | True          | **False**  |"},{"line_number":84,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":85,"context_line":"| \u003cempty\u003e       | **False**  | **False**  | **False**     | True       |"},{"line_number":86,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"*Table 2: rows are image/flavor properties, columns are aggregate metadata*"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_aba77ebb","line":85,"range":{"start_line":85,"start_character":18,"end_line":85,"end_character":53},"updated":"2016-11-02 11:10:20.000000000","message":"These are very clearly related to the aggregate metadata, thats all good. I am happy with the first four columns here.","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1caf7e21b93d49f88f4392fca0a7f0799425f560","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* An alternative solution would be to create new filters that inherits from"},{"line_number":113,"context_line":"  `AggregateImagePropertiesIsolation` and `AggregateInstanceExtraSpecsFilter`"},{"line_number":114,"context_line":"  filters."},{"line_number":115,"context_line":"* New per-aggregate metadata support can also be implemented by extending"},{"line_number":116,"context_line":"  Nova API related to aggregates and adding two new columns to DB"},{"line_number":117,"context_line":"  (image_strict_isolation and flavor_strict_isolation) by new DB migration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_432470ae","line":114,"updated":"2016-10-28 13:07:30.000000000","message":"please no. We already have a long list of filters, adding another one doing the nearly same behaviour than another one confuses a lot of operators.","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"144a66ac220a7a9686ca152889a5c526a4819f21","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* An alternative solution would be to create new filters that inherits from"},{"line_number":113,"context_line":"  `AggregateImagePropertiesIsolation` and `AggregateInstanceExtraSpecsFilter`"},{"line_number":114,"context_line":"  filters."},{"line_number":115,"context_line":"* New per-aggregate metadata support can also be implemented by extending"},{"line_number":116,"context_line":"  Nova API related to aggregates and adding two new columns to DB"},{"line_number":117,"context_line":"  (image_strict_isolation and flavor_strict_isolation) by new DB migration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_6fe875e3","line":114,"in_reply_to":"ba5da102_432470ae","updated":"2016-10-28 16:01:31.000000000","message":"agree, it seems to be a bad idea","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1caf7e21b93d49f88f4392fca0a7f0799425f560","unresolved":false,"context_lines":[{"line_number":115,"context_line":"* New per-aggregate metadata support can also be implemented by extending"},{"line_number":116,"context_line":"  Nova API related to aggregates and adding two new columns to DB"},{"line_number":117,"context_line":"  (image_strict_isolation and flavor_strict_isolation) by new DB migration"},{"line_number":118,"context_line":"  but this approach is unreasonably difficult."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Data model impact"},{"line_number":121,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_0351980e","line":118,"updated":"2016-10-28 13:07:30.000000000","message":"that looks overkill.","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"144a66ac220a7a9686ca152889a5c526a4819f21","unresolved":false,"context_lines":[{"line_number":115,"context_line":"* New per-aggregate metadata support can also be implemented by extending"},{"line_number":116,"context_line":"  Nova API related to aggregates and adding two new columns to DB"},{"line_number":117,"context_line":"  (image_strict_isolation and flavor_strict_isolation) by new DB migration"},{"line_number":118,"context_line":"  but this approach is unreasonably difficult."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Data model impact"},{"line_number":121,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_efbac5e0","line":118,"in_reply_to":"ba5da102_0351980e","updated":"2016-10-28 16:01:31.000000000","message":"fully agree that it is too complex for this change","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fe9150d2c87ad4a0bb7997368d8c2400c2f21619","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"::"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  aggregate_image_filter_strict_isolation\u003dTrue"},{"line_number":159,"context_line":"  aggregate_extra_specs_filter_strict_isolation\u003dTrue"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"*If an option is not set for an aggregate it is considered False.*"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5da102_eb6fb6f9","line":158,"range":{"start_line":158,"start_character":2,"end_line":158,"end_character":11},"updated":"2016-11-02 11:10:20.000000000","message":"Nit: How does this relate to the config options that define the prefix, etc. Would be good just to note this key is independent of those configs.","commit_id":"0869039e5e95e9986a997107457af9ec7edf5cff"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f900892530fab278cd7e59a6421e555ed0dc6383","unresolved":false,"context_lines":[{"line_number":76,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":77,"context_line":"| props \\\\ aggr | k1\u003dv1      | k1\u003dv2      | k1\u003dv1,k2\u003dv2   | \u003cempty\u003e    |"},{"line_number":78,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":79,"context_line":"| k1\u003dv1         | True       | False      | **False**     | **False**  |"},{"line_number":80,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":81,"context_line":"| k1\u003dv2         | False      | True       | False         | **False**  |"},{"line_number":82,"context_line":"+---------------+------------+------------+---------------+------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_cd44964b","line":79,"range":{"start_line":79,"start_character":60,"end_line":79,"end_character":69},"updated":"2016-11-11 10:30:21.000000000","message":"So if image_strict_isolation\u003dTrue, and the admin/deployer has put that there, you get False.\n\nIf the host is not in an aggregate, or the aggregate doesn\u0027t have image_strict_isolation set, or has image_strict_isolation\u003dFalse, then this value is True.\n\nI think we could make that clearer, if only so admins know how to correctly use this filter.","commit_id":"525778123bc4cae0ada55ec44c618363a9f1374f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f900892530fab278cd7e59a6421e555ed0dc6383","unresolved":false,"context_lines":[{"line_number":78,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":79,"context_line":"| k1\u003dv1         | True       | False      | **False**     | **False**  |"},{"line_number":80,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":81,"context_line":"| k1\u003dv2         | False      | True       | False         | **False**  |"},{"line_number":82,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":83,"context_line":"| k1\u003dv1,k2\u003dv2   | False      | False      | True          | **False**  |"},{"line_number":84,"context_line":"+---------------+------------+------------+---------------+------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_ad7042a5","line":81,"range":{"start_line":81,"start_character":60,"end_line":81,"end_character":69},"updated":"2016-11-11 10:30:21.000000000","message":"Maybe we should be clear, we fail any build that has a key that matches the known prefix and separator. I think that defaults to \"hw:\", if my memory is correct, which is probably a bit unfortunate, but I guess its OK.","commit_id":"525778123bc4cae0ada55ec44c618363a9f1374f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"37a38437bf4ddfc1abbabebe1f47544b423306cd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Lets see how the matrix now looks:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":102,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":103,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":104,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":105,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_63663b52","line":102,"range":{"start_line":102,"start_character":69,"end_line":102,"end_character":71},"updated":"2016-11-11 11:54:38.000000000","message":"So I do wonder if we need a configuration variable so we can turn this column so that it matches the \u003cempty\u003e column?","commit_id":"b593e086831037db63e976e0266eac580be61540"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5679b0911d7a87eae9592ba6ec0769c6fbe3879d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Lets see how the matrix now looks:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":102,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":103,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":104,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":105,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_1ee2322f","line":102,"range":{"start_line":102,"start_character":69,"end_line":102,"end_character":71},"in_reply_to":"9a629dbe_63663b52","updated":"2016-11-11 12:10:57.000000000","message":"Just for context, I get you can just add all your hosts into an aggregate with isolation\u003dTrue, its just that seems error prone as you add capacity, and you end up with things building on odd hosts until you add them into the correct aggregate.\n\nMaybe I am overthinking this though?","commit_id":"b593e086831037db63e976e0266eac580be61540"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"dbaf6ee01b54ed12646b53288497f771ac27aded","unresolved":false,"context_lines":[{"line_number":122,"context_line":"* \"\u003cno\u003e\" column represents hosts that are not in any aggregate, or in an"},{"line_number":123,"context_line":"  aggregate that either has image_strict_isolation\u003dFalse or"},{"line_number":124,"context_line":"  flavor_strict_isolation\u003dFalse or don\u0027t have either set."},{"line_number":125,"context_line":"* \"\u003cempty\u003e\" column above means the either image_strict_isolation\u003dTrue or"},{"line_number":126,"context_line":"  flavor_strict_isolation\u003dTrue is set on the aggregate."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Alternatives"},{"line_number":129,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a629dbe_99701ca6","line":126,"range":{"start_line":125,"start_character":3,"end_line":126,"end_character":55},"updated":"2016-11-11 12:38:50.000000000","message":"nit: I\u0027d explicitly highlight that there is no meaningful metadata other than image_strict_isolation or flavor_strict_isolation is specified.","commit_id":"1664d64827409500aae4a02249d84e3734dd547c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"018cbfa75b91dee07a4cfdf053eb87e19d62f0b1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"   the corresponding filter functions as proposed decision (see Table 2)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"*Each aggregate can have any of these metadata options. For backward"},{"line_number":91,"context_line":"compatibility if an option is not set for an aggregate it is considered False.*"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"*Note that aggregate metadata keys `image_strict_isolation` and"},{"line_number":94,"context_line":"`flavor_strict_isolation` are not considered as real metadata keys and values."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_ed782d2e","line":91,"updated":"2016-11-14 16:24:22.000000000","message":"thanks for clarifying that.","commit_id":"09fe6fc996420d4c96b0a70f09bfa9f3f90ee7cb"},{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"a2345bdb78ead07897fa118c5bbeb6907d2eef40","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"*Note that aggregate metadata keys `image_strict_isolation` and"},{"line_number":94,"context_line":"`flavor_strict_isolation` are not considered as real metadata keys and values."},{"line_number":95,"context_line":"They mean only level of the isolation and do not affect on matching.*"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Note that these metadata keys are independent and can be used separately.**"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_d2a94126","line":95,"updated":"2016-11-14 17:55:11.000000000","message":"This is a bit awkward to parse, as somebody not intimately familiar with the nova codebase.","commit_id":"09fe6fc996420d4c96b0a70f09bfa9f3f90ee7cb"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"98f84438ba995a1da77feeb5f0b5e435e31b93e8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":102,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":103,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":104,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":105,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":106,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":107,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_6f81bafa","line":104,"range":{"start_line":104,"start_character":42,"end_line":104,"end_character":51},"updated":"2016-11-11 13:48:54.000000000","message":"I was going to suggest relaxing the requirement a bit to allow image/flavor metadata keys be a subset of aggregate keys, but then figured out that it\u0027s no different from the \"empty\" case on the right, as an empty set would also be a subset of some aggregate keys.\n\nThis looks good! Let\u0027s make sure we document this to set correct expectation for operators.","commit_id":"09fe6fc996420d4c96b0a70f09bfa9f3f90ee7cb"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"68286db073355fe8df7d9ecd223ac18a7d5d14d6","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"::"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  aggregate_image_filter_strict_isolation\u003dTrue"},{"line_number":189,"context_line":"  aggregate_extra_specs_filter_strict_isolation\u003dTrue"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"*If an option is not set for an aggregate it is considered False.*"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a77a97e_59d011f8","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":52},"updated":"2016-11-21 15:30:14.000000000","message":"These are old names, should be image_strict_isolation\u003dTrue` and`flavor_strict_isolation\u003dTrue\u0027.\n\nLet\u0027s change it just before merging or in a separate patch after (if we will find some other things to fix or add)","commit_id":"09fe6fc996420d4c96b0a70f09bfa9f3f90ee7cb"}],"specs/pike/approved/strict_isolation_of_group_of_hosts_for_image_and_flavor.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"da6d67ac3318f706883ec0522f1d55bb75b268d4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"and a new set of flavors. He/She doesn\u0027t want any of the non-SSD flavors"},{"line_number":62,"context_line":"getting on the new hardware, but he/she doesn\u0027t really want to modify old"},{"line_number":63,"context_line":"flavors either (modifying existing flavors and aggregates can lead issues with"},{"line_number":64,"context_line":"things like rebuild or evacuate, when stored flavor is used to choose a host)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Proposed change"},{"line_number":67,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dfeb2761_b614874f","line":64,"updated":"2017-04-04 11:27:41.000000000","message":"We spoke about this at the PTG:\nhttps://etherpad.openstack.org/p/nova-ptg-pike\n\nPlease reach out to Sean Mooney and Chris Friesen\u0027s to see if it meets their use cases, and if not why not.\n\nFirst, please the full set of use cases for this thing (John wants to see the use cases the spec doesn\u0027t deal with, or that require new aggregates or flavor modifications to implement).","commit_id":"1edffa09d78760813892abdc37372a9a84742dd8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2f9ac2c83f1a19810ae1a625f7f4f6e8423d23a9","unresolved":false,"context_lines":[{"line_number":101,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":102,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":103,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":104,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":105,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":106,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":107,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dfeb2761_97ce1cb2","line":104,"range":{"start_line":104,"start_character":56,"end_line":104,"end_character":65},"updated":"2017-04-04 12:42:45.000000000","message":"well, that supposes that you have at least 2 aggregates and one having image_strict_isolation\u003dTrue for the same node. If those two aggregates are not defining a strict isolation for both of them, why should we fail if the image props or flavor extra specs are defined ?\n\nFor that reason, I\u0027m not super happy with this kind of policy for filters be set per-aggregate. I\u0027m not super happy with using config opts too, that said but meh.","commit_id":"1edffa09d78760813892abdc37372a9a84742dd8"}],"specs/queens/approved/strict_isolation_of_group_of_hosts_for_image_and_flavor.rst":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bd82dc83530d956394239d7e2342ac5246d6ed80","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The aim of this blueprint is to improve `AggregateImagePropertiesIsolation`"},{"line_number":14,"context_line":"and `AggregateInstanceExtraSpecsFilter` scheduler filters."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"An operator wants to schedule instances for a specific image/flavor on a"},{"line_number":17,"context_line":"pre-defined group of hosts. In addition, the operator would also like to"},{"line_number":18,"context_line":"prevent images/flavors without keys from being placed on this group of hosts."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_2f12e963","line":16,"range":{"start_line":16,"start_character":55,"end_line":16,"end_character":67},"updated":"2017-10-03 16:45:54.000000000","message":"should probably be something like \"...instances having a specific image property/flavor extra-spec key/value...\"","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ad10d88e8db67643e4f6351ad011b9165f17325","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The aim of this blueprint is to improve `AggregateImagePropertiesIsolation`"},{"line_number":14,"context_line":"and `AggregateInstanceExtraSpecsFilter` scheduler filters."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"An operator wants to schedule instances for a specific image/flavor on a"},{"line_number":17,"context_line":"pre-defined group of hosts. In addition, the operator would also like to"},{"line_number":18,"context_line":"prevent images/flavors without keys from being placed on this group of hosts."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_3eaa08d2","line":16,"range":{"start_line":16,"start_character":55,"end_line":16,"end_character":67},"in_reply_to":"7f515b1d_2f12e963","updated":"2017-10-04 09:16:14.000000000","message":"will change in new PS","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bd82dc83530d956394239d7e2342ac5246d6ed80","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"An operator wants to schedule instances for a specific image/flavor on a"},{"line_number":17,"context_line":"pre-defined group of hosts. In addition, the operator would also like to"},{"line_number":18,"context_line":"prevent images/flavors without keys from being placed on this group of hosts."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_8f02fd0a","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":46},"updated":"2017-10-03 16:45:54.000000000","message":"would be clearer as \"...instances without the special image property or flavor extra-spec from being...\"","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ad10d88e8db67643e4f6351ad011b9165f17325","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"An operator wants to schedule instances for a specific image/flavor on a"},{"line_number":17,"context_line":"pre-defined group of hosts. In addition, the operator would also like to"},{"line_number":18,"context_line":"prevent images/flavors without keys from being placed on this group of hosts."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_1eb74c3d","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":46},"in_reply_to":"7f515b1d_8f02fd0a","updated":"2017-10-04 09:16:14.000000000","message":"will change in new PS","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"a86603cd3b8f5ab234d5c11b6728cb3c08d19b1d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"| \u003cempty\u003e       | True       | True       | True          | True       |"},{"line_number":37,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"*Table 1: rows are image/flavor properties, columns are aggregate metadata.*"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The problem is:"},{"line_number":42,"context_line":" * An image/flavor without key can still be scheduled in a tagged aggregate"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_b303c673","line":39,"range":{"start_line":39,"start_character":11,"end_line":39,"end_character":41},"updated":"2017-10-04 15:48:42.000000000","message":"Note: the behaviour is different between AggregateImagePropertiesIsolation and AggregateInstanceExtraSpecsFilter so this table isn\u0027t accurate for filter extra-specs.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bd82dc83530d956394239d7e2342ac5246d6ed80","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The problem is:"},{"line_number":42,"context_line":" * An image/flavor without key can still be scheduled in a tagged aggregate"},{"line_number":43,"context_line":" * The hosts outside aggregates or in a no-tagged aggregate can still accept a"},{"line_number":44,"context_line":"   tagged image/flavor"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_5a02850b","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":22},"updated":"2017-10-03 16:45:54.000000000","message":"I think this is incorrect.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d8370566c6844d4b87ddefe3833a16b5c6564d74","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The problem is:"},{"line_number":42,"context_line":" * An image/flavor without key can still be scheduled in a tagged aggregate"},{"line_number":43,"context_line":" * The hosts outside aggregates or in a no-tagged aggregate can still accept a"},{"line_number":44,"context_line":"   tagged image/flavor"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_d981c3c5","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":22},"in_reply_to":"7f515b1d_53e372a5","updated":"2017-10-04 16:48:01.000000000","message":"If there are behavioural discrepancies between those two filters, I\u0027d wonder if it would be better to just provide a new filter doing both image/flavor checks, would read the exact same values but would have distinct behaviour so that would deprecate the old filters.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ad10d88e8db67643e4f6351ad011b9165f17325","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The problem is:"},{"line_number":42,"context_line":" * An image/flavor without key can still be scheduled in a tagged aggregate"},{"line_number":43,"context_line":" * The hosts outside aggregates or in a no-tagged aggregate can still accept a"},{"line_number":44,"context_line":"   tagged image/flavor"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_a3fdc209","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":22},"in_reply_to":"7f515b1d_5a02850b","updated":"2017-10-04 09:16:14.000000000","message":"There are two parts covered here;\n\n1. The hosts outside of aggregates\n2. host in a no-tagged aggregate\n\nPart 1 is host is not part of aggregate group which means it can able to launch any of the instance in spite of image properties or flavor extra-specs.\n\nPart 2 is host is in aggregate which does not match with image property or flavor extra-spec. For example host aggregate metadata is os:rhel and image has a property of os:windows. In this case it\u0027s a problem because aggregate_image_properties_isolation filter will return True in this case (refer, https://github.com/openstack/nova/blob/master/nova/scheduler/filters/aggregate_image_properties_isolation.py#L47)\n\nI will upload a new specs soon to remove part 1 and only mention about no-tagged aggregate case.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"581bb04ae6ffa90e0101fd580c6be2d800943de3","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The problem is:"},{"line_number":42,"context_line":" * An image/flavor without key can still be scheduled in a tagged aggregate"},{"line_number":43,"context_line":" * The hosts outside aggregates or in a no-tagged aggregate can still accept a"},{"line_number":44,"context_line":"   tagged image/flavor"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_d3b402f5","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":22},"in_reply_to":"7f515b1d_a3fdc209","updated":"2017-10-04 15:36:53.000000000","message":"As I described in a separeate comment, the AggregateImagePropertiesIsolation and AggregateInstanceExtraSpecsFilter are actually doing two different things, so the behaviour is different depending on whether you set an image property or a flavor extra-spec.\n\nAggregateInstanceExtraSpecsFilter will ensure that if you ask for something in the flavor then the host is part of a host aggregate that provides that thing.  This means it will *not* allow it to schedule on hosts that are outside of aggregates or are in a no-tagged aggregate.\n\nAggregateImagePropertiesIsolation will ensure that if you specify something in a host aggregate then only instances with images that also specify that thing will be allowed to run in that host aggregate. This is actually very similar to the strict isolation that is being talked about, but is backwards to how you were thinking about it.  (The criteria are on the aggregate, and the filter checks that the image meets the criteria.)","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"a86603cd3b8f5ab234d5c11b6728cb3c08d19b1d","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The problem is:"},{"line_number":42,"context_line":" * An image/flavor without key can still be scheduled in a tagged aggregate"},{"line_number":43,"context_line":" * The hosts outside aggregates or in a no-tagged aggregate can still accept a"},{"line_number":44,"context_line":"   tagged image/flavor"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_53e372a5","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":22},"in_reply_to":"7f515b1d_d3b402f5","updated":"2017-10-04 15:48:42.000000000","message":"After reading AggregateImagePropertiesIsolation I realized I was mistaken.  If the host aggregate specifies a key that isn\u0027t present in the image properties it\u0027ll log a warning but still allow the match.  My bad for not reading closely enough the first time.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bd82dc83530d956394239d7e2342ac5246d6ed80","unresolved":false,"context_lines":[{"line_number":70,"context_line":"os\u003dother"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"For example:"},{"line_number":73,"context_line":"image 1 metadata: {\"os\": \"windows\"} (added by operator)"},{"line_number":74,"context_line":"image 2 metadata: {\"os\": \"rhel\"} (added by operator)"},{"line_number":75,"context_line":"image 3 metadata: {\"os\": \"others\"} (added by operator)"},{"line_number":76,"context_line":"image 4 metadata: {} (added by normal user)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Host aggregate 1 metadata: {\"os\": \"windows\"}"},{"line_number":79,"context_line":"Host aggregate 2 metadata: {\"os\": \"rhel\"}"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_1a73edb3","line":76,"range":{"start_line":73,"start_character":0,"end_line":76,"end_character":43},"updated":"2017-10-03 16:45:54.000000000","message":"we normally talk about image \"properties\", not metadata.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ad10d88e8db67643e4f6351ad011b9165f17325","unresolved":false,"context_lines":[{"line_number":70,"context_line":"os\u003dother"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"For example:"},{"line_number":73,"context_line":"image 1 metadata: {\"os\": \"windows\"} (added by operator)"},{"line_number":74,"context_line":"image 2 metadata: {\"os\": \"rhel\"} (added by operator)"},{"line_number":75,"context_line":"image 3 metadata: {\"os\": \"others\"} (added by operator)"},{"line_number":76,"context_line":"image 4 metadata: {} (added by normal user)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Host aggregate 1 metadata: {\"os\": \"windows\"}"},{"line_number":79,"context_line":"Host aggregate 2 metadata: {\"os\": \"rhel\"}"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_9e7c5c73","line":76,"range":{"start_line":73,"start_character":0,"end_line":76,"end_character":43},"in_reply_to":"7f515b1d_1a73edb3","updated":"2017-10-04 09:16:14.000000000","message":"will change in new PS","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bd82dc83530d956394239d7e2342ac5246d6ed80","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"New per-aggregate metadata support will be implemented on Nova objects level."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"We propose to support two aggregate metadata options:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* `image_strict_isolation` aggregate metadata key for"},{"line_number":105,"context_line":"  `AggregateImagePropertiesIsolation` filter"},{"line_number":106,"context_line":"* `flavor_strict_isolation` aggregate metadata key for"},{"line_number":107,"context_line":"  `AggregateInstanceExtraSpecsFilter` filter"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Which dictate strictness level of the isolation:"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_b5b62a3e","line":107,"range":{"start_line":102,"start_character":0,"end_line":107,"end_character":44},"updated":"2017-10-03 16:45:54.000000000","message":"I think it would make more sense to specify per aggregate metadata key whether or not flavors/images that don\u0027t match are excluded.\n\nUsing your example above you might specify the aggregate metadata as {\"os\": \"windows\"} currently, and for a strict match you could specify it as something like {\"strict:os\": \"windows\"}.  We could optionally make the strict prefix a config option the way that aggregate_image_properties_isolation_namespace is today.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"48c6389604df6092e45e28edbb677bfbf99d2186","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"New per-aggregate metadata support will be implemented on Nova objects level."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"We propose to support two aggregate metadata options:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* `image_strict_isolation` aggregate metadata key for"},{"line_number":105,"context_line":"  `AggregateImagePropertiesIsolation` filter"},{"line_number":106,"context_line":"* `flavor_strict_isolation` aggregate metadata key for"},{"line_number":107,"context_line":"  `AggregateInstanceExtraSpecsFilter` filter"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Which dictate strictness level of the isolation:"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_d9cf8327","line":107,"range":{"start_line":102,"start_character":0,"end_line":107,"end_character":44},"in_reply_to":"7f515b1d_590153af","updated":"2017-10-04 17:04:29.000000000","message":"That\u0027s a good point.\n\nGiven the fact that the two filters currently behave differently, it might make sense to introduce a new filter that would first combine the aggregate-matching info from image properties and flavor extra-specs and then match the combined info against the aggregate metadata in a unified way, with a single new aggregate metadata key to specify strict bidirectional matching.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ad10d88e8db67643e4f6351ad011b9165f17325","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"New per-aggregate metadata support will be implemented on Nova objects level."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"We propose to support two aggregate metadata options:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* `image_strict_isolation` aggregate metadata key for"},{"line_number":105,"context_line":"  `AggregateImagePropertiesIsolation` filter"},{"line_number":106,"context_line":"* `flavor_strict_isolation` aggregate metadata key for"},{"line_number":107,"context_line":"  `AggregateInstanceExtraSpecsFilter` filter"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Which dictate strictness level of the isolation:"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_c9021f0c","line":107,"range":{"start_line":102,"start_character":0,"end_line":107,"end_character":44},"in_reply_to":"7f515b1d_b5b62a3e","updated":"2017-10-04 09:16:14.000000000","message":"The use case mentioned between line 66:90 is just a use case, as per current implementation if image_strict_isolation is set to true then the property which will be added to image will be prefixed with \u0027aggregate_image_properties_isolation_namespace\u0027","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b3b75a4e9ada310dc4bbaaf5cb1002ed5a72309b","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"New per-aggregate metadata support will be implemented on Nova objects level."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"We propose to support two aggregate metadata options:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* `image_strict_isolation` aggregate metadata key for"},{"line_number":105,"context_line":"  `AggregateImagePropertiesIsolation` filter"},{"line_number":106,"context_line":"* `flavor_strict_isolation` aggregate metadata key for"},{"line_number":107,"context_line":"  `AggregateInstanceExtraSpecsFilter` filter"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Which dictate strictness level of the isolation:"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_590153af","line":107,"range":{"start_line":102,"start_character":0,"end_line":107,"end_character":44},"in_reply_to":"7f515b1d_c9021f0c","updated":"2017-10-04 16:39:01.000000000","message":"I don\u0027t like the idea of namespacing the aggregate metadata keys in order to have strict policy per key. \nLike I said in IRC, if you need a strict policy per key, just set two aggregates containing the same host, one with metadata containing the keys you want to be strict on and just add the specific image/flavor_strict_isolation key into it, and for the keys you don\u0027t want a strict policy, just provide them in the second aggregate.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"48c6389604df6092e45e28edbb677bfbf99d2186","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Which dictate strictness level of the isolation:"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":" * `image_strict_isolation\u003dFalse` or `flavor_strict_isolation\u003dFalse`:"},{"line_number":112,"context_line":"   the corresponding filter functions as before (see Table 1)"},{"line_number":113,"context_line":" * `image_strict_isolation\u003dTrue` or `flavor_strict_isolation\u003dTrue`:"},{"line_number":114,"context_line":"   the corresponding filter functions as proposed decision (see Table 2)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"*Each aggregate can have any of these metadata options. For backward"},{"line_number":117,"context_line":"compatibility if an option is not set for an aggregate it is considered False.*"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_f998ff1b","line":114,"range":{"start_line":111,"start_character":0,"end_line":114,"end_character":72},"updated":"2017-10-04 17:04:29.000000000","message":"Do you have a scenario where it would make sense to be strict about one and not the other?  It seems like this could lead to unexpected behaviour if the end-user specifies something in a flavor vs an image.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bd82dc83530d956394239d7e2342ac5246d6ed80","unresolved":false,"context_lines":[{"line_number":127,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":128,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":129,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":130,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":131,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":132,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":133,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_35f11a03","line":130,"range":{"start_line":130,"start_character":68,"end_line":130,"end_character":72},"updated":"2017-10-03 16:45:54.000000000","message":"I think this should be \"false\"","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ad10d88e8db67643e4f6351ad011b9165f17325","unresolved":false,"context_lines":[{"line_number":127,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":128,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":129,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":130,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":131,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":132,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":133,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_3b20dab0","line":130,"range":{"start_line":130,"start_character":68,"end_line":130,"end_character":72},"in_reply_to":"7f515b1d_35f11a03","updated":"2017-10-04 09:16:14.000000000","message":"This is for maintaining backward compatibility, if image_strict_isolation or flavor_strict_isolation are set to False then it should behave the way it is behaving now. Please refer line #116.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"48c6389604df6092e45e28edbb677bfbf99d2186","unresolved":false,"context_lines":[{"line_number":127,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":128,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":129,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":130,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":131,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":132,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":133,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_047a4e87","line":130,"range":{"start_line":130,"start_character":68,"end_line":130,"end_character":72},"in_reply_to":"7f515b1d_3b20dab0","updated":"2017-10-04 17:04:29.000000000","message":"It seems odd to me that you can specify something like \"os\u003dwindows\" in an image, but end up on an aggregate where \"os\u003dwindows\" is *not* set.\n\nIt might make more sense to specify \"image_strict_matching\", which would ensure bidirectional matching...that is, the aggregate metadata must contain the key from the image property, and the image property must contain the key from the aggregate.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bd82dc83530d956394239d7e2342ac5246d6ed80","unresolved":false,"context_lines":[{"line_number":129,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":130,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":131,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":132,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":133,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":134,"context_line":"| k1\u003dv1,k2\u003dv2   | False     | False     | True        | **False** | True |"},{"line_number":135,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_15f61efb","line":132,"range":{"start_line":132,"start_character":68,"end_line":132,"end_character":72},"updated":"2017-10-03 16:45:54.000000000","message":"I think think should be \"false\"","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ad10d88e8db67643e4f6351ad011b9165f17325","unresolved":false,"context_lines":[{"line_number":129,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":130,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":131,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":132,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":133,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":134,"context_line":"| k1\u003dv1,k2\u003dv2   | False     | False     | True        | **False** | True |"},{"line_number":135,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_fb29229b","line":132,"range":{"start_line":132,"start_character":68,"end_line":132,"end_character":72},"in_reply_to":"7f515b1d_15f61efb","updated":"2017-10-04 09:16:14.000000000","message":"ditto","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bd82dc83530d956394239d7e2342ac5246d6ed80","unresolved":false,"context_lines":[{"line_number":131,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":132,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":133,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":134,"context_line":"| k1\u003dv1,k2\u003dv2   | False     | False     | True        | **False** | True |"},{"line_number":135,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":136,"context_line":"| \u003cempty\u003e       | **False** | **False** | **False**   | True      | True |"},{"line_number":137,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_f5da6277","line":134,"range":{"start_line":134,"start_character":68,"end_line":134,"end_character":72},"updated":"2017-10-03 16:45:54.000000000","message":"I think this should be \"false\"","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ad10d88e8db67643e4f6351ad011b9165f17325","unresolved":false,"context_lines":[{"line_number":131,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":132,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":133,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":134,"context_line":"| k1\u003dv1,k2\u003dv2   | False     | False     | True        | **False** | True |"},{"line_number":135,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":136,"context_line":"| \u003cempty\u003e       | **False** | **False** | **False**   | True      | True |"},{"line_number":137,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_5b0cb641","line":134,"range":{"start_line":134,"start_character":68,"end_line":134,"end_character":72},"in_reply_to":"7f515b1d_f5da6277","updated":"2017-10-04 09:16:14.000000000","message":"ditto","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"48c6389604df6092e45e28edbb677bfbf99d2186","unresolved":false,"context_lines":[{"line_number":136,"context_line":"| \u003cempty\u003e       | **False** | **False** | **False**   | True      | True |"},{"line_number":137,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"*Table 2: rows are image/flavor properties, columns are aggregate metadata*"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Please note:"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_995eab43","line":139,"range":{"start_line":139,"start_character":10,"end_line":139,"end_character":42},"updated":"2017-10-04 17:04:29.000000000","message":"This table is only accurate for image properties, not flavor extra-specs.","commit_id":"9579ba7104d54b8c8858c21553bde3ffba64ad39"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"80c3761fba865409e8ea45641e147230dac7b03c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"NOTE:"},{"line_number":56,"context_line":"As flavors and host aggregates are created and managed by operator, he/she"},{"line_number":57,"context_line":"can control scheduling of specific instances having a specific flavor on a"},{"line_number":58,"context_line":"pre-defined group of hosts using request traits implemented in the spec [1]."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Use Cases"},{"line_number":61,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa0c359_d4053515","line":58,"updated":"2018-02-14 00:44:03.000000000","message":"Do the traits allow you to get the isolation effect with flavor extra-specs?  (i.e., only instances booting flavors with a particular extra spec key/value are allowed on a given host aggregate.)\n\nIf they don\u0027t I think Sylvain\u0027s suggestion of a new filter to unify the image/flavor checks and also provide isolation might be useful.\n\nYou could merge the flavor extra-specs and image properties to get the effective instance properties, and then compare that against the aggregate metadata.","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"567251576ab547c0b6aad9ac3aaa279483015017","unresolved":false,"context_lines":[{"line_number":55,"context_line":"NOTE:"},{"line_number":56,"context_line":"As flavors and host aggregates are created and managed by operator, he/she"},{"line_number":57,"context_line":"can control scheduling of specific instances having a specific flavor on a"},{"line_number":58,"context_line":"pre-defined group of hosts using request traits implemented in the spec [1]."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Use Cases"},{"line_number":61,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa0c359_b9457d72","line":58,"in_reply_to":"3fa0c359_d4053515","updated":"2018-02-20 09:35:43.000000000","message":"Specs [1] is implemented to assign traits to resource providers and Specs [2] to pass required traits using flavor to placement service to return allocation candidates.\nSo operator will be in full control to add required traits to flavors and resource providers. Hence, we have excluded strict isolation for flavor extra-specs.\n\nIn fact, we can deprecate existing “AggregateInstanceExtraSpecsFilter” filter or simply don’t enable it.\n\n[1] https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/resource-provider-traits.html\n[2] https://review.openstack.org/#/c/468797/9/specs/queens/approved/request-traits-in-nova.rst","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"80c3761fba865409e8ea45641e147230dac7b03c","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Now when user boots an instance using image 4, then it should be matched with"},{"line_number":87,"context_line":"host aggregate with empty metadata only. In this example, it should choose"},{"line_number":88,"context_line":"\"Host aggregate 4\" to boot instance."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa0c359_1a10a74d","line":88,"updated":"2018-02-14 00:44:03.000000000","message":"By \"should\", are you talking the current behaviour or some theoretical ideal behaviour?","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"567251576ab547c0b6aad9ac3aaa279483015017","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Now when user boots an instance using image 4, then it should be matched with"},{"line_number":87,"context_line":"host aggregate with empty metadata only. In this example, it should choose"},{"line_number":88,"context_line":"\"Host aggregate 4\" to boot instance."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa0c359_39596d59","line":88,"in_reply_to":"3fa0c359_1a10a74d","updated":"2018-02-20 09:35:43.000000000","message":"Referring to this example, this should be the expected behaviour.","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"80c3761fba865409e8ea45641e147230dac7b03c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"* `image_strict_isolation\u003dTrue/False`, will dictate strictness level of"},{"line_number":103,"context_line":"  the isolation."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"We would also like to introduce a new config option `strict_keys_to_match`"},{"line_number":106,"context_line":"which will be a list of keys to be matched strictly in case host aggregate"},{"line_number":107,"context_line":"metadata \u0027image_strict_isolation\u0027 is False or not set. This config option"},{"line_number":108,"context_line":"will be defined in nova.conf under the \u0027filter_scheduler\u0027 section."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The new filter will behave like below:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa0c359_5a238fa7","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":54},"updated":"2018-02-14 00:44:03.000000000","message":"what\u0027s the use-case for strict-matching if the aggregate didn\u0027t ask for it?","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"567251576ab547c0b6aad9ac3aaa279483015017","unresolved":false,"context_lines":[{"line_number":102,"context_line":"* `image_strict_isolation\u003dTrue/False`, will dictate strictness level of"},{"line_number":103,"context_line":"  the isolation."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"We would also like to introduce a new config option `strict_keys_to_match`"},{"line_number":106,"context_line":"which will be a list of keys to be matched strictly in case host aggregate"},{"line_number":107,"context_line":"metadata \u0027image_strict_isolation\u0027 is False or not set. This config option"},{"line_number":108,"context_line":"will be defined in nova.conf under the \u0027filter_scheduler\u0027 section."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The new filter will behave like below:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa0c359_d9164956","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":54},"in_reply_to":"3fa0c359_5a238fa7","updated":"2018-02-20 09:35:43.000000000","message":"No use case from our side. Removed in the new patchset.","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"80c3761fba865409e8ea45641e147230dac7b03c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":127,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":128,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":129,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":130,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":131,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":132,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa0c359_ba48935b","line":129,"range":{"start_line":129,"start_character":68,"end_line":129,"end_character":72},"updated":"2018-02-14 00:44:03.000000000","message":"I still think it\u0027s kind of weird that you could have an image that specifies \"os_distro\u003dwindows\" and end up on a host aggregate that doesn\u0027t have the matching metadata.","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"00c6dbbcba438cadeeeaaf20f1de7c50016c5589","unresolved":false,"context_lines":[{"line_number":126,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":127,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":128,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":129,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":130,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":131,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":132,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1f9dbf25_813895d3","line":129,"range":{"start_line":129,"start_character":68,"end_line":129,"end_character":72},"in_reply_to":"3fa0c359_441c9069","updated":"2018-03-01 11:05:26.000000000","message":"Discussed with Chris in PTG. \nReverted back to returning True as if the host is not under any aggregate and doesn\u0027t have any metadata set then it is eligible for deploying any instance.","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"567251576ab547c0b6aad9ac3aaa279483015017","unresolved":false,"context_lines":[{"line_number":126,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":127,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e |"},{"line_number":128,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":129,"context_line":"| k1\u003dv1         | True      | False     | **False**   | **False** | True |"},{"line_number":130,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"},{"line_number":131,"context_line":"| k1\u003dv2         | False     | True      | False       | **False** | True |"},{"line_number":132,"context_line":"+---------------+-----------+-----------+-------------+-----------+------+"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa0c359_441c9069","line":129,"range":{"start_line":129,"start_character":68,"end_line":129,"end_character":72},"in_reply_to":"3fa0c359_ba48935b","updated":"2018-02-20 09:35:43.000000000","message":"Done","commit_id":"8973aa5bba00765df0077b6fd3adae2adf465d23"}],"specs/rocky/approved/strict_isolation_of_group_of_hosts_for_image.rst":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"3676346fb0a412564a4cc03f84e22b664a4c99ea","unresolved":false,"context_lines":[{"line_number":35,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":36,"context_line":"| k1\u003dv2         | False      | True       | False         | True       |"},{"line_number":37,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":38,"context_line":"| k1\u003dv1,k2\u003dv2   | False      | False      | True          | True       |"},{"line_number":39,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":40,"context_line":"| \u003cempty\u003e       | True       | True       | True          | True       |"},{"line_number":41,"context_line":"+---------------+------------+------------+---------------+------------+"}],"source_content_type":"text/x-rst","patch_set":16,"id":"1f9dbf25_a6183a1d","line":38,"range":{"start_line":38,"start_character":18,"end_line":38,"end_character":23},"updated":"2018-03-01 22:38:04.000000000","message":"isn\u0027t this \"true\" in the current filter?  all the key/value pairs in the aggregate are matched in the image properties.","commit_id":"ebe9e54f9d15cd6d6d5ba1dc98cb5474aaea895f"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"89b034ee85c70191983216f97089d02f2af12a90","unresolved":false,"context_lines":[{"line_number":35,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":36,"context_line":"| k1\u003dv2         | False      | True       | False         | True       |"},{"line_number":37,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":38,"context_line":"| k1\u003dv1,k2\u003dv2   | False      | False      | True          | True       |"},{"line_number":39,"context_line":"+---------------+------------+------------+---------------+------------+"},{"line_number":40,"context_line":"| \u003cempty\u003e       | True       | True       | True          | True       |"},{"line_number":41,"context_line":"+---------------+------------+------------+---------------+------------+"}],"source_content_type":"text/x-rst","patch_set":16,"id":"1f9dbf25_93e1b99d","line":38,"range":{"start_line":38,"start_character":18,"end_line":38,"end_character":23},"in_reply_to":"1f9dbf25_a6183a1d","updated":"2018-03-02 10:16:01.000000000","message":"oops..., will change in updated spec.","commit_id":"ebe9e54f9d15cd6d6d5ba1dc98cb5474aaea895f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4713896c89b1de0c57451a8d542a48535763abc6","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* `image_strict_isolation\u003dTrue/False`, will dictate strictness level of"},{"line_number":107,"context_line":"  the isolation. This metadata will be added to host aggregate. If this"},{"line_number":108,"context_line":"  metadata is not set then it will be treated as `False`."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The new filter will behave like below:"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"1f9dbf25_24f09d67","line":108,"updated":"2018-03-02 12:02:03.000000000","message":"and what happens if a compute node is associated with 2 aggregates, and each aggregates has a different value for this metadata key?","commit_id":"ebe9e54f9d15cd6d6d5ba1dc98cb5474aaea895f"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"48c34f029cac7b7f6bbf1b09dcc897632852c882","unresolved":false,"context_lines":[{"line_number":136,"context_line":"+---------------+-----------+-----------+-------------+-----------+-------+"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* \"\u003cno\u003e\" column represents hosts that are not in any aggregate."},{"line_number":139,"context_line":"* \"\u003cempty\u003e\" column above means no metadata set on aggregate."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"*Table 2: rows are image properties, columns are host aggregate metadata*"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"1f9dbf25_0699ee6c","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":60},"updated":"2018-03-01 23:04:30.000000000","message":"Just to clarify, it appears that the key point here is that you are doing a *bidirectional* matching between the image and the aggregate.  Thus, anything extra in either one will result in the filter returning False.","commit_id":"ebe9e54f9d15cd6d6d5ba1dc98cb5474aaea895f"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"89b034ee85c70191983216f97089d02f2af12a90","unresolved":false,"context_lines":[{"line_number":136,"context_line":"+---------------+-----------+-----------+-------------+-----------+-------+"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* \"\u003cno\u003e\" column represents hosts that are not in any aggregate."},{"line_number":139,"context_line":"* \"\u003cempty\u003e\" column above means no metadata set on aggregate."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"*Table 2: rows are image properties, columns are host aggregate metadata*"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"1f9dbf25_53f57156","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":60},"in_reply_to":"1f9dbf25_0699ee6c","updated":"2018-03-02 10:16:01.000000000","message":"correct.","commit_id":"ebe9e54f9d15cd6d6d5ba1dc98cb5474aaea895f"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"48c34f029cac7b7f6bbf1b09dcc897632852c882","unresolved":false,"context_lines":[{"line_number":144,"context_line":"host aggregate group with image properties as depicted in below table."},{"line_number":145,"context_line":"This behaviour is same as existing `AggregateImagePropertiesIsolation` filter"},{"line_number":146,"context_line":"except if metadata of host-aggregate group doesn\u0027t exist in image"},{"line_number":147,"context_line":"properties it will return `False`. If operator doesn\u0027t set any metadata to"},{"line_number":148,"context_line":"host aggregate group, then in that case it will return `False` otherwise"},{"line_number":149,"context_line":"all images can be booted on hosts belonging to this host aggregate group"},{"line_number":150,"context_line":"which is one of the biggest problem to the operators."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"+---------------+-----------+-----------+-------------+-----------+-------+"},{"line_number":153,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e  |"}],"source_content_type":"text/x-rst","patch_set":16,"id":"1f9dbf25_06e7aee6","line":150,"range":{"start_line":147,"start_character":35,"end_line":150,"end_character":53},"updated":"2018-03-01 23:04:30.000000000","message":"This doesn\u0027t make sense.\n\nThe overall logic here is basically \"all keys in the aggregate must be present and have the same value in the image\".\n\nIf the operator doesn\u0027t set any metadata on the aggregate, it is equivalent to the operator saying \"I have no special requirements for images to run on this host-aggregate\", so it\u0027s reasonable that all images would be able to run there.","commit_id":"ebe9e54f9d15cd6d6d5ba1dc98cb5474aaea895f"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"89b034ee85c70191983216f97089d02f2af12a90","unresolved":false,"context_lines":[{"line_number":144,"context_line":"host aggregate group with image properties as depicted in below table."},{"line_number":145,"context_line":"This behaviour is same as existing `AggregateImagePropertiesIsolation` filter"},{"line_number":146,"context_line":"except if metadata of host-aggregate group doesn\u0027t exist in image"},{"line_number":147,"context_line":"properties it will return `False`. If operator doesn\u0027t set any metadata to"},{"line_number":148,"context_line":"host aggregate group, then in that case it will return `False` otherwise"},{"line_number":149,"context_line":"all images can be booted on hosts belonging to this host aggregate group"},{"line_number":150,"context_line":"which is one of the biggest problem to the operators."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"+---------------+-----------+-----------+-------------+-----------+-------+"},{"line_number":153,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e  |"}],"source_content_type":"text/x-rst","patch_set":16,"id":"1f9dbf25_aef9ec80","line":150,"range":{"start_line":147,"start_character":35,"end_line":150,"end_character":53},"in_reply_to":"1f9dbf25_06e7aee6","updated":"2018-03-02 10:16:01.000000000","message":"We can return \u0027True\u0027 in this case, but do we want images to be launched in some specific host aggregate groups to land in any other host aggregate group.\n\nFor example,\nI have one licensed image \"IMG1\"  with image property \"os_distro\u003dwindows\" and I want it to land in host aggregate group \"HA1\" which has set \"\"os_distro\u003dwindows\" metadata. If I have another host aggregate group \u0027HA2\" with empty metadata set and if hosts belonging to it are returned first in allocation candidates from placement service, then the image \"IMG1\" will land in \"HA2\". I think we don\u0027t want this behavior.","commit_id":"ebe9e54f9d15cd6d6d5ba1dc98cb5474aaea895f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4713896c89b1de0c57451a8d542a48535763abc6","unresolved":false,"context_lines":[{"line_number":144,"context_line":"host aggregate group with image properties as depicted in below table."},{"line_number":145,"context_line":"This behaviour is same as existing `AggregateImagePropertiesIsolation` filter"},{"line_number":146,"context_line":"except if metadata of host-aggregate group doesn\u0027t exist in image"},{"line_number":147,"context_line":"properties it will return `False`. If operator doesn\u0027t set any metadata to"},{"line_number":148,"context_line":"host aggregate group, then in that case it will return `False` otherwise"},{"line_number":149,"context_line":"all images can be booted on hosts belonging to this host aggregate group"},{"line_number":150,"context_line":"which is one of the biggest problem to the operators."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"+---------------+-----------+-----------+-------------+-----------+-------+"},{"line_number":153,"context_line":"| props \\\\ aggr | k1\u003dv1     | k1\u003dv2     | k1\u003dv1,k2\u003dv2 | \u003cempty\u003e   | \u003cno\u003e  |"}],"source_content_type":"text/x-rst","patch_set":16,"id":"1f9dbf25_3f52e414","line":150,"range":{"start_line":147,"start_character":35,"end_line":150,"end_character":53},"in_reply_to":"1f9dbf25_aef9ec80","updated":"2018-03-02 12:02:03.000000000","message":"Specifically for the Windows license thing, it might be a good idea to make a custom resource class for Windows licenses and make them a consumable resource. That way, the licenses can be inventoried and allocated just like any other resource class.","commit_id":"ebe9e54f9d15cd6d6d5ba1dc98cb5474aaea895f"}]}
