)]}'
{"specs/ocata/approved/input-user-id-keypair.rst":[{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"095299ed4b6feca2064da08bd51c7d9fa6de644a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a95cdbc_7f96624d","line":70,"updated":"2016-10-05 18:23:16.000000000","message":"s/and/an/","commit_id":"170f497677d96300395eb6c1ab843892f3bc2cbb"},{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"095299ed4b6feca2064da08bd51c7d9fa6de644a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a95cdbc_dfa9367d","line":108,"updated":"2016-10-05 18:23:16.000000000","message":"Should this take in a name as well as an ID, and allow the client to attempt to resolve the name to a UUID (or error if there are more than one users within the project with the same name?)","commit_id":"170f497677d96300395eb6c1ab843892f3bc2cbb"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8a5b823bcf4199d41381da3d011f3f2a1987f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_4f6fc22a","updated":"2016-10-08 05:19:12.000000000","message":"Whats the current default policy (in policy.json) for creating keypairs? I assumed there would be a change there","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_d3202a9e","in_reply_to":"1a95cdbc_4f6fc22a","updated":"2016-10-20 00:08:49.000000000","message":"This is about creating servers, not keypairs, so the policy for creating keypairs shouldn\u0027t come into this.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8a5b823bcf4199d41381da3d011f3f2a1987f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_afbf66a8","line":2,"range":{"start_line":2,"start_character":26,"end_line":2,"end_character":42},"updated":"2016-10-08 05:19:12.000000000","message":"trim the unnecessary \u003d\u003d\u003d\u0027s","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8a5b823bcf4199d41381da3d011f3f2a1987f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_cfde7210","line":6,"range":{"start_line":6,"start_character":58,"end_line":6,"end_character":68},"updated":"2016-10-08 05:19:12.000000000","message":"\"their\" is a bit ambiguous, does this mean with a user\u0027s key-pair? or an admin\u0027s key-pair?","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"d2fdea2e22f18ee6049561790230bf586ac74d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a629dbe_65b2b6e6","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":5},"updated":"2016-11-11 16:27:03.000000000","message":"s/Allow/This change allows/\nThis update assumes that the redundant sentence in lines 9-10 is removed and the updated sentence above will replace it","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_53633adc","line":6,"range":{"start_line":6,"start_character":58,"end_line":6,"end_character":68},"in_reply_to":"1a95cdbc_cfde7210","updated":"2016-10-20 00:08:49.000000000","message":"+1. s/users with their keypair/user with that user\u0027s keypair/","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_53917a98","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":24},"updated":"2016-10-20 00:08:49.000000000","message":"s/admin/an admin/","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_f37fee63","line":9,"range":{"start_line":9,"start_character":64,"end_line":9,"end_character":69},"updated":"2016-10-20 00:08:49.000000000","message":"s/users/user/","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_73e3de33","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":31},"updated":"2016-10-20 00:08:49.000000000","message":"same issue of ambiguity Steve mentioned above.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"d2fdea2e22f18ee6049561790230bf586ac74d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a629dbe_458132fa","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":31},"in_reply_to":"fa6399be_73e3de33","updated":"2016-11-11 16:27:03.000000000","message":"The sentence in lines 9-10 is not necessary.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_b361f6aa","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"updated":"2016-10-20 00:08:49.000000000","message":"drop the word \"currently\". That isn\u0027t going to change.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8a5b823bcf4199d41381da3d011f3f2a1987f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_cf7af2f0","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":58},"updated":"2016-10-08 05:19:12.000000000","message":"The highlighted section can be simplified to:\n\nCurrently, key-pairs generated are associated with a specific user. If a `user_id` is specified in the API call, the generated key-pair is associated with the specified `user_id`. Otherwise, it is associated with the `user_id` extracted from the request context.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8a5b823bcf4199d41381da3d011f3f2a1987f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_0ffcda70","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":58},"updated":"2016-10-08 05:19:12.000000000","message":"add a new line after this line for readability","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_f3852e07","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":58},"in_reply_to":"1a95cdbc_cf7af2f0","updated":"2016-10-20 00:08:49.000000000","message":"generated could imply the wrong thing here, since nova allows you to either upload or generate a key-pair. I prefer \"Nova key pairs are associated with a specific user at creation time. If a `user_id` is specified in the API request, the new key-pair is associated with the specified `user_id`. Otherwise, it is associated with the `user_id` extracted from the request context.\"","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8a5b823bcf4199d41381da3d011f3f2a1987f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_2f38b63c","line":32,"range":{"start_line":32,"start_character":28,"end_line":32,"end_character":29},"updated":"2016-10-08 05:19:12.000000000","message":"add another new line here for readability","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8a5b823bcf4199d41381da3d011f3f2a1987f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_2f0fd688","line":32,"range":{"start_line":25,"start_character":0,"end_line":32,"end_character":29},"updated":"2016-10-08 05:19:12.000000000","message":"this whole highlighted section can be reduced to:\n\nAn administrator is able to generate a key-pair for another user in the project (by passing in a specific `user_id`). However, the admin is unable to deploy a VM with the new key-pair.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_53c5fa39","line":32,"range":{"start_line":25,"start_character":0,"end_line":32,"end_character":29},"in_reply_to":"1a95cdbc_2f0fd688","updated":"2016-10-20 00:08:49.000000000","message":"+1. I think that should actually replace the rest of this section, not just what was highlighted.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ef2c710ffee980ae815bc601358926fe63e3fcfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_b1f2c46d","line":45,"range":{"start_line":43,"start_character":2,"end_line":45,"end_character":25},"updated":"2016-10-06 11:44:13.000000000","message":"what\u0027s the value of doing this and why limit inside same project?","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_a520c99c","line":45,"range":{"start_line":43,"start_character":2,"end_line":45,"end_character":25},"in_reply_to":"1a95cdbc_b1f2c46d","updated":"2016-10-20 00:08:49.000000000","message":"the value is explained in the problem section, but you do need to remove \"within the same project\" because neither users nor keypairs are scoped to projects.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_45ba8d0b","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":25},"updated":"2016-10-20 00:08:49.000000000","message":"this would require nova making an extra call to keystone to get the effective role assignments of user_id. That\u0027s typically not how things work. I don\u0027t know that there is sufficient harm in letting the admin deploy a VM with a user\u0027s key-pair even when that user doesn\u0027t have access to the project to justify checking this.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ef2c710ffee980ae815bc601358926fe63e3fcfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_31231407","line":52,"range":{"start_line":47,"start_character":2,"end_line":52,"end_character":17},"updated":"2016-10-06 11:44:13.000000000","message":"guess this is not use case , it\u0027s restrictions to usage","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_091c20c0","line":57,"range":{"start_line":57,"start_character":7,"end_line":57,"end_character":8},"updated":"2016-10-20 00:08:49.000000000","message":"remove this comma","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_e977ecff","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":32},"updated":"2016-10-20 00:08:49.000000000","message":"\"along with a key-pair name\".","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_094a60ac","line":60,"range":{"start_line":60,"start_character":39,"end_line":60,"end_character":53},"updated":"2016-10-20 00:08:49.000000000","message":"this can\u0027t just be first priority. If a user_id isn\u0027t specified, then the behaviour should be as it is today, but if a user_id is specified, that user_id needs to scope the key-pair name. If no key-pair with that name is found for the specified user_id, the deploy must fail just as it does today if the key-pair name isn\u0027t found for the contextual user.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_f8718da9","line":68,"range":{"start_line":68,"start_character":22,"end_line":68,"end_character":29},"updated":"2016-10-20 00:08:49.000000000","message":"s/to this/is/","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_989b31c9","line":71,"range":{"start_line":71,"start_character":51,"end_line":71,"end_character":54},"updated":"2016-10-20 00:08:49.000000000","message":"an","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_982b31eb","line":73,"range":{"start_line":72,"start_character":17,"end_line":73,"end_character":35},"updated":"2016-10-20 00:08:49.000000000","message":"this isn\u0027t really an alternative, because key_name is only unique per user. Just specifying key_name would therefore be ambiguous when multiple users have a key with that name.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_299564e3","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":67},"updated":"2016-10-20 00:08:49.000000000","message":"this should go in the previous section if it needs to be said. This section is supposed to be about alternatives (and I don\u0027t think there are any, so I would expect this section to simply say \"None\").","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ef2c710ffee980ae815bc601358926fe63e3fcfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_31add431","line":89,"range":{"start_line":89,"start_character":25,"end_line":89,"end_character":60},"updated":"2016-10-06 11:44:13.000000000","message":"better to talk about microversion though doc part already mentioned","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_a98974cc","line":89,"range":{"start_line":89,"start_character":25,"end_line":89,"end_character":60},"in_reply_to":"1a95cdbc_31add431","updated":"2016-10-20 00:08:49.000000000","message":"+1","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_29bc846b","line":98,"range":{"start_line":98,"start_character":16,"end_line":98,"end_character":39},"updated":"2016-10-20 00:08:49.000000000","message":"remove this for the same reasons mentioned above.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_a9b0948c","line":110,"range":{"start_line":110,"start_character":26,"end_line":110,"end_character":41},"updated":"2016-10-20 00:08:49.000000000","message":"both novaclient (first) and openstackclient. Good to mention those here, but I would expect those changes to fall under additional specs in those projects.","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8a5b823bcf4199d41381da3d011f3f2a1987f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a95cdbc_0f813ac3","line":113,"range":{"start_line":113,"start_character":2,"end_line":113,"end_character":13},"updated":"2016-10-08 05:19:12.000000000","message":"the command already has the word \"key\" in it:\n\n  openstack keypair create\n\njust add a --user option (OSC support ID and name lookup), and there is no reason to prefix it with \"key\"","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"b496eb3b758a0c72da1a08cd2740c4b07e406a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa6399be_ac3a62cb","line":164,"range":{"start_line":164,"start_character":9,"end_line":164,"end_character":10},"updated":"2016-10-20 00:08:49.000000000","message":"missing a space","commit_id":"b1ae9726b084e3e4cbeb6d82c9e9b82d74243379"}]}