)]}'
{"specs/ocata/approved/vendordata-reboot-ocata.rst":[{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"993456b72488ba74f1bd69e1bfef92aea455fa4b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The original specification envisaged caching of responses from the external"},{"line_number":99,"context_line":"vendordata service, but this was not implemented. If time allows in the Ocata"},{"line_number":100,"context_line":"release, we willa dd this support."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"This is not a bug fix and will not be backported."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_478e5a28","line":100,"updated":"2016-11-14 15:59:30.000000000","message":"nit: willa dd -\u003e will add","commit_id":"95012c7f7df928b95517b0ee35b81160cc8e2e97"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d051fa8d9b067a81a1eb76abb170ecf14203925a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Role information from the user\u0027s token"},{"line_number":74,"context_line":"--------------------------------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The only place where we need to user\u0027s token is for role information. So that"},{"line_number":77,"context_line":"this is available later (and doesn\u0027t change if the user\u0027s roles change), we"},{"line_number":78,"context_line":"will cache this information from the boot request in the Nova database as"},{"line_number":79,"context_line":"system metadata, and then pass that through to the external vendordata"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a77a97e_38132168","line":76,"range":{"start_line":76,"start_character":29,"end_line":76,"end_character":31},"updated":"2016-11-16 02:52:58.000000000","message":"s/to/to use the/?","commit_id":"51f25780277ab940b3bc32bbfa382e0f41ff0e16"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a4359d20ecda7f624d6401494e7e06ad75a61d44","unresolved":false,"context_lines":[{"line_number":77,"context_line":"this is available later (and doesn\u0027t change if the user\u0027s roles change), we"},{"line_number":78,"context_line":"will cache this information from the boot request in the Nova database as"},{"line_number":79,"context_line":"system metadata, and then pass that through to the external vendordata"},{"line_number":80,"context_line":"service with each request."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This is not a bug fix and will not be backported."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a77a97e_1314c3f3","line":80,"updated":"2016-11-14 23:03:32.000000000","message":"It\u0027s not sufficiently clear from this description why it\u0027s important for the user\u0027s roles to not change.\n\nWhat is the lifetime and lifecycle of this bit of cache?","commit_id":"51f25780277ab940b3bc32bbfa382e0f41ff0e16"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d051fa8d9b067a81a1eb76abb170ecf14203925a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"this is available later (and doesn\u0027t change if the user\u0027s roles change), we"},{"line_number":78,"context_line":"will cache this information from the boot request in the Nova database as"},{"line_number":79,"context_line":"system metadata, and then pass that through to the external vendordata"},{"line_number":80,"context_line":"service with each request."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This is not a bug fix and will not be backported."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a77a97e_733bfad1","line":80,"in_reply_to":"7a77a97e_1314c3f3","updated":"2016-11-16 02:52:58.000000000","message":"It\u0027s not really a cache, it\u0027s stashing the user\u0027s role(s) from the original token in the instance.system_metadata and then using that on subsequent requests to the metadata API to pass that through to the metadata server.\n\nI didn\u0027t totally follow the conversation on this at the summit so I\u0027m not really sure why it was necessary to pass this along, but I guess it\u0027s just more info for the metadata server to tell if it\u0027s dealing with an admin or not? It\u0027s a bit weird though because after the server is created that role could change but we\u0027d still be passing the old value from the initial server create, but it was decided that didn\u0027t matter for some reason.\n\nThere could be some more wording around this part of the spec to explain the need to pass this and why the role changing doesn\u0027t matter.","commit_id":"51f25780277ab940b3bc32bbfa382e0f41ff0e16"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"d02ad792c9f9abc9617a3d6b190ce99b84e331bf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"this is available later (and doesn\u0027t change if the user\u0027s roles change), we"},{"line_number":78,"context_line":"will cache this information from the boot request in the Nova database as"},{"line_number":79,"context_line":"system metadata, and then pass that through to the external vendordata"},{"line_number":80,"context_line":"service with each request."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This is not a bug fix and will not be backported."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_7d366fe8","line":80,"in_reply_to":"7a77a97e_733bfad1","updated":"2016-11-24 07:50:02.000000000","message":"I have attempted to clarify, but am proxying others here. I wasn\u0027t the one advocating for storing this data. I think it was James Pennick?","commit_id":"51f25780277ab940b3bc32bbfa382e0f41ff0e16"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d051fa8d9b067a81a1eb76abb170ecf14203925a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Other deployer impact"},{"line_number":141,"context_line":"---------------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Developer impact"},{"line_number":146,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a77a97e_936416e6","line":143,"updated":"2016-11-16 02:52:58.000000000","message":"There will be config options for the service token that\u0027s going to be passed to the vendordata service, right? Basically whatever standard options we need for KSA like we have for cinder/glance/neutron/barbican/placement.","commit_id":"51f25780277ab940b3bc32bbfa382e0f41ff0e16"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"d02ad792c9f9abc9617a3d6b190ce99b84e331bf","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Other deployer impact"},{"line_number":141,"context_line":"---------------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Developer impact"},{"line_number":146,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_b2f3ce9d","line":143,"in_reply_to":"7a77a97e_936416e6","updated":"2016-11-24 07:50:02.000000000","message":"Done","commit_id":"51f25780277ab940b3bc32bbfa382e0f41ff0e16"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"84018ad9cca7d110f663e5f7840bfc63585d778f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"information so that the results returned for metadata requests do not change"},{"line_number":84,"context_line":"over time -- for example if a user has a role that allows them to start a mail"},{"line_number":85,"context_line":"server at the time of the boot request, the instance should remain a mail"},{"line_number":86,"context_line":"server for all time, regardless of if that user has that role removed from them."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This is not a bug fix and will not be backported."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a74a57a_3883ee57","line":86,"updated":"2016-11-25 10:47:21.000000000","message":"That\u0027s a) interesting, b) sounds a bit wrong. It feels the almost equivalent to: we should allow this server, created by this user, to continue to exist (e.g., persist through an administrative migration), even if we have declared that this user is not allowed to have servers. Is that the intent?","commit_id":"3021e4c7452309463d94104ba457d1d8dd9afa7a"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"947c3f8b2c15ff268e36c9dd01906c2ea9ddc828","unresolved":false,"context_lines":[{"line_number":83,"context_line":"information so that the results returned for metadata requests do not change"},{"line_number":84,"context_line":"over time -- for example if a user has a role that allows them to start a mail"},{"line_number":85,"context_line":"server at the time of the boot request, the instance should remain a mail"},{"line_number":86,"context_line":"server for all time, regardless of if that user has that role removed from them."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This is not a bug fix and will not be backported."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a74a57a_12226152","line":86,"in_reply_to":"5a74a57a_3883ee57","updated":"2016-11-28 05:28:04.000000000","message":"I see it more being associated with a job role if that makes sense -- I work on the gmail team, so I can start gmail frontends. I then change to the mobile search team. gmail still wants their frontends, but I don\u0027t administer them any more -- someone else with that role now does.","commit_id":"3021e4c7452309463d94104ba457d1d8dd9afa7a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dcc82628171bfd22965eed60c4b8c8979d84a211","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The original specification envisaged caching of responses from the external"},{"line_number":106,"context_line":"vendordata service, but this was not implemented. If time allows in the Ocata"},{"line_number":107,"context_line":"release, we willa dd this support."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"This is not a bug fix and will not be backported."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a74a57a_e7ea66da","line":107,"range":{"start_line":107,"start_character":12,"end_line":107,"end_character":20},"updated":"2016-11-28 15:56:01.000000000","message":"will add","commit_id":"b51341a1e12532510ba7361c6d08e667b30b9f01"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fc21f9f6429b2bb018003f62faca1f3f7773fca0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"over time -- for example if a user has a role that allows them to start a mail"},{"line_number":85,"context_line":"server at the time of the boot request, the instance should remain a mail"},{"line_number":86,"context_line":"server for all time, regardless of if that user has that role removed from"},{"line_number":87,"context_line":"them."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This is not a bug fix and will not be backported."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_88fd10b3","line":87,"updated":"2016-11-29 13:51:22.000000000","message":"There is no talk of how old instances will never have this information, so this only works for instances launched after the feature was added. But this seems the only sensible way forward, so perhaps its not worth discussing here.","commit_id":"b1313ce224e5c8100ba62595615917b5f3e03cb2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fc21f9f6429b2bb018003f62faca1f3f7773fca0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"the instance requires configuration information from an external service to be"},{"line_number":98,"context_line":"able to operate correctly."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This is not a bug fix and will not be backported."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Caching"},{"line_number":103,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_c86388af","line":100,"updated":"2016-11-29 13:51:22.000000000","message":"I assume this is when config drive is forced on.","commit_id":"b1313ce224e5c8100ba62595615917b5f3e03cb2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fc21f9f6429b2bb018003f62faca1f3f7773fca0","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Testing"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Unit test"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_a8bc8cdc","line":181,"updated":"2016-11-29 13:51:22.000000000","message":"Hmm, feels like a functional test of some kind would be useful, to confirm this is all working.","commit_id":"b1313ce224e5c8100ba62595615917b5f3e03cb2"}]}