)]}'
{"specs/pike/approved/nova-bfv-by-reserving-volume.rst":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"62bea2dcca4937b599a07049cadc1e9795a422bb","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/bfv-with-reserved-volume"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Cinder change https://review.openstack.org/#/c/387712/ provides the"},{"line_number":14,"context_line":"mechanics to reserve a volume while it is in creating or downloading state."},{"line_number":15,"context_line":"This can be leveraged by the nova boot from volume procedure so that BFV will"},{"line_number":16,"context_line":"not have to wait for the volume to be completely available. To avoid waiting"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_49404457","line":13,"range":{"start_line":13,"start_character":14,"end_line":13,"end_character":54},"updated":"2017-02-10 12:00:49.000000000","message":"This link is out of date. That change was abandoned in favour of this one, which is now merged: https://review.openstack.org/#/c/414632/","commit_id":"f12ec78472cdd681232baa56af73d80a58a25eed"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"159f28c780906ac37126ab1707813915a585d063","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/bfv-with-reserved-volume"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Cinder change https://review.openstack.org/#/c/387712/ provides the"},{"line_number":14,"context_line":"mechanics to reserve a volume while it is in creating or downloading state."},{"line_number":15,"context_line":"This can be leveraged by the nova boot from volume procedure so that BFV will"},{"line_number":16,"context_line":"not have to wait for the volume to be completely available. To avoid waiting"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_1f9d020a","line":13,"range":{"start_line":13,"start_character":14,"end_line":13,"end_character":54},"in_reply_to":"fa31d9ce_49404457","updated":"2017-02-14 22:58:36.000000000","message":"Good catch Matt, the updated version that merged is here:\n    https://review.openstack.org/#/c/414632/\n\nSame principals still apply, just some other things changed.","commit_id":"f12ec78472cdd681232baa56af73d80a58a25eed"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"62bea2dcca4937b599a07049cadc1e9795a422bb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"at all because its not actually \"attaching\" rather someone has expressed that"},{"line_number":52,"context_line":"they intend to attach to the volume at some future time."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Cinder change (https://review.openstack.org/#/c/387712/) provides granular"},{"line_number":55,"context_line":"state what allows nova BFV to be able to reserve and wait for the volume"},{"line_number":56,"context_line":"to be"},{"line_number":57,"context_line":"available."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_64ce0d85","line":54,"range":{"start_line":54,"start_character":15,"end_line":54,"end_character":55},"updated":"2017-02-10 12:00:49.000000000","message":"See above: out of date.","commit_id":"f12ec78472cdd681232baa56af73d80a58a25eed"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"volume to be created, and then boot onto it if they want anything other then"},{"line_number":34,"context_line":"the default."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Ideally the solution to this problem is to extend the nova API to accept"},{"line_number":37,"context_line":"volume-type as an optional field on the BFV call. After 2 cycles of discussion"},{"line_number":38,"context_line":"we have been unable to get agreement from the nova core team to pursue this"},{"line_number":39,"context_line":"route. Nova has taken that stance that the proper way to address this is to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_eb2ad77d","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":36},"updated":"2017-02-19 19:40:59.000000000","message":"Ideally is subjective here, and the rest of this paragraph goes on to explain why it\u0027s not ideal for everyone. I think it\u0027d be good to remove this bit and maybe replace some or all of it in the alternatives section.","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee69ea324f926fe7caa1a64ca2a4dbf9913356fb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"simply create a volume using cinder and boot from that volume. The main"},{"line_number":41,"context_line":"problem with this is that you have to create the volume and wait for it to"},{"line_number":42,"context_line":"become \"available\" before you issue the boot command. If the status of a"},{"line_number":43,"context_line":"volume is not \"available\" the nova API will reject the request as invalid."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Today this is done in the check_attach function of the compute API, however"},{"line_number":46,"context_line":"nova core plans on merging https://review.openstack.org/#/c/335358/ which"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_135caa4a","line":43,"updated":"2017-02-20 19:49:43.000000000","message":"You\u0027re paraphrasing your first paragraph, I don\u0027t think this whole paragraph is needed and like Dan said, just add a note in the \"alternative\" section about the previous approach you had (which I disagree because I don\u0027t like exposing hardware types on an API level)","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"or \"in-use\" (for multiattach only) state. Additionally the reserve volume"},{"line_number":51,"context_line":"call changes the status of the volume to \"attaching\" which isn\u0027t accurate"},{"line_number":52,"context_line":"at all because its not actually \"attaching\" rather someone has expressed that"},{"line_number":53,"context_line":"they intend to attach to the volume at some future time."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Cinder change (https://review.openstack.org/#/c/414632/) provides granular"},{"line_number":56,"context_line":"state what allows nova BFV to be able to reserve and wait for the volume"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_4b3a03cf","line":53,"updated":"2017-02-19 19:40:59.000000000","message":"This whole paragraph is describing part of the proposed changed, but in a strange way. It\u0027s definitely not part of the \"problem statement\".\n\nIMHO, it\u0027d be nice to have all three of these paragraphs replaced with a succinct explanation of how advanced cinder volume creation requires going direct to cinder, and that nova currently won\u0027t properly wait on a reserved volume.","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"at all because its not actually \"attaching\" rather someone has expressed that"},{"line_number":53,"context_line":"they intend to attach to the volume at some future time."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Cinder change (https://review.openstack.org/#/c/414632/) provides granular"},{"line_number":56,"context_line":"state what allows nova BFV to be able to reserve and wait for the volume"},{"line_number":57,"context_line":"to be"},{"line_number":58,"context_line":"available."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Use Cases"},{"line_number":61,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_6b37c7e3","line":58,"range":{"start_line":55,"start_character":56,"end_line":58,"end_character":10},"updated":"2017-02-19 19:40:59.000000000","message":"This needs to be reworded and reformatted. It could also use some clarity.","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee69ea324f926fe7caa1a64ca2a4dbf9913356fb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"state what allows nova BFV to be able to reserve and wait for the volume"},{"line_number":57,"context_line":"to be"},{"line_number":58,"context_line":"available."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Use Cases"},{"line_number":61,"context_line":"---------"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_f613845a","line":59,"updated":"2017-02-20 19:49:43.000000000","message":"After reading twice this problem statement,  I still don\u0027t get the crux of the problem that needs another blueprint in order to address your usecase. Could you please try to make a very clear statement on what\u0027s missing once we merge the above change?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Use Cases"},{"line_number":61,"context_line":"---------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The use case is Nova BFV with volume not being at \"available\" state."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"This blueprint impacts Nova developers, reviewers and users."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_cb4c3379","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":68},"updated":"2017-02-19 19:40:59.000000000","message":"This really only affects users, so I think this should be:\n\n \"As a user I want to be able to boot a volume-backed instance where the volume is still in reserved state\"","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee69ea324f926fe7caa1a64ca2a4dbf9913356fb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Use Cases"},{"line_number":61,"context_line":"---------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The use case is Nova BFV with volume not being at \"available\" state."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"This blueprint impacts Nova developers, reviewers and users."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_96a088f6","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":68},"in_reply_to":"da36d5c6_cb4c3379","updated":"2017-02-20 19:49:43.000000000","message":"Wow, thanks Dan for giving me the usecase, it wasn\u0027t clear.\n\nJust to make it clear, what would be the state of the instance while the volume is still not active ?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The use case is Nova BFV with volume not being at \"available\" state."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"This blueprint impacts Nova developers, reviewers and users."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Proposed change"},{"line_number":68,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_0b572b03","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":60},"updated":"2017-02-19 19:40:59.000000000","message":"This belongs in the section(s) below.","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Proposed change"},{"line_number":68,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We propose to change the reserve volume call such that it will allow for the"},{"line_number":71,"context_line":"reserving of a volume that is in the \"creating\" or \"downloading\" state."},{"line_number":72,"context_line":"Since we now want to \"reserve\" a volume that is still in a transitory state"},{"line_number":73,"context_line":"(\"creating\" or \"downloading\") we wish to change the way the reserve volume"},{"line_number":74,"context_line":"call works such that it does not need to change the status to \"attaching\"."},{"line_number":75,"context_line":"We propose that we extend the existing attach_status field to indicate a"},{"line_number":76,"context_line":"reserved volume. The attach_status field today have two values \"attached\""},{"line_number":77,"context_line":"and \"detached\". This cinder change (https://review.openstack.org/#/c/387712/)"},{"line_number":78,"context_line":"propose more granular states e.g \"pending\". When a reserve call is made the"},{"line_number":79,"context_line":"status and attach_status of the volume will be checked and assuming the"},{"line_number":80,"context_line":"attach could proceed the attach_status field will be updated to \"pending\"."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The code for the reserve volume call would look something like the following."},{"line_number":83,"context_line":"NOTE: This code has not been tested and may not be complete."}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_6b3ee7b9","line":80,"range":{"start_line":70,"start_character":0,"end_line":80,"end_character":74},"updated":"2017-02-19 19:40:59.000000000","message":"This sounds like the proposed change to cinder, am I wrong?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"+                                           expected)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"         if not result:"},{"line_number":106,"context_line":"             expected_status \u003d utils.build_or_str(expected[\u0027status\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"In addition to the changes to the reserve volume call the unreserve volume"},{"line_number":109,"context_line":"call would also need to be updated to account for this change."}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_ab48df5c","line":106,"updated":"2017-02-19 19:40:59.000000000","message":"I don\u0027t think a diff of cinder code belongs here (especially without proper formatting). I think describing the change in behavior from what we have today is plenty.","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee69ea324f926fe7caa1a64ca2a4dbf9913356fb","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"         if not result:"},{"line_number":106,"context_line":"             expected_status \u003d utils.build_or_str(expected[\u0027status\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"In addition to the changes to the reserve volume call the unreserve volume"},{"line_number":109,"context_line":"call would also need to be updated to account for this change."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_36ba7c24","line":107,"updated":"2017-02-20 19:49:43.000000000","message":"I don\u0027t get at all why we\u0027re discussing about a Cinder diff in a Nova blueprint. What do you need to modify in Nova to achieve your usecase?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"             expected_status \u003d utils.build_or_str(expected[\u0027status\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"In addition to the changes to the reserve volume call the unreserve volume"},{"line_number":109,"context_line":"call would also need to be updated to account for this change."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Additionally there are handful of locations in the code base today where the"},{"line_number":112,"context_line":"attach_status of the volume is checked. Those locations would have to be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_cb81934f","line":109,"updated":"2017-02-19 19:40:59.000000000","message":"This sounds like you\u0027re talking about cinder not nova. Am I wrong? If so, could you describe the changes necessary to nova please?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Additionally there are handful of locations in the code base today where the"},{"line_number":112,"context_line":"attach_status of the volume is checked. Those locations would have to be"},{"line_number":113,"context_line":"updated to account for the new status of \"pending\"."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Once the cinder side of things is completed, nova needs to be updated to"},{"line_number":116,"context_line":"utilization this new functionality. Depending on how the functionality is"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_abb61f3b","line":113,"updated":"2017-02-19 19:40:59.000000000","message":"Are you talking about nova or cinder here?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"attach_status of the volume is checked. Those locations would have to be"},{"line_number":113,"context_line":"updated to account for the new status of \"pending\"."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Once the cinder side of things is completed, nova needs to be updated to"},{"line_number":116,"context_line":"utilization this new functionality. Depending on how the functionality is"},{"line_number":117,"context_line":"implemented in cinder (micro versions etc) work may have to be done to allow"},{"line_number":118,"context_line":"nova to use the new reserve volume functionality. Additionally the logic on"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_0b7c8b71","line":115,"range":{"start_line":115,"start_character":45,"end_line":115,"end_character":69},"updated":"2017-02-19 19:40:59.000000000","message":"This seems like the only bit here relevant to \"proposed change[s to nova]\"","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"the nova-compute node that waits for a volume to become available before"},{"line_number":120,"context_line":"booting the VM will also need to be updated to wait when a request is made to"},{"line_number":121,"context_line":"boot from an existing volume (see the changes to nova/virt/block_device.py"},{"line_number":122,"context_line":"in https://review.openstack.org/#/c/391444/ for info)."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Alternatives"},{"line_number":125,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_ab8d3f7d","line":122,"updated":"2017-02-19 19:40:59.000000000","message":"Please describe any upgrade-related changes you\u0027ll need. For example, how will you handle the case where a newer api/conductor node reserves a volume (or allows a reserved volume in creating state), but then an older compute node chokes on it?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Nova boot with specific volume type specified at \"block_device_mapping_v2\""},{"line_number":128,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-volume-type-when-boot-instances"},{"line_number":129,"context_line":". However, this solution was denied by Nova core team not to overload Nova"},{"line_number":130,"context_line":"parameter interface"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Data model impact"},{"line_number":133,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_2b814f4b","line":130,"updated":"2017-02-19 19:40:59.000000000","message":"Ah, so this is already in the alternatives section, so you can remove it all from above I think.\n\nAlso, it\u0027d be great if you could just reference the URL in the footnotes below to clean this up a bit.","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"No database schema change is needed."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Nova DB shall reflect BFV job status with reserved volume waiting for"},{"line_number":138,"context_line":"volume to be available"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"REST API impact"},{"line_number":141,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_4b968395","line":138,"updated":"2017-02-19 19:40:59.000000000","message":"I\u0027m not sure this is a DB model impact, and if it is, I don\u0027t understand it. Can you elaborate here?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Other deployer impact"},{"line_number":167,"context_line":"---------------------"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"None"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Developer impact"},{"line_number":172,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_ebed7726","line":169,"updated":"2017-02-19 19:40:59.000000000","message":"What will happen if I have a partially-upgraded nova deployment where the control plane nodes are new enough to know about this change in interaction, but the compute nodes are not?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee69ea324f926fe7caa1a64ca2a4dbf9913356fb","unresolved":false,"context_lines":[{"line_number":179,"context_line":"Assignee(s)"},{"line_number":180,"context_line":"-----------"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"\u003ctbd\u003e"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Work Items"},{"line_number":185,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_33944ee1","line":182,"updated":"2017-02-20 19:49:43.000000000","message":"I\u0027m quite anxious if I can see a BP having a TBD for assignee. Can we at least make sure someone will implement that if we accept that blueprint ?","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ad1c17feda050c58137f182ce1ff3b59cf2c226f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"Work Items"},{"line_number":185,"context_line":"----------"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"See proposed solution"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Dependencies"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_6b9347a4","line":187,"updated":"2017-02-19 19:40:59.000000000","message":"The proposed solution is supposed to be a description of the change. Please put some miletone-like work items here.","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee69ea324f926fe7caa1a64ca2a4dbf9913356fb","unresolved":false,"context_lines":[{"line_number":184,"context_line":"Work Items"},{"line_number":185,"context_line":"----------"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"See proposed solution"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Dependencies"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_d3bbf270","line":187,"in_reply_to":"da36d5c6_6b9347a4","updated":"2017-02-20 19:49:43.000000000","message":"Right, please add bullet points describing the baby-steps you\u0027ll take in order to implement your solution.","commit_id":"83b5a64dee9e61ef6053c4881b52ce67ef4cbaa4"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"47fb4362aa5b51b671bafef4095f2f40e7c89805","unresolved":false,"context_lines":[{"line_number":44,"context_line":"users to more easily boot from volumes across different cinder backends. The"},{"line_number":45,"context_line":"only way today to boot from a volume that is not on the default cinder"},{"line_number":46,"context_line":"volume-type (which map to backends) is to first create the volume and then"},{"line_number":47,"context_line":"issue the boot request. This new workflow would stream like that process."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Proposed change"},{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da36d5c6_297d6ee7","line":47,"range":{"start_line":47,"start_character":48,"end_line":47,"end_character":59},"updated":"2017-02-22 18:36:08.000000000","message":"streamline","commit_id":"e95e984b9c0b41d6c3ff757f33c0e6585a8d345d"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"47fb4362aa5b51b671bafef4095f2f40e7c89805","unresolved":false,"context_lines":[{"line_number":52,"context_line":"There is already an proposed spec[7] to move to the new cinder API[1]."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Once that spec is implemented nova should be updated to allow reserving a"},{"line_number":55,"context_line":"volume that is in the \"creating\" or \"downlaoding\" states. Additionally the"},{"line_number":56,"context_line":"nova-compute logic should be updated to call the existing"},{"line_number":57,"context_line":"_await_block_device_map_created()[3] function for boot from volumes calls with"},{"line_number":58,"context_line":"and existing volume id."}],"source_content_type":"text/x-rst","patch_set":7,"id":"da36d5c6_698766d7","line":55,"range":{"start_line":55,"start_character":37,"end_line":55,"end_character":48},"updated":"2017-02-22 18:36:08.000000000","message":"downloading","commit_id":"e95e984b9c0b41d6c3ff757f33c0e6585a8d345d"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"47fb4362aa5b51b671bafef4095f2f40e7c89805","unresolved":false,"context_lines":[{"line_number":58,"context_line":"and existing volume id."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"As an example of what these changes might look like, a review has been"},{"line_number":61,"context_line":"posted[8] to show what the changes would like in the existing code base. This"},{"line_number":62,"context_line":"change would not work as it would require changes to how the existing reserve"},{"line_number":63,"context_line":"call in cinder."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Alternatives"},{"line_number":66,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da36d5c6_a9695e27","line":63,"range":{"start_line":61,"start_character":73,"end_line":63,"end_character":15},"updated":"2017-02-22 18:36:08.000000000","message":"...what?","commit_id":"e95e984b9c0b41d6c3ff757f33c0e6585a8d345d"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"47fb4362aa5b51b671bafef4095f2f40e7c89805","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Data model impact"},{"line_number":74,"context_line":"-----------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"No database schema change is needed for this change. Changes maybe needed as"},{"line_number":77,"context_line":"part of implementing spec to move to new cinder API"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"da36d5c6_09618a39","line":76,"range":{"start_line":76,"start_character":61,"end_line":76,"end_character":66},"updated":"2017-02-22 18:36:08.000000000","message":"may be","commit_id":"e95e984b9c0b41d6c3ff757f33c0e6585a8d345d"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"47fb4362aa5b51b671bafef4095f2f40e7c89805","unresolved":false,"context_lines":[{"line_number":96,"context_line":"---------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The nova api boot call will now support boot from volume while the volume is"},{"line_number":99,"context_line":"still in \"creating\" or \"downloading\" state."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Performance Impact"},{"line_number":102,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da36d5c6_a9507e5f","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":5},"updated":"2017-02-22 18:36:08.000000000","message":"This word can be removed","commit_id":"e95e984b9c0b41d6c3ff757f33c0e6585a8d345d"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"47fb4362aa5b51b671bafef4095f2f40e7c89805","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Dependencies"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Testing"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da36d5c6_09642a20","line":131,"updated":"2017-02-22 18:36:08.000000000","message":"You accidentally the whole section here.","commit_id":"e95e984b9c0b41d6c3ff757f33c0e6585a8d345d"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"4aff1b8c06e885fd068560dc75c60eb9d0196def","unresolved":false,"context_lines":[{"line_number":44,"context_line":"users to more easily boot from volumes across different cinder backends. The"},{"line_number":45,"context_line":"only way today to boot from a volume that is not on the default cinder"},{"line_number":46,"context_line":"volume-type (which map to backends) is to first create the volume and then"},{"line_number":47,"context_line":"issue the boot request. This new workflow would streamiline that process."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Proposed change"},{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da36d5c6_b9244fc5","line":47,"range":{"start_line":47,"start_character":48,"end_line":47,"end_character":59},"updated":"2017-02-22 19:04:15.000000000","message":"LOL","commit_id":"11cae05c499cdc071938316476a7e5b608939f20"}]}